*** bobh has quit IRC | 00:00 | |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-command' Sphinx directive https://review.openstack.org/450322 | 00:02 |
---|---|---|
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-commands' Sphinx directive https://review.openstack.org/453383 | 00:02 |
*** hoangcx has joined #openstack-sdks | 00:28 | |
*** yuanying has joined #openstack-sdks | 00:34 | |
*** hongbin has quit IRC | 00:43 | |
*** shu-mutou has joined #openstack-sdks | 00:55 | |
*** john-davidge has joined #openstack-sdks | 01:12 | |
reedip | o/ | 01:13 |
*** john-davidge has quit IRC | 01:17 | |
*** reedip has quit IRC | 01:20 | |
*** yanyanhu has joined #openstack-sdks | 01:27 | |
*** amotoki has joined #openstack-sdks | 01:31 | |
*** huanxuan has joined #openstack-sdks | 01:31 | |
*** fzdarsky_ has joined #openstack-sdks | 01:38 | |
*** annp has joined #openstack-sdks | 01:39 | |
*** fzdarsky|afk has quit IRC | 01:42 | |
openstackgerrit | yangweiwei proposed openstack/python-openstackclient master: Update endpoint-delete and endpoint-show method exception. https://review.openstack.org/453429 | 01:49 |
*** jamielennox is now known as jamielennox|away | 02:07 | |
*** bobh has joined #openstack-sdks | 02:14 | |
*** bobh has quit IRC | 02:20 | |
*** jamielennox|away is now known as jamielennox | 02:21 | |
openstackgerrit | yangweiwei proposed openstack/python-openstackclient master: Update endpoint-delete and endpoint-show method exception. https://review.openstack.org/453429 | 02:32 |
*** prg3 has quit IRC | 02:38 | |
*** prg3 has joined #openstack-sdks | 02:41 | |
*** reedip has joined #openstack-sdks | 02:44 | |
*** bobh has joined #openstack-sdks | 02:46 | |
*** gouthamr has quit IRC | 02:49 | |
openstackgerrit | Merged openstack/python-openstackclient master: Enable to specify which fixed-ip to add to a vm. https://review.openstack.org/452235 | 02:55 |
*** bobh has quit IRC | 03:10 | |
*** Kevin_Zheng has quit IRC | 03:13 | |
*** john-davidge has joined #openstack-sdks | 03:13 | |
*** john-davidge has quit IRC | 03:18 | |
*** prg3 has quit IRC | 03:56 | |
*** prg3 has joined #openstack-sdks | 03:59 | |
*** dave-mccowan has quit IRC | 04:05 | |
*** amotoki has quit IRC | 04:12 | |
*** prg3 has quit IRC | 04:13 | |
*** prg3 has joined #openstack-sdks | 04:14 | |
*** amotoki has joined #openstack-sdks | 04:30 | |
*** amotoki has quit IRC | 04:48 | |
*** chlong has quit IRC | 04:49 | |
*** amotoki has joined #openstack-sdks | 04:53 | |
*** john-davidge has joined #openstack-sdks | 05:14 | |
*** john-davidge has quit IRC | 05:18 | |
*** amotoki has quit IRC | 05:19 | |
*** prg3 has quit IRC | 05:22 | |
*** prg3 has joined #openstack-sdks | 05:24 | |
*** tonyb_ is now known as tonyb | 05:25 | |
*** amotoki has joined #openstack-sdks | 05:32 | |
*** ritz has quit IRC | 05:57 | |
*** rabel has joined #openstack-sdks | 07:03 | |
rabel | good morning | 07:03 |
*** ralonsoh has joined #openstack-sdks | 07:12 | |
rabel | someone can help me with a question about argparse? | 07:14 |
*** john-davidge has joined #openstack-sdks | 07:15 | |
rabel | in https://review.openstack.org/#/c/444924/4/openstackclient/compute/v2/server.py@612 cedric proposes that --nic, --network and --port should all add their values to the same variable. but is this even possible? or doable in a clean way? | 07:15 |
*** john-davidge has quit IRC | 07:19 | |
*** rabel has quit IRC | 07:20 | |
*** rabel has joined #openstack-sdks | 07:20 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311 | 07:23 |
*** Serlex has joined #openstack-sdks | 07:35 | |
reedip | rabel : hi | 07:37 |
rabel | hi reedop | 07:37 |
rabel | *reedip. sry ;) | 07:37 |
reedip | lol , no worries .. o and I are very near | 07:37 |
reedip | rabel : why are we using different options here? Cant we use MutliKeyValue Action ? | 07:38 |
reedip | I mean network, port and nic, all can be optional | 07:38 |
reedip | in the MultiKeyValue Action | 07:38 |
reedip | and it allows the user to specify them as a dict | 07:38 |
reedip | and remove the trouble which you guys are facing, right ? | 07:39 |
rabel | i'm not sure if i understand. we can use MultiKeyValueAction for --network, --port and --nic and then have them all in one? | 07:39 |
reedip | we can have --network net=Network_ID,port=Port_Id,nic=Nic_ID | 07:39 |
reedip | yes | 07:39 |
reedip | so that ways, we get a dictionary , with {"net":Network_ID, "port":Port_ID, "nic":Nic_ID} and handle the internals ourselves as we see fit | 07:40 |
reedip | though merging things in the same variable is POSSIBLE | 07:41 |
rabel | but that's actually what we don't want. | 07:41 |
reedip | but I agree that there are cleaner options | 07:41 |
reedip | rabel : okay | 07:41 |
rabel | what you propose is basically the current solution with --nic net-id=,port=,... | 07:41 |
rabel | the patch tries to simplify that | 07:41 |
rabel | it is possible, but not in a clean way? | 07:42 |
reedip | then the second option is to keep it in different metavar and then handle it yourself | 07:43 |
reedip | I mean keep nic, port and network in separate metavars | 07:43 |
reedip | but then is that what u need? | 07:43 |
reedip | I see I reviewed this patch earlier and gave the same response to you about MultiKeyValueAction :D | 07:44 |
rabel | yes :D | 07:44 |
rabel | to keep them in different metavars would not fix the issue, that --nic bla1 --network bla2 --nic bla3 would end up in the order bla1 bla3 bla2. | 07:45 |
rabel | but i have no idea how to deal with that issue | 07:45 |
reedip | rabel : okay, let me know what you really want :) | 07:46 |
reedip | you want direct mapping of the network to the nic, right? | 07:46 |
reedip | I mean as per the above command, you want bla1 to be associated with bla2, and bla3 is not associated with any network, right ? | 07:47 |
rabel | no, it's just about the order. | 07:47 |
rabel | so at the moment the nics provided with --nic are first, then come the --network nics and then the --port nics | 07:47 |
reedip | okay | 07:47 |
rabel | but i want them all in the order that they are provided | 07:48 |
rabel | so if you first specifiy a --network net1 and then a --nic net-id=net2, then i want the net1 nic to be first and net2 nic to be second | 07:48 |
reedip | any reason for wanting them in that same order ? ( I am trying to find the root requirement, and if it can be met some other way ) | 07:48 |
rabel | i think the end user will expect them to be in that order. that's the only reason | 07:49 |
reedip | not necessarily ... | 07:49 |
reedip | but is there any other reason with respect to the functionality you need? | 07:49 |
rabel | no | 07:50 |
reedip | so except the exact order with which the user enters the options, you dont have any other requirement, right ? | 07:50 |
reedip | then appending in the same variable is the best solution | 07:51 |
reedip | otherwise everything would be parsed with the argument you are sending | 07:51 |
rabel | do you know how to append them to the same variable? | 07:52 |
reedip | the method which you have done :D metavar =X and action = append for all variables | 07:52 |
reedip | --network, --nic and --port | 07:52 |
rabel | :D than i misunderstood you | 07:53 |
rabel | wait. this confuses me. the metavar= statement is only for the help message, right? | 07:54 |
reedip | nope | 07:55 |
reedip | the metavar actually tells argparse where the value would end up | 07:55 |
rabel | the variables are parsed_args.network, parsed_args.port and parsed_args.nic | 07:55 |
reedip | wait a minute | 07:56 |
rabel | and i thought the variable names are derived from the option name --network, --port, --nic | 07:56 |
reedip | yeah u r right.. it was destination what I was talking about | 07:57 |
reedip | so yeah, you can use dest as well | 07:57 |
reedip | that would add everything in the same variable , try that | 07:57 |
*** ssbarnea has joined #openstack-sdks | 07:58 | |
*** zacksh has quit IRC | 07:58 | |
*** jpich has joined #openstack-sdks | 07:58 | |
*** zacksh has joined #openstack-sdks | 08:00 | |
rabel | i will have a look at that. thank you! | 08:00 |
*** valery has joined #openstack-sdks | 08:05 | |
*** fzdarsky_ is now known as fzdarsky | 08:06 | |
*** valery is now known as valeryt | 08:06 | |
valeryt | is it possible to list the user project as in https://developer.openstack.org/api-ref/identity/v3/?expanded=list-projects-for-user-detail with the openstacksdk ? | 08:07 |
valeryt | I tried conn.identity.projects(user_id=user.id) but it doesn't work... | 08:08 |
*** john-davidge has joined #openstack-sdks | 08:15 | |
*** john-davidge has quit IRC | 08:20 | |
*** reedip has quit IRC | 08:41 | |
*** cdent has joined #openstack-sdks | 09:05 | |
*** ssbarnea has quit IRC | 09:11 | |
*** john-davidge has joined #openstack-sdks | 09:17 | |
*** aarefiev_afk is now known as aarefiev | 09:19 | |
*** reedip has joined #openstack-sdks | 09:34 | |
*** ssbarnea has joined #openstack-sdks | 09:47 | |
*** annp has quit IRC | 10:15 | |
*** yanyanhu has quit IRC | 10:24 | |
*** amotoki has quit IRC | 10:26 | |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-commands' Sphinx directive https://review.openstack.org/453383 | 10:27 |
*** jkilpatr has quit IRC | 10:37 | |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 10:38 |
rabel | reedip: do you want to have a look at my newest patch proposal? i know it's a bit of a workaround, but this is probably the best solution for now. | 10:40 |
reedip | rabel : Maybe a bit later, but will do :) | 10:40 |
reedip | thanks | 10:40 |
rabel | ok, thank you. :) | 10:41 |
*** hoangcx has quit IRC | 11:04 | |
*** dave-mccowan has joined #openstack-sdks | 11:07 | |
*** jkilpatr has joined #openstack-sdks | 11:12 | |
*** shu-mutou is now known as shu-mutou-AWAY | 11:12 | |
*** john-davidge has quit IRC | 11:13 | |
*** john-davidge has joined #openstack-sdks | 11:17 | |
frickler | how can I create a non-ha router with OSC? seems there is only the "--ha" option, but that is the default anyway | 11:18 |
frickler | neutron cli can do "--ha False" | 11:19 |
*** rabel_b1 has joined #openstack-sdks | 11:24 | |
*** rabel has quit IRC | 11:27 | |
*** amotoki has joined #openstack-sdks | 11:38 | |
briancurtin | valeryt: projects probably doesn’t currently take query parameters, but it could be added | 11:55 |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 11:58 |
rabel_b1 | frickler: ha should not be default on router creation | 12:01 |
rabel_b1 | just tried it here. "openstack router create my_router" creates a router without ha | 12:02 |
*** cdent has quit IRC | 12:03 | |
frickler | rabel_b1: which version are you using? I'm at 3.9.0 and for me that gets me a router with ha enabled. at least when I'm running as admin | 12:03 |
rabel_b1 | 3.9.1 | 12:04 |
briancurtin | valeryt: also it looks like what you’re trying wouldn’t be supported by the REST API anyway. user_id isn’t a query param it takes | 12:04 |
rabel_b1 | ah no, it's master from git | 12:04 |
rabel_b1 | wait | 12:04 |
rabel_b1 | frickler: the same with 3.9.0 | 12:05 |
rabel_b1 | got to go now, sorry | 12:07 |
*** rabel__b1 has joined #openstack-sdks | 12:10 | |
frickler | rabel_b1: but you did test with a cloud that has l3_ha=true in neutron? | 12:10 |
*** rabel_b1 has quit IRC | 12:13 | |
*** rabel_b1 has joined #openstack-sdks | 12:20 | |
*** rabel__b1 has quit IRC | 12:21 | |
*** rabel_b1 has quit IRC | 12:23 | |
*** rabel_b1 has joined #openstack-sdks | 12:23 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 12:23 |
valeryt | briancurtin: ok, but the keystone v3 user api have the REST /v3/users/{user_id}/projects for it | 12:24 |
valeryt | briancurtin: as described here: https://developer.openstack.org/api-ref/identity/v3/?expanded=list-projects-for-user-detail#list-projects-for-user | 12:24 |
briancurtin | ah | 12:24 |
*** rabel_b1 has quit IRC | 12:24 | |
*** rabel_b1 has joined #openstack-sdks | 12:25 | |
briancurtin | valeryt: can you enter this on https://bugs.launchpad.net/python-openstacksdk and we’ll take a look at adding it? | 12:25 |
valeryt | briancurtin: is it implemented, or it was just forget? | 12:25 |
valeryt | briancurtin: ok will do | 12:25 |
briancurtin | valeryt: it’s 100% not implemented how you tried to do it, but it could be supported. we don’t have a ton of keystone v3 coverage right now | 12:26 |
*** ZZelle has joined #openstack-sdks | 12:27 | |
*** ZZelle is now known as Guest85496 | 12:27 | |
Guest85496 | reedip, hi | 12:27 |
*** Guest85496 is now known as ZZelle_ | 12:27 | |
*** gouthamr has joined #openstack-sdks | 12:29 | |
valeryt | briancurtin: https://bugs.launchpad.net/python-openstacksdk/+bug/1680063 | 12:31 |
openstack | Launchpad bug 1680063 in OpenStack SDK "List projects for user" [Undecided,New] | 12:31 |
*** rabel_b1 has quit IRC | 12:32 | |
*** rabel_b1 has joined #openstack-sdks | 12:33 | |
frickler | rabel_b1: https://bugs.launchpad.net/python-openstackclient/+bug/1664255 has a similar issue, seems it can be extended to cover mine | 12:33 |
openstack | Launchpad bug 1664255 in python-openstackclient "Admin can't override default "distributed" flags" [Undecided,In progress] - Assigned to venkata anil (anil-venkata) | 12:33 |
*** rabel_b1 has quit IRC | 12:34 | |
*** rabel_b1 has joined #openstack-sdks | 12:35 | |
*** rabel_b1 has quit IRC | 12:36 | |
*** rabel_b1 has joined #openstack-sdks | 12:37 | |
*** amotoki has quit IRC | 12:41 | |
briancurtin | valeryt: cool, i commented on there about some options. i think what you were originally trying to do should be how it works. i’m busy right now myself but if no one else gets to it i’ll try to fix it relatively soon | 12:44 |
valeryt | briancurtin: thanks | 12:46 |
-openstackstatus- NOTICE: The Gerrit service on http://review.openstack.org is being restarted to address hung remote replication tasks, and should return to an operable state momentarily | 12:52 | |
*** gouthamr has quit IRC | 12:53 | |
*** gouthamr has joined #openstack-sdks | 12:53 | |
*** gouthamr has quit IRC | 12:54 | |
*** markvoelker has joined #openstack-sdks | 12:55 | |
*** amotoki has joined #openstack-sdks | 12:56 | |
*** gouthamr has joined #openstack-sdks | 12:59 | |
openstackgerrit | Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585 | 12:59 |
openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: WIP! Start using 'cliff.sphinxext' https://review.openstack.org/452861 | 13:13 |
*** chlong has joined #openstack-sdks | 13:17 | |
*** huanxuan has quit IRC | 13:27 | |
*** cleong has joined #openstack-sdks | 13:28 | |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 13:42 |
*** hongbin has joined #openstack-sdks | 14:06 | |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Add get_stack_* methods to documentation https://review.openstack.org/453646 | 14:06 |
*** bobh has joined #openstack-sdks | 14:13 | |
*** john-davidge has quit IRC | 14:23 | |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Clean up some errant doc warnings/errors https://review.openstack.org/453661 | 14:25 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "qos-policy" option to "port create" & "port set" https://review.openstack.org/419236 | 14:30 |
*** cdent has joined #openstack-sdks | 14:32 | |
reedip | ZZelle_ yes hello | 14:44 |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 14:48 |
reedip | rabel_b1 : hi | 14:49 |
rabel_b1 | reedip: hi. arg, i just made it worse... :D | 14:49 |
reedip | rabel_b1 : I saw ZZelle_ 's comments. I agree, lets discuss this in detail here or on the bug . dtroyer 's input would alsio be great here :) | 14:50 |
reedip | s/bug/patch/ | 14:51 |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 14:51 |
openstackgerrit | Merged openstack/python-openstacksdk master: Add get_stack_* methods to documentation https://review.openstack.org/453646 | 14:52 |
rabel_b1 | i would prefer not to discuss that in the change. here is fine, launchpad also. but on the change there is already enough, if it's only about the implementation. so i would like to keep the "what to implement?" question separate | 14:53 |
rabel_b1 | also in the launchpad bug we already started talking about that. | 14:55 |
ZZelle_ | rabel_b1, reedip, it's a mess to jump between launchpad and review.o.o ... let's discuss in one place | 14:55 |
reedip | agreed ZZelle_ | 14:55 |
reedip | but where ?? :) | 14:56 |
ZZelle_ | reedip, review.o.o :) | 14:56 |
ZZelle_ | reedip, the code won't go in launchpad :) | 14:57 |
reedip | rabel_b1 : is that ok with u ?? | 14:57 |
reedip | ZZelle_ hehe.. yeah | 14:57 |
rabel_b1 | ZZelle_, reedip: ok, review then. | 14:58 |
openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Add ability to pass in user_agent https://review.openstack.org/452550 | 14:58 |
rabel_b1 | but maybe we can also talk about it here first | 14:58 |
rabel_b1 | since we three are here right now and we can post the outcome as comment on the review? | 14:59 |
ankur-gupta-f4 | Which patchset are you discussing | 15:00 |
reedip | ankur-gupta-f4 : I was waiting for you to chime in :) | 15:00 |
reedip | https://review.openstack.org/444924 | 15:01 |
ankur-gupta-f4 | Oh yea. Fun | 15:01 |
reedip | :D | 15:01 |
reedip | I will be Back ... ( in a jiffy ) | 15:03 |
ZZelle_ | rabel_b1, reedip, dtroyer, the main point to agree is the format | 15:03 |
*** chlong has quit IRC | 15:03 | |
ZZelle_ | rabel_b1, reedip, dtroyer, imo, there is no reason to have 3 options --nic, --network, --port which supports complex values | 15:03 |
*** chlong has joined #openstack-sdks | 15:04 | |
ZZelle_ | rabel_b1, reedip, let's use --network --port for simplex cases: --network $network or --port $port | 15:04 |
ZZelle_ | rabel_b1, reedip, if you need a finer interface description then use --nic $key=$value,... | 15:05 |
rabel_b1 | ZZelle_, reedip, ankur-gupta-f4, dtroyer: sounds reasonable to me. i think i first had in mind that --nic could be deprecated in the future in favour of --network and --port. but since those are not going to implement the --nic auto and --nic none functionality either, we will probably stay with having three parameters. | 15:07 |
reedip | ZZelle_ ok, so you mean with --network and --port we do not need to specify nic | 15:08 |
rabel_b1 | so, since --nic will not be deprecated, i think you are right, ZZelle_. | 15:08 |
ZZelle_ | rabel_b1, what means --nic none or --nic auto? | 15:08 |
reedip | if that is so ZZelle_ , rabel_b1 , we need to be pretty thorough in the Help Message | 15:08 |
rabel_b1 | ZZelle_: afaiu --nic none means having a nic without a port connected to it and --nic auto means looking for a network that fits it needs. but i'm not sure here. | 15:09 |
ZZelle_ | reedip, yes, --network $network enables to specify a nic on a specific network, --port port a nic using a specific port and --nic is for other cases | 15:09 |
ZZelle_ | rabel_b1, ok | 15:09 |
ankur-gupta-f4 | If --nic will be deprecated then --network and --port need to fulfill all the options that --nic supports | 15:10 |
ankur-gupta-f4 | Imho | 15:10 |
rabel_b1 | ankur-gupta-f4: yes, but it very probably won't | 15:11 |
reedip | rabel_b1 : IIUC currently --nic should have default none if nothing is specified, you might need to handle that with --network and --port as well ( i.e. if no option is specified, treat --nic as none in the body ) | 15:11 |
reedip | auto option should be with --nic only , not with --network/--port | 15:11 |
reedip | ankur-gupta-f4 ; it would be difficult to replacte the auto behavior with --network/--port | 15:11 |
ankur-gupta-f4 | It shouldn't be that complicated if both nic and network options are handled in similar ways | 15:12 |
rabel_b1 | yes, dtroyer said something similar: none and auto should only be available for --nic, not for --network/--port | 15:13 |
reedip | ankur-gupta-f4 : it shouldnt be, but ideally it need not be required if we have --nic :) anyways, I think rabel_b1 has reached a satisfying conclusion , thanks to ZZelle_ :) | 15:14 |
ankur-gupta-f4 | Okay | 15:15 |
ankur-gupta-f4 | Will review it later. Still seems like it is would be confusing for end user. | 15:16 |
ankur-gupta-f4 | Lets see how it turnsout | 15:16 |
rabel_b1 | ankur-gupta-f4, reedip, ZZelle_: so, everyone seems to be fine with that solution. i will implement that in a new patch set. | 15:17 |
rabel_b1 | reedip: i am not quite sure yet how to do the help message the best way. | 15:17 |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 15:18 |
reedip | rabel_b1 : hmm ... for help message, you can simply mention like what we have mentioned here | 15:19 |
rabel_b1 | ZZelle_: i use network= instead of net-id= in that place to distinguish between --nic and --network later for the error message. see line 610+ | 15:19 |
rabel_b1 | ZZelle_: maybe it is better to change the error message to something more generic? | 15:20 |
ZZelle_ | rabel_b1, i will wait for the next PS as it's not really meaningful to review the current one more | 15:20 |
rabel_b1 | ok, i will first create a new patch set now, then we can discuss on that. :) | 15:21 |
sindhu | dtroyer: hi, https://review.openstack.org/#/c/383025/ is ready. Have added a detail commit message | 15:21 |
*** chlong has quit IRC | 15:21 | |
* dtroyer catching up | 15:21 | |
*** Serlex has quit IRC | 15:22 | |
*** john-davidge has joined #openstack-sdks | 15:23 | |
dtroyer | I don't mind having multiple ways to do things when they fit particular use cases, I think —port and —network do as long as they are simple options. in PS9 they are nearly aliases to —nic which I do not think adds much here. | 15:24 |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 15:28 |
reedip | dtroyer : missing your opinion on this : ^^ ( I am going to bug you a bit for this , hope you dont mind :) ) | 15:28 |
*** john-davidge has quit IRC | 15:29 | |
dtroyer | reedip: you mean 383025? | 15:31 |
reedip | dtroyer : YES :) | 15:31 |
dtroyer | what specifically? | 15:31 |
reedip | well, its ready .. | 15:31 |
dtroyer | not quite: https://review.openstack.org/#/c/383025/74/doc/source/command-objects/floating-ip.rst@156 | 15:32 |
reedip | ohh ... | 15:32 |
reedip | 3rd April , will look into it.. thanks | 15:32 |
dtroyer | also, what I was looking for with regard to the SDK is when that dependent review gets released. | 15:33 |
dtroyer | ie, it's merged, what is the next release expected to be? | 15:33 |
*** annegentle has joined #openstack-sdks | 15:33 | |
dtroyer | but that's just a bit of leg owrk to track down | 15:33 |
*** chlong has joined #openstack-sdks | 15:34 | |
reedip | dtroyer: thats what sindhu has mentioned in the commit message and in the file | 15:34 |
ankur-gupta-f4 | reedip make note in commit saying 0.9.15 SDK release needed | 15:35 |
dtroyer | it only points to a (now merged) review. it is more helpful to say "is expected to be relased in 0.9.xx", but that's just a bit of research to figure out if that has happened | 15:35 |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Enable warnings_as_errors in doc enforcer https://review.openstack.org/453676 | 15:35 |
dtroyer | you don't always know, that's fine | 15:36 |
reedip | dtroyer : ankur-gupta-f4 : ok... | 15:36 |
reedip | dtroyer: I think I and sindhu agree that that type of work could be tracked down by us... but yes mentioning a ToDO with the approporate SDK release is imp | 15:37 |
briancurtin | if you guys need an SDK release, we’re probably close to one. should probably wait on a couple of these load_balancer ones since they’re close to being done and they’re all related | 15:37 |
sindhu | reedip: for some reason I thought u addressed https://review.openstack.org/#/c/383025/74/doc/source/command-objects/floating-ip.rst@156, are u doing it or shall I do it | 15:38 |
reedip | sindhu : be my guest if you want to .. I was searching for the patch that merged on 3rd april :) | 15:39 |
dtroyer | thanks briancurtin. I think there are a couple of things in OSC that go with new/fixed SDK bits. We're cutting a release today or tomorrow for OSC and osc-lib so we're not really blocked on the SDK | 15:39 |
sindhu | reedip: oh ok | 15:40 |
dtroyer | sindhu, reedip: actually, it isn't just released, but that version of the SDK needs to be in the minimum in global requirements (requirements.txt) before we can assume it will be present | 15:40 |
reedip | dtroyer : yeah, thats what is bliocking us and is our requirement ( the SDK needs to be in ou requirements ) | 15:40 |
sindhu | dtroyer: Oh ok ... but we don't have to be blocked by that now right? | 15:41 |
ankur-gupta-f4 | briancurtin: for the load balancer ones we are concerned over the functional tests not being run. And we haven't yet been able to verify whether the calls/functionally are working correctly yet. I don't know if you want to wait upon those to release. Else, we can push those all though and deal with fixing them later | 15:41 |
briancurtin | ankur-gupta-f4: yeah, actually it does look like the functional tests might take a bit so we could be waiting a while. i’ll take a look in about an hour and see if we have anything else necessary to get a release out | 15:42 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: [WIP] Introduce Member for Octavia (loadbalancing) https://review.openstack.org/451488 | 15:44 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Member for Octavia (loadbalancing) https://review.openstack.org/451488 | 15:44 |
ankur-gupta-f4 | that seems best. I would prefer to hold off on merging the LBs till I/we can verify its working as expected locally before merging. | 15:44 |
dtroyer | sindhu: if an OSC review requires an SDK review to be present to work, yes, you must either handle both cases (with and without the SDK review present) or you must wait until the SDK release that includes that dependent review is in global-requirements. | 15:44 |
reedip | ankur-gupta-f4 : feel free to let me know if something needs to be done for octaviaclient | 15:45 |
ankur-gupta-f4 | yea review the initial. Figure out how to deal with that function that just "pass"es | 15:45 |
reedip | link ? | 15:45 |
sindhu | dtroyer: Okay, cool. got it ... thanks :) | 15:46 |
ankur-gupta-f4 | sindhu: reedip: once the SDK 9.15 is released you will need to follow up with a patchset like https://review.openstack.org/#/c/451482/1/global-requirements.txt to bump the global req. then we can merge it | 15:46 |
*** aarefiev is now known as aarefiev_afk | 15:46 | |
ankur-gupta-f4 | reedip: | 15:46 |
ankur-gupta-f4 | https://review.openstack.org/#/c/446223/ | 15:46 |
reedip | ankur-gupta-f4 : Openstack Proposal bot would do that itself, isnt it ? | 15:47 |
ankur-gupta-f4 | dtroyer: could use your quick input on how its being implemented as well before i get too down the rabbit hole | 15:47 |
reedip | ankur-gupta-f4 ( for Link ) : thanks :)( | 15:47 |
ankur-gupta-f4 | reedip: i don't think so, since I've had to do it a couple times already | 15:47 |
reedip | dtroyer : ^^ shouldnt the proposal bot pick it up ? | 15:48 |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-command' Sphinx directive https://review.openstack.org/450322 | 15:48 |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-commands' Sphinx directive https://review.openstack.org/453383 | 15:48 |
ankur-gupta-f4 | once merged to global-req, then proposal bot bumps it for all the individual projects as well... i believe | 15:49 |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 15:49 |
rabel_b1 | new proposal for you ::) | 15:50 |
reedip | ankur-gupta-f4 : yeah it should, and you dont need to do it yourself, in the Ideal scenario | 15:50 |
reedip | rabel_b1 : thanks :) | 15:50 |
rabel_b1 | reedip: it has some weeknesses that should be fixed when migrating to MultiKey...andSoOn. but i think for now it should be fine. | 15:53 |
reedip | rabel_b1 : ok , will put it in the review tab :) | 15:54 |
sindhu | ankur-gupta-f4: but we don't need SDK now for 383025 to work right? | 15:55 |
reedip | we dont ... I agree | 15:56 |
*** prg3 has quit IRC | 15:57 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add "qos-policy" option to "port create" & "port set" https://review.openstack.org/419236 | 15:57 |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 15:57 |
*** prg3 has joined #openstack-sdks | 15:58 | |
dtroyer | reedip, ankur-gupta-f1: the proposal bot creates reviews for projects based on what gets merged into the requirements repo. We have to propose the reviews to requirements. | 15:59 |
dtroyer | ankur-gupta-f1: what did you want input on? | 15:59 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Policy for Octavia (load balancing) https://review.openstack.org/451980 | 16:00 |
ankur-gupta-f4 | dtroyer: https://review.openstack.org/#/c/446223/ | 16:01 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Rule for Octavia (load balancing) https://review.openstack.org/452832 | 16:01 |
ankur-gupta-f4 | to see if its in the fashion that looks okay/works for you. | 16:01 |
ankur-gupta-f4 | https://review.openstack.org/#/c/447068/ is piece in OSC to initialize it. | 16:02 |
ankur-gupta-f4 | Bout to head out to airport so will be on/off for the next couple hours but will log back in on the plane. | 16:02 |
mordred | cdent: the example iin https://specs.openstack.org/openstack/api-wg/guidelines/microversion_specification.html#version-discovery says it was taken from nova, but it does not match what nova emits | 16:02 |
cdent | a) /me shakes tiny fist | 16:03 |
cdent | b) predates me | 16:03 |
mordred | k. I mena- I like what's in the spec better | 16:03 |
cdent | c) give me a few minutes and I'll look into it more closely and fix it | 16:03 |
openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | 16:03 |
mordred | but I'm wondering if we should align the spec to nova or try to get nova to add an additional key to theirs? | 16:03 |
cdent | it is quite likely that what's in the spec is desirable | 16:03 |
mordred | cdent: (the tl;dr is nova uses "version" to mean max_version) | 16:04 |
cdent | oh yeah, that's an intentional change | 16:04 |
mordred | ok. cool | 16:04 |
cdent | the surrounding tesxt is wrong | 16:04 |
mordred | I'll make the project-navigator stuff align to the api-wg thing | 16:04 |
*** jkilpatr_ has joined #openstack-sdks | 16:04 | |
cdent | yes please | 16:05 |
mordred | cdent: also - for major versions without microversions, min_version and max_version can be omitted or contain empty strings? or only be omitted? or do you care? | 16:06 |
*** jkilpatr has quit IRC | 16:06 | |
cdent | mordred: as far as I'm aware we haven't yet provided guidance for discovery in a non microversioned world, but my interpretation is that 'id' takes on the meaning of "the actual version you're getting, majorly" and min and max ought to be omitted | 16:08 |
reedip | sindhu : I updated the latest PS with the changes mentioned by dtroyer | 16:08 |
cdent | mordred: so, basically, keep id, put the version in there, leave min and max out | 16:09 |
sindhu | reedip: great! thanks :) | 16:09 |
* dtroyer hasn't read what cdent and mordred are talking about but has a thought anyway | 16:09 | |
dtroyer | is the presence/absense of min_version and max_version how we would detect microversion support? | 16:10 |
cdent | dtroyer: that seems to be the implication | 16:10 |
cdent | but I'm not sure if that's intentional or not | 16:10 |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 16:10 |
dtroyer | I'm generalizing the client-side negotiation code to put into ksa… | 16:10 |
* cdent nods | 16:10 | |
*** john-davidge has joined #openstack-sdks | 16:12 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 16:12 |
mordred | cdent: https://review.openstack.org/453361 | 16:13 |
mordred | dtroyer: that is my hunch, yes | 16:13 |
cdent | mordred: cool, will look properly soon | 16:14 |
mordred | dtroyer: and ooh - you adding version discovery and microversion-per-call suport? or just one or just theother? | 16:14 |
dtroyer | I've started with the negotiation, will be doing per-call since OSC needs it | 16:14 |
mordred | woot | 16:15 |
dtroyer | mordred: https://review.openstack.org/451618 | 16:15 |
mordred | I've been avoiding bothering with that so far | 16:15 |
dtroyer | it's all in OSC for development ATM | 16:15 |
*** john-davidge has quit IRC | 16:17 | |
mordred | dtroyer: ah - so cool - I _also_ want major version discovery and have a minor portion of that somewhere - but can add that in when you're happy with what you've got there for microversions | 16:19 |
mordred | (and I like what you've got there) | 16:19 |
*** jpich has quit IRC | 16:28 | |
*** amotoki has quit IRC | 16:29 | |
openstackgerrit | Chris Dent proposed openstack/api-wg master: Remove reference to nova on version discovery https://review.openstack.org/453744 | 16:29 |
*** valeryt has quit IRC | 16:33 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Policy for Octavia (load balancing) https://review.openstack.org/451980 | 16:35 |
mordred | dtroyer: also, I finally got around to writing a patch to horizon to add suport for downloading clouds.yaml files | 16:38 |
mordred | (fixing tests right now) | 16:38 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Policy for Octavia (load balancing) https://review.openstack.org/451980 | 16:38 |
dtroyer | mordred: \o/ | 16:39 |
*** Kuwagata has joined #openstack-sdks | 16:41 | |
mordred | dtroyer: remote: https://review.openstack.org/453669 Add support for downloading clouds.yaml files | 16:44 |
*** rabel_b1 has quit IRC | 16:45 | |
dtroyer | mordred: Nice. Maybe OSC should grow this too, and maybe both need to have a way to pull the update for the vendors file? | 16:50 |
mordred | dtroyer: yah - I have some patches I'll push up later today about vendors files too | 16:52 |
dtroyer | coolio | 16:52 |
mordred | dtroyer: and I've been thinking of making a few osc commands like "add cloud" that could injest a clouds.yaml from a vendor into an existing one | 16:52 |
dtroyer | yeah, thats a natural place to manage that file... | 16:53 |
mordred | ++ | 16:53 |
reedip | stevemar: there ? | 16:57 |
openstackgerrit | Merged openstack/python-openstackclient master: Enable to create legacy router https://review.openstack.org/449176 | 17:00 |
*** gus has quit IRC | 17:04 | |
*** jamielennox has quit IRC | 17:04 | |
*** gus has joined #openstack-sdks | 17:05 | |
*** jamielennox has joined #openstack-sdks | 17:07 | |
*** prg3 has quit IRC | 17:18 | |
*** prg3 has joined #openstack-sdks | 17:21 | |
*** ssbarnea has quit IRC | 17:39 | |
*** bobh has quit IRC | 17:42 | |
*** ssbarnea has joined #openstack-sdks | 17:46 | |
*** prg3 has quit IRC | 17:48 | |
*** prg3 has joined #openstack-sdks | 17:51 | |
*** jkilpatr_ has quit IRC | 17:54 | |
*** ralonsoh has quit IRC | 18:08 | |
*** jkilpatr_ has joined #openstack-sdks | 18:08 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Policy for Octavia (load balancing) https://review.openstack.org/451980 | 18:10 |
*** john-davidge has joined #openstack-sdks | 18:13 | |
*** john-davidge has quit IRC | 18:17 | |
*** bobh has joined #openstack-sdks | 18:42 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Develop api.versions for microversion discovery https://review.openstack.org/451618 | 18:46 |
*** bobh has quit IRC | 18:47 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Rule for Octavia (load balancing) https://review.openstack.org/452832 | 18:51 |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Clean up password prompt work-arounds https://review.openstack.org/453832 | 18:54 |
*** malloc83 has joined #openstack-sdks | 19:04 | |
malloc83 | hi there :-) just a tad curious why this isnt covered or just not documented.. i just started using the openstack proposed sdk.. and realised after authenticating and using authorize to get a token.. it pretty much doesnt mean much,, because after the user browses around on my gui, i have zero way of using the token to authenticate again on the sdk ;-) | 19:06 |
briancurtin | You can auth again with that token | 19:06 |
malloc83 | is this just not possible at this time? I noticed there is a plugin ? password? but nothing stating i could use plugin token if it even exists.. | 19:06 |
malloc83 | bradjones: yup i can,, but not using the sdk.. i cant find any intercace or something via the connection class that allows that. | 19:07 |
briancurtin | huh? | 19:07 |
malloc83 | so openstack has a connection class that i am using to connect in python, i use authorise() method to get a token... | 19:07 |
malloc83 | after that i can use the token again against the api... | 19:08 |
malloc83 | but how do i use it again with the connection handler? | 19:08 |
malloc83 | since the connection handler has been re-initilized, i cant afford to store a username and password in memory to auth again :) it must have some way for me to provide the token to continue the session | 19:08 |
briancurtin | as in, you want to create another connection instance elsewhere, perhaps in another instance of your application, using the token that was already received? | 19:09 |
malloc83 | bradjones: spot on.. this is for wsgi app.. | 19:09 |
malloc83 | briancurtin: i am sorry spot on yes.. :) getting used to this new mac keyboard. | 19:09 |
briancurtin | malloc83: that has definitely worked in the past. let me write something up and send it to you in a min | 19:10 |
*** bobh has joined #openstack-sdks | 19:10 | |
malloc83 | perhaps i missed this in the documentation, looked through all the examples too. | 19:10 |
openstackgerrit | Chris Dent proposed openstack/api-wg master: Remove reference to nova on version discovery https://review.openstack.org/453744 | 19:10 |
malloc83 | briancurtin: it works great, just no idea how to re-use the token with the connection handler.. other than that, everything seems to be as expected.. the documentation however has no mention of using token for auth, just v2,v3 keystone username and password, unscoped etc | 19:11 |
*** john-davidge has joined #openstack-sdks | 19:13 | |
briancurtin | malloc83: is this what you’re looking for https://gist.github.com/briancurtin/a10f4ed985d51a64f9c5de4c63b685fc | 19:15 |
malloc83 | having a look quick | 19:15 |
briancurtin | malloc83: yeah, we use keystoneauth for all of the auth handling, so we need to do a better job either explaining some of what can be done, or link out to keystoneauth’s docs on it | 19:16 |
malloc83 | i guessed it exactly like that, didnt work.. :) but that would be worth putting in the docs. | 19:16 |
malloc83 | ill have a look now why, perhaps i broke it :) | 19:16 |
briancurtin | malloc83: what version are you using? | 19:16 |
malloc83 | v2 auth api ? or what you asking for? the sdk? | 19:17 |
briancurtin | SDK version | 19:17 |
malloc83 | checking quick... | 19:17 |
malloc83 | openstacksdk==0.9.14 | 19:17 |
malloc83 | its the well defaulto version via pip install. | 19:18 |
*** john-davidge has quit IRC | 19:18 | |
briancurtin | ok cool, yeah from the SDK side of things that should all work (it maybe wouldn’t work on something way old, though i can’t remember how old). if you have more info on what failed and how i can maybe help figure it out. if it’s something with keystone itself though, that i don’t really know about | 19:19 |
malloc83 | briancurtin: no problem, just checking my understanding.. if i have a unscoped token on v2, i should be able to scope a new one using that against a project/tenant right? getting a 401 | 19:20 |
briancurtin | i know even less about keystone than what you just asked about | 19:20 |
malloc83 | briancurtin: haha cool :) understood. | 19:20 |
malloc83 | thanks for your help so far :) | 19:21 |
sindhu | stevemar: hi, https://review.openstack.org/#/c/383025/ is ready for your review :) | 19:21 |
openstackgerrit | Brian Haley proposed openstack/python-openstackclient master: Allow override of distributed router flag https://review.openstack.org/433442 | 19:22 |
*** Kuwagata has quit IRC | 19:26 | |
*** Kuwagata has joined #openstack-sdks | 19:26 | |
openstackgerrit | Merged openstack/api-wg master: Clarify the meaning of BODY https://review.openstack.org/451568 | 19:34 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Rule for Octavia (load balancing) https://review.openstack.org/452832 | 19:52 |
openstackgerrit | Chris Dent proposed openstack/api-wg master: Create a set of api interoperability guidelines https://review.openstack.org/421846 | 20:06 |
*** annegentle has quit IRC | 20:10 | |
*** jamielennox is now known as jamielennox|away | 20:12 | |
*** cdent has quit IRC | 20:41 | |
*** annegentle has joined #openstack-sdks | 20:41 | |
*** cdent has joined #openstack-sdks | 20:50 | |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstacksdk master: Introduce Pool for Octavia (load balancing) https://review.openstack.org/449264 | 20:51 |
*** cleong has quit IRC | 21:00 | |
*** john-davidge has joined #openstack-sdks | 21:14 | |
*** eliqiao has quit IRC | 21:18 | |
*** eliqiao has joined #openstack-sdks | 21:19 | |
*** john-davidge has quit IRC | 21:19 | |
*** gouthamr has quit IRC | 21:21 | |
*** cdent has quit IRC | 21:39 | |
*** jkilpatr_ has quit IRC | 21:42 | |
*** chlong has quit IRC | 22:02 | |
*** Kuwagata has quit IRC | 22:12 | |
*** jamielennox|away is now known as jamielennox | 22:13 | |
*** Kuwagata has joined #openstack-sdks | 22:16 | |
*** Kuwagata has quit IRC | 22:19 | |
*** Kuwagata has joined #openstack-sdks | 22:20 | |
*** jkilpatr_ has joined #openstack-sdks | 22:20 | |
*** annegentle has quit IRC | 22:36 | |
*** ssbarnea has quit IRC | 22:47 | |
*** ssbarnea has joined #openstack-sdks | 22:50 | |
*** ssbarnea has quit IRC | 22:51 | |
*** ssbarnea has joined #openstack-sdks | 23:05 | |
*** adriant has joined #openstack-sdks | 23:06 | |
*** bobh has quit IRC | 23:09 | |
*** ssbarnea has quit IRC | 23:11 | |
*** ssbarnea has joined #openstack-sdks | 23:15 | |
*** john-davidge has joined #openstack-sdks | 23:15 | |
*** Kuwagata has quit IRC | 23:19 | |
*** john-davidge has quit IRC | 23:19 | |
*** Kuwagata has joined #openstack-sdks | 23:20 | |
*** ssbarnea has quit IRC | 23:21 | |
*** Kuwagata has quit IRC | 23:24 | |
*** Kuwagata has joined #openstack-sdks | 23:25 | |
*** ssbarnea has joined #openstack-sdks | 23:27 | |
*** ssbarnea has quit IRC | 23:33 | |
*** jamielennox is now known as jamielennox|away | 23:42 | |
*** jamielennox|away is now known as jamielennox | 23:45 | |
*** ssbarnea has joined #openstack-sdks | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!