| reedip | stevemar, sindhu, ankur-gupta-f4 , RuiChen : need ur reviews on https://review.openstack.org/#/c/447938/2 | 00:00 |
|---|---|---|
| ankur-gupta-f4 | reedip: I agree with Sindhu adding that patchset within the FIP/port patch | 00:01 |
| reedip | I brought it out of the Floating IP associate/disassociate patch bcz the change here is not related with that patch | 00:02 |
| reedip | Its a separate piece of code which would also impact other locations where the code is used. | 00:02 |
| ankur-gupta-f4 | okay makes sense | 00:02 |
| reedip | If it would have been directly related to the floating ip associate/disassociate, I would have been the first one to put it there :) | 00:03 |
| sindhu | reedip: hey, I still feel it can be added in the fip patch, then there is no need of any dependency and even fip patch can get merged soon rather than wait for this one. anyway this method is currently not being used anywhere else in the code | 00:07 |
| reedip | sindhu : no not the new method, but there is a good amount of code which uses ip_cache but ignores it | 00:08 |
| reedip | sindhu : like show floating ip, delete floating ip etc | 00:08 |
| reedip | sindhu : the code you are working on is dependent on this change but this change also spawns other code changes | 00:08 |
| reedip | sindhu :thats why I avoided mixing the 2 | 00:09 |
| reedip | the old method has some issues, and if you do a find, you will see that there are code sections which use the old function, get the ip_Cache, but then do not use it | 00:09 |
| sindhu | reedip: are u planning to make changes to show and delete in the same patch? | 00:10 |
| reedip | sindhu : I think I can do it in this patch or in a follow up patch . I wanted to get this patch on road so that the floating IP patch can move forward. But if you think its corret then I can make the changes in Show and Delete as well | 00:11 |
| reedip | thats not a big issue, I guess. The point which dtroyer and stevemar had was that this function was not actually pretty good, but it can still be used where ip_cache is actually required | 00:12 |
| reedip | therefore I spun up a new function so that old code isnt hampered, the ip_Cache function still exists and we can just move on | 00:13 |
| sindhu | reedip: I feel, it makes sense to have a new patch only if ur changing the rest of the code base (show and delete). it its just defining the new method, then might as well do it in the fip patch so it gets merged together | 00:13 |
| reedip | sindhu : okay, got your point. Wait, lemme spin the new version | 00:14 |
| sindhu | reedip: gtg. will look at it again tom | 00:15 |
| reedip | Okay ... have a great day :) | 00:15 |
| *** bobh has joined #openstack-sdks | 00:16 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: TrivialFix : Introduce FindFloatingIP() without ip_Cache https://review.openstack.org/447938 | 00:17 |
| reedip | sindhu : jfyi , done :P | 00:17 |
| *** pepijn has joined #openstack-sdks | 00:21 | |
| *** reedip has quit IRC | 00:38 | |
| *** hoangcx has joined #openstack-sdks | 00:48 | |
| *** dave-mcc_ has joined #openstack-sdks | 00:52 | |
| *** dave-mccowan has quit IRC | 00:53 | |
| *** hongbin has quit IRC | 01:08 | |
| *** huanxuan has joined #openstack-sdks | 01:10 | |
| *** huanxuan has quit IRC | 01:17 | |
| *** huanxuan has joined #openstack-sdks | 01:21 | |
| openstackgerrit | Merged openstack/os-client-config master: Add support for bailing on invalid service versions https://review.openstack.org/439119 | 01:22 |
| *** reedip has joined #openstack-sdks | 01:24 | |
| *** yanyanhu has joined #openstack-sdks | 01:25 | |
| *** gouthamr has joined #openstack-sdks | 01:32 | |
| *** gildub has quit IRC | 01:36 | |
| *** markvoelker has quit IRC | 01:49 | |
| *** dave-mccowan has joined #openstack-sdks | 01:58 | |
| *** dave-mcc_ has quit IRC | 02:00 | |
| *** bobh has quit IRC | 02:13 | |
| *** huanxuan has quit IRC | 02:16 | |
| openstackgerrit | qtlu proposed openstack/osc-lib master: Using assertIsNone() instead of assertEqual(None) https://review.openstack.org/448346 | 02:28 |
| *** huanxuan has joined #openstack-sdks | 02:30 | |
| *** fzdarsky_ has joined #openstack-sdks | 02:31 | |
| *** RuiChen has joined #openstack-sdks | 02:33 | |
| *** fzdarsky has quit IRC | 02:35 | |
| *** bobh has joined #openstack-sdks | 02:35 | |
| *** gouthamr has quit IRC | 02:45 | |
| *** markvoelker has joined #openstack-sdks | 02:50 | |
| *** reedip has quit IRC | 02:52 | |
| *** markvoelker has quit IRC | 02:54 | |
| *** bobh has quit IRC | 03:00 | |
| *** yuanying has quit IRC | 03:05 | |
| *** pepijn has quit IRC | 03:34 | |
| *** markvoelker has joined #openstack-sdks | 03:51 | |
| *** dave-mccowan has quit IRC | 03:51 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: TrivialFix : Introduce FindFloatingIP() without ip_Cache https://review.openstack.org/447938 | 03:52 |
| *** markvoelker has quit IRC | 03:55 | |
| *** adriant has quit IRC | 04:12 | |
| *** yuanying has joined #openstack-sdks | 04:18 | |
| *** gouthamr has joined #openstack-sdks | 04:25 | |
| *** markvoelker has joined #openstack-sdks | 04:52 | |
| *** gildub has joined #openstack-sdks | 04:52 | |
| *** markvoelker has quit IRC | 04:56 | |
| *** gouthamr has quit IRC | 05:02 | |
| *** markvoelker has joined #openstack-sdks | 05:52 | |
| *** reedip has joined #openstack-sdks | 05:55 | |
| reedip | o/ | 05:55 |
| *** markvoelker has quit IRC | 05:57 | |
| *** reedip has quit IRC | 06:06 | |
| *** reedip has joined #openstack-sdks | 06:11 | |
| *** reedip has quit IRC | 06:12 | |
| *** reedip has joined #openstack-sdks | 06:13 | |
| *** gildub has quit IRC | 06:39 | |
| *** pepijn has joined #openstack-sdks | 06:41 | |
| *** markvoelker has joined #openstack-sdks | 06:53 | |
| *** markvoelker has quit IRC | 06:58 | |
| *** reedip has quit IRC | 07:16 | |
| *** reedip has joined #openstack-sdks | 07:16 | |
| *** e0ne has joined #openstack-sdks | 07:17 | |
| *** gildub has joined #openstack-sdks | 07:28 | |
| *** reedip__ has joined #openstack-sdks | 07:30 | |
| *** reedip has quit IRC | 07:31 | |
| *** reedip__ has quit IRC | 07:34 | |
| *** ssbarnea has joined #openstack-sdks | 07:34 | |
| *** reedip__ has joined #openstack-sdks | 07:34 | |
| *** reedip__ has quit IRC | 07:37 | |
| *** reedip__ has joined #openstack-sdks | 07:37 | |
| *** reedip__ has quit IRC | 07:43 | |
| *** reedip__ has joined #openstack-sdks | 07:43 | |
| *** reedip__ has quit IRC | 07:44 | |
| *** reedip__ has joined #openstack-sdks | 07:44 | |
| *** markvoelker has joined #openstack-sdks | 07:54 | |
| *** reedip__ has quit IRC | 07:54 | |
| *** reedip__ has joined #openstack-sdks | 07:56 | |
| *** markvoelker has quit IRC | 07:58 | |
| *** Serlex has joined #openstack-sdks | 08:04 | |
| *** pepijn has quit IRC | 08:07 | |
| *** lifeless_ has joined #openstack-sdks | 08:13 | |
| *** lifeless has quit IRC | 08:14 | |
| *** amotoki has joined #openstack-sdks | 08:20 | |
| *** reedip__ has quit IRC | 08:32 | |
| *** ralonsoh has joined #openstack-sdks | 08:45 | |
| *** gildub has quit IRC | 08:50 | |
| *** e0ne has quit IRC | 08:56 | |
| *** fnordahl has quit IRC | 09:14 | |
| *** yanyanhu has quit IRC | 09:19 | |
| *** reedip__ has joined #openstack-sdks | 09:20 | |
| *** yuanying has quit IRC | 09:31 | |
| *** reedip__ has quit IRC | 09:33 | |
| *** reedip__ has joined #openstack-sdks | 09:33 | |
| *** reedip__ has quit IRC | 09:37 | |
| *** reedip__ has joined #openstack-sdks | 09:37 | |
| *** cdent has joined #openstack-sdks | 09:43 | |
| *** reedip__ has quit IRC | 09:47 | |
| *** reedip__ has joined #openstack-sdks | 09:47 | |
| *** e0ne has joined #openstack-sdks | 09:54 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce FindFloatingIP() without ip_Cache https://review.openstack.org/447938 | 10:07 |
| *** yuanying has joined #openstack-sdks | 10:11 | |
| *** reedip__ has quit IRC | 10:19 | |
| *** jkilpatr has quit IRC | 10:37 | |
| *** yanyanhu has joined #openstack-sdks | 10:43 | |
| *** yanyanhu has quit IRC | 10:43 | |
| *** reedip__ has joined #openstack-sdks | 10:47 | |
| *** jkilpatr has joined #openstack-sdks | 10:53 | |
| *** hoangcx has quit IRC | 11:00 | |
| reedip__ | o/ | 12:32 |
| *** reedip__ has quit IRC | 12:36 | |
| *** reedip has joined #openstack-sdks | 12:37 | |
| *** markvoelker has joined #openstack-sdks | 12:51 | |
| *** markvoelker_ has joined #openstack-sdks | 12:54 | |
| *** fguillot has joined #openstack-sdks | 12:54 | |
| *** markvoelker has quit IRC | 12:54 | |
| *** cleong has joined #openstack-sdks | 12:57 | |
| *** gouthamr has joined #openstack-sdks | 13:21 | |
| cdent | elmiko, edleafe: some work in progress we might be able to halt sooner than later: https://bugs.launchpad.net/openstack-api-wg/+bug/1674192 | 13:24 |
| openstack | Launchpad bug 1674192 in openstack-api-wg "Mention max length limit of tags in api-wg" [Undecided,New] | 13:24 |
| * elmiko looks | 13:49 | |
| elmiko | cdent: added a comment agreeing with you and Sergey on the review | 13:52 |
| cdent | thans elmiko | 13:53 |
| *** huanxuan has quit IRC | 13:54 | |
| elmiko | i'm curious though, why 60 char limit. why not 255? | 13:58 |
| cdent | elmiko: 60 is what nova is using, so I think it was just a matter of codifying what's there | 14:00 |
| *** markvoelker_ is now known as markvoelker | 14:01 | |
| *** bobh has joined #openstack-sdks | 14:03 | |
| *** bobh has quit IRC | 14:04 | |
| *** chlong has joined #openstack-sdks | 14:04 | |
| *** bobh has joined #openstack-sdks | 14:04 | |
| *** shu-mutou-AWAY has quit IRC | 14:04 | |
| edleafe | cdent: elmiko: added my two cents | 14:07 |
| edleafe | I think it was my discussion with lbragstad that started this ball rolling | 14:07 |
| lbragstad | edleafe cdent elmiko interesting - we actually just talked about that in yesterday's keystone meeting http://eavesdrop.openstack.org/meetings/keystone/2017/keystone.2017-03-21-18.00.log.html#l-228 | 14:08 |
| * cdent looks | 14:09 | |
| lbragstad | the overall reaction of the group was to be strict about validation individual tags - http://eavesdrop.openstack.org/meetings/keystone/2017/keystone.2017-03-21-18.00.log.html#l-249 | 14:09 |
| lbragstad | but we'd greatly appreciate any guidance on that | 14:10 |
| *** corey_ has joined #openstack-sdks | 14:10 | |
| cdent | I think there's been plenty of guidance already on the form of the tags (in the docs that's being changed) but not on length | 14:11 |
| *** cleong has quit IRC | 14:11 | |
| cdent | as in "make sure they are URL safe" | 14:11 |
| lbragstad | fwiw - most of the discussion consisted of what policy we should use to enforce tags (which we kind of tabled and agreed to document for now), but the bits specific to "should we validate individual tags" is interesting | 14:12 |
| *** chlong has quit IRC | 14:12 | |
| lbragstad | the policy/rbac usecase we discussed in the meeting is related to other policy problems we have and isn't specific to tags | 14:12 |
| *** chlong has joined #openstack-sdks | 14:12 | |
| *** dave-mccowan has joined #openstack-sdks | 14:25 | |
| dstanek | i added my 2 cents to that | 14:35 |
| dstanek | yes, you are correct about the channel | 14:35 |
| dstanek | lbragstad: lol....and i magically switched channels! | 14:35 |
| reedip | stevemar, ankur-gupta-f4, sindhu, RuiChen : https://review.openstack.org/#/c/447938/ | 14:41 |
| *** ssbarnea has quit IRC | 14:48 | |
| *** ssbarnea has joined #openstack-sdks | 14:48 | |
| *** ssbarnea has quit IRC | 14:49 | |
| *** ssbarnea has joined #openstack-sdks | 14:54 | |
| *** chlong has quit IRC | 15:30 | |
| *** chlong has joined #openstack-sdks | 15:33 | |
| *** Serlex has quit IRC | 15:53 | |
| *** annegentle has joined #openstack-sdks | 15:59 | |
| openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient master: OSC Extension Show https://review.openstack.org/382023 | 16:39 |
| openstackgerrit | Merged openstack/osc-lib master: Using assertIsNone() instead of assertEqual(None) https://review.openstack.org/448346 | 16:43 |
| *** chlong has quit IRC | 16:45 | |
| openstackgerrit | Ed Leafe proposed openstack/api-wg master: Define pagination guidelines https://review.openstack.org/446716 | 16:48 |
| *** chlong has joined #openstack-sdks | 16:51 | |
| openstackgerrit | Ankur proposed openstack/python-openstackclient master: [WIP] Add support for Octavia Plugin https://review.openstack.org/447068 | 16:53 |
| openstackgerrit | Chris Dent proposed openstack/api-wg master: Create a new set of api stability guidelines https://review.openstack.org/421846 | 16:57 |
| cdent | edleafe, elmiko, anyone else: new version ^. I hope we're nearly done. | 16:57 |
| elmiko | cdent: ack, added to the queue | 16:58 |
| edleafe | cdent: yeah, saw that as I was commenting on the previous version :) | 17:09 |
| cdent | *more tiny fist shaking* | 17:09 |
| *** jkilpatr_ has joined #openstack-sdks | 17:13 | |
| *** jkilpatr has quit IRC | 17:15 | |
| *** e0ne has quit IRC | 17:16 | |
| *** annegentle has quit IRC | 17:22 | |
| *** cdent has quit IRC | 17:27 | |
| *** cdent has joined #openstack-sdks | 17:29 | |
| *** fzdarsky_ is now known as fzdarsky|afk | 17:35 | |
| *** fzdarsky|afk has quit IRC | 17:35 | |
| *** ralonsoh has quit IRC | 18:04 | |
| openstackgerrit | Ankur proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729 | 18:14 |
| cdent | sdague, elmiko: I agree with you guys that the alternatives secion is a bit sparse, but it is in there to effectively say "yeah, we heard you, but it's not good enough for the needs delineated here" | 18:15 |
| cdent | I'm happy to remove it though, if that's the consensus | 18:15 |
| * cdent is checking with mugsie over in #openstack-dev too. elmiko is here but not there. mugsie is there but not here | 18:16 | |
| elmiko | lol | 18:24 |
| elmiko | cdent: can we add a DONT DO THIS! to that section ;) | 18:24 |
| cdent | elmiko: is the last paragraph to circumspect in that regard? | 18:25 |
| cdent | too | 18:25 |
| *** jkilpatr_ has quit IRC | 18:34 | |
| *** jkilpatr has joined #openstack-sdks | 18:41 | |
| elmiko | cdent: i think so | 18:58 |
| elmiko | it leaves too much wiggle room | 18:58 |
| cdent | elmiko: have you read the followups from graham and chris? I'm probably gonna let it stew until tomorrow morning as I've lost steam in that direction | 18:59 |
| elmiko | cdent: i'll look again, last reply i saw was from Sean | 19:06 |
| elmiko | +1 to letting it stew | 19:07 |
| *** ssbarnea has quit IRC | 19:40 | |
| *** ssbarnea has joined #openstack-sdks | 19:41 | |
| *** ssbarnea has quit IRC | 19:41 | |
| *** annegentle has joined #openstack-sdks | 19:49 | |
| *** fguillot has quit IRC | 19:50 | |
| *** ssbarnea has joined #openstack-sdks | 20:04 | |
| *** e0ne has joined #openstack-sdks | 20:22 | |
| *** alex_xu has quit IRC | 20:43 | |
| *** alex_xu has joined #openstack-sdks | 20:46 | |
| *** adriant has joined #openstack-sdks | 20:50 | |
| *** corey_ has quit IRC | 20:51 | |
| *** chlong has quit IRC | 21:08 | |
| *** e0ne has quit IRC | 21:19 | |
| *** e0ne has joined #openstack-sdks | 21:20 | |
| *** e0ne has quit IRC | 21:22 | |
| *** gouthamr has quit IRC | 21:26 | |
| openstackgerrit | Ankur proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729 | 21:32 |
| *** sshank has quit IRC | 21:37 | |
| *** cdent has quit IRC | 21:54 | |
| *** sshank has joined #openstack-sdks | 21:57 | |
| *** jkilpatr has quit IRC | 22:25 | |
| *** gildub has joined #openstack-sdks | 22:50 | |
| reedip | ankur-gupta-f4 ; care to review https://review.openstack.org/#/c/447938/ ? | 22:58 |
| *** annegentle has quit IRC | 23:04 | |
| *** jkilpatr has joined #openstack-sdks | 23:05 | |
| ankur-gupta-f4 | reedip: address dtroyer comments onthere | 23:09 |
| reedip | ankur-gupta-f4 : just saw that... IMHO I think dtroyer has got a point but I am just considering if we would need ip_cache in the future ? | 23:12 |
| ankur-gupta-f4 | Im gonna wait to see what he says. But its simple enough and looks good | 23:13 |
| openstackgerrit | Merged openstack/cliff master: Use Sphinx 1.5 warning-is-error https://review.openstack.org/446630 | 23:15 |
| reedip | ankur-gupta-f4 : Well , dare say I am attempting to tease the dragon , but yes, I am making another workaround so that this function can still be used with the ip_cache ifrequired | 23:16 |
| reedip | I guess it was made for reason, and without knowing that reason, purging the ip_cache doesnt make sense to me | 23:17 |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce FindFloatingIP() without ip_Cache https://review.openstack.org/447938 | 23:19 |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Structure FindFloatingIP() to work without ip_cache https://review.openstack.org/447938 | 23:20 |
| *** bobh has quit IRC | 23:42 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!