Monday, 2017-03-20

« Sunday, 2017-03-19 Index Tuesday, 2017-03-21 »
*** reedip has joined #openstack-sdks00:09
*** dave-mccowan has joined #openstack-sdks00:13
*** bobh has joined #openstack-sdks00:24
*** bobh has quit IRC00:27
*** reedip has quit IRC00:38
*** jamielennox is now known as jamielennox|away00:38
*** hoangcx has joined #openstack-sdks00:41
openstackgerritMerged openstack/python-openstacksdk master: StackTemplate resource for orchestration  https://review.openstack.org/44684901:27
openstackgerritMerged openstack/python-openstacksdk master: Add StackEnvironment resource to orchestration v1  https://review.openstack.org/44688001:27
*** bobh has joined #openstack-sdks01:28
*** reedip has joined #openstack-sdks01:30
*** bobh has quit IRC01:32
*** huanxuan has joined #openstack-sdks01:33
openstackgerritAdrian Turjak proposed openstack/python-openstackclient master: Non-Admin can't list own projects  https://review.openstack.org/37605601:41
openstackgerritReedip proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC  https://review.openstack.org/38302501:42
reedipRuiChen : Fixed ur points ^^01:42
*** markvoelker has joined #openstack-sdks01:45
*** annp has quit IRC01:47
*** markvoelker has quit IRC01:49
openstackgerritZhenyu Zheng proposed openstack/api-wg master: Mention max length limit information for tags  https://review.openstack.org/44734402:32
*** fzdarsky_ has joined #openstack-sdks02:33
*** fzdarsky has quit IRC02:37
*** gildub has quit IRC03:17
*** annp has joined #openstack-sdks03:17
*** dave-mccowan has quit IRC03:20
*** jamielennox|away is now known as jamielennox03:22
*** Dinesh_Bhor has joined #openstack-sdks04:08
*** Matias has quit IRC04:15
*** Matias has joined #openstack-sdks04:31
*** frickler has joined #openstack-sdks04:50
*** bobh has joined #openstack-sdks05:31
*** bobh has quit IRC05:36
*** adriant has quit IRC05:53
*** hoangcx_ has joined #openstack-sdks06:29
openstackgerritHa Van Tu proposed openstack/python-openstackclient master: Add tags filter options to os network list command  https://review.openstack.org/38001206:31
*** bobh has joined #openstack-sdks06:32
*** hoangcx has quit IRC06:32
*** pepijn has joined #openstack-sdks06:33
*** bobh has quit IRC06:36
*** 7IZAATF07 has joined #openstack-sdks06:42
*** 7GHAALN3P has joined #openstack-sdks06:42
*** 7GHAALN3P has quit IRC06:42
reedipRuiChen : we are getting error when changing the @mock.patch06:45
openstackgerritReedip proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC  https://review.openstack.org/38302506:48
*** hoangcx has joined #openstack-sdks06:56
*** hoangcx has quit IRC07:20
*** hoangcx_ has quit IRC07:21
*** hoangcx has joined #openstack-sdks07:21
*** pepijn has quit IRC07:45
*** ralonsoh has joined #openstack-sdks07:51
RuiChenreedip: yeah, looks like naming conflict, the import floating_ip is same with the class attribute  floating_ip = network_fakes.FakeFloatingIP.create_one_floating_ip , in line 61607:56
RuiChenreedip: let me download the patch code to dive deep in code07:56
reedip:)07:57
openstackgerritqtlu proposed openstack/python-openstackclient master: Add Progressbar for uploadimg, downloadimg image with v1 and v2 client  https://review.openstack.org/44740608:10
*** Serlex has joined #openstack-sdks08:15
*** ssbarnea has joined #openstack-sdks08:25
*** bobh has joined #openstack-sdks08:33
*** bobh has quit IRC08:38
*** jpich has joined #openstack-sdks08:52
openstackgerritRui Chen proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC  https://review.openstack.org/38302508:57
RuiChenHi reedip, I commit a new patch ^^ and fix the mock naming conflict, that test cases pass in my local env, you can check the diff detail in patch08:59
reedipWelcome to the patch RuiCHen :D08:59
reedipChecked it08:59
reedipDidnt find anything MUCH different from the one I tried earlier08:59
reedipLets see what Jenkins states :)08:59
RuiChenthat is the detail https://review.openstack.org/#/c/383025/67..68/openstackclient/tests/unit/network/v2/test_floating_ip.py09:01
RuiChen@mock.patch => @mock.patch.object and rename something09:01
RuiChenjust that :-)09:02
*** openstackgerrit has quit IRC09:02
reedipyeah , the patch.object was missing :)09:06
*** reedip has quit IRC09:14
*** e0ne has joined #openstack-sdks09:18
*** e0ne has quit IRC09:24
*** e0ne has joined #openstack-sdks09:24
*** reedip has joined #openstack-sdks09:53
*** bobh has joined #openstack-sdks10:35
*** bobh has quit IRC10:39
*** jkilpatr has quit IRC10:41
*** hoangcx has quit IRC10:51
*** jkilpatr has joined #openstack-sdks10:58
*** cdent has joined #openstack-sdks11:03
*** 7IZAATF07 has quit IRC11:07
*** yanyanhu_ has joined #openstack-sdks11:09
*** yanyanhu_ has quit IRC11:09
*** aarefiev_afk is now known as aarefiev11:15
*** bobh has joined #openstack-sdks11:35
*** bobh has quit IRC11:40
*** dave-mccowan has joined #openstack-sdks12:08
*** bobh has joined #openstack-sdks12:15
*** cdent has quit IRC12:16
*** bobh has quit IRC12:20
*** ralonsoh_ has joined #openstack-sdks12:34
*** cleong has joined #openstack-sdks12:51
*** yuvalb has quit IRC12:53
*** yuvalb has joined #openstack-sdks12:54
*** markvoelker has joined #openstack-sdks13:01
*** cdent has joined #openstack-sdks13:03
*** gouthamr has joined #openstack-sdks13:07
*** cdent has quit IRC13:20
*** cdent has joined #openstack-sdks13:35
*** cdent has quit IRC13:35
*** ralonsoh_ has quit IRC13:40
*** edleafe- is now known as edleafe13:45
*** hongbin has joined #openstack-sdks13:47
*** exploreshaifali has joined #openstack-sdks13:57
*** pepijn has joined #openstack-sdks14:04
*** huanxuan has quit IRC14:06
*** cdent has joined #openstack-sdks14:22
*** annegentle has joined #openstack-sdks14:22
*** bobh has joined #openstack-sdks14:59
*** annegentle has quit IRC15:00
*** annegentle has joined #openstack-sdks15:02
*** exploreshaifali has quit IRC15:08
*** jamielennox has quit IRC15:17
*** exploreshaifali has joined #openstack-sdks15:23
*** jkilpatr has quit IRC15:27
*** jkilpatr has joined #openstack-sdks15:28
*** chlong has joined #openstack-sdks15:33
*** openstackgerrit has joined #openstack-sdks15:40
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Make MAC address of port updatable  https://review.openstack.org/44254315:40
sshankCan I please get reviews on patch: https://review.openstack.org/#/c/387611/ . I think its ready. Please look into it and comment.15:42
sshankreedip, ^15:42
*** annegentle has quit IRC15:58
*** annegentle has joined #openstack-sdks16:00
*** jkilpatr has quit IRC16:16
*** jamielennox has joined #openstack-sdks16:19
lbragstado/ hey folks - curious if anyone would be able to provide some clarity on a question i have about the guidelines for tags http://specs.openstack.org/openstack/api-wg/guidelines/tags.html16:19
edleafelbragstad: We can try16:20
lbragstadedleafe the modifying tags section eludes to some set limit of tags that can be modified in a single request - http://specs.openstack.org/openstack/api-wg/guidelines/tags.html#modifying-the-tag-list16:20
lbragstadedleafe my first question is whether or not the API WG provides a baseline as to what that limit should be?16:21
*** jamielennox is now known as jamielennox|away16:21
lbragstadedleafe my second question is if the API WG has any recommendations on the total number of tags a thing can have16:21
edleafelbragstad: it's not a design limit of tags; it's the limit of the web server handling the request16:21
edleafeThe number of tags isn't as important as the total size of the tags16:22
lbragstadedleafe ah - sure, ok that makes sense16:22
lbragstadedleafe so that suggestion is to protect against that case16:22
edleafeIOW, if you have 100 10-byte tags, it will be better than 1 50GB tag :)16:22
lbragstadright16:23
openstackgerritNakul Dahiwade proposed openstack/python-openstackclient master: OSC Network Flavor Profile  https://review.openstack.org/39678316:24
lbragstadedleafe we have a spec proposed to add tags to projects - https://review.openstack.org/#/c/43178516:24
edleafeThe main point of that suggestion is the response code to return16:24
lbragstadso is the limit referring to the size of the tag, or the total number of tags?16:25
lbragstadbecause the example provided makes me think its the total size of the tags16:26
lbragstadnot limiting the actual number of tags16:26
edleafeMy understanding is that while the total size of all the tags is the limiting factory, an API developer might want to limit the number of tags allowed for more practical purposes16:27
lbragstadok16:28
edleafeIOW, it would be nearly meaningless to assign 10K tags to a server16:28
lbragstadright16:28
lbragstadthat kind of what i was getting at with my second question16:28
lbragstaddoes it make sense to limit the total number of tags a thing can have (not just limiting the request)16:29
edleafelbragstad: my opinion is that it is dependent on the project, and the resource being tagged16:29
edleafeI don't know of any API-WG stance on that16:30
*** jkilpatr has joined #openstack-sdks16:30
lbragstadedleafe ok - so for keystone, we could choose to limit the total number of tags a project can have, and we can choose to limi the total number of tags that can be modified in a single request16:30
edleafelbragstad: well, those should be the same16:30
lbragstadI would think there would be a pretty good correlation between two things16:31
lbragstadedleafe ++16:31
edleafesince a PUT has to contain the complete list16:31
edleafe(not a PATCH)16:31
lbragstadso my second question doesn't make sense based on the answer from the first :)16:31
edleafeheh16:31
lbragstadbut what about the case where single tags are added?16:31
lbragstadif i limit the total number of tags in a single request to 50, that shouldn't stop me from using PUT /servers/1234567890/tags/<random_tag> 50+ times16:32
edleafelbragstad: it wouldn't, but you have to keep in mind that GET /servers/1234567890/tags is a thing that will return the full list16:33
edleafeSo yeah, you can run individual PUTs as many times as you like, but you might have too big a body for the GET16:34
lbragstadedleafe at which point you'd have to start pruning things based upon that list, right?16:35
lbragstadbecause using PUT to modify the entire list would rewrite the whole thing16:35
edleafelbragstad: yes, PUT with a body replaces the current tags with the body contents16:36
lbragstadedleafe so what i'm hearing is that it should be possible to exceed the total number of tags limited in a PUT request with individual tag management16:37
edleafelbragstad: unless you do server-side checking, yes16:38
lbragstadedleafe is there any reason to *not* do server-side checking?16:38
lbragstad(outside of extra validation)16:38
edleafethat would require that the server do a GET to determine the number of current tags with each PUT request16:39
lbragstadyeah - it would have to inspect what's already tagged16:39
lbragstadedleafe thanks for answering my questions - i think i have enough to go do another review of the spec16:44
*** shaifali has joined #openstack-sdks16:45
*** exploreshaifali has quit IRC16:48
edleafelbragstad: yw16:51
*** hoangcx has joined #openstack-sdks16:52
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Use Sphinx 1.5 warning-is-error  https://review.openstack.org/44662916:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: docs: Don't include ChangeLog  https://review.openstack.org/44758816:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Remove local fork of apidoc  https://review.openstack.org/44758916:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Fix option-describe typos  https://review.openstack.org/44759016:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Correct option, envvar markup  https://review.openstack.org/44759116:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Don't duplicate commands  https://review.openstack.org/44759216:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Option arguments are not options  https://review.openstack.org/44759316:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Correct docstrings  https://review.openstack.org/44759416:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Correct invalid indentation  https://review.openstack.org/44759516:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Don't use murano plugin  https://review.openstack.org/44759616:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Correct issues with network-topology spec  https://review.openstack.org/44759716:54
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Include API modules in docs  https://review.openstack.org/44759816:54
*** Serlex has quit IRC16:55
dtroyerso Stephen, ^^^^ could have been done as a couple of reviews that batch together similar things16:56
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Remove local fork of apidoc  https://review.openstack.org/44758917:08
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Correct option, envvar markup  https://review.openstack.org/44759117:08
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: doc: Fix option-describe typos  https://review.openstack.org/44759017:08
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Don't duplicate commands  https://review.openstack.org/44759217:08
*** annegentle has quit IRC17:12
*** shaifali has quit IRC17:34
*** annegentle has joined #openstack-sdks17:36
*** chlong has quit IRC17:42
*** annegentle has quit IRC17:45
*** annegentle has joined #openstack-sdks17:48
*** shaifali has joined #openstack-sdks17:49
*** hoangcx has quit IRC17:51
*** jpich has quit IRC17:54
openstackgerritMerged openstack/python-openstackclient master: Adds missing flavor information in the server list long command  https://review.openstack.org/44493417:57
openstackgerritMerged openstack/python-openstackclient master: Add extra filtering options to qos policy list  https://review.openstack.org/40113117:58
openstackgerritMerged openstack/python-openstackclient master: Non-Admin can't list own projects  https://review.openstack.org/37605617:58
*** hoangcx has joined #openstack-sdks18:02
*** ralonsoh has quit IRC18:02
*** cdent has quit IRC18:05
*** aarefiev is now known as aarefiev_pto18:06
*** cdent has joined #openstack-sdks18:07
*** e0ne has quit IRC18:11
*** annegentle has quit IRC18:17
*** shaifali has quit IRC18:19
*** jamielennox|away is now known as jamielennox18:24
*** shaifali has joined #openstack-sdks18:27
*** ssbarnea has quit IRC18:38
*** gus has quit IRC18:41
*** shaifali has quit IRC18:44
*** gus has joined #openstack-sdks18:45
*** shaifali has joined #openstack-sdks18:46
stevemardtroyer: i have questions on https://review.openstack.org/#/c/387611/55 -- you +2'ed, can you answer them in the authors absence ?18:51
ankur-gupta-f4stevemar: it is laying down a common command in case there are more agent commands down the line which add the network to an agent.18:53
ankur-gupta-f4hence the --dhcp flag18:53
stevemarankur-gupta-f4: oh okay18:54
ankur-gupta-f4Your comments about the help text needs to be addressed though18:54
ankur-gupta-f4I thought it had already been addressed18:54
stevemarankur-gupta-f4: fix them up and i'll approve it ;)18:54
ankur-gupta-f4k gimme a sec18:55
openstackgerritAnkur proposed openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC  https://review.openstack.org/38761119:02
ankur-gupta-f4stevemar: done. Double check my work though. It was hurried sitting at airport gate19:03
sshankstevemar, The dhcp flag check was added to support any future agents needs to be extended.19:05
*** Matias has quit IRC19:15
*** Matias has joined #openstack-sdks19:27
stevemarsshank: gotcha19:45
*** e0ne has joined #openstack-sdks19:58
reedipsshank : checking20:08
reedipo/20:08
reedipstevemar , ankur-gupta-f4, sshank : there is an issue with https://review.openstack.org/#/c/387611/5520:11
reedipnot a big one though\20:12
sshankreedip, Whats it about?20:12
reedipsshank : change the commit message plz20:12
*** pepijn has quit IRC20:13
reedipsshank : if you are moving the DHCP commands to OSC, please add the DHCP flag to network agent add/list etc20:13
reedipas mentioned in the https://review.openstack.org/#/c/387611/56/doc/source/command-objects/network-agent.rst20:13
ankur-gupta-f4I think it is a non-issue20:13
ankur-gupta-f4Since it is introducing a general command for adding agents to network20:14
ankur-gupta-f4Not just dhcp. Even though currently dhcp is the only agent type supported20:14
*** dave-mcc_ has joined #openstack-sdks20:15
reedipankur-gupta-f4 : its not a big issue , but it does cause a bit of a misunderstanding in the inital review ... :)20:15
ankur-gupta-f4Up to cores. Im out till tmw. Adios amigos.20:15
reediphehe ... asta la vista  !20:16
*** waj334_ has joined #openstack-sdks20:16
*** cdent_ has joined #openstack-sdks20:16
*** purplerbot_ has joined #openstack-sdks20:17
*** purplerbot_ is now known as purplerbot__20:17
*** purplerbot__ is now known as purplerbot___20:17
*** purplerbot___ is now known as purplerbot____20:17
*** purplerbot____ is now known as purplerbot_____20:17
*** purplerbot_____ is now known as purplerbot______20:17
reedipsshank: couple of nits are there20:18
reedipposting them up in another 5 min20:19
*** rosmaita_ has joined #openstack-sdks20:20
*** DuncanT_ has joined #openstack-sdks20:22
reedipdone20:22
*** e0ne has quit IRC20:22
*** jgriffith_ has joined #openstack-sdks20:27
*** purplerbot______ has quit IRC20:28
*** cdent has quit IRC20:29
*** jkilpatr has quit IRC20:29
*** dave-mccowan has quit IRC20:29
*** sdague has quit IRC20:29
*** DuncanT has quit IRC20:29
*** purplerbot has quit IRC20:29
*** waj334 has quit IRC20:29
*** jgriffith has quit IRC20:29
*** rosmaita has quit IRC20:29
*** cdent_ is now known as cdent20:29
*** waj334_ is now known as waj33420:29
*** purplerbot has joined #openstack-sdks20:29
*** jgriffith_ is now known as jgriffith20:30
*** shaifali has quit IRC20:32
*** jkilpatr has joined #openstack-sdks20:32
*** DuncanT_ is now known as DuncanT20:32
*** dave-mcc_ is now known as dave-mccowan20:33
sindhustevemar: hi, ping?20:36
*** sdague has joined #openstack-sdks20:36
*** sdague has quit IRC20:37
stevemarsindhu: pong, whaddup20:40
sindhustevemar: hi, needed your review on https://review.openstack.org/#/c/379813/20:41
reedipstevemar, sindhu : follow up ( related patch ) : https://review.openstack.org/#/c/376311/   :D20:42
sindhureedip: yup, looking :)20:44
*** adriant has joined #openstack-sdks20:44
reedipstevemar : care to bless https://review.openstack.org/#/c/383025/ as well, if you are there  :)20:44
*** sdague has joined #openstack-sdks20:45
stevemarreedip sindhu why can't you guys ever give me easy patches :P20:45
reedipstevemar : Has anyone left any easy patch :P20:46
reedipbesides , its fun to irritate you with the bigger ones :P20:46
sindhustevemar: haha :)20:46
*** ZZelle has joined #openstack-sdks20:46
ZZelledtroyer, hi20:47
stevemarhehe, give me a day or so to review, we're racing to a deadline internally20:47
stevemartomorrow :(20:47
reedipok stevemar20:47
sindhustevemar: sure, np :)20:48
dtroyerZZelle: hey20:48
reedipsindhu : do you also need a day or can I ping you repeatedly till you doint review ??? :P20:48
sindhureedip: hehe ... I will do it today :) soon after the networking meeting20:49
ZZelledtroyer, could you relook at https://review.openstack.org/371786 ?20:49
*** sdague has quit IRC20:51
*** cleong has quit IRC20:51
*** sdague__ has joined #openstack-sdks20:52
openstackgerritMerged openstack/python-openstackclient master: Make MAC address of port updatable  https://review.openstack.org/44254320:53
reedipmeeting ??? :O20:53
reedipyou mean the weekly neutron one ?20:53
sindhureedip: yup20:54
reedipthats 12 hours from now ..20:54
reedipatleast !20:54
reedip:)20:54
reedipbut ok :D20:54
sindhureedip: it's today right in 6min20:54
reedipWhat ???????/20:54
sindhulast week it was on tuesday20:54
reedipoh ... yeah20:54
sindhuthis week Monday20:54
reedipthanks for the heads up :D20:55
sindhu:)20:55
reedipmy calnedar is screwed20:55
reedipsindhu : hey do you know the VPNaaS patch for OSC ?21:04
reedipgot it sindhu21:05
sindhureedip: ok21:09
dtroyerZZelle: about the option name, we have been consistent with how we use —fixed-ip, with the kv pairs as you mentioned, but I'd rather not create a new option name for this.  We've used —fixed-ip-address in the floating IP commands and it takes only an IP address as an argument.  How do you feel about that?21:09
openstackgerritAdrian Otto proposed openstack/service-types-authority master: WIP: Add coe-cluster service type  https://review.openstack.org/44769421:11
ZZelledtroyer, honestly i have no opinion if fixed-ip-address has been somewhere else let's go for it21:12
dtroyercool…leaving comments21:14
dtroyerheh, on huanxuan's other comment about the relnote name, I do find the 'bug-####' naming helpful as I am going through the release notes cleaning things up.  no need to change, just thought I'd point out where I do find them meaningful.21:16
openstackgerritCedric Brandily proposed openstack/python-openstackclient master: Enable to specify which vm fixed-ip to publish  https://review.openstack.org/37178621:22
*** amotoki has joined #openstack-sdks21:23
ZZelledtroyer, ^^21:25
openstackgerritMerged openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC  https://review.openstack.org/38761121:31
dtroyerZZelle: could you make the help string match the doc?    "Fixed IP address to associate with this floating IP address"21:32
openstackgerritCedric Brandily proposed openstack/python-openstackclient master: Enable to specify which vm fixed-ip to publish  https://review.openstack.org/37178621:34
ZZelledtroyer, ^^21:34
dtroyercool, thanks21:34
*** gouthamr has quit IRC21:50
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Simplify logic around option lists in port set  https://review.openstack.org/43904821:56
*** jkilpatr has quit IRC22:03
*** bobh has quit IRC22:10
*** dave-mccowan has quit IRC22:12
*** amotoki has quit IRC22:41
*** jkilpatr has joined #openstack-sdks22:41
openstackgerritHongbin Lu proposed openstack/service-types-authority master: Add container service type for Zun  https://review.openstack.org/44772523:20
*** gildub has joined #openstack-sdks23:24
*** hoangcx has quit IRC23:25
*** jamielennox is now known as jamielennox|away23:36
*** cdent has quit IRC23:37
*** jamielennox|away is now known as jamielennox23:40
*** dave-mccowan has joined #openstack-sdks23:44
« Sunday, 2017-03-19 Index Tuesday, 2017-03-21 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!