| thingee | jamielennox: sounds dangerous | 00:01 |
|---|---|---|
| jamielennox | thingee: yea, i can see that, and i can always put it into a shell loop - just in the current case it would have made my operation 2 commands instead of 10 | 00:03 |
| jamielennox | anyway, it's not a something i'm super passionate about, just was dropping it here so its mentally a thing that has been requested at some point | 00:04 |
| *** salv-orlando has quit IRC | 00:33 | |
| *** jamielennox is now known as jamielennox|away | 00:36 | |
| *** jamielennox|away is now known as jamielennox | 00:44 | |
| *** hongbin has quit IRC | 00:46 | |
| dtroyer | jamielennox: I've thought about that, and like thingee sez, caution has been the order… I think it might be interesting to have a setting somewhere to unlock things like that (especially on a delete) for people who are "this high" and can drive a cloud responsibly | 01:05 |
| *** hoangcx has joined #openstack-sdks | 01:06 | |
| dtroyer | really what I want to do is take the output of a filtered list and be able to use it somewhere else…and now I'm creeping into interactive mode becoming a DSL…thats why the stray thoughts about Lua for those purposes | 01:06 |
| thingee | dtroyer: --i-really-mean-it | 01:06 |
| dtroyer | 'zactly! | 01:06 |
| dtroyer | except plural! | 01:07 |
| thingee | dtroyer: we put that in one of the ceph commands back in the day. | 01:07 |
| * dtroyer ducks | 01:07 | |
| dtroyer | —dwim has been in more than one of my previous projects (do what I mean) | 01:07 |
| thingee | don't shoot the messenger | 01:08 |
| *** yanyanhu has joined #openstack-sdks | 01:13 | |
| *** alex_xu has quit IRC | 01:19 | |
| *** alex_xu has joined #openstack-sdks | 01:19 | |
| *** alex_xu has quit IRC | 01:25 | |
| *** Kuwagata has quit IRC | 01:25 | |
| *** alex_xu has joined #openstack-sdks | 01:25 | |
| *** alex_xu has quit IRC | 01:26 | |
| *** alex_xu has joined #openstack-sdks | 01:27 | |
| *** huanxuan has joined #openstack-sdks | 01:39 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 01:53 | |
| *** gildub has quit IRC | 01:53 | |
| openstackgerrit | Qiming Teng proposed openstack/python-openstacksdk master: Reorganize cluster docs https://review.openstack.org/439110 | 01:55 |
| openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Functional test for subnet https://review.openstack.org/435914 | 02:01 |
| *** john-davidge has joined #openstack-sdks | 02:04 | |
| *** john-davidge has quit IRC | 02:09 | |
| *** annp has joined #openstack-sdks | 02:11 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Update doc/source/command-objects/image.rst https://review.openstack.org/439142 | 02:22 |
| *** reedip has joined #openstack-sdks | 02:29 | |
| reedip | ankur-gupta-f1 : anything to do ?? :P | 02:33 |
| ankur-gupta-f4 | well I'm hoping you have slept since the last time we talked haha | 02:34 |
| reedip | 2.5 hours ... enough to clear the cache ! | 02:34 |
| ankur-gupta-f4 | :| | 02:34 |
| ankur-gupta-f4 | you can address amotoki's comments on the set/unset for FIP on floating IP :P | 02:35 |
| ankur-gupta-f4 | reedip: you also got a nit -1 on the TaaS patchsets | 02:36 |
| reedip | I will do the TaaS after I reach office :) Will update the FIP one for now | 02:37 |
| *** fzdarsky_ has joined #openstack-sdks | 02:38 | |
| ankur-gupta-f4 | and quota unset. So much to do so little time haha. | 02:38 |
| *** prg3 has joined #openstack-sdks | 02:38 | |
| reedip | amotoki : I also faced the same issue with https://review.openstack.org/#/c/383025/ . After confirmation from sindhu , it was informed that the devstack needed to be updated. | 02:39 |
| reedip | sindhu : care to explain the sdk_connection error in http://paste.openstack.org/show/600865/ for the patch https://review.openstack.org/#/c/383025 | 02:39 |
| amotoki | reedip: what needs to be updated? | 02:39 |
| amotoki | reedip: I used the version specified in upper-constraitnt.txt of openstacksdk, i.e., 0.9.13. what's the prbolem? | 02:40 |
| ankur-gupta-f4 | amotoki: Will try recreating now | 02:40 |
| amotoki | in addition to the above, it seems Ocata released versions of SDK and OSC have problems due to SDK API change. | 02:41 |
| amotoki | for example, osc floating ip show <id> does not work. | 02:41 |
| reedip | amotoki : ?? really ??? | 02:41 |
| *** fzdarsky|afk has quit IRC | 02:42 | |
| amotoki | reedip: http://paste.openstack.org/show/600867/ | 02:42 |
| amotoki | I haven't checked all commands, but we have at least one :-( | 02:42 |
| reedip | amotoki : As per what sindhu discussed with dtroyer, the sdk_connection error occurred due to devstack not being updated. I am waiting for sindhu's explanation for your question as I was also facing this issue in my local machine ( my devstack is older) but this issue is not occurring on the Gate | 02:43 |
| amotoki | reedip: I created a new virtualenv and installed SDK and OSC, so i believe it does not apply to my case. | 02:44 |
| amotoki | another strange behavior http://paste.openstack.org/show/600868/ | 02:44 |
| ankur-gupta-f4 | well I'm getting "ImportError: No module named deprecation" | 02:44 |
| amotoki | network list --external does not work. it lists non-external networks too. | 02:45 |
| ankur-gupta-f4 | so i guess my env is broken | 02:45 |
| reedip | amotoki : TL;DR , a lot of issues are now coming :) Let me try out the latest SDK and OSC and get back to you. ankur-gupta-f4 ; too little time is right :) | 02:46 |
| amotoki | reedip: no problem | 02:46 |
| reedip | amotoki: thanks | 02:46 |
| ankur-gupta-f4 | rebuilding. but this seems like it may be a tomorrow (for me) issue. Thanks amotoki for bringing it to attention. And also good morning :) | 02:47 |
| *** yuanying has quit IRC | 02:47 | |
| reedip | good ???? not for the CLI | 02:47 |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311 | 02:48 |
| sindhu | reedip: amotoki : ok I finally found the conversation 12:16 PM <dtroyer> sindhu: make sure you have https://review.openstack.org/#/c/435735/ in your git history. rebase your patchset on master if you have not done that since 435735 merged. | 02:50 |
| reedip | sindhu : is this the part of Openstack SDK 0.13 release? | 02:51 |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311 | 02:52 |
| sindhu | reedip: I am not sure abt that. Should ask dtroyer :) | 02:59 |
| reedip | Or check the latest 0.13 code and see if it exists :F | 03:00 |
| reedip | :D | 03:00 |
| reedip | thats the longer way | 03:00 |
| ankur-gupta-f4 | check the release notes and it wud show whether patch 435735 merged | 03:00 |
| ankur-gupta-f4 | wait its an OSC patch. SDK doesn't matter | 03:00 |
| reedip | oops | 03:01 |
| reedip | ankur-gupta-f4 : there are some issues with OSC as the upgrade to 0.9.13 didnt remove the workarounds for 0.9.12 | 03:09 |
| reedip | sindhu : ^^ | 03:09 |
| ankur-gupta-f4 | excellent | 03:10 |
| reedip | ankur-gupta-f4 : vv This is under works | 03:16 |
| *** Kuwagata has joined #openstack-sdks | 03:16 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Remove workarounds for 0.9.12 SDK version https://review.openstack.org/439299 | 03:16 |
| *** reedip has quit IRC | 03:31 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Reorganize cluster docs https://review.openstack.org/439110 | 03:33 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Reorganize workflow docs https://review.openstack.org/439028 | 03:34 |
| *** salv-orlando has joined #openstack-sdks | 03:34 | |
| *** amotoki_ has joined #openstack-sdks | 03:36 | |
| *** salv-orlando has quit IRC | 03:39 | |
| *** amotoki has quit IRC | 03:39 | |
| *** gildub has joined #openstack-sdks | 03:44 | |
| *** yuanying has joined #openstack-sdks | 03:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/439362 | 04:16 |
| *** john-davidge has joined #openstack-sdks | 04:31 | |
| *** john-davidge has quit IRC | 04:35 | |
| *** adriant has quit IRC | 04:49 | |
| *** amotoki has joined #openstack-sdks | 05:07 | |
| *** amotoki_ has quit IRC | 05:09 | |
| *** salv-orlando has joined #openstack-sdks | 05:35 | |
| *** e0ne has joined #openstack-sdks | 05:36 | |
| *** e0ne has quit IRC | 05:38 | |
| *** gouthamr has quit IRC | 05:40 | |
| *** salv-orlando has quit IRC | 05:40 | |
| *** Kuwagata has quit IRC | 05:49 | |
| *** salv-orlando has joined #openstack-sdks | 06:26 | |
| *** sigmavirus has quit IRC | 06:52 | |
| *** salv-orl_ has joined #openstack-sdks | 06:52 | |
| *** sigmavirus has joined #openstack-sdks | 06:53 | |
| *** sigmavirus is now known as Guest53153 | 06:54 | |
| *** salv-orlando has quit IRC | 06:55 | |
| *** john-davidge has joined #openstack-sdks | 06:58 | |
| *** john-davidge has quit IRC | 07:03 | |
| *** namnh has joined #openstack-sdks | 07:04 | |
| *** gildub has quit IRC | 07:06 | |
| *** amotoki has quit IRC | 07:20 | |
| *** salv-orl_ has quit IRC | 07:25 | |
| *** amotoki has joined #openstack-sdks | 07:34 | |
| *** annp has quit IRC | 07:35 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 07:40 |
| *** amotoki has quit IRC | 07:42 | |
| *** Kuwagata has joined #openstack-sdks | 07:45 | |
| *** Kuwagata has quit IRC | 07:49 | |
| *** ralonsoh has joined #openstack-sdks | 07:55 | |
| *** yuanying has quit IRC | 08:01 | |
| *** yuanying has joined #openstack-sdks | 08:05 | |
| *** annp has joined #openstack-sdks | 08:08 | |
| *** dfflanders has quit IRC | 08:12 | |
| *** salv-orlando has joined #openstack-sdks | 08:24 | |
| *** amotoki has joined #openstack-sdks | 08:32 | |
| openstackgerrit | Rikimaru Honjo proposed openstack/python-openstackclient master: Add a validation about options for server migrate command https://review.openstack.org/439451 | 08:37 |
| *** yuanying has quit IRC | 08:51 | |
| *** yuanying has joined #openstack-sdks | 08:55 | |
| *** alex_xu has quit IRC | 09:01 | |
| *** ralonsoh has quit IRC | 09:01 | |
| *** alex_xu has joined #openstack-sdks | 09:02 | |
| *** jpich has joined #openstack-sdks | 09:09 | |
| openstackgerrit | Reedip proposed openstack/python-openstacksdk master: WIP Bulk Create support in OpenstackSDK https://review.openstack.org/439477 | 09:11 |
| *** yuanying has quit IRC | 09:16 | |
| reedip_ | ankur-gupta-f4 , ankur-gupta-f4 : You need to update devstack , openstack-sdk installed deprecation as a requirement 14 days ago | 09:23 |
| reedip_ | ankur-gupta-f1 ^^ | 09:24 |
| reedip_ | amotoki : I am not facing any issue with floating ip show <id> | 09:25 |
| reedip_ | checking the External Network issue ( I have updated my branch to master for SDK and OSC ) | 09:25 |
| amotoki | reedip_: what versions (SDK/OSC) do you use? | 09:27 |
| reedip_ | amotoki: 0.9.13, 3.8.1 | 09:28 |
| reedip_ | thats as per pip freeze | 09:28 |
| *** lucas-afk is now known as lucasagomes | 09:28 | |
| reedip_ | I am redeploying the devstack . And will retry the CLIs just to be doubly sure | 09:29 |
| openstackgerrit | Qiming Teng proposed openstack/python-openstacksdk master: Add wait_for_xxx methods to cluster proxy https://review.openstack.org/439490 | 09:37 |
| *** Kuwagata has joined #openstack-sdks | 09:46 | |
| amotoki | reedip_: I checked the latest patch set locally and confirmed it works. | 09:48 |
| amotoki | reedip_: one question remaining on the class name. | 09:48 |
| amotoki | reedip_: currently SetFloatingIP is used for the class name. I wonder what class name is used when we have 'floating ip set' command in the future. | 09:49 |
| reedip_ | amotoki : I am not sure about your query. Isnt the current Class name "SetFloatingIP" used for floating ip set CLI ? | 09:50 |
| *** Kuwagata has quit IRC | 09:50 | |
| amotoki | reedip_: assume we have both 'openstack floating ip set port' and 'openstack floating ip set' in future | 09:52 |
| reedip_ | amotoki : ok . Now its clear | 09:52 |
| amotoki | reedip_: we currently use 'SetFloatingIP' for the former. what class name should be used for the latter. | 09:52 |
| reedip_ | amotoki : how about keeping the same class name but using --port for setting the Port IP | 09:53 |
| amotoki | reedip_: that is one option. | 09:54 |
| amotoki | reedip_: I do not know the background why we chose 'floating ip set port' rather than 'floating ip set' | 09:54 |
| reedip_ | amotoki : we had floating ip port associate/disassociate | 09:55 |
| reedip_ | amotoki : but the actions ( associate /disassociate ) were not conforming with the Rules defined in OSC | 09:55 |
| reedip_ | thats why it was proposed to move them to set / unset | 09:56 |
| reedip_ | amotoki: but now this makes more sense to have port as optional | 09:56 |
| reedip_ | amotoki: to keep floating ip set available for other operations | 09:56 |
| reedip_ | amotoki : Can you send the neutronclient to OSC google sheet ???? Please :) | 09:56 |
| reedip_ | amotoki: got it never mind :) | 09:58 |
| *** yuanying has joined #openstack-sdks | 10:00 | |
| amotoki | reedip_: if we choose 'floating ip set port' as command name, users can easily know what we are doing and --port is a required parameter. | 10:02 |
| amotoki | reedip_: this is the merit of the current proposed command name. This is my understanding. | 10:02 |
| amotoki | reedip_: do you need the link of my google spreadsheet? | 10:03 |
| reedip_ | amotoki : yes, but if we remove port, and keep the --port option,( i.e. floating ip set --port) still they will know that the port is being set with the floating ip | 10:03 |
| reedip_ | amotoki: I needed the link, I got it from history | 10:03 |
| amotoki | reedip_: the link is pasteed in the OSC PTG page | 10:04 |
| reedip_ | amotoki: I am fine with both "floating ip set port" and "floating ip set" | 10:04 |
| amotoki | reedip_: honestly my current vote is 'set port' :) | 10:04 |
| reedip_ | amotoki: Currently , there is no SET option in NeutronClient for Floating IP | 10:04 |
| amotoki | reedip_: yeah, there is no. | 10:04 |
| reedip_ | amotoki: so what we can do is , change the name of the class to SetFloatingIPPort | 10:05 |
| amotoki | reedip_: we have description field now. | 10:05 |
| amotoki | reedip_: it is okay to me if create command supports it later. | 10:05 |
| *** shu-mutou is now known as shu-mutou-AWAY | 10:05 | |
| reedip_ | amotoki: so that if there is ever a requirement in the future, we can consider it later | 10:05 |
| amotoki | reedip_: okay | 10:05 |
| amotoki | reedip_: it is just for curiosity. thanks for your time | 10:06 |
| reedip_ | :) | 10:06 |
| *** hoangcx has quit IRC | 10:07 | |
| *** e0ne has joined #openstack-sdks | 10:10 | |
| *** annp has quit IRC | 10:16 | |
| *** ralonsoh has joined #openstack-sdks | 10:20 | |
| *** yanyanhu has quit IRC | 10:20 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 10:29 |
| *** cdent has joined #openstack-sdks | 10:30 | |
| *** alex_xu has quit IRC | 10:31 | |
| *** alex_xu has joined #openstack-sdks | 10:33 | |
| *** fzdarsky_ is now known as fzdarsky | 10:39 | |
| *** alex_xu has quit IRC | 10:45 | |
| *** alex_xu has joined #openstack-sdks | 10:46 | |
| *** erlon has joined #openstack-sdks | 10:59 | |
| *** sdague has joined #openstack-sdks | 11:01 | |
| *** gildub has joined #openstack-sdks | 11:03 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "qos-policy" option to "port create" & "port set" https://review.openstack.org/419236 | 11:04 |
| *** cdent has quit IRC | 11:05 | |
| *** amotoki has quit IRC | 11:07 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/439362 | 11:11 |
| *** amotoki has joined #openstack-sdks | 11:13 | |
| *** Serlex has joined #openstack-sdks | 11:17 | |
| *** namnh has quit IRC | 11:23 | |
| *** john-davidge has joined #openstack-sdks | 11:34 | |
| *** amotoki has quit IRC | 11:36 | |
| *** jkilpatr has quit IRC | 11:40 | |
| *** wklm has quit IRC | 11:47 | |
| *** huanxuan has quit IRC | 12:02 | |
| *** Guest53153 is now known as sigmavirus | 12:10 | |
| *** sigmavirus has quit IRC | 12:10 | |
| *** sigmavirus has joined #openstack-sdks | 12:10 | |
| *** jkilpatr has joined #openstack-sdks | 12:13 | |
| *** lucasagomes is now known as lucas-hungry | 12:18 | |
| *** alex_xu has quit IRC | 12:18 | |
| *** amotoki has joined #openstack-sdks | 12:21 | |
| *** alex_xu has joined #openstack-sdks | 12:25 | |
| *** salv-orl_ has joined #openstack-sdks | 12:53 | |
| *** salv-orlando has quit IRC | 12:56 | |
| *** ralonsoh_ has joined #openstack-sdks | 12:58 | |
| *** amotoki has quit IRC | 13:00 | |
| *** lucas-hungry is now known as lucasagomes | 13:01 | |
| *** ralonsoh has quit IRC | 13:01 | |
| *** salv-orl_ has quit IRC | 13:08 | |
| *** gildub has quit IRC | 13:14 | |
| *** sambetts has joined #openstack-sdks | 13:16 | |
| sambetts | Hi openstackclient team, I'm hitting an issue on stable/mitaka, my CI has been failing since https://github.com/openstack/requirements/commit/808355f7ddd29f834531bfa6ead7ad01fbe37fb6 merged | 13:17 |
| sambetts | when I have 2.3.1 installed I get this error during devstack: [localhost] out: 2017-02-28 22:24:49.692 | DEFAULT_USER_AGENT = "openstacksdk/%s" % openstack.__version__ | 13:19 |
| sambetts | [localhost] out: 2017-02-28 22:24:49.692 | AttributeError: 'module' object has no attribute '__version__' | 13:19 |
| sambetts | reverting to 2.3.0 fixes this issue | 13:19 |
| *** annegentle has joined #openstack-sdks | 13:31 | |
| *** gouthamr has joined #openstack-sdks | 13:39 | |
| *** Kuwagata has joined #openstack-sdks | 13:48 | |
| openstackgerrit | Qiming Teng proposed openstack/python-openstacksdk master: Add wait_for_xxx methods to cluster proxy https://review.openstack.org/439490 | 13:49 |
| *** Kuwagata has quit IRC | 13:53 | |
| *** shadower has quit IRC | 13:53 | |
| *** amotoki has joined #openstack-sdks | 14:00 | |
| *** Kuwagata has joined #openstack-sdks | 14:43 | |
| *** salv-orlando has joined #openstack-sdks | 14:48 | |
| openstackgerrit | Qiming Teng proposed openstack/python-openstacksdk master: Change version of hacking in test-requirements https://review.openstack.org/439636 | 14:56 |
| openstackgerrit | Qiming Teng proposed openstack/python-openstacksdk master: Add wait_for_xxx methods to cluster proxy https://review.openstack.org/439490 | 14:58 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/openstackclient master: Explicitly depend on python-openstackclient https://review.openstack.org/439641 | 15:05 |
| *** ralonsoh__ has joined #openstack-sdks | 15:05 | |
| *** ralonsoh_ has quit IRC | 15:07 | |
| *** Kuwagata_ has joined #openstack-sdks | 15:13 | |
| *** Kuwagata has quit IRC | 15:16 | |
| *** chlong has joined #openstack-sdks | 15:22 | |
| *** chlong has quit IRC | 15:27 | |
| *** chlong has joined #openstack-sdks | 15:28 | |
| *** chlong has quit IRC | 15:32 | |
| *** Serlex has quit IRC | 15:33 | |
| *** chlong has joined #openstack-sdks | 15:36 | |
| *** annegentle has quit IRC | 15:36 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Change version of hacking in test-requirements https://review.openstack.org/439636 | 15:38 |
| *** chlong has quit IRC | 15:41 | |
| *** hongbin has joined #openstack-sdks | 15:41 | |
| elmiko | etoews, edleafe, looks like i've got a conflict with tomorrow's meeting. just a heads up | 15:45 |
| *** annegentle has joined #openstack-sdks | 15:52 | |
| *** chlong has joined #openstack-sdks | 15:52 | |
| edleafe | elmiko: ack | 15:52 |
| *** annegentle has quit IRC | 16:00 | |
| *** annegentle has joined #openstack-sdks | 16:01 | |
| * edleafe wonders if cdent will be around... | 16:07 | |
| openstackgerrit | Nakul Dahiwade proposed openstack/python-openstackclient master: OSC Network Flavor Profile https://review.openstack.org/396783 | 16:18 |
| *** Serlex has joined #openstack-sdks | 16:21 | |
| openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce neutron flavor associate, disassociate to OSC https://review.openstack.org/403907 | 16:30 |
| openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce neutron flavor associate, disassociate to OSC https://review.openstack.org/403907 | 16:33 |
| *** annegentle has quit IRC | 16:35 | |
| *** ralonsoh__ has quit IRC | 16:35 | |
| *** annegentle has joined #openstack-sdks | 16:36 | |
| *** reedip has joined #openstack-sdks | 16:37 | |
| *** salv-orlando has quit IRC | 16:44 | |
| *** cdent has joined #openstack-sdks | 16:44 | |
| reedip | o/ | 16:46 |
| ediardo | o/ | 16:51 |
| ankur-gupta-f1 | ediardo: whats up! | 16:56 |
| *** salv-orlando has joined #openstack-sdks | 17:00 | |
| *** e0ne has quit IRC | 17:11 | |
| dtroyer | sshank, ankur-gupta-f1: so on https://review.openstack.org/#/c/387611/ it seems like the final thing to sort out is —agent-type | 17:12 |
| sshank | dtroyer, yes. | 17:13 |
| *** aarefiev is now known as aarefiev_afk | 17:13 | |
| dtroyer | I asked for it to be there because I was worried and thinking ahead to if making the assumption that "network agent add network" can _always_ assume the DHCP agent in the future | 17:13 |
| dtroyer | rather, I wanted it to protect against that assumption changing | 17:14 |
| sshank | dtroyer, yeah right now it seems like only dhcp can be added to network. | 17:14 |
| dtroyer | if that is a safe assumption, let's just remove —agent-type. But we will forever have that assumption of the default type if there ever is a nother one possible in this command | 17:14 |
| dtroyer | can we live with thqat? | 17:15 |
| dtroyer | that? | 17:15 |
| sshank | ankur-gupta-f1, ^^? | 17:15 |
| sshank | dtroyer, he is not at his desk. Lemme ping him | 17:16 |
| dtroyer | I'll leaving a comment in the review to doc this… | 17:16 |
| ankur-gupta-f1 | yea i am fine with removing --agent-type | 17:16 |
| dtroyer | and living with the assumption forever? :) | 17:17 |
| ankur-gupta-f1 | ah theres the catch | 17:17 |
| dtroyer | that's why I have been deliberate on this… | 17:18 |
| ankur-gupta-f1 | I still stick by my original idea of putting the --<agent-binary> flag. | 17:18 |
| dtroyer | what is that again? | 17:18 |
| ankur-gupta-f1 | so in case an agent is created down the road where it can add an agent there must be some way of indicating which of the two types of agents. | 17:19 |
| dtroyer | also, there is the slightly larger pattern for all "network agent add/remove XXXX" commands. If others may need to declare an agent type | 17:19 |
| dtroyer | right, that is what —agent-type is for | 17:19 |
| dtroyer | but unneeded at the moment | 17:19 |
| ankur-gupta-f1 | What I am proposing is instead of --agent-type <agent-name>, just have a single flag --<agent-name> | 17:20 |
| ankur-gupta-f1 | network agent add network --dhcp <agent-id> <network> | 17:20 |
| dtroyer | ok, yeah, that is actaully closer to what we do in a lot of other places. | 17:21 |
| ankur-gupta-f1 | parser then will only have to check which flag is set and then call the appropriate object function | 17:21 |
| dtroyer | sometimes we pick the enumerated options over explicit options when there are either a lot of them, or the list is semi-fluid | 17:21 |
| dtroyer | in the general "network agent add/remove XXX" command case, is this still a safe approach? | 17:22 |
| reedip | hi ankur-gupta-f1 | 17:22 |
| reedip | cant we add lbaas as an agent ? | 17:22 |
| ankur-gupta-f1 | yes. many-to-many relationship I think should be the guideline whether to use add/remove and set | 17:23 |
| dtroyer | specifically though WRT —dhcp style options rather than a single generic --agent-type | 17:23 |
| ankur-gupta-f1 | yes | 17:25 |
| reedip | I agree with "network agent add/remove ABC" optio | 17:25 |
| ankur-gupta-f1 | reedip: currently the only lbaasv2 command for the lbaas-agent checks lbaas-agent vs other loadbalancing resources | 17:25 |
| reedip | ankur-gupta-f1 : what I meant was except dhcp , we have other options as wel | 17:26 |
| ankur-gupta-f1 | reedip: explain? | 17:27 |
| ankur-gupta-f1 | there will be a flag for --l3 as well | 17:27 |
| dtroyer | so to restate for clarity: for any "network agent" commands that may need to handle multiple agent types, we will use agent-type-specific options (such as —dhcp and —l3) to identify the agent type rather than a single —agent-type <type> option; also where only a single type can be assumed we will use that assumption as the default. | 17:27 |
| ankur-gupta-f1 | correct | 17:28 |
| dtroyer | \o/ | 17:28 |
| ankur-gupta-f1 | adding to both those reviews for reference | 17:28 |
| sshank | so its 'openstack network agent add network --dhcp <agent-id> <network>' correct? | 17:28 |
| ankur-gupta-f1 | yes | 17:29 |
| dtroyer | —dhscp is not required in that command as it is the only agent type to need "add network" is my understanding | 17:29 |
| dtroyer | if we want to allow —dhcp that is fine with me, and is essentially what the current —agent-type option is doing | 17:29 |
| reedip | dtroyer: yes, thats correct | 17:29 |
| sshank | So its 'openstack network agent add network <agent-id> <network>' since dhcp is default? | 17:29 |
| dtroyer | yes | 17:30 |
| sshank | Ok | 17:30 |
| reedip | but cant we have any oher network agent in the future ? | 17:30 |
| dtroyer | we can, but DHCP will be the default forever | 17:30 |
| ankur-gupta-f1 | wait no we just went backwards | 17:30 |
| dtroyer | ?? | 17:30 |
| reedip | dtroyer : so you want --dhcp to be the default optional ? | 17:31 |
| reedip | I am not sure about that .... User should know which agent he is working upon. I would suggest an agent type to be specified. It may not be a flag , but an agent name ( like dhcp / l3 ) which can be checked | 17:32 |
| dtroyer | so then the need is to make the rule for how to specify network agent type for all network agent commands | 17:33 |
| sshank | I personally think 'openstack network agent add network --dhcp <agent-id> <network>' would be better. It is explicit and causes no confusion. | 17:33 |
| reedip | sshank : --dhcp => dhcp | 17:34 |
| reedip | does that seem better or equally intriguing to u? | 17:34 |
| dtroyer | no, if it is there it is an option | 17:34 |
| dtroyer | —dhcp | 17:34 |
| reedip | dtroyer ; thats my question, does it have to be an option? | 17:34 |
| dtroyer | otherwise w echange the resource name from "network agent" to "dhcp agent" or omething like that, then deal with the explosion of commands | 17:35 |
| *** lucasagomes is now known as lucas-afk | 17:35 | |
| reedip | dtroyer : oh ok, got it. The agent-id will be used with the Optional flag | 17:36 |
| reedip | and that would make our complete agent | 17:36 |
| dtroyer | no, the option is stand-aline | 17:37 |
| dtroyer | agent id is a positional argument | 17:37 |
| ankur-gupta-f1 | http://paste.openstack.org/show/600983/ | 17:38 |
| reedip | dtroyer ; U didnt get what I meant ( I was not clear :) ) . I understand that agent-id is the positional argument. Just that from the neutron's POV the agent-id and the agent-type would define the complete agent info | 17:38 |
| dtroyer | ok, fair enough, I've only been thinking about the command structure, not implementation. | 17:38 |
| dtroyer | that said, agent-id isn't uniqueue enough to identify it? | 17:39 |
| reedip | dtroyer: agent id is unique enough ( being the UUID value ) | 17:39 |
| dtroyer | good. I've been surorised about that sort of thing before, OpenStack is always finding new and unique ways to surprise me :) | 17:40 |
| dtroyer | *surprised | 17:40 |
| reedip | we have to fetch its type and verify if the passed option ( like --dhcp ) matches with the agent passed ( or else leave the handling to neutron server and wait for them[ in this case, maybe Us] to pop up :P ) | 17:40 |
| dtroyer | without knowing much else, such as the specifics of the error that is returned, I would let Neutron validate the agent id | 17:41 |
| reedip | ankur-gupta-f1 : so your proposal is to have "network agent add router" and "neutron agent add network " as 2 different CLIs ? | 17:41 |
| dtroyer | unless that is something we can easily validate because we already have the information without another trip to the server | 17:41 |
| reedip | dtroyer : yeah, neutron can do that | 17:41 |
| ankur-gupta-f4 | reedip: yes | 17:42 |
| reedip | dtoryer; No , we need to fetch the agent type from its ID from the server, so its better to let Neutron handle it, if possible | 17:42 |
| reedip | ankur-gupta-f4 ( I am confused which ID is on ) : but using "network agent add --XXX" makes handling simpler , isnt it? | 17:43 |
| ankur-gupta-f4 | reedip: how would you implement that. | 17:44 |
| dtroyer | reedip: recall the structure of add/remove commands, with 2 resources | 17:45 |
| reedip | dtroyer: yeah that thought crossed my mind | 17:45 |
| reedip | ankur-gupta-f4 : do we need to keep separate resources for router and network ? | 17:47 |
| reedip | my implementation may be wrong | 17:47 |
| ankur-gupta-f4 | Yea. There should be 2 args when adding | 17:48 |
| *** sambetts is now known as sambetts|afk | 17:48 | |
| *** shadower has joined #openstack-sdks | 17:49 | |
| ankur-gupta-f4 | No need to overcomplicate | 17:49 |
| dtroyer | network agent add XXX [[—<agent-type-option>] <agent-id> <XXX-name-or-id> | 17:50 |
| sshank | dtroyer: +1 | 17:51 |
| ankur-gupta-f4 | Yes. +1 | 17:52 |
| *** salv-orlando has quit IRC | 17:54 | |
| reedip | yeah, kinda what I would like.. handling things in one go +1 dtroyer | 17:54 |
| *** salv-orlando has joined #openstack-sdks | 17:57 | |
| ankur-gupta-f4 | 30 min later we finalize the solution we came up with at the beginning 😞 | 17:57 |
| ankur-gupta-f4 | Thanks for the feedback everyone | 17:58 |
| ankur-gupta-f4 | sshank: we got work to do | 17:58 |
| sshank | Thanks all. Finally a conclusion. :D \o/ | 17:58 |
| *** jpich has quit IRC | 18:00 | |
| ankur-gupta-f4 | sshank: u say that now | 18:02 |
| reedip | ankur-gupta-f4 : HA HA HAAA | 18:02 |
| reedip | :P | 18:02 |
| ankur-gupta-f4 | sshank: expect heavy doses of -1s... mostly from me | 18:03 |
| openstackgerrit | Merged openstack/python-openstackclient master: Auto allocated topology for OSC https://review.openstack.org/391331 | 18:03 |
| reedip | ankur-gupta-f4 : can you review the floating ip set/unset | 18:04 |
| ankur-gupta-f4 | Yea | 18:04 |
| reedip | sindhu might just hit me with a broom otherwise :P | 18:04 |
| sindhu | reedip: lol .... naaa i won't :D | 18:08 |
| ankur-gupta-f4 | reedip: i gave a quick glance. Let me get back from lunch and take better look | 18:11 |
| reedip | gn then .... have been sleep deprived since yesterday ! Catch you tomorrow | 18:11 |
| ankur-gupta-f4 | Goodnight man | 18:12 |
| ankur-gupta-f4 | Thx for helping out with the FIP stuff | 18:12 |
| *** fzdarsky is now known as fzdarsky|afk | 18:12 | |
| reedip | Now dont say such sweet things, I might just wake up in 2 hours ! | 18:14 |
| reedip | :P | 18:14 |
| *** cdent has quit IRC | 18:29 | |
| *** annegentle has quit IRC | 18:38 | |
| *** e0ne has joined #openstack-sdks | 18:40 | |
| *** salv-orl_ has joined #openstack-sdks | 18:52 | |
| *** cdent has joined #openstack-sdks | 18:54 | |
| *** salv-orlando has quit IRC | 18:55 | |
| *** gouthamr has quit IRC | 18:56 | |
| *** gouthamr has joined #openstack-sdks | 19:01 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add Cinder v3 client support for volumes https://review.openstack.org/412614 | 19:10 |
| *** Kuwagata_ has quit IRC | 19:19 | |
| *** e0ne has quit IRC | 19:20 | |
| *** salv-orl_ has quit IRC | 19:23 | |
| *** reedip has quit IRC | 19:24 | |
| openstackgerrit | Gage Hugo proposed openstack/keystoneauth master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/439797 | 19:36 |
| openstackgerrit | Gage Hugo proposed openstack/keystoneauth master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/439797 | 19:37 |
| *** reedip has joined #openstack-sdks | 19:39 | |
| *** cdent has quit IRC | 19:46 | |
| *** annegentle has joined #openstack-sdks | 19:57 | |
| *** chlong_ has joined #openstack-sdks | 20:01 | |
| *** chlong has quit IRC | 20:01 | |
| *** openstackgerrit has quit IRC | 20:03 | |
| *** john-davidge has quit IRC | 20:06 | |
| *** chlong_ has quit IRC | 20:08 | |
| JayF | /win 32 | 20:09 |
| JayF | whoops :/ | 20:09 |
| *** chlong_ has joined #openstack-sdks | 20:20 | |
| *** jkilpatr has quit IRC | 20:30 | |
| *** jkilpatr has joined #openstack-sdks | 20:34 | |
| *** chlong_ has quit IRC | 20:36 | |
| *** kuzko_ has joined #openstack-sdks | 20:50 | |
| *** openstackgerrit has joined #openstack-sdks | 20:50 | |
| openstackgerrit | Gage Hugo proposed openstack/keystoneauth master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/439797 | 20:50 |
| *** chlong_ has joined #openstack-sdks | 20:50 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Add wait_for_xxx methods to cluster proxy https://review.openstack.org/439490 | 20:52 |
| *** kuzko has quit IRC | 20:53 | |
| openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Update devstack config to point to a valid image https://review.openstack.org/439847 | 20:57 |
| openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC https://review.openstack.org/387611 | 21:05 |
| *** john-davidge has joined #openstack-sdks | 21:06 | |
| openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce neutron flavor associate, disassociate to OSC https://review.openstack.org/403907 | 21:09 |
| *** salv-orlando has joined #openstack-sdks | 21:14 | |
| *** john-davidge has quit IRC | 21:16 | |
| openstackgerrit | Nakul Dahiwade proposed openstack/python-openstackclient master: Jsonify meter and meter rule functional tests https://review.openstack.org/439854 | 21:20 |
| *** jkilpatr has quit IRC | 21:20 | |
| *** jkilpatr has joined #openstack-sdks | 21:22 | |
| *** jkilpatr has quit IRC | 21:30 | |
| *** Serlex has quit IRC | 21:33 | |
| *** gouthamr has quit IRC | 21:33 | |
| openstackgerrit | Merged openstack/osc-lib master: Updated from global requirements https://review.openstack.org/439332 | 21:41 |
| *** jkilpatr has joined #openstack-sdks | 21:43 | |
| *** gildub has joined #openstack-sdks | 21:54 | |
| *** boris-42_ has quit IRC | 22:01 | |
| *** salv-orlando has quit IRC | 22:50 | |
| *** salv-orlando has joined #openstack-sdks | 22:51 | |
| *** gouthamr has joined #openstack-sdks | 22:59 | |
| *** adriant_ has joined #openstack-sdks | 23:01 | |
| *** chlong_ has quit IRC | 23:08 | |
| *** jkilpatr has quit IRC | 23:33 | |
| *** salv-orlando has quit IRC | 23:35 | |
| *** Guest27057 is now known as zigo | 23:57 | |
| *** sdague has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!