| *** john-davidge has joined #openstack-sdks | 00:02 | |
| *** john-davidge has quit IRC | 00:07 | |
| *** sdague has quit IRC | 00:18 | |
| openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: OSC Quota List https://review.openstack.org/379813 | 00:27 |
|---|---|---|
| *** chlong has joined #openstack-sdks | 00:32 | |
| *** hongbin has quit IRC | 00:33 | |
| *** huanxuan has joined #openstack-sdks | 00:34 | |
| *** hoangcx has joined #openstack-sdks | 00:54 | |
| sindhu | dtroyer: ping? | 00:58 |
| *** chlong has quit IRC | 01:08 | |
| *** prg3 has quit IRC | 01:23 | |
| *** yanyanhu has joined #openstack-sdks | 01:23 | |
| *** prg3 has joined #openstack-sdks | 01:24 | |
| RuiChen | ping ankur-gupta-f4 | 01:43 |
| ankur-gupta-f4 | Hey Rui | 01:43 |
| ankur-gupta-f4 | Good morning | 01:44 |
| RuiChen | morning : ) | 01:44 |
| RuiChen | you know our patches fix the same bug | 01:45 |
| ankur-gupta-f4 | Yea i posted comment | 01:45 |
| RuiChen | I would like to add Co-Authored-by and abandon one of them | 01:45 |
| ankur-gupta-f4 | Okay. Abandon yours and add co-authored to mine | 01:45 |
| RuiChen | save the core review time | 01:46 |
| ankur-gupta-f4 | I think dean put +2 on it | 01:46 |
| ankur-gupta-f4 | But gate issues | 01:46 |
| RuiChen | ok, I prefer to rebase your patch ob my functional port test patch | 01:47 |
| RuiChen | sorry, s/ob/on/ | 01:47 |
| *** salv-orlando has joined #openstack-sdks | 01:47 | |
| RuiChen | >> this one https://review.openstack.org/#/c/423970/ | 01:49 |
| ankur-gupta-f4 | It should be the other way. Because the updated functional tests will fail without bug fix | 01:50 |
| ankur-gupta-f4 | Or it should if functional hits bug, which if its a complete functional test it should hit | 01:50 |
| *** salv-orlando has quit IRC | 01:52 | |
| RuiChen | the current functional test don't cover the port set/unset --secuerty-group logic, so it don't catch the bug | 01:53 |
| RuiChen | the related cases should be added in your patch, it's good, I just want to avoid the merge conflict | 01:54 |
| ankur-gupta-f4 | Okay. Fair enough | 01:54 |
| ankur-gupta-f4 | Im good with whichever decision you make | 01:54 |
| ankur-gupta-f4 | As long as it gets done im happy :) | 01:54 |
| RuiChen | thank you :) | 01:56 |
| *** john-davidge has joined #openstack-sdks | 02:03 | |
| *** john-davidge has quit IRC | 02:07 | |
| *** eliqiao has quit IRC | 02:09 | |
| *** fzdarsky__ has joined #openstack-sdks | 02:14 | |
| *** fzdarsky_ has quit IRC | 02:18 | |
| *** bobh has quit IRC | 02:20 | |
| *** amotoki has joined #openstack-sdks | 02:53 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Reorganize image docs https://review.openstack.org/434539 | 02:55 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Reorganize compute docs https://review.openstack.org/434475 | 02:56 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Reorganize database docs https://review.openstack.org/434500 | 02:56 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Reorganize bare_metal docs https://review.openstack.org/434460 | 02:58 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Privatize session instance on Proxy subclasses https://review.openstack.org/434457 | 02:58 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Remove unnecessary coding format in the head of files https://review.openstack.org/416500 | 03:05 |
| openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Fix can not set is_default in network https://review.openstack.org/434602 | 03:15 |
| *** Klumben has quit IRC | 03:33 | |
| *** amotoki has quit IRC | 03:41 | |
| *** gouthamr has quit IRC | 03:44 | |
| *** annp has joined #openstack-sdks | 03:47 | |
| *** salv-orlando has joined #openstack-sdks | 03:48 | |
| *** salv-orlando has quit IRC | 03:53 | |
| *** john-davidge has joined #openstack-sdks | 04:03 | |
| RuiChen | anyone face the issue ? I have no idea about it | 04:07 |
| RuiChen | ft1.1: openstackclient.tests.functional.compute.v2.test_server.ServerTests.test_server_attach_detach_floating_ip_StringException: Traceback (most recent call last): | 04:07 |
| RuiChen | File "openstackclient/tests/functional/compute/v2/test_server.py", line 94, in setUp | 04:07 |
| RuiChen | self.server_create(self.NAME) | 04:07 |
| RuiChen | File "openstackclient/tests/functional/compute/v2/test_server.py", line 68, in server_create | 04:07 |
| RuiChen | name + opts) | 04:07 |
| RuiChen | TypeError: coercing to Unicode: need string or buffer, NoneType found | 04:07 |
| *** Guest15729 has joined #openstack-sdks | 04:08 | |
| RuiChen | in functional tests, block current jenkin jobs gate-osc-dsvm-functional-ubuntu-xenial | 04:08 |
| *** john-davidge has quit IRC | 04:09 | |
| *** Guest15729 has left #openstack-sdks | 04:17 | |
| *** Klumben has joined #openstack-sdks | 04:19 | |
| sindhu | RuiChen: https://review.openstack.org/#/c/383025/ | 04:21 |
| sindhu | RuiChen: yes, even I m getting the same error | 04:22 |
| *** amotoki has joined #openstack-sdks | 04:29 | |
| *** huanxuan has quit IRC | 04:30 | |
| *** adriant has quit IRC | 04:34 | |
| *** amotoki has quit IRC | 04:40 | |
| *** amotoki has joined #openstack-sdks | 04:48 | |
| reedip | o/ | 04:50 |
| *** erlon has quit IRC | 05:05 | |
| *** gildub has quit IRC | 05:21 | |
| *** gildub has joined #openstack-sdks | 05:26 | |
| *** salv-orlando has joined #openstack-sdks | 05:28 | |
| *** salv-orlando has quit IRC | 05:33 | |
| openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient master: Fix the output of quota show https://review.openstack.org/431366 | 05:42 |
| openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient master: Support --no-property in "volume set" command https://review.openstack.org/434094 | 05:43 |
| openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Fix can not set is_default in network https://review.openstack.org/434602 | 05:52 |
| *** salv-orlando has joined #openstack-sdks | 05:53 | |
| *** gildub has quit IRC | 05:54 | |
| openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Fix can not set is_default in network https://review.openstack.org/434602 | 06:00 |
| *** salv-orl_ has joined #openstack-sdks | 06:04 | |
| *** john-davidge has joined #openstack-sdks | 06:04 | |
| *** salv-orlando has quit IRC | 06:07 | |
| *** john-davidge has quit IRC | 06:09 | |
| RuiChen | sindhu, reedip looks like all patch are blocked by the issue, so we have some workaround tips? | 06:13 |
| reedip | which issue ? | 06:25 |
| reedip | RuiChen : nm | 06:26 |
| reedip | RuiChen, restacking devstack, will look into it as soon as it is up. | 06:27 |
| reedip | RuiChen : https://review.openstack.org/#/c/432993/ ?? | 06:29 |
| *** huanxuan has joined #openstack-sdks | 06:31 | |
| RuiChen | reedip: yes, I found the current osc patches face the same issue in job gate-osc-dsvm-functional-ubuntu-xenial | 06:32 |
| RuiChen | TypeError: coercing to Unicode: need string or buffer, NoneType found | 06:32 |
| RuiChen | raise TypeError in setup() of functional tests | 06:32 |
| RuiChen | the same cases pass in my local devstack env | 06:33 |
| *** e0ne has joined #openstack-sdks | 06:46 | |
| *** hoangcx has quit IRC | 06:55 | |
| *** hoangcx has joined #openstack-sdks | 06:58 | |
| *** e0ne has quit IRC | 07:24 | |
| *** amotoki_ has joined #openstack-sdks | 07:29 | |
| *** amotoki has quit IRC | 07:32 | |
| *** gus_ is now known as gus | 07:32 | |
| *** hoangcx has quit IRC | 07:44 | |
| *** hoangcx has joined #openstack-sdks | 07:55 | |
| *** john-davidge has joined #openstack-sdks | 08:05 | |
| *** john-davidge has quit IRC | 08:10 | |
| *** d0ugal has joined #openstack-sdks | 08:23 | |
| *** Serlex has joined #openstack-sdks | 08:29 | |
| *** ralonsoh has joined #openstack-sdks | 08:49 | |
| *** jpich has joined #openstack-sdks | 08:51 | |
| *** aarefiev_afk is now known as aarefiev | 09:09 | |
| openstackgerrit | Huanxuan Ao proposed openstack/osc-lib master: Avoid 'NoneType' error when format conversion https://review.openstack.org/434768 | 09:28 |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** lucas-afk is now known as lucasagomes | 09:35 | |
| *** e0ne has joined #openstack-sdks | 09:56 | |
| *** amotoki_ has quit IRC | 10:01 | |
| *** ralonsoh_ has joined #openstack-sdks | 10:04 | |
| *** gildub has joined #openstack-sdks | 10:04 | |
| *** john-davidge has joined #openstack-sdks | 10:06 | |
| *** ralonsoh has quit IRC | 10:07 | |
| *** john-davidge has quit IRC | 10:11 | |
| *** amotoki has joined #openstack-sdks | 10:13 | |
| *** erlon has joined #openstack-sdks | 10:18 | |
| *** amotoki has quit IRC | 10:20 | |
| *** ralonsoh_ is now known as ralonsoh | 10:23 | |
| *** openstackgerrit has joined #openstack-sdks | 10:33 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/432260 | 10:33 |
| *** Cagelin has joined #openstack-sdks | 10:35 | |
| *** amotoki has joined #openstack-sdks | 10:35 | |
| *** hoangcx has quit IRC | 10:36 | |
| *** cdent has joined #openstack-sdks | 10:41 | |
| *** amotoki has quit IRC | 10:42 | |
| *** annp has quit IRC | 10:51 | |
| *** yanyanhu has quit IRC | 10:55 | |
| *** sdague has joined #openstack-sdks | 11:06 | |
| openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient master: Gate broken test https://review.openstack.org/434818 | 11:18 |
| *** lucasagomes is now known as lucas-bbl | 11:26 | |
| *** ralonsoh has quit IRC | 11:31 | |
| *** gildub has quit IRC | 11:47 | |
| *** cdent has quit IRC | 11:48 | |
| *** reedip has quit IRC | 11:54 | |
| *** reedip_ has joined #openstack-sdks | 11:59 | |
| *** salv-orlando has joined #openstack-sdks | 12:04 | |
| *** john-davidge has joined #openstack-sdks | 12:07 | |
| *** Anticime1 is now known as Anticimex | 12:07 | |
| *** salv-orl_ has quit IRC | 12:07 | |
| *** john-davidge has quit IRC | 12:12 | |
| *** john-davidge has joined #openstack-sdks | 12:16 | |
| *** cdent has joined #openstack-sdks | 12:16 | |
| *** chlong has joined #openstack-sdks | 12:56 | |
| *** lucas-bbl is now known as lucasagomes | 13:01 | |
| *** bobh has joined #openstack-sdks | 13:03 | |
| *** bobh has joined #openstack-sdks | 13:04 | |
| *** bobh has quit IRC | 13:05 | |
| *** bobh has joined #openstack-sdks | 13:05 | |
| openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Reorganize identity docs https://review.openstack.org/434534 | 13:06 |
| *** bobh has quit IRC | 13:10 | |
| *** lucasagomes is now known as lucas-brb | 13:13 | |
| *** gouthamr has joined #openstack-sdks | 13:15 | |
| *** Serlex has quit IRC | 13:36 | |
| *** salv-orlando has quit IRC | 13:36 | |
| *** ralonsoh has joined #openstack-sdks | 13:40 | |
| *** e0ne has quit IRC | 13:41 | |
| *** e0ne has joined #openstack-sdks | 13:42 | |
| *** huanxuan has quit IRC | 13:42 | |
| *** gouthamr has quit IRC | 13:42 | |
| *** gouthamr has joined #openstack-sdks | 13:43 | |
| *** lucas-brb is now known as lucasagomes | 13:49 | |
| *** e0ne has quit IRC | 13:56 | |
| *** Serlex has joined #openstack-sdks | 14:33 | |
| cdent | mordred: thanks for adding your words to the api stability guideline thing. I think we'll get there in the end, but if nothing else it has done a good job of showing what I thought: that there isn't yet a solid consensus. So all in all a good exercise I guess. | 14:35 |
| mordred | cdent: ++ | 14:35 |
| cdent | I was hoping to write a new version today, but I don't think we're there yet | 14:36 |
| mordred | cdent: if I had a billion dollars, I'd buy a large billboard in the bay area and put on it "using semver is not an excuse to break your users" | 14:36 |
| mordred | of course, if I actually had a billion dollars, Id likely stop caring about semver really quickly | 14:37 |
| cdent | I would hope so | 14:37 |
| cdent | I tried to address that concept at the top a bit where I say that if you do use versioning it shouldn't mean that you're removing the old version. | 14:38 |
| dtroyer | mordred: you might be able to pay me to care as your proxy though... | 14:38 |
| cdent | But that's in the "should" side. | 14:38 |
| * cdent checks something | 14:39 | |
| cdent | yup. dtroyer you're input is eagerly awaited here: https://review.openstack.org/#/c/421846/ | 14:39 |
| cdent | oh for heaven's sake | 14:39 |
| cdent | your | 14:39 |
| * cdent puts on a hairshirt | 14:40 | |
| *** hongbin has joined #openstack-sdks | 14:48 | |
| sdague | cdent: that's looking quite good, it would be nice to move that into merge state | 14:50 |
| sdague | so even mordred's issues don't seem very far from concensus | 14:51 |
| cdent | sdague: Yes, but I'm not willing to do so while there's still some pretty hefty disagreement in the comments. I'm trying to be really agnostic about my own points of view and get the disagreements to a point of at least compromise if not aggreement, without imposing my own view. | 14:51 |
| cdent | I think steve isn't fully on board with everything yet, for example | 14:52 |
| sdague | ok, what do you see as the major disagreements? | 14:52 |
| * cdent looks again | 14:52 | |
| cdent | a) not a disagreement but something that needs to be cleared up is the unresolved questions section | 14:53 |
| cdent | b) monty's comments about never changing even with a version is an important thing to resolve. it is the heart of the discussion and the main reason why the document now opens with "if you're gonna do this you must version" | 14:54 |
| cdent | c) the role or meaning of discoverability with regard to capability needs to be clarified | 14:54 |
| cdent | d) 5xx to 4xx == okay needs to change to 500 to anything == okay | 14:55 |
| cdent | e) at least one person wants the examples back | 14:55 |
| sdague | so I don't think c) needs to be resolved before this is updated, because that's an active and ongoing discussion | 14:56 |
| sdague | and other things are held up by the asserting that the currently written api guidelines aren't valid any more | 14:56 |
| cdent | sure, but that conversation is happening because we are doing this process | 14:56 |
| cdent | so it would be good to have it play out on a field where it's already happening? | 14:57 |
| sdague | only if there is a belief that all relevant inputs have the stamina for that, and won't give up and go other places. I'm much more a fan of "ok, we're all agreed on X, get that committed, so it's clear where we are still having discussion" | 14:58 |
| sdague | because while the whole thing remains uncommitted people assume, correctly, that everything is up for reinterpretation | 14:59 |
| *** annegentle has joined #openstack-sdks | 15:00 | |
| cdent | I guess I'm pretty invested in allowing people to explore that reinterpretation because it is exactly that which leads to real, instead of artifical, agreement | 15:03 |
| *** bobh has joined #openstack-sdks | 15:03 | |
| cdent | sdague: I'm not intending to draw this out forever or anything, and if I had a clear understanding of everything that was in the comments right now, I'd try to close it up pronto. but right now I don't. | 15:04 |
| *** annegentle has quit IRC | 15:05 | |
| *** chlong has quit IRC | 15:05 | |
| cdent | sdague: I'm especially hesitant to commit the pending conversation down when people who I know to have a lot of interest and opinion on this topic (like mordred) have only commented today | 15:06 |
| cdent | he's provided some good input which will help the next version | 15:06 |
| *** annegentle has joined #openstack-sdks | 15:06 | |
| sdague | sure, there is just a lot of cognitive weight on the fact that the diff is the entire document. | 15:07 |
| cdent | Yeah, that was intentional. Sometimes making good stuff takes work. | 15:08 |
| cdent | I think think for you this feels like tuning something for which there was already some measure of agreement | 15:09 |
| cdent | but based on the conversations I've had with other people, there are significant bits that were rules that people felt they didn't or couldn't agree with | 15:09 |
| cdent | the lumbering and cumbersome process here is in place to try to expose those things that make people squirm and to be explicit about it and not paper over it | 15:10 |
| * cdent is not happy when people squirm | 15:11 | |
| mordred | cdent: yesterday I had some fun with usage from nova ... | 15:15 |
| mordred | a project's usage contains some totals for the project and then a list of explicit server usages that enumerate each server's usage of resources | 15:15 |
| mordred | in the top level usage, there are two datetimes - stop and start - which are the start and stop of the time period requested | 15:15 |
| mordred | in the server_usages list - there are two datetimes - started_at and ended_at | 15:15 |
| mordred | then in a server itself - there are four datetimes launched_at, terminated_at, created and updated | 15:15 |
| * cdent squirms | 15:16 | |
| mordred | cdent: isn't that magical? | 15:16 |
| sdague | cdent: ok, I'm throwing on a few more comments there | 15:18 |
| cdent | sdague: great, thank you | 15:19 |
| sdague | my hope, one day I'll stop having to explain that adding a field in a multi deployment environment isn't a non breaking change | 15:19 |
| cdent | sdague: I think we've almost reached buy in on that, but not quite yet on values | 15:20 |
| dtroyer | values is nearly the came thing from a consumer standpoint, where we've hurt ourselves is where those are deployment-specific. and that's part of the discovery question that is ongoing. Values that are part of say a server's state should be API versioned as those are expressed in code not in config. | 15:25 |
| dtroyer | s/came/same/ | 15:25 |
| mordred | dtroyer: ++ | 15:25 |
| * dtroyer added that to the review | 15:31 | |
| openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient master: Gate broken test https://review.openstack.org/434818 | 15:38 |
| dtroyer | stevemar: any idea on why that passed to get in but fails so regularly now? | 15:39 |
| stevemar | dtroyer: i'm guessing something broke us? | 15:40 |
| stevemar | dtroyer: maybe tempest or cliff or something more subtle | 15:40 |
| dtroyer | cliff hasn't changed, I did wonder about the wisdom of pulling in tempest there, but figured utilities were safe | 15:40 |
| *** e0ne has joined #openstack-sdks | 15:44 | |
| stevemar | dtroyer: looking at the source it seems okay... | 15:46 |
| stevemar | dtroyer: tempest looks OK, i'm quite confused :) | 15:48 |
| stevemar | dtroyer: but i definitely don't see something that we merged that would have broken us | 15:49 |
| dtroyer | its the unicode coercion that struck me… does tempest include unicode chars in the generated name, maybe only occasionally? | 15:49 |
| stevemar | dtroyer: thats what i was wondering, why i put up the patch to use a straight uuid | 15:50 |
| stevemar | dtroyer: but it doesn't seem like tempest does that https://github.com/openstack/tempest/blob/master/tempest/lib/common/utils/data_utils.py#L46-L62 | 15:50 |
| dtroyer | which I think we should do anyway | 15:50 |
| dtroyer | yeah, that's pretty simple | 15:51 |
| * stevemar shrugs at dtroyer | 15:53 | |
| *** elmiko has joined #openstack-sdks | 15:53 | |
| *** salv-orlando has joined #openstack-sdks | 16:00 | |
| *** annegentle has quit IRC | 16:07 | |
| *** reedip_1 has joined #openstack-sdks | 16:13 | |
| mordred | cdent: what channel is the api meeting in again? | 16:17 |
| cdent | mordred: #openstack-meeting-3 | 16:17 |
| *** annegentle has joined #openstack-sdks | 16:21 | |
| openstackgerrit | Michael Johnson proposed openstack/service-types-authority master: Add load-balancing service type https://review.openstack.org/434999 | 16:34 |
| openstackgerrit | Merged openstack/api-wg master: Add guidelines for boolean names https://review.openstack.org/411529 | 16:38 |
| *** annegentle has quit IRC | 16:42 | |
| *** annegentle has joined #openstack-sdks | 16:44 | |
| *** chlong has joined #openstack-sdks | 16:59 | |
| *** jpich has quit IRC | 17:20 | |
| *** e0ne has quit IRC | 17:22 | |
| *** cdent has quit IRC | 17:54 | |
| *** salv-orl_ has joined #openstack-sdks | 18:04 | |
| *** salv-orlando has quit IRC | 18:07 | |
| *** lucasagomes is now known as lucas-afk | 18:14 | |
| *** cdent has joined #openstack-sdks | 18:32 | |
| *** Serlex has quit IRC | 18:39 | |
| *** fzdarsky__ is now known as fzdarsky|afk | 18:40 | |
| *** cdent has quit IRC | 18:50 | |
| *** cdent has joined #openstack-sdks | 18:50 | |
| *** ralonsoh has quit IRC | 18:51 | |
| *** e0ne has joined #openstack-sdks | 18:54 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/432260 | 19:01 |
| openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Reorganize key_manager docs https://review.openstack.org/435069 | 19:11 |
| ankur-gupta-f4 | dtroyer: finalize --<agent-name> for the network agent commands. Put the optional arg. Done-done. | 19:16 |
| dtroyer | ok, cool, I'll chekc when I pass through the review queue again later | 19:16 |
| sindhu | dtroyer: ping? | 19:17 |
| dtroyer | sindhu: yes | 19:17 |
| sindhu | dtroyer: hi, regarding https://review.openstack.org/#/c/382023/ | 19:18 |
| sindhu | dtroyer: is it ok to have --network, --compute, --volume option like the list command? | 19:18 |
| sindhu | dtroyer: right now this patch only handles network extension | 19:19 |
| dtroyer | what other API still has extensions? They've been eradicated from the other core projects | 19:19 |
| ankur-gupta-f4 | the others don't have extension show though do they? | 19:19 |
| ankur-gupta-f4 | yea | 19:20 |
| dtroyer | and I'd argue should go away in neutron too, but that's for a different audience | 19:20 |
| ankur-gupta-f4 | hence my comment to take it out of common and make it a core networking command. so 'os network extension show' | 19:20 |
| dtroyer | that said, I dislike making the resource name 'network extension' because it reinforces the notion that "all network commands must be namespaced with 'network'" which is exactly not the case | 19:20 |
| reedip_1 | dtroyer : Neutron is pretty tightly coupled with extensions actually | 19:21 |
| dtroyer | OSC is based around named resources, many of which are qualified with names that happen to match API service types, but some do not. and | 19:21 |
| reedip_1 | I agree with ankur-gupta-f4 , remove this from common till we do not have more extensions to list :P | 19:21 |
| dtroyer | reedip_: that doesn't make it a good idea or one that should be copied elsewhere. it isn't | 19:22 |
| reedip_1 | dtroyer : I agree , if it has been removed from other projects, neutron can also look in the future to remove the same , if possible . But till it is not, we can use "openstack extension list --network " to list network extensions, couldnt we ? | 19:23 |
| dtroyer | I would also argue that we prefixed some resources with 'network' out of habit that didn't need it, again due to the misconception that "that is the way it should be done" rather than to fully-qualify the resource | 19:23 |
| ankur-gupta-f4 | reedip_1: note the the command is extension show. List is already in place. | 19:24 |
| dtroyer | reedip_: yes, that would work. also, since no other API has extensions (in the OSC repo anyway) —network can be optional. if others appear then no option simply lists them all | 19:24 |
| dtroyer | why does a show command need a type identifier? | 19:25 |
| dtroyer | to show something you have to have a name or ID to begin with? | 19:25 |
| reedip_1 | sorry ankur-gupta-f4 , misread the command | 19:26 |
| ankur-gupta-f4 | because list extensions exists for all core resources. But extension show only is a network command | 19:26 |
| ankur-gupta-f4 | volume and compute APIs don't support the 'show' which returns more details about a specific API extension | 19:26 |
| dtroyer | so either throw an exception for them (not found?) or return an empty or minimal result set | 19:27 |
| sindhu | so i'll still keep in common ? | 19:27 |
| dtroyer | yes | 19:27 |
| ankur-gupta-f4 | but update help text plz | 19:28 |
| ankur-gupta-f4 | as per John Davidge's comments | 19:28 |
| sindhu | okay will do | 19:28 |
| reedip_1 | dtroyer : but is keeping this implementation in common correct ? | 19:28 |
| reedip_1 | I mean that was your query , and I found it right. Wondering what changed your mind :) | 19:29 |
| dtroyer | phase of moon? | 19:30 |
| reedip_1 | wont change till tomorrow :P | 19:30 |
| dtroyer | I don't recall exactly what was the rationaly, but the way I understand it today may be different | 19:30 |
| reedip_1 | so should we take this with a pinch of salt ??? | 19:31 |
| *** e0ne has quit IRC | 19:32 | |
| ankur-gupta-f4 | moving on though. I want to bring up these updated functional test stuff coming in | 19:32 |
| dtroyer | am I not allowed to change my mind if my understanding changes? | 19:32 |
| reedip_1 | dtroyer : no you are , for sure :) | 19:33 |
| dtroyer | also, given that a number of other commands have dependencies on knowing if extensions are installed/enabled, this is one area I would support putting into a common network lib (network.v2.common) | 19:33 |
| reedip_1 | and I think keeping it in the network section sounds logical | 19:33 |
| dtroyer | excpet that particular module already has command classes in it | 19:33 |
| reedip_1 | ok | 19:33 |
| dtroyer | err, network.common | 19:33 |
| dtroyer | similar to what is in identity.common | 19:33 |
| dtroyer | I'm talking about the actual access methods (calling REST) not the command classes | 19:34 |
| dtroyer | so another command can easily check if an extension is enabled and act appropriately | 19:34 |
| dtroyer | that doesn't need to be done immediately, but I wanted to mention it as an example of places I do think factoring out stuff is beneficial since I rant against that so much in the command classes | 19:35 |
| ankur-gupta-f4 | makes sense. | 19:37 |
| dtroyer | ok, so functional tests? | 19:38 |
| ankur-gupta-f4 | I would like to see more comprehensive tests specifically for some of the set/unset tests. Ive noticed a lot of them just set a description or something similar. I want to see them do a bit more. i.e. port command instead of just setting and unset description. I want them to create another resource like security group and set and unset the security group. I | 19:39 |
| ankur-gupta-f4 | have a patch like that but I want that to be the standard | 19:39 |
| ankur-gupta-f4 | We can catch broken commands/resources faster that way | 19:39 |
| dtroyer | exactly right | 19:40 |
| ankur-gupta-f4 | okay. In that case Im going to start commenting on patches coming in that are still doing the superficial testing and do more thorough functional tests | 19:40 |
| dtroyer | the mechanics of testing the option parsing belongs in unit tests, but especially where things interact with other resources we need to be checking deeper in functional tests | 19:41 |
| dtroyer | good idea | 19:41 |
| ankur-gupta-f4 | Okay. Sounds good. | 19:41 |
| dtroyer | we don't need to duplicate unit tests, but some things also can be affected by changes in the underlying libs and this is the only place we catch those until we add more integration tests | 19:42 |
| dtroyer | to be clear, I think we understand the scope of unit tests, and functional tests work against a running cloud | 19:43 |
| dtroyer | what I'm calling integration tests (maybe the wrong name) test the stack from the command parser down the the requests session emitting HTTP | 19:43 |
| dtroyer | so no actual server required, we mock the HTTP reply and look at the entire client stack | 19:44 |
| ankur-gupta-f4 | hows the run time for something like that? | 19:44 |
| ankur-gupta-f4 | just thinking beyond to bringing it up into voting job | 19:45 |
| dtroyer | similar to unit tests. I have a few defined in tests.unit.integ. so far they are mostly for checking os-client-config behaviour | 19:45 |
| dtroyer | they are run with the unit tests today | 19:46 |
| dtroyer | where unit tests mock out things outside osc, these use the entire stack of dependencies down to the requests lib | 19:46 |
| dtroyer | so osc-lib, python-*client (or SDK), os-client-config, etc | 19:47 |
| ankur-gupta-f4 | neat will take a look | 19:47 |
| dtroyer | hmmm… I'm looking now and it seems like I wrote more than what is there | 19:48 |
| ankur-gupta-f4 | thats all I had for today assuming we are still holding off on networking commands for a while | 19:49 |
| dtroyer | I think we're past where I'd worry about adding functionality, I started looking at some of those larger reviews again yesterday | 19:50 |
| dtroyer | PTG next week will affect the flow, either better or worse, depending on the amount of hacking time we end up with | 19:51 |
| ankur-gupta-f4 | right. PTG :( | 19:52 |
| ankur-gupta-f4 | Flavor Profile and Flavor are two huge ones that could use some eyes | 19:53 |
| dtroyer | ankur-gupta-f1: so just fly home on Sunday and get on the wrong place. oops! Hartsfield? that's not the right airport… oh well… | 19:53 |
| dtroyer | s/place/plane | 19:53 |
| ankur-gupta-f4 | haha. I was thinking of just 'missing' my flight back to Texas and being stuck in Portland forever :| | 19:53 |
| ankur-gupta-f4 | alright. Thanks for the help Dean. Going to go grab some grub | 19:54 |
| ankur-gupta-f4 | thanks reedip_1 : sindhu | 19:54 |
| ankur-gupta-f4 | thanks for the help as well :) | 19:54 |
| *** chlong has quit IRC | 19:56 | |
| *** john-davidge has quit IRC | 19:57 | |
| *** salv-orl_ has quit IRC | 20:16 | |
| *** salv-orlando has joined #openstack-sdks | 20:23 | |
| *** _-___-_ has joined #openstack-sdks | 20:24 | |
| *** _-___-_ has left #openstack-sdks | 20:24 | |
| *** gouthamr has quit IRC | 20:24 | |
| *** salv-orlando has quit IRC | 20:28 | |
| *** reedip_1 has quit IRC | 20:32 | |
| *** gouthamr has joined #openstack-sdks | 20:40 | |
| openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Implement message docs https://review.openstack.org/435104 | 20:41 |
| *** john-davidge has joined #openstack-sdks | 20:58 | |
| openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Implement metric docs https://review.openstack.org/435110 | 20:59 |
| *** john-davidge has quit IRC | 21:03 | |
| *** cdent has quit IRC | 21:16 | |
| openstackgerrit | Ankur proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 21:23 |
| *** salv-orlando has joined #openstack-sdks | 21:24 | |
| *** salv-orlando has quit IRC | 21:29 | |
| *** salv-orlando has joined #openstack-sdks | 21:38 | |
| openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Reorganize orchestration docs https://review.openstack.org/435132 | 21:48 |
| *** ankur-gupta-f1 has quit IRC | 21:52 | |
| *** dfflanders has joined #openstack-sdks | 22:01 | |
| *** chlong has joined #openstack-sdks | 22:05 | |
| *** chlong has quit IRC | 22:11 | |
| *** bknudson has left #openstack-sdks | 22:14 | |
| *** bknudson has joined #openstack-sdks | 22:14 | |
| *** gouthamr has quit IRC | 22:15 | |
| *** fguillot has quit IRC | 22:28 | |
| *** adriant has joined #openstack-sdks | 22:34 | |
| *** bobh has quit IRC | 22:35 | |
| *** annegentle has quit IRC | 22:36 | |
| *** gildub has joined #openstack-sdks | 22:49 | |
| *** john-davidge has joined #openstack-sdks | 22:59 | |
| *** jamielennox is now known as jamielennox|away | 23:02 | |
| *** cdent has joined #openstack-sdks | 23:04 | |
| *** john-davidge has quit IRC | 23:04 | |
| *** bobh has joined #openstack-sdks | 23:05 | |
| *** bobh has quit IRC | 23:08 | |
| *** bobh has joined #openstack-sdks | 23:08 | |
| *** bobh has quit IRC | 23:13 | |
| *** jamielennox|away is now known as jamielennox | 23:14 | |
| *** salv-orlando has quit IRC | 23:24 | |
| *** cdent has quit IRC | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!