*** e0ne has quit IRC | 00:01 | |
*** hongbin has quit IRC | 00:19 | |
*** abhiraut has quit IRC | 00:22 | |
*** abhiraut has joined #openstack-sdks | 00:25 | |
*** abhiraut has quit IRC | 00:28 | |
*** sdague has quit IRC | 00:29 | |
*** kevo has quit IRC | 00:59 | |
*** yanyanhu has joined #openstack-sdks | 01:24 | |
*** annegentle has joined #openstack-sdks | 01:28 | |
*** annegentle has quit IRC | 02:00 | |
*** fzdarsky_ has joined #openstack-sdks | 02:51 | |
*** fzdarsky has quit IRC | 02:54 | |
*** salv-orlando has joined #openstack-sdks | 03:03 | |
*** salv-orlando has quit IRC | 03:07 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | 04:03 |
---|---|---|
*** salv-orlando has joined #openstack-sdks | 04:04 | |
*** salv-orlando has quit IRC | 04:08 | |
*** _elmiko has quit IRC | 04:25 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650 | 04:31 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | 04:31 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194 | 04:39 |
stevemar | mordred: i wouldn't say you "suck", inhale quickly though for sure | 04:41 |
stevemar | <3 | 04:41 |
stevemar | dtroyer: looks like your floating ip patch depends on SDK >=0.9.11 | 04:41 |
stevemar | dtroyer: i staged it on top of my "run tests with SDK 0.9.12" patch to see if it's true | 04:42 |
reedip | stevemar : good morning :). Any help needed for OSC ? | 04:44 |
stevemar | reedip: i think we're still looking at one last bug | 04:49 |
stevemar | reedip: http://logs.openstack.org/50/418650/11/check/gate-osc-dsvm-functional-ubuntu-xenial/329d025/testr_results.html.gz | 04:49 |
stevemar | the test_quota_set and test_quota_show | 04:49 |
stevemar | they dont seem to work with SDK at 0.9.12 | 04:50 |
reedip | stevemar : see if this helps : https://review.openstack.org/#/c/419911/ | 04:50 |
stevemar | the rest of the failures should be fixed | 04:50 |
stevemar | reedip: probably fixes it ;) | 04:56 |
reedip | :D | 04:56 |
reedip | Ok, I am looking into the default quota bug then | 04:56 |
reedip | I mean test_quota_show_with_default_option | 04:56 |
stevemar | reedip: probably need a test for the sdk change? | 04:56 |
stevemar | reedip: looking like the quota show bug stems from the same error | 04:57 |
reedip | stevemar : there was no test written earlier, but ok, I will fix it | 04:57 |
reedip | is it ??? | 04:57 |
reedip | U mean does it fix both the issues ? | 04:57 |
reedip | stevemar : no I dont think it fixes it | 05:00 |
reedip | stevemar : but the solution is similar | 05:01 |
*** gouthamr has quit IRC | 05:07 | |
stevemar | ah similar is good | 06:04 |
*** salv-orlando has joined #openstack-sdks | 06:05 | |
*** salv-orlando has quit IRC | 06:10 | |
reedip | stevemar : upcoming | 06:55 |
reedip | sorry, it took some time to find out :) | 06:55 |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301 | 06:57 |
*** salv-orlando has joined #openstack-sdks | 07:06 | |
*** salv-orlando has quit IRC | 07:10 | |
stevemar | reedip: np! i'll review it tmrw | 07:11 |
reedip | ok :) | 07:11 |
RuiChen | hi reedip: I work on the bug test_quota_show_with_default_option, ready to push a patch to openstacksdk | 07:25 |
reedip | RuiChen : ohh , I didnt know that. I already pushed a patch just a few minutes back | 07:26 |
reedip | RuiChen : https://review.openstack.org/420301 | 07:26 |
RuiChen | ah, see your patch https://review.openstack.org/#/c/420301/ | 07:27 |
reedip | Maybe you can review and rebase it with your changes | 07:27 |
reedip | if you think something which you have taken care but I have missed | 07:27 |
reedip | can be added to that patch | 07:27 |
RuiChen | yeah, never mind, I will review it | 07:27 |
RuiChen | reedip: by the way, if you pip install -e openstacksdk, do you face the error? | 07:28 |
RuiChen | https://www.irccloud.com/pastebin/7GdQciTn/ | 07:29 |
reedip | RuiChen : Never tried it | 07:29 |
reedip | RuiChen: I saw it in devstack | 07:29 |
reedip | I mean when I was reinstalling Openstack using devstack , on Thursday, I faced a similar issue | 07:30 |
reedip | I then removed my directories, put reclone=true and restarted devstack | 07:30 |
reedip | it worked | 07:30 |
reedip | it was similar , but may be or may not be the same issue | 07:30 |
RuiChen | weird, if pip install openstacksdk, no error exist | 07:30 |
RuiChen | I'm not sure what the different between develop mode and regular mode... | 07:33 |
reedip | RuiChen : I dont think it would be much of a difference, devstack jsut takes care of a lot of things | 07:33 |
RuiChen | yeah, devstack do lots of thing that we don' know :) | 07:35 |
RuiChen | reedip: a fresh comment :) https://review.openstack.org/#/c/420301 | 07:43 |
reedip | RuiChen : vv | 07:48 |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301 | 07:48 |
reedip | RuiChen : UT and FT for quotas are not written in the SDK, I guess | 07:48 |
RuiChen | reedip: i don't think so, i found one test_quota_default_get | 07:49 |
reedip | RuiChen : dont know, maybe I missed it | 07:49 |
reedip | RuiChen : the new patch will fail pep8 :P | 07:49 |
reedip | sorry | 07:50 |
RuiChen | looks like the UT test should be change with the current modification | 07:50 |
RuiChen | i feel gate is slower than yesterday | 07:51 |
reedip | RuiChen : done | 07:56 |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301 | 07:56 |
RuiChen | it's great :) | 07:57 |
*** salv-orlando has joined #openstack-sdks | 08:41 | |
*** salv-orlando has quit IRC | 08:45 | |
*** yanyanhu has quit IRC | 09:24 | |
openstackgerrit | Rui Chen proposed openstack/python-openstackclient: Fix OSC networking commands help errors https://review.openstack.org/418221 | 09:25 |
*** dgonzalez has quit IRC | 10:34 | |
*** salv-orlando has joined #openstack-sdks | 10:45 | |
*** salv-orlando has quit IRC | 10:50 | |
*** huanxuan has joined #openstack-sdks | 11:05 | |
*** dgonzalez has joined #openstack-sdks | 11:07 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326 | 11:14 |
*** salv-orlando has joined #openstack-sdks | 11:46 | |
*** salv-orlando has quit IRC | 11:51 | |
openstackgerrit | yuval shalev proposed openstack/python-openstacksdk: Added project role assignment https://review.openstack.org/416598 | 12:01 |
*** reedip_outofmemo has joined #openstack-sdks | 12:08 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix subnet creating failure in functional test https://review.openstack.org/420334 | 12:29 |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326 | 12:32 |
*** reedip_outofmemo has quit IRC | 12:38 | |
*** salv-orlando has joined #openstack-sdks | 12:47 | |
*** salv-orlando has quit IRC | 12:51 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix subnet creating failure in functional test https://review.openstack.org/420334 | 13:30 |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326 | 13:33 |
*** reedip_outofmemo has joined #openstack-sdks | 13:34 | |
*** reedip_outofmemo has quit IRC | 13:35 | |
*** salv-orlando has joined #openstack-sdks | 13:48 | |
*** salv-orlando has quit IRC | 13:53 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Add "encryption-*" options in volume type commands https://review.openstack.org/414197 | 13:57 |
*** salv-orlando has joined #openstack-sdks | 14:49 | |
*** salv-orlando has quit IRC | 14:53 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326 | 14:59 |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326 | 15:00 |
*** bobh has joined #openstack-sdks | 15:21 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: SDK refactor: Prepare network agent commands https://review.openstack.org/420326 | 15:32 |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: SDK refactor: Prepare network agent commands https://review.openstack.org/420326 | 15:34 |
*** huanxuan has quit IRC | 15:39 | |
*** salv-orlando has joined #openstack-sdks | 15:50 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194 | 15:52 |
*** salv-orlando has quit IRC | 15:54 | |
dtroyer | stevemar: I think your testing stack is upside-down, removing the skips from all of the broken tests before fixing the breaks makes the whole stack fail | 15:59 |
dtroyer | I've rebased https://review.openstack.org/420194 to stand alone again, and am testing https://review.openstack.org/420154 the same way. Then the 0.9.12 can get stacked on top of all of these until the -tips job is working… | 16:01 |
*** e0ne has joined #openstack-sdks | 16:07 | |
*** knikolla has quit IRC | 16:11 | |
*** knikolla has joined #openstack-sdks | 16:12 | |
*** e0ne has quit IRC | 16:25 | |
*** erlon_pto has quit IRC | 16:50 | |
*** salv-orlando has joined #openstack-sdks | 16:51 | |
*** prg3 has quit IRC | 16:54 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194 | 16:55 |
*** salv-orlando has quit IRC | 16:55 | |
*** bobh has quit IRC | 16:58 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | 17:00 |
dtroyer | stevemar: , I made ^^^ stand-alone too. We're going to be chasing a long series of rebases and then have to re-test the entire series again once the last one in the chain passes, I'd rather be opportunistic and make the func test fixes stand-alone and then check them with the https://review.openstack.org/418650 review | 17:02 |
*** bobh has joined #openstack-sdks | 17:04 | |
*** prg3 has joined #openstack-sdks | 17:07 | |
dtroyer | argh…I thought the quota commands were fixed… | 17:09 |
*** gouthamr has joined #openstack-sdks | 17:11 | |
*** cardeois has quit IRC | 17:21 | |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301 | 17:37 |
*** salv-orlando has joined #openstack-sdks | 17:52 | |
*** salv-orlando has quit IRC | 17:56 | |
*** e0ne has joined #openstack-sdks | 18:39 | |
*** salv-orlando has joined #openstack-sdks | 18:52 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix quota show --default command https://review.openstack.org/420363 | 19:06 |
dtroyer | reedip: See if ^^^ works around the problem you just posted for the SDK... | 19:06 |
dtroyer | stevemar: ^^^ should be the last of the functioanl test issues... | 19:07 |
*** salv-orlando has quit IRC | 19:12 | |
*** salv-orlando has joined #openstack-sdks | 19:13 | |
*** e0ne has quit IRC | 19:42 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | 19:47 |
*** salv-orlando has quit IRC | 19:55 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix quota show --default command https://review.openstack.org/420363 | 19:56 |
stevemar | dtroyer: reporting in | 20:28 |
stevemar | dtroyer: yeah, i knew the testing stack was upside down :) | 20:28 |
stevemar | dtroyer: was hoping to get a clean chain of patches at the end, then rearranging the puzzle, but fixing them upfront is fine too | 20:28 |
stevemar | dtroyer: please push https://review.openstack.org/#/c/420162/ though | 20:39 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | 20:40 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: SDK refactor: Prepare network agent commands https://review.openstack.org/420326 | 20:52 |
openstackgerrit | Merged openstack/python-openstackclient: Fix subnet creating failure in functional test https://review.openstack.org/420334 | 21:24 |
openstackgerrit | Merged openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194 | 21:25 |
*** bobh has quit IRC | 21:36 | |
*** bobh has joined #openstack-sdks | 21:45 | |
*** bobh has quit IRC | 21:51 | |
stevemar | dtroyer: pushed a bunch of changes | 21:55 |
stevemar | dtroyer: we should be all good to go with the exception of quota set | 21:55 |
dtroyer | stevemar: re https://review.openstack.org/#/c/420162/, tips still wasn't passing, want it anyway? | 21:57 |
*** salv-orlando has joined #openstack-sdks | 22:01 | |
*** salv-orl_ has joined #openstack-sdks | 22:22 | |
*** salv-orlando has quit IRC | 22:26 | |
openstackgerrit | Merged openstack/python-openstackclient: Fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | 23:11 |
stevemar | dtroyer: yes, its a non-voting job, 420162 made the results of the functional-tips usable (viewable in html) | 23:24 |
stevemar | dtroyer: additionally, it made it possible to use "Depends-On" with osc-lib, occ, and sdk | 23:24 |
openstackgerrit | Merged openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | 23:25 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650 | 23:33 |
stevemar | dtroyer: ^^^ should now only have 1 failed test | 23:34 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: unskip port test https://review.openstack.org/420373 | 23:37 |
stevemar | dtroyer: we somehow missed that one ^ | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!