Thursday, 2017-01-12

*** annegentle has joined #openstack-sdks00:14
*** abhiraut has joined #openstack-sdks00:23
*** gildub has quit IRC00:29
*** elmiko is now known as _elmiko00:41
*** huanxuan has joined #openstack-sdks00:45
*** kevo has quit IRC00:46
*** kevo has joined #openstack-sdks00:48
*** jamielennox is now known as jamielennox|away00:50
*** annegentle has quit IRC00:51
*** huanxuan has quit IRC00:59
*** hoangcx has joined #openstack-sdks01:00
*** sdague has quit IRC01:05
openstackgerritAbhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands  https://review.openstack.org/41818301:06
*** jamielennox|away is now known as jamielennox01:21
*** yanyanhu has joined #openstack-sdks01:23
*** kevo has quit IRC01:29
*** gouthamr has quit IRC01:36
*** huanxuan has joined #openstack-sdks01:41
openstackgerritHa Van Tu proposed openstack/python-openstackclient: Add "qos-policy" option to "port create" & "port set"  https://review.openstack.org/41923601:54
*** abhiraut has quit IRC02:04
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12  https://review.openstack.org/41865002:17
*** gouthamr has joined #openstack-sdks02:32
*** markvoelker has quit IRC02:38
*** markvoelker_ has joined #openstack-sdks02:41
*** gildub has joined #openstack-sdks02:44
*** annp has joined #openstack-sdks02:52
*** annp_ has joined #openstack-sdks02:53
*** markvoelker_ has quit IRC02:56
*** annp has quit IRC03:10
*** hoangcx_ has joined #openstack-sdks03:10
*** annp_ has quit IRC03:10
*** hieulq has quit IRC03:10
*** hoangcx has quit IRC03:10
*** hoangcx_ is now known as hoangcx03:12
openstackgerritMerged openstack/python-openstackclient: Add unit test for multi volume types delete  https://review.openstack.org/40594703:13
*** annp_ has joined #openstack-sdks03:24
*** annp has joined #openstack-sdks03:24
*** hieulq has joined #openstack-sdks03:25
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12  https://review.openstack.org/41865003:44
openstackgerritAbhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands  https://review.openstack.org/41818303:45
*** gildub has quit IRC03:51
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Fix quota show output  https://review.openstack.org/41906703:52
*** markvoelker has joined #openstack-sdks03:57
*** amotoki has quit IRC04:22
*** amotoki has joined #openstack-sdks04:22
*** gildub has joined #openstack-sdks04:32
*** adriant has quit IRC04:47
openstackgerritavnish proposed openstack/os-client-config: Use upper-constraints for tox envs  https://review.openstack.org/41927304:51
reedipstevemar : thanks for the reno :)05:00
*** fzdarsky|afk has joined #openstack-sdks05:01
*** fzdarsky|afk has quit IRC05:09
stevemarreedip: np ;)05:11
*** sc68cal has quit IRC05:18
*** sc68cal has joined #openstack-sdks05:20
*** salv-orlando has joined #openstack-sdks05:26
*** salv-orlando has quit IRC05:31
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: unskip network qos rule type functional test  https://review.openstack.org/41912905:53
openstackgerritzhiyong.dai proposed openstack/python-openstackclient: Update functional test for aggregate.  https://review.openstack.org/41868506:02
openstackgerritzhiyong.dai proposed openstack/python-openstackclient: Update functional test for aggregate.  https://review.openstack.org/41868506:15
*** salv-orlando has joined #openstack-sdks06:28
*** salv-orlando has quit IRC06:32
*** ankur-gupta-f has quit IRC06:40
*** kevo has joined #openstack-sdks06:43
*** e0ne has joined #openstack-sdks06:55
*** e0ne has quit IRC06:57
*** salv-orlando has joined #openstack-sdks06:57
*** hoangcx_ has joined #openstack-sdks06:57
*** hoangcx has quit IRC07:00
*** john-davidge has joined #openstack-sdks07:37
*** gouthamr has quit IRC07:42
*** john-davidge has quit IRC07:42
*** hoangcx has joined #openstack-sdks07:49
*** hoangcx_ has quit IRC07:51
*** ralonsoh has joined #openstack-sdks07:52
openstackgerritHa Van Tu proposed openstack/python-openstackclient: Add "qos-policy" option to "port create" & "port set"  https://review.openstack.org/41923608:06
*** hongbin has quit IRC08:16
*** john-davidge has joined #openstack-sdks08:33
*** salv-orl_ has joined #openstack-sdks08:43
*** salv-orlando has quit IRC08:43
reedipralonsoh : ping08:46
ralonsohreedip: hello08:46
ralonsohreedip: I know, the qos port cli08:47
reedipralonsoh : :D08:47
reedipyup08:47
ralonsohI mean:08:47
ralonsohqos-policy is only an id08:47
reedipI have updated my response in the PS. Can you verify the same?08:47
reedipralonsoh: ok08:47
ralonsohok08:47
reedipralonsoh: I understand that we cannot append the QoS policy for a port08:48
reedipralonsoh : but we can handle it in the code itself08:48
ralonsohWe can do what you are proposing: to fail if there is already a qos associated08:49
ralonsohThis is the case of append08:49
reedipralonsoh : yes, for append08:49
reedipWe have 4 cases basically08:49
reedipCreate08:49
reedipAppend08:50
reedipRemove08:50
reedipOverwrite08:50
ralonsohyes08:50
ralonsohI agree08:50
reedipCreate would be by --qos-policy08:50
ralonsohnow append has a different action to overwrite08:50
reedipralonsoh : yup, it has a different action08:50
ralonsohaction=effect08:50
ralonsohok08:50
ralonsohi'll update my comment in the PS08:50
ralonsohthank you!!08:50
reedipralonsoh : ok , great :)08:51
*** kevo has quit IRC08:59
*** david-lyle has quit IRC09:01
*** e0ne has joined #openstack-sdks09:07
reedipralonsoh : Hi . This Test Case failed in one of my patches09:12
reediphttps://review.openstack.org/#/c/352477/34/openstackclient/tests/unit/network/v2/test_network_qos_rule.py#65609:12
reedipralonsoh : http://logs.openstack.org/67/419067/2/check/gate-python-openstackclient-python27-ubuntu-xenial/7a2f84a/console.html#_2017-01-12_05_58_52_97791309:13
ralonsohreedip: i'm in a meeting. I'll take a look at this ASAP09:13
reedipralonsoh : Oh sorry , sure :)09:14
*** lucas-afk is now known as lucasagomes09:22
*** david-lyle has joined #openstack-sdks09:24
*** salv-orl_ has quit IRC09:26
*** gildub has quit IRC09:44
*** huanxuan has quit IRC09:45
*** yanyanhu has quit IRC09:54
*** e0ne has quit IRC10:06
*** fzdarsky|afk has joined #openstack-sdks10:07
*** e0ne has joined #openstack-sdks10:12
*** ralonsoh_ has joined #openstack-sdks10:17
*** ralonsoh has quit IRC10:20
*** hoangcx has quit IRC10:27
*** huanxuan has joined #openstack-sdks10:31
*** cdent has joined #openstack-sdks10:44
*** amotoki has quit IRC10:56
*** amotoki has joined #openstack-sdks11:06
*** cdent has quit IRC11:23
*** fzdarsky|afk is now known as fzdarsky11:25
*** crinkle_ is now known as crinkle11:38
*** fzdarsky has quit IRC11:41
*** ralonsoh_ is now known as ralonsoh11:42
ralonsohreedip: uffff, I took me a bit of time. You found an error11:42
ralonsohreedip: in parse_args i make this check "if parsed_args.dscp_mark:"11:42
ralonsohreedip: and dscp_mark = 0 in this case11:42
ralonsohreedip: I'll fill this bug and I'll send the patch. Thanks!!!11:43
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Network qos rule unit test broken  https://review.openstack.org/41943411:49
huanxuanralonsoh: er... I also  found it just now...11:50
*** amotoki has quit IRC11:53
*** ralonsoh_ has joined #openstack-sdks11:55
huanxuanralonsoh: To be fair... I will abandon my patch if you are working on it, sorry for the conflict...11:55
*** fzdarsky has joined #openstack-sdks11:57
*** amotoki has joined #openstack-sdks11:58
*** ralonsoh has quit IRC11:59
*** fzdarsky has quit IRC11:59
*** fzdarsky has joined #openstack-sdks12:00
*** amotoki_ has joined #openstack-sdks12:03
*** cdent has joined #openstack-sdks12:03
*** amotoki has quit IRC12:05
*** fzdarsky has quit IRC12:06
ralonsoh_huanxuan: no, please, continue with it12:06
ralonsoh_I'll review it12:07
ralonsoh_Add me as reviewer12:07
ralonsoh_Ok, I saw you abandon the patch12:08
*** annp_ has quit IRC12:08
*** annp has quit IRC12:08
*** amotoki_ has quit IRC12:10
huanxuanralonsoh_: Yes... really sorry about the conflict, I was just found the error but did not sure about it, you can commit your patch and fix it now, thank you!12:11
*** rtheis has joined #openstack-sdks12:11
*** sheel has joined #openstack-sdks12:19
stevemarhuanxuan: ralonsoh_ sounds like you two found the gate bug :)12:23
ralonsoh_stevemar: I'm on it and adding new tests to check that12:24
huanxuanstevemar: I cause a conflict... :(  thank you alot ralonsoh_12:25
*** lucasagomes is now known as lucas-hungry12:26
huanxuanstevemar: I think we may still have a gate bug12:26
huanxuanhttp://logs.openstack.org/85/418685/3/check/gate-python-openstackclient-python35/fe25c5f/console.html#_2017-01-12_06_18_50_57175612:27
huanxuanstevemar: about auth_ref12:27
stevemarhuanxuan: yeah, i noticed that a few times now12:28
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test  https://review.openstack.org/41944512:29
openstackgerritXinhui Li proposed openstack/python-openstacksdk: Add workflow service (mistral)  https://review.openstack.org/41491912:31
huanxuanstevemar: I try to specify a value for auth_ref, just like we did in other unit test, hopefully it works12:31
dtroyerOK, I am trying to understand what makes that test race like that…12:43
dtroyerooooooooohhhhhhhhhh...12:43
dtroyermany class variables in that file12:43
*** sdague has joined #openstack-sdks12:43
dtroyerare all of the failures in the same place?12:45
huanxuandtroyer: no, I saw two in network qos rule command, and one in image set command12:47
huanxuanthey are variable...12:50
stevemarhuanxuan: dtroyer at least unit test failures are more isolated than functional test failures :)12:52
*** fzdarsky has joined #openstack-sdks12:56
*** dgonzalez has quit IRC12:58
RuiChenwe have an IRC meeting UTC 13:00 today?13:00
dtroyerYES!  thanks for the nudge…13:00
dtroyer#openstack-meeting-3 now13:01
RuiChen\o/, I join it right now13:01
*** fzdarsky has quit IRC13:01
*** lucas-hungry is now known as lucasagomes13:02
*** salv-orlando has joined #openstack-sdks13:04
*** dgonzalez has joined #openstack-sdks13:05
openstackgerritMonty Taylor proposed openstack/os-client-config: Use upper-constraints for tox envs  https://review.openstack.org/41927313:17
openstackgerritMonty Taylor proposed openstack/os-client-config: Remove 3.4 from tox envlist  https://review.openstack.org/41945713:17
openstackgerritRodolfo Alonso Hernandez proposed openstack/python-openstackclient: Fix Network QoS rule CLI attrs parsing  https://review.openstack.org/41946113:23
*** ralonsoh_ is now known as ralonsoh13:23
*** aarefiev_afk is now known as aarefiev13:26
*** ralonsoh_ has joined #openstack-sdks13:33
*** ralonsoh has quit IRC13:36
*** salv-orlando has quit IRC13:39
*** lamt has joined #openstack-sdks13:58
stevemaro/14:00
RuiChenhi14:00
huanxuanstevemar: let's talk about the manage and unmanage14:00
stevemarhuanxuan: sure, looks like thingee (mike perez) had some comments in v14:01
stevemarhttps://review.openstack.org/#/c/410008/14:01
RuiChenbut some new commands which is added in newton can't use against Mitaka OpenStack, I mean, dtroyer14:01
huanxuanstevemar: actually I don't know how to make sure the comment "do this automatically"14:02
huanxuanstevemar: I don't know how to see the difference in this kind of volume between using --remote and not14:03
huanxuansince there is not a volume create using --remote for me14:04
huanxuanI cannot see any information about it14:04
stevemarhuanxuan: that's fine, i was hoping there was information about in the volume, but i guess not14:05
stevemarhuanxuan: i'm just concerned about mike's last comments14:05
*** jiahui has joined #openstack-sdks14:05
stevemarhe really doesn't like the --remote option, sounds like he would have liked manage/unmanage commands14:05
*** fzdarsky has joined #openstack-sdks14:05
dtroyerI really don't like manage/unmanage, but don't understant the choice of —remote either14:06
huanxuanstevemar: yes14:06
stevemardtroyer: did we release those commands yet?14:06
dtroyeris 'set —manage | —unmanage' a thing here?14:06
dtroyerstevemar: no idea…probably, this goes back to before the previous release or two14:07
dtroyerif we make a change in direction, deprecating —remote is no big deal14:07
huanxuanyes, we can make a change if necessary14:08
stevemargrr, went into 3.6.0 and 3.5.014:08
dtroyermy concern with manage/unamanage is that it is fairly meaningless without already knowing exactly what cinder defines it to mean, not something that can ge used elsewhere sicne no other API that I know of has this concenpt14:08
stevemarthats true14:08
huanxuanyeah14:08
dtroyerthose really are db-only operations14:09
RuiChensorry, I think make OSC version match openstack version make sense for downstream team, it's easier to pick right osc version for stable openstack , so what's your advise? dtroyer14:09
dtroyerif I wanted to be a jerk, I'd say they belong in cinder-manage :)14:09
*** amotoki has joined #openstack-sdks14:09
dtroyerRuiChen: I'd like to finish the cinder thing first…14:09
stevemarwe can always deprecate the option or add a new manage command (the two options for creating can co-exist)14:09
stevemardtroyer: i think we're done14:10
RuiChensure, here you go, sorry14:10
dtroyerright.  this is a case where I do think we need to step back a bit and make sure we build the right UI14:10
dtroyerok, thanks guys14:10
huanxuanRuiChen: thanks14:11
dtroyerRuiChen: the current OSC will always have features that an older cloud can not use, but that does not make it unusable on older clouds14:11
*** gouthamr has joined #openstack-sdks14:11
stevemarif someone comes up with a nice UI, they can build it. the two options can co-exist. just like git checkout -b new_branch; and git branch -d <new_branch>14:11
dtroyerif that idea is a problem for your downstream, then it will always be a problem during every release14:11
huanxuanstevemar: sounds good14:12
*** _elmiko is now known as elmiko14:12
huanxuanstevemar: so we are going to add manange and unmanage commands now, right?14:13
stevemarhuanxuan: not now, whenever :P14:13
dtroyerthe cases where matching stable OSC to a cloud release are usually due to distributions that can not co-install multiple python bits from different releases due to dependency conflicts14:13
huanxuanstevemar: OK, get it! :)14:13
dtroyerRuiChen: so what specifically is blocking your use of the current OSc releases?14:14
RuiChenour user confused about why some osc commands raise error in stable openstack, they don't know openstack too much14:16
RuiCheni means latest osc run against old version openstack cloud14:17
dtroyerare those due to differences in the API or due to deployment choices?14:18
RuiChenand the dependency conflicts is other reason too14:18
RuiChenfor example, that SSL bug, we deploy all openstack services in SSL14:19
dtroyerand I agree that is one that probably should be backported14:19
dtroyercan you prepare that one for a backport?14:20
RuiChenthank you, I will14:20
RuiChenI saw the backport patch is abandoned, so ask these14:21
dtroyerfortunately, stable releases will not be stuck in our upcoming freeze so there is not a time pressure from our side for that14:22
RuiChen\o/, I will prepare the patch14:23
RuiChenjust make sure, will we release a stable osc version for it?14:23
dtroyeryes14:24
RuiChenthank you :)14:24
*** amotoki has quit IRC14:24
*** amotoki has joined #openstack-sdks14:29
*** jiahui has quit IRC14:30
* RuiChen go home, good night :)14:30
*** amotoki has quit IRC14:31
stevemarRuiChen: thanks for your help with osc :)14:32
*** amotoki has joined #openstack-sdks14:33
dtroyerhuanxuan: that image test is still racy, failed py35 but passed py2714:33
huanxuandtroyer: yes, I saw it14:33
dtroyerI'm having a hard time reproducing it locally, can you?14:33
*** cdent has quit IRC14:34
huanxuandtroyer: I am working on it14:34
dtroyerI am wondering if we need to reset the mock inside the for loop14:35
dtroyerwell, reset is at the bottom, I mean re-initialize it14:35
huanxuandtroyer: re-initialize?14:37
dtroyermove lines 855-857 below 85914:38
*** salv-orlando has joined #openstack-sdks14:39
huanxuandtroyer: Oh! get your point!14:40
*** salv-orlando has quit IRC14:41
*** salv-orlando has joined #openstack-sdks14:41
dtroyerstevemar, huanxuan: https://review.openstack.org/#/c/419461/ looks ready to go14:43
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test  https://review.openstack.org/41944514:43
huanxuandtroyer: +A14:44
*** jiahui has joined #openstack-sdks14:50
*** hongbin has joined #openstack-sdks14:59
*** lucasagomes has quit IRC14:59
*** lucasagomes has joined #openstack-sdks15:00
*** lamt has quit IRC15:02
*** chlong has joined #openstack-sdks15:03
*** lamt has joined #openstack-sdks15:03
*** cleong has joined #openstack-sdks15:04
*** amotoki has quit IRC15:05
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test  https://review.openstack.org/41944515:06
*** sheel has quit IRC15:07
stevemardtroyer: i dont understand the if statements in the tests15:08
reedipralonsoh : hehe, gate did it :D15:08
*** jiahui has quit IRC15:10
dtroyerstevemar: Where?  are you talking about test_image_set_membership_option()?15:11
stevemardtroyer: commented15:11
stevemarhttps://review.openstack.org/#/c/419461/115:11
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test  https://review.openstack.org/41944515:14
dtroyerok… ugh, more parallel testing side effects maybe?15:14
stevemardtroyer: rebased https://review.openstack.org/#/c/419445/4 on top of the qos fix15:14
stevemardtroyer: yeah, i was wondering if we're just opening ourselves up to more racey tests15:15
dtroyertotally.  am I off base for just wanting unrolled multiple tests that don't try to share too much?15:16
dtroyermy gut says the for loop in the image test is part of our pain15:17
dtroyertoo15:17
dtroyerI'm going to do an unroll of the qos tests and see how bad it looks15:18
dtroyeralthough not gettgin them to fail locally makes it hard to prove it is worth the effort15:18
openstackgerritReedip proposed openstack/python-openstackclient: Fix quota show output  https://review.openstack.org/41906715:20
stevemarhehe15:20
dtroyerso I'm going to go find it, but I had to do a lot of deepcopy() in the past to avoid this sort of thing with shared mock return values, I think we've forgotten that15:21
*** reedip_outofmemo has joined #openstack-sdks15:22
huanxuandtroyer: failed again :(15:25
*** markvoelker has quit IRC15:27
dtroyerso I'm trying a simple unrolling of that loop and making it into 3 tests15:40
*** reedip_outofmemo has quit IRC15:41
openstackgerritDean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures  https://review.openstack.org/41952815:43
dtroyerlet's see what that does ^^^15:43
huanxuandtroyer: good idea, thank you!15:45
huanxuanI am also trying in other ways15:47
etoewscdent elmiko edleafe i have a conflicting meeting today and won't be able to attend the api wg meeting15:48
* edleafe cues up a series of Canadian jokes since etoews won't be there15:48
etoewsedleafe: you hoser15:49
edleafe:)15:49
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test  https://review.openstack.org/41944515:49
openstackgerritEd Leafe proposed openstack/api-wg: Add guidelines for boolean names  https://review.openstack.org/41152915:49
elmikoedleafe: ack15:52
elmikoer etoews lol15:52
*** markvoelker has joined #openstack-sdks15:52
edleafeelmiko: that's ok. etoews and I are practically indistinguishable15:52
elmikohehe =)15:53
mordrededleafe: when is the api wg meeting?15:55
edleafemordred: 5 minutes15:56
*** cdent has joined #openstack-sdks15:56
edleafemordred: in #openstack-meeting-315:56
mordrededleafe: neat15:57
openstackgerritMerged openstack/python-openstackclient: Fix Network QoS rule CLI attrs parsing  https://review.openstack.org/41946116:02
waj334dtroyer: What's the verdict on this patch? https://review.openstack.org/#/c/412614/16:07
stevemarwaj334: probably wait til after client freeze to push that one16:09
stevemarwaj334: meaning it won't go into "ocata"16:09
stevemarwaj334: we made the call at the last osc meeting i believe16:09
dtroyerwaj334: nothing really, we're just not ready to merge it yet right before we do the stable release in a week or two.  I don't think there is any advantage to having a very incomplete v3 in stable that will never get brought up to spec16:09
waj334Cool. I was just following up16:10
*** rtheis has quit IRC16:10
waj334I'm gonna proceed with the implementation of Cinder v3.3 (implements messages api) and maybe I'll be able to tackle this microversion problem16:12
dtroyerwaj334: cool.  I think it is safe to use 412614 as the base for that now16:12
*** reedip_outofmemo has joined #openstack-sdks16:13
stevemarwaj334: dtroyer not sure if you guys saw this, but diana_clarke pushed https://review.openstack.org/#/c/419108/ which starts microversion support for nova stuff16:14
stevemarmriedem was saying they'll be looking at it in pike, i think16:14
dtroyersaw but have not really read it yet16:14
waj334stevemar: It doesn't seem to do much of anything16:16
mordreddtroyer, stevemar: do we have any time at the PTG that we can sit down together and talk through / work through where we want the osc/occ config ownership and handoff to be? I think we keep wanting to talk about it and never quite getting to it ...16:18
*** ankur-gupta-f1 has joined #openstack-sdks16:19
*** annegentle has joined #openstack-sdks16:19
dtroyermordred: we have a room mon/tues, it's just a matter of arranging the schedule16:19
mordreddtroyer: woot16:20
openstackgerritPavlo Shchelokovskyy proposed openstack/python-openstackclient: Fix flavor create help re swap size units  https://review.openstack.org/41954916:21
*** salv-orl_ has joined #openstack-sdks16:23
openstackgerritDean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures  https://review.openstack.org/41952816:23
*** salv-orlando has quit IRC16:26
waj334The microversion issue is gonna be a bigger problem than I thought. Any ideas on how to handle 2 versions of the same function, but with different parameters? lol16:27
waj334* not so lol *16:27
openstackgerritPavlo Shchelokovskyy proposed openstack/python-openstackclient: Fix flavor create help re swap size units  https://review.openstack.org/41954916:28
dtroyerwaj334: we've talked about a couple of strategies for handling those.  #1 is user-breaking changes are bad and we have to abide by semver at the CLI level so if you're talking about CLi-visible differences we need to consider that and time it properly16:29
dtroyermost of what we've talked about though is handling the differences internally, which is basically writing multiple versions and branching as required.  No magic, copying code is not bad here16:30
*** reedip_outofmemo has quit IRC16:34
waj334dtroyer: So, with the messages api in Cinder v3.3 and v3.5 I'll end up with 2 separate files is what you're saying? Like messages_3_3.py, messages_3_5.py? Or, just different versions of various methods, just named slightly different?16:36
waj334I may be overthinking this16:39
*** fzdarsky has quit IRC16:39
dtroyerwe only split fies by major version so far, I suppose if it's a huge change that might be easier, but there is no mechanism to handle minor version changes at the stevedore/entry-point level16:41
dtroyerso we'll still wind up with a common entry point.16:42
dtroyermy thinking is of a microversion is so different that it's a total re-work, then something went wrong somewhere16:42
waj334Well, luckily what I'm seeing in this messages api is where optional params were added in v3.5 so that's easier to deal with. How important is maintaining consistency of command parameters if they are allowed to change between versions?16:46
*** Serlex has joined #openstack-sdks16:46
SerlexHi, can someone post an example of "add_gateway_to_router(router, **body)" cheers16:47
openstackgerritDean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures  https://review.openstack.org/41952816:50
*** chlong has quit IRC16:52
*** e0ne has quit IRC16:55
waj334dtroyer: Would it be wise to check the client version first before adding arguments? That way I could set up the command properly for that specific microversion by just a few if statements.16:56
waj334Provided that I know about the client before commands are set up that is16:56
dtroyerwe don't do version discovery until the very last minute, ie the first actual API call to the service.  So we'll only know the specific API version if the user has specified it.16:59
dtroyerotherwise we have to make multiple calls (auth, discovery) to even build help16:59
dtroyerfor that, and the fact that we don't want incompatible changes to begin with, we should go to a good bit of work internally to not expose unnecessary changes to the user17:00
* cdent shakes tiny itching powder fist at elmiko 17:01
elmikoLOL17:01
waj334It seems that I'm defeated17:06
*** sheel has joined #openstack-sdks17:10
*** ralonsoh_ has quit IRC17:13
stevemarmordred: handoff? you ditching occ and leaving it on our laps? :)17:13
Serlexsooo17:14
stevemarSerlex: you're using openstacksdk?17:15
Serlexyes17:16
SerlexI want to add external network to a router17:16
Serlex"add_gateway_to_router(router, **body)", got my router...how do I apply the body bit17:16
stevemarSerlex: -- briancurtin huanxuan or reedip might be able to help you out, i'm not familiar with that command and my googling hasn't turned up anything17:17
briancurtinSerlex: apply the body bit?17:18
cdentelmiko, edleafe I forgot to mention I can't run the meeting next week, can one of you?17:21
elmikocdent: i should be able to17:22
elmikoi'll be out the following week though17:22
briancurtinSerlex: i don’t see that in the neutron API docs so i don’t know what’s expected there. hopefully someone who worked on it is in here because as usual things are undocumented17:22
cdentcool, thanks, it's the last day my parents are in country17:22
elmikoooh nice, say hi for me =)17:22
edleafecdent: elmiko: I'll be around too17:24
Serlexbriancurtin: thanks, complete noob, hoping example will set me off17:24
elmikoedleafe: cool17:25
stevemarSerlex: briancurtin sounds like it's this API? http://developer.openstack.org/api-ref/networking/v2/?expanded=add-interface-to-router-detail#add-interface-to-router17:25
briancurtinSerlex: looking at https://github.com/openstack/python-openstacksdk/blob/master/openstack/tests/unit/network/v2/test_router.py#L177 you would just pass kwargs that correspond with what’s expected by the server. they pass network_id=3, enable_snat=True there17:25
dtroyerstevemar: my hacky-test for the image bits passed unit tests: https://review.openstack.org/419528   want to go with that (unrolled 1 test into 3) or shall I fix up huanxuan's?   I know what bit we both missed the first time thought, just not why it is inconsistent17:25
stevemarbriancurtin: Serlex sounds like you need to pass one of subnet_id or port_id as kwargs17:25
briancurtinSerlex: it might be similar but it’s not the same. the method you asked about isn’t listed there in the API docs17:26
cdentedleafe, elmiko: proof please: https://etherpad.openstack.org/p/api-wg-newsletter17:26
briancurtinit’s an interface-to-router not gateway-to-router17:26
*** chlong has joined #openstack-sdks17:26
* elmiko looks17:26
Serlexok thanks17:27
Serlexthis what I was looking at http://developer.openstack.org/sdks/python/openstacksdk/users/proxies/network.html17:27
elmikocdent: +1 from me17:27
edleafecdent: looks good, except I'm not sure how moral my support can be :)17:29
* cdent makes a slight adjustment17:30
cdenthow's that edleafe ?17:30
edleafeheehee17:31
edleafeI think the earlier version would be clearer to the masses17:31
elmikolol17:31
* cdent is a lattel sipping elitist17:34
cdentdamn17:34
cdenthoisted on my typos, again and again17:34
* cdent ships it17:34
*** gouthamr has quit IRC17:35
ankur-gupta-f1dtroyer: stevemar: link for todays meetings agenda etherpad?17:37
dtroyerankur-gupta-f1: the etherpad is at https://etherpad.openstack.org/p/osc-weekly-meeting, but the meeting was a few hours ago…it an even week17:41
ankur-gupta-f1well shit. k thanks17:41
*** gouthamr has joined #openstack-sdks17:49
*** lucasagomes is now known as lucas-afk17:50
*** Serlex has quit IRC18:03
*** chlong has quit IRC18:19
*** chlong has joined #openstack-sdks18:32
*** openstackgerrit has quit IRC18:33
*** kevo has joined #openstack-sdks18:45
mordredstevemar: oh good golly no - I mean working through a plan for dealing with the duplication of concerns between osc and occ that we're all happy with18:46
*** fguillot has joined #openstack-sdks18:47
mordredcdent, johnthetubaguy sorry I missed the second half of the api meeting - had to run to the airport18:53
cdentas ya do18:53
mordredcdent: in answer to your question, the sorts of things that would be useful from an occ/shade perspective as discoverable capabilities are the "Does this cloud support volume deletion" sorts of things18:54
cdentwhat about "does this volume right here support deletion"?18:55
mordredthat's maybe useful, but less urgent than the first thing18:55
mordreda better direct example is things like "this cloud requires floating ips for external access"18:56
cdentthat sounds more like a warning than capabilities discovery18:56
mordredor "this cloud requires v2 tasks for image uploads"  - or "this cloud requires images to be in VHD format"18:56
mordredcdent: maybe I should phrase that differently...18:57
stevemardtroyer: let go with https://review.openstack.org/#/c/419528/3 instead, ship it!18:57
mordred"this cloud supports floating ips" "this cloud supports direct attached public ips" "this cloud supports ipv6" "this cloud supports uploading image via PUT" - all of which are deployment choices18:58
cdentI think your phrasing is pretty important because it represents one of the differences in the ways people are describing capabilities18:58
stevemardtroyer: huanxuan is fast asleep :)18:58
dtroyerstevemar: shipped18:58
stevemardtroyer: woo hoo18:58
mordredcdent: let me compile you a list of the things we either do a lot of work to figure out / infer or have to punt to config files18:59
dtroyerstevemar: so my inability to successfully get a neutron devstack running again has borked my attempt to validate https://review.openstack.org/418650 with sdk 0.9.12.  it sez devstack installed it, but the functional log sez 0.9.1018:59
cdentmordred: if you wanna do it right on the review that would be awesome: https://review.openstack.org/#/c/386555/19:00
stevemardtroyer: hehe19:00
mordredcdent: will do!19:00
dtroyerfwiw, amazon will deliver my solution to the devstack VM problem Saturday…19:00
stevemardtroyer: let the CI do it19:00
cdentmordred: awesome thanks19:00
stevemardtroyer: new laptop or workstation?19:00
dtroyercdent: what mordred sez +++19:00
mordreddtroyer: does AWS provide devstack as a service now?19:00
stevemarmordred: i was going to go there lol19:00
dtroyermordred: via NUC, yes19:00
dtroyeron-premises19:01
dtroyerunfortunately, it isn't going to run OpenStack19:01
mordreddtroyer: mmm. devstack-nuc on-prem19:01
dtroyerI'm going to go back to Ganeti for lightweight VM management19:01
dtroyerit just always works19:01
* mordred just uses public clouds19:01
* dtroyer is tired of fighting it…19:02
dtroyerso if I could ask nodepool for a VM to use ad-hoc...19:02
dtroyerNodepool-as-a-service?19:02
dtroyerbut of course, running in my account19:02
cdentthat would be rather handy19:03
stevemardtroyer: that would be nice indeed19:08
*** john-davidge has quit IRC19:11
mordreddtroyer: that will be easy with nodepool v319:15
*** openstackgerrit has joined #openstack-sdks19:16
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: unskip network qos rule type functional test  https://review.openstack.org/41912919:16
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12  https://review.openstack.org/41865019:17
stevemardtroyer: i scaffolded the patches ^19:18
openstackgerritMerged openstack/python-openstackclient: Fix flavor create help re swap size units  https://review.openstack.org/41954919:19
stevemardtroyer: do we need https://review.openstack.org/#/c/419067/ too?19:20
*** john-davidge has joined #openstack-sdks19:26
stevemardtroyer: https://review.openstack.org/#/c/376056/ would have been nice to include too19:32
stevemarbut needs tests19:32
*** chlong has quit IRC19:41
*** lucas-afk has quit IRC19:41
*** lucasagomes has joined #openstack-sdks19:44
*** abhiraut has joined #openstack-sdks19:48
*** e0ne has joined #openstack-sdks19:54
*** salv-orl_ has quit IRC19:54
openstackgerritMerged openstack/python-openstackclient: Fix image member unit tests occasional failures  https://review.openstack.org/41952819:54
sshank_dtroyer, stevemar Will functional tests at gates be done with SDK 0.9.11 anytime soon?19:56
*** chlong has joined #openstack-sdks19:56
*** e0ne has quit IRC19:59
*** salv-orlando has joined #openstack-sdks20:01
*** e0ne has joined #openstack-sdks20:02
mordredstevemar: ^^ do we have an osc gate job that does master of sdk (preferrably one we could have sdk also gate on?)20:06
openstackgerritJustin A Wilson proposed openstack/python-openstackclient: Add Versioned Method Support To Openstack Client  https://review.openstack.org/41963320:08
-openstackstatus- NOTICE: Gerrit will be offline between now and 20:30 for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html20:09
*** ChanServ changes topic to "Gerrit will be offline between now and 20:30 for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html"20:09
*** e0ne has quit IRC20:26
*** john-davidge has quit IRC20:30
*** john-davidge has joined #openstack-sdks20:30
-openstackstatus- NOTICE: Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated): http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html20:34
*** ChanServ changes topic to "Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated): http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html"20:34
*** john-davidge has quit IRC20:35
dtroyerwhelp, I managed to make lunch last waaaay to long and into the Gerrit maintenance20:44
*** chlong has quit IRC20:44
dtroyeror maybe missed it altogether?20:44
*** e0ne has joined #openstack-sdks20:48
dtroyermordred: stevemar added just such a job in https://review.openstack.org/#/c/419047/ that appears to need some attention20:48
*** adriant has joined #openstack-sdks20:51
*** d0ugal has quit IRC20:52
openstackgerritAnindita Das proposed openstack/python-openstackclient: OSC Network Flavor  https://review.openstack.org/38253020:53
*** ChanServ changes topic to "#openstack-sdks"20:54
stevemarmordred: dtroyer aye, i just added the patch yesterday20:54
*** d0ugal has joined #openstack-sdks20:54
*** d0ugal has quit IRC20:54
*** d0ugal has joined #openstack-sdks20:54
dtroyerit has a typo, I'm fixing...20:54
stevemardtroyer: *shakes fist*20:55
*** chlong has joined #openstack-sdks20:58
stevemardtroyer: s/devm/dsvm :)20:59
dtroyeryup…21:00
*** david-lyle has quit IRC21:01
*** david-lyle has joined #openstack-sdks21:02
stevemardtroyer: fixed :)21:03
*** d0ugal has quit IRC21:03
*** chlong has quit IRC21:04
*** e0ne has quit IRC21:06
dtroyerstevemar: look in the console log of http://logs.openstack.org/50/418650/5/check/gate-osc-dsvm-functional-ubuntu-xenial/849d8e6/, it shows openstacksdk 0.9.10 installed even though you have removed the blacklist and DevStac installed 0.9.12 for it's use.21:08
dtroyerthis is what I was trying to check out this morning…why didn't it (tox?) pick up the right version?  does it pull requirements from not-the-repo when it builds the venv?21:09
stevemardtroyer: i was looking at http://logs.openstack.org/50/418650/5/check/gate-osc-dsvm-functional-ubuntu-xenial/849d8e6/logs/pip2-freeze.txt.gz21:10
stevemardtroyer: hmm, but yours ran just before the functional test, dammit21:10
dtroyerthat's from the devstack run I think21:10
dtroyerthe code-under-test is in the functional venv, not the devstack install21:11
stevemarright21:12
dtroyerI think we'll need the recently mentioned and fixed master job to really test this before we remove the blacklist21:12
stevemarwe can do a quick "pip install --upgrade" in the tox file?21:12
stevemaror that21:12
dtroyeror in the hook shell script21:12
dtroyersure, that way we don't have to wait21:12
dtroyerjust copy over the new one for that run?21:12
dtroyerit is a good sign that the devstack stuff works with 0.9.12...21:13
openstackgerritMerged openstack/fairy-slipper: Retire fairy-slipper API doc tools project  https://review.openstack.org/41768321:13
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12  https://review.openstack.org/41865021:15
stevemardtroyer: tossed up something21:16
stevemardtroyer: i'll probably be afk for the next two week regarding oSC stuff21:17
stevemargotta shape up keystone21:17
dtroyerouch… good to know21:17
stevemardtroyer: well i finalized all keystone libraries and stable branches this week21:17
stevemarso its strictly feature work next week and after21:17
*** chlong has joined #openstack-sdks21:18
*** openstackgerrit has quit IRC21:18
*** john-davidge has joined #openstack-sdks21:31
*** john-davidge has quit IRC21:35
*** fguillot has quit IRC21:44
*** sheel has quit IRC21:47
mordredstevemar: woot21:53
stevemarmordred: if you want to review: https://review.openstack.org/#/c/419047/21:54
*** cleong has quit IRC21:55
mordredstevemar: on it - I'm thinking maybe I should add a similar one for shade21:55
mordred(I mean, I have a shade one that uses master libs - but it doesn't include sdk in the list of libs it does from master)21:56
stevemarmordred: for os-client-config?21:56
stevemarah21:56
mordredstevemar: SOOO ... I don;'t think that's going to do what you want21:56
dtroyeris shade using the sdk?21:56
stevemarmordred: oh?21:57
mordreddtroyer: nope. it's indirect through the osc setup - so actually, your new job for osc here should protect us I think21:57
mordredstevemar: I mean, it will install those things from master - but I'm pretty sure it will do so in a way that will not allow depends-on to work21:58
mordredstevemar: lemme link you to example21:58
stevemarruh roh21:59
mordredstevemar: http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/shade.yaml#n172 ... I believe you need to include the repos in PROJECTS and pass them in to LIBS_FROM_GIT. we should double check with someone smarter like clarkb though22:00
*** amotoki has joined #openstack-sdks22:01
dtroyermordred: that'll get the right thing installed for the DevStack run, functioanl tests run inside their own venv, no?22:02
*** annegentle has quit IRC22:02
mordreddtroyer: oh. wow. yeah. you are smarter than me. in fact, I think the _shade_ test isn't doing what I think it should :)22:04
dtroyerI happen to have spent more minutes than I care to admit sussing that out this morning so it is still in L2 cache22:06
stevemarmordred: hehe, i copied it from oslo people, they are smart22:06
dtroyerstevemar: has the correct answer :)22:07
*** d0ugal has joined #openstack-sdks22:07
stevemari hear theres a smart guy named doug there22:07
mordredI mean - I still think we need the important repos in PROJECTS to get depends-on - but the install strategy is definitely right22:09
stevemardtroyer: test is runing with 0.9.12: http://paste.openstack.org/show/594778/22:10
dtroyerI suspect doing both is not a bad strategy, for OSC anyway22:10
dtroyer\o/22:10
stevemarmy zaney pip approach worked22:10
*** openstackgerrit has joined #openstack-sdks22:10
openstackgerritDean Troyer proposed openstack/python-openstackclient: Fix quota show output  https://review.openstack.org/41906722:10
stevemardtroyer: ruh roh22:11
stevemar2017-01-12 22:11:38.545189 | 2017-01-12 22:11:38.544 | {2} openstackclient.tests.functional.network.v2.test_floating_ip.FloatingIpTests.test_floating_ip_delete [10.191858s] ... FAILED22:11
stevemar2017-01-12 22:11:54.238611 | 2017-01-12 22:11:54.238 | {2} openstackclient.tests.functional.network.v2.test_floating_ip.FloatingIpTests.test_floating_ip_list [15.702999s] ... FAILED22:12
stevemarand network agent, dammit22:12
* stevemar is literally watching the test results scroll by22:12
mordredstevemar: you love telnet22:13
stevemarmordred: don't judge my love22:13
stevemar:)22:13
mordredI think your love is beautiful22:13
openstackgerritMonty Taylor proposed openstack/python-openstackclient: Install from /opt/stack/new instead of git.o.o  https://review.openstack.org/41967022:16
*** john-davidge has joined #openstack-sdks22:21
mordredstevemar: left comment on the project-config patch - I think the one above ^^ is also needed22:21
*** salv-orl_ has joined #openstack-sdks22:23
*** salv-orlando has quit IRC22:25
*** annegentle has joined #openstack-sdks22:26
*** chlong has quit IRC22:29
*** john-davidge has quit IRC22:33
*** john-davidge has joined #openstack-sdks22:33
*** chlong has joined #openstack-sdks22:37
*** john-davidge has quit IRC22:38
*** annegentle has quit IRC22:40
*** annegentle has joined #openstack-sdks22:59
*** elmiko is now known as _elmiko23:36
adriantI seem to be getting a devstack failure because of this: http://paste.openstack.org/show/594785/23:43
adriantis this a known problem? Or something I can fix?23:43
openstackgerritMerged openstack/python-openstackclient: unskip network qos rule type functional test  https://review.openstack.org/41912923:44
adriantClean VM ubuntu 14.04 vm, mitaka devstack.23:44
adriantI can't find anything special that I'm doing differently, and I've been able to build devstack for months just fine. :(23:45
dtroyeradriant: what are the versions of python-openstackclient, python-openstacksdk, and os-client-config?23:46
*** annegentle has quit IRC23:46
adriantI'll do a pip freeze and check23:46
adrianthttp://paste.openstack.org/show/594786/23:47
adriantopenstacksdk==0.8.1, python-openstackclient==2.3.023:47
adriantthis is what devstack at "stable/mitaka" is installing23:48
adriantos-client-config==1.16.023:48
*** salv-orl_ has quit IRC23:48
dtroyerwhere is that traceback coming from?  is this the first osc comamnd being run?23:52
adriantfrom running stack.sh23:52
adriantit's from just before the build exited23:52
dtroyerso the cloud is up?23:52
adriantnope23:52
dtroyerwhat is the osc command?23:53
adriantwell... sec23:53
adriantit's the image uploading23:53
adriantso yes the cloud probably is up in some basic capacity.23:53
dtroyerI'm wondering about the sdk version, and why it fails now23:54
dtroyerwe only use the SDK for network commands, even today, so it has to be related to that somehow23:54
adrianthmmm23:55
adriantno the devstack build is nowhere near done23:55
adriantit died in the service setup stages for glance it seems.23:55
dtroyerbut if even just keystone is running osc is functioning at some level23:55
*** lamt has quit IRC23:55
adriantI'll reinstall OSC with a later version23:55
adriantand try talking to at elast keystone23:55
adriantI can possibly install OSC myself, and then run devstack23:56
dtroyeryou'll get dependency conflicts if you don't put it into a venv23:56
*** cdent has quit IRC23:57
dtroyerthe traceback indicates an assumption about the sdk, I have no idea when openstack.__verion__ was added (or removed)23:57
adriantWould you build a devstack for mitaka of your own and see if you get the same issue?23:58
adriantI'm vaguely curious if this is somewhat ubuntu related.23:58
dtroyermaybe tomorrow.  my devstack vm resources are tied up with neutron-related build failures right now23:58
adriantand can talk to keystone with newer version of OSC23:59
dtroyercurrent OSc should be able to do everything you need, except install in the same system as a running mitaka devstack23:59
adriantchecking as to what is actually in the catalog now23:59
*** huanxuan has quit IRC23:59
adriantOh yeah, I assume as much, my problem is that devstack itself is failing to finish23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!