Wednesday, 2016-06-15

« Tuesday, 2016-06-14 Index Thursday, 2016-06-16 »
*** hieulq has quit IRC00:08
openstackgerritMerged openstack/python-openstackclient: Standardize logger usage in volume  https://review.openstack.org/32625700:09
*** shu-mutou has joined #openstack-sdks00:15
openstackgerritMerged openstack/python-openstackclient: Add geneve provider network type  https://review.openstack.org/32847000:41
*** zhurong has joined #openstack-sdks01:06
*** aohuanxuan has joined #openstack-sdks01:33
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Support bulk deletion for commands that exist in both network and compute.  https://review.openstack.org/32868901:55
*** aohuanxuan has quit IRC02:16
*** RuiChen has joined #openstack-sdks02:18
*** coolsvap has joined #openstack-sdks02:18
*** yanyanhu has joined #openstack-sdks02:29
*** hieulq has joined #openstack-sdks02:32
*** aohuanxuan has joined #openstack-sdks02:43
openstackgerritQiming Teng proposed openstack/python-openstacksdk: Relocate alarm service into a submodule  https://review.openstack.org/22668902:46
*** yuanying has quit IRC02:50
*** yuanying has joined #openstack-sdks02:53
*** zhurong has quit IRC02:56
*** zhurong has joined #openstack-sdks02:56
*** Klumben has quit IRC03:01
*** aohuanxuan has quit IRC03:23
*** erlon has quit IRC03:26
*** sheel has joined #openstack-sdks03:34
*** Klumben has joined #openstack-sdks03:35
*** yuanying_ has joined #openstack-sdks03:48
*** yuanying has quit IRC03:49
*** gouthamr has quit IRC04:34
*** aohuanxuan has joined #openstack-sdks04:45
*** salv-orl_ has quit IRC04:54
*** salv-orlando has joined #openstack-sdks04:54
*** jaosorior has joined #openstack-sdks05:04
*** salv-orlando has quit IRC05:17
*** salv-orlando has joined #openstack-sdks05:17
*** salv-orl_ has joined #openstack-sdks05:29
*** salv-orlando has quit IRC05:32
*** coolsvap has quit IRC05:57
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Fix help messages for ip availability  https://review.openstack.org/32977106:02
*** yuanying has joined #openstack-sdks06:03
*** yuanying_ has quit IRC06:05
*** coolsvap has joined #openstack-sdks06:10
*** openstackgerrit has quit IRC06:18
*** openstackgerrit has joined #openstack-sdks06:18
*** yuanying has quit IRC06:21
*** salv-orlando has joined #openstack-sdks06:24
*** yuanying has joined #openstack-sdks06:28
*** salv-orl_ has quit IRC06:28
*** salv-orlando has quit IRC06:29
openstackgerritReedip proposed openstack/python-openstackclient: Add option to unset information from Routers  https://review.openstack.org/30567806:44
*** e0ne has joined #openstack-sdks06:51
*** zhurong has quit IRC06:58
*** fzdarsky has joined #openstack-sdks07:03
*** yuanying has quit IRC07:05
*** yuanying has joined #openstack-sdks07:08
*** zhurong has joined #openstack-sdks07:11
openstackgerritAlvaro Lopez Garcia proposed openstack/python-openstackclient: Refactor check_valid_auth_options function  https://review.openstack.org/31820107:19
*** dhellmann has quit IRC07:20
*** dhellmann has joined #openstack-sdks07:20
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add "--project" option to the "flavor create" command.  https://review.openstack.org/32979007:27
*** openstackgerrit has quit IRC07:33
*** openstackgerrit has joined #openstack-sdks07:33
*** amotoki has joined #openstack-sdks07:37
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add "--project" option to the "flavor create" command.  https://review.openstack.org/32979007:37
*** salv-orlando has joined #openstack-sdks07:41
*** jaosorior is now known as jaosorior_brb07:53
openstackgerritTang Chen proposed openstack/python-openstackclient: Add doc for logger usage  https://review.openstack.org/32980907:59
*** shu-mutou is now known as shu-mutou-AFK08:15
*** kromanenko__ has joined #openstack-sdks08:16
*** kromanenko has joined #openstack-sdks08:16
*** jaosorior_brb has quit IRC08:40
*** jaosorior_brb has joined #openstack-sdks08:41
*** jaosorior_brb is now known as jaosorior08:41
*** jaosorior has quit IRC08:57
*** fzdarsky has quit IRC09:02
*** fzdarsky has joined #openstack-sdks09:04
*** jaosorior has joined #openstack-sdks09:21
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Support bulk deletion for commands that exist in both network and compute.  https://review.openstack.org/32868909:23
openstackgerritTang Chen proposed openstack/python-openstackclient: Transfer "ip floating add/remove" to "server add/remove  floating ip"  https://review.openstack.org/30250809:37
openstackgerritTang Chen proposed openstack/python-openstackclient: Transfer "ip floating pool list" to "floating ip pool list"  https://review.openstack.org/30038809:37
openstackgerritTang Chen proposed openstack/python-openstackclient: Transfer "ip fixed add/remove" to "server add/remove fixed ip"  https://review.openstack.org/30259009:37
openstackgerritTang Chen proposed openstack/python-openstackclient: Transfer "ip floating CRUD" to "floating ip CRUD"  https://review.openstack.org/30268709:37
*** cdent has joined #openstack-sdks09:41
*** salv-orlando has quit IRC09:47
*** salv-orlando has joined #openstack-sdks09:48
*** zhurong has quit IRC10:00
reediptangchen10:09
reediptangchen: is osc_lib already in production?10:09
tangchenreedip: Er...well, I'm not sure if it has been used in any production, but OSC10:12
tangchenOSC is now using it.10:12
tangchenreedip: osc_lib is just some common code moved from OSC.10:13
reedipOkay, because I cannot find it it seems :(10:13
reedipNeed some review help ... if you have time10:13
tangchenreedip: Sure. But not tonight. Will do it tomorrow. Please add me as a reviewer. :)10:14
openstackgerritReedip proposed openstack/python-openstackclient: Add option to unset information from Routers  https://review.openstack.org/30567810:16
reedipYou are already a reviewer10:16
reedip:)10:16
reedipSure , no problem10:16
tangchenreedip: OK :)10:17
openstackgerritReedip proposed openstack/python-openstackclient: Add option to unset information from ports  https://review.openstack.org/30253010:18
*** yanyanhu has quit IRC10:23
*** betheynyx has joined #openstack-sdks10:29
*** cdent has quit IRC10:43
*** sdague has joined #openstack-sdks10:52
*** salv-orlando has quit IRC10:56
*** salv-orlando has joined #openstack-sdks10:57
tangchenreedip: Review done. Just some little problems that are easy to fix. :)11:01
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add default IP version and fix help messages for "ip availability list"  https://review.openstack.org/32977111:05
reedipthanks tangchen11:05
*** salv-orlando has quit IRC11:06
*** cdent has joined #openstack-sdks11:17
*** thrash|g0ne is now known as thrash11:19
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add default IP version and fix help messages for "ip availability list"  https://review.openstack.org/32977111:24
*** rtheis has joined #openstack-sdks11:29
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add default IP version and fix help messages for "ip availability list"  https://review.openstack.org/32977111:33
openstackgerritTang Chen proposed openstack/python-openstackclient: Setup deprecate msg for command.py  https://review.openstack.org/32988511:41
*** zhurong has joined #openstack-sdks11:46
openstackgerritSrushti Gadadare proposed openstack/cliff: Fix logging and piping unicode multi-bytes characters issue  https://review.openstack.org/32988711:47
*** fzdarsky has quit IRC11:58
*** e0ne has quit IRC12:01
*** e0ne has joined #openstack-sdks12:02
*** zhurong has quit IRC12:09
*** zhurong has joined #openstack-sdks12:10
*** erlon has joined #openstack-sdks12:13
openstackgerritTang Chen proposed openstack/python-openstackclient: Trivial: Fix incorrect import order in volume  https://review.openstack.org/32990012:14
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add "--project" option to the "flavor create" command.  https://review.openstack.org/32979012:16
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add default IP version and fix help messages for "ip availability list"  https://review.openstack.org/32977112:33
*** aohuanxuan has quit IRC12:34
*** fzdarsky has joined #openstack-sdks12:42
*** edmondsw has joined #openstack-sdks12:43
*** salv-orlando has joined #openstack-sdks12:56
*** salv-orlando has quit IRC12:56
*** salv-orlando has joined #openstack-sdks12:56
*** fzdarsky has quit IRC12:58
openstackgerritMichael Krotscheck proposed openstack/js-openstack-lib: Added .eslintignore  https://review.openstack.org/32991113:04
openstackgerritMichael Krotscheck proposed openstack/js-openstack-lib: Moved eslint dependencies into devDependencies.  https://review.openstack.org/32991213:04
*** gouthamr has joined #openstack-sdks13:09
*** cdent has quit IRC13:15
openstackgerritMichael Krotscheck proposed openstack/js-openstack-lib: Moved eslint dependencies into devDependencies.  https://review.openstack.org/32991213:19
openstackgerritMichael Krotscheck proposed openstack/js-openstack-lib: Added nsp to prepublish check  https://review.openstack.org/32992113:19
*** michaelgugino has joined #openstack-sdks13:24
openstackgerritAlvaro Lopez Garcia proposed openstack/python-openstackclient: Refactor setting defaults for some scope parameters  https://review.openstack.org/32203213:28
openstackgerritMichael Krotscheck proposed openstack/js-openstack-lib: Added gulpfile  https://review.openstack.org/32992613:29
stevemarreedip: tangchen not ready for public consumption just yet :)13:35
stevemardtroyer: reedip: tangchen: we should move the last auth.py file out of the openstack module into osc_lib (https://github.com/openstack/osc-lib)13:37
dtroyerstevemar: yes, I want to do that when I re-work the auth bits13:38
*** coolsvap has quit IRC13:39
dtroyerI want to break some of that down, but need to get the current o-c-c into my head (it has grown a scary amount)13:39
stevemardtroyer: you could do an interen 0.2.0 release *shrugs*13:41
stevemarinterim*13:41
dtroyersure?  What is waiting on one other than the flavor thing I did?13:44
*** amotoki has quit IRC13:55
openstackgerritRichard Theis proposed openstack/python-openstackclient: Add "--device-owner" option to "port list"  https://review.openstack.org/32995113:56
*** singhj has joined #openstack-sdks13:59
*** zhurong_ has joined #openstack-sdks14:01
*** zhurong has quit IRC14:02
openstackgerritTang Chen proposed openstack/python-openstackclient: Setup deprecate msg for command.py  https://review.openstack.org/32988514:08
*** cdent has joined #openstack-sdks14:14
*** fzdarsky has joined #openstack-sdks14:17
*** sigmavirus24_awa is now known as sigmavirus2414:18
*** betheynyx has quit IRC14:34
*** zhurong_ has quit IRC14:54
openstackgerritAlvaro Lopez Garcia proposed openstack/keystoneauth: WIP: fix OpenID Connect authorization code grant_type  https://review.openstack.org/33000615:15
openstackgerritMerged openstack/python-openstackclient: Add default IP version and fix help messages for "ip availability list"  https://review.openstack.org/32977115:17
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Setup deprecate msg for command.py  https://review.openstack.org/32988515:24
openstackgerritSteve Martinelli proposed openstack/keystoneauth: Use SAML2 requests plugin  https://review.openstack.org/25505615:25
*** sheel has quit IRC15:25
*** coolsvap has joined #openstack-sdks15:31
*** Kevin_Zheng has quit IRC15:41
*** michaelgugino has quit IRC15:46
stevemarrtheis: mind double checking this one: https://review.openstack.org/#/c/328689/315:50
rtheisstevemar: sure, will do15:51
*** michaelgugino has joined #openstack-sdks16:00
*** krotscheck is now known as krotscheck_dcm16:09
*** jaosorior has quit IRC16:20
*** kromanenko__ has quit IRC16:26
*** kromanenko has quit IRC16:26
*** aimeeu has joined #openstack-sdks16:29
openstackgerritDolph Mathews proposed openstack/python-openstackclient: Do not prompt for scope options with default scoped tokens  https://review.openstack.org/33005716:31
openstackgerritMerged openstack/python-openstackclient: Support compute service force down/up  https://review.openstack.org/32580016:36
openstackgerritRichard Theis proposed openstack/python-openstackclient: Fix volume functional tests  https://review.openstack.org/33006716:41
*** michaelgugino has quit IRC16:45
openstackgerritMerged openstack/python-openstackclient: Support bulk deletion for commands that exist in both network and compute.  https://review.openstack.org/32868916:54
*** sheel has joined #openstack-sdks16:58
*** erlon has quit IRC17:00
*** erlon has joined #openstack-sdks17:01
*** singhj has quit IRC17:06
*** coolsvap has quit IRC17:11
*** singhj has joined #openstack-sdks17:14
*** fzdarsky is now known as fzdarsky|afk17:14
*** singhj has quit IRC17:18
*** malloc83 has quit IRC17:36
openstackgerritGhe Rivero proposed openstack/python-openstackclient: OS_DEFAULT_DOMAIN must be an ID  https://review.openstack.org/33012117:53
openstackgerritMerged openstack/python-openstackclient: Setup deprecate msg for command.py  https://review.openstack.org/32988517:53
stevemarrtheis: thanks for fixing the functional tests :)17:59
openstackgerritDolph Mathews proposed openstack/python-openstackclient: Do not prompt for scope options with default scoped tokens  https://review.openstack.org/33005717:59
rtheisstevemar:  yw17:59
stevemardhellmann: i just realized we should release a new cliff, https://github.com/openstack/cliff/compare/2.0.0...master18:01
stevemarwe had a few bug fixes land there related to max-width18:01
dhellmannstevemar : seems reasonable. there are some new features in there, too18:02
stevemardhellmann: i'll propose a new release, what's the new feature?18:03
dhellmanna new environment variable18:04
dhellmannc59f044 2016-05-08 13:43:36 +0200 Add CLIFF_MAX_TERM_WIDTH envvar to complement --max-width18:04
stevemaryeah, that's what i said "... there related to max-width" :P anyway: https://review.openstack.org/#/c/330126/18:09
dhellmann:-)18:14
stevemarrtheis: dtroyer awesome patch for OSC from dolphm https://review.openstack.org/#/c/330057/218:18
*** singhj has joined #openstack-sdks18:19
*** singhj has quit IRC18:23
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: better functional test collection  https://review.openstack.org/33013718:27
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: better functional test collection  https://review.openstack.org/33013718:27
*** e0ne has quit IRC18:30
*** singhj has joined #openstack-sdks18:30
*** sdague has quit IRC18:34
*** aimeeu has quit IRC18:39
*** sdague has joined #openstack-sdks18:41
*** salv-orlando has quit IRC18:43
*** salv-orlando has joined #openstack-sdks18:44
*** jaosorior has joined #openstack-sdks18:44
*** aimeeu has joined #openstack-sdks18:44
openstackgerritMerged openstack/cliff: Add more test coverage for CSV formatter  https://review.openstack.org/31638218:45
*** cdent has quit IRC18:55
*** salv-orl_ has joined #openstack-sdks18:55
*** salv-orlando has quit IRC18:58
openstackgerritMerged openstack/cliff: Add more test coverage for shell formatter  https://review.openstack.org/31642419:02
*** sheel has quit IRC19:05
openstackgerritMerged openstack/python-openstackclient: Fix volume functional tests  https://review.openstack.org/33006719:11
stevemardhellmann: one more cliff test patch: https://review.openstack.org/#/c/316059/3/cliff/tests/test_formatters_table.py19:15
dtroyercould you guys take a look at https://review.openstack.org/#/c/287536/ in cliff too?  It would be helpful for a couple of things in OSC19:20
dhellmannstevemar, dtroyer : added to my queue19:20
*** cdent has joined #openstack-sdks19:20
*** cdent has quit IRC19:24
dhellmanndtroyer : do we need a flag to indicate whether something is machine readable? doesn't the formatter implementation know that?19:30
dtroyerthe formatter does, but we need it in the command class to know if a field needs additional formatting, say to de-json a field that contains a list19:31
dtroyerI expect the formatter to set this as the table one does in the review19:32
stevemardtroyer: i think we need an XML formatter19:33
*** openstackgerrit has quit IRC19:33
* dtroyer fires a BFG at stevemar19:33
*** openstackgerrit has joined #openstack-sdks19:34
dtroyerthere is probably a better way to do this, but at the time it was not apparent to me19:34
* stevemar disintegrates at the slight of a large green plasma blast19:34
dhellmanndtroyer : does the command class give the formatter a string? I honestly don't remember how that works, but I would expect the formatter to deal with all of this so if we're giving it a string maybe that's the issue?19:34
stevemardhellmann: IIRC i think its so that OSC can check whether we want to format properties (dicts) / tags (lists) prettily, or leave them in JSON19:39
dhellmannstevemar : right, I get that. I think that's the formatter's job. Maybe we need to flag columns as "may be reformattable by machine readable formatters"?19:39
dtroyerThere are a number ofplaces that work is done long before we return the data back thgouth cliff's formatters19:40
dhellmannhaving the main application look at what type of formatter it has and take action feels like it's mixing concerns. so if we have data that can be reformatted, we shouldn't serialize it in the app19:40
dtroyerhere is one example: http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/compute/v2/server.py#n11219:40
dtroyerthen we need to teach cliff many more specific field types19:41
dhellmannpossibly19:41
dhellmannI wonder if we could get away with some sort of meta thing with 2 options, the human readable view and the machine readable view19:42
dhellmannso column values could either be strings or instances of a thing we construct and pass (data, format_for_humans, format_for_machines)19:43
dhellmannthen the formatters could call the right method, which would call the functions given19:43
dhellmannwe could subclass if we want, but we wouldn't have to19:43
dhellmannFormattableColumnValue19:43
dtroyerI would have to walk through a number of examples to see if that is sufficient19:44
stevemardhellmann: do you know why this failed? is it because i have to move that to _independent?19:44
dtroyerI do know there are a couple of places where we need to do some branching based on output formet.  right now, it's just broken19:44
stevemardhellmann: a link would help... https://review.openstack.org/#/c/330126/19:44
stevemar(while we're all talking about cliff)19:44
*** salv-orl_ has quit IRC19:45
*** salv-orlando has joined #openstack-sdks19:45
dhellmanndtroyer : looking at prep_server_detail, I see generic cases for "named thing with id" (image, flavor), special cases for format_servers_list_networks and format_servers_list_power_state19:45
dhellmannstevemar : the deliverable name in the governance repo doesn't match the file name in the releases repo. I think you want to call that file cliff.yaml19:46
stevemardhellmann: alright, weird, it was called python-cliff in all other releases o_O19:47
dhellmannstevemar : possibly this is a new validation rule19:47
*** e0ne has joined #openstack-sdks19:48
dtroyerpushing the individual field formatting into cliff is a major change and is going to require a hell of a lot more time than I have in the forseeable future.19:55
dtroyerI also need to unbreak field wrapping so it is off by default in 3.019:55
dtroyerthe default should have never changed and it is driving me nuts19:55
*** jaosorior has quit IRC19:57
dhellmannok, yeah, I get that19:58
dhellmannare there specific fields where this is an issue? maybe I can take a stab at something to get it started19:58
dtroyerthose in the server I linked to are some of the older examples, darn near anything in a network command has newer more neutron-like examples19:59
dhellmannok19:59
*** krotscheck_dcm is now known as krotscheck20:00
dtroyerhttp://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/network/v2/router.py#n50 is the formatter dict, http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/network/v2/router.py#n444 is where it is called in take_action()20:00
dtroyersome of those are generic enough though20:01
dtroyerThe other approach I took last winter was to look at exposing the CLI options cliff defines so the app can interpret itself, but that doesn't account for any app-specific formatters that may be added20:03
dhellmannyeah that's just going to  spread the complexity around20:05
*** gouthamr has quit IRC20:05
dhellmannI think this is something I got wrong in the initial design of cliff20:05
dtroyerit is worse in multiple ways20:05
dhellmannI wasn't expecting such complicated values for individual columns20:05
dtroyershoot, neither was I.  we still don't have decent ways to present some of this nested data20:06
*** fzdarsky|afk has quit IRC20:07
dhellmannfor human readability, tables may not be the best solution for some of this20:07
dhellmannanother approach is command-specific formatters20:08
dhellmannwhich is basically what we've done, just not in formatter plugins20:08
openstackgerritMerged openstack/cliff: Support multiple sub commands in completion  https://review.openstack.org/28465420:21
openstackgerritDean Troyer proposed openstack/python-openstackclient: Finish osc-lib transition for command.py  https://review.openstack.org/33019320:29
openstackgerritDoug Hellmann proposed openstack/cliff: add formattable columns concept  https://review.openstack.org/33022321:09
dhellmanndtroyer : ^^21:09
dhellmanndtroyer : suggestions on a better name for "formattable columns" are welcome21:10
*** rtheis has quit IRC21:12
*** e0ne has quit IRC21:14
dtroyerdhellmann: I am playing with that, don't have a better name than FormattableColumn (yet), it is a good start22:01
dtroyerI have found something that I did not anticipate though, and my hack didn't address either22:01
dhellmannoh?22:01
dtroyer'machine readable' means different things in different formatters22:01
dhellmannyeah, that method is supposed to return a real object, not a string, and let the formatter actually format it22:02
dtroyerI'm looking at the shell formatter, you have it using human_readable() which I didn't like at first, but I see why now22:02
dhellmannwe could also add more methods to that class, for other more-specific cases22:02
dtroyerone of the things some want in human_readable is \n chars, which I think will break in shell22:02
*** openstackgerrit has quit IRC22:02
dhellmannIIRC the shell formatter already stripped newlines22:02
dhellmannmaybe that got lost in my patch, or maybe that was somewhere else22:03
dtroyerI don't see that now, just escaping " chars22:03
dtroyeranyway, for a first cut it looks good and will go a long way, thanks22:04
dhellmannhmm, no, I mis-remembered22:04
dtroyeranyway, what I am worried about may be better done as an anhancement to the shell formatter itself22:05
dtroyerlike stripping the \n chars as you thought it did ;)22:06
dhellmannsure, and like I said, once we have this in place we can add more methods for things like human_readable_single_line() and human_readable_multiline()22:06
*** openstackgerrit has joined #openstack-sdks22:06
dtroyerthat should work.  I am wondering about which ones should be considered human readable…in my mind it was only table, the others are meant to be parsed in one way or another22:08
dtroyerI can make a note in the review and go from there22:09
dhellmannok22:09
dtroyerthanks again, this is a huge help22:09
dhellmannI thought value might have been human readable, too? maybe not22:09
dtroyerit was meant for directly getting an ID, say, in $(openstack image show fred) etc22:09
dtroyerIIRc we use it in devstack22:10
dhellmannah, right22:11
*** salv-orlando has quit IRC22:25
*** salv-orlando has joined #openstack-sdks22:26
*** edmondsw has quit IRC22:40
openstackgerritDean Troyer proposed openstack/python-openstackclient: Finish osc-lib transition for command.py  https://review.openstack.org/33019322:50
openstackgerritDean Troyer proposed openstack/python-openstackclient: Test new cliff column formatting  https://review.openstack.org/33026122:51
dtroyerdhellmann: Is this the sort of usage you had in mind for the FormattableColumn? https://review.openstack.org/#/c/330261/22:53
*** gouthamr has joined #openstack-sdks22:54
openstackgerritColleen Murphy proposed openstack/keystoneauth: Fix kerberos available property  https://review.openstack.org/33026522:56
« Tuesday, 2016-06-14 Index Thursday, 2016-06-16 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!