*** Qiming has joined #openstack-sdks | 00:07 | |
openstackgerrit | Michael Gugino proposed openstack/python-openstacksdk: Implement network agents https://review.openstack.org/315832 | 00:16 |
---|---|---|
*** lhcheng_ has joined #openstack-sdks | 00:17 | |
*** lhcheng has quit IRC | 00:17 | |
openstackgerrit | Michael Gugino proposed openstack/python-openstacksdk: Implement network agents https://review.openstack.org/315832 | 00:20 |
*** yuanying has joined #openstack-sdks | 00:27 | |
openstackgerrit | Michael Gugino proposed openstack/python-openstacksdk: Implement network agents https://review.openstack.org/315832 | 00:29 |
*** yuanying has quit IRC | 00:30 | |
*** Qiming has quit IRC | 00:31 | |
*** dfflanders has quit IRC | 00:32 | |
*** jamielennox|away is now known as jamielennox | 00:37 | |
*** yuanying has joined #openstack-sdks | 00:40 | |
*** lhcheng_ has quit IRC | 00:41 | |
*** michaelgugino has joined #openstack-sdks | 00:44 | |
*** lhcheng has joined #openstack-sdks | 01:05 | |
*** lhcheng_ has joined #openstack-sdks | 01:08 | |
*** lhcheng has quit IRC | 01:11 | |
*** zhurong has joined #openstack-sdks | 01:17 | |
*** Qiming has joined #openstack-sdks | 01:21 | |
*** yuanying has quit IRC | 01:30 | |
*** singhj has joined #openstack-sdks | 01:37 | |
*** singhj has quit IRC | 01:42 | |
*** yanyanhu has joined #openstack-sdks | 01:53 | |
openstackgerrit | Michael Gugino proposed openstack/python-openstacksdk: Implement network agents https://review.openstack.org/315832 | 01:54 |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Add FakeBackup class and updata backup unittest in volumeV2 https://review.openstack.org/316359 | 01:57 |
*** jamielennox is now known as jamielennox|away | 01:59 | |
tangchen | stevemar: Hi Steve, would you please help to confirm this patch. https://review.openstack.org/#/c/293997/ | 02:06 |
tangchen | stevemar: If you are OK with it, I can move on to fix all the other similar problems. | 02:07 |
stevemar | tangchen: i shall take a look | 02:07 |
stevemar | ah, i was going to look at this one | 02:07 |
tangchen | stevemar: thx | 02:08 |
*** gildub has quit IRC | 02:13 | |
stevemar | tangchen: +2/+A :D | 02:14 |
*** coolsvap|zzzzzzz has quit IRC | 02:14 | |
tangchen | stevemar: Thanks. :) | 02:16 |
*** yuanying has joined #openstack-sdks | 02:24 | |
*** fangxu has quit IRC | 02:36 | |
*** coolsvap has joined #openstack-sdks | 02:49 | |
*** yuanying has quit IRC | 02:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/osc-lib: Updated from global requirements https://review.openstack.org/317185 | 03:01 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/317196 | 03:02 |
openstackgerrit | Merged openstack/python-openstackclient: Enhance exception handling for "network delete" command https://review.openstack.org/293997 | 03:04 |
*** lnk has joined #openstack-sdks | 03:23 | |
tangchen | stevemar: Hi Steve, please take a look at this BP. https://blueprints.launchpad.net/python-openstackclient/+spec/migrate-glanceclient-to-osc | 03:24 |
tangchen | stevemar: lnk is now working with me, and he will try to migrate glanceclient to osc | 03:25 |
tangchen | stevemar: We will discuss this with glance guys soon, and then we can start the work, I think. :) | 03:25 |
lnk | hi steve, I'd like to take the image commands job.:-) | 03:27 |
openstackgerrit | Michael Gugino proposed openstack/python-openstacksdk: Implement network agents https://review.openstack.org/315832 | 03:27 |
lnk | stevemar: I'd like to take the image commands job.:-) | 03:28 |
stevemar | tangchen: lnk that would be great :) | 03:29 |
stevemar | lnk: tangchen i think there are more than just `image` commands | 03:30 |
stevemar | image members... but i think that is "add project" ? | 03:30 |
stevemar | https://github.com/openstack/python-glanceclient/tree/master/glanceclient/v2 schemas everywhere! | 03:33 |
stevemar | tangchen: lnk: for the `tags` and `location`, will those be updated based on `osc image set`? | 03:34 |
stevemar | what the heck is a glance task?! | 03:35 |
stevemar | tangchen: lnk i'm totally for using the openstackSDK instead of glanceclient | 03:36 |
stevemar | one less requirement (it pulls in warlock: https://github.com/openstack/python-glanceclient/blob/master/requirements.txt#L9 -- used for schema/models) | 03:37 |
michaelgugino | writing tests is defeating :( Waiting on zuul is painful. | 03:38 |
lnk | stevemar: ok i will look deeply into it :) | 03:39 |
lnk | stevemar: thanks ;-) | 03:41 |
stevemar | michaelgugino: are waiting for zuul for test results? | 03:42 |
stevemar | lnk: np! please feel free to bug me if you have any questions | 03:42 |
michaelgugino | stevemar: yes, functional tests | 03:42 |
michaelgugino | is there a way to run unit tests locally? | 03:43 |
stevemar | michaelgugino: http://docs.openstack.org/developer/python-openstackclient/developing.html#running-functional-tests | 03:43 |
stevemar | michaelgugino: tox -e py27 will run unit tests locally, tox -e functional will run the functional bits locally | 03:43 |
stevemar | just need devstack installed | 03:44 |
michaelgugino | yeah, I don't have any devstack installed atm. I should probably do that ;) | 03:44 |
stevemar | michaelgugino: it's not painful (like it used to be :) ) | 03:44 |
stevemar | michaelgugino: basically, before jenkins kicks off the functional test suite, it runs this: https://github.com/openstack/python-openstackclient/blob/master/post_test_hook.sh#L13-L20 | 03:45 |
michaelgugino | :). I'm hoping my tests pass this run, and I can avoid it a little longer | 03:45 |
michaelgugino | is that the only dependency on devstack? | 03:45 |
lnk | stevemar: ok :) | 03:45 |
stevemar | so as long as you run: source ~stack/devstack/openrc admin admin (or somewhere like that), then tox -e functional should be a-ok | 03:45 |
*** gouthamr_ has quit IRC | 03:46 | |
stevemar | michaelgugino: not sure what you mean? devstack (or any openstack cloud) is a requirement for running osc functional tests, yes | 03:46 |
stevemar | i just wouldn't run it / point the functional tests to anywhere meaningful... | 03:47 |
michaelgugino | I work a lot with openstack-ansible. It would be good if I could test against that | 03:47 |
stevemar | yep, you could | 03:47 |
michaelgugino | instead of having to spin up another vm with devstack. | 03:47 |
michaelgugino | sweet, I'll give that a go. | 03:47 |
stevemar | michaelgugino: the functional tests run based on environment variables, so as long as those are set, you are good | 03:47 |
michaelgugino | yeah, no problem. | 03:48 |
michaelgugino | I'll run one now and let you know what it does :) | 03:48 |
*** yuanying has joined #openstack-sdks | 03:48 | |
*** lnk has quit IRC | 03:53 | |
michaelgugino | stevemar: it's looking for test_cloud for occ | 03:55 |
*** jamielennox|away is now known as jamielennox | 03:55 | |
stevemar | michaelgugino: is a specific test looking for that? | 03:55 |
michaelgugino | lots of them | 03:56 |
*** dfflanders has joined #openstack-sdks | 03:57 | |
michaelgugino | stevemar: I'm currently working on an openstacksdk patch btw | 03:59 |
*** reedip__ has joined #openstack-sdks | 03:59 | |
stevemar | michaelgugino: nice | 04:00 |
*** lnk has joined #openstack-sdks | 04:02 | |
michaelgugino | well, I can say simply sourcing openrc and running tox -e functional does not work with openstack ansible. It's looking for test_cloud's credentials. I suppose I can add a file wherever it's looking though. | 04:02 |
*** sheel has joined #openstack-sdks | 04:06 | |
*** salv-orlando has joined #openstack-sdks | 04:15 | |
tangchen | stevemar: I just went out for lunch...Will start the work with lnk soon. Thanks. :) | 04:16 |
*** salv-orl_ has quit IRC | 04:18 | |
*** yuanying has quit IRC | 04:22 | |
*** yuanying has joined #openstack-sdks | 04:23 | |
*** gildub has joined #openstack-sdks | 04:26 | |
*** yuanying has quit IRC | 04:27 | |
stevemar | tangchen: have a good lunch! i'm off to sleep, not feeling too well today | 04:30 |
tangchen | stevemar: Good night. :) | 04:32 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/317196 | 04:42 |
*** yuanying has joined #openstack-sdks | 04:46 | |
*** yuanying has quit IRC | 05:08 | |
*** e0ne has joined #openstack-sdks | 05:09 | |
*** e0ne has quit IRC | 05:11 | |
openstackgerrit | Merged openstack/osc-lib: Updated from global requirements https://review.openstack.org/317185 | 05:13 |
*** michaelgugino has quit IRC | 05:22 | |
*** fangxu has joined #openstack-sdks | 05:37 | |
*** reedip__ has quit IRC | 05:40 | |
*** fangxu has quit IRC | 05:41 | |
*** fangxu has joined #openstack-sdks | 05:42 | |
*** jaosorior has joined #openstack-sdks | 05:43 | |
*** reedip__ has joined #openstack-sdks | 05:53 | |
*** jamielennox is now known as jamielennox|away | 06:41 | |
*** tangchen has quit IRC | 06:47 | |
*** tangchen has joined #openstack-sdks | 06:48 | |
*** jaosorior has quit IRC | 06:56 | |
*** jaosorior has joined #openstack-sdks | 06:57 | |
*** fzdarsky has joined #openstack-sdks | 07:21 | |
*** lhcheng_ has quit IRC | 07:33 | |
*** shu-mutou has joined #openstack-sdks | 08:06 | |
*** fzdarsky is now known as fzdarsky|afk | 08:12 | |
oomichi | elmiko: hi, shu-mutou is working for pecan-swagger on magnum side | 08:16 |
oomichi | elmiko: and he cannot install the pecan-swagger from pypi now and he needs to write the url of pecan-swagger on test-requirements.txt | 08:17 |
oomichi | elmiko: can you give him advice on the gerrit? https://review.openstack.org/#/c/303235/ | 08:18 |
*** e0ne has joined #openstack-sdks | 08:30 | |
*** tingwang has joined #openstack-sdks | 08:30 | |
*** kromanenko__ has joined #openstack-sdks | 08:45 | |
*** kromanenko has joined #openstack-sdks | 08:45 | |
reedip__ | tangchen: ping? | 08:47 |
tangchen | reedip__: yes | 08:48 |
reedip__ | tangchen hi | 08:48 |
tangchen | hi | 08:48 |
reedip__ | tangchen: sorry, was not present :) | 08:48 |
reedip__ | tangchen: quick query ... related to https://review.openstack.org/#/c/302530/9 | 08:48 |
reedip__ | tangchen: need your help in this a bit | 08:49 |
reedip__ | tangchen: https://review.openstack.org/#/c/302530/9/openstackclient/network/v2/port.py line#470 gives me OBJECT with entries as string | 08:49 |
reedip__ | tangchen: but in https://review.openstack.org/#/c/302530/9/openstackclient/tests/network/v2/test_port.py, I am getting the FakeObject with key entries as variables ( i.e. not strings) | 08:50 |
reedip__ | tangchen: have yo9u ever faced such an issue in your tests? | 08:50 |
tangchen | reedip__: Er...no, I don't think so. But it may be FakePort's problem. | 08:51 |
tangchen | reedip__: Which property ? | 08:52 |
reedip__ | tangchen: fixed_ip | 08:52 |
reedip__ | tangchen: fixed_ip in fakeport is a normal variable but its a string when I try to get it using find_port | 08:52 |
tangchen | reedip__: In FakePort, we have 'fixed_ips': [{}], | 08:52 |
tangchen | yes, it is not a string | 08:52 |
reedip__ | tangchen: find_port returns a string | 08:53 |
reedip__ | tangchen: for fixed_ips | 08:53 |
reedip__ | tangchen: I mean obj={'fixed_ips':...} from find_port and obj={fixed_ips:...} from FakePort | 08:54 |
*** salv-orlando has quit IRC | 08:54 | |
reedip__ | so my test scenarios are not doing the actual work they should do on the object | 08:54 |
tangchen | reedip__: If so, then I think it is SDK's problem | 08:55 |
reedip__ | tangchen: umm.... | 08:55 |
tangchen | reedip__: Have you checked SDK ? | 08:55 |
reedip__ | tangchen: no not yet, but now I will | 08:55 |
reedip__ | tangchen: thnx for your precious time and help :) | 08:55 |
tangchen | reedip__: I think the obj returned from sdk is an obj of class Port in SDK | 08:56 |
tangchen | It is not a dict | 08:56 |
reedip__ | tangchen : I am not sure | 08:58 |
reedip__ | tangchen : it is displayed as a dict on printing the obj | 08:59 |
tangchen | reedip__: when I run port list --debug, I got: | 09:01 |
tangchen | {"ports": [{"status": "ACTIVE", "binding:host_id": "tangchen", "description": "", "allowed_address_pairs": [], "extra_dhcp_opts": [], "updated_at": "2016-05-14T06:14:36", "device_owner": "network:dhcp", "port_security_enabled": false, "binding:profile": {}, "fixed_ips": [{"subnet_id": "73125985-b5cd-4dd3-ac3e-4d2452962402", "ip_address": "10.10.10.2"}], " | 09:01 |
tangchen | fixed_ip is a string | 09:01 |
reedip__ | tangchen: thats a dict, right? | 09:01 |
reedip__ | tangchen : on running tox, the obj ggives me: <FakeResource admin_state_up=True, allowed_address_pairs=[{}], binding:host_id=binding-host-id-62f5f98a122e4e51bb48c62b7ebec79e, binding:profile={'Superman': 'LexLuthor', 'batman': 'Joker'}, binding:vif_details={}, binding:vif_type=ovs, binding:vnic_type=normal, binding_host_id=binding-host-id-62f5f98a122e4e51bb48c62b7ebec79e, binding_profile={'Superman': 'LexLuthor', 'batman': 'Joker'}, binding_vif_d | 09:02 |
reedip__ | etails={}, binding_vif_type=ovs, binding_vnic_type=normal, device_id=device-id-091d677fcd904d69ac5673264c8d1e02, device_owner=compute:nova, dns_assignment=[{}], dns_name=dns-name-0077c5343a7049159804bf6f645360f1, extra_dhcp_opts=[{}], fixed_ips=[{'subnet_id': '042eb10a-3a18-4658-ab-cf47c8d03152', 'ip_address': '0.0.0.1'}, {'subnet_id': '042eb10a-3a18-4658-ab-cf47c8d03152', 'ip_address': '1.0.0.0'}], id=port-id-e66e45d231cd49419e51787ce7a740eb, ma | 09:02 |
reedip__ | c_address=fa:16:3e:a9:4e:72, name=port-name-56b6314739c34493a47d83842e241127, network_id=network-id-d77073a491da43b2bbd32000d3171154, port_security_enabled=True, project_id=project-id-cc43855734e442e1a1f5009d5561a506, security_groups=[], status=ACTIVE, tenant_id=project-id-cc43855734e442e1a1f5009d5561a506 | 09:02 |
tangchen | reedip__: yes, but it is from the resp body. I will check the return value from sdk | 09:02 |
reedip__ | ( stupid NewLine ) : tangchen , the above output which I pasted is an object | 09:03 |
reedip__ | tangchen : and https://github.com/openstack/python-openstacksdk/blob/7a8c7e6df4164ea0112f61881d5f62bf87abdf97/openstack/network/v2/_proxy.py#L1032 returns a port object | 09:03 |
tangchen | yes | 09:04 |
tangchen | openstack.network.v2.port.Port(attrs={u'status': u'N/A', u'binding:host_id': u'', u'description': u'', u'allowed_address_pairs': [], u'extra_dhcp_opts': [], u'updated_at': u'2016-05-14T06:26:02', u'device_owner': u'network:floatingip', u'port_security_enabled': False, u'binding:profile': {}, u'fixed_ips': [{u'subnet_id': u'73125985-b5cd-4dd3-ac3e-4d2452962402', u'ip_address': u'10.10.10.3'}], u'id': u'de32a139-a5a3-471f-9a31-16a9b1346e44', | 09:04 |
tangchen | u'security_groups': [], u'device_id': u'eafd5894-458e-4bec-bfc4-24cbbd2d218c', u'name': u'', u'admin_state_up': True, u'network_id': u'69443312-1541-4b98-b13b-abad43e70254', u'dns_name': None, u'binding:vif_details': {}, u'binding:vnic_type': u'normal', u'binding:vif_type': u'unbound', u'tenant_id': u'', u'mac_address': u'fa:16:3e:03:bd:44', u'created_at': u'2016-05-14T06:26:02'}, loaded=True) | 09:04 |
tangchen | it is an obj of Port. | 09:04 |
tangchen | Then fixed_ips should be a property, not a string. | 09:05 |
reedip__ | tangchen: exactly | 09:05 |
reedip__ | but weirdly, its not | 09:05 |
tangchen | reedip__: What happened in your test ? | 09:05 |
tangchen | reedip__: What made you think it is a string ? | 09:06 |
reedip__ | tangchen: tests written in https://review.openstack.org/#/c/302530/9 pass, but it fails on actual ports as mentioned by RuiChen ( http://paste.openstack.org/show/495105/) | 09:07 |
reedip__ | tangchen: on changing the line #476 in https://review.openstack.org/#/c/302530/9/openstackclient/network/v2/port.py from " obj.fixed_ips.remove(ip) " to " obj['fixed_ips'].remove(ip)" worked! | 09:08 |
reedip__ | ( worked on the actual ports ) | 09:08 |
tangchen | reedip__: I just read Rui Chen's comment. I think we should find out if the fixed ips can be unset freely. | 09:10 |
tangchen | reedip_: Maybe we can only unset them on some conditions. I'm not quite sure either | 09:11 |
reedip__ | It is happening with obj['fixed_ips'] | 09:11 |
reedip__ | but not with obj.fixed_ips | 09:11 |
reedip__ | tangchen: my new code ( which is uncommitted) works on RuiChen's test but fails the written UT | 09:12 |
reedip__ | because of the transition from property to string in find_ports | 09:12 |
tangchen | You mean obj.fixed_ips.remove(ip) doesn't work ? | 09:13 |
reedip__ | tangchen: no it doesnt work on actual ports | 09:14 |
reedip__ | I printed the object | 09:14 |
reedip__ | and it gave me a response body and not a port object | 09:14 |
reedip__ | dont know WHY | 09:14 |
reedip__ | just a minute.... :) working a bit more | 09:17 |
tangchen | reedip__: OK, I think in Rui Chen's test, --fixed-ip subnet=b0938830-a9d8-4126-aaae-d5fbb0263654,ip-address=20.20.20.3 | 09:18 |
tangchen | the option was not parsed into a dict correctly. | 09:19 |
tangchen | the UT is different | 09:19 |
tangchen | it has only ip_address | 09:19 |
tangchen | no subnet | 09:19 |
tangchen | In the real world, it cannot find the parsed dict in the list. So it failed to remove it. | 09:20 |
reedip__ | that is exactly what I am trying to find out | 09:22 |
reedip__ | :) | 09:22 |
tangchen | :) | 09:23 |
reedip__ | I found one problem ( maybe) | 09:25 |
reedip__ | I have 2 fixed_ips on a port | 09:25 |
reedip__ | I passed to remove one | 09:25 |
reedip__ | I made a for loop to check the passed argument against each fixed_ip in the port object | 09:26 |
reedip__ | this is the output | 09:26 |
reedip__ | {'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', 'ip_address': '10.0.0.2'} {u'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', u'ip_address': u'10.0.0.2'} | 09:26 |
reedip__ | {'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', 'ip_address': '10.0.0.2'} {u'subnet_id': u'f2b4dd8f-b5d4-4dc8-bd43-10aab86efda7', u'ip_address': u'fd8a:24af:d19c:0:f816:3eff:feed:3019'} | 09:26 |
tangchen | ok | 09:26 |
tangchen | then ? | 09:26 |
*** coolsvap has quit IRC | 09:27 | |
reedip__ | then the problem seems to be simple unicode :( | 09:28 |
reedip__ | see the first output | 09:28 |
*** coolsvap has joined #openstack-sdks | 09:28 | |
reedip__ | everything matches except the fact that I have 'subnet_id' at one place and u'subnet_id' on the other | 09:28 |
reedip__ | :( | 09:28 |
tangchen | but remove() failed ? | 09:29 |
tangchen | it removes nothing ? | 09:29 |
reedip__ | tangchen: nope | 09:30 |
reedip__ | let me encode the information and see what happens(?) | 09:30 |
tangchen | I think remove() failed to determine one dict equals to another. | 09:31 |
tangchen | not sure | 09:31 |
reedip__ | yeah it is unable to do so and encode doesnt work | 09:32 |
*** amotoki has joined #openstack-sdks | 09:35 | |
tangchen | reedip__: Would you please try to print obj.fixed_ips.index(the dict) ? | 09:38 |
reedip__ | Okay tangchen , lemme try | 09:39 |
tangchen | If exception is thrown, then list cannot find a dict item in itself. | 09:39 |
tangchen | Then this is the problem. | 09:39 |
tangchen | Well, I tried this: | 09:42 |
tangchen | >>> l=[{'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', 'ip_address': '10.0.0.2'}, {u'subnet_id': u'f2b4dd8f-b5d4-4dc8-bd43-10aab86efda7', u'ip_address': u'fd8a:24af:d19c:0:f816:3eff:feed:3019'}] | 09:42 |
tangchen | >>> l.remove({'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', 'ip_address': '10.0.0.2'}) | 09:42 |
tangchen | >>> print l | 09:42 |
tangchen | [{u'subnet_id': u'f2b4dd8f-b5d4-4dc8-bd43-10aab86efda7', u'ip_address': u'fd8a:24af:d19c:0:f816:3eff:feed:3019'}] | 09:42 |
tangchen | >>> | 09:42 |
tangchen | I think remove() works. | 09:42 |
reedip__ | it doesnt work in the code :( | 09:42 |
reedip__ | it works individually | 09:42 |
reedip__ | Okay, I tried it | 09:43 |
reedip__ | [{u'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', u'ip_address': u'10.0.0.3'}, {u'subnet_id': u'f2b4dd8f-b5d4-4dc8-bd43-10aab86efda7', u'ip_address': u'fd8a:24af:d19c:0:f816:3eff:feed:3019'}] | 09:43 |
reedip__ | Unable to find {'subnet_id': u'9d46976f-ec82-41f8-a44d-53b6c89f392d', 'ip_address': '10.0.0.2'} in fixed-ip | 09:43 |
reedip__ | The first is the obj output | 09:43 |
reedip__ | the second if the index search | 09:44 |
tangchen | well, the ip is incorrect | 09:44 |
tangchen | it should be 10.0.0.3, but it was 10.0.0.2 | 09:45 |
tangchen | right ? | 09:45 |
*** shu-mutou is now known as shu-mutou-AFK | 09:48 | |
*** cdent has joined #openstack-sdks | 09:51 | |
*** zhurong has quit IRC | 09:51 | |
tangchen | reedip__: Going out for dinner. Will be back in an hour. | 09:54 |
reedip__ | tangchen: okay , the client works :) | 10:01 |
reedip__ | tangchen but the sdk doesnt | 10:01 |
*** fzdarsky|afk is now known as fzdarsky | 10:08 | |
*** yanyanhu has quit IRC | 10:12 | |
*** salv-orl_ has joined #openstack-sdks | 10:13 | |
*** salv-orl_ has quit IRC | 10:13 | |
*** cdent has quit IRC | 10:13 | |
*** salv-orl_ has joined #openstack-sdks | 10:13 | |
*** cdent has joined #openstack-sdks | 10:14 | |
*** sdague has joined #openstack-sdks | 10:18 | |
reedip__ | tangchen : solved! :) | 10:23 |
*** Qiming has quit IRC | 10:25 | |
*** e0ne has quit IRC | 10:25 | |
tangchen | reedip__: OK :) | 10:26 |
*** e0ne has joined #openstack-sdks | 10:26 | |
*** dfflanders has quit IRC | 10:46 | |
*** jamielennox|away is now known as jamielennox | 10:53 | |
*** cdent has quit IRC | 11:03 | |
*** lucasagomes is now known as lucas-hungry | 11:07 | |
*** cdent has joined #openstack-sdks | 11:08 | |
*** rtheis has joined #openstack-sdks | 11:17 | |
*** Qiming has joined #openstack-sdks | 11:20 | |
*** salv-orl_ has quit IRC | 11:32 | |
*** salv-orlando has joined #openstack-sdks | 11:35 | |
*** tingwang has quit IRC | 11:37 | |
*** Qiming has quit IRC | 11:37 | |
*** Qiming has joined #openstack-sdks | 11:40 | |
*** reedip__ has quit IRC | 11:40 | |
openstackgerrit | Tang Chen proposed openstack/python-openstackclient: Transfer "ip floating add/remove" to "server add/remove floating ip" https://review.openstack.org/302508 | 11:40 |
openstackgerrit | Tang Chen proposed openstack/python-openstackclient: Transfer "ip floating pool list" to "floating ip pool list" https://review.openstack.org/300388 | 11:40 |
openstackgerrit | Tang Chen proposed openstack/python-openstackclient: Transfer "ip fixed add/remove" to "server add/remove fixed ip" https://review.openstack.org/302590 | 11:40 |
openstackgerrit | Tang Chen proposed openstack/python-openstackclient: Transfer "ip floating CRUD" to "floating ip CRUD" https://review.openstack.org/302687 | 11:40 |
*** Qiming_ has joined #openstack-sdks | 11:43 | |
*** Qiming has quit IRC | 11:46 | |
*** Qiming_ has quit IRC | 11:54 | |
*** Qiming has joined #openstack-sdks | 11:57 | |
*** Qiming has quit IRC | 11:58 | |
*** gouthamr has joined #openstack-sdks | 12:02 | |
*** Qiming has joined #openstack-sdks | 12:04 | |
*** gildub has quit IRC | 12:05 | |
*** Qiming has quit IRC | 12:06 | |
*** Qiming has joined #openstack-sdks | 12:07 | |
*** lucas-hungry is now known as lucasagomes | 12:13 | |
*** Qiming has quit IRC | 12:16 | |
*** Qiming has joined #openstack-sdks | 12:16 | |
openstackgerrit | ting wang proposed openstack/python-openstackclient: Refactor TestVolumeShow with FakeVolume https://review.openstack.org/315344 | 12:22 |
openstackgerrit | sunyajing proposed openstack/python-openstackclient: add command image_set --deltag option and unit test wo could add a tag ,so we can also remove a tag https://review.openstack.org/317427 | 12:22 |
openstackgerrit | Rui Chen proposed openstack/python-openstackclient: Support "--no" and "--all" option in aggregate set and unset https://review.openstack.org/310193 | 12:23 |
*** thrash has quit IRC | 12:37 | |
*** thrash has joined #openstack-sdks | 12:42 | |
*** thrash has quit IRC | 12:42 | |
*** thrash has joined #openstack-sdks | 12:42 | |
*** sheel has quit IRC | 12:45 | |
*** edmondsw has joined #openstack-sdks | 12:48 | |
*** salv-orlando has quit IRC | 12:49 | |
*** lnk has quit IRC | 12:53 | |
*** salv-orlando has joined #openstack-sdks | 12:55 | |
*** coolsvap has quit IRC | 12:56 | |
openstackgerrit | Markus Suonto proposed openstack/python-openstacksdk: Fixed session.parse_url not to strip versionless paths anymore https://review.openstack.org/317448 | 13:00 |
*** openstackgerrit has quit IRC | 13:32 | |
*** openstackgerrit has joined #openstack-sdks | 13:33 | |
*** lnk has joined #openstack-sdks | 13:39 | |
*** jaosorior has quit IRC | 13:52 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
*** thrash has quit IRC | 14:01 | |
*** Kuwagata has joined #openstack-sdks | 14:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/osc-lib: Updated from global requirements https://review.openstack.org/317494 | 14:08 |
*** thrash has joined #openstack-sdks | 14:10 | |
*** thrash has quit IRC | 14:10 | |
*** thrash has joined #openstack-sdks | 14:10 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/317196 | 14:10 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstacksdk: Updated from global requirements https://review.openstack.org/317506 | 14:10 |
elmiko | oomichi: fixed the pypi issue, added a comment on the 303235 review. thanks again =) | 14:18 |
*** amotoki has quit IRC | 14:23 | |
*** markvoelker has joined #openstack-sdks | 14:35 | |
*** markvoelker has quit IRC | 14:35 | |
*** markvoelker has joined #openstack-sdks | 14:36 | |
*** markvoelker has quit IRC | 14:39 | |
*** markvoelker has joined #openstack-sdks | 14:39 | |
*** markvoelker has quit IRC | 14:51 | |
*** michaelgugino has joined #openstack-sdks | 14:51 | |
*** markvoelker has joined #openstack-sdks | 14:53 | |
*** markvoelker has quit IRC | 14:57 | |
*** gildub has joined #openstack-sdks | 14:57 | |
*** markvoelker has joined #openstack-sdks | 14:58 | |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Add transition doc https://review.openstack.org/317095 | 14:59 |
*** salv-orlando has quit IRC | 14:59 | |
*** salv-orlando has joined #openstack-sdks | 15:00 | |
*** salv-orlando has quit IRC | 15:00 | |
*** salv-orlando has joined #openstack-sdks | 15:00 | |
*** coolsvap has joined #openstack-sdks | 15:01 | |
*** salv-orlando has quit IRC | 15:01 | |
*** Qiming has quit IRC | 15:02 | |
*** salv-orlando has joined #openstack-sdks | 15:02 | |
*** markvoelker has quit IRC | 15:04 | |
*** gildub has quit IRC | 15:04 | |
*** lnk has quit IRC | 15:05 | |
*** sheel has joined #openstack-sdks | 15:09 | |
*** amotoki has joined #openstack-sdks | 15:09 | |
*** singhj has joined #openstack-sdks | 15:37 | |
*** fangxu has quit IRC | 15:39 | |
*** CraigSterrett has joined #openstack-sdks | 15:43 | |
*** lhcheng has joined #openstack-sdks | 15:50 | |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Add transition doc https://review.openstack.org/317095 | 15:51 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Move clientmanager to osc_lib https://review.openstack.org/316916 | 15:51 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Rework TLS option handling https://review.openstack.org/316918 | 15:51 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Remove keystoneclient dependency https://review.openstack.org/317591 | 15:51 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Move shell to osc_lib and begin rework https://review.openstack.org/316982 | 15:57 |
*** sdague has quit IRC | 16:07 | |
*** e0ne has quit IRC | 16:28 | |
sheel | tangchen: hi | 16:30 |
*** fangxu has joined #openstack-sdks | 16:41 | |
sheel | Dear core members: could you please review https://review.openstack.org/#/c/292043/ | 16:47 |
sheel | waiting for final workflow on it.. | 16:47 |
sheel | thanks | 16:47 |
*** heyongli has quit IRC | 16:50 | |
*** heyongli has joined #openstack-sdks | 16:52 | |
*** fangxu has quit IRC | 16:53 | |
*** fangxu has joined #openstack-sdks | 16:54 | |
*** lucasagomes is now known as lucas-dinner | 17:02 | |
*** thrash is now known as thrash|biab | 17:08 | |
openstackgerrit | Merged openstack/osc-lib: Updated from global requirements https://review.openstack.org/317494 | 17:09 |
manjeets | rtheis: ping | 17:11 |
*** michaelgugino has quit IRC | 17:12 | |
*** lhcheng_ has joined #openstack-sdks | 17:15 | |
*** lhcheng_ has quit IRC | 17:15 | |
*** lhcheng_ has joined #openstack-sdks | 17:16 | |
*** lhcheng_ has quit IRC | 17:16 | |
*** lhcheng_ has joined #openstack-sdks | 17:17 | |
*** kromanenko has quit IRC | 17:17 | |
*** kromanenko__ has quit IRC | 17:17 | |
*** lhcheng has quit IRC | 17:18 | |
openstackgerrit | Merged openstack/python-openstackclient: Add FakeBackup class and updata backup unittest in volumeV2 https://review.openstack.org/316359 | 17:20 |
sheel | dtroyer: hi | 17:29 |
sheel | dtroyer: could you please have a look at https://review.openstack.org/#/c/315225/ .. its just 4 to 5 line of change, this is already reviewed by rtheis and stevemar .. waiting for your aproval for participation... | 17:31 |
sheel | sorry 21 line of change | 17:31 |
sheel | dtroyer: also volume transfer related patch.. is pending for final go ahead.. | 17:33 |
sheel | dtroyer: please find some spare time to review.. | 17:33 |
sheel | thanks | 17:34 |
sheel | https://review.openstack.org/#/c/292043/ | 17:34 |
*** salv-orl_ has joined #openstack-sdks | 17:37 | |
*** michaelgugino has joined #openstack-sdks | 17:37 | |
michaelgugino | hello all. Wondering if I could get a couple reviews on https://review.openstack.org/#/c/315832/ | 17:38 |
*** amotoki has quit IRC | 17:39 | |
*** salv-orlando has quit IRC | 17:40 | |
sheel | michaelgugino: LGTM | 17:46 |
sheel | though i dont have power to +2 :( | 17:46 |
*** e0ne has joined #openstack-sdks | 17:47 | |
*** michaelgugino has quit IRC | 17:49 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/python-openstackclient: WIP Add functional tests for IP availability https://review.openstack.org/317649 | 17:49 |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/python-openstackclient: WIP Add functional tests for IP availability https://review.openstack.org/317649 | 17:52 |
*** thrash|biab is now known as thrash | 17:52 | |
*** michaelgugino has joined #openstack-sdks | 17:54 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/python-openstackclient: WIP Add functional tests for IP availability https://review.openstack.org/317649 | 17:55 |
*** cdent has quit IRC | 18:02 | |
*** coolsvap has quit IRC | 18:20 | |
*** salv-orl_ has quit IRC | 18:37 | |
*** sdague has joined #openstack-sdks | 18:51 | |
openstackgerrit | Merged openstack/keystoneauth: Updated from global requirements https://review.openstack.org/317484 | 18:58 |
*** Kuwagata has quit IRC | 19:10 | |
*** Kuwagata has joined #openstack-sdks | 19:11 | |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Move shell to osc_lib and begin rework https://review.openstack.org/316982 | 19:11 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Remove keystoneclient dependency https://review.openstack.org/317591 | 19:11 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Add transition doc https://review.openstack.org/317095 | 19:11 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Move clientmanager to osc_lib https://review.openstack.org/316916 | 19:11 |
openstackgerrit | Dean Troyer proposed openstack/osc-lib: Rework TLS option handling https://review.openstack.org/316918 | 19:11 |
briancurtin | michaelgugino: you don’t need to ping the channel for reviews. we all get emails and channel messages about changes. | 19:17 |
michaelgugino | ok, didn't mean to be a bother. Just was hoping to catch some reviews while I'm online in case need of discussion. I haven't contributed to this project before :) | 19:19 |
jamielennox | dtroyer: osc-lib is cleaning up quite nicely | 19:24 |
jamielennox | dtroyer: can i suggest as a library bein super paranoid and make absolutely everything private until someone comes screaming at you | 19:25 |
dtroyer | jamielennox: we've talked about the private before, and generally I agree… what I am trying to do in ClientManager is stop access into the config object inside the ClientManager, at least for the things I know we'll need elsewhere | 19:26 |
dtroyer | too much inside knowledge was in play in the existing OSC bits | 19:27 |
jamielennox | dtroyer: ++, yea, hide the o-c-c implementation bits away from your users | 19:27 |
*** singhj has quit IRC | 19:28 | |
jamielennox | anyway, i was just browsing and it's nice to not see all the hacks and comments explaining the hacks :) | 19:29 |
dtroyer | one or two of those will probably survive | 19:30 |
jamielennox | i'm sure they will, hopefully more can be pushed to o-c-c as well, like we should still need to be specifying all the session args manually to argparse | 19:30 |
*** salv-orlando has joined #openstack-sdks | 19:35 | |
*** e0ne has quit IRC | 19:48 | |
*** e0ne has joined #openstack-sdks | 19:51 | |
*** e0ne has quit IRC | 19:54 | |
*** Kuwagata_ has joined #openstack-sdks | 19:56 | |
*** Kuwagata has quit IRC | 19:59 | |
*** e0ne has joined #openstack-sdks | 20:01 | |
*** e0ne has quit IRC | 20:04 | |
*** fzdarsky has quit IRC | 20:09 | |
*** sheel has quit IRC | 20:15 | |
*** gildub has joined #openstack-sdks | 20:43 | |
*** gouthamr has quit IRC | 20:46 | |
*** gildub has quit IRC | 20:49 | |
*** salv-orlando has quit IRC | 20:59 | |
*** salv-orlando has joined #openstack-sdks | 21:00 | |
*** fangxu has quit IRC | 21:00 | |
*** rtheis has quit IRC | 21:02 | |
*** dfflanders has joined #openstack-sdks | 21:04 | |
*** amotoki has joined #openstack-sdks | 21:11 | |
*** sdague has quit IRC | 21:14 | |
*** gildub has joined #openstack-sdks | 21:27 | |
*** jamielennox is now known as jamielennox|away | 21:30 | |
*** fzdarsky has joined #openstack-sdks | 21:30 | |
stevemar | dtroyer: when you have some time, henrynash is looking for feedback here: https://review.openstack.org/#/c/311460/4 | 21:31 |
*** jamielennox|away is now known as jamielennox | 21:39 | |
*** michaelgugino has quit IRC | 21:45 | |
*** edmondsw has quit IRC | 21:45 | |
*** CraigSterrett has quit IRC | 22:03 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:08 | |
manjeets | dtroyer: ping | 22:11 |
manjeets | http://logs.openstack.org/49/317649/3/check/gate-osc-dsvm-functional/39a871e/console.html#_2016-05-17_21_40_48_031 | 22:11 |
manjeets | i guess this failure is because of the reason sdk not released ? | 22:12 |
manjeets | i added a dependency in patch but it still failed to find resource | 22:12 |
*** markvoelker has joined #openstack-sdks | 22:14 | |
*** markvoelker has quit IRC | 22:21 | |
*** markvoelker has joined #openstack-sdks | 22:22 | |
openstackgerrit | Merged openstack/python-openstackclient: Add ip version filter to subnet list https://review.openstack.org/315719 | 22:28 |
*** Kuwagata_ has quit IRC | 22:38 | |
*** fzdarsky has quit IRC | 22:42 | |
*** thrash is now known as thrash|g0ne | 22:45 | |
briancurtin | manjeets: yes, it’s still failing because that change has still not been released. | 22:52 |
briancurtin | i will see if i can make a release tomorrow, but I’m not doing this every time someone adds one set of methods to the SDK. | 22:52 |
*** lhcheng has joined #openstack-sdks | 23:00 | |
manjeets | briancurtin: thanks i added funtional tests according to comments on review it was doing fine with unit tests | 23:00 |
*** singhj has joined #openstack-sdks | 23:02 | |
*** lhcheng_ has quit IRC | 23:03 | |
*** markvoelker has quit IRC | 23:12 | |
*** salv-orlando has quit IRC | 23:21 | |
*** Qiming has joined #openstack-sdks | 23:39 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/python-openstackclient: Add network availability for osc https://review.openstack.org/306072 | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!