Friday, 2016-03-18

*** reedip__ has quit IRC00:04
*** dims has joined #openstack-sdks00:07
*** eliqiao_ has joined #openstack-sdks00:08
*** alex_xu has quit IRC00:10
*** eliqiao has quit IRC00:11
*** alex_xu has joined #openstack-sdks00:21
*** gildub has joined #openstack-sdks00:33
*** Qiming has quit IRC00:48
*** boris-42 has quit IRC01:04
*** knikolla has joined #openstack-sdks01:04
openstackgerritQichen Hao proposed openstack/cliff: Add the return value for take_action function  https://review.openstack.org/29391001:07
*** salv-orlando has joined #openstack-sdks01:16
*** salv-orlando has quit IRC01:17
*** salv-orlando has joined #openstack-sdks01:18
*** salv-orl_ has quit IRC01:19
*** dims has quit IRC01:21
*** salv-orlando has quit IRC01:22
*** thrash is now known as thrash|g0ne01:22
*** Qiming has joined #openstack-sdks01:24
openstackgerritMerged openstack/python-openstackclient: update docs with status of plugins  https://review.openstack.org/29431101:38
reedipstevemar: ping01:42
*** heyongli has joined #openstack-sdks01:44
stevemarreedip: pong01:44
*** heyongli has quit IRC01:44
reedipstevemar : this is a silly question, but still having a doubt...01:44
*** heyongli has joined #openstack-sdks01:44
reedipstevemar: I see that the structure for rst is doc/source/command-objects/*.rst01:44
*** scottda_vacation has quit IRC01:45
reedipstevemar : just wanted to know the reason why the folder was named as command-objects01:45
reedipstevemar: any reason/document which I can refer to?01:45
*** heyongli has left #openstack-sdks01:45
stevemarreedip: no reason, do you have an alternate suggestion?01:46
reedipstevemar: no actually... I am writing a new documentation for another project, so wanted to know the reason why openstackclient has the folder named command-objects01:48
reedipstevemar: actually I was not able to link command-objects to the RST files we make.... they are not objects per se, but whole commands.... thats why I had the doubt01:49
stevemarreedip: i think it's whatever dtroyer or i felt like naming it that day :)01:49
*** Yanyanhu has joined #openstack-sdks01:49
reedipstevemar: hehe ... okay, maybe we can consider it in the future once.. what do you think ?01:50
stevemarreedip: it was dtroyer, you can blame him! https://github.com/openstack/python-openstackclient/commit/254910d3ce34c954551a0827aa8727d6367f48f301:51
reedipyikes...  :) , okay I will ask him01:52
*** heyongli has joined #openstack-sdks01:52
reedipthanks stevemar ....01:52
stevemarreedip: doesn't matter too much to me, if you want to change it, go ahead an propose something - if it's better we'll merge it ^_^01:52
reedipstevemar : will ask dtroyer before proceeding, he may have some specific reason .. if not then will definitely think and propose something01:53
*** heyongli has quit IRC01:54
*** heyongli has joined #openstack-sdks01:55
stevemarreedip: alrighty01:55
*** heyongli has quit IRC01:56
*** heyongli has joined #openstack-sdks01:57
*** alex_xu_ has joined #openstack-sdks02:02
*** heyongli has quit IRC02:04
*** heyongli has joined #openstack-sdks02:05
*** alex_xu has quit IRC02:05
*** lhcheng has quit IRC02:06
openstackgerritReedip proposed openstack/python-openstackclient: Add "router remove port" to osc  https://review.openstack.org/28169402:07
*** fzdarsky|afk has quit IRC02:15
*** heyongli has quit IRC02:15
*** heyongli has joined #openstack-sdks02:15
reedipstevemar: can you review ^^ and its sister patch https://review.openstack.org/#/c/281691/ if you have time ?02:15
*** fzdarsky has joined #openstack-sdks02:21
stevemarreedip: yes sir02:21
reedipstevemar: thank you sir :)02:22
*** heyongli has quit IRC02:25
*** heyongli has joined #openstack-sdks02:25
*** alex_xu_ has quit IRC02:31
*** alex_xu has joined #openstack-sdks02:34
openstackgerritReedip proposed openstack/python-openstackclient: Add external network options to osc network create  https://review.openstack.org/29223402:34
stevemarreedip: i'll have to look at them tomorrow, falling asleep here!02:35
*** heyongli has quit IRC02:35
reedipstevemar: yeah sure, please do ... thanks anyway :)02:35
*** heyongli has joined #openstack-sdks02:36
*** knikolla has quit IRC02:36
*** heyongli has quit IRC02:44
*** eliqiao has joined #openstack-sdks02:45
*** heyongli has joined #openstack-sdks02:45
*** heyongli has quit IRC02:45
*** heyongli has joined #openstack-sdks02:46
*** eliqiao_ has quit IRC02:47
*** heyongli has quit IRC02:52
*** markvoelker has joined #openstack-sdks02:55
*** lhcheng has joined #openstack-sdks02:56
*** lhcheng_ has joined #openstack-sdks02:57
*** markvoelker has quit IRC03:01
*** lhcheng has quit IRC03:01
*** Yanyanhu has quit IRC03:08
*** Yanyanhu has joined #openstack-sdks03:09
*** RuiChen has quit IRC03:14
*** RuiChen has joined #openstack-sdks03:16
*** lhcheng has joined #openstack-sdks03:20
*** lhcheng_ has quit IRC03:20
*** eliqiao_ has joined #openstack-sdks03:21
*** lhcheng_ has joined #openstack-sdks03:22
*** eliqiao has quit IRC03:24
*** lhcheng has quit IRC03:24
*** lhcheng has joined #openstack-sdks03:35
*** lhcheng_ has quit IRC03:39
*** eliqiao_ is now known as eliqiao03:41
*** lhcheng has quit IRC03:47
RuiChenhi sheel , thanks showing the background information, I got it, https://review.openstack.org/#/c/293661/303:47
sheelRuiChen: you are welcome03:48
openstackgerritReedip proposed openstack/python-openstackclient: Add "router remove port" to osc  https://review.openstack.org/28169403:49
reedipRuiChen: ^^ updated with your comments03:54
dtroyerreedip: The reason is that we use the word 'object' to refer to the resources being manipulated, as we use the word 'action' to refer to the verbs.  In retrospect, 'resource' would have probably been better, but all of the docs (Command Structure, etc) use object and action.03:54
dtroyerThe files in command-objects dir are named for the object/resource03:55
reedipdtroyer: okay ...03:55
dtroyerrather, the primary object when there might be two, such as in 'server add volume'03:55
RuiChenreedip: cool, +1 :-)03:56
*** salv-orlando has joined #openstack-sdks03:56
reedipdtroyer : but the word object  is bit of a misnomer, in my honest opinion.. I agree that Resource would have been a better option. But this is just my opinion, I just wanted to know the reason behind the naming convention03:56
reedipRuiChen : Thanks :)03:57
dtroyerreedip: object is too overloaded, yes.  but it is accurate as part of English grammar: subject verb object03:58
dtroyerthe commands were originally verb object03:58
dtroyerwe swapped them to simplify bash completion, and somewhere along the way I changed verb to action03:58
dtroyerI'm not sure if changing object to resource now is a good idea or not…if it is too confusing for non-native-English speakers that might be enough of a reason to do it03:59
reedipdtroyer : I would also not like it to change, unless there is a good enough concern....04:00
*** salv-orlando has quit IRC04:10
*** markvoelker has joined #openstack-sdks04:47
*** markvoelker has quit IRC04:51
*** lifeless has quit IRC04:55
*** lifeless has joined #openstack-sdks04:56
*** lhcheng has joined #openstack-sdks05:00
*** salv-orlando has joined #openstack-sdks05:23
*** salv-orlando has quit IRC05:34
*** stephen_m has joined #openstack-sdks05:52
*** stephen_m has left #openstack-sdks05:53
*** yanghy has joined #openstack-sdks06:11
*** amotoki has joined #openstack-sdks06:14
openstackgerritReedip proposed openstack/python-openstackclient: Trivial-Fix : Add a ' to the choices documentation  https://review.openstack.org/29441206:24
openstackgerritReedip proposed openstack/python-openstackclient: Trivial-Fix : Add a ' to the choices documentation  https://review.openstack.org/29441206:25
*** salv-orlando has joined #openstack-sdks06:33
*** ankit_ag has joined #openstack-sdks06:33
*** yanghy has quit IRC06:39
*** salv-orlando has quit IRC06:41
*** gildub has quit IRC06:46
openstackgerritReedip proposed openstack/python-openstackclient: Add provider network options to osc network create  https://review.openstack.org/29442206:46
*** markvoelker has joined #openstack-sdks06:48
*** markvoelker has quit IRC06:52
*** yanghy has joined #openstack-sdks06:54
*** salv-orlando has joined #openstack-sdks07:14
*** salv-orl_ has joined #openstack-sdks07:16
*** salv-orlando has quit IRC07:19
*** yanghy has quit IRC07:22
*** yanghy has joined #openstack-sdks07:32
*** BobBall_ has joined #openstack-sdks07:33
*** BobBall_ is now known as Guest9218507:34
*** e0ne has joined #openstack-sdks07:35
*** BobBall has quit IRC07:36
*** BobBall has joined #openstack-sdks07:38
*** Guest92185 has quit IRC07:38
*** BobBall is now known as Guest3632607:39
*** yanghy has quit IRC07:41
*** e0ne has quit IRC07:41
*** lhcheng has quit IRC07:43
openstackgerritReedip proposed openstack/python-openstackclient: Add external network options to osc network create  https://review.openstack.org/29223407:45
*** salv-orl_ has quit IRC08:03
*** Yanyanhu has quit IRC08:27
*** reedip is now known as outofmemory09:01
*** Yanyanhu has joined #openstack-sdks09:02
*** salv-orlando has joined #openstack-sdks09:24
*** Yanyanhu has quit IRC09:30
*** alex_xu has quit IRC09:39
*** Guest36326 is now known as BobBall09:40
*** alex_xu has joined #openstack-sdks09:41
*** sdague has joined #openstack-sdks09:42
*** dims has joined #openstack-sdks09:43
*** cdent has joined #openstack-sdks10:15
*** alex_xu has quit IRC10:27
*** alex_xu has joined #openstack-sdks10:28
*** rtheis has joined #openstack-sdks10:35
*** amotoki has quit IRC10:36
*** amotoki has joined #openstack-sdks10:46
*** BobBall_ has joined #openstack-sdks10:59
*** BobBall_ is now known as Guest8647310:59
*** BobBall has quit IRC11:02
*** Guest86473 has quit IRC11:03
*** BobBall has joined #openstack-sdks11:04
*** BobBall is now known as Guest7227011:04
*** Guest72270 is now known as BobBall211:07
*** e0ne has joined #openstack-sdks11:08
openstackgerritTang Chen proposed openstack/python-openstackclient: Enhance exception handling for "network delete" command  https://review.openstack.org/29399711:08
*** amotoki_ has joined #openstack-sdks11:17
*** amotoki has quit IRC11:20
*** amotoki_ has quit IRC11:27
*** amotoki has joined #openstack-sdks11:27
*** thrash|g0ne is now known as thrash11:31
openstackgerritMerged openstack/python-openstackclient: Trivial-Fix : Add a ' to the choices documentation  https://review.openstack.org/29441211:31
*** amotoki has quit IRC11:39
*** Qiming has quit IRC11:58
*** Yanyanhu has joined #openstack-sdks12:15
*** Yanyanhu has quit IRC12:19
openstackgerritTang Chen proposed openstack/python-openstackclient: Enhance exception handling for "network delete" command  https://review.openstack.org/29399712:20
*** Qiming has joined #openstack-sdks12:24
openstackgerritAnkit Agrawal proposed openstack/python-openstacksdk: Fix image member apis  https://review.openstack.org/29157212:24
*** lucasagomes is now known as lucas-hungry12:25
openstackgerritRichard Theis proposed openstack/python-openstackclient: Refactor security group rule create to use SDK  https://review.openstack.org/29411812:26
*** markvoelker has joined #openstack-sdks12:32
*** ankit_ag has quit IRC12:33
*** fzdarsky is now known as fzdarsky|lunch12:34
*** jaypipes is now known as leakypipes12:36
*** openstackgerrit has quit IRC12:48
*** openstackgerrit has joined #openstack-sdks12:49
*** fzdarsky|lunch is now known as fzdarsky12:51
*** BobBall2 is now known as BobBall13:06
*** salv-orlando has quit IRC13:06
*** lucas-hungry is now known as lucasagomes13:31
*** singhj has joined #openstack-sdks13:32
*** cleong has joined #openstack-sdks13:35
*** sdague has quit IRC13:45
*** e0ne has quit IRC13:54
*** e0ne has joined #openstack-sdks13:55
openstackgerritRichard Theis proposed openstack/python-openstacksdk: Consistent resource.prop for timestamps and booleans (telemetry)  https://review.openstack.org/29460413:56
*** cdent has quit IRC13:56
*** knikolla has joined #openstack-sdks13:56
*** cdent has joined #openstack-sdks14:03
*** knikolla has quit IRC14:07
*** erlon has joined #openstack-sdks14:07
*** knikolla has joined #openstack-sdks14:08
*** sigmavirus24_awa is now known as sigmavirus2414:12
*** singhj has quit IRC14:16
rtheisbriancurtin: good morning, I was wondering if we could get another release of SDK to pull in https://github.com/openstack/python-openstacksdk/commit/d99bbe80ca3f2000840e66032b983a01c99e0e75 ?  OSC is working on several commands to use this.14:17
briancurtinrtheis: sure. let me take a quick look around and see if there’s anything else we can squeeze in - i have a few emails of reviews updates that i’m a bit behind on14:18
rtheisbriancurtin: thank you14:18
*** reedip__ has joined #openstack-sdks14:21
briancurtinrtheis: once those key_manager and telemetry ones that i pushed through get merged, i’ll do the release14:24
rtheisbriancurtin: thank you14:24
openstackgerritMerged openstack/python-openstacksdk: Fix key manager secret resource object  https://review.openstack.org/29344014:25
*** amotoki has joined #openstack-sdks14:25
openstackgerritSheel Rana proposed openstack/python-openstackclient: Add support for removing volume-type-access  https://review.openstack.org/29368414:32
*** singhj has joined #openstack-sdks14:33
*** amotoki has quit IRC14:33
*** knikolla has quit IRC14:33
stevemarrtheis: dhellmann dtroyer thoughts on: https://etherpad.openstack.org/p/state-of-osc-plugins14:34
stevemarwas going to blast it to the ML14:34
dtroyerstevemar: I asked the requirements question in https://review.openstack.org/#/c/292541/14:36
stevemardtroyer: we spoke about it in the meeting yesterday14:36
stevemarwe all think it should be in requirements14:36
dtroyerI think it is valid for a library that also has a plugin in the same package (maybe that's the error?) to not have openstackclient in requirements.txt14:36
*** singhj has quit IRC14:37
dtroyerunilaterally?14:37
rtheisstevemar: looks good to me pending resolution to requirements question14:37
stevemar"library that also has a plugin in the same package" ? can you use real examples :)14:37
dtroyershould/could the plugin go into a separate package?   I'm not so concerned about devs and testing, but the end-user installing many unnedded deps14:37
openstackgerritMerged openstack/python-openstacksdk: Consistent resource.prop for timestamps and booleans (telemetry)  https://review.openstack.org/29460414:38
dtroyerheatclient?  congressclient?  those are the only two I've looked at in detail and it's been a while.14:38
*** knikolla has joined #openstack-sdks14:38
dtroyerthe use-case is wanting the python lib for some reason but not a cli14:38
dtroyermaybe I'm the only one worried about that?14:39
stevemardtroyer: i think so14:39
*** srini has quit IRC14:39
dtroyerit's that 'installing a thousand deps' stuff I grew an allergy to, especially on Windows14:39
dtroyerok, I can live with that ;)14:39
stevemardtroyer: most are going to consume it the same time - and they will probably want keystone + other CLI support too14:39
stevemari doubt anyone is using it as a library, jeez i hope not14:40
stevemarprobably for find_resources :(14:40
dtroyernot osc, but keystone+nova+glance+heat… app devs might do that14:40
stevemarbut with things synced up in GR, then it shouldn't be that much of an issue14:40
dtroyeroh, I see, you're thinking of plugins calling into openstackclient.* namespace?14:40
stevemarmmm yes14:40
dtroyerI was purely at the package level14:41
stevemarand you're think of "what if i'm a heat app developer and i just want the python bindings"14:41
* dtroyer quotes Emily Litella (and reveals his advanced age) 14:41
dtroyer"Never Mind"14:41
stevemardtroyer: we'll see what doug says, maybe we're both wrong :O14:43
stevemardtroyer: any other notes you wanted to drop in? I included an 'announcements' section.. and i tried to clean it up a bit, i plan on copying and pasting it to a mailing list note14:44
stevemardtroyer: alternatively, you could, since you are el PTL grande14:44
dtroyerI think there are multiple levels to consider here and I don't have it all in my head14:45
dtroyerme send the email?  I could but it wouldn't be today, I'm on a short schedule again.  I will get through reading it right now though14:46
stevemardtroyer: i'm OK with waiting til you are happy with the state of your head14:46
openstackgerritKyrylo Romanenko proposed openstack/python-openstackclient: Functional tests for openstackclient help messages  https://review.openstack.org/29304214:50
*** amotoki has joined #openstack-sdks14:53
*** singhj has joined #openstack-sdks14:53
reedip__rtheis: ping14:53
rtheisreedip__: hi14:53
reedip__rtheis: good morning (?)14:53
rtheisyes14:53
rtheismorning here14:54
reedip__rtheis: Ok, I was right :)  ... I have a doubt wrt https://review.openstack.org/#/c/281694/14:54
rtheisreedip__: ok14:54
reedip__https://review.openstack.org/#/c/281694/19/openstackclient/network/v2/router_interface.py , Line#6314:54
*** alex_xu has quit IRC14:55
rtheisreedip__: a new sdk release is coming soon14:55
reedip__rtheis: Okay, I was saying that https://review.openstack.org/#/c/287573/4/openstack/network/v2/_proxy.py is already having the support14:56
reedip__rtheis: so I think once the SDK is released, some of the comments may be skipped?14:56
rtheisreedip__: it does but that hasn't been released yet (beyond being in master)14:56
rtheisreedip__: what comments?14:57
reedip__rtheis: the one in https://review.openstack.org/#/c/281694/19/openstackclient/network/v2/router_interface.py , Line#6314:57
reedip__actually only one comment, I guess14:57
rtheisreedip__: once released then we'll need to osc requirements updated to include it14:58
rtheisreedip__: then the patches are good to go14:58
reedip__rtheis: okay, that I understand , but I am having one concern...14:59
rtheissorry, what is the concern?14:59
*** alex_xu has joined #openstack-sdks14:59
reedip__rtheis: is it possible to sync openstacksdk and openstackclient ; I mean waiting for the release of the SDK to be updated to the requirements of the client is a bit of a manual work isnt it ? ( Or am I missing something here)15:00
rtheisreedip__: yes it is a bit of manual work ... how do you propose syncing?15:01
*** cleong has quit IRC15:01
reedip__rtheis: why cant openstackclient pull up the master for sdk and work on it? Is there any issue there?15:02
reedip__rtheis: I am just trying to understand the concept first...15:02
*** fzdarsky has quit IRC15:02
rtheisreedip__: when both osc and sdk are on master that is fine15:04
rtheisreedip__: the problem occurs when we want to cut an osc release15:04
rtheisreedip__: the osc release would document new commands but they would only work if installed with sdk master15:04
stevemarreedip__: it's fine for development, but we can't depend on an unreleased version :)15:05
*** gouthamr has joined #openstack-sdks15:05
reedip__stevemar, rtheis: when is the OSC release scheduled?15:10
*** fzdarsky has joined #openstack-sdks15:10
reedip__or is it already cut for Mitaka ?15:10
briancurtinrtheis: https://pypi.python.org/pypi/openstacksdk/0.8.215:10
*** salv-orlando has joined #openstack-sdks15:10
rtheisbriancurtin: thank you15:10
rtheisreedip__: sdk 0.8.2 is ready15:11
reedip__braincurtin : thanks ... this is just what we were discussing . . :)15:11
reedip__Yeah, I saw rtheis15:11
reedip__rtheis: so now that it is released, the requirements would be updated... then is there a timeframe by when the patches need to be submitted for Mitaka Cutoff?15:12
*** fzdarsky has quit IRC15:12
rtheisreedip__: I'll defer to dtroyer and stevemar for details on the release schedule15:12
reedip__rtheis: anyways, I think I should republish the patches which are linked to this ...15:13
rtheisok15:13
reedip__thanks rtheis and stevemar for the information ...15:14
rtheisreedip__: you're welcome15:14
*** amotoki has quit IRC15:18
*** e0ne has quit IRC15:23
*** salv-orlando has quit IRC15:24
openstackgerritReedip proposed openstack/python-openstackclient: Add "router add port" to osc  https://review.openstack.org/28169115:24
reedip__ rthies: Patch#A ^^15:25
openstackgerritReedip proposed openstack/python-openstackclient: Add "router remove port" to osc  https://review.openstack.org/28169415:25
openstackgerritReedip proposed openstack/python-openstackclient: Add "router remove port" to osc  https://review.openstack.org/28169415:27
*** singhj has quit IRC15:27
reedip__rtheis: Patch #B15:28
openstackgerritReedip proposed openstack/python-openstackclient: Add Subnet interface to router  https://review.openstack.org/28971615:28
*** cdent has quit IRC15:28
rtheisok15:28
*** cdent has joined #openstack-sdks15:30
*** e0ne has joined #openstack-sdks15:30
*** singhj has joined #openstack-sdks15:31
openstackgerritReedip proposed openstack/python-openstackclient: Add Subnet interface to router  https://review.openstack.org/28971615:32
*** david-lyle has quit IRC15:32
reedip__rtheis : And the final patch :) ^^15:32
rtheisok15:33
*** cdent has quit IRC15:33
reedip__rtheis: Thanks a lot for your review comments15:33
*** david-lyle has joined #openstack-sdks15:33
rtheisyw15:33
*** cdent has joined #openstack-sdks15:43
*** fzdarsky has joined #openstack-sdks15:56
*** cdent_ has joined #openstack-sdks15:56
openstackgerritReedip proposed openstack/python-openstackclient: Add external network options to osc network create  https://review.openstack.org/29223415:56
reedip__stevemar: Thank you for the review.. updated ^^15:57
*** cdent has quit IRC15:58
*** cdent_ is now known as cdent15:58
*** david-lyle has quit IRC16:00
*** david-lyle has joined #openstack-sdks16:01
openstackgerritMerged openstack/api-wg: Header non-proliferation guideline  https://review.openstack.org/28038116:04
*** sdague has joined #openstack-sdks16:12
dtroyerreedip__: The current release is what is/will be stable/mitaka.  Remember, we don't sync to the main release schedule, we just pick one to branch at the client branch time16:14
reedip__dtroyer: Just wanted to know when would the branch occur ? Any specific date?16:15
dtroyerI don't know when those get cut16:16
*** e0ne has quit IRC16:17
openstackgerritBrian Curtin proposed openstack/python-openstacksdk: [WIP] Refactor Resource to better serve Proxy  https://review.openstack.org/28999816:18
reedip__dtroyer: umm... okay ...16:18
dtroyerit was tagged last week: http://git.openstack.org/cgit/openstack/python-openstackclient/log/?h=stable/mitaka16:19
briancurtinBobBall: fyi your SDK change from the other day was released in https://pypi.python.org/pypi/openstacksdk/0.8.216:20
reedip__dtroyer: trying to figure it out.... the one by dhellmann I guess...16:23
*** cdent has quit IRC16:24
*** cdent has joined #openstack-sdks16:24
dtroyeryes16:26
*** Qiming has quit IRC16:27
openstackgerritKyrylo Romanenko proposed openstack/python-openstackclient: Functional tests for openstackclient help messages  https://review.openstack.org/29304216:28
*** lhcheng has joined #openstack-sdks16:31
*** alex_xu has quit IRC16:32
*** dims_ has joined #openstack-sdks16:33
*** dims has quit IRC16:34
*** alex_xu has joined #openstack-sdks16:37
*** salv-orlando has joined #openstack-sdks16:41
openstackgerritDean Troyer proposed openstack/python-openstackclient: Fix keypair create --public-key  https://review.openstack.org/29470916:43
*** salv-orlando has quit IRC16:51
*** singhj has quit IRC16:53
*** salv-orlando has joined #openstack-sdks16:53
*** singhj has joined #openstack-sdks16:57
*** cdent has quit IRC17:02
*** singhj has quit IRC17:03
*** cdent has joined #openstack-sdks17:03
*** cdent has quit IRC17:03
*** cdent has joined #openstack-sdks17:08
*** singhj has joined #openstack-sdks17:20
*** e0ne has joined #openstack-sdks17:37
*** lucasagomes is now known as lucas-afk17:44
*** david-lyle_ has joined #openstack-sdks17:44
*** david-lyle has quit IRC17:45
*** david-lyle_ is now known as david-lyle17:46
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Fix keypair create --public-key  https://review.openstack.org/29470917:48
*** knikolla has quit IRC18:19
*** knikolla has joined #openstack-sdks18:21
openstackgerritRichard Theis proposed openstack/python-openstackclient: Devref: Document OSC interfaces available to plugins  https://review.openstack.org/29254118:23
*** lbragstad has quit IRC18:49
*** lbragstad has joined #openstack-sdks18:49
*** singhj has quit IRC18:50
*** singhj has joined #openstack-sdks19:05
openstackgerritRichard Theis proposed openstack/python-openstacksdk: Consistent resource.prop for timestamps and booleans (orchestration)  https://review.openstack.org/29476619:05
elmikosdague: ping19:08
sdagueelmiko: what's up?19:10
elmikojust curious to pick your brain a little about http://specs.openstack.org/openstack/api-wg/guidelines/errors.html19:11
elmikowhat do you have in mind for the error links?19:11
*** e0ne has quit IRC19:12
*** chlong has quit IRC19:12
*** etoews has quit IRC19:15
*** etoews has joined #openstack-sdks19:16
*** cdent has quit IRC19:16
*** e0ne has joined #openstack-sdks19:22
elmikosdague: were those meant to be informational style links (for example, back to the api docs), or a link to something like a json-home doc that the server would produce?19:22
sdagueelmiko: my feeling is they should be links back to the api docs19:22
elmikosdague: ok, cool. thanks!19:22
sdaguejson-home is an expired spec, and apparently looks a bit dead - https://tools.ietf.org/html/draft-nottingham-json-home-0319:23
elmikoyea, i knew it was on the edge. i was hopeful though ;)19:23
sdagueelmiko: but, we kind of need a better api publish process before we can reasonably expect errors to be up on the api site somewhere19:23
elmiko+119:24
elmikosdague: i can see how ideally this field would be used to send a user to a specific spot in the api docs (assuming said publishing process). i just wanted to make sure i understood what you were hinting at in the guideline.19:25
sdaguewhich, is actually a thing I've been POCing this week. And will be spending some time with annegentle next week to sort out19:25
elmikooh, nice19:25
sdagueelmiko: right, that was my idea, it should be a real link19:25
sdagueit's just... it's hard to quite say that until we have the ability to put content at that place19:25
elmikobut, like you said, there will need to be some way to programmatically coordinate between the api-doc site and the code producing the error19:25
elmikoimo, seems like a nice fit for autogenerated doc stuffs19:26
sdaguethe way I would actually imagine this is that people will extend exceptions with a unique slug about the issue19:27
elmikothat would be really cool19:27
sdagueand when that exception is caught and translated at the top of the wsgi stack, it will thus link to the right place19:28
elmikoan interesting thought19:28
*** e0ne has quit IRC19:29
*** rtheis has quit IRC19:47
*** singhj has quit IRC20:09
*** fzdarsky is now known as fzdarsky|afk20:11
*** e0ne has joined #openstack-sdks20:15
openstackgerritMerged openstack/python-openstackclient: Functional tests for openstackclient help messages  https://review.openstack.org/29304220:20
*** singhj has joined #openstack-sdks20:23
*** e0ne has quit IRC20:38
openstackgerritMerged openstack/python-openstackclient: Fix keypair create --public-key  https://review.openstack.org/29470920:55
*** sdague has quit IRC21:02
*** leakypipes has quit IRC21:04
*** david-lyle has quit IRC21:06
*** david-lyle has joined #openstack-sdks21:07
knikollastevemar, i would like your opinion on this https://github.com/CCI-MOC/python-openstackclient/commit/41ff4e1635ef2a839ff83a30edc9c58bf121804421:20
stevemarknikolla: looking..21:20
*** gouthamr has quit IRC21:21
stevemarknikolla: so, i think first we have to figure out whats a use case you're trying to solve21:22
stevemarknikolla: it's been a while since i've looked at K2K21:22
knikollastevemar, this is basically for querying a service provider.21:23
knikollathrough K2K21:23
knikollaas there is no way with current openstackclient21:23
stevemarknikolla: and querying will allow you perform an operation on the SP?21:24
*** ryansb_ has joined #openstack-sdks21:24
*** ryansb_ has quit IRC21:24
*** ryansb_ has joined #openstack-sdks21:24
*** charz_ has joined #openstack-sdks21:25
knikollastevemar, yes. I've tried it with basic commands and it worked21:25
*** charz has quit IRC21:25
*** ryansb has quit IRC21:25
*** christi3k has quit IRC21:25
*** _tutima has quit IRC21:25
*** ryansb_ is now known as ryansb21:25
knikollaoperation will be directed to the SP21:25
*** mordred has quit IRC21:26
*** dhellmann has quit IRC21:26
*** redrobot has quit IRC21:26
*** dhellmann has joined #openstack-sdks21:26
stevemarknikolla: *not_bad.gif*21:26
*** mordred has joined #openstack-sdks21:26
*** christi3k has joined #openstack-sdks21:27
stevemarknikolla: write something up, toss up some code, show some results, let's see how it works21:28
stevemarthat'll be awesome if it's that easy...21:28
knikollastevemar, i'll have to wait on this https://review.openstack.org/#/c/276350/21:28
stevemarjust add an extra --sp my_pub_cloud and you're done21:28
stevemargah that21:28
stevemaryeah, i need to get on that21:28
stevemar:(21:28
*** redrobot has joined #openstack-sdks21:29
*** redrobot is now known as Guest9839921:29
stevemarmaybe this weekend i'll look at it21:29
knikollastevemar, the patch he proposed doesn't work. but can easily be fixed if he puts the effort.21:30
knikollai provided some comments in the review.21:30
stevemarknikolla: don't hesitate to pull it down yourself and fix it up21:30
knikollaand fixing those 2 errors made it work.21:30
knikollahe's already put something like 12 patchsets. it feels weird.21:31
knikollastevemar21:31
stevemarknikolla: just add yourself as a co-author, in the commit message write: "Co-Authored-By: FirstName LastName <email>"21:31
stevemarknikolla: nah, don't think of it like that21:31
stevemarknikolla: leave a comment before doing it21:32
stevemar"I have solved these issues locally, do you mind if i post a follow on patch?"21:32
stevemari'll reply asking you to please post one :)21:32
knikollastevemar, ok, i'll do that. in "Download", which of the options do i copy/paste21:33
*** _tutima has joined #openstack-sdks21:34
knikollastevemar, the web ui is confusing.21:34
stevemarknikolla: go to your osc master branch21:34
stevemarknikolla: pull from master `git pull origin master`21:34
stevemarknikolla: download the change: `git review -d 276350`21:35
stevemarknikolla: <hack hack hack>21:35
stevemarknikolla: `git add <files>`21:35
stevemarknikolla: `git commit --amend` << please add your name as a co-author like i said above21:35
stevemarknikolla: `git review`21:35
stevemardone21:35
stevemari would be very appreciate if you got that patch working!21:36
knikollastevemar, thanks a lot. I didn't know the "git review -d <patch>"21:36
stevemarknikolla: it's awesome21:36
stevemarknikolla: there is also a cherry-pick option -- git review -x <patch>21:36
knikolla*pulls up 'man git-review'21:36
*** Guest98399 is now known as redrobot21:37
stevemarknikolla: heading out for the evening, thanks for all your work as of late21:37
stevemarknikolla: if you have any questions, please post here and i'll see them when i log back on21:38
knikollastevemar, thanks for all the help! it's been a pleasure.21:38
stevemar:)21:41
*** knikolla has quit IRC21:48
*** erlon has quit IRC21:57
*** sigmavirus24 is now known as sigmavirus24_awa22:00
*** cdent has joined #openstack-sdks22:15
*** cdent has quit IRC22:17
*** singhj has quit IRC22:19
*** salv-orl_ has joined #openstack-sdks22:28
*** salv-orlando has quit IRC22:30
*** singhj has joined #openstack-sdks22:34
*** singhj has quit IRC22:38
openstackgerritTimothy Symanczyk proposed openstack/python-openstackclient: Improve error for token issue command without auth  https://review.openstack.org/29484422:45
*** sheel has quit IRC22:47
openstackgerritReedip proposed openstack/python-openstackclient: Add Subnet interface to router  https://review.openstack.org/28971622:47
*** knikolla has joined #openstack-sdks22:48
openstackgerritReedip proposed openstack/python-openstackclient: Add external network options to osc network create  https://review.openstack.org/29223422:57
openstackgerritNicolas Simonds proposed openstack/python-openstackclient: Image API v2: make volume_type optional  https://review.openstack.org/29484823:08
*** lhcheng has quit IRC23:21
*** lhcheng has joined #openstack-sdks23:35
*** lhcheng has quit IRC23:43
*** markvoelker has quit IRC23:44
*** e0ne has joined #openstack-sdks23:44
*** gouthamr has joined #openstack-sdks23:54
*** gouthamr_ has joined #openstack-sdks23:55
*** gouthamr has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!