*** reedip__ has quit IRC | 00:04 | |
*** dims has joined #openstack-sdks | 00:07 | |
*** eliqiao_ has joined #openstack-sdks | 00:08 | |
*** alex_xu has quit IRC | 00:10 | |
*** eliqiao has quit IRC | 00:11 | |
*** alex_xu has joined #openstack-sdks | 00:21 | |
*** gildub has joined #openstack-sdks | 00:33 | |
*** Qiming has quit IRC | 00:48 | |
*** boris-42 has quit IRC | 01:04 | |
*** knikolla has joined #openstack-sdks | 01:04 | |
openstackgerrit | Qichen Hao proposed openstack/cliff: Add the return value for take_action function https://review.openstack.org/293910 | 01:07 |
---|---|---|
*** salv-orlando has joined #openstack-sdks | 01:16 | |
*** salv-orlando has quit IRC | 01:17 | |
*** salv-orlando has joined #openstack-sdks | 01:18 | |
*** salv-orl_ has quit IRC | 01:19 | |
*** dims has quit IRC | 01:21 | |
*** salv-orlando has quit IRC | 01:22 | |
*** thrash is now known as thrash|g0ne | 01:22 | |
*** Qiming has joined #openstack-sdks | 01:24 | |
openstackgerrit | Merged openstack/python-openstackclient: update docs with status of plugins https://review.openstack.org/294311 | 01:38 |
reedip | stevemar: ping | 01:42 |
*** heyongli has joined #openstack-sdks | 01:44 | |
stevemar | reedip: pong | 01:44 |
*** heyongli has quit IRC | 01:44 | |
reedip | stevemar : this is a silly question, but still having a doubt... | 01:44 |
*** heyongli has joined #openstack-sdks | 01:44 | |
reedip | stevemar: I see that the structure for rst is doc/source/command-objects/*.rst | 01:44 |
*** scottda_vacation has quit IRC | 01:45 | |
reedip | stevemar : just wanted to know the reason why the folder was named as command-objects | 01:45 |
reedip | stevemar: any reason/document which I can refer to? | 01:45 |
*** heyongli has left #openstack-sdks | 01:45 | |
stevemar | reedip: no reason, do you have an alternate suggestion? | 01:46 |
reedip | stevemar: no actually... I am writing a new documentation for another project, so wanted to know the reason why openstackclient has the folder named command-objects | 01:48 |
reedip | stevemar: actually I was not able to link command-objects to the RST files we make.... they are not objects per se, but whole commands.... thats why I had the doubt | 01:49 |
stevemar | reedip: i think it's whatever dtroyer or i felt like naming it that day :) | 01:49 |
*** Yanyanhu has joined #openstack-sdks | 01:49 | |
reedip | stevemar: hehe ... okay, maybe we can consider it in the future once.. what do you think ? | 01:50 |
stevemar | reedip: it was dtroyer, you can blame him! https://github.com/openstack/python-openstackclient/commit/254910d3ce34c954551a0827aa8727d6367f48f3 | 01:51 |
reedip | yikes... :) , okay I will ask him | 01:52 |
*** heyongli has joined #openstack-sdks | 01:52 | |
reedip | thanks stevemar .... | 01:52 |
stevemar | reedip: doesn't matter too much to me, if you want to change it, go ahead an propose something - if it's better we'll merge it ^_^ | 01:52 |
reedip | stevemar : will ask dtroyer before proceeding, he may have some specific reason .. if not then will definitely think and propose something | 01:53 |
*** heyongli has quit IRC | 01:54 | |
*** heyongli has joined #openstack-sdks | 01:55 | |
stevemar | reedip: alrighty | 01:55 |
*** heyongli has quit IRC | 01:56 | |
*** heyongli has joined #openstack-sdks | 01:57 | |
*** alex_xu_ has joined #openstack-sdks | 02:02 | |
*** heyongli has quit IRC | 02:04 | |
*** heyongli has joined #openstack-sdks | 02:05 | |
*** alex_xu has quit IRC | 02:05 | |
*** lhcheng has quit IRC | 02:06 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add "router remove port" to osc https://review.openstack.org/281694 | 02:07 |
*** fzdarsky|afk has quit IRC | 02:15 | |
*** heyongli has quit IRC | 02:15 | |
*** heyongli has joined #openstack-sdks | 02:15 | |
reedip | stevemar: can you review ^^ and its sister patch https://review.openstack.org/#/c/281691/ if you have time ? | 02:15 |
*** fzdarsky has joined #openstack-sdks | 02:21 | |
stevemar | reedip: yes sir | 02:21 |
reedip | stevemar: thank you sir :) | 02:22 |
*** heyongli has quit IRC | 02:25 | |
*** heyongli has joined #openstack-sdks | 02:25 | |
*** alex_xu_ has quit IRC | 02:31 | |
*** alex_xu has joined #openstack-sdks | 02:34 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add external network options to osc network create https://review.openstack.org/292234 | 02:34 |
stevemar | reedip: i'll have to look at them tomorrow, falling asleep here! | 02:35 |
*** heyongli has quit IRC | 02:35 | |
reedip | stevemar: yeah sure, please do ... thanks anyway :) | 02:35 |
*** heyongli has joined #openstack-sdks | 02:36 | |
*** knikolla has quit IRC | 02:36 | |
*** heyongli has quit IRC | 02:44 | |
*** eliqiao has joined #openstack-sdks | 02:45 | |
*** heyongli has joined #openstack-sdks | 02:45 | |
*** heyongli has quit IRC | 02:45 | |
*** heyongli has joined #openstack-sdks | 02:46 | |
*** eliqiao_ has quit IRC | 02:47 | |
*** heyongli has quit IRC | 02:52 | |
*** markvoelker has joined #openstack-sdks | 02:55 | |
*** lhcheng has joined #openstack-sdks | 02:56 | |
*** lhcheng_ has joined #openstack-sdks | 02:57 | |
*** markvoelker has quit IRC | 03:01 | |
*** lhcheng has quit IRC | 03:01 | |
*** Yanyanhu has quit IRC | 03:08 | |
*** Yanyanhu has joined #openstack-sdks | 03:09 | |
*** RuiChen has quit IRC | 03:14 | |
*** RuiChen has joined #openstack-sdks | 03:16 | |
*** lhcheng has joined #openstack-sdks | 03:20 | |
*** lhcheng_ has quit IRC | 03:20 | |
*** eliqiao_ has joined #openstack-sdks | 03:21 | |
*** lhcheng_ has joined #openstack-sdks | 03:22 | |
*** eliqiao has quit IRC | 03:24 | |
*** lhcheng has quit IRC | 03:24 | |
*** lhcheng has joined #openstack-sdks | 03:35 | |
*** lhcheng_ has quit IRC | 03:39 | |
*** eliqiao_ is now known as eliqiao | 03:41 | |
*** lhcheng has quit IRC | 03:47 | |
RuiChen | hi sheel , thanks showing the background information, I got it, https://review.openstack.org/#/c/293661/3 | 03:47 |
sheel | RuiChen: you are welcome | 03:48 |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add "router remove port" to osc https://review.openstack.org/281694 | 03:49 |
reedip | RuiChen: ^^ updated with your comments | 03:54 |
dtroyer | reedip: The reason is that we use the word 'object' to refer to the resources being manipulated, as we use the word 'action' to refer to the verbs. In retrospect, 'resource' would have probably been better, but all of the docs (Command Structure, etc) use object and action. | 03:54 |
dtroyer | The files in command-objects dir are named for the object/resource | 03:55 |
reedip | dtroyer: okay ... | 03:55 |
dtroyer | rather, the primary object when there might be two, such as in 'server add volume' | 03:55 |
RuiChen | reedip: cool, +1 :-) | 03:56 |
*** salv-orlando has joined #openstack-sdks | 03:56 | |
reedip | dtroyer : but the word object is bit of a misnomer, in my honest opinion.. I agree that Resource would have been a better option. But this is just my opinion, I just wanted to know the reason behind the naming convention | 03:56 |
reedip | RuiChen : Thanks :) | 03:57 |
dtroyer | reedip: object is too overloaded, yes. but it is accurate as part of English grammar: subject verb object | 03:58 |
dtroyer | the commands were originally verb object | 03:58 |
dtroyer | we swapped them to simplify bash completion, and somewhere along the way I changed verb to action | 03:58 |
dtroyer | I'm not sure if changing object to resource now is a good idea or not…if it is too confusing for non-native-English speakers that might be enough of a reason to do it | 03:59 |
reedip | dtroyer : I would also not like it to change, unless there is a good enough concern.... | 04:00 |
*** salv-orlando has quit IRC | 04:10 | |
*** markvoelker has joined #openstack-sdks | 04:47 | |
*** markvoelker has quit IRC | 04:51 | |
*** lifeless has quit IRC | 04:55 | |
*** lifeless has joined #openstack-sdks | 04:56 | |
*** lhcheng has joined #openstack-sdks | 05:00 | |
*** salv-orlando has joined #openstack-sdks | 05:23 | |
*** salv-orlando has quit IRC | 05:34 | |
*** stephen_m has joined #openstack-sdks | 05:52 | |
*** stephen_m has left #openstack-sdks | 05:53 | |
*** yanghy has joined #openstack-sdks | 06:11 | |
*** amotoki has joined #openstack-sdks | 06:14 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Trivial-Fix : Add a ' to the choices documentation https://review.openstack.org/294412 | 06:24 |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Trivial-Fix : Add a ' to the choices documentation https://review.openstack.org/294412 | 06:25 |
*** salv-orlando has joined #openstack-sdks | 06:33 | |
*** ankit_ag has joined #openstack-sdks | 06:33 | |
*** yanghy has quit IRC | 06:39 | |
*** salv-orlando has quit IRC | 06:41 | |
*** gildub has quit IRC | 06:46 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add provider network options to osc network create https://review.openstack.org/294422 | 06:46 |
*** markvoelker has joined #openstack-sdks | 06:48 | |
*** markvoelker has quit IRC | 06:52 | |
*** yanghy has joined #openstack-sdks | 06:54 | |
*** salv-orlando has joined #openstack-sdks | 07:14 | |
*** salv-orl_ has joined #openstack-sdks | 07:16 | |
*** salv-orlando has quit IRC | 07:19 | |
*** yanghy has quit IRC | 07:22 | |
*** yanghy has joined #openstack-sdks | 07:32 | |
*** BobBall_ has joined #openstack-sdks | 07:33 | |
*** BobBall_ is now known as Guest92185 | 07:34 | |
*** e0ne has joined #openstack-sdks | 07:35 | |
*** BobBall has quit IRC | 07:36 | |
*** BobBall has joined #openstack-sdks | 07:38 | |
*** Guest92185 has quit IRC | 07:38 | |
*** BobBall is now known as Guest36326 | 07:39 | |
*** yanghy has quit IRC | 07:41 | |
*** e0ne has quit IRC | 07:41 | |
*** lhcheng has quit IRC | 07:43 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add external network options to osc network create https://review.openstack.org/292234 | 07:45 |
*** salv-orl_ has quit IRC | 08:03 | |
*** Yanyanhu has quit IRC | 08:27 | |
*** reedip is now known as outofmemory | 09:01 | |
*** Yanyanhu has joined #openstack-sdks | 09:02 | |
*** salv-orlando has joined #openstack-sdks | 09:24 | |
*** Yanyanhu has quit IRC | 09:30 | |
*** alex_xu has quit IRC | 09:39 | |
*** Guest36326 is now known as BobBall | 09:40 | |
*** alex_xu has joined #openstack-sdks | 09:41 | |
*** sdague has joined #openstack-sdks | 09:42 | |
*** dims has joined #openstack-sdks | 09:43 | |
*** cdent has joined #openstack-sdks | 10:15 | |
*** alex_xu has quit IRC | 10:27 | |
*** alex_xu has joined #openstack-sdks | 10:28 | |
*** rtheis has joined #openstack-sdks | 10:35 | |
*** amotoki has quit IRC | 10:36 | |
*** amotoki has joined #openstack-sdks | 10:46 | |
*** BobBall_ has joined #openstack-sdks | 10:59 | |
*** BobBall_ is now known as Guest86473 | 10:59 | |
*** BobBall has quit IRC | 11:02 | |
*** Guest86473 has quit IRC | 11:03 | |
*** BobBall has joined #openstack-sdks | 11:04 | |
*** BobBall is now known as Guest72270 | 11:04 | |
*** Guest72270 is now known as BobBall2 | 11:07 | |
*** e0ne has joined #openstack-sdks | 11:08 | |
openstackgerrit | Tang Chen proposed openstack/python-openstackclient: Enhance exception handling for "network delete" command https://review.openstack.org/293997 | 11:08 |
*** amotoki_ has joined #openstack-sdks | 11:17 | |
*** amotoki has quit IRC | 11:20 | |
*** amotoki_ has quit IRC | 11:27 | |
*** amotoki has joined #openstack-sdks | 11:27 | |
*** thrash|g0ne is now known as thrash | 11:31 | |
openstackgerrit | Merged openstack/python-openstackclient: Trivial-Fix : Add a ' to the choices documentation https://review.openstack.org/294412 | 11:31 |
*** amotoki has quit IRC | 11:39 | |
*** Qiming has quit IRC | 11:58 | |
*** Yanyanhu has joined #openstack-sdks | 12:15 | |
*** Yanyanhu has quit IRC | 12:19 | |
openstackgerrit | Tang Chen proposed openstack/python-openstackclient: Enhance exception handling for "network delete" command https://review.openstack.org/293997 | 12:20 |
*** Qiming has joined #openstack-sdks | 12:24 | |
openstackgerrit | Ankit Agrawal proposed openstack/python-openstacksdk: Fix image member apis https://review.openstack.org/291572 | 12:24 |
*** lucasagomes is now known as lucas-hungry | 12:25 | |
openstackgerrit | Richard Theis proposed openstack/python-openstackclient: Refactor security group rule create to use SDK https://review.openstack.org/294118 | 12:26 |
*** markvoelker has joined #openstack-sdks | 12:32 | |
*** ankit_ag has quit IRC | 12:33 | |
*** fzdarsky is now known as fzdarsky|lunch | 12:34 | |
*** jaypipes is now known as leakypipes | 12:36 | |
*** openstackgerrit has quit IRC | 12:48 | |
*** openstackgerrit has joined #openstack-sdks | 12:49 | |
*** fzdarsky|lunch is now known as fzdarsky | 12:51 | |
*** BobBall2 is now known as BobBall | 13:06 | |
*** salv-orlando has quit IRC | 13:06 | |
*** lucas-hungry is now known as lucasagomes | 13:31 | |
*** singhj has joined #openstack-sdks | 13:32 | |
*** cleong has joined #openstack-sdks | 13:35 | |
*** sdague has quit IRC | 13:45 | |
*** e0ne has quit IRC | 13:54 | |
*** e0ne has joined #openstack-sdks | 13:55 | |
openstackgerrit | Richard Theis proposed openstack/python-openstacksdk: Consistent resource.prop for timestamps and booleans (telemetry) https://review.openstack.org/294604 | 13:56 |
*** cdent has quit IRC | 13:56 | |
*** knikolla has joined #openstack-sdks | 13:56 | |
*** cdent has joined #openstack-sdks | 14:03 | |
*** knikolla has quit IRC | 14:07 | |
*** erlon has joined #openstack-sdks | 14:07 | |
*** knikolla has joined #openstack-sdks | 14:08 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:12 | |
*** singhj has quit IRC | 14:16 | |
rtheis | briancurtin: good morning, I was wondering if we could get another release of SDK to pull in https://github.com/openstack/python-openstacksdk/commit/d99bbe80ca3f2000840e66032b983a01c99e0e75 ? OSC is working on several commands to use this. | 14:17 |
briancurtin | rtheis: sure. let me take a quick look around and see if there’s anything else we can squeeze in - i have a few emails of reviews updates that i’m a bit behind on | 14:18 |
rtheis | briancurtin: thank you | 14:18 |
*** reedip__ has joined #openstack-sdks | 14:21 | |
briancurtin | rtheis: once those key_manager and telemetry ones that i pushed through get merged, i’ll do the release | 14:24 |
rtheis | briancurtin: thank you | 14:24 |
openstackgerrit | Merged openstack/python-openstacksdk: Fix key manager secret resource object https://review.openstack.org/293440 | 14:25 |
*** amotoki has joined #openstack-sdks | 14:25 | |
openstackgerrit | Sheel Rana proposed openstack/python-openstackclient: Add support for removing volume-type-access https://review.openstack.org/293684 | 14:32 |
*** singhj has joined #openstack-sdks | 14:33 | |
*** amotoki has quit IRC | 14:33 | |
*** knikolla has quit IRC | 14:33 | |
stevemar | rtheis: dhellmann dtroyer thoughts on: https://etherpad.openstack.org/p/state-of-osc-plugins | 14:34 |
stevemar | was going to blast it to the ML | 14:34 |
dtroyer | stevemar: I asked the requirements question in https://review.openstack.org/#/c/292541/ | 14:36 |
stevemar | dtroyer: we spoke about it in the meeting yesterday | 14:36 |
stevemar | we all think it should be in requirements | 14:36 |
dtroyer | I think it is valid for a library that also has a plugin in the same package (maybe that's the error?) to not have openstackclient in requirements.txt | 14:36 |
*** singhj has quit IRC | 14:37 | |
dtroyer | unilaterally? | 14:37 |
rtheis | stevemar: looks good to me pending resolution to requirements question | 14:37 |
stevemar | "library that also has a plugin in the same package" ? can you use real examples :) | 14:37 |
dtroyer | should/could the plugin go into a separate package? I'm not so concerned about devs and testing, but the end-user installing many unnedded deps | 14:37 |
openstackgerrit | Merged openstack/python-openstacksdk: Consistent resource.prop for timestamps and booleans (telemetry) https://review.openstack.org/294604 | 14:38 |
dtroyer | heatclient? congressclient? those are the only two I've looked at in detail and it's been a while. | 14:38 |
*** knikolla has joined #openstack-sdks | 14:38 | |
dtroyer | the use-case is wanting the python lib for some reason but not a cli | 14:38 |
dtroyer | maybe I'm the only one worried about that? | 14:39 |
stevemar | dtroyer: i think so | 14:39 |
*** srini has quit IRC | 14:39 | |
dtroyer | it's that 'installing a thousand deps' stuff I grew an allergy to, especially on Windows | 14:39 |
dtroyer | ok, I can live with that ;) | 14:39 |
stevemar | dtroyer: most are going to consume it the same time - and they will probably want keystone + other CLI support too | 14:39 |
stevemar | i doubt anyone is using it as a library, jeez i hope not | 14:40 |
stevemar | probably for find_resources :( | 14:40 |
dtroyer | not osc, but keystone+nova+glance+heat… app devs might do that | 14:40 |
stevemar | but with things synced up in GR, then it shouldn't be that much of an issue | 14:40 |
dtroyer | oh, I see, you're thinking of plugins calling into openstackclient.* namespace? | 14:40 |
stevemar | mmm yes | 14:40 |
dtroyer | I was purely at the package level | 14:41 |
stevemar | and you're think of "what if i'm a heat app developer and i just want the python bindings" | 14:41 |
* dtroyer quotes Emily Litella (and reveals his advanced age) | 14:41 | |
dtroyer | "Never Mind" | 14:41 |
stevemar | dtroyer: we'll see what doug says, maybe we're both wrong :O | 14:43 |
stevemar | dtroyer: any other notes you wanted to drop in? I included an 'announcements' section.. and i tried to clean it up a bit, i plan on copying and pasting it to a mailing list note | 14:44 |
stevemar | dtroyer: alternatively, you could, since you are el PTL grande | 14:44 |
dtroyer | I think there are multiple levels to consider here and I don't have it all in my head | 14:45 |
dtroyer | me send the email? I could but it wouldn't be today, I'm on a short schedule again. I will get through reading it right now though | 14:46 |
stevemar | dtroyer: i'm OK with waiting til you are happy with the state of your head | 14:46 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-openstackclient: Functional tests for openstackclient help messages https://review.openstack.org/293042 | 14:50 |
*** amotoki has joined #openstack-sdks | 14:53 | |
*** singhj has joined #openstack-sdks | 14:53 | |
reedip__ | rtheis: ping | 14:53 |
rtheis | reedip__: hi | 14:53 |
reedip__ | rtheis: good morning (?) | 14:53 |
rtheis | yes | 14:53 |
rtheis | morning here | 14:54 |
reedip__ | rtheis: Ok, I was right :) ... I have a doubt wrt https://review.openstack.org/#/c/281694/ | 14:54 |
rtheis | reedip__: ok | 14:54 |
reedip__ | https://review.openstack.org/#/c/281694/19/openstackclient/network/v2/router_interface.py , Line#63 | 14:54 |
*** alex_xu has quit IRC | 14:55 | |
rtheis | reedip__: a new sdk release is coming soon | 14:55 |
reedip__ | rtheis: Okay, I was saying that https://review.openstack.org/#/c/287573/4/openstack/network/v2/_proxy.py is already having the support | 14:56 |
reedip__ | rtheis: so I think once the SDK is released, some of the comments may be skipped? | 14:56 |
rtheis | reedip__: it does but that hasn't been released yet (beyond being in master) | 14:56 |
rtheis | reedip__: what comments? | 14:57 |
reedip__ | rtheis: the one in https://review.openstack.org/#/c/281694/19/openstackclient/network/v2/router_interface.py , Line#63 | 14:57 |
reedip__ | actually only one comment, I guess | 14:57 |
rtheis | reedip__: once released then we'll need to osc requirements updated to include it | 14:58 |
rtheis | reedip__: then the patches are good to go | 14:58 |
reedip__ | rtheis: okay, that I understand , but I am having one concern... | 14:59 |
rtheis | sorry, what is the concern? | 14:59 |
*** alex_xu has joined #openstack-sdks | 14:59 | |
reedip__ | rtheis: is it possible to sync openstacksdk and openstackclient ; I mean waiting for the release of the SDK to be updated to the requirements of the client is a bit of a manual work isnt it ? ( Or am I missing something here) | 15:00 |
rtheis | reedip__: yes it is a bit of manual work ... how do you propose syncing? | 15:01 |
*** cleong has quit IRC | 15:01 | |
reedip__ | rtheis: why cant openstackclient pull up the master for sdk and work on it? Is there any issue there? | 15:02 |
reedip__ | rtheis: I am just trying to understand the concept first... | 15:02 |
*** fzdarsky has quit IRC | 15:02 | |
rtheis | reedip__: when both osc and sdk are on master that is fine | 15:04 |
rtheis | reedip__: the problem occurs when we want to cut an osc release | 15:04 |
rtheis | reedip__: the osc release would document new commands but they would only work if installed with sdk master | 15:04 |
stevemar | reedip__: it's fine for development, but we can't depend on an unreleased version :) | 15:05 |
*** gouthamr has joined #openstack-sdks | 15:05 | |
reedip__ | stevemar, rtheis: when is the OSC release scheduled? | 15:10 |
*** fzdarsky has joined #openstack-sdks | 15:10 | |
reedip__ | or is it already cut for Mitaka ? | 15:10 |
briancurtin | rtheis: https://pypi.python.org/pypi/openstacksdk/0.8.2 | 15:10 |
*** salv-orlando has joined #openstack-sdks | 15:10 | |
rtheis | briancurtin: thank you | 15:10 |
rtheis | reedip__: sdk 0.8.2 is ready | 15:11 |
reedip__ | braincurtin : thanks ... this is just what we were discussing . . :) | 15:11 |
reedip__ | Yeah, I saw rtheis | 15:11 |
reedip__ | rtheis: so now that it is released, the requirements would be updated... then is there a timeframe by when the patches need to be submitted for Mitaka Cutoff? | 15:12 |
*** fzdarsky has quit IRC | 15:12 | |
rtheis | reedip__: I'll defer to dtroyer and stevemar for details on the release schedule | 15:12 |
reedip__ | rtheis: anyways, I think I should republish the patches which are linked to this ... | 15:13 |
rtheis | ok | 15:13 |
reedip__ | thanks rtheis and stevemar for the information ... | 15:14 |
rtheis | reedip__: you're welcome | 15:14 |
*** amotoki has quit IRC | 15:18 | |
*** e0ne has quit IRC | 15:23 | |
*** salv-orlando has quit IRC | 15:24 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add "router add port" to osc https://review.openstack.org/281691 | 15:24 |
reedip__ | rthies: Patch#A ^^ | 15:25 |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add "router remove port" to osc https://review.openstack.org/281694 | 15:25 |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add "router remove port" to osc https://review.openstack.org/281694 | 15:27 |
*** singhj has quit IRC | 15:27 | |
reedip__ | rtheis: Patch #B | 15:28 |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add Subnet interface to router https://review.openstack.org/289716 | 15:28 |
*** cdent has quit IRC | 15:28 | |
rtheis | ok | 15:28 |
*** cdent has joined #openstack-sdks | 15:30 | |
*** e0ne has joined #openstack-sdks | 15:30 | |
*** singhj has joined #openstack-sdks | 15:31 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add Subnet interface to router https://review.openstack.org/289716 | 15:32 |
*** david-lyle has quit IRC | 15:32 | |
reedip__ | rtheis : And the final patch :) ^^ | 15:32 |
rtheis | ok | 15:33 |
*** cdent has quit IRC | 15:33 | |
reedip__ | rtheis: Thanks a lot for your review comments | 15:33 |
*** david-lyle has joined #openstack-sdks | 15:33 | |
rtheis | yw | 15:33 |
*** cdent has joined #openstack-sdks | 15:43 | |
*** fzdarsky has joined #openstack-sdks | 15:56 | |
*** cdent_ has joined #openstack-sdks | 15:56 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add external network options to osc network create https://review.openstack.org/292234 | 15:56 |
reedip__ | stevemar: Thank you for the review.. updated ^^ | 15:57 |
*** cdent has quit IRC | 15:58 | |
*** cdent_ is now known as cdent | 15:58 | |
*** david-lyle has quit IRC | 16:00 | |
*** david-lyle has joined #openstack-sdks | 16:01 | |
openstackgerrit | Merged openstack/api-wg: Header non-proliferation guideline https://review.openstack.org/280381 | 16:04 |
*** sdague has joined #openstack-sdks | 16:12 | |
dtroyer | reedip__: The current release is what is/will be stable/mitaka. Remember, we don't sync to the main release schedule, we just pick one to branch at the client branch time | 16:14 |
reedip__ | dtroyer: Just wanted to know when would the branch occur ? Any specific date? | 16:15 |
dtroyer | I don't know when those get cut | 16:16 |
*** e0ne has quit IRC | 16:17 | |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk: [WIP] Refactor Resource to better serve Proxy https://review.openstack.org/289998 | 16:18 |
reedip__ | dtroyer: umm... okay ... | 16:18 |
dtroyer | it was tagged last week: http://git.openstack.org/cgit/openstack/python-openstackclient/log/?h=stable/mitaka | 16:19 |
briancurtin | BobBall: fyi your SDK change from the other day was released in https://pypi.python.org/pypi/openstacksdk/0.8.2 | 16:20 |
reedip__ | dtroyer: trying to figure it out.... the one by dhellmann I guess... | 16:23 |
*** cdent has quit IRC | 16:24 | |
*** cdent has joined #openstack-sdks | 16:24 | |
dtroyer | yes | 16:26 |
*** Qiming has quit IRC | 16:27 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-openstackclient: Functional tests for openstackclient help messages https://review.openstack.org/293042 | 16:28 |
*** lhcheng has joined #openstack-sdks | 16:31 | |
*** alex_xu has quit IRC | 16:32 | |
*** dims_ has joined #openstack-sdks | 16:33 | |
*** dims has quit IRC | 16:34 | |
*** alex_xu has joined #openstack-sdks | 16:37 | |
*** salv-orlando has joined #openstack-sdks | 16:41 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix keypair create --public-key https://review.openstack.org/294709 | 16:43 |
*** salv-orlando has quit IRC | 16:51 | |
*** singhj has quit IRC | 16:53 | |
*** salv-orlando has joined #openstack-sdks | 16:53 | |
*** singhj has joined #openstack-sdks | 16:57 | |
*** cdent has quit IRC | 17:02 | |
*** singhj has quit IRC | 17:03 | |
*** cdent has joined #openstack-sdks | 17:03 | |
*** cdent has quit IRC | 17:03 | |
*** cdent has joined #openstack-sdks | 17:08 | |
*** singhj has joined #openstack-sdks | 17:20 | |
*** e0ne has joined #openstack-sdks | 17:37 | |
*** lucasagomes is now known as lucas-afk | 17:44 | |
*** david-lyle_ has joined #openstack-sdks | 17:44 | |
*** david-lyle has quit IRC | 17:45 | |
*** david-lyle_ is now known as david-lyle | 17:46 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Fix keypair create --public-key https://review.openstack.org/294709 | 17:48 |
*** knikolla has quit IRC | 18:19 | |
*** knikolla has joined #openstack-sdks | 18:21 | |
openstackgerrit | Richard Theis proposed openstack/python-openstackclient: Devref: Document OSC interfaces available to plugins https://review.openstack.org/292541 | 18:23 |
*** lbragstad has quit IRC | 18:49 | |
*** lbragstad has joined #openstack-sdks | 18:49 | |
*** singhj has quit IRC | 18:50 | |
*** singhj has joined #openstack-sdks | 19:05 | |
openstackgerrit | Richard Theis proposed openstack/python-openstacksdk: Consistent resource.prop for timestamps and booleans (orchestration) https://review.openstack.org/294766 | 19:05 |
elmiko | sdague: ping | 19:08 |
sdague | elmiko: what's up? | 19:10 |
elmiko | just curious to pick your brain a little about http://specs.openstack.org/openstack/api-wg/guidelines/errors.html | 19:11 |
elmiko | what do you have in mind for the error links? | 19:11 |
*** e0ne has quit IRC | 19:12 | |
*** chlong has quit IRC | 19:12 | |
*** etoews has quit IRC | 19:15 | |
*** etoews has joined #openstack-sdks | 19:16 | |
*** cdent has quit IRC | 19:16 | |
*** e0ne has joined #openstack-sdks | 19:22 | |
elmiko | sdague: were those meant to be informational style links (for example, back to the api docs), or a link to something like a json-home doc that the server would produce? | 19:22 |
sdague | elmiko: my feeling is they should be links back to the api docs | 19:22 |
elmiko | sdague: ok, cool. thanks! | 19:22 |
sdague | json-home is an expired spec, and apparently looks a bit dead - https://tools.ietf.org/html/draft-nottingham-json-home-03 | 19:23 |
elmiko | yea, i knew it was on the edge. i was hopeful though ;) | 19:23 |
sdague | elmiko: but, we kind of need a better api publish process before we can reasonably expect errors to be up on the api site somewhere | 19:23 |
elmiko | +1 | 19:24 |
elmiko | sdague: i can see how ideally this field would be used to send a user to a specific spot in the api docs (assuming said publishing process). i just wanted to make sure i understood what you were hinting at in the guideline. | 19:25 |
sdague | which, is actually a thing I've been POCing this week. And will be spending some time with annegentle next week to sort out | 19:25 |
elmiko | oh, nice | 19:25 |
sdague | elmiko: right, that was my idea, it should be a real link | 19:25 |
sdague | it's just... it's hard to quite say that until we have the ability to put content at that place | 19:25 |
elmiko | but, like you said, there will need to be some way to programmatically coordinate between the api-doc site and the code producing the error | 19:25 |
elmiko | imo, seems like a nice fit for autogenerated doc stuffs | 19:26 |
sdague | the way I would actually imagine this is that people will extend exceptions with a unique slug about the issue | 19:27 |
elmiko | that would be really cool | 19:27 |
sdague | and when that exception is caught and translated at the top of the wsgi stack, it will thus link to the right place | 19:28 |
elmiko | an interesting thought | 19:28 |
*** e0ne has quit IRC | 19:29 | |
*** rtheis has quit IRC | 19:47 | |
*** singhj has quit IRC | 20:09 | |
*** fzdarsky is now known as fzdarsky|afk | 20:11 | |
*** e0ne has joined #openstack-sdks | 20:15 | |
openstackgerrit | Merged openstack/python-openstackclient: Functional tests for openstackclient help messages https://review.openstack.org/293042 | 20:20 |
*** singhj has joined #openstack-sdks | 20:23 | |
*** e0ne has quit IRC | 20:38 | |
openstackgerrit | Merged openstack/python-openstackclient: Fix keypair create --public-key https://review.openstack.org/294709 | 20:55 |
*** sdague has quit IRC | 21:02 | |
*** leakypipes has quit IRC | 21:04 | |
*** david-lyle has quit IRC | 21:06 | |
*** david-lyle has joined #openstack-sdks | 21:07 | |
knikolla | stevemar, i would like your opinion on this https://github.com/CCI-MOC/python-openstackclient/commit/41ff4e1635ef2a839ff83a30edc9c58bf1218044 | 21:20 |
stevemar | knikolla: looking.. | 21:20 |
*** gouthamr has quit IRC | 21:21 | |
stevemar | knikolla: so, i think first we have to figure out whats a use case you're trying to solve | 21:22 |
stevemar | knikolla: it's been a while since i've looked at K2K | 21:22 |
knikolla | stevemar, this is basically for querying a service provider. | 21:23 |
knikolla | through K2K | 21:23 |
knikolla | as there is no way with current openstackclient | 21:23 |
stevemar | knikolla: and querying will allow you perform an operation on the SP? | 21:24 |
*** ryansb_ has joined #openstack-sdks | 21:24 | |
*** ryansb_ has quit IRC | 21:24 | |
*** ryansb_ has joined #openstack-sdks | 21:24 | |
*** charz_ has joined #openstack-sdks | 21:25 | |
knikolla | stevemar, yes. I've tried it with basic commands and it worked | 21:25 |
*** charz has quit IRC | 21:25 | |
*** ryansb has quit IRC | 21:25 | |
*** christi3k has quit IRC | 21:25 | |
*** _tutima has quit IRC | 21:25 | |
*** ryansb_ is now known as ryansb | 21:25 | |
knikolla | operation will be directed to the SP | 21:25 |
*** mordred has quit IRC | 21:26 | |
*** dhellmann has quit IRC | 21:26 | |
*** redrobot has quit IRC | 21:26 | |
*** dhellmann has joined #openstack-sdks | 21:26 | |
stevemar | knikolla: *not_bad.gif* | 21:26 |
*** mordred has joined #openstack-sdks | 21:26 | |
*** christi3k has joined #openstack-sdks | 21:27 | |
stevemar | knikolla: write something up, toss up some code, show some results, let's see how it works | 21:28 |
stevemar | that'll be awesome if it's that easy... | 21:28 |
knikolla | stevemar, i'll have to wait on this https://review.openstack.org/#/c/276350/ | 21:28 |
stevemar | just add an extra --sp my_pub_cloud and you're done | 21:28 |
stevemar | gah that | 21:28 |
stevemar | yeah, i need to get on that | 21:28 |
stevemar | :( | 21:28 |
*** redrobot has joined #openstack-sdks | 21:29 | |
*** redrobot is now known as Guest98399 | 21:29 | |
stevemar | maybe this weekend i'll look at it | 21:29 |
knikolla | stevemar, the patch he proposed doesn't work. but can easily be fixed if he puts the effort. | 21:30 |
knikolla | i provided some comments in the review. | 21:30 |
stevemar | knikolla: don't hesitate to pull it down yourself and fix it up | 21:30 |
knikolla | and fixing those 2 errors made it work. | 21:30 |
knikolla | he's already put something like 12 patchsets. it feels weird. | 21:31 |
knikolla | stevemar | 21:31 |
stevemar | knikolla: just add yourself as a co-author, in the commit message write: "Co-Authored-By: FirstName LastName <email>" | 21:31 |
stevemar | knikolla: nah, don't think of it like that | 21:31 |
stevemar | knikolla: leave a comment before doing it | 21:32 |
stevemar | "I have solved these issues locally, do you mind if i post a follow on patch?" | 21:32 |
stevemar | i'll reply asking you to please post one :) | 21:32 |
knikolla | stevemar, ok, i'll do that. in "Download", which of the options do i copy/paste | 21:33 |
*** _tutima has joined #openstack-sdks | 21:34 | |
knikolla | stevemar, the web ui is confusing. | 21:34 |
stevemar | knikolla: go to your osc master branch | 21:34 |
stevemar | knikolla: pull from master `git pull origin master` | 21:34 |
stevemar | knikolla: download the change: `git review -d 276350` | 21:35 |
stevemar | knikolla: <hack hack hack> | 21:35 |
stevemar | knikolla: `git add <files>` | 21:35 |
stevemar | knikolla: `git commit --amend` << please add your name as a co-author like i said above | 21:35 |
stevemar | knikolla: `git review` | 21:35 |
stevemar | done | 21:35 |
stevemar | i would be very appreciate if you got that patch working! | 21:36 |
knikolla | stevemar, thanks a lot. I didn't know the "git review -d <patch>" | 21:36 |
stevemar | knikolla: it's awesome | 21:36 |
stevemar | knikolla: there is also a cherry-pick option -- git review -x <patch> | 21:36 |
knikolla | *pulls up 'man git-review' | 21:36 |
*** Guest98399 is now known as redrobot | 21:37 | |
stevemar | knikolla: heading out for the evening, thanks for all your work as of late | 21:37 |
stevemar | knikolla: if you have any questions, please post here and i'll see them when i log back on | 21:38 |
knikolla | stevemar, thanks for all the help! it's been a pleasure. | 21:38 |
stevemar | :) | 21:41 |
*** knikolla has quit IRC | 21:48 | |
*** erlon has quit IRC | 21:57 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:00 | |
*** cdent has joined #openstack-sdks | 22:15 | |
*** cdent has quit IRC | 22:17 | |
*** singhj has quit IRC | 22:19 | |
*** salv-orl_ has joined #openstack-sdks | 22:28 | |
*** salv-orlando has quit IRC | 22:30 | |
*** singhj has joined #openstack-sdks | 22:34 | |
*** singhj has quit IRC | 22:38 | |
openstackgerrit | Timothy Symanczyk proposed openstack/python-openstackclient: Improve error for token issue command without auth https://review.openstack.org/294844 | 22:45 |
*** sheel has quit IRC | 22:47 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add Subnet interface to router https://review.openstack.org/289716 | 22:47 |
*** knikolla has joined #openstack-sdks | 22:48 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Add external network options to osc network create https://review.openstack.org/292234 | 22:57 |
openstackgerrit | Nicolas Simonds proposed openstack/python-openstackclient: Image API v2: make volume_type optional https://review.openstack.org/294848 | 23:08 |
*** lhcheng has quit IRC | 23:21 | |
*** lhcheng has joined #openstack-sdks | 23:35 | |
*** lhcheng has quit IRC | 23:43 | |
*** markvoelker has quit IRC | 23:44 | |
*** e0ne has joined #openstack-sdks | 23:44 | |
*** gouthamr has joined #openstack-sdks | 23:54 | |
*** gouthamr_ has joined #openstack-sdks | 23:55 | |
*** gouthamr has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!