Friday, 2015-09-18

*** Qiming has quit IRC00:17
*** stevemar has joined #openstack-sdks00:18
*** hitalia has quit IRC00:36
*** david-lyle has quit IRC00:40
*** david-lyle has joined #openstack-sdks00:44
*** stevemar has quit IRC00:55
*** stevemar has joined #openstack-sdks00:55
*** stevemar has quit IRC00:58
*** trown is now known as trown|outttypeww01:05
*** Qiming has joined #openstack-sdks01:21
*** pratikmallya has quit IRC01:24
*** Yanyanhu has joined #openstack-sdks01:32
*** stevemar has joined #openstack-sdks01:42
*** pratikmallya has joined #openstack-sdks02:13
*** pratikmallya has quit IRC03:14
*** gildub has quit IRC03:57
*** gildub has joined #openstack-sdks04:17
openstackgerritSteve Martinelli proposed openstack/keystoneauth: add openid connect plugins  https://review.openstack.org/22499304:19
openstackgerritSteve Martinelli proposed openstack/keystoneauth: add openid connect plugins  https://review.openstack.org/22499305:14
*** openstackgerrit has quit IRC05:31
*** Qiming has quit IRC05:31
*** openstackgerrit has joined #openstack-sdks05:32
openstackgerritSteve Martinelli proposed openstack/keystoneauth: add openid connect plugins  https://review.openstack.org/22499305:44
*** stevemar has quit IRC06:09
*** aufi has joined #openstack-sdks06:10
*** stevemar has joined #openstack-sdks06:11
*** e0ne has joined #openstack-sdks06:42
*** e0ne has quit IRC06:45
*** e0ne has joined #openstack-sdks06:48
*** e0ne has quit IRC06:55
*** pratikmallya has joined #openstack-sdks06:57
*** e0ne has joined #openstack-sdks06:59
*** karimb has joined #openstack-sdks07:02
*** woodster_ has quit IRC07:09
*** e0ne has quit IRC07:10
*** HenryG has quit IRC07:21
*** karmatronic has joined #openstack-sdks07:34
*** e0ne has joined #openstack-sdks07:37
*** karimb has quit IRC07:38
*** e0ne has quit IRC07:44
*** stevemar has quit IRC07:49
*** stevemar has joined #openstack-sdks07:50
*** stevemar has quit IRC07:52
*** karmatronic has quit IRC07:57
*** gildub has quit IRC07:58
*** karimb has joined #openstack-sdks07:58
*** HenryG has joined #openstack-sdks08:12
*** HenryG has quit IRC08:16
*** HenryG has joined #openstack-sdks08:30
*** chlong has quit IRC08:47
*** stevemar has joined #openstack-sdks08:51
*** stevemar has quit IRC09:05
*** e0ne has joined #openstack-sdks09:27
openstackgerritNiall Bunting proposed openstack/python-openstackclient: Add 'image create' to openstack  https://review.openstack.org/20328009:35
*** Yanyanhu has quit IRC09:38
*** gildub has joined #openstack-sdks09:46
*** karimb has quit IRC10:53
*** karimb has joined #openstack-sdks10:54
*** e0ne has quit IRC11:10
*** thrash|g0ne is now known as thrash11:16
*** e0ne has joined #openstack-sdks11:33
*** stevemar has joined #openstack-sdks11:33
*** stevemar has quit IRC11:37
*** trown|outttypeww is now known as trown12:01
*** chlong has joined #openstack-sdks12:06
*** chlong has quit IRC12:07
*** chlong has joined #openstack-sdks12:07
*** pratikmallya has quit IRC12:13
*** pratikmallya has joined #openstack-sdks12:16
*** pratikmallya has quit IRC12:47
*** fifieldt has quit IRC13:00
*** gildub has quit IRC13:10
*** edleafe is now known as figleaf13:15
*** woodster_ has joined #openstack-sdks13:32
*** stevemar has joined #openstack-sdks13:34
*** stevemar has quit IRC13:37
*** openstackgerrit has quit IRC13:46
*** openstackgerrit has joined #openstack-sdks13:47
*** jose4183 has joined #openstack-sdks14:02
*** karimb has quit IRC14:11
*** sigmavirus24_awa is now known as sigmavirus2414:14
*** Qiming has joined #openstack-sdks14:30
briancurtinterrylhowe: fyi, I’m still working through reviews but sidetracked a bit to read through ksa so i have a good understanding of your change to have us use that. also, i’m out tues-fri next week, so will try to knock as much out today and monday as i can14:30
*** david-lyle has quit IRC14:31
terrylhoweawesome briancurtin I won’t get around to fixing the ksa patch until next week14:34
terrylhowebut I think the only thing wrong with it is some broken tests14:34
*** stevemar has joined #openstack-sdks14:39
openstackgerritNiall Bunting proposed openstack/python-openstackclient: Add 'image create' to openstack  https://review.openstack.org/20328014:54
*** zz_steveortiz is now known as steveortiz14:59
openstackgerritNiall Bunting proposed openstack/python-openstackclient: Image fix bug with --volume  https://review.openstack.org/22519515:25
openstackgerritNiall Bunting proposed openstack/python-openstackclient: Image fix bug with --volume  https://review.openstack.org/22519515:31
*** aufi has quit IRC15:32
*** jose4183 has quit IRC15:59
*** jose4183 has joined #openstack-sdks15:59
*** trown is now known as trown|lunch16:04
*** e0ne has quit IRC16:05
*** Qiming has quit IRC16:07
*** pratikmallya has joined #openstack-sdks16:09
openstackgerritMonty Taylor proposed openstack/os-client-config: Move plugin loader creation to try block  https://review.openstack.org/22521716:20
openstackgerritMonty Taylor proposed openstack/os-client-config: Handle the 'insecure' option that osc uses  https://review.openstack.org/22521816:20
openstackgerritMonty Taylor proposed openstack/os-client-config: Handle default_domain as a domain option  https://review.openstack.org/22521916:20
mordredterrylhowe, dtroyer, GheRivero: ^^ https://review.openstack.org/225217 is the problem that was breaking osc16:21
mordredShrews: ^^ you too16:21
dtroyerso I would _really_ like to not have to do things like that insecure bit, but I still don't quite understand what broke it in the first place16:22
GheRiverogot it16:22
*** hitalia has joined #openstack-sdks16:27
*** pratikmallya has quit IRC16:34
openstackgerritOpenStack Proposal Bot proposed openstack/keystoneauth: Updated from global requirements  https://review.openstack.org/22522416:38
openstackgerritOpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements  https://review.openstack.org/22468116:42
openstackgerritMerged openstack/os-client-config: Move plugin loader creation to try block  https://review.openstack.org/22521716:46
mordreddtroyer: oh - the insecure bit is totally not needed16:47
mordreddtroyer: anyting other than the first patch is just me finding things osc was doing that occ wasn't doing for other places but that one could imagine wanting to work in all of your things, not just osc16:48
mordred(like default_domain too... I'd want ansible fokls who are using osc to have that do what they think it would do)16:48
mordreddtroyer: but the "try block" patch is the thing that broke - it should just return None for an auth plugin if it doesn't work - I missed that the line that got moved was doing Stuff that Mattered16:49
openstackgerritMonty Taylor proposed openstack/python-openstackclient: Pass validate=False to get_one_cloud  https://review.openstack.org/22445116:49
mordreddtroyer: moving it to the try block keeps the osc interaction with the system like it was before .. or it does when combined with ... ^^ that16:50
mordredthat didn't work before because it was hitting a different error. with the occ patch and that patch above, osc has no new behavior and operates as before16:50
*** pratikmallya has joined #openstack-sdks16:56
dtroyerosc unit tests are still failing in a —insecure cli test that doesn't happen with occ 1.6.416:59
dtroyerthat's what I can' tfigure out why16:59
dtroyerI suppose I need to let go of occ having more knowledge of things like ksa and other arg conventions and let it all live there16:59
*** pratikmallya has quit IRC16:59
dtroyeralso, OSC17:00
openstackgerritMonty Taylor proposed openstack/os-client-config: Handle the 'insecure' option that osc uses  https://review.openstack.org/22521817:00
dtroyer's need for the osc_password auth plugin is probably near an end17:00
openstackgerritMonty Taylor proposed openstack/os-client-config: Handle default_domain as a domain option  https://review.openstack.org/22521917:00
dtroyerwe probably should make it not-the-default17:00
mordreddtroyer: ++17:01
mordreddtroyer: I've got a crazy patch for you that I wrote on the plane17:01
dtroyer+ to plane patches!17:01
mordreddtroyer: when I didn't have internet and nothing else to hack on :)17:01
dtroyerbtw, that's where OSC was born ;)17:01
mordredhehe17:01
dtroyerafter talking it over with dolphm in a cab to SFO17:02
mordreddtroyer: the osc unittests worked for me with that patch - I'll try again here in just a bit (need to find lunch for face)17:03
dtroyerI'm about to blow away all of the venvs and try it again now too17:03
*** trown|lunch is now known as trown17:04
*** e0ne has joined #openstack-sdks17:26
stevemarmordred: dtroyer i look forward to seeing crazy patches17:36
crinklewe're seeing openstackclient default to using the glance v2 api (http://logs.openstack.org/74/224974/8/check/gate-puppet-openstack-integration-dsvm-centos7/0522764/console.html#_2015-09-18_14_33_01_115), which is weird because it looks like it should still be using v1 https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/client.py#L2317:40
crinklelooks like you all ran into this too since your func tests work around it http://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=817ab3ec0ea5a74aeda12850f39a56f332e9558b17:40
crinklewhy is that happening?17:40
*** e0ne has quit IRC17:41
stevemarcrinkle: devstack sets it to v2 by default now17:41
crinklestevemar: we're not using devstack17:41
stevemarcrinkle: actually, now that i look into it, its not the case17:44
stevemarwhich you've just determined17:44
crinkle\o/ yay i'm helping17:45
stevemarhehe17:48
stevemari have no idea why it switched17:48
*** e0ne has joined #openstack-sdks17:49
*** boris-42 has quit IRC17:50
*** hitalia has quit IRC17:54
*** pratikmallya has joined #openstack-sdks18:22
stevemarmordred: i'm being lazy here, does the small patch you tossed up to occ fix osc's issue?18:29
*** e0ne has quit IRC18:39
mordredstevemar: yes18:39
mordredat least18:39
mordredit does on my laptop18:39
mordredstevemar: let me test clean from scratch again18:39
stevemarmordred: alright, so theres no giant / crazy patch?18:39
mordredstevemar: you need the occ patch and then the osc patch18:39
mordredstevemar: oh, there is18:39
mordredthat's not pushed up yet18:39
mordredbecause it doesn't yet work18:39
stevemarbut thats not needed for this fix?18:39
stevemarmordred: alright, so we probably need another occ release then, s'all good18:43
mordredstevemar: yes. will need a new occ release18:43
mordredstevemar: I just pushed a 1.7.2 tag18:56
mordredwiht the occ fix18:56
mordredstevemar: which should make testing the osc patch easier18:56
*** e0ne has joined #openstack-sdks18:58
dtroyerI'll try again, but about 30 min ago osc still wasn't fixed with osc-password as the default19:04
dtroyerthe —insecure arg test is still failing for me and I can't for the life of me figure out what changed in occ commit 093d7b085 to cause that…  I think I have Friday Brain19:11
mordreddtroyer: I only made the tag 10 minutes ago - so it's worth trying19:17
*** e0ne has quit IRC19:17
mordreddtroyer: I'm retrying from a clean tree now19:17
dtroyerno change for me, still 6 failed tests, 5 of which are due to the plugin problem19:17
mordred  py27: commands succeeded19:17
mordreddtroyer: ^^19:17
mordreddtroyer: did you pull the osc change?19:17
openstackgerritDean Troyer proposed openstack/python-openstackclient: Set default auth plugin back to 'password'  https://review.openstack.org/22528419:18
mordreddtroyer: https://review.openstack.org/#/c/224451/19:18
dtroyerno, I don't necessarily like that one…  why bother loading the plugins if we're not going to use them to validate?19:18
mordreddtroyer: validate in this case means "use keystoneauth to validate them"19:18
mordreddtroyer: we're not using keystoneauth in osc yet19:19
dtroyerbut occ does so we have to adapt, or cap back to 1.6.419:19
mordreddtroyer: so asking occ to create and validate the plugins is a bit much19:19
mordreddtroyer: it doesn't19:19
mordreddtroyer: not if you pass validate=False19:19
mordredvalidate=False is basically the pre-ksa behavior19:20
dtroyerok.  I'm going to give up trying to keep the layers separate here anymore.19:21
mordreddtroyer: if we want to go the other direction - it's a bit more involved - that's what my crazy plane patch is working on - an actual ksa use in osc19:22
mordredit snowballs though - so I think after I get it working I need to go backtataking what I learned and break it in to smaller patches19:22
mordredwow. backtataking19:22
mordredthat's a word19:22
*** pratikmallya has quit IRC19:23
*** pratikmallya has joined #openstack-sdks19:23
dtroyeras long as the semantics and spelling of the options don't change, whatever.  I hate ksa doing cli ard handling, don't think occ should know the semantics of those args, but I'm the only one and my brain isn't fully here…  I think that's a clue19:23
dtroyerjust so OSC doesn't break compatibility19:24
mordred++19:24
*** pratikmallya has quit IRC19:27
openstackgerritDean Troyer proposed openstack/python-openstackclient: Move option logging back to start if initialize_app()  https://review.openstack.org/22528719:29
openstackgerritSteve Martinelli proposed openstack/keystoneauth: add openid connect plugins  https://review.openstack.org/22499319:34
*** steveortiz is now known as zz_steveortiz19:40
mordreddtroyer: ok. https://review.openstack.org/#/c/224451/ fixes unittests - lemme go look at the functional tests that failed19:45
mordreddtroyer: wth?19:46
mordred2015-09-18 19:30:01.939 | Missing parameter(s):19:46
mordred2015-09-18 19:30:01.939 | Set a token with --os-token, OS_TOKEN or auth.token19:46
mordred2015-09-18 19:30:01.939 | Set a service URL, with --os-url, OS_URL or auth.url19:46
mordred2015-09-18 19:30:01.124 | ++ openstack --os-url=http://127.0.0.1:5000/v3 --os-identity-api-version=3 project create service --domain=default --or-show -f value -c id19:46
mordredI should have pasted that last line first19:46
mordreddtroyer: uhm19:50
mordreddtroyer: os-client-config is pinned to 1.6.3 because of upper-constraint19:50
openstackgerritMerged openstack/keystoneauth: Updated from global requirements  https://review.openstack.org/22522419:51
mordreddtroyer: so latest occ is not causing that fail19:51
mordredmorgan: ^^ I has confuses19:57
morganmordred: yeah something odd there?19:58
mordredmorgan: WELL20:00
mordredmorgan: it's using 1.6.3, which is pre-ksa20:00
mordredmorgan: but the error it gives is one related to not having the right stuff for osc plugins20:00
*** jose4183 has quit IRC20:01
morganWhich should have worked with ksc? Right?20:02
*** jose4183 has joined #openstack-sdks20:02
morganWe didn't remove but added a new entry point20:02
*** hitalia has joined #openstack-sdks20:02
*** jose4183 has quit IRC20:04
*** jose4183 has joined #openstack-sdks20:05
*** bnemec has quit IRC20:15
*** bnemec has joined #openstack-sdks20:15
openstackgerritMonty Taylor proposed openstack/python-openstackclient: Pass validate=False to get_one_cloud  https://review.openstack.org/22445120:22
openstackgerritMonty Taylor proposed openstack/python-openstackclient: Pass validate=False to get_one_cloud  https://review.openstack.org/22445120:23
openstackgerritMonty Taylor proposed openstack/python-openstackclient: WIP - Rework everything to just use ksa/occ  https://review.openstack.org/22531820:25
mordredthe patch above is only pushed up for reference - there is no way it's going to look like that - 2 problems a) too much in one patch b) it breaks things it should not20:26
openstackgerritJames E. Blair proposed openstack/os-client-config: Fix typo in ovh region names  https://review.openstack.org/22532120:29
dhellmannmordred: is there no way to fix this issue in occ instead of osc? we have other bugs on master in osc, and a rather long list of unreleased changes, so I'm not sure we're actually in a good state to make a release there20:37
openstackgerritSteve Martinelli proposed openstack/keystoneauth: add openid connect plugins  https://review.openstack.org/22499320:38
dhellmannmordred, terrylhowe, dtroyer, stevemar: the list of unreleased python-openstackclient changes: http://paste.openstack.org/show/468435/20:38
stevemardhellmann: yep, we're trying to fix up occ and the osc gate20:39
stevemardhellmann: since we're dependent on occ and the rest of the clients we always get bitten20:39
mordreddhellmann: oh. we can't cut an osc release when we fix it?20:39
dhellmannstevemar: we need to add more tests20:40
dhellmannmordred: well, we can, but that's a long list of changes to dump on a friday20:40
dhellmannstevemar: either more jobs, or functional tests within the clients themselves20:41
stevemardhellmann: it is a long list, do you want to wait til monday?20:43
morgandhellmann: release and quit for the weekend... Worse than commit and quit ;) :P20:44
dhellmannstevemar: I'd feel better about not breaking anyone else, but how badly are things jammed up right now?20:44
mordredI believe the two things that are broken20:44
mordredare osc20:44
stevemardhellmann: right now only osc is mucked20:44
mordredand constraints20:44
stevemaroh, and ^20:44
mordredwe can't land new constraints that update occ20:44
morganYah20:44
stevemargah20:44
dhellmannmordred: I'm not at all concerned by the constraints auto-update because I'm doing our libs by hand and -1 any other lib changes20:44
mordredand ... it's entirely possible this is breaking people with current osc installed20:44
mordredout in the world20:44
stevemarmordred: yes20:45
* dhellmann nods20:45
mordredif they also happen to install latest occ20:45
mordrednow, the set of people who would do those two things20:45
stevemaryeah20:45
mordredis pretty low20:45
stevemarbut it exists20:45
mordredbut it's at least a theory20:45
morganmordred: pip update -U20:45
dhellmannis this an api change in occ? I don't really understand the fix20:45
stevemarthere was already a bug about it20:45
morganPeople do stranger things20:45
morganErm install -U20:45
mordreddhellmann: we added the creation of ... hang on20:46
mordreddhellmann: thank you for asking that20:46
mordredI do not understand why anything breaks with 1.7.2 of occ20:46
mordredbecuase that should no-op the new ksa stuff if it doesn't work20:46
dhellmannmordred: it breaks with 1.7.0, 1.7.1, and 1.7.220:46
dhellmannis it's not that recent a break20:47
mordredyes. it should breka with 1.7.0 and 1.7.120:47
mordredbecause bug20:47
mordredwhich 1.7.2 fixed20:47
mordrednow - the thing I don't grok20:47
mordredis why it's breaking with 1.7.220:47
mordredthe thing that 1.7.2 fixed should make the ksa stuff a noop if it can't happen20:48
dhellmannah20:48
mordredlet me dig again20:48
mordredit's possible I missed something - I was under the impression we needed the osc patch ... but honestly, we should NOT20:48
mordredbecause if we do, that means we've broken current installs, which is not what we want to do20:49
openstackgerritMerged openstack/os-client-config: Fix typo in ovh region names  https://review.openstack.org/22532120:49
mordreddhellmann: I have an idea for a fix20:49
dhellmannmordred: that's encouraging!20:49
mordreddhellmann: ok. yes. I can produce fix only in occ20:51
mordreddhellmann: it'll take a little bit20:51
dhellmannmordred: cool. it's good to make both sides more robust, but if we can fix it just with occ that simplifies the question of when/whether to release osc20:52
dhellmannstevemar, terrylhowe : since python-openstackclient is a managed project, someone from the core team just needs to submit a release request to openstack/releases20:53
mordredbtw - I'm not making this stylish - just working20:57
openstackgerritMonty Taylor proposed openstack/os-client-config: Fall back to keystoneclient arg processing  https://review.openstack.org/22532820:58
mordredhttps://review.openstack.org/22532820:58
mordredstevemar, morgan: ^^20:58
morganNod21:00
morganLooking at it.21:00
openstackgerritMonty Taylor proposed openstack/os-client-config: Fall back to keystoneclient arg processing  https://review.openstack.org/22532821:11
mordredmorgan, stevemar: ^^ needed to update it21:11
mordredfound another way it can fai21:11
mordredfail21:11
morganOy!21:11
dhellmannmordred: I'm going to start my weekend. I put up a patch to change the ACLs for occ releases, but it hasn't merged, yet, so you can still do them. After you do, go ahead and submit a patch to requirements to update the constraints file by hand because the automated thingy is trying to update all sorts of third-party libs that we're not updating right now.21:12
mordreddhellmann: kk21:12
mordredmorgan: new logic:21:12
morgan"Don't do the dumb"? ;)21:12
mordredmorgan: "try doing it with ksa, if that doens't work, try ksc. if it still does't work, raise the original ksa error, becuase that means it wasn't a transition issue"21:12
morganAh. That is a good approach21:13
mordredmorgan: we need to try the ksc step becuse we use the ksc and ksa options not just for validation but to know how to split ot the auth parameters to pass to the constructors21:13
morganYah21:13
morganIcky, but makes sense21:14
morganSilly ksc / ksa things21:14
mordredShrews: ^^ you may also want to look21:14
morganAnd tla soup21:14
mordredmorgan: yah man21:14
*** chlong has quit IRC21:14
morganI try hard to avoid the TLAs21:14
morganBut..21:14
mordredmorgan: BUT - honestly I believe the only thing that this is affecting is osc21:14
morganThats good21:15
mordredmorgan: so once we get it updated, we can drop this back out of occ21:15
morganYah21:15
*** stevemar has quit IRC21:16
*** stevemar has joined #openstack-sdks21:32
*** stevemar has quit IRC21:32
*** stevemar has joined #openstack-sdks21:33
dtroyerso… I'll say this just once more just because I'm in a grouchy mood…   if occ didn't reach down into the app layer (ksa) this wouldn't be a problem.  it doesn't validate other args, just accepts them and composes them into the dict/object.21:34
stevemardtroyer: you're in a grouchy mood? never...21:35
stevemar:)21:35
*** trown is now known as trown|outttypeww21:36
*** pratikmallya has joined #openstack-sdks21:41
*** terrylhowe has quit IRC21:46
*** jose4183 has quit IRC21:57
stevemarmordred: rechecked your 224444 patch now that occ 1.7.2 has been out, and its not looking like it fixed that last test >.<22:18
stevemartried it in my dev. env. too, same result as jenkins22:18
*** figleaf is now known as edleafe22:21
mordredsteve22:23
mordredgah22:23
mordredstevemar: you need the new patch22:24
stevemarmordred: one that is not https://review.openstack.org/#/c/224444/4 ?22:25
morganstevemar: https://review.openstack.org/22532822:26
morganstevemar: the osc change is future looking and should happen eventually22:26
morganThat one, 225328 fixes the immediate bug/issue22:27
stevemargotcha22:27
stevemarthen we'll need 1.7.3 :P22:27
*** sigmavirus24 is now known as sigmavirus24_awa22:32
morganYar22:34
*** openstackgerrit has quit IRC22:46
*** openstackgerrit has joined #openstack-sdks22:47
stevemarmordred: thank you sir22:55
stevemarmordred: hmm, do you not use os/releases for occ? https://review.openstack.org/#/q/project:openstack/releases,n,z - i don't see patches there for 1.7.2 or 1.7.122:57
openstackgerritMerged openstack/os-client-config: Fall back to keystoneclient arg processing  https://review.openstack.org/22532822:57
mordredstevemar: nope - we're just about to get that going23:02
stevemarcoolio23:09
mordreddhellmann: https://review.openstack.org/22536323:15
mordredstevemar: 1.7.3 tagged and pushed23:15
mordredstevemar: if that patch above passes gate, it means we've fixed it23:15
stevemarmordred: rechecking now23:22
stevemarmordred: oh hello old friend: gate-python-openstackclient-python26 SUCCESS23:25
*** stevemar has quit IRC23:26
mordredstevelle: woot!23:27

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!