*** Qiming has quit IRC | 00:12 | |
*** jamielennox is now known as jamielennox|away | 00:29 | |
*** hitalia has quit IRC | 00:33 | |
*** jamielennox|away is now known as jamielennox | 00:39 | |
*** ameybhide has left #openstack-sdks | 00:46 | |
*** Qiming has joined #openstack-sdks | 01:06 | |
*** Qiming_ has joined #openstack-sdks | 01:07 | |
*** Qiming has quit IRC | 01:10 | |
*** dguerri` is now known as dguerri | 01:29 | |
*** Yanyanhu has joined #openstack-sdks | 01:37 | |
*** Qiming_ has quit IRC | 01:41 | |
*** Qiming_ has joined #openstack-sdks | 01:41 | |
*** bitblt has quit IRC | 01:45 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 01:49 | |
*** Yanyan has joined #openstack-sdks | 01:51 | |
*** Yanyanhu has quit IRC | 01:54 | |
*** steveortiz is now known as zz_steveortiz | 02:05 | |
*** crinkle has quit IRC | 02:08 | |
*** crinkle has joined #openstack-sdks | 02:16 | |
*** dguerri is now known as dguerri` | 02:17 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 02:17 | |
*** dguerri` is now known as dguerri | 02:22 | |
*** dguerri is now known as dguerri` | 02:25 | |
*** dguerri` is now known as dguerri | 02:30 | |
*** dguerri is now known as dguerri` | 02:34 | |
*** stevemar has joined #openstack-sdks | 02:40 | |
*** rbrooker has quit IRC | 02:56 | |
*** Qiming_ is now known as Qiming | 03:00 | |
*** guojian has joined #openstack-sdks | 03:00 | |
*** jamielennox is now known as jamielennox|away | 03:22 | |
*** jamielennox|away is now known as jamielennox | 03:31 | |
*** pm90_ has joined #openstack-sdks | 03:57 | |
*** pm90_ has quit IRC | 04:30 | |
*** pm90_ has joined #openstack-sdks | 04:40 | |
*** terrylhowe has quit IRC | 05:01 | |
*** hitalia has joined #openstack-sdks | 05:03 | |
*** stevemar has quit IRC | 05:22 | |
*** Qiming_ has joined #openstack-sdks | 05:40 | |
*** Qiming has quit IRC | 05:43 | |
*** ig0r_ has joined #openstack-sdks | 05:51 | |
*** ig0r__ has quit IRC | 05:55 | |
openstackgerrit | Guojian Shao proposed openstack/python-openstackclient: add functional tests for identity v2 https://review.openstack.org/198498 | 06:08 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Imported Translations from Transifex https://review.openstack.org/199891 | 06:11 |
*** dguerri` is now known as dguerri | 06:40 | |
*** dguerri is now known as dguerri` | 06:46 | |
*** Qiming_ is now known as Qiming | 06:53 | |
*** tobe has joined #openstack-sdks | 07:18 | |
*** aufi has joined #openstack-sdks | 07:25 | |
*** karimb has joined #openstack-sdks | 07:29 | |
*** stevemar has joined #openstack-sdks | 07:37 | |
*** stevemar has quit IRC | 07:40 | |
*** sorantis has joined #openstack-sdks | 07:44 | |
*** jaosorior has joined #openstack-sdks | 07:55 | |
*** heha has joined #openstack-sdks | 08:05 | |
*** heha has quit IRC | 08:06 | |
*** hitalia has quit IRC | 08:47 | |
*** pm90_ has quit IRC | 08:52 | |
*** pm90_ has joined #openstack-sdks | 09:23 | |
*** pm90_ has quit IRC | 09:28 | |
*** Qiming has quit IRC | 10:10 | |
*** Yanyan has quit IRC | 10:17 | |
*** guojian has quit IRC | 10:17 | |
*** sorantis has quit IRC | 10:27 | |
*** sorantis has joined #openstack-sdks | 10:59 | |
*** sorantis has quit IRC | 11:05 | |
*** sorantis has joined #openstack-sdks | 11:09 | |
*** Qiming has joined #openstack-sdks | 11:13 | |
*** sorantis has quit IRC | 11:38 | |
*** sorantis has joined #openstack-sdks | 11:44 | |
*** tobe has quit IRC | 11:48 | |
*** trown|outttypeww is now known as trown | 12:01 | |
*** bknudson has quit IRC | 12:26 | |
*** thrash|g0ne is now known as thrash | 12:33 | |
*** bknudson has joined #openstack-sdks | 12:42 | |
*** pserebryakov has joined #openstack-sdks | 12:50 | |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Specify the config file with environment variable https://review.openstack.org/198502 | 13:04 |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Add support for configuring region lists with yaml https://review.openstack.org/198501 | 13:04 |
*** stevemar has joined #openstack-sdks | 13:06 | |
*** sorantis_ has joined #openstack-sdks | 13:09 | |
*** sorantis has quit IRC | 13:11 | |
*** sorantis_ is now known as sorantis | 13:11 | |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Specify the config file with environment variable https://review.openstack.org/198502 | 13:11 |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Add support for configuring region lists with yaml https://review.openstack.org/198501 | 13:11 |
*** rbrooker has joined #openstack-sdks | 13:13 | |
*** stevemar has quit IRC | 13:26 | |
*** stevemar has joined #openstack-sdks | 13:26 | |
*** terrylhowe has joined #openstack-sdks | 13:27 | |
*** pm90_ has joined #openstack-sdks | 13:28 | |
*** stevemar has quit IRC | 13:33 | |
*** pm90_ has quit IRC | 13:33 | |
*** pm90_ has joined #openstack-sdks | 13:33 | |
*** petertr7_away is now known as petertr7 | 13:37 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Some updates to object_store user guide https://review.openstack.org/199622 | 13:44 |
openstackgerrit | Merged stackforge/python-openstacksdk: Add or change timestamp suffixes to "_at" https://review.openstack.org/199731 | 13:46 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:47 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Add docstrings for database resources https://review.openstack.org/199738 | 13:49 |
*** rbrooker has quit IRC | 13:51 | |
*** pm90_ is now known as pratikmallya | 13:56 | |
mordred | Shrews: ^^ I reworked https://review.openstack.org/198501 based on feedback from GheRivero | 13:59 |
*** karimb has quit IRC | 13:59 | |
*** pserebryakov has quit IRC | 14:00 | |
openstackgerrit | Everett Toews proposed stackforge/python-openstacksdk: Log reauth https://review.openstack.org/197165 | 14:08 |
*** stevemar has joined #openstack-sdks | 14:25 | |
*** stevemar has quit IRC | 14:25 | |
*** stevemar has joined #openstack-sdks | 14:26 | |
*** jose4183 has quit IRC | 14:27 | |
*** jose4183 has joined #openstack-sdks | 14:27 | |
*** zz_steveortiz is now known as steveortiz | 14:28 | |
openstackgerrit | Merged openstack/python-openstackclient: Imported Translations from Transifex https://review.openstack.org/199891 | 14:39 |
*** petertr7 is now known as petertr7_away | 14:41 | |
*** petertr7_away is now known as petertr7 | 14:43 | |
*** notmars has joined #openstack-sdks | 14:53 | |
mordred | Shrews, dtroyer: just sent email to the dev list about adding Ghe to oscc core | 15:01 |
*** sorantis has quit IRC | 15:02 | |
*** steveortiz is now known as zz_steveortiz | 15:03 | |
*** pratikmallya has quit IRC | 15:18 | |
*** jamielennox is now known as jamielennox|away | 15:23 | |
*** pratikmallya has joined #openstack-sdks | 15:24 | |
*** aufi has quit IRC | 15:26 | |
*** jamielennox|away is now known as jamielennox | 15:32 | |
*** Qiming has quit IRC | 15:33 | |
*** zz_steveortiz is now known as steveortiz | 15:34 | |
etoews | briancurtin: do you think would this be the best place for a re-auth log message? https://github.com/stackforge/python-openstacksdk/blob/master/openstack/auth/identity/base.py#L109 | 15:41 |
briancurtin | etoews: looking. that might be, but i think i'd want it even closer to where the call is being made since that just tells something that tells something else that tells something else "ok, *now* do it" | 15:43 |
briancurtin | etoews: or maybe log that reauthentication is needed, and we also log when the call is actually made? i dont know if i'm adding too many log messages here or not, but it feels like an important distinction | 15:44 |
briancurtin | etoews: oh, we actually do log "Making authentication request to %s" in openstack/auth/identity/v2.py and v3.py | 15:46 |
briancurtin | etoews: so yeah, that spot would be a good time to say something like "Re-authentication needed" | 15:46 |
etoews | k | 15:47 |
briancurtin | being able to trace that we have an expiring token, we need reauth, and that the auth request was made seems like a good set of debug logs to have. this seems good | 15:47 |
etoews | yep. super important event. guaranteed we'll be seeing lots of logs from people with this in it. ;) | 15:51 |
openstackgerrit | Everett Toews proposed stackforge/python-openstacksdk: Log reauth https://review.openstack.org/197165 | 15:54 |
*** stevemar has quit IRC | 15:56 | |
openstackgerrit | Merged openstack/python-openstackclient: openstack catalog list always returns publicURL for internalURL and adminURL https://review.openstack.org/199591 | 15:58 |
*** trown is now known as trown|mtg | 15:59 | |
*** notmars has quit IRC | 16:03 | |
*** bitblt has joined #openstack-sdks | 16:03 | |
*** notmars has joined #openstack-sdks | 16:08 | |
*** notmars_ has joined #openstack-sdks | 16:11 | |
*** notmars has quit IRC | 16:13 | |
*** notmars_ is now known as notmars | 16:13 | |
*** jose4183 has quit IRC | 16:20 | |
*** jamielennox is now known as jamielennox|away | 16:21 | |
*** jose4183 has joined #openstack-sdks | 16:21 | |
*** boris-42 has quit IRC | 16:22 | |
*** jamielennox|away is now known as jamielennox | 16:29 | |
*** notmars has quit IRC | 16:31 | |
*** pratikmallya has quit IRC | 16:31 | |
*** pratikmallya has joined #openstack-sdks | 16:32 | |
*** pratikmallya has quit IRC | 16:34 | |
*** petertr7 is now known as petertr7_away | 16:38 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Argument consistency in test_proxy_base https://review.openstack.org/200174 | 16:38 |
openstackgerrit | Merged stackforge/python-openstacksdk: Log reauth https://review.openstack.org/197165 | 16:39 |
*** trown|mtg is now known as trown | 16:45 | |
*** bitblt has quit IRC | 16:45 | |
*** trown is now known as trown|lunch | 16:54 | |
terrylhowe | briancurtin: you all done with proxy testing, etc? I’m messing with find and list is next on my list | 16:55 |
briancurtin | terrylhowe: yeah for right now, had been meaning to adjust those methods for a while and just got that out. won't be touching that anymore until after find work is done | 16:56 |
terrylhowe | thx | 16:56 |
*** rbrooker has joined #openstack-sdks | 17:11 | |
*** notmars has joined #openstack-sdks | 17:15 | |
*** boris-42 has joined #openstack-sdks | 17:20 | |
*** beagles is now known as beagles_lunch | 17:24 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Argument consistency in test_proxy_base https://review.openstack.org/200174 | 17:25 |
*** pratikmallya has joined #openstack-sdks | 17:26 | |
*** stevemar has joined #openstack-sdks | 17:36 | |
*** petertr7_away is now known as petertr7 | 17:37 | |
*** trown|lunch is now known as trown | 17:48 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: WIP: Support get/set metadata on object_store proxy https://review.openstack.org/188452 | 17:49 |
openstackgerrit | Terry Howe proposed stackforge/python-openstacksdk: Add ignore_missing to proxy find https://review.openstack.org/200191 | 17:57 |
*** bknudson has quit IRC | 17:59 | |
*** ameybhide has joined #openstack-sdks | 18:03 | |
terrylhowe | is that a cliff bug stevemar ? | 18:09 |
stevemar | terrylhowe: the help | 18:09 |
stevemar | ? | 18:09 |
stevemar | yeah, probably, assign cliff too | 18:10 |
terrylhowe | that help issue | 18:10 |
*** notmars has quit IRC | 18:10 | |
*** notmars has joined #openstack-sdks | 18:10 | |
*** stevemar has quit IRC | 18:11 | |
*** hitalia has joined #openstack-sdks | 18:11 | |
openstackgerrit | Terry Howe proposed stackforge/python-openstacksdk: Add ignore_missing to proxy find https://review.openstack.org/200191 | 18:13 |
*** stevemar has joined #openstack-sdks | 18:14 | |
*** stevemar has quit IRC | 18:15 | |
*** stevemar has joined #openstack-sdks | 18:15 | |
*** shaleh has joined #openstack-sdks | 18:18 | |
stevemar | terrylhowe: yeah, shaleh is the fella from the ML | 18:20 |
*** rbrooker has quit IRC | 18:34 | |
*** jaosorior has quit IRC | 18:36 | |
*** beagles_lunch is now known as beagles | 18:37 | |
etoews | all: terrylhowe: briancurtin: here's proposal i worked up for the sdk to be added to the big tent https://etherpad.openstack.org/p/python-openstacksdk-big-tent-proposal | 18:45 |
etoews | please have a look. fix grammar and punctuation as you will. discuss here or comment on the etherpad for substantial changes. | 18:45 |
etoews | we'll also need to fill in the ptl field for the projects.yaml | 18:46 |
etoews | dtroyer: fyi, i mention osc in the proposal | 18:47 |
etoews | mordred: fyi, i mention occ in the proposal | 18:47 |
briancurtin | etoews: i think url in the projects.yaml should just we the wiki. that looks like what others have done, and i have to assume we'll eventually have docs up on openstack.org (could leave RTD as well, though) | 18:56 |
terrylhowe | oh oh, etoews is punting on image create | 18:58 |
etoews | terrylhowe: ? i actually did image create/import. i'm punting on update. :) https://review.openstack.org/#/c/199318/ | 19:00 |
terrylhowe | ah, okay, thanks | 19:00 |
*** petertr7 is now known as petertr7_away | 19:01 | |
terrylhowe | somehow I missed that one | 19:01 |
*** petertr7_away is now known as petertr7 | 19:01 | |
*** rbrooker has joined #openstack-sdks | 19:19 | |
etoews | terrylhowe: also, image update in glance v2 uses json-patch, which isn't used anywhere else in the sdk yet. i knew i wouldn't have time to dig into it before leaving on vacation tomorrow. | 19:22 |
terrylhowe | well, have a blast on vacation :) | 19:23 |
*** notmars has quit IRC | 19:24 | |
briancurtin | terrylhowe: what do you want to do about the PTL slot in that proposal? i dont know if we need a formal election for this one or if a meeting works or how we want to get started with this | 19:26 |
*** notmars has joined #openstack-sdks | 19:31 | |
*** shaleh has quit IRC | 19:42 | |
*** shaleh has joined #openstack-sdks | 19:47 | |
shaleh | re: --help option to openstack subcommands | 19:47 |
shaleh | I investigated why 'openstack user list --help' shows the openstack top level help instead of the sub command help. | 19:48 |
shaleh | The --help option is consumed by the top level argparse before the code ever looks at the subcommands. | 19:48 |
*** petertr7 is now known as petertr7_away | 19:48 | |
shaleh | so the help action is triggered at the top level instead of lower down | 19:48 |
shaleh | to resolve this what I did was check if 'remainder' had any values during app.run(). If it does and self.options.deferred_help is true I set it to false and push "--help" onto the remainders list. | 19:49 |
shaleh | This allows the code to end sub command processing. | 19:50 |
shaleh | But then the next snag occurs. The check for a proper project, username, etc. is run before the arguments to the subcommand are processed. | 19:50 |
shaleh | To fix this I moved prepare_to_run_command to occur just before the command runs instead of before argument parsing. | 19:51 |
shaleh | It is this second change I am most concerned about. | 19:51 |
shaleh | All told this is only about 7 lines of code. | 19:51 |
shaleh | is there a reason to not parse the subcommand options before ensuring the user has what they need to authenticate? | 19:51 |
*** petertr7_away is now known as petertr7 | 19:52 | |
shaleh | I could not think of a good reason, but I thought I would ask the old timers | 19:52 |
terrylhowe | shaleh: the main reason is you can’t tell what commands you have until you parse the options and auth | 19:53 |
terrylhowe | if you don’t have v3 identity for instance, the commands don’t show up, you’d get v2 | 19:53 |
shaleh | terrylhowe: is there a use case where a user will ask for --help and not get any because they have not given all of the parameters? | 19:54 |
shaleh | look at line 304+ in cliff/app.py. This is where all of the changes occur. | 19:55 |
shaleh | I moved self.prepare_to_run_command() to just before cmd.run() | 19:56 |
shaleh | at this point, I know you have asked for 'user list' and I am attempting to parse the options accordingly | 19:56 |
terrylhowe | well, as long as ‘os user list —os-identity-api-version 3 —help’ works we are g2g | 19:57 |
terrylhowe | default is v2 I think although that might of changed | 19:57 |
shaleh | does passing --os-identity-api-version 3 change the output of the help? | 19:57 |
shaleh | All of the --os-foo options are consumed at the top level already. | 19:58 |
shaleh | All that is being parsed here are subcommand specific options | 19:58 |
shaleh | This is actually the core reason this behaviour occurs. os --os-blah user list and os user list --os-blah both work | 19:59 |
shaleh | Most apps consume top level options first then let subcommands handle it. So 'os user list --os-blah' would try to let user->list process --os-blah | 20:00 |
terrylhowe | well ‘os credential list’ is maybe a better example. it doesn’t exist for v2 | 20:00 |
shaleh | I will experiment and ensure. Thanks for the pointer. | 20:01 |
shaleh | back in a bit | 20:01 |
terrylhowe | user list for example is in both, but v3 has —domain | 20:01 |
*** pratikmallya has quit IRC | 20:05 | |
*** stevemar has quit IRC | 20:08 | |
*** stevemar has joined #openstack-sdks | 20:11 | |
openstackgerrit | Terry Howe proposed stackforge/python-openstacksdk: Add ignore_missing to proxy find https://review.openstack.org/200191 | 20:11 |
*** stevemar has quit IRC | 20:12 | |
*** stevemar has joined #openstack-sdks | 20:12 | |
*** notmars has quit IRC | 20:17 | |
openstackgerrit | Doug Hellmann proposed openstack/cliff: Fix logging config in demo app https://review.openstack.org/200240 | 20:17 |
*** stevemar has quit IRC | 20:19 | |
*** stevemar has joined #openstack-sdks | 20:21 | |
*** stevemar has quit IRC | 20:25 | |
*** pratikmallya has joined #openstack-sdks | 20:33 | |
*** pratikmallya has quit IRC | 20:33 | |
*** pratikmallya has joined #openstack-sdks | 20:34 | |
*** karimb has joined #openstack-sdks | 20:38 | |
*** karimb has quit IRC | 20:39 | |
*** karimb has joined #openstack-sdks | 20:39 | |
*** hitalia has quit IRC | 20:43 | |
dtroyer | shaleh: the API version options affect the help output, the commands are different for different API versions. we hide that when we can, but it is unavoidable | 21:02 |
dtroyer | re-rdering cliff will have ramifications in more than just OSC and needs to be carefully considered | 21:02 |
dtroyer | as it is there is more context-sensitivity to help than I would like, it seemed easier to me to document that —help and -h were for global and the help command is for command-specific | 21:03 |
dtroyer | ie, easier for a user to learn. trying to be too smart often for one group means we're too obtuse for another | 21:04 |
mordred | etoews: woot! | 21:05 |
*** sigmavirus24 is now known as emacsraptor | 21:10 | |
*** emacsraptor is now known as sigmavirus24 | 21:10 | |
*** hitalia has joined #openstack-sdks | 21:13 | |
*** petertr7 is now known as petertr7_away | 21:17 | |
*** trown is now known as trown|outttypeww | 21:20 | |
*** notmars has joined #openstack-sdks | 21:21 | |
*** jose4183 has quit IRC | 21:25 | |
*** jamielennox is now known as jamielennox|away | 21:37 | |
*** steveortiz is now known as zz_steveortiz | 21:40 | |
*** shaleh has quit IRC | 21:47 | |
*** shaleh has joined #openstack-sdks | 21:47 | |
*** jamielennox|away is now known as jamielennox | 21:48 | |
*** notmars has quit IRC | 21:55 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 21:59 | |
*** bknudson has joined #openstack-sdks | 22:04 | |
openstackgerrit | Merged openstack/cliff: Use base command for help test https://review.openstack.org/199052 | 22:05 |
openstackgerrit | Merged openstack/cliff: Fix logging config in demo app https://review.openstack.org/200240 | 22:10 |
shaleh | dtroyer: documenting bad UX does not improve the UX. There is no reason not to behave better. | 22:10 |
shaleh | if there is concern about my change affecting projects outside of OpenStack it would be pretty easy to put another flag like deferred_help in cliff. | 22:11 |
*** bknudson has quit IRC | 22:27 | |
*** shaleh has quit IRC | 22:37 | |
*** stevemar has joined #openstack-sdks | 22:49 | |
*** stevemar has quit IRC | 22:54 | |
*** pratikmallya has quit IRC | 23:01 | |
*** pratikmallya has joined #openstack-sdks | 23:01 | |
openstackgerrit | Terry Howe proposed stackforge/python-openstacksdk: WIP: List QueryParameters class https://review.openstack.org/200308 | 23:34 |
*** openstack has joined #openstack-sdks | 23:40 | |
-cameron.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 23:40 | |
*** Qiming has joined #openstack-sdks | 23:43 | |
*** chlong has quit IRC | 23:49 | |
*** thrash is now known as thrash|g0ne | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!