*** etoews has quit IRC | 01:49 | |
*** britthou_ has quit IRC | 02:13 | |
*** britthouser has joined #openstack-sdks | 02:13 | |
*** stevemar has joined #openstack-sdks | 02:14 | |
*** jamielennox is now known as jamielennox|away | 02:58 | |
*** jamielennox|away is now known as jamielennox | 03:03 | |
*** subscope has joined #openstack-sdks | 04:25 | |
*** subscope has quit IRC | 04:47 | |
*** boris-42 has quit IRC | 04:58 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Imported Translations from Transifex https://review.openstack.org/175268 | 06:04 |
---|---|---|
*** stevemar has quit IRC | 06:40 | |
*** aufi has joined #openstack-sdks | 06:46 | |
*** jamielennox is now known as jamielennox|away | 06:52 | |
*** stevemar has joined #openstack-sdks | 06:54 | |
*** chlong has quit IRC | 07:29 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Refactor utility to find identity resources https://review.openstack.org/175184 | 07:51 |
*** stevemar has quit IRC | 08:06 | |
*** f13o has joined #openstack-sdks | 08:47 | |
*** chlong has joined #openstack-sdks | 08:50 | |
*** chlong has quit IRC | 09:20 | |
*** chlong has joined #openstack-sdks | 09:32 | |
*** boris-42 has joined #openstack-sdks | 09:51 | |
*** chlong has quit IRC | 11:58 | |
*** trown|outttypeww is now known as trown | 12:13 | |
*** bknudson has quit IRC | 12:26 | |
*** jamielennox|away is now known as jamielennox | 12:31 | |
*** jamielennox is now known as jamielennox|away | 12:32 | |
*** bknudson has joined #openstack-sdks | 12:55 | |
*** pm90_ has joined #openstack-sdks | 13:06 | |
*** f13o has quit IRC | 13:07 | |
*** f13o has joined #openstack-sdks | 13:12 | |
*** pm90_ has quit IRC | 13:22 | |
*** pm90_ has joined #openstack-sdks | 13:23 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:42 | |
*** mattfarina has joined #openstack-sdks | 13:45 | |
*** terrylhowe has joined #openstack-sdks | 13:45 | |
*** stevemar has joined #openstack-sdks | 14:39 | |
*** f13o has quit IRC | 14:40 | |
*** f13o has joined #openstack-sdks | 14:40 | |
*** pm90_ has quit IRC | 14:56 | |
*** beekneemech is now known as bnemec | 15:10 | |
stevemar | dtroyer, if you have a minute, can you look at: https://review.openstack.org/#/c/175184/ | 15:33 |
stevemar | it's failing tests, but because the fake object's __module__ defaults to 'mock' instead of another value | 15:34 |
stevemar | actually, i'll clean it up differently | 15:37 |
dtroyer | see, if I wait long enough things resolve themselves… ;) | 15:37 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Refactor utility to find identity resources https://review.openstack.org/175184 | 15:44 |
openstackgerrit | Terry Howe proposed openstack/python-openstackclient: Handle the pagination for image list https://review.openstack.org/173420 | 15:49 |
*** pm90_ has joined #openstack-sdks | 16:08 | |
dtroyer | stevemar: so, I'll make one attempt at philosophical purity then move on… in _find_identity_resource() could you pass in the actual resource type and have a single object creation at the end? and only branch if we have a type later on that doesn't fit the id/name pattern? | 16:20 |
stevemar | dtroyer, passin users.User as resource_type, and call return resource_type(None, {...}) ? | 16:22 |
dtroyer | right | 16:23 |
dtroyer | it gets rid of the type-specific branching in a common method | 16:23 |
dtroyer | or jsut return name_or_id and do that in the calling method | 16:24 |
stevemar | thats cool with me, i was thinking of something like that, but didn't kow if it would work | 16:25 |
stevemar | but, it does! | 16:25 |
dtroyer | dynamic typing FTW! | 16:26 |
dtroyer | I will admit after a weekend of Go that's nice to not think so hard about | 16:26 |
*** aufi has quit IRC | 16:31 | |
*** trown is now known as trown|lunch | 16:39 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Refactor utility to find identity resources https://review.openstack.org/175184 | 16:40 |
stevemar | dtroyer, added helpful docstrings too! | 16:40 |
dtroyer | nice | 16:44 |
sdague | hey, so I have a UX gripe about the fact that -h and help are different | 16:45 |
sdague | I keep end up typing the wrong one in the wrong context, it would be really nice if they were unified | 16:46 |
dtroyer | they are implemented totally differently internally…it could be done, it just isn't a shake-the-box thing to fix | 16:47 |
dtroyer | so would you have the presence/absens of something that looked command-like be ther trigger to decide between command help and global help? | 16:47 |
sdague | yeh | 16:50 |
sdague | honestly, the fact that "openstack" with no options takes me to a shell, it's entirely helpful | 16:50 |
sdague | especially when you compare that to 'nova' with no args | 16:51 |
stevemar | sdague, bknudson had the same issue with no args | 16:52 |
bknudson | stevemar: how did you know? | 16:52 |
stevemar | bknudson, you mentioned it way back when | 16:52 |
bknudson | ah... I thought I had kept it to myself. | 16:52 |
stevemar | or i can read minds | 16:53 |
bknudson | I have a lot of pent up rage. | 16:53 |
stevemar | taking notes from mriedeman again | 16:53 |
bknudson | he's my idol. | 16:53 |
stevemar | dtroyer, maybe it's time to re-evaluate our help UX | 16:54 |
bknudson | the openstack command prompt and help issues don't bother me that much. | 16:55 |
bknudson | "openstack help" says that -h "shows this help message", but -h actually shows useful help text. | 16:56 |
*** f13o has quit IRC | 16:57 | |
bknudson | and help from the command prompt is totally different. | 16:58 |
dtroyer | stevemar: I'm sure we can improve things but we're getting really close to purely preference issues | 16:58 |
bknudson | I didn't know there was a "hi" command. | 16:58 |
dtroyer | whether we change anything or not we need to write down the rationale so we don't have this conversation next year | 16:58 |
dtroyer | bknudson: that's a cmd2 built-in | 16:59 |
dtroyer | I've always also wanted to do Cisco IOS-style shortcuts | 16:59 |
dtroyer | but that's even more runtime startup stuff that we don't need | 16:59 |
dtroyer | anyway, I see a summit conversation coming | 17:00 |
sdague | also "openstack help" doesn't work without auth | 17:00 |
stevemar | dtroyer, add it to the etherpad | 17:00 |
stevemar | sdague, it should now with the latest release | 17:00 |
sdague | which seems wierd | 17:00 |
stevemar | or will, when we release it | 17:00 |
stevemar | sdague, that was actually a regression | 17:01 |
sdague | oh, this is 1.0.2 | 17:01 |
bknudson | I've got 1.0.3 and openstack help works for me. | 17:01 |
dtroyer | did that come with —so-cloud? | 17:01 |
stevemar | sdague, try 1.0.3 | 17:01 |
stevemar | i don't remember where the fix for that fell, but it's either there or master | 17:01 |
stevemar | steppin out for a bit | 17:02 |
dtroyer | also, help is dependent on API versions selected, which it totally non-intuitive | 17:02 |
sdague | yeh, let me rebuild this box | 17:02 |
dtroyer | help is hard | 17:02 |
dtroyer | but not too hard | 17:02 |
sdague | oh, right, and the whole fact that you don't get volumes commands if you source openrc | 17:02 |
dtroyer | that's the version thing | 17:03 |
bknudson | I ran into an issue where I had to set the cinder_api_version or something for boot... it was 2 and openstack cli complained it needed to be 2. | 17:04 |
bknudson | unfortunately I didn't write it down. | 17:04 |
dtroyer | it probably needed to be OS_VOLUME_API_VERSION=1, osc doesn't do volume v2 yet | 17:05 |
sdague | dtroyer: so, we should probably delete that bit from devstack | 17:09 |
sdague | it goes back to 2013 | 17:10 |
sdague | but seems weird to set there | 17:10 |
*** pm90_ has quit IRC | 17:14 | |
*** pm90_ has joined #openstack-sdks | 17:19 | |
openstackgerrit | Terry Howe proposed openstack/python-openstackclient: Handle the pagination for image list https://review.openstack.org/173420 | 17:23 |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply delete API changes https://review.openstack.org/174904 | 17:30 |
openstackgerrit | Terry Howe proposed stackforge/python-openstacksdk: Dynamically load services https://review.openstack.org/155362 | 17:33 |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply object_store delete changes https://review.openstack.org/175017 | 17:49 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to identity proxies https://review.openstack.org/174922 | 17:51 |
*** mattfarina has quit IRC | 18:04 | |
*** trown|lunch is now known as trown | 18:08 | |
*** mattfarina has joined #openstack-sdks | 18:16 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply delete changes to identity proxies https://review.openstack.org/174922 | 18:30 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to keystore proxy https://review.openstack.org/174947 | 18:37 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to image proxies https://review.openstack.org/174944 | 18:38 |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply orchestration delete change https://review.openstack.org/175020 | 19:29 |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply telemetry delete change https://review.openstack.org/175021 | 19:33 |
*** chellygel has left #openstack-sdks | 19:33 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply network delete changes https://review.openstack.org/175011 | 19:34 |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply delete changes to keystore proxy https://review.openstack.org/174947 | 19:45 |
openstackgerrit | Merged stackforge/python-openstacksdk: Apply delete changes to image proxies https://review.openstack.org/174944 | 19:46 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Proxy get method https://review.openstack.org/164351 | 19:52 |
*** pm90_ has quit IRC | 20:09 | |
openstackgerrit | Merged openstack/python-openstackclient: Imported Translations from Transifex https://review.openstack.org/175268 | 20:27 |
openstackgerrit | Merged openstack/python-openstackclient: Handle the pagination for image list https://review.openstack.org/173420 | 20:35 |
*** etoews has joined #openstack-sdks | 20:44 | |
*** pm90_ has joined #openstack-sdks | 20:45 | |
*** pm90_ has quit IRC | 20:45 | |
*** pm90_ has joined #openstack-sdks | 20:46 | |
etoews | terrylhowe: do you have a minute to chat about https://review.openstack.org/#/c/174980/4 ? | 20:48 |
*** stevemar has quit IRC | 20:58 | |
*** trown is now known as trown|outttypeww | 21:04 | |
*** mattfarina has quit IRC | 21:37 | |
*** pm90_ has quit IRC | 22:21 | |
etoews | terrylhowe: i commented in the review. we can also discuss at the meeting tomorrow if we don't get to it before then. | 22:26 |
*** bknudson has quit IRC | 22:26 | |
*** chlong has joined #openstack-sdks | 23:34 | |
*** jamielennox|away is now known as jamielennox | 23:45 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:46 | |
*** openstackgerrit has quit IRC | 23:58 | |
*** openstackgerrit has joined #openstack-sdks | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!