| *** bknudson has joined #openstack-sdks | 00:12 | |
| *** britthouser has joined #openstack-sdks | 00:56 | |
| *** mattfarina has joined #openstack-sdks | 01:17 | |
| *** mattfarina has quit IRC | 01:17 | |
| *** britthouser has quit IRC | 01:46 | |
| *** openstackgerrit has quit IRC | 05:21 | |
| *** openstackgerrit has joined #openstack-sdks | 05:21 | |
| *** stevemar has joined #openstack-sdks | 05:21 | |
| *** terrylhowe has quit IRC | 05:26 | |
| *** stevemar has quit IRC | 05:32 | |
| *** stevemar has joined #openstack-sdks | 05:33 | |
| *** aufi has joined #openstack-sdks | 06:03 | |
| *** stevemar has quit IRC | 06:12 | |
| *** bnemec has quit IRC | 06:32 | |
| openstackgerrit | Merged openstack/python-openstackclient: Better help for --nic in create server https://review.openstack.org/174091 | 07:04 |
|---|---|---|
| *** chlong has quit IRC | 07:33 | |
| *** Miouge has joined #openstack-sdks | 08:28 | |
| *** Miouge_ has joined #openstack-sdks | 08:30 | |
| *** Miouge has quit IRC | 08:34 | |
| *** Miouge_ is now known as Miouge | 08:34 | |
| *** nosleep77 has quit IRC | 09:20 | |
| *** jamielennox is now known as jamielennox|away | 09:49 | |
| *** trown|outttypeww is now known as trown | 11:32 | |
| aufi | Hi, I found propably typo in image create action source (localtion x location attribute name; location attribute is not passed to the method - https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v1/image.py#L193). Should I create bug on launchpad and fix it? | 11:50 |
| *** terrylhowe has joined #openstack-sdks | 11:55 | |
| *** bknudson has quit IRC | 12:15 | |
| openstackgerrit | Marek Aufart proposed openstack/python-openstackclient: Fix skipped image create attribute location attr https://review.openstack.org/174848 | 12:27 |
| *** bknudson has joined #openstack-sdks | 12:36 | |
| *** nosleep77 has joined #openstack-sdks | 12:38 | |
| *** Miouge has quit IRC | 12:48 | |
| openstackgerrit | Merged openstack/python-openstackclient: Uncap library requirements for liberty https://review.openstack.org/174542 | 12:51 |
| openstackgerrit | Terry Howe proposed openstack/python-openstackclient: Functional tests run with less customization https://review.openstack.org/174566 | 12:53 |
| *** Miouge has joined #openstack-sdks | 13:05 | |
| *** edleafe is now known as figleaf | 13:20 | |
| *** Miouge has quit IRC | 13:36 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:45 | |
| *** mattfarina has joined #openstack-sdks | 13:45 | |
| openstackgerrit | Terry Howe proposed openstack/python-openstackclient: Print warning on authentication error https://review.openstack.org/173918 | 13:54 |
| *** pm90_ has joined #openstack-sdks | 13:59 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Add --os-cloud support https://review.openstack.org/129795 | 14:02 |
| *** bnemec has joined #openstack-sdks | 14:03 | |
| *** pm90_ has quit IRC | 14:03 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Begin documenting --os-cloud https://review.openstack.org/161093 | 14:04 |
| *** pm90_ has joined #openstack-sdks | 14:04 | |
| *** pm90_ has quit IRC | 14:16 | |
| *** britthouser has joined #openstack-sdks | 14:36 | |
| *** stevemar has joined #openstack-sdks | 14:37 | |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete API changes https://review.openstack.org/174904 | 14:48 |
| openstackgerrit | Nathan Kinder proposed openstack/python-openstackclient: Role operations should not require list object permission https://review.openstack.org/174908 | 14:52 |
| *** pm90_ has joined #openstack-sdks | 14:54 | |
| *** pm90_ has quit IRC | 14:54 | |
| openstackgerrit | Merged openstack/python-openstackclient: Fix skipped image create attribute location attr https://review.openstack.org/174848 | 15:04 |
| openstackgerrit | Merged stackforge/golang-client: Workflow documentation is now in infra-manual https://review.openstack.org/139465 | 15:23 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to identity proxies https://review.openstack.org/174922 | 15:35 |
| etoews | what do people think about moving Server.wait_for_status up into a Resource.wait_for_status? | 15:53 |
| etoews | however, not all resources have a status prop | 15:53 |
| etoews | so maybe it makes more sense as a generic util method | 15:54 |
| etoews | that takes a Resource (that must have a status prop) | 15:54 |
| etoews | plus all of the other stuff wait_for_status would need | 15:55 |
| etoews | i'm going to try moving it to the utils module and see what that looks like | 15:56 |
| *** britthouser has quit IRC | 15:58 | |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to image proxies https://review.openstack.org/174944 | 16:00 |
| *** britthouser has joined #openstack-sdks | 16:02 | |
| *** trown is now known as trown|lunch | 16:08 | |
| briancurtin | etoews: in utils is probably ideal | 16:11 |
| etoews | yep. self just becomes resource. | 16:11 |
| *** aufi has quit IRC | 16:11 | |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to keystore proxy https://review.openstack.org/174947 | 16:13 |
| *** britthouser has quit IRC | 16:17 | |
| *** subscope has joined #openstack-sdks | 16:20 | |
| *** britthouser has joined #openstack-sdks | 16:21 | |
| etoews | how bad is it to shadow a module name with a function parameter? e.g. | 16:22 |
| etoews | from openstack.compute.v2 import server | 16:22 |
| etoews | ... | 16:22 |
| etoews | def wait_for_status(self, server, status='ACTIVE', failures=['ERROR'], ...) | 16:22 |
| etoews | the server param shadows the module import | 16:23 |
| etoews | it's unfortunate but doesn't harm anything as the server module isn't used in wait_for_status | 16:25 |
| *** britthouser has quit IRC | 16:37 | |
| terrylhowe | the only reason really to move it to utils would be to avoid churn in the Resource class and to keep it as simple as possible. The keep it as simple as possible is a good reason, but maybe we should consider (at least for the future) some other way of breaking things down or design so we aren’t dumping things in utils that are really associated with a resource. | 16:46 |
| briancurtin | etoews: that's not great, but if it's in teh util module it should probably be more generic than server so it's not implied that it's only able to wait on servers. in theory it would be able to wait on anything that needed to be waited on, so maybe make it resource? (unless that is also shadowed...) | 16:47 |
| briancurtin | etoews: i have the same problem with a lot of these proxy apis. i'd love to say delete_server(server), but we have to pass a reference to the actual server.Server from within there, so it's delete_server(value) | 16:48 |
| terrylhowe | the only other big async thing I can think of is volumes, but in theory, people could wait on any field change if it was generalized | 16:48 |
| terrylhowe | Ruby Fog used to have some method like that some wait_for where you could wait on any field change. | 16:49 |
| briancurtin | libcloud has something similar iirc | 16:49 |
| etoews | it's in the _proxy module where i run into the shadowing. same as what you've seen. i can use value instead. | 16:50 |
| etoews | it's certainly more generic than server | 16:51 |
| etoews | that's the whole point of moving it out | 16:51 |
| etoews | volumes, stacks, databases, servers, images, lots of stuff needs it | 16:52 |
| etoews | every lib i can think of has a util for it rather than inheriting it because not every resource has a status | 16:53 |
| openstackgerrit | Nathan Kinder proposed openstack/python-openstackclient: Role operations should not require list object permission https://review.openstack.org/174908 | 17:15 |
| openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Re-organize functional tests https://review.openstack.org/174974 | 17:38 |
| stevemar | terrylhowe, ^ | 17:39 |
| stevemar | now to see if it passes... | 17:39 |
| *** trown|lunch is now known as trown | 17:50 | |
| openstackgerrit | Everett Toews proposed stackforge/python-openstacksdk: Move wait_for_status to utils https://review.openstack.org/174980 | 17:54 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete API changes https://review.openstack.org/174904 | 19:03 |
| stevemar | dtroyer, mind approving https://review.openstack.org/#/c/174974/ ? | 19:10 |
| dtroyer | stevemar: sure, test away! | 19:12 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply network delete changes https://review.openstack.org/175011 | 19:18 |
| *** pm90_ has joined #openstack-sdks | 19:20 | |
| *** bnemec is now known as beekneemech | 19:22 | |
| stevemar | \o/ | 19:23 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply object_store delete changes https://review.openstack.org/175017 | 19:29 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply orchestration delete change https://review.openstack.org/175020 | 19:37 |
| *** stevemar has quit IRC | 19:40 | |
| *** stevemar2 has joined #openstack-sdks | 19:40 | |
| openstackgerrit | Merged stackforge/python-openstacksdk: Add module name to repr string https://review.openstack.org/174350 | 19:40 |
| *** subscope has quit IRC | 19:40 | |
| openstackgerrit | Merged stackforge/python-openstacksdk: Add more detail to method not supported exception https://review.openstack.org/174409 | 19:41 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply telemetry delete change https://review.openstack.org/175021 | 19:41 |
| openstackgerrit | Everett Toews proposed stackforge/python-openstacksdk: Move wait_for_status to resource module https://review.openstack.org/174980 | 19:46 |
| openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Apply delete changes to volume proxy https://review.openstack.org/175025 | 19:51 |
| etoews | terrylhowe: i thought about what you said about wait_for_status in utils. you're right. i don't want utils to become a dumping ground either. i think it makes more sense in the resource module. let me know what you think. | 19:51 |
| terrylhowe | I think so etoews. It’d also be nice if we could find a way to break down resource a bit so there isn’t as much churn there. | 19:55 |
| openstackgerrit | Merged openstack/python-openstackclient: Re-organize functional tests https://review.openstack.org/174974 | 20:06 |
| *** mattfarina has quit IRC | 20:11 | |
| *** stevemar2 is now known as stevemar | 20:15 | |
| briancurtin | etoews: i like resource.wait_for_status as a generic wait function, but i wonder if the server and orchestration proxy usages of it should have a more specific name? since the status and failure values are specific to servers and stacks, maybe wait_for_server and wait_for_stack? | 20:21 |
| *** openstackgerrit has quit IRC | 20:22 | |
| *** openstackgerrit has joined #openstack-sdks | 20:22 | |
| etoews | hmmmm...my first reaction is that it would be nice to have a consistent name across all proxy usages. | 20:22 |
| etoews | i can certainly see where you're coming from though | 20:23 |
| etoews | and you've still got the common wait_for_ prefix | 20:24 |
| briancurtin | etoews: yeah, i thought the wait_for_ prefix keeps it inline, so you have create_server, delete_server, wait_for_server, etc | 20:25 |
| etoews | right. in that sense it's more consistent with the verb_resource naming in the proxies. | 20:26 |
| *** trown is now known as trown|outttypeww | 20:29 | |
| openstackgerrit | Everett Toews proposed stackforge/python-openstacksdk: Move wait_for_status to resource module https://review.openstack.org/174980 | 20:41 |
| openstackgerrit | Merged openstack/python-openstackclient: Fix session timing https://review.openstack.org/164091 | 20:47 |
| briancurtin | etoews: that wait_for change looks good, but im going to find some examples to look off of for the orchestration tests. we need to not use MagicMock (i think there's an issue to eventually remove them all) -- we know what methods we'll be calling and what attributes to fill out, so we should do that without the magic | 20:59 |
| *** figleaf is now known as edleafe | 21:02 | |
| etoews | sgtm. if there's a better way to do it, i'm happy to learn. | 21:03 |
| *** pm90_ has quit IRC | 21:04 | |
| -openstackstatus- NOTICE: Gerrit will be unavailable between 22:00 and 23:59 UTC for project renames and a database update. | 21:05 | |
| *** pm90_ has joined #openstack-sdks | 21:05 | |
| briancurtin | etoews: actually, teh more i think about it, you really shouldn't need the in-depth orchestration tests to run it through those states. resource.wait_for_status should be where that stuff is tested (and it is), and applications of that function should just be tested that they're passing in arguments and that they get through, similar to how we do the other | 21:09 |
| briancurtin | proxy tests -- we test BaseProxy._delete in depth, and then delete_server we just verify that it's sending the right things through | 21:09 |
| etoews | briancurtin: should i move the in depth testing to test_resource.py and do only 1 basic test in each of test_server and test_stack? | 21:13 |
| briancurtin | etoews: i'd move what exists in test_server to be in test_resource, and then in test_{server|stack} have something that just checks when you call wait_for_{server|stack} that teh underlying wait_for_status function is receiving the appropriate values. so test the functionality in test_resource, watch after its usage in the server/stack tests | 21:16 |
| etoews | yep. i think we have the same thing in mind. | 21:18 |
| *** openstackgerrit has quit IRC | 21:23 | |
| *** openstackgerrit has joined #openstack-sdks | 21:23 | |
| *** pm90_ has quit IRC | 21:28 | |
| *** stevemar has quit IRC | 21:29 | |
| etoews | briancurtin: actually i think the tests for wait_for_{server|stack} wind up belonging in test_proxy rather than test_{server|stack}. thoughts? | 21:39 |
| etoews | compute.v2.test_proxy and orch.v1.test_proxy that is | 21:40 |
| *** bknudson has quit IRC | 21:44 | |
| *** jamielennox|away is now known as jamielennox | 21:48 | |
| briancurtin | etoews: yep, that's right | 21:50 |
| *** pm90_ has joined #openstack-sdks | 22:03 | |
| -openstackstatus- NOTICE: Gerrit is unavailable until 23:59 UTC for project renames and a database update. | 22:05 | |
| -openstackstatus- NOTICE: Gerrit is unavailable until 23:59 UTC for project renames and a database update. | 22:08 | |
| *** ChanServ changes topic to "Gerrit is unavailable until 23:59 UTC for project renames and a database update." | 22:09 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:13 | |
| *** terrylhowe has quit IRC | 22:57 | |
| openstackgerrit | Merged stackforge/python-openstacksdk: Updated from global requirements https://review.openstack.org/174554 | 23:04 |
| *** ChanServ changes topic to "#openstack-sdks" | 23:06 | |
| -openstackstatus- NOTICE: Gerrit is available again. | 23:06 | |
| *** pm90_ has quit IRC | 23:09 | |
| *** jamielennox is now known as jamielennox|away | 23:30 | |
| *** stevelle has quit IRC | 23:46 | |
| *** stevelle has joined #openstack-sdks | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!