| *** bknudson has joined #openstack-sdks | 00:17 | |
| *** bknudson has left #openstack-sdks | 00:25 | |
| *** bknudson has joined #openstack-sdks | 00:34 | |
| jamielennox | Alex_Gaynor, terrylhowe: i created a replacement for httpretty i want to get used instead https://github.com/jamielennox/requests-mock do you guys want to have a look at it from a general python library perspective and the docs and tell me any problems you see before i try to get it used | 01:40 |
|---|---|---|
| *** jamielennox is now known as jamielennox|away | 02:22 | |
| *** openstackgerrit has quit IRC | 02:31 | |
| *** samchoi has quit IRC | 02:42 | |
| *** deanchou has joined #openstack-sdks | 04:27 | |
| *** deanchou has left #openstack-sdks | 04:30 | |
| *** deanchou has joined #openstack-sdks | 04:32 | |
| *** deanchou has left #openstack-sdks | 04:32 | |
| *** deanchou has joined #openstack-sdks | 04:32 | |
| *** deanchou has quit IRC | 04:36 | |
| *** etoews has joined #openstack-sdks | 04:39 | |
| *** etoews has quit IRC | 04:44 | |
| *** deanchou has joined #openstack-sdks | 04:58 | |
| *** terrylhowe has quit IRC | 06:19 | |
| *** etoews has joined #openstack-sdks | 06:41 | |
| *** stevemar has quit IRC | 06:45 | |
| *** etoews has quit IRC | 06:47 | |
| *** etoews has joined #openstack-sdks | 07:44 | |
| *** etoews has quit IRC | 07:48 | |
| *** etoews has joined #openstack-sdks | 08:44 | |
| *** etoews has quit IRC | 08:49 | |
| *** openstackgerrit has joined #openstack-sdks | 08:53 | |
| *** mattyw has joined #openstack-sdks | 09:10 | |
| *** etoews has joined #openstack-sdks | 09:45 | |
| *** etoews has quit IRC | 09:50 | |
| *** deanchou has quit IRC | 10:05 | |
| *** terrylhowe has joined #openstack-sdks | 11:02 | |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Make version parsing in examples more intelligent https://review.openstack.org/102503 | 11:56 |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Have exceptions print something by default https://review.openstack.org/102504 | 11:58 |
| *** etoews has joined #openstack-sdks | 13:18 | |
| *** etoews has quit IRC | 14:14 | |
| *** stevemar has joined #openstack-sdks | 14:30 | |
| *** etoews has joined #openstack-sdks | 14:56 | |
| *** samchoi has joined #openstack-sdks | 15:16 | |
| *** mfer has joined #openstack-sdks | 15:27 | |
| mfer | openstack-sdk-php meeting in 3 minutes in #openstack-meeting-3 | 15:27 |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Add --data option to debug curl logging https://review.openstack.org/102561 | 15:39 |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Have the service catalog ignore empty urls https://review.openstack.org/102564 | 15:43 |
| *** etoews has quit IRC | 15:47 | |
| dtroyer | terrylhowe: in transport.py, what is resp.is_redirect supposed to be? I can't find that defined anywhere in requests or the SDK. https://github.com/stackforge/python-openstacksdk/blob/master/openstack/transport.py#L156 | 16:07 |
| terrylhowe | From requests dtroyer there might be other cases for that, not sure | 16:09 |
| terrylhowe | https://github.com/kennethreitz/requests/blob/master/requests/models.py#L607 | 16:09 |
| dtroyer | ok…I see it now…lesson: update your repo before complaining about undefined attributes. | 16:10 |
| terrylhowe | I’m not entirely thrilled with that bit in transport, but it works | 16:10 |
| dtroyer | this does imply we have a slightly higher minimum reuqests version than currently specified | 16:12 |
| terrylhowe | do you want me to update or are you? | 16:12 |
| dtroyer | I'll do it, I'm looking for the minimum rev with it | 16:12 |
| dtroyer | ooohhh….it's brand-spanking new… 2.3.0? | 16:13 |
| dtroyer | I'm not sure I'd suggest we do that just yet | 16:14 |
| dtroyer | although that does finally address the redirect issues, we'll have to see if that is equivalent to Jamie's bits | 16:14 |
| dtroyer | so 2.3.0 isn't released yet, we need to handle resp.is_redirect not present in the current transport code | 16:15 |
| dtroyer | terrylhowe: So my question is now, why do we not want to do resp.body = resp.json() in the redirect case? | 16:19 |
| terrylhowe | the response isn’t valid json | 16:20 |
| terrylhowe | like empty, it was blowing up for me in those redirect cases | 16:20 |
| dtroyer | is it _always_ not valid JSON? | 16:20 |
| terrylhowe | I think so | 16:21 |
| terrylhowe | if it was valid, we wouldn’t care to parse it | 16:21 |
| dtroyer | I need to set this up to try it again. What I see is that the response at that point is either an error caught by the exception immediately prior, or the result you wanted in the first place in which case it should be valid json. What am I missing? | 16:23 |
| terrylhowe | hmm | 16:25 |
| terrylhowe | It may only be failing for tests where redirect is off | 16:26 |
| terrylhowe | dtroyer: do you want to kill redirect disable? | 16:26 |
| dtroyer | unsure, I need to re-absorb this code, I've slept since I last looked at it | 16:27 |
| *** etoews has joined #openstack-sdks | 16:29 | |
| dtroyer | I'm looking at jamielennox|away's requests_mock and was going to change test_transport.py to use it rather than httpretty so I'm headed there anyway | 16:29 |
| dtroyer | I thnk there is a connection to changing fake_response to be JSON rather than just a string…we really should be testing both | 16:30 |
| terrylhowe | The resource tests could probably just use a mock session instead of httpretty | 16:32 |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: The resource repr method should print id https://review.openstack.org/102578 | 16:32 |
| *** mattyw has quit IRC | 17:07 | |
| *** etoews_ has joined #openstack-sdks | 17:08 | |
| *** etoews has quit IRC | 17:11 | |
| *** jamiehannaford has joined #openstack-sdks | 17:20 | |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Add common method to find a resource https://review.openstack.org/102587 | 17:23 |
| openstackgerrit | A change was merged to openstack/python-openstackclient: Network CRUD https://review.openstack.org/73318 | 17:26 |
| *** etoews has joined #openstack-sdks | 17:30 | |
| *** etoews__ has joined #openstack-sdks | 17:31 | |
| *** etoews_ has quit IRC | 17:32 | |
| *** etoews has quit IRC | 17:35 | |
| *** etoews__ has quit IRC | 17:36 | |
| *** samchoi has quit IRC | 17:37 | |
| *** jamiehannaford has quit IRC | 17:41 | |
| *** jamiehannaford has joined #openstack-sdks | 17:41 | |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Example create command https://review.openstack.org/102590 | 17:45 |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Add example delete https://review.openstack.org/102591 | 17:54 |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Simple network resource https://review.openstack.org/102593 | 17:57 |
| *** terrylhowe has quit IRC | 18:18 | |
| *** terrylhowe has joined #openstack-sdks | 18:19 | |
| *** samchoi has joined #openstack-sdks | 18:29 | |
| *** stevemar has quit IRC | 18:52 | |
| *** stevemar has joined #openstack-sdks | 18:52 | |
| *** stevemar has quit IRC | 18:56 | |
| *** stevemar has joined #openstack-sdks | 18:56 | |
| openstackgerrit | Terry Howe proposed a change to openstack/python-openstackclient: Use region instead of region_name https://review.openstack.org/102606 | 18:58 |
| openstackgerrit | Dean Troyer proposed a change to stackforge/python-openstacksdk: Change transport JSON handling https://review.openstack.org/102607 | 19:03 |
| dtroyer | terrylhowe: ^^^^ is what I think we can do to properly handle unexpected not-JSON responses, plus a bunch of redirect tests for both cases | 19:03 |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** openstackgerrit has joined #openstack-sdks | 19:06 | |
| *** jamiehannaford has quit IRC | 19:06 | |
| *** jamiehannaford has joined #openstack-sdks | 19:09 | |
| *** etoews has joined #openstack-sdks | 19:15 | |
| terrylhowe | dtroyer: are you going to revive the old api discovery stuff? | 19:20 |
| dtroyer | my plan is to do so, but it's low o the priority list atm | 19:21 |
| terrylhowe | k | 19:21 |
| dtroyer | terrylhowe: re https://review.openstack.org/#/c/102607/, the two things I think we need to answer is what happens when a response is assumed to be JSON (via the accept=JSON default) but is not because it is either plain text or invalid in some other way. | 19:57 |
| dtroyer | I think the options are: a) resp.body not present; b) resp.body = None (or ""); c) resp.body = resp.text | 19:58 |
| *** jamiehannaford has quit IRC | 20:00 | |
| *** openstackgerrit has quit IRC | 20:05 | |
| *** openstackgerrit has joined #openstack-sdks | 20:06 | |
| *** etoews_ has joined #openstack-sdks | 20:27 | |
| *** etoews has quit IRC | 20:28 | |
| *** stevemar has quit IRC | 20:45 | |
| *** mfer has quit IRC | 21:09 | |
| *** etoews_ has quit IRC | 21:18 | |
| *** HenryG has quit IRC | 21:23 | |
| *** jamiehannaford has joined #openstack-sdks | 21:54 | |
| *** openstackgerrit has quit IRC | 22:35 | |
| *** openstackgerrit has joined #openstack-sdks | 22:36 | |
| *** etoews has joined #openstack-sdks | 22:43 | |
| *** jdag has quit IRC | 22:45 | |
| *** jdag has joined #openstack-sdks | 22:48 | |
| *** jamiehannaford has quit IRC | 23:02 | |
| *** jamiehannaford has joined #openstack-sdks | 23:23 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!