| *** openstack has joined #openstack-sdks | 00:20 | |
| *** bknudson has joined #openstack-sdks | 00:31 | |
| wchrisj | elight: Just pushed an update now that all specs are passing; any desire to doa last minute check before I merge this? | 00:43 |
|---|---|---|
| wchrisj | elight: there is no discovery stuff in here - commented it out to get this big cut merged ASAP. | 00:44 |
| *** wchrisj has quit IRC | 00:45 | |
| *** wchrisj has joined #openstack-sdks | 00:56 | |
| *** wchrisj has quit IRC | 01:31 | |
| *** wchrisj has joined #openstack-sdks | 01:39 | |
| *** wchrisj has quit IRC | 01:44 | |
| *** wchrisj has joined #openstack-sdks | 01:49 | |
| *** wchrisj_ has joined #openstack-sdks | 01:53 | |
| *** wchrisj has quit IRC | 01:53 | |
| *** wchrisj_ has quit IRC | 02:00 | |
| *** bknudson has quit IRC | 02:16 | |
| *** HenryG has joined #openstack-sdks | 02:29 | |
| *** wchrisj has joined #openstack-sdks | 03:02 | |
| *** wchrisj has quit IRC | 03:06 | |
| *** wchrisj has joined #openstack-sdks | 03:07 | |
| *** wchrisj has quit IRC | 03:14 | |
| *** wchrisj has joined #openstack-sdks | 03:15 | |
| *** wchrisj_ has joined #openstack-sdks | 03:19 | |
| *** wchrisj has quit IRC | 03:20 | |
| *** wchrisj has joined #openstack-sdks | 03:24 | |
| *** wchrisj_ has quit IRC | 03:25 | |
| *** wchrisj_ has joined #openstack-sdks | 03:28 | |
| *** wchrisj has quit IRC | 03:29 | |
| *** wchrisj has joined #openstack-sdks | 03:32 | |
| *** wchrisj_ has quit IRC | 03:32 | |
| *** wchrisj_ has joined #openstack-sdks | 03:39 | |
| *** wchrisj has quit IRC | 03:40 | |
| *** wchrisj has joined #openstack-sdks | 03:43 | |
| *** wchrisj_ has quit IRC | 03:43 | |
| *** wchrisj has quit IRC | 03:47 | |
| elight | wchrisj: sorry friend in from out of town. No time tonight. | 04:05 |
| *** krames has joined #openstack-sdks | 12:38 | |
| *** bknudson has joined #openstack-sdks | 13:09 | |
| *** wchrisj has joined #openstack-sdks | 13:20 | |
| *** ChanServ changes topic to "the gerrit event stream is currently hung, blocking all testing. troubleshooting is in progress (next update at 14:00 utc)" | 13:21 | |
| *** wchrisj has quit IRC | 13:26 | |
| *** ChanServ changes topic to "#openstack-sdks" | 13:30 | |
| *** wchrisj has joined #openstack-sdks | 13:35 | |
| wchrisj | krames: Good Morning! | 13:41 |
| krames | wchrisj morning!!! | 13:41 |
| wchrisj | Appreciate the code review. To be clear, this was more of a code reorg to get the versions of Identity in place; not much refactoring took place, by intent. | 13:42 |
| wchrisj | All good comments | 13:43 |
| wchrisj | I'd rather not change any more code in this PR if that's OK | 13:44 |
| wchrisj | krames: ^^ | 13:45 |
| krames | sure | 13:45 |
| krames | going back through it...a lot of it seems like its old code that needs to be refactored right? | 13:46 |
| wchrisj | exactly, but given the changes to implement diff versions of Identity, Evan and I agreed that we would just rearrange the code in this PR and do the refactor in the next one | 13:47 |
| wchrisj | krames: ^^ | 13:47 |
| wchrisj | krames: this code reorg touched almost evey file in Identity, so it would make for yet another huge PR if we went ahead with it all in this PR | 13:48 |
| *** wchrisj has quit IRC | 13:57 | |
| *** wchrisj_ has joined #openstack-sdks | 13:59 | |
| *** mfer has joined #openstack-sdks | 14:46 | |
| *** mhagedorn has joined #openstack-sdks | 14:47 | |
| *** wchrisj_ has quit IRC | 15:15 | |
| *** wchrisj has joined #openstack-sdks | 15:35 | |
| *** wchrisj has quit IRC | 15:35 | |
| *** wchrisj has joined #openstack-sdks | 15:36 | |
| briancurtin | dtroyer: in api_discovery.py, i have a change suggestion to the ApiVersion.__repr__ that would be a rewriting of it. can i submit a patchset of my own, or would you rather a comment? | 15:53 |
| briancurtin | basically using getattr with a default, versus hasattr and duplicating the params for each case. part of the reason i ask is because i've never contributed a patch set to someone else's review | 15:55 |
| *** rgbkrk has joined #openstack-sdks | 16:01 | |
| dtroyer | briancurtin: it's fine to push up a patch. | 16:10 |
| mfer | ycombinator did you get a chance to start the md -> rst change on the php sdk? | 16:10 |
| ycombinator | mfer: not yet, but its on my list; traveling this week | 18:12 |
| ycombinator | mfer: I'll try to do one tonight | 18:13 |
| mfer | no rush. i just wanted to see if I could be helpful | 18:13 |
| *** samchoi has joined #openstack-sdks | 18:36 | |
| briancurtin | FYI, python-openstacksdk meeting in 5 min in #openstack-meeting-3 | 18:55 |
| elight | wchrisj: I’m back. I’ve got a few hours before I head off to ARUG | 19:03 |
| elight | wchrisj: Lemme merge the minitest PR then look at identity.rb | 19:04 |
| wchrisj | no need - already done - if we are talking the same thing elight: | 19:04 |
| elight | o rly | 19:04 |
| elight | wchrisj: I guess you needed that sooner than expected? | 19:07 |
| elight | wchrisj: Wait, no. https://github.com/fog/fog-core/blob/master/lib/fog/identity.rb still needs to change, yes? | 19:08 |
| wchrisj | ahh - sorry - you are correct elight: | 19:10 |
| wchrisj | brain fart | 19:10 |
| *** krames has quit IRC | 19:54 | |
| *** krames has joined #openstack-sdks | 19:55 | |
| jamielennox | dtroyer: no i don't like subclasses overriding private methods - it's more a question of support though | 20:02 |
| jamielennox | probably doesn't matter for now | 20:02 |
| dtroyer | there are certainly some methods that should/could be private | 20:05 |
| jamielennox | dtroyer: i've just gotten paranoid about everything being public lately | 20:08 |
| jamielennox | i'm defaulting to having a real use for a function before making it public | 20:08 |
| dtroyer | good point…it's always easier to unmask something... | 20:09 |
| briancurtin | +1 jamie | 20:13 |
| edleafe | jamielennox: Every public method becomes a contract with the SDK user. I default to starting methods with '_' unless I intend on having devs use them. | 20:17 |
| jamielennox | edleafe: ++ but variables as well | 20:18 |
| jamielennox | my classes start to look like a sea of underscores now | 20:18 |
| edleafe | implementation details | 20:18 |
| edleafe | ;-) | 20:18 |
| elight | wchrisj mhagedorn: If there’s a God, I hope he forgives me for what I am about to do. You’ll see in the PR. And I want a Fog 2.0 now a bit more. | 20:19 |
| mhagedorn | :) | 20:20 |
| wchrisj | elight: when will we get to see this ungodly mess? ;-) | 20:29 |
| elight | Writing specs now. Hang on…. | 20:29 |
| wchrisj | lol | 20:29 |
| elight | Have to account for how we (Rackspace) namespace Identity wrongly without mentioning us so…. | 20:30 |
| elight | We’ll want to fix this in Fog 2.0 too | 20:30 |
| elight | All providers will namespace things the same way or else. | 20:30 |
| jamielennox | dtroyer: did you see that nova came up with a new URL discovery format? | 20:31 |
| jamielennox | http://docs.openstack.org/api/openstack-compute/2/content/Versions-d1e1193.html | 20:33 |
| dtroyer | no I didn't | 20:36 |
| jamielennox | joy :) | 20:37 |
| dtroyer | thats unser a compute/2/content URL, are they making it retro-active to v2? ugh, given they were considering making v3 into v2.1 I wouldnt be too surprised | 20:38 |
| wchrisj | elight: I saw that namespacing for Rackspace Identity and wondered... | 20:39 |
| elight | I don’t even…. | 20:39 |
| elight | Yeah | 20:39 |
| elight | see above re: namespacing or else. ;-) | 20:39 |
| elight | going forward | 20:40 |
| wchrisj | Evan the code Nazi... | 20:40 |
| elight | I prefer “lord of order” ;-) | 20:40 |
| wchrisj | definitely much more PC fer sure... elight: | 20:41 |
| wchrisj | ... "your Lordship"... <bowing> | 20:41 |
| elight | lol | 20:42 |
| jamielennox | dtroyer: i'm not sure, i read the first part realized it was different and closed it in frustration | 20:48 |
| jamielennox | dtroyer: they do have the mime-type so you can get the old mode - but serious WTF | 20:48 |
| dtroyer | I need to look closer later, but that may not be new… | 20:50 |
| dtroyer | A couple of summits ago (Portland maybe?) there was a version discovery session and someone did write up some stuff | 20:50 |
| jamielennox | really? i looked prior to writing that wiki page but couldn't find anything | 20:52 |
| dtroyer | it was in an etherpad, the great un-indexed repository of design summit knowledge | 20:53 |
| elight | wchrisj: The new spec before refactor. https://github.com/fog/fog-core/commit/21d68b81d45ee9bf2c7f84132a3e5d680dfc65d9 | 21:02 |
| wchrisj | elight: I'd like to discuss with you, maybe in the morning. New stuff to me in that spec... | 21:07 |
| wchrisj | looks good as far as I can tell - would like to understnd better what's going on | 21:07 |
| elight | wchrisj: FYI spec only specs existing Identity behavior. But, yes, the test set up is “exciting”. :-/ | 21:08 |
| wchrisj | elight: THAT's what I want to discuss | 21:08 |
| wchrisj | interesting take on things | 21:08 |
| elight | wchrisj: The spec setup? Understandable | 21:08 |
| wchrisj | yes | 21:09 |
| elight | wchrisj: I’m not thrilled with it. But I also don’t see too many good choices. Anyway, you’re busy now, yes? And I need to log shortly anyway | 21:09 |
| elight | wchrisj: Tomorrow morning works | 21:09 |
| wchrisj | elight: works for me | 21:09 |
| elight | wchrisj: Feel free to tell me I’m insane in the soon to be posted PR | 21:11 |
| wchrisj | lol will do elight: | 21:11 |
| elight | wchrisj: https://github.com/fog/fog-core/pull/30 | 21:13 |
| wchrisj | elight: just added a few nits on spec vs test syntax... | 21:17 |
| elight | saw and replied | 21:17 |
| elight | TL;DR: I favor xUnit assertions | 21:17 |
| elight | with spec nesting | 21:17 |
| elight | Dislike matchers. | 21:17 |
| elight | Now that’s me. | 21:17 |
| elight | If the cabal decides we use matchers, I’ll suck it up. | 21:18 |
| elight | Though the rest of fog-core uses assertions because I ported it. ;-) ;-) | 21:18 |
| krames | if we are voting on it...I like matchers | 21:18 |
| krames | I think they read better than asserts | 21:19 |
| elight | krames: FWIW, it’s bigger than the 3 of us. It’s all of fog eventually. | 21:20 |
| mhagedorn | elight… composition effort on identity is turning in to a lot of sadness and pain | 21:20 |
| elight | krames wchrisj: But, for now, it’s internally consistent in fog-core | 21:20 |
| elight | mhagedorn: Sounds like we’ll pair on it tomorrow then. | 21:20 |
| elight | mhagedorn: Maybe I can help? | 21:20 |
| elight | Gotta run shortly. ARUG. | 21:20 |
| mhagedorn | yeah as my former boss used to say.. its pretty much a shit show | 21:20 |
| wchrisj | elight: krames: I prefer matchers to asserts, but dont see why we have to pick one over the other, TBH. For certain things, I'm a pragmatist. | 21:22 |
| elight | wchrisj: *shrug* It’s minitest. They can coexist in the same test. | 21:23 |
| elight | wchrisj: But I’m opening it up to the fog summit cabal for comment. | 21:23 |
| wchrisj | elight: krames: as long as there is good test coverage, I'm good. | 21:23 |
| wchrisj | elight: krames: that should be the litmus test, no pun intended... | 21:24 |
| elight | wchrisj: Personally, I’d prefer consistency. And I’ll be fine if the consensus evolves to “use matchers”. But let’s see if we can get the Summit people to arrive at a consensus on something pre-Summit. ;-) ;-) | 21:24 |
| wchrisj | ok | 21:25 |
| elight | wchrisj: Besides, good exercise leading up to mid-May. :D | 21:25 |
| wchrisj | elight: given Paul's predeliction toward minitest, I suspect he's going to side with you on assertions | 21:26 |
| wchrisj | elight: how do we handle the version issue in your PR? You sidestep it altogether... | 21:29 |
| elight | wchrisj: *shrug* He’s just one guy. There are many of us. | 21:29 |
| elight | Must go now | 21:29 |
| wchrisj | elight: (it appears) | 21:29 |
| wchrisj | ok | 21:29 |
| *** sharwell___ has joined #openstack-sdks | 21:38 | |
| *** Alex_Gaynor has quit IRC | 21:39 | |
| *** sharwell__ has quit IRC | 21:39 | |
| *** Alex_Gaynor has joined #openstack-sdks | 21:40 | |
| *** dolphm has quit IRC | 21:47 | |
| *** mfer has quit IRC | 21:50 | |
| *** dolphm has joined #openstack-sdks | 21:50 | |
| *** bknudson has quit IRC | 22:03 | |
| *** rgbkrk has quit IRC | 22:30 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!