| *** bknudson has quit IRC | 01:38 | |
| *** jamielennox is now known as jamielennox|away | 07:50 | |
| *** jdag___ has quit IRC | 08:21 | |
| *** openstack has quit IRC | 08:21 | |
| *** openstack has joined #openstack-sdks | 08:30 | |
| *** openstackstatus has joined #openstack-sdks | 08:30 | |
| *** jamieh has joined #openstack-sdks | 08:44 | |
| *** jamieh is now known as Guest89169 | 08:44 | |
| *** sharwell_ has quit IRC | 11:10 | |
| *** sharwell_ has joined #openstack-sdks | 11:37 | |
| *** krames has joined #openstack-sdks | 13:10 | |
| *** mfer has joined #openstack-sdks | 13:19 | |
| *** wchrisj has joined #openstack-sdks | 13:34 | |
| *** wchrisj has quit IRC | 13:39 | |
| *** jnoller has joined #openstack-sdks | 13:50 | |
| *** bknudson has joined #openstack-sdks | 13:58 | |
| *** wchrisj has joined #openstack-sdks | 14:01 | |
| *** terrylhowe has joined #openstack-sdks | 14:01 | |
| *** elight has quit IRC | 14:15 | |
| *** elight has joined #openstack-sdks | 14:15 | |
| *** ycombinator has joined #openstack-sdks | 14:55 | |
| *** rgbkrk has joined #openstack-sdks | 15:13 | |
| *** annegentle has joined #openstack-sdks | 15:46 | |
| *** mhagedorn has joined #openstack-sdks | 15:51 | |
| wchrisj | elight: krames: Check this out: http://git.openstack.org/cgit/openstack/api-site/plain/www/index.html | 16:02 |
|---|---|---|
| krames | wchrisj nice!!! | 16:02 |
| wchrisj | that page is still in development, but fog is getting the nod as the "official" ruby sdk effort of OpenStack | 16:02 |
| wchrisj | So I need to rework/rename the page I added last week; unfortunately it gives the impression that OpenStack has a dedicate ruby effort, which isnt really true. It's a different sort of project. | 16:04 |
| *** jnoller has quit IRC | 16:18 | |
| wchrisj | Elight: krames: I'd like to take a few minutes during our midweek meeting to discuss what needs to go on the wiki page and the wording, so everyone has a hand in it. | 16:26 |
| wchrisj | mhagedorn: ^^ | 16:26 |
| *** jdag___ is now known as jdag | 16:48 | |
| *** samchoi has joined #openstack-sdks | 17:00 | |
| wchrisj | elight: krames: how close do you think we are to merging this PR? | 17:02 |
| *** rgbkrk_ has joined #openstack-sdks | 17:07 | |
| *** rgbkrk has quit IRC | 17:08 | |
| *** Guest89169 has quit IRC | 17:22 | |
| *** jamieh has joined #openstack-sdks | 17:22 | |
| *** jamieh is now known as Guest45863 | 17:23 | |
| wchrisj | elight: krames: Not rushing you guys - just anxious to get this next PR completed so we can rock and roll on Compute and Storage! | 17:27 |
| wchrisj | krames: elight: back in a bit - errand | 17:27 |
| *** annegentle has quit IRC | 17:31 | |
| *** glenc has quit IRC | 17:32 | |
| *** annegentle has joined #openstack-sdks | 17:32 | |
| *** glenc has joined #openstack-sdks | 17:32 | |
| *** ycombinator has quit IRC | 17:33 | |
| *** shaunak has joined #openstack-sdks | 17:33 | |
| elight | wchrisj: will review further once my trainer is done kicking my ass. | 17:38 |
| *** rgbkrk has joined #openstack-sdks | 17:58 | |
| *** rgbkrk_ has quit IRC | 17:58 | |
| wchrisj | elight: lol - have fun! | 18:22 |
| elight | wchrisj: inhaling lunch. Will finish review soon! | 18:23 |
| wchrisj | elight: as one who recently lost 35 lbs, it's definitely worth it! | 18:23 |
| wchrisj | good for you | 18:24 |
| elight | +1. Almost 40 pounds down now. | 18:24 |
| wchrisj | elight: SWEET! Now that's an accomplishment... | 18:25 |
| elight | wchrisj: thanks. Long way to go yet though! But progress is heartening | 18:25 |
| *** Guest45863 has quit IRC | 18:28 | |
| wchrisj | elight: krames: Do you guys run code metrics on your projects/code on a regular basis? | 18:58 |
| elight | No. Just CI on fog for now. And we should. | 18:59 |
| wchrisj | elight: I just ran metric_fu - really interesting; btw - I haven't been doing this consistently either, but think we should | 19:00 |
| krames | wchrisj have you seen this? https://codeclimate.com/github/fog/fog | 19:01 |
| elight | But we ought to get our other projects under CodeClimate. Though Fog is the largest. | 19:02 |
| elight | And the messiest by far | 19:02 |
| elight | 2.89 sounds about right…. | 19:02 |
| wchrisj | krames: I have heard of it, but not seen much | 19:04 |
| *** jnoller has joined #openstack-sdks | 19:07 | |
| wchrisj | elight: in tenants and users, we return self in cases of create and update; do you think both should return true instead of self? e may need to refactor a bit if create/update differ in the response... | 19:28 |
| wchrisj | *we* | 19:28 |
| elight | wchrisj: I *believe* so | 19:29 |
| wchrisj | ok - I'll change across the board for now | 19:29 |
| wchrisj | elight: http://apidock.com/rails/ActiveRecord/Base/create/class/ AR returns the created object on success | 19:34 |
| wchrisj | for reference... | 19:34 |
| elight | wchrisj: That method behaves very differently than the #create method in the Fog models | 19:35 |
| elight | wchrisj: ActiveRecord #create takes hash args, news an object, then saves it | 19:35 |
| elight | wchrisj: In this case, #create is being called on an instance of an object. It’s already been new’d. | 19:36 |
| elight | wchrisj: So “create” isn’t analogous. The create in Fog is more like ‘save a new record’ | 19:36 |
| wchrisj | elight: ahh, I see the distinction. This deserves some discussion later | 19:36 |
| elight | It’s not really “create”. Or not analogous to Rails. | 19:37 |
| wchrisj | our current approach leaves a bit to be desired... ;-) | 19:37 |
| elight | Heh. Yes. | 19:37 |
| wchrisj | ok for now | 19:37 |
| wchrisj | However, we are going to do a LOT of refactoring, and I'd like to nail down and document the approach we agree on. This could be much cleaner. | 19:38 |
| elight | +1 | 19:39 |
| elight | wchrisj: Use the TNG repos wiki to track this? | 19:39 |
| elight | wchrisj: Or, wait, the TNG repos issues | 19:39 |
| wchrisj | yeah | 19:39 |
| elight | Cool | 19:39 |
| wchrisj | I'll open a ticket | 19:39 |
| wchrisj | elight: On my part, I need to grok what we get automatically from the base collection and model classes, even if they might change later. | 19:41 |
| wchrisj | elight: krames: do either of you have a hard opinion on leaving/ripping out the find methods within the collections in the immediate term? I renamed them to "get_" but will kill them if you prefer... | 20:27 |
| elight | Leaning toward kill | 20:28 |
| krames | kill | 20:28 |
| wchrisj | ok, we can revisit once we settle on the overall aproach | 20:28 |
| wchrisj | works for me | 20:28 |
| krames | sounds good | 20:28 |
| wchrisj | elight: krames: so do we wantto kill the "get" methods too? any fiind-ish type of method? | 20:30 |
| wchrisj | kill that too? | 20:30 |
| wchrisj | the get actually populates from the service | 20:30 |
| wchrisj | killed | 20:32 |
| wchrisj | all of the related methods-> find_*, get_*, etc. | 20:32 |
| *** jnoller has quit IRC | 20:34 | |
| *** mfer has quit IRC | 20:59 | |
| *** krames has quit IRC | 21:35 | |
| *** jamielennox|away is now known as jamielennox | 22:03 | |
| *** wchrisj has quit IRC | 22:05 | |
| *** terrylhowe has left #openstack-sdks | 22:50 | |
| *** terrylhowe has joined #openstack-sdks | 22:51 | |
| *** dhellmann has quit IRC | 23:18 | |
| *** dhellmann has joined #openstack-sdks | 23:23 | |
| *** HenryG has quit IRC | 23:25 | |
| *** bknudson has quit IRC | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!