| *** shuyingya has joined #openstack-sahara | 00:40 | |
| *** shuyingya has quit IRC | 00:43 | |
| *** shuyingya has joined #openstack-sahara | 00:43 | |
| *** zemuvier_ has joined #openstack-sahara | 00:47 | |
| *** zemuvier_ has quit IRC | 00:49 | |
| *** shuyingya has quit IRC | 00:49 | |
| *** zemuvier1 has joined #openstack-sahara | 00:49 | |
| *** zemuvier has quit IRC | 00:50 | |
| *** masber has quit IRC | 01:01 | |
| *** masber has joined #openstack-sahara | 01:02 | |
| *** shuyingya has joined #openstack-sahara | 01:14 | |
| openstackgerrit | Iwona Kotlarska proposed openstack/python-saharaclient master: Add import of Cluster Templates https://review.openstack.org/498574 | 01:25 |
|---|---|---|
| *** caowei has joined #openstack-sahara | 01:34 | |
| shuyingya | tellesnobrega, around? | 02:05 |
| *** zemuvier1 has quit IRC | 02:15 | |
| *** zemuvier1 has joined #openstack-sahara | 02:15 | |
| *** dave-mccowan has quit IRC | 02:32 | |
| *** zemuvier has joined #openstack-sahara | 02:51 | |
| *** zemuvier1 has quit IRC | 02:51 | |
| *** masber has quit IRC | 02:53 | |
| *** esikachev has joined #openstack-sahara | 03:43 | |
| *** esikachev has quit IRC | 03:48 | |
| *** links has joined #openstack-sahara | 04:03 | |
| *** masber has joined #openstack-sahara | 04:08 | |
| *** hoonetorg has quit IRC | 04:11 | |
| *** hoonetorg has joined #openstack-sahara | 04:23 | |
| *** caowei has quit IRC | 05:23 | |
| *** pgadiya has joined #openstack-sahara | 05:36 | |
| *** caowei has joined #openstack-sahara | 05:57 | |
| *** pgadiya has quit IRC | 06:18 | |
| *** pgadiya has joined #openstack-sahara | 06:34 | |
| *** pcaruana has joined #openstack-sahara | 06:39 | |
| *** raissa has quit IRC | 06:46 | |
| *** pgadiya has quit IRC | 06:54 | |
| *** pgadiya has joined #openstack-sahara | 07:06 | |
| *** rcernin has joined #openstack-sahara | 07:10 | |
| *** tesseract has joined #openstack-sahara | 07:25 | |
| *** anshul has joined #openstack-sahara | 07:29 | |
| *** esikachev has joined #openstack-sahara | 08:01 | |
| *** esikachev has quit IRC | 08:12 | |
| *** esikachev has joined #openstack-sahara | 08:16 | |
| *** raissa has joined #openstack-sahara | 08:20 | |
| *** tosky has joined #openstack-sahara | 08:55 | |
| *** esikachev has quit IRC | 09:20 | |
| *** esikachev has joined #openstack-sahara | 09:22 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara stable/pike: Replace http with https for doc links in sahara https://review.openstack.org/498732 | 09:42 |
| *** esikachev has quit IRC | 10:52 | |
| *** esikachev has joined #openstack-sahara | 11:12 | |
| *** esikachev has quit IRC | 11:16 | |
| *** caowei has quit IRC | 11:27 | |
| *** esikachev has joined #openstack-sahara | 11:30 | |
| *** pgadiya has quit IRC | 11:39 | |
| *** tellesnobrega has quit IRC | 11:46 | |
| *** esikachev has quit IRC | 12:03 | |
| *** dave-mccowan has joined #openstack-sahara | 12:06 | |
| *** esikachev has joined #openstack-sahara | 12:14 | |
| *** shuyingya has quit IRC | 12:15 | |
| *** shuyingya has joined #openstack-sahara | 12:15 | |
| *** esikachev has quit IRC | 12:18 | |
| *** iwonka has quit IRC | 12:20 | |
| *** iwonka has joined #openstack-sahara | 12:21 | |
| *** shuyingya has quit IRC | 12:25 | |
| *** shuyingya has joined #openstack-sahara | 12:26 | |
| *** esikachev has joined #openstack-sahara | 12:30 | |
| *** shuyingya has quit IRC | 12:30 | |
| *** shuyingya has joined #openstack-sahara | 12:31 | |
| *** shuyingya has quit IRC | 12:33 | |
| *** shuyingya has joined #openstack-sahara | 12:33 | |
| *** esikachev has quit IRC | 12:34 | |
| *** shuyingya has quit IRC | 12:38 | |
| *** lucasxu has joined #openstack-sahara | 12:42 | |
| mnaser | is anyone here familiar with the sahara db structure | 12:44 |
| mnaser | and is there a reason why the cluster_verifications in a separate table? | 12:44 |
| tosky | uhm, I think that the original architects are not around | 12:48 |
| tosky | even if verifications may have been added later | 12:48 |
| mnaser | because literally | 12:51 |
| mnaser | all it holds is | 12:51 |
| mnaser | id/cluster_id/status | 12:51 |
| mnaser | and its just the status of the cluster | 12:51 |
| mnaser | so we're really adding 4 more fields for no reason | 12:51 |
| tosky | uh | 12:55 |
| *** shuyingya has joined #openstack-sahara | 12:55 | |
| mnaser | and the cluster_health_check_add function in the db api is a lie | 12:56 |
| mnaser | :p | 12:56 |
| mnaser | ok ill see if we can get the cluster verification part of the table in a migration | 12:57 |
| mnaser | sigh but if we do that then we cant backport it | 12:57 |
| *** shuyingya has quit IRC | 13:00 | |
| *** shuyingya has joined #openstack-sahara | 13:00 | |
| *** tellesnobrega has joined #openstack-sahara | 13:01 | |
| tosky | right, better focus on changes that can be backported without destroying too much | 13:02 |
| tosky | or the stable policy will beat us | 13:02 |
| mnaser | yeah i dont want that to happen cause i need this to be backportable. anyways, just a small arch. question if anyone knows | 13:03 |
| mnaser | if i make changes in the db layer but the conductor still delivers the same object structure | 13:03 |
| mnaser | will that keep everything ok? does all db interaction go through the conductor layer? | 13:03 |
| mnaser | (please let the answer be yes, hah) | 13:03 |
| *** esikachev has joined #openstack-sahara | 13:05 | |
| tosky | but we need to plan a migration | 13:07 |
| tosky | not sure that we can do this in a minor version | 13:07 |
| tosky | maybe yes, but not sure | 13:07 |
| *** esikachev has quit IRC | 13:07 | |
| *** esikache1 has joined #openstack-sahara | 13:08 | |
| *** hoonetorg has quit IRC | 13:08 | |
| *** hoonetorg has joined #openstack-sahara | 13:09 | |
| *** esikache1 has quit IRC | 13:12 | |
| openstackgerrit | Merged openstack/sahara master: Replace http with https for doc links in sahara https://review.openstack.org/498329 | 13:13 |
| *** zemuvier has quit IRC | 13:15 | |
| *** links has quit IRC | 13:18 | |
| *** dave-mccowan has quit IRC | 13:19 | |
| mnaser | ok so | 13:24 |
| mnaser | instead of us having the session stored per session for example | 13:24 |
| mnaser | as nova does it (context.session) | 13:25 |
| mnaser | we're instead generating a session per each DB call with get_session() | 13:25 |
| mnaser | im pretty sure that's the reason i cant drop the joins and make them lazy loading | 13:25 |
| tellesnobrega | mnaser, hmm that makes sense | 13:31 |
| mnaser | im gonna try switching to this | 13:31 |
| mnaser | https://review.openstack.org/#/c/221310/ | 13:32 |
| mnaser | how nova switched to it fyi | 13:32 |
| mnaser | https://review.openstack.org/#/c/225065/23/nova/db/sqlalchemy/api.py | 13:33 |
| mnaser | looks straight forward | 13:33 |
| *** shuyingya has quit IRC | 13:34 | |
| *** shuyingya has joined #openstack-sahara | 13:34 | |
| tosky | the commit message in the nova change is really... helpful | 13:35 |
| *** shuyingya has quit IRC | 13:38 | |
| openstackgerrit | Merged openstack/puppet-sahara stable/pike: Update UPPER_CONSTRAINTS_FILE for stable/pike https://review.openstack.org/497372 | 13:40 |
| *** dave-mccowan has joined #openstack-sahara | 13:41 | |
| *** shuyingya has joined #openstack-sahara | 13:43 | |
| *** anshulbehl has joined #openstack-sahara | 13:45 | |
| *** anshul has quit IRC | 13:46 | |
| *** shuyingy_ has joined #openstack-sahara | 13:47 | |
| *** shuyingya has quit IRC | 13:47 | |
| *** esikache1 has joined #openstack-sahara | 13:49 | |
| *** jeremyfreudberg has joined #openstack-sahara | 13:51 | |
| mnaser | yay.. # of failing tests slowly decreasing with this change | 14:22 |
| mnaser | we're going to be using a singular session per request | 14:22 |
| mnaser | rather than many sessions all over the place | 14:22 |
| mnaser | so many session flush's which shouldn't be there | 14:24 |
| iwonka | ping tellesnobrega | 14:25 |
| *** tellesnobrega has quit IRC | 14:26 | |
| *** anshulbehl has quit IRC | 14:26 | |
| *** tellesnobrega has joined #openstack-sahara | 14:27 | |
| jeremyfreudberg | (tellesnobrega, i think iwonka pinged you when your internet didn't work) | 14:30 |
| tellesnobrega | jeremyfreudberg, thanks | 14:31 |
| tellesnobrega | hi iwonka | 14:31 |
| iwonka | yes | 14:33 |
| iwonka | i pinged you because | 14:34 |
| iwonka | i'm tring to add the thing to gui | 14:34 |
| iwonka | and it needs default_image_id | 14:34 |
| iwonka | and in code for create there is | 14:34 |
| iwonka | # TODO(nkonovalov): Fix client to support default_image_id | 14:34 |
| iwonka | so apparently it's not supported | 14:34 |
| iwonka | can i do the same thing? just skip it in gui and set to None? | 14:35 |
| iwonka | tellesnobrega ^ | 14:35 |
| tellesnobrega | iwonka, I have to check before giving a definitive answer and I can't right (on a meeting) | 14:36 |
| tellesnobrega | but seems like you could do it for now and we can fix it later | 14:36 |
| iwonka | sure, please let me know once you check it | 14:36 |
| *** chlong has joined #openstack-sahara | 14:41 | |
| tellesnobrega | will do | 14:55 |
| *** shuyingy_ has quit IRC | 15:01 | |
| *** iwonka has quit IRC | 15:25 | |
| *** iwonka has joined #openstack-sahara | 15:25 | |
| *** shuyingya has joined #openstack-sahara | 15:27 | |
| *** shuyingy_ has joined #openstack-sahara | 15:28 | |
| *** tellesnobrega has quit IRC | 15:28 | |
| *** shuyingya has quit IRC | 15:31 | |
| *** shuyingy_ has quit IRC | 15:46 | |
| *** esikache1 has quit IRC | 15:47 | |
| *** jeremyfreudberg has quit IRC | 15:49 | |
| *** ssmith has joined #openstack-sahara | 16:03 | |
| *** tesseract has quit IRC | 16:15 | |
| *** esikache1 has joined #openstack-sahara | 16:22 | |
| *** jeremyfreudberg has joined #openstack-sahara | 16:22 | |
| *** esikache1 has quit IRC | 16:26 | |
| *** rcernin has quit IRC | 16:46 | |
| *** pcaruana has quit IRC | 16:48 | |
| *** dave-mccowan has quit IRC | 16:50 | |
| *** links has joined #openstack-sahara | 16:55 | |
| *** abalutoiu has joined #openstack-sahara | 16:56 | |
| *** jeremyfreudberg has quit IRC | 17:01 | |
| *** esikache1 has joined #openstack-sahara | 17:05 | |
| *** raissa has quit IRC | 17:10 | |
| *** jeremyfreudberg has joined #openstack-sahara | 17:12 | |
| *** links has quit IRC | 17:34 | |
| openstackgerrit | Iwona Kotlarska proposed openstack/sahara-dashboard master: Add export of cluster templates to UI https://review.openstack.org/498612 | 18:01 |
| *** lucasxu has quit IRC | 18:01 | |
| *** tellesnobrega has joined #openstack-sahara | 18:07 | |
| *** esikache1 has quit IRC | 18:34 | |
| *** cpusmith has joined #openstack-sahara | 19:01 | |
| openstackgerrit | Merged openstack/sahara stable/pike: Replace http with https for doc links in sahara https://review.openstack.org/498732 | 19:04 |
| *** ssmith has quit IRC | 19:04 | |
| *** cpusmith_ has joined #openstack-sahara | 19:04 | |
| *** cpusmith has quit IRC | 19:08 | |
| *** abalutoiu_ has joined #openstack-sahara | 19:30 | |
| *** abalutoiu has quit IRC | 19:34 | |
| *** abalutoiu_ has quit IRC | 19:34 | |
| *** dave-mccowan has joined #openstack-sahara | 19:35 | |
| *** abalutoiu has joined #openstack-sahara | 19:35 | |
| *** abalutoiu_ has joined #openstack-sahara | 19:41 | |
| tellesnobrega | iwonka, about the default_image_id | 19:44 |
| tellesnobrega | you can just set to None | 19:44 |
| tellesnobrega | after we can fix saharaclient and update that | 19:45 |
| *** abalutoiu has quit IRC | 19:46 | |
| tellesnobrega | jeremyfreudberg, do you agree with that? | 19:47 |
| tellesnobrega | tosky, as well | 19:47 |
| tosky | tellesnobrega: out of context, which review? | 19:48 |
| jeremyfreudberg | tellesnobrega, i do agree with it, mostly because to me it's not even clear what that parameter does -- the docs and git-blame are very vague. and because it's not present in CLI or UI i've never used it either | 19:48 |
| jeremyfreudberg | tosky, default_image_id on cluster template | 19:49 |
| tellesnobrega | tosky, sorry | 19:50 |
| tellesnobrega | iwonka, found that default_image_id is not set on the client, she asked if she could set it to none while importing cluster-templates due to this issue | 19:51 |
| tosky | oh, right | 19:52 |
| tosky | well, yes, if it's needed and it's not there, it needs a value | 19:52 |
| jeremyfreudberg | tosky/ tellesnobrega do either of you actually know what it does | 19:52 |
| jeremyfreudberg | ? | 19:52 |
| tellesnobrega | not really | 19:52 |
| jeremyfreudberg | confusingly we actually reuse the name for default template generation, but i think the use case here (manual cluster template creation) is different | 19:53 |
| tellesnobrega | other option would be find out why this is needed and maybe fix it or completely remove it if we don't need it anymore | 19:53 |
| *** abalutoiu__ has joined #openstack-sahara | 19:53 | |
| jeremyfreudberg | exactly, i would like to find out if we still need it before patching dashboard to support it | 19:54 |
| tosky | if it's a parameter passed in public API, remove only in v2 | 19:54 |
| tosky | :D | 19:54 |
| tellesnobrega | true | 19:54 |
| tellesnobrega | v1.1 is "untouchable" | 19:54 |
| jeremyfreudberg | i'd be willing to bet based on the lack of doc about it, there is no users using it. of course tosky is right, we have to "play safe" and remove only for v2 | 19:54 |
| tellesnobrega | makes total sense | 19:55 |
| iwonka | sooooo | 19:55 |
| iwonka | I can just leave it be? | 19:55 |
| iwonka | and set to None? | 19:56 |
| *** abalutoiu_ has quit IRC | 19:57 | |
| jeremyfreudberg | iwonka, i would say just when you call this function https://github.com/openstack/sahara-dashboard/blob/b05932f4fbb15a4be0569c4cd741111b18986a10/sahara_dashboard/api/sahara.py#L260 just do not pass in the kwarg for default_image_id | 20:01 |
| iwonka | jeremyfreudberg: that is the function i'm caling now :) | 20:02 |
| jeremyfreudberg | iwonka, great, so if i can get confirmation from tellesnobrega do as i suggested | 20:02 |
| tellesnobrega | iwonka, go ahead as jeremyfreudberg suggested | 20:03 |
| iwonka | ok, thanks | 20:03 |
| mnaser | well | 20:13 |
| mnaser | i was able to play round with a few things | 20:13 |
| mnaser | and | 20:13 |
| * mnaser 167105 function calls (162509 primitive calls) in 0.381 seconds | 20:13 | |
| tosky | wow | 20:15 |
| jeremyfreudberg | mnaser, nice, this is cut down from the several seconds on cluster get, right? | 20:15 |
| mnaser | yeah | 20:15 |
| mnaser | and it was like | 20:15 |
| mnaser | let me show | 20:15 |
| openstackgerrit | Mohammed Naser proposed openstack/sahara master: Optimize model relationships (avoid joins, prefer subquery) https://review.openstack.org/498611 | 20:17 |
| mnaser | jeremyfreudberg tosky ^ | 20:17 |
| mnaser | this will simply do subqueries instead of large joins | 20:18 |
| mnaser | which are obviously far more efficent | 20:18 |
| mnaser | by subquery it means that it will issue 2 queries rather than 1 | 20:18 |
| mnaser | which in our case, the deduplication of data is much more efficent than the latency of an extra query imho | 20:19 |
| mnaser | 2017-08-29 20:21:48.640 24480 INFO eventlet.wsgi.server [-] 192.168.0.252,192.168.0.251 "GET /v1.1/8ffa97d00b9a4f55a5f4f40a5a05b600/clusters/4961ff69-a2f9-40a3-b44c-ff208ce5ca51?show_progress=False HTTP/1.1" status: 200 len: 13814 time: 7.7812359 | 20:24 |
| mnaser | 2017-08-29 20:23:49.159 24558 INFO eventlet.wsgi.server [-] 192.168.0.253,192.168.0.251 "GET /v1.1/8ffa97d00b9a4f55a5f4f40a5a05b600/clusters/4961ff69-a2f9-40a3-b44c-ff208ce5ca51?show_progress=False HTTP/1.1" status: 200 len: 13814 time: 0.1510959 | 20:24 |
| mnaser | guess which one is before and which one is after | 20:24 |
| jeremyfreudberg | wow | 20:24 |
| tosky | I wonder if the some of the relationship could be still joined, but inner joins, not the default left outer joins | 20:31 |
| tosky | but I can't investigate it, so I guess that the speedup is good enough :) | 20:31 |
| *** cpusmith_ has quit IRC | 20:43 | |
| *** jeremyfreudberg has quit IRC | 20:52 | |
| *** abalutoiu__ has quit IRC | 20:54 | |
| openstackgerrit | Mohammed Naser proposed openstack/sahara-image-elements master: Enable the ability to cache packages https://review.openstack.org/498087 | 21:03 |
| openstackgerrit | Mohammed Naser proposed openstack/sahara master: Optimize model relationships (avoid joins, prefer subquery) https://review.openstack.org/498611 | 21:08 |
| *** esikache1 has joined #openstack-sahara | 21:31 | |
| *** esikache1 has quit IRC | 21:35 | |
| iwonka | ping tellesnobrega | 21:38 |
| tellesnobrega | iwonka, pong | 21:50 |
| iwonka | am i supposed to write some documentation? | 21:50 |
| iwonka | and if yes, where? | 21:50 |
| tellesnobrega | it would be great | 21:51 |
| tellesnobrega | sahara docs | 21:51 |
| tellesnobrega | they live now on the sahara project | 21:51 |
| tellesnobrega | sahara/doc/source/ | 21:51 |
| *** jeremyfreudberg has joined #openstack-sahara | 21:52 | |
| tellesnobrega | I believe the best place would be sahara/doc/source/user/overview | 21:52 |
| iwonka | ok | 21:52 |
| tellesnobrega | let me check if there is a better place | 21:52 |
| *** tellesnobrega has left #openstack-sahara | 21:52 | |
| *** tellesnobrega has joined #openstack-sahara | 21:52 | |
| tellesnobrega | I think this place should | 21:53 |
| tellesnobrega | under templates | 21:53 |
| tellesnobrega | you could add a subtopic importing and exporting templates | 21:53 |
| tellesnobrega | and you explain how you do it | 21:53 |
| iwonka | okay | 21:54 |
| iwonka | thanks | 21:54 |
| iwonka | i'll do it before import of ct in gui | 21:54 |
| tosky | and final touch, tempest tests :P | 21:54 |
| iwonka | ? | 21:54 |
| *** jeremyfreudberg has quit IRC | 21:57 | |
| tosky | https://docs.openstack.org/tempest/latest/overview.html - our tests are here: https://docs.openstack.org/sahara-tests/latest/tempest-plugin.html | 22:09 |
| tellesnobrega | tosky, that would be perfect | 22:13 |
| tellesnobrega | iwonka, https://docs.openstack.org/tempest/latest/ | 22:13 |
| iwonka | seems like a longer work | 22:14 |
| iwonka | let me deal with import of ct in gui first please :( | 22:14 |
| tosky | oh, a simple test for one of the new API is not complex | 22:14 |
| tellesnobrega | it shouldn't be too complicated | 22:14 |
| tosky | the horizon part is definitely more complex | 22:15 |
| tosky | (for me at least :) | 22:15 |
| tellesnobrega | but finish your patches first | 22:15 |
| tellesnobrega | we can deal with that later | 22:15 |
| *** iwonka_ has joined #openstack-sahara | 22:21 | |
| *** iwonka has quit IRC | 22:25 | |
| *** iwonka_ is now known as iwonka | 22:34 | |
| mnaser | well | 23:11 |
| mnaser | my fixes work for python3 | 23:11 |
| mnaser | but not python2 | 23:11 |
| mnaser | whaah | 23:11 |
| *** tosky has quit IRC | 23:15 | |
| openstackgerrit | Mohammed Naser proposed openstack/sahara master: Optimize model relationships (avoid joins, prefer subquery) https://review.openstack.org/498611 | 23:25 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!