Monday, 2015-03-16

*** mahito has joined #openstack-sahara01:02
*** Longgeek has joined #openstack-sahara01:08
*** hdd has quit IRC01:09
*** Longgeek has quit IRC01:15
*** _mattf has joined #openstack-sahara01:44
*** hdd has joined #openstack-sahara02:13
*** hogepodge has joined #openstack-sahara02:43
*** coolsvap|afk is now known as coolsvap02:58
*** hdd has quit IRC02:58
*** Poornima has joined #openstack-sahara03:03
*** Longgeek has joined #openstack-sahara03:11
*** Longgeek has quit IRC03:13
*** Longgeek has joined #openstack-sahara03:14
*** Longgeek_ has joined #openstack-sahara03:19
*** Longgeek has quit IRC03:20
*** bandarji has joined #openstack-sahara03:30
*** bandarji has quit IRC03:30
*** bandarji has joined #openstack-sahara03:31
*** Longgeek has joined #openstack-sahara03:41
*** Longgeek_ has quit IRC03:44
*** mahito has quit IRC04:08
*** Longgeek has quit IRC04:11
*** Longgeek has joined #openstack-sahara04:11
*** bandarji has quit IRC04:13
*** Poornima has quit IRC04:28
*** hdd has joined #openstack-sahara04:52
*** Poornima has joined #openstack-sahara05:00
*** hdd has quit IRC05:29
*** Nikolay_St has quit IRC05:31
*** sreshetn1 has joined #openstack-sahara06:46
*** Longgeek_ has joined #openstack-sahara06:52
*** Longgeek has quit IRC06:52
*** tnovacik has joined #openstack-sahara06:53
*** mahito has joined #openstack-sahara06:56
*** pcaruana has quit IRC07:14
openstackgerritArtem Osadchiy proposed openstack/sahara: Add Spark support for MapR plugin  https://review.openstack.org/16300707:21
*** Nikolay_St has joined #openstack-sahara07:28
*** sgotliv has quit IRC07:36
*** sreshetn1 has quit IRC07:40
openstackgerritVitaly Gridnev proposed openstack/sahara: Replace empty list with scalable process in scaling  https://review.openstack.org/16384508:02
openstackgerritVitaly Gridnev proposed openstack/sahara: Apply event-log feature for HDP plugin  https://review.openstack.org/15247208:12
openstackgerritVitaly Gridnev proposed openstack/sahara: Apply event-log feature for HDP plugin  https://review.openstack.org/15247208:18
*** witlessb has joined #openstack-sahara08:18
openstackgerritMerged openstack/sahara: Update the docs for CDH plugin userdoc and image-builder doc  https://review.openstack.org/16367008:24
*** skolekonov has joined #openstack-sahara08:26
openstackgerritVitaly Gridnev proposed openstack/sahara: Add usages for step_type field  https://review.openstack.org/16299708:27
*** mahito has quit IRC08:33
*** AndreyPavlov has quit IRC08:44
*** sreshetn1 has joined #openstack-sahara09:15
openstackgerritAndrey Pavlov proposed openstack/sahara: Adding cluster, instance, job_execution ids to logs  https://review.openstack.org/14396409:26
*** sgotliv has joined #openstack-sahara09:26
openstackgerritAndrey Pavlov proposed openstack/sahara: Adding cluster, instance, job_execution ids to logs  https://review.openstack.org/14396409:30
openstackgerritAndrey Pavlov proposed openstack/sahara: Adding cluster, instance, job_execution ids to logs  https://review.openstack.org/14396409:30
openstackgerritAndrey Pavlov proposed openstack/sahara: Adding cluster, instance, job_execution ids to logs  https://review.openstack.org/14396409:31
*** AndreyPavlov has joined #openstack-sahara09:31
openstackgerritVitaly Gridnev proposed openstack/sahara: Move updating provision progress to conductor  https://review.openstack.org/15942109:41
*** IBerezovskiy has joined #openstack-sahara09:41
openstackgerritAndrey Pavlov proposed openstack/sahara: Fixing log messages to avoid information duplication  https://review.openstack.org/14750409:42
*** sgotliv has quit IRC10:14
*** sgotliv has joined #openstack-sahara10:14
openstackgerritVitaly Gridnev proposed openstack/sahara: Event log supported in new integration tests  https://review.openstack.org/15695610:15
*** coolsvap is now known as coolsvap|afk10:19
*** sgotliv has quit IRC10:25
*** tosky has joined #openstack-sahara10:31
*** tnovacik_ has joined #openstack-sahara10:47
openstackgerritEvgeny Sikachev proposed openstack/sahara: Add scenario files for new integration tests  https://review.openstack.org/16464410:47
*** tnovacik has quit IRC10:48
*** tosky has quit IRC11:12
*** tosky has joined #openstack-sahara11:12
openstackgerritMerged openstack/sahara: Add support for MapR v4.0.2  https://review.openstack.org/16037511:15
openstackgerritEvgeny Sikachev proposed openstack/sahara: Add scenario files for new integration tests  https://review.openstack.org/16464411:19
*** tnovacik_ has quit IRC11:23
openstackgerritVitaly Gridnev proposed openstack/sahara: Event log supported in new integration tests  https://review.openstack.org/15695611:23
*** sgotliv has joined #openstack-sahara11:31
SergeyLukjanovtmckay, elmiko, https://wiki.openstack.org/wiki/Sahara/Kilo/FPF_Exceptions for doc11:31
*** Poornima has quit IRC11:36
openstackgerritMerged openstack/sahara: Add an is_default field to cluster templates and node group templates  https://review.openstack.org/16092012:03
openstackgerritMerged openstack/sahara: Changed wrong value for total during step creation  https://review.openstack.org/15975812:03
*** sreshetn1 has quit IRC12:11
*** tnovacik_ has joined #openstack-sahara12:12
*** sreshetn1 has joined #openstack-sahara12:25
*** macjack has joined #openstack-sahara12:31
openstackgerritMerged openstack/sahara: Rewrite log levels and messages  https://review.openstack.org/15403712:33
openstackgerritMerged openstack/sahara: Changing method for verifying existence of cinder  https://review.openstack.org/16427412:33
*** macjack has quit IRC12:35
openstackgerritMerged openstack/sahara-specs: [EDP] Add a new job-types endpoint  https://review.openstack.org/15756312:38
openstackgerritArtem Osadchiy proposed openstack/sahara: Add Spark support for MapR plugin  https://review.openstack.org/16300712:49
*** openstackgerrit has quit IRC12:50
*** openstackgerrit has joined #openstack-sahara12:50
openstackgerritMerged openstack/sahara-extra: Fix copy operation for large object  https://review.openstack.org/16203612:52
openstackgerritMerged openstack/sahara-extra: Fix pseudo-directory renaming operation  https://review.openstack.org/16210112:54
openstackgerritMerged openstack/sahara-extra: Fix segment object naming that uploaded at qualified URL  https://review.openstack.org/16200512:54
openstackgerritAdrien VergĂ© proposed openstack/sahara: HDP plugin: Fix Beeswax error when starting Hue  https://review.openstack.org/16266812:54
openstackgerritMerged openstack/sahara-extra: Fix to use renewal keystone token when re-authenticated  https://review.openstack.org/16166612:54
openstackgerritSergey Lukjanov proposed openstack/sahara-specs: Defere "Add Spark Shell Action job type" to Liberty We're already meet Feature Proposal Freeze  https://review.openstack.org/16468013:00
openstackgerritSergey Lukjanov proposed openstack/sahara-specs: Defere "Add Spark Shell Action job type" to Liberty  https://review.openstack.org/16468013:01
elmikoSergeyLukjanov: ack, thanks13:01
SergeyLukjanovtmckay, egafford, sgotliv I've deferred Add Spark Shell Action job type to Liberty release because of FPF two weeks ago and FF this week13:02
openstackgerritVitaly Gridnev proposed openstack/sahara: Implement poll util and plugin poll util  https://review.openstack.org/15739213:03
openstackgerritVitaly Gridnev proposed openstack/sahara: Add usages of poll util for service modules  https://review.openstack.org/16346313:03
*** _crobertsrh is now known as crobertsrh13:06
openstackgerritAndrey Pavlov proposed openstack/sahara: Docs updated with instance locality feature  https://review.openstack.org/16468313:08
*** tmckay has joined #openstack-sahara13:11
openstackgerritEvgeny Sikachev proposed openstack/sahara: Add scenario files for new integration tests  https://review.openstack.org/16464413:12
openstackgerritMerged openstack/sahara-specs: Defere "Add Spark Shell Action job type" to Liberty  https://review.openstack.org/16468013:13
openstackgerritSergey Lukjanov proposed openstack/sahara: Avoid additional runtime requirements by default  https://review.openstack.org/16468413:14
openstackgerritArtem Osadchiy proposed openstack/sahara: Oozie doesn't start properly  https://review.openstack.org/16468513:14
SergeyLukjanovelmiko, I've proposed CR to remove python-barbicanclient>=3.0.1 from requirements to avoid additional runtime requirements13:14
SergeyLukjanovelmiko, https://review.openstack.org/16468413:15
SergeyLukjanovelmiko, what do you think about it?13:15
elmikoSergeyLukjanov: it will make the sahara.utils.keymgr stuff break, and we will need to turn off the keymgr tests i think.13:17
elmikoSergeyLukjanov: so, maybe move it to test-requirements.txt?13:18
SergeyLukjanovelmiko, yeah, that's a good option, the main reason I've proposed this patch is to discuss it13:18
elmikoSergeyLukjanov: also, i am working on a patch for the swift passwords now. by default the external manager is turned off, but all the passwords are still gated through the keymgr module.13:19
elmikoso, that might have an effect as well13:19
openstackgerritSergey Lukjanov proposed openstack/sahara: [DISCUSSION, DO NOT MERGE] Avoid additional runtime requirements by default  https://review.openstack.org/16468413:19
elmikoSergeyLukjanov: i'll add my comments to the review13:19
SergeyLukjanovelmiko, I think that probably keymgr module should be improved first13:20
SergeyLukjanovelmiko, there was a very good comment on the initial change13:20
SergeyLukjanovelmiko, about class and pluggability13:20
elmikoSergeyLukjanov: about the cinder/nova keymgr stuff?13:20
SergeyLukjanovelmiko, yeah13:21
SergeyLukjanovelmiko, have you seen their impl?13:21
elmikoSergeyLukjanov: yes13:21
elmikoSergeyLukjanov: i responded to those comments, i think we will want to use the Castellan keymgr when it is released.13:21
elmikoSergeyLukjanov: but i still think we can use the thin wrapper to help gate calls through the keymgr.13:22
elmikoSergeyLukjanov: my thinking is this, we use the keymgr calls regardless of whether we are using external or not.13:22
elmikoSergeyLukjanov: then the keymgr can control if the keys are moved off-board or just returned to be stored in the db13:22
SergeyLukjanovelmiko, Castellan?13:23
elmikoSergeyLukjanov: yea, Castellan is a keymgr library that can use multiple backends.13:24
elmikoSergeyLukjanov: it's being developed based off the cinder/nova keymgr code13:24
SergeyLukjanovelmiko, could you please add link to it?13:24
SergeyLukjanovelmiko, oh, got it13:24
elmikoSergeyLukjanov: https://review.openstack.org/#/c/148742/13:24
elmikothat's the big commit that just happened13:24
SergeyLukjanovelmiko, my main concern is that in Kilo prod installations barbican will not used13:25
elmikoSergeyLukjanov: agreed. we can probably remove it from the requirements.txt, but might need to keep for test-requirements.txt13:25
SergeyLukjanovelmiko, and it means that packaging its client is absolutely useless but if it'll be not installed than sahara will not work13:25
elmikoSergeyLukjanov: agreed13:25
SergeyLukjanovelmiko, so, we need to wrap it in a way to support situation when client isn't installed13:26
SergeyLukjanovelmiko, I could wrap imports to impl it13:26
elmikoSergeyLukjanov: that could work13:26
elmikoSergeyLukjanov: i'll open a new bug to address creating a better separation13:27
SergeyLukjanovelmiko, ack, thx13:27
SergeyLukjanovelmiko, re WADL API doc - we need to have it in 2 weeks13:27
elmikoSergeyLukjanov: i think that's doable13:27
elmikoSergeyLukjanov: i started reviewing what we need over the weekend13:28
tmckayelmiko, crobertsrh, fyi, from Friday discussion, client allows delete of tempaltes by name or id, so I'm gonna tweak delete on the template CLI13:28
elmikotmckay: ack13:28
crobertsrhack13:28
SergeyLukjanovelmiko, in fact it's about converting all our API docs to the ugly XML format to then generate sexy API ref page13:28
elmikoSergeyLukjanov: i'm thinking maybe i should just wait till Liberty cycle before trying to implement more keymgr stuff. that makes removing barbicanclient an easy choice13:29
openstackgerritMerged openstack/sahara: Switch to v2 version of novaclient  https://review.openstack.org/16380213:29
SergeyLukjanovelmiko, do you need help with it? I could ask someone from my team to start doing it to have first parts asap13:29
tmckayelmiko, crobertsrh, SergeyLukjanov, I had a thought over the weekend.  I wonder if we need any kind of version in default templates, so that we know what release a default template is from, or what version of the CLI? is_default could be a string instead of a Boolean, or we could use the description field, or we could use a naming convention.  No clear use case, just a nagging feeling that a version might come in handy for some reason13:29
tmckayof course, with alembic, we could always change the is_default field later, or add one, etc etc13:30
SergeyLukjanovelmiko, I'm ok with and IMO it's the best choice now because will not have direct benefits from adding experimental support to the Kilo release, prod ready impl in Liberty is extremely improtant13:30
tmckayrelated thought, we might want to organize the directory of def templates from Sahara so that we have them grouped by release ....13:30
tmckayso we have a clear trail of what was created when13:30
crobertsrhMy first thought when I originally wrote the spec was to have a version of some sort, but we eventually concluded that we didn't want/need it, at least for now.13:31
crobertsrhI don't hate the idea of having some sort of version info though.13:31
elmikoSergeyLukjanov: i think much of it will be copying what we have in the v1 v1.1 docs into the WADL format. i was going to do a transformation on the swagger doc i produced for sahara to build the base of the WADL doc, but... if you have folks who are ready to go then i don't mind help =)13:31
SergeyLukjanovtmckay, crobertsrh speaking about versions - we need to take a look on glance artifact store13:31
SergeyLukjanovprobably we could migrate our templates to it and re-use their versioning, search and etc.13:32
crobertsrhah, yes....the glance artifact store....I had forgot about that13:32
tmckaySergeyLukjanov, yes, we had that in the back of our minds for Kilo, but we haven13:32
tmckayhaven't paid much attention13:32
SergeyLukjanovelmiko, could you please ping me when you'll understand when you're able to start working on it? I will try to investigate it before13:33
SergeyLukjanovtmckay, yeah13:33
SergeyLukjanovtmckay, as I know it's working already somehow13:33
SergeyLukjanovtmckay, I've been approving semver lib in global requirements for their versioning feature ;)13:33
elmikoSergeyLukjanov: i was thinking about starting tuesday or wednesday this week, there is some security doc stuff i need to finish before then.13:34
SergeyLukjanovelmiko, ack13:34
SergeyLukjanovtmckay, I've asked ativelkov to join our channel to chat about glance stuff, he's driving this feature13:35
tmckaySergeyLukjanov, okay.  Forgive me if I'm a little distracted, I still have a few things to do for default templates -- tweak delete, fix up spec, unit tests13:36
SergeyLukjanovtmckay, that's ok :)13:38
openstackgerritMerged openstack/sahara-image-elements: Fix datanode launch performance caused by entropy pool depletion  https://review.openstack.org/16198813:42
toskyI've noticed that the swift bugs have been fixed: https://bugs.launchpad.net/sahara/+bug/142893913:43
openstackLaunchpad bug 1428939 in Sahara "[hadoop-swiftfs] cannot read large object that uploaded by hadoop command" [High,Fix committed] - Assigned to Kazuki OIKAWA (k.oikw)13:43
uvirtbotLaunchpad bug 1428939 in sahara "[hadoop-swiftfs] cannot read large object that uploaded by hadoop command" [High,Fix committed]13:43
uvirtbotLaunchpad bug 1428939 in sahara "[hadoop-swiftfs] cannot read large object that uploaded by hadoop command" [High,Fix committed] https://launchpad.net/bugs/142893913:43
toskybut my comment #4 is still relevant, I think: not all images use "our" version of swiftfs hadoop library, but the upstream one13:43
elmikotosky: as i understand it, the issue with pushing to upstream is that the apache hadoop folks are very slow in accepting patches13:48
toskyelmiko: ok, but then does it mean we are giving up pushing upstream?13:51
toskyI didn't see any link to an upstream ticket, even after I asked13:52
toskyalso, if we decide to ignore upstream, which I think is bad, we should at least fix the image generation process to always use the internal library13:52
elmikotosky: good question, i'm not clear on how exactly we are working with upstream on these issues13:52
elmikotosky: i agree we should work with upstream, i'm just repeating what came up when we talked about working with them last year.13:53
*** tnovacik_ has quit IRC13:53
elmikotosky: here's one of the jiras https://issues.apache.org/jira/browse/HADOOP-1094813:54
toskyelmiko: sure, right now, if I understand the core correctly, HDP use the upstream version (as it does not include the swiftfs_hadoop element in s-i-e)13:55
elmikotosky: hmm, interesting. i think in general we should probably always use the code from sahara-extras13:56
toskyelmiko: uhm, I wonder which of the 3/4 bugs closed today matches that patch13:56
toskyelmiko: unless I misunderstand the code from s-i-e, that's why I asked13:56
elmikotosky: it's a good point, i just haven't looked into it for awhile. we certainly need to clear this up13:57
openstackgerritArtem Osadchiy proposed openstack/sahara: Oozie doesn't start properly  https://review.openstack.org/16468513:57
elmikotosky: it seems to me that main point of contact on this stuff between the sahara and hadoop projects is oikawa13:57
elmikoSergeyLukjanov: i need to adjust the description on the barbican bp, but i think we can mark it as complete at this point14:02
*** egafford has joined #openstack-sahara14:03
*** egafford has quit IRC14:04
*** tnovacik_ has joined #openstack-sahara14:05
*** egafford has joined #openstack-sahara14:08
openstackgerritSergey Reshetnyak proposed openstack/sahara-image-elements: Migrate to openjdk - part 2  https://review.openstack.org/14643414:16
SergeyLukjanovelmiko, I think it'll be better to defer spec to liberty because bp isn't implemented actually14:16
*** Nikolay_St has quit IRC14:17
elmikoSergeyLukjanov: that bp was just about implementing the key manager portion14:17
SergeyLukjanovelmiko, oh14:18
elmikoSergeyLukjanov: i wanted to separate the different parts so it wasn't such a huge undertaking14:18
elmikoSergeyLukjanov: i think we should be creating bugs as we come across areas that can be improved by moving to key manager usage14:18
SergeyLukjanovelmiko, my concern is that if someone will see "Improved secret storage utilizing Barbican" implemented than it sounds like at least experimental support14:19
SergeyLukjanovelmiko, but we currently only have wrapper14:19
elmikoSergeyLukjanov: makes sense, maybe i should reword the description then slightly?14:20
SergeyLukjanovelmiko, IMO it should be just moved to Liberty to avoid misunderstanding14:20
elmikoi  mean, technically the wrapper is implemented. it just isn't used14:20
elmikoSergeyLukjanov: ack14:20
SergeyLukjanovelmiko, okay, I'll do it14:21
SergeyLukjanovelmiko, it's only about moving spec14:21
SergeyLukjanovelmiko, not about removing code14:21
elmikoSergeyLukjanov: i was just talking about the blueprint, i think the spec is fine. the spec only defines the manager wrapper14:21
SergeyLukjanovelmiko, oh, ack14:22
elmikoSergeyLukjanov: i marked the bp as complete, but maybe that was premature14:22
SergeyLukjanovelmiko, so, we could adjust the bp title a bit to make it more clear14:22
elmikoSergeyLukjanov: yea14:22
elmikoSergeyLukjanov: i'll take care of it14:23
SergeyLukjanovelmiko, thx14:23
elmikoSergeyLukjanov: i adjusted the bp to change the language slighty, but i think we should talk again at the meeting this week.14:31
SergeyLukjanovelmiko, okay14:33
SergeyLukjanovelmiko, hm, we'll have a meeting most probably after the kilo-3 cut14:34
SergeyLukjanovelmiko, it's better to agree on it before the actual tag14:34
elmikoSergeyLukjanov: i just thought originally the bp and spec would address only implementing the key manager abstraction, then we would create bugs for the individual secrets that needed to use the key manager.14:36
elmikoSergeyLukjanov: it sounds like you'd like the bp to address the secrets as well?14:36
SergeyLukjanovelmiko, probably abstract pluggable keymngr14:40
elmikoSergeyLukjanov: agreed, i think that is a layer which can be added to what we have now14:41
SergeyLukjanovelmiko, I'm just a bit concerned that having this BP implemented doesn't mean any actual change to Sahara14:41
elmikoSergeyLukjanov: hmm, good point. by itself, it doesn't represent a change.14:42
elmikoSergeyLukjanov: well, the bp is changed to "Good Progress" and i'm fine with that for K-314:43
elmikoSergeyLukjanov: i'll stay on top of the changes to Castellan and the internal progress we want to make towards putting more secrets behind the manager. i don't see us adding anything more for Kilo, but it will be a nice roadmap for Liberty.14:44
*** sreshetn1 has quit IRC14:46
*** stannie has quit IRC14:49
*** sreshetn1 has joined #openstack-sahara14:52
SergeyLukjanovelmiko, okay, thx, so, are you with moving it to Liberty?14:53
elmikoSergeyLukjanov: +114:53
*** esikachev has joined #openstack-sahara14:56
*** Nikolay_St has joined #openstack-sahara14:56
openstackgerritSergey Lukjanov proposed openstack/sahara-specs: Defere "Improved secret storage utilizing external key manager" to Liberty  https://review.openstack.org/16473215:17
*** Networkn3rd has joined #openstack-sahara15:20
*** Nikolay_St has quit IRC15:27
*** Longgeek_ has quit IRC15:36
*** bandarji has joined #openstack-sahara15:47
openstackgerritYuriy Taraday proposed openstack/sahara: Add an option to use lazy formatting in new-style logging  https://review.openstack.org/16475515:56
*** ativelkov has joined #openstack-sahara15:58
*** tnovacik_ has quit IRC15:59
openstackgerritMerged openstack/sahara-specs: Defere "Improved secret storage utilizing external key manager" to Liberty  https://review.openstack.org/16473216:00
*** skolekonov has quit IRC16:05
openstackgerritTrevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates  https://review.openstack.org/16364916:09
*** openstackgerrit has quit IRC16:11
*** openstackgerrit has joined #openstack-sahara16:11
*** IBerezovskiy has quit IRC16:15
openstackgerritMerged openstack/sahara: Added support of instance locality to engines  https://review.openstack.org/16217216:27
openstackgerritMerged openstack/sahara: Add job-types endpoint  https://review.openstack.org/16125016:27
openstackgerritMerged openstack/sahara: Implement job-types endpoint support methods for HDP plugin  https://review.openstack.org/16126316:27
openstackgerritEvgeny Sikachev proposed openstack/sahara: Add scenario files for new integration tests  https://review.openstack.org/16464416:30
openstackgerritEvgeny Sikachev proposed openstack/sahara: Add scenario files for new integration tests  https://review.openstack.org/16464416:32
*** esikachev has quit IRC16:32
*** hdd has joined #openstack-sahara16:40
openstackgerritEthan Gafford proposed openstack/sahara: Default templates for HDP  https://review.openstack.org/16477216:43
*** vgridnev_ has joined #openstack-sahara16:44
*** tnovacik_ has joined #openstack-sahara16:47
*** openstackgerrit has quit IRC16:54
*** openstackgerrit has joined #openstack-sahara16:54
tmckayelmiko, crobertsrh, egafford, re substitution in default templates.  So we are adding config sections on the fly based on plugin, version, and template name and prefering more specific (so we will look for vanilla_1.2.1_worker, then vanilla_1.2.1, vanilla, and finally DEFAULT17:08
tmckaybut our substitutions are pre-set.17:08
tmckayI mean, the fields we support17:08
crobertsrhYeah, I think the substitution fields are pre-set.17:09
tmckayWhat if I added a config option on the fly in the same way for anything we find in {}?  Like,   count: {my_favorite_value}17:09
elmikoi dunno, i kinda like keeping it simple17:09
tmckaythis is simple17:09
crobertsrhWe could do that if we wanted to be really really flexible, but that seems like it could be troublesome17:09
tmckayyou name a field, it's in the config file, you get it17:10
tmckaycrobertsrh, how so?17:10
crobertsrhAs long as we could give a good error message when it doesn't go as planned17:10
tmckayelmiko, crobertsrh, egafford mentioned "count" today.  There's no way to map that simply.  It might be nice to be able to configure count to change the number of workers, for instance17:10
elmikoit's a nice convenience but imo it starts to move away from the idea that we talked about keeping this "on the rails" kind of configuration.17:11
tmckayso if you want that, you copy the set and edit yourself17:11
tmckayif our count is not good enough, make your own17:11
crobertsrhHow much additional work would it be to support arbitrary substitutions?17:11
tmckayI mean, copy the json files and edit17:11
tmckaywell, validation is going to catch errors.  The only trouble I see is that oslo config wants a type for an option17:13
tmckayknowing what to give it for a type might be tricky.  Unless it can be lifted from the schema17:13
crobertsrhMaybe just go with the 2 supported options for now.  If the masses demand more flexibility, maybe a Liberty thing?17:14
tmckaymay not be worth it.  I was looking for a simple way to make "count" configurable, but there is not a one-to-one mapping in a cluster template for count17:14
tmckayack, I could see that17:14
elmikocrobertsrh: +117:14
elmikoi like making it simpler for now17:14
tmckaywhat do you guys think about rollback?  It's currently attempting to undo changes for a set (a directory level defines a set) if something happens part way through17:15
tmckayrolling back creation is easy.  Rolling back update doesn't work yet.17:15
openstackgerritEthan Gafford proposed openstack/sahara: Default templates for Vanilla  https://review.openstack.org/16478917:16
openstackgerritVitaly Gridnev proposed openstack/sahara: Apply event-log feature for HDP plugin  https://review.openstack.org/15247217:16
elmikothat's a toughie17:16
tmckayI think I can do it without too much trouble by looking at what I'm pushing up and saving the differences.  But nested structures might be weird.  Also, sqlalchemy is not noticing a change of "count" currently as an update, could be a bug.17:17
egaffordtmckay, elmiko, crobertsrh: Perfectly reasonable to not make count configurable; templates can always be copied and edited.17:18
elmikoimo, i thought the default templates are targeted at new users who have no idea what is going on with sahara and potentially hadoop/spark in general. these templates give them a cluster to start messing around on.17:19
elmikoonce they get past the initial phase, then they should really create their own json, or use the ui, or whatever works for them17:20
tmckayyeah, maybe we just should have made some sample JSON files and called it good enough17:23
tmckaymaybe this CLI thing is overkill17:24
elmikowell... the cli could grow in the future, but for now maybe keep it simple.17:25
openstackgerritTrevor McKay proposed openstack/sahara-specs: Provide default templates for each plugin  https://review.openstack.org/16220917:28
openstackgerritEthan Gafford proposed openstack/sahara: Default templates for Spark  https://review.openstack.org/16479717:34
*** IlyaE has joined #openstack-sahara17:39
tmckaySergeyLukjanov, is the exception link, or is there an etherpad too? https://wiki.openstack.org/wiki/Sahara/Kilo/FPF_Exceptions17:58
*** Nikolay_St has joined #openstack-sahara17:59
elmikowhat do folks think about a security session for vancouver, should i look towards making it a fish bowl session or a working session?18:07
elmikotopic-wise i'm thinking, where we are now, what we plan to do for L, what we could be looking at long term18:07
elmikothe security session was well attended in paris, but i'm not sure if this would be large enough for a fish bowl session18:08
*** sgotliv has quit IRC18:16
*** sreshetn1 has quit IRC18:19
openstackgerritVitaly Gridnev proposed openstack/sahara: Implement poll util and plugin poll util  https://review.openstack.org/15739218:20
openstackgerritVitaly Gridnev proposed openstack/sahara: Add usages of poll util for service modules  https://review.openstack.org/16346318:20
openstackgerritTrevor McKay proposed openstack/python-saharaclient: Add support for job-types-list  https://review.openstack.org/16144818:20
openstackgerritTrevor McKay proposed openstack/python-saharaclient: Add support for job-types-list  https://review.openstack.org/16144818:22
openstackgerritMerged openstack/sahara: Add Sentry service test in cdh plugin integration test  https://review.openstack.org/15791518:33
*** sreshetn1 has joined #openstack-sahara18:40
openstackgerritVitaly Gridnev proposed openstack/sahara: Add usages for step_type field  https://review.openstack.org/16299718:46
openstackgerritVitaly Gridnev proposed openstack/sahara: Move updating provision progress to conductor  https://review.openstack.org/15942118:46
openstackgerritVitaly Gridnev proposed openstack/sahara: Minor - misprint corrected  https://review.openstack.org/16482518:53
elmikotmckay: reading the default-templates spec review now, something occurs to me18:58
elmikowhy even allow node group templates, why not just create all-in-one cluster templates?18:58
elmikothat would simplify things and make the templates more flat18:59
*** Nikolay_St has quit IRC18:59
*** Nikolay_St has joined #openstack-sahara19:00
openstackgerritVitaly Gridnev proposed openstack/sahara: Minor - allow changing status description of deleting cluster  https://review.openstack.org/16482919:02
tmckaycrobertsrh, ^^ elmiko, hmm, could be.  If you have multiple cluster templates, though, you can reuse some of the ng templates.19:02
tmckayelmiko, why not post a comment on the spec?19:03
elmikotmckay: given the way you are specifying the detection of ng template vs. cluster templates, it will break if someone attempts to create an all-in-one template19:03
tmckayI'm not sure if embedded node groups are something we are trying to move away from, or encourage19:03
crobertsrhYeah, ng_templates might still be useful.19:03
elmikoi agree they are useful in general, but i'm having doubts about their usefulness in the default stuff specifically19:04
tmckayelmiko, I don't think so, because it checks at top level.  It's a dict.19:04
crobertsrhwill it really break it?19:04
elmikoi dunno, that's why i'm asking =)19:04
crobertsrha cluster template can be created....it should be using the cluster_template schema19:04
tmckayso node_processes or flavor_id buried in a node group will be okay19:04
elmikook19:04
crobertsrhYou can have your fancy-pants all-in-one custom default cluster templates19:05
elmikocrobertsrh: i meant more for the language in the spec that talks about differentiating the template types based on their contents19:05
crobertsrhAh19:05
*** vgridnev_ has quit IRC19:06
elmikoi think there are some side effects from all-in-one style that might be nice for this too, but i'm not quite sure.19:06
elmikowhen you create a cluster template from an all-in-one, you only get the template in the db, no node group templates.19:06
elmikothat might be a simplification in terms of creating less that the user will see. not sure, just spitballing.19:07
tmckaywe can still support both, but we could just distribute cluster templates for now.  Also not sure.19:08
elmikoyea, just a thought while reading this19:09
openstackgerritEthan Gafford proposed openstack/sahara: Default templates for Spark  https://review.openstack.org/16479719:09
openstackgerritEthan Gafford proposed openstack/sahara: Default templates for HDP  https://review.openstack.org/16477219:10
tmckayelmiko, trying to figure out how to handle floating_ip_pool sanely as a replaceable value.  If you leave it out, it shows up as "null"19:10
tmckaybut you might not want it19:11
elmikomaybe check the CONF while processing and if the user did not define a value *and* use_floating_ips=False then remove it?19:12
egaffordtmckay: Is null an acceptable value that translates to None and behaves appropriately?19:12
tmckayI'm wondering if the CLI should just blow away replaceable fields if they are None in the CLI.  So that if you do not specify a config, it blows it away.  And log an INFO message, maybe19:12
elmikoi think that field is needed for schema validation though, right?19:12
tmckayegafford, if you send None through JSON you get "None"19:12
tmckaynull means it wasn'19:13
tmckaywasn't there19:13
tmckay"" comes through as ""19:13
egaffordtmckay: Right; that may be acceptable. I can certainly replace "floating_ip_pool": "{floating_ip_pool}" with {floating_ip_pool}, allowing you to empty out the whole line, but that might be diretier.19:13
tmckaynot sure what the implications are19:13
egaffords/diretier/dirtier19:13
egafforddiretier sounds like it should be pronounced in Frech.19:14
elmikolooks like floating_ip_pool is not required for validation, so probably safe to remove if necessary19:15
openstackgerritEthan Gafford proposed openstack/sahara: Default templates for Vanilla  https://review.openstack.org/16478919:15
tmckayI think blowing away values with nothing specified in config (default config param value is None) is okay.19:15
egaffordtmckay: Are you okay enough with the default template sets that I should take them out of wf-1? I've added a dep on your CLI change.19:16
elmikoi think we need to get this spec merged...19:16
tmckayleave it wf -1 for the moment, til I get this floating_ip_pool thing sorted19:16
tmckayelmiko, ack19:16
egaffordtmckay: Okey doke.19:17
tmckaydo you guys think we need a log message if we blow away a replaceable field because there was no config value?19:20
tmckayor we consider that not noteworthy19:21
elmikoi19:21
elmikoi'd say debug log maybe19:21
crobertsrhMight want to have it as a debug19:21
crobertsrhheh19:21
tmckayokey-doke19:21
*** IlyaE has quit IRC19:24
tmckaywell, that works.19:24
egaffordtmckay: Hoorah!19:26
tmckayif you leave it out of the config file, you end up with "null" in JSON19:26
tmckayif you specify it, you get your value19:27
tmckaypretty sane19:27
elmikosounds good19:27
egaffordYeah, ideal really.19:27
tmckayI'll just add that little debug message19:27
elmikotmckay: is the cli review under you or egafford ?19:30
tmckayme19:30
egaffordelmiko: I'm mostly on image generation stuff at the moment; just throwing the cycles I can at templates. :)19:30
elmikotmckay: found it19:30
elmikoegafford: cool, i just didn't see it on my list.19:31
egaffordelmiko: Ack.19:31
crobertsrhSo far, I'm loving the default templates stuff.  My "restack" scripts are about to get a lot simpler and more useful by setting up all of my templates right out of the box.19:31
elmiko+119:32
tmckayoh, man -- because of the way update works, if you make something with a floating_ip_pool field then try to update it with something that doesn't have that field, ot19:34
tmckayit's not replaced19:34
elmikocrobertsrh: there might also be a win in the future for the guided stuff if we could expand functionality later to allow default cluster creation with a 1-click or something19:34
tmckaywhich is expected, but subtle19:35
crobertsrhYes..I wish we had done default templates sooner19:35
tmckaysame for any field you want to drop, actually19:35
tmckayyour only choice is to delete and recreate for fields you want to drop19:35
elmikowe'd need to modify the saharaclient to allow default template access though19:35
tmckayoh well19:35
elmikodoh19:35
tmckaymaybe update should just be removed19:36
crobertsrhIt'll give me something to do for L19:36
tmckaymaybe you should only have create and delete19:36
elmikowell, update just because delete then create ?19:36
elmikos/because/becomes19:36
crobertsrhtmckay:  That might be sufficient.....or have "update" just do a delete/create in the background.19:36
crobertsrhgive the illusion of update19:36
elmikopretty sure you could even preserve the id19:37
tmckayhmm, I wonder if sqlalchemy will trash a field if you pass it a none19:38
tmckayso, not missing, but present and == None19:38
elmikonot sure19:39
egaffordI'd hope that would result in a null.19:39
elmikoi think it depends if the table field allows NULL as a value19:39
egaffordOtherwise sqlalchemy is scary and is making a lot of decisions about my data model.19:39
tmckayegafford, well, it might do something silly like generating "None" for a string value19:40
elmikoi know in django you need to explicitly set a field to allow null/None as a value19:40
tmckaywhich is what json seems to do19:40
egaffordtmckay: JSON generates null, not "null", right?19:40
elmikoegafford: yea, null19:40
openstackgerritMerged openstack/sahara: Change imports after moving tempest common code  https://review.openstack.org/16331019:40
egaffordjson null is cool; null -> "null" would be really unfortunate.19:41
elmikolol agreed19:41
egaffordJust so, [thing: null] -> [thing: NULL] is cool; [thing: null] -> [] is not.19:42
tmckaymaybe we should kick def templates to Liberty19:42
elmikoyea, that would be tragic19:42
egafford(At the data layer. In impl, it can be fine.)19:42
elmiko(that was at egafford's comment)19:42
elmikoif we kick defaults to L, then i definitely think we should use jinja. just sayin19:43
toskyare all Sahara blueprints going through the git/review-based process nowadays?19:45
egaffordtosky: Specs are; I think very small changes can conceivably go through without a reviewed spec.19:46
*** hdd has quit IRC19:47
*** IlyaE has joined #openstack-sahara19:48
*** uvirtbot has quit IRC19:50
*** IlyaE has quit IRC19:51
*** sgotliv has joined #openstack-sahara19:52
elmikotosky: i've seen some refactoring allowed through without specs. i think the idea is to gate features/large changes through blueprints/specs19:53
toskyelmiko: and for testing-related blueprints which can span two releases?19:54
tosky:D19:54
elmikowell...19:54
elmikothey start as a bp/spec in one release, and then the spec gets moved to the 2nd release folder if it's not implemented yet19:55
elmikoat least, that's how i think it should work19:55
*** hdd has joined #openstack-sahara19:56
toskyand if you know that you can't implement everything now because of other depedencies, but you can start at least something before the release (and being a test should be like bugfixes)?19:56
toskya possibility would be create two specs, but it's really the same process19:57
toskyto be tracked together19:57
elmikoyea, i guess it depends on the specifics.19:57
elmikoyou could create a single spec and when it's approved start implementing "Partial-implements" reviews against it19:58
*** IlyaE has joined #openstack-sahara19:58
elmikoor, you could go with what you said. basically, 2 specs19:58
toskythanks19:59
toskyI will recheck the real status before proceeding20:00
elmikotmckay: i'm most of the way through the cli review, looks good so far.20:04
*** IlyaE has quit IRC20:04
elmikoi'll prob. finish it up tonight20:04
*** IlyaE has joined #openstack-sahara20:04
*** sreshetn1 has quit IRC20:06
*** sgotliv has quit IRC20:10
*** IlyaE has quit IRC20:11
*** sreshetn1 has joined #openstack-sahara20:13
*** sgotliv has joined #openstack-sahara20:14
openstackgerritMerged openstack/sahara: Add a common HBase lib in hdfs on cluster start  https://review.openstack.org/16265720:23
*** crobertsrh has quit IRC20:29
*** Networkn3rd has quit IRC20:36
*** IlyaE has joined #openstack-sahara20:43
openstackgerritTrevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates  https://review.openstack.org/16364921:03
*** IlyaE has quit IRC21:05
*** syncroswitch has joined #openstack-sahara21:11
*** tellesnobrega has quit IRC21:13
*** sreshetn1 has quit IRC21:14
*** tellesnobrega has joined #openstack-sahara21:18
*** sreshetn1 has joined #openstack-sahara21:21
*** tmckay has quit IRC21:25
*** IlyaE has joined #openstack-sahara21:30
*** sgotliv has quit IRC21:42
*** syncroswitch has quit IRC21:43
*** sreshetn1 has quit IRC21:44
*** IlyaE has quit IRC22:20
*** IlyaE has joined #openstack-sahara22:42
*** sgotliv has joined #openstack-sahara22:56
*** bandarji has quit IRC23:06
*** sgotliv has quit IRC23:10
*** IlyaE has quit IRC23:17
*** egafford has quit IRC23:18
*** IlyaE has joined #openstack-sahara23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!