| *** Longgeek has joined #openstack-sahara | 00:18 | |
| *** tnovacik has quit IRC | 00:29 | |
| *** Longgeek has quit IRC | 00:32 | |
| *** bandarji has quit IRC | 01:09 | |
| *** macjack has joined #openstack-sahara | 02:01 | |
| *** hdd_ has joined #openstack-sahara | 02:06 | |
| *** Longgeek has joined #openstack-sahara | 02:18 | |
| *** Poornima has joined #openstack-sahara | 02:34 | |
| *** Longgeek has quit IRC | 02:35 | |
| *** devlaps has quit IRC | 02:43 | |
| openstackgerrit | Ken Chen proposed openstack/sahara: Update the docs for CDH plugin userdoc and image-builder doc https://review.openstack.org/163670 | 02:55 |
|---|---|---|
| *** Longgeek has joined #openstack-sahara | 03:31 | |
| *** Poornima has quit IRC | 03:34 | |
| *** Longgeek has quit IRC | 03:41 | |
| *** Longgeek has joined #openstack-sahara | 03:52 | |
| *** hdd_ has quit IRC | 04:37 | |
| *** chandankumar has joined #openstack-sahara | 04:39 | |
| *** Longgeek has quit IRC | 04:47 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Replace empty list with scalable process in scaling https://review.openstack.org/163845 | 04:53 |
| *** akuznetsov has joined #openstack-sahara | 05:10 | |
| *** akuznetsov has quit IRC | 05:11 | |
| *** akuznetsov has joined #openstack-sahara | 05:12 | |
| *** coolsvap|afk is now known as coolsvap | 05:14 | |
| *** akuznetsov has quit IRC | 05:19 | |
| *** akuznetsov has joined #openstack-sahara | 05:20 | |
| *** akuznetsov has quit IRC | 05:22 | |
| *** Poornima has joined #openstack-sahara | 05:24 | |
| *** Poornima has quit IRC | 05:24 | |
| *** Poornima has joined #openstack-sahara | 05:25 | |
| *** chandankumar has quit IRC | 05:36 | |
| *** chandankumar has joined #openstack-sahara | 05:40 | |
| *** Nikolay_St has quit IRC | 05:41 | |
| *** Longgeek has joined #openstack-sahara | 05:48 | |
| *** chandankumar has quit IRC | 05:52 | |
| *** Longgeek has quit IRC | 06:21 | |
| *** sreshetn1 has joined #openstack-sahara | 06:35 | |
| *** chandankumar has joined #openstack-sahara | 06:52 | |
| *** coolsvap is now known as coolsvap|afk | 06:54 | |
| *** coolsvap has joined #openstack-sahara | 07:09 | |
| *** Longgeek has joined #openstack-sahara | 07:18 | |
| *** tnovacik has joined #openstack-sahara | 07:27 | |
| *** jamielennox has quit IRC | 07:31 | |
| *** jamielennox has joined #openstack-sahara | 07:34 | |
| *** jamielennox has quit IRC | 07:39 | |
| *** Nikolay_St has joined #openstack-sahara | 07:40 | |
| *** Longgeek has quit IRC | 07:41 | |
| *** Longgeek has joined #openstack-sahara | 07:41 | |
| *** sgotliv has quit IRC | 07:49 | |
| *** jamielennox|away has joined #openstack-sahara | 07:55 | |
| *** jamielennox|away is now known as jamielennox | 07:55 | |
| *** coolsvap has quit IRC | 07:59 | |
| *** sreshetn1 has quit IRC | 08:03 | |
| *** sgotliv has joined #openstack-sahara | 08:04 | |
| *** chlong has quit IRC | 08:09 | |
| *** openstackgerrit has quit IRC | 08:21 | |
| *** openstackgerrit has joined #openstack-sahara | 08:21 | |
| *** esikachev has joined #openstack-sahara | 08:43 | |
| *** esikachev has quit IRC | 08:47 | |
| *** esikachev has joined #openstack-sahara | 08:50 | |
| *** esikachev has quit IRC | 08:52 | |
| *** sreshetn1 has joined #openstack-sahara | 09:00 | |
| *** sreshetn1 has quit IRC | 09:04 | |
| *** stannie1 has joined #openstack-sahara | 09:07 | |
| *** Longgeek has quit IRC | 09:16 | |
| openstackgerrit | Nikita Konovalov proposed openstack/sahara: Node Groups now have id field https://review.openstack.org/163812 | 09:21 |
| *** witlessb has joined #openstack-sahara | 09:51 | |
| *** IBerezovskiy has joined #openstack-sahara | 09:54 | |
| *** witlessb has quit IRC | 10:09 | |
| *** witlessb has joined #openstack-sahara | 10:09 | |
| *** Longgeek has joined #openstack-sahara | 10:17 | |
| *** stannie1 has quit IRC | 10:25 | |
| openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding cluster, instance, job_execution ids to logs https://review.openstack.org/143964 | 10:28 |
| *** Longgeek has quit IRC | 10:32 | |
| *** jamielennox has quit IRC | 10:55 | |
| openstackgerrit | Andrey Pavlov proposed openstack/sahara: Fixing log messages to avoid information duplication https://review.openstack.org/147504 | 10:58 |
| *** tosky has joined #openstack-sahara | 10:58 | |
| openstackgerrit | Andrey Pavlov proposed openstack/sahara: Fixing log messages to avoid information duplication https://review.openstack.org/147504 | 10:59 |
| *** jamielennox|away has joined #openstack-sahara | 11:02 | |
| *** jamielennox|away is now known as jamielennox | 11:02 | |
| *** egafford has joined #openstack-sahara | 11:06 | |
| *** jamielennox has quit IRC | 11:14 | |
| *** jamielennox|away has joined #openstack-sahara | 11:24 | |
| *** jamielennox|away is now known as jamielennox | 11:24 | |
| *** sreshetn1 has joined #openstack-sahara | 11:35 | |
| SergeyLukjanov | elmiko, ping | 11:37 |
| SergeyLukjanov | elmiko, I'd like to discuss WADL stuff we were talking about in early Kilo release | 11:37 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Move updating provision progress to conductor https://review.openstack.org/159421 | 11:38 |
| SergeyLukjanov | elmiko, due to the our project status we need to make it already and there is a bug for it https://bugs.launchpad.net/openstack-api-site/+bug/1430860 | 11:38 |
| openstack | Launchpad bug 1430860 in openstack-api-site "Sahara project does not have API docs on the API Reference page at http://developer.openstack.org/api-ref.html" [High,Confirmed] | 11:38 |
| SergeyLukjanov | elmiko, will you be able to do it soon? if have no time for it we could try to find volunteers | 11:39 |
| *** Poornima has quit IRC | 11:40 | |
| *** Longgeek has joined #openstack-sahara | 12:15 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Implement poll util and plugin poll util https://review.openstack.org/157392 | 12:20 |
| *** tmckay has quit IRC | 12:23 | |
| *** chlong has joined #openstack-sahara | 12:24 | |
| openstackgerrit | Nikolay Starodubtsev proposed openstack/sahara: Take back upstream checks for import order https://review.openstack.org/163021 | 12:27 |
| openstackgerrit | Nikolay Starodubtsev proposed openstack/sahara: Rewrite malformed imports order https://review.openstack.org/163123 | 12:27 |
| *** Longgeek has quit IRC | 12:31 | |
| *** macjack has quit IRC | 12:32 | |
| *** sreshetn1 has quit IRC | 12:33 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages of poll util for service modules https://review.openstack.org/163463 | 12:37 |
| *** chandankumar has quit IRC | 12:40 | |
| *** Networkn3rd has quit IRC | 12:43 | |
| *** sreshetn1 has joined #openstack-sahara | 12:44 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Switch to v2 version of novaclient https://review.openstack.org/163802 | 12:45 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages of plugin poll - part 2 https://review.openstack.org/160818 | 12:47 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages of plugin poll - part 1 https://review.openstack.org/160769 | 12:47 |
| *** hdd_ has joined #openstack-sahara | 12:47 | |
| *** _crobertsrh is now known as crobertsrh | 12:54 | |
| openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Global refactoring of CI scripts https://review.openstack.org/162102 | 12:54 |
| *** sreshetn1 has quit IRC | 12:55 | |
| elmiko | SergeyLukjanov: lol, i was just talking with annegentle at the api-wg meeting yesterday about this | 12:57 |
| elmiko | SergeyLukjanov: i can generate the WADL, i just need to know a little more about the time frame. | 12:57 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages for step_type field https://review.openstack.org/162997 | 13:01 |
| *** sreshetn1 has joined #openstack-sahara | 13:01 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages for step_type field https://review.openstack.org/162997 | 13:02 |
| *** Nikolay_St has quit IRC | 13:05 | |
| openstackgerrit | Merged openstack/sahara: check solr availability integration testing without add skip_test https://review.openstack.org/161287 | 13:07 |
| *** skolekonov has joined #openstack-sahara | 13:11 | |
| *** tmckay has joined #openstack-sahara | 13:20 | |
| tmckay | vgridnev, SergeyLukjanov, ping | 13:24 |
| tmckay | Question about translation | 13:24 |
| tmckay | I was uncertain whether to use translate in the template CLI .... | 13:24 |
| tmckay | Lots of log messages, but it's not part of the "main" application. Similar question as python-saharaclient -- in the case of the client, it's a separate repo, so maybe that's why translation is not done there? Or is it because it's a separate tool? | 13:25 |
| crobertsrh | Good question. | 13:34 |
| tmckay | crobertsrh, I just posted a comment on delete in https://review.openstack.org/#/c/163649/4/sahara/db/templates/cli.py | 13:35 |
| tmckay | crobertsrh, the question is how powerful delete should be. We have to provide a way to remove the defaults. | 13:35 |
| crobertsrh | What do you mean by "how powerful"? | 13:36 |
| tmckay | crobertsrh, 2 basic options, and then subptions :) Basic options are 1) do not provide delete, only supply "clear default" and let delete happen through normal channels after a clear | 13:36 |
| crobertsrh | ok...reading comment for more | 13:36 |
| tmckay | 2) provide delete. I like this better | 13:36 |
| crobertsrh | Oh, for sure, #2 +1 | 13:37 |
| tmckay | crobertsrh, current delete just finds anything with is_default=True and deletes it (pruned by plugin/version options) | 13:37 |
| elmiko | yea, 2 seems way easier and cleaner | 13:37 |
| tmckay | elmiko, crobertsrh, in the comment I said that current code is not consistent operation. upgrade uses the directory structure to define the sets, but delete is a firehose | 13:38 |
| tmckay | I think delete should use the directory structure to define a set to delete by name | 13:38 |
| elmiko | tmckay: might be nice to have a little more control over the delete, in terms of specifying a template | 13:38 |
| elmiko | interesting thought, that keeps it consistent to the user | 13:39 |
| tmckay | elmiko, yeah, I was going to add a "by name or id" for a specific delete | 13:39 |
| crobertsrh | Hmm, maybe some params to specify how much to delete....maybe by names, or maybe a --all | 13:39 |
| tmckay | elmiko, other option is to *only* allow "by name or id" | 13:39 |
| tmckay | firehose option is bad, I decided | 13:39 |
| elmiko | agreed about firehose | 13:39 |
| elmiko | would be cool if you could allow name, id, or path | 13:40 |
| tmckay | elmiko, I can. But for path -- should it be limited to a specific path for an individual file, or for a directory? Because a set is defined by directory. | 13:40 |
| tmckay | this is so that cluster templates can reference node group templates by name in the same set | 13:41 |
| tmckay | the dirrectory draws a box around the file set to consider | 13:41 |
| tmckay | trying to get my head into the "end user" case | 13:41 |
| elmiko | i think for the path option is should be consistent with the way a path is specified for input | 13:42 |
| tmckay | elmiko, crobertsrh, basically the idea is that the "process_files" method which is used for update would be called, and return a set of json templates. Delete would look for those names in the specified tenant and delete. So on an empty database, upgrade followed by delete with the same arguments would be inverse operations. | 13:43 |
| elmiko | but yea, i guess we should step back and think about when someone will want to do a delete | 13:43 |
| tmckay | elmiko, probably not very often. But, I can't in good conscience make something that is "add or modify only" :) | 13:43 |
| elmiko | agreed | 13:44 |
| tmckay | crobertsrh, elmiko, lets say that someone has a site where they use vanilla plugin | 13:44 |
| tmckay | they start with 1.2.1 | 13:44 |
| tmckay | later they move all applications to hadoop 2 | 13:44 |
| tmckay | so, they want to remove the default templates for vanilla 1.2.1 | 13:45 |
| tmckay | It would look like this: | 13:45 |
| tmckay | sahara-templates --config-file myconfig delete -t $TENANT -p vanilla -pv 1.2.1 -d template_directory | 13:45 |
| tmckay | template_directory is defaulted to the Sahara bundled dir | 13:45 |
| tmckay | oh, and maybe a -r for recursive. Haven't quite decided whether that should be true or false by default | 13:46 |
| crobertsrh | Hmm, is this making things too complex again? | 13:47 |
| tmckay | elmiko, crobertsrh, the way I have it written currently, there is no directory spec, only -p vanilla -pv 1.2.1 | 13:48 |
| tmckay | crobertsrh, might be | 13:48 |
| tmckay | but I can see the use case, of retiring a plugin, or retiring a plugin version | 13:48 |
| elmiko | hmm | 13:48 |
| *** mikehn_ has quit IRC | 13:48 | |
| crobertsrh | Yeah, I suppose | 13:48 |
| elmiko | yea, it's starting to look complicated | 13:48 |
| crobertsrh | But is it the 99% use case? | 13:48 |
| crobertsrh | Maybe delete all for given plugin? | 13:49 |
| *** mikehn has joined #openstack-sahara | 13:49 | |
| crobertsrh | nah, it probably has to be version or nothing, eh? | 13:49 |
| tmckay | well, the other option is "delete --id [id [id ....]" or "delete --name [name [name...]]" | 13:49 |
| tmckay | and the admin would just have to use the client or REST to find the list they want to get rid of | 13:50 |
| tmckay | is that simple enough ? ^^ and not too burdensome? | 13:50 |
| elmiko | if we follow other delete operations in sahara, shouldn't we stick to delete by id? | 13:50 |
| tmckay | elmiko, I thought client allowed name, could be wrong. Whatever it does, yes. | 13:51 |
| crobertsrh | maybe that's enough | 13:52 |
| elmiko | tmckay: yea, my point was more sticking to what we do already | 13:52 |
| tmckay | hmm, maybe a "list ids" operation as a convenience, so you can list all the ids for a plugin/version, and then call delete on them by hand (or script?) | 13:52 |
| tmckay | and I suppose there should be delete-cluster-template and delete-node-group-template as separate ops | 13:53 |
| SergeyLukjanov | elmiko, okay, I'll investigate what's the preferred time frame for doing it | 13:54 |
| elmiko | SergeyLukjanov: thanks, you can assign the bug to me. i already subscribed | 13:55 |
| tmckay | elmiko, crobertsrh, alright. What if keep the current delete, but require --plugin-name --plugin-version. No defaults, you have to be specific. All default temps in the tenant for that plugin/version get delete. | 13:55 |
| SergeyLukjanov | elmiko, ack, thx | 13:55 |
| elmiko | SergeyLukjanov: well, assuming they don't want something by next week ;) | 13:55 |
| tmckay | then I add a by_id for each type. | 13:55 |
| elmiko | tmckay: if i do by id, do i need plugin-name plugin-version? | 13:56 |
| tmckay | nope | 13:56 |
| tmckay | If you do it by id, I assume you meant it. | 13:57 |
| elmiko | cool | 13:57 |
| tmckay | This seems like a sane compromise. You can remove a plugin or plugin/version, or you can "cherry-destroy" | 13:58 |
| tmckay | well, sorry, only a plugin/version | 13:58 |
| elmiko | so i can't do a whole plugin, or i can? | 13:59 |
| tmckay | or, maybe a plugin. yeah, you should be able to wipe out a whole plugin if you like | 13:59 |
| elmiko | but not a whole version, that might not make sense | 13:59 |
| tmckay | elmiko, thinking out loud as you can see :) Yes, a whole plugin. | 13:59 |
| elmiko | sometimes you gotta talk it out =) | 13:59 |
| tmckay | absolutely, elmiko, crobertsrh thanks for your time. | 14:00 |
| tmckay | elmiko, I need Eliza from the early 90s. "How do you feel about deleting default templates?" | 14:00 |
| tmckay | "Did your parents have default templates?" | 14:01 |
| elmiko | lol | 14:01 |
| tmckay | SergeyLukjanov, oh, should log strings in the sahara-templates CLI be translated? | 14:01 |
| tmckay | I wasn't sure, separate app, same repo | 14:02 |
| SergeyLukjanov | hm | 14:02 |
| SergeyLukjanov | tmckay, it's a helper app, so, I presume that it shouldn't be translated | 14:03 |
| tmckay | SergeyLukjanov, okay, Nik posted "please translate" comments | 14:04 |
| SergeyLukjanov | tmckay, actually it's a good question | 14:05 |
| *** Nikolay_St has joined #openstack-sahara | 14:05 | |
| SergeyLukjanov | tmckay, IMO users will be administrators and this tool will be used most probably in some automations | 14:06 |
| SergeyLukjanov | tmckay, and it'll not be shown from the API itself | 14:06 |
| SergeyLukjanov | tmckay, so, I have a feeling that we don't need translations in default templates ops cli | 14:06 |
| tmckay | SergeyLukjanov, agreed. Okay, I'll leave it untranslated for now, maybe an email to the dev-list when it's more complete (and you can ping Nik) | 14:07 |
| SergeyLukjanov | Nikolay_St, ping ^^ | 14:08 |
| Nikolay_St | SergeyLukjanov: I'm here | 14:08 |
| tmckay | oh, hi! I missed your nick | 14:08 |
| tmckay | sorry :) | 14:08 |
| Nikolay_St | tmckay: that's ok | 14:08 |
| tmckay | Nikoly_St, are you okay with no translation? Kind of a gray area for a helper app. | 14:11 |
| tmckay | Nikolay_St, that is | 14:11 |
| Nikolay_St | tmckay: one minute please | 14:12 |
| Nikolay_St | tmckay: yeap, no problem. we don't have a word about translation in Sahara or general spec for logging | 14:13 |
| tmckay | Nikolay_St, okay, thanks | 14:13 |
| Nikolay_St | tmckay: so, if you think that's ok I agree | 14:13 |
| Nikolay_St | tmckay: np | 14:13 |
| Nikolay_St | tmckay: if you need help with anything just send me a message :) | 14:14 |
| tmckay | Nikolay_St, okay, will do. I looked through the list to see if you were here but I missed your name. Forgot which time zone you like to be in :) | 14:15 |
| *** Longgeek has joined #openstack-sahara | 14:15 | |
| *** sreshetn1 has quit IRC | 14:19 | |
| *** Nikolay_St has quit IRC | 14:23 | |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Add validation in new integration tests https://review.openstack.org/151680 | 14:28 |
| *** Networkn3rd has joined #openstack-sahara | 14:36 | |
| *** Nikolay_St has joined #openstack-sahara | 14:40 | |
| openstackgerrit | Merged openstack/sahara: Node Groups now have id field https://review.openstack.org/163812 | 14:44 |
| *** Longgeek has quit IRC | 14:49 | |
| *** tnovacik has quit IRC | 15:14 | |
| *** skolekonov has quit IRC | 15:36 | |
| *** Nikolay_St has quit IRC | 15:47 | |
| *** logan2 has joined #openstack-sahara | 15:54 | |
| *** sreshetn1 has joined #openstack-sahara | 15:55 | |
| *** egafford has quit IRC | 16:12 | |
| *** Longgeek has joined #openstack-sahara | 16:34 | |
| *** sreshetn1 has quit IRC | 16:42 | |
| *** Longgeek has quit IRC | 16:56 | |
| *** Networkn3rd has quit IRC | 17:03 | |
| *** Networkn3rd has joined #openstack-sahara | 17:06 | |
| *** Networkn3rd has quit IRC | 17:09 | |
| *** Networkn3rd has joined #openstack-sahara | 17:13 | |
| *** Networkn3rd has quit IRC | 17:15 | |
| *** Networkn3rd has joined #openstack-sahara | 17:19 | |
| *** Networkn3rd has quit IRC | 17:21 | |
| *** Networkn3rd has joined #openstack-sahara | 17:26 | |
| *** Networkn3rd has quit IRC | 17:26 | |
| *** Networkn3rd has joined #openstack-sahara | 17:26 | |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Changing method for verifying existence of cinder https://review.openstack.org/164274 | 17:27 |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Changing method for verifying existence of cinder https://review.openstack.org/164274 | 17:29 |
| openstackgerrit | Trevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates https://review.openstack.org/163649 | 17:30 |
| openstackgerrit | Trevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates https://review.openstack.org/163649 | 17:30 |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: [WIP] Don't use middleware params for client auth https://review.openstack.org/163873 | 17:53 |
| *** Longgeek has joined #openstack-sahara | 17:53 | |
| openstackgerrit | Trevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates https://review.openstack.org/163649 | 17:58 |
| *** bandarji has joined #openstack-sahara | 18:00 | |
| elmiko | SergeyLukjanov: for some reason i cannot assign this bug to myself, https://bugs.launchpad.net/sahara/+bug/1431944 , would you mind assigning it to me | 18:01 |
| openstack | Launchpad bug 1431944 in Sahara "Swift passwords should use key manager interface" [Undecided,New] | 18:01 |
| crobertsrh | elmiko: weird, I was able to assign it to you | 18:02 |
| elmiko | crobertsrh: weird, thanks! | 18:02 |
| elmiko | so bizarre, i can modify all details except the assigned to column | 18:02 |
| crobertsrh | maybe due to "security" tab?? | 18:03 |
| crobertsrh | not tab, but tag | 18:03 |
| crobertsrh | but it doesn't make sense that I could do anything with it | 18:03 |
| elmiko | that's what i was thinking, i marked it as public security as well | 18:03 |
| tmckay | crobertsrh, oh, it occurred to me that we need to allow "copy" of a default template, without copying the "is_default" fields :) | 18:03 |
| elmiko | tmckay: that makes sense | 18:04 |
| tmckay | crobertsrh, so that you can use one as a base for your own playtime | 18:04 |
| crobertsrh | tmckay: Ah, yes...that would make sense | 18:04 |
| tmckay | not sure if that needs to happen on the UI side or I can handle it in Sahara proper. | 18:04 |
| tmckay | I'll try the latter ... gravy | 18:04 |
| crobertsrh | I think "proper" | 18:04 |
| crobertsrh | I can take a peek at it if you're swamped | 18:05 |
| crobertsrh | Oh, hmmm | 18:06 |
| tmckay | crobertsrh, hmm, the trick would be to notice the is_default before validation on a create and erase it. But, that's not maybe what was intended. Someone maybe was really trying to create a default through the wrong channel. | 18:06 |
| tmckay | maybe we don't support copy | 18:07 |
| crobertsrh | Right because a "copy" is really just a create | 18:07 |
| crobertsrh | Actually, I don't think the UI "copy" would pass the "is_default" flag back down | 18:08 |
| tmckay | really? | 18:08 |
| tmckay | it will be in the result. | 18:08 |
| tmckay | do you only copy fields you know about? | 18:08 |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: [WIP] Don't use middleware params for client auth https://review.openstack.org/163873 | 18:09 |
| crobertsrh | There's nothing in the client library that knows about it, right? | 18:09 |
| tmckay | hmm, right. Well the client fail, or throw it away? | 18:09 |
| crobertsrh | The nodegroup_template_create method in there knows nothing about is_default | 18:09 |
| tmckay | well -> will | 18:10 |
| crobertsrh | I suspect the default behavior is to totally ignore it. | 18:10 |
| crobertsrh | it would be in the object that we get back, but the UI won't even bother with it. | 18:11 |
| tmckay | elmiko, crobertsrh, minor detail, should recurse be default, or no recurse? If you want the simplest command with bundhed templates from Sahara, it would be "sahara-templates --config-file blah update -t tenantid" | 18:11 |
| crobertsrh | At some point, I could make it look at the flag to gray-out the edit/delete functionality | 18:11 |
| tmckay | that would start at the sahara default dir and process everything | 18:11 |
| elmiko | tmckay: that seems reasonable given there are options to make it more specific | 18:12 |
| crobertsrh | I think default to recurse...that would give the simplest command to get people started | 18:12 |
| tmckay | okay, I have to reverse that. Thanks. | 18:12 |
| crobertsrh | If someone wants to be more than just basic, then they should have to add extra stuff | 18:12 |
| *** IBerezovskiy has quit IRC | 18:16 | |
| *** Longgeek has quit IRC | 18:22 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: [WIP] Run terminating cluster in separate thread https://review.openstack.org/164299 | 18:48 |
| *** vgridnev_ has joined #openstack-sahara | 18:50 | |
| vgridnev_ | folks, hi. Can someone review this patches: https://review.openstack.org/#/c/159758/ https://review.openstack.org/#/c/162118/ | 18:54 |
| elmiko | vgridnev_: i'll take another look | 18:55 |
| vgridnev_ | no reviews for 2 days, looks really strange for sahara | 18:55 |
| elmiko | hehe, yea | 18:55 |
| tosky | vgridnev_: it's basically the same code for two different versions, couldn't it be factored out in a common function somewhere? | 18:57 |
| tosky | maybe useful also for other plugins | 18:57 |
| elmiko | tosky: nice idea | 18:58 |
| vgridnev_ | it has, but i can't | 18:58 |
| vgridnev_ | we have _mount_volume | 18:58 |
| tosky | I don't see it in the new piece of code | 18:59 |
| vgridnev_ | you are talking about 159758? | 18:59 |
| tosky | sorry, about https://review.openstack.org/#/c/162118/ | 19:00 |
| *** hdd_ has quit IRC | 19:00 | |
| vgridnev_ | I can move to separate utils module under hdp folder | 19:01 |
| tosky | yep, that would be good - less code duplication | 19:02 |
| vgridnev_ | ok | 19:02 |
| elmiko | maybe put it in sahara.plugins.hdp.saharautils ? | 19:03 |
| elmiko | ah, maybe that doesn't make sense | 19:03 |
| vgridnev_ | elmiko, ok | 19:03 |
| elmiko | vgridnev_: it may make more sense to create sahara.plugins.hdp.versions.utils | 19:04 |
| elmiko | up to you | 19:04 |
| elmiko | other than tosky's suggestion, it's lgtm | 19:05 |
| vgridnev_ | In patch 1 it was under cluster_spec, were most of validations are done. But it cause about 80 unit tests failures | 19:05 |
| elmiko | ouch | 19:06 |
| tosky | maybe the unit tests could need some fix - why were they failing? Behavior change? But it could have been correc | 19:06 |
| tosky | correct* | 19:06 |
| tosky | maybe | 19:06 |
| * tosky needs to go | 19:07 | |
| vgridnev_ | unit tests thinks, that it's ok to create cluster with number of datanodes < dfs.replication | 19:07 |
| tosky | then maybe they are not exactly reliable :D | 19:07 |
| tosky | I would defer to elmiko, but I think that maybe the initial approach could be good if the unit tests are adapted | 19:07 |
| tosky | but I'm a QE, I don't know that code | 19:08 |
| * tosky really runs | 19:08 | |
| *** tosky has quit IRC | 19:08 | |
| elmiko | lol | 19:08 |
| *** Nikolay_St has joined #openstack-sahara | 19:12 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Implement poll util and plugin poll util https://review.openstack.org/157392 | 19:38 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages of plugin poll - part 2 https://review.openstack.org/160818 | 19:38 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: [HDP] Add validation check for dfs.replication https://review.openstack.org/162118 | 19:50 |
| *** Longgeek has joined #openstack-sahara | 19:50 | |
| openstackgerrit | Trevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates https://review.openstack.org/163649 | 19:53 |
| *** sreshetn1 has joined #openstack-sahara | 19:59 | |
| *** hdd_ has joined #openstack-sahara | 20:03 | |
| *** Longgeek has quit IRC | 20:18 | |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Changing method for verifying existence of cinder https://review.openstack.org/164274 | 20:26 |
| *** sreshetn1 has quit IRC | 20:30 | |
| *** tnovacik has joined #openstack-sahara | 20:31 | |
| openstackgerrit | Trevor McKay proposed openstack/sahara: Add a CLI tool for managing default templates https://review.openstack.org/163649 | 20:34 |
| *** sreshetn1 has joined #openstack-sahara | 20:37 | |
| *** crobertsrh is now known as _crobertsrh | 20:43 | |
| *** tmckay has quit IRC | 20:45 | |
| *** sgotliv has quit IRC | 20:58 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Run terminating transient clusters in separate thread https://review.openstack.org/164299 | 21:09 |
| *** Networkn3rd has quit IRC | 21:18 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add usages for step_type field https://review.openstack.org/162997 | 21:21 |
| *** sreshetn1 has quit IRC | 21:22 | |
| *** tnovacik has quit IRC | 21:29 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Move updating provision progress to conductor https://review.openstack.org/159421 | 21:41 |
| *** vgridnev_ has quit IRC | 21:41 | |
| *** Longgeek has joined #openstack-sahara | 22:03 | |
| *** Longgeek has quit IRC | 22:25 | |
| *** hdd_ has quit IRC | 23:06 | |
| *** bandarji has quit IRC | 23:08 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!