| *** shakamunyi has joined #openstack-sahara | 00:31 | |
| *** shakamunyi has quit IRC | 00:37 | |
| *** IlyaE has quit IRC | 00:43 | |
| *** IlyaE has joined #openstack-sahara | 01:06 | |
| *** RockKuo_ has joined #openstack-sahara | 01:11 | |
| *** tmckay has joined #openstack-sahara | 01:19 | |
| *** tmckay has quit IRC | 01:37 | |
| *** akuznetsov has joined #openstack-sahara | 04:41 | |
| *** akuznetsov has joined #openstack-sahara | 04:51 | |
| *** IlyaE has quit IRC | 05:02 | |
| *** IlyaE has joined #openstack-sahara | 05:50 | |
| openstackgerrit | Jenkins proposed a change to openstack/sahara: Imported Translations from Transifex https://review.openstack.org/86507 | 06:06 |
|---|---|---|
| *** skolekonov has joined #openstack-sahara | 06:13 | |
| *** IlyaE has quit IRC | 07:44 | |
| *** witlessb has joined #openstack-sahara | 07:48 | |
| *** witlessb has quit IRC | 07:48 | |
| *** witlessb has joined #openstack-sahara | 07:49 | |
| openstackgerrit | Vadim Rovachev proposed a change to openstack/sahara: Add tenant_id getting in integration tests https://review.openstack.org/84781 | 09:28 |
| *** tosky has joined #openstack-sahara | 10:00 | |
| *** _crobertsrh is now known as crobertsrh | 11:16 | |
| *** RockKuo_ has quit IRC | 11:46 | |
| openstackgerrit | A change was merged to openstack/sahara-image-elements: Add RHEL as an expected platform https://review.openstack.org/86977 | 12:05 |
| openstackgerrit | A change was merged to openstack/sahara-image-elements: Reformat the usage message https://review.openstack.org/86986 | 12:06 |
| openstackgerrit | A change was merged to openstack/sahara-image-elements: Refactor logic around selinux bug 1204824 https://review.openstack.org/86987 | 12:06 |
| *** skolekonov has quit IRC | 12:54 | |
| *** elmiko has joined #openstack-sahara | 13:10 | |
| openstackgerrit | A change was merged to openstack/sahara: Add *.log files to gitignore https://review.openstack.org/86522 | 13:22 |
| *** tmckay has joined #openstack-sahara | 13:27 | |
| *** sballe has joined #openstack-sahara | 13:40 | |
| *** witlessb has quit IRC | 14:06 | |
| *** witlessb has joined #openstack-sahara | 14:08 | |
| *** witlessb has quit IRC | 14:11 | |
| *** witlessb has joined #openstack-sahara | 14:12 | |
| *** witlessb has quit IRC | 14:16 | |
| *** witlessb has joined #openstack-sahara | 14:17 | |
| *** bob_nettleton has joined #openstack-sahara | 14:38 | |
| *** bob_nettleton has quit IRC | 14:39 | |
| *** ErikB has joined #openstack-sahara | 14:40 | |
| *** IlyaE has joined #openstack-sahara | 14:51 | |
| *** bob_nettleton has joined #openstack-sahara | 15:06 | |
| *** bob_nettleton has quit IRC | 15:28 | |
| *** coolsvap1 has joined #openstack-sahara | 16:02 | |
| *** coolsvap1 has quit IRC | 16:03 | |
| *** coolsvap1 has joined #openstack-sahara | 16:04 | |
| *** coolsvap1 has quit IRC | 16:08 | |
| *** IlyaE has quit IRC | 16:09 | |
| *** akuznetsov has quit IRC | 16:19 | |
| *** akuznetsov has joined #openstack-sahara | 16:31 | |
| openstackgerrit | Andrew Lazarev proposed a change to openstack/sahara: Added support of multi-region environment https://review.openstack.org/79795 | 16:56 |
| *** IlyaE has joined #openstack-sahara | 17:58 | |
| *** IlyaE has quit IRC | 18:23 | |
| *** bob_nettleton has joined #openstack-sahara | 18:30 | |
| *** IlyaE has joined #openstack-sahara | 18:40 | |
| elmiko | crobertsrh: ping | 18:47 |
| crobertsrh | yes? | 18:47 |
| elmiko | in sahara.service.validations.edp.job.JOB_SCHEMA, do you know if the ordering of the job types matters? | 18:48 |
| crobertsrh | Order should not matter. | 18:49 |
| elmiko | ok, we might have a test that is getting fussy about the order. i'm gonna dig a little more | 18:49 |
| crobertsrh | Seems like it would be a bad idea to rely on the order there. | 18:49 |
| elmiko | i'm trying to do a little refactor on the edp-job-type-constants and i'm running into interesting stuff when i create a list of all job types and then start using it in the code base | 18:50 |
| *** tosky has quit IRC | 18:52 | |
| crobertsrh | Ah...ok. I think Trevor found an oddity or two with some of the validation code before, so there could be something nasty lurking. | 18:53 |
| elmiko | lol, thanks for the heads up | 18:53 |
| elmiko | we'll see how deep the rabbit hole goes... | 18:53 |
| *** tellesnobrega has joined #openstack-sahara | 18:56 | |
| elmiko | i need some help on this one. could someone explain test_jar_rejected in sahara/tests/unit/service/validation/edp/test_job.py? | 19:26 |
| elmiko | and more to the point, why does changing the job type ordering in sahara.service.validation.edp.job.JOB_SCHEMA make it fail? | 19:27 |
| tmckay | elmiko, I'll take a look at the test ... | 19:29 |
| elmiko | tmckay: thanks | 19:30 |
| elmiko | i'm quite stumped why changing that schema order would matter | 19:30 |
| tmckay | my head is swimming from reviews ... | 19:30 |
| tmckay | k, this will be fun | 19:30 |
| *** tosky has joined #openstack-sahara | 19:30 | |
| elmiko | yea, it touches a lot of code | 19:32 |
| tmckay | elmiko, okay, so the point of the test is that "Jar" was the original name for "MapReduce", and for a while we supported it as a synonym. It got weird when we added Java actions ... what the heck is jar? | 19:32 |
| tmckay | that's the point. as to why order matters, I'll keep looking ... | 19:32 |
| elmiko | my thought is it has something to do with the validate decoration that occurs in sahara.tests.unit.service.validation.utils.ValidationTestCase._assert_create_object_validation | 19:34 |
| *** bob_nettleton has quit IRC | 19:34 | |
| elmiko | but i don't know these functions that well, so i'm having to read a lot to figure out what they are supposed to do | 19:35 |
| tmckay | elmiko, so what order change did you make? | 19:38 |
| elmiko | i tried a bunch, but just swap the order of pig and hive | 19:39 |
| tmckay | in what, the json schema? | 19:39 |
| elmiko | yes | 19:39 |
| elmiko | well, in JOB_SCHEMA["properties | 19:40 |
| elmiko | "]["type"]["enum"] | 19:40 |
| tmckay | ah | 19:41 |
| tmckay | k, the validation stuff is somewhat builtin | 19:41 |
| tmckay | The junk that is testing the json is producing the exception message based on the order | 19:41 |
| tmckay | We are asserting that the exception message matches the literal text in the test ... | 19:42 |
| elmiko | right | 19:42 |
| tmckay | but the order of the enum determines what the json checker will spit out | 19:42 |
| tmckay | so all we have to do is change the text in the test | 19:42 |
| elmiko | hmm, where is the text of the test? | 19:42 |
| tmckay | Not much of a way around that, unless we find a way to generalize the test and not look at the specific message | 19:42 |
| tmckay | bad_req_i=(1, "VALIDATION_ERROR", | 19:43 |
| tmckay | "'Jar' is not one of " | 19:43 |
| tmckay | "['Pig', 'Hive', 'MapReduce', " | 19:43 |
| tmckay | "'MapReduce.Streaming', 'Java']")) | 19:43 |
| elmiko | oh, ok. that text | 19:43 |
| tmckay | end of test_jar_rejected | 19:43 |
| tmckay | :) | 19:43 |
| tmckay | all we have to do is make that message match | 19:43 |
| tmckay | so the order should just match whatever your enum order is | 19:43 |
| elmiko | we should just be able to use "'Jar' is note one of " + edp.JOB_TYPES_ALL, or some such | 19:43 |
| elmiko | or str(edp.JOB_TYPES_ALL) or something | 19:44 |
| tmckay | you, with a join() maybe | 19:44 |
| tmckay | what? you? that makes no sense | 19:44 |
| tmckay | but I think you're on the right track | 19:44 |
| elmiko | good spot, i was deep into how we are decorting mock.Mock() lol | 19:45 |
| tmckay | lol, yeah, sometimes the simple things are really simple | 19:45 |
| elmiko | i didn't even recognize the order was the same as the error output | 19:45 |
| * elmiko facepalm | 19:45 | |
| tmckay | np, I've been taken to school by unit tests more than once | 19:46 |
| tmckay | you develop a sick intuition for what is happening | 19:46 |
| tmckay | that was way more fun than reviews | 19:46 |
| elmiko | yea, my python intuition has not fully blossomed yet ;) | 19:46 |
| tmckay | well, I wouldn't even say python in this case ... flask json validation is closer, I think | 19:47 |
| tmckay | personally, mock decorators make me dizzy | 19:48 |
| elmiko | ok, i never played with the json validation in flask | 19:48 |
| elmiko | i didn't even realize it had that type of validation | 19:48 |
| elmiko | lol, ok yep, add str(edp.JOB_TYPES_ALL) to the end of that messge fixed it | 19:49 |
| tmckay | elmiko, cool. to be honest, I don't know how much of this stuff is provided by flask, and how much was written as part of sahara. I've never drilled that deep | 19:50 |
| openstackgerrit | Michael McCune proposed a change to openstack/sahara: Implementing constants for the job types used by EDP https://review.openstack.org/80352 | 19:51 |
| elmiko | i've played with flask a bunch, but usually for making website not so much the rest side of things | 19:51 |
| elmiko | i can see where json validation is really important for rest stuff | 19:51 |
| tmckay | looks like it might be coming from python-jsonschema | 19:51 |
| elmiko | ahh ok | 19:51 |
| tmckay | so maybe not flask per se | 19:52 |
| *** akuznetsov has quit IRC | 20:11 | |
| *** akuznetsov has joined #openstack-sahara | 20:20 | |
| *** akuznetsov has quit IRC | 20:22 | |
| *** ErikB has quit IRC | 20:56 | |
| *** ErikB has joined #openstack-sahara | 21:00 | |
| *** crobertsrh is now known as _crobertsrh | 21:00 | |
| *** witlessb has quit IRC | 21:06 | |
| *** ErikB has quit IRC | 21:27 | |
| *** ErikB has joined #openstack-sahara | 21:48 | |
| *** akuznetsov has joined #openstack-sahara | 22:34 | |
| *** akuznetsov has quit IRC | 22:37 | |
| *** IlyaE has quit IRC | 23:07 | |
| *** elmiko has quit IRC | 23:35 | |
| *** IlyaE has joined #openstack-sahara | 23:42 | |
| *** elmiko has joined #openstack-sahara | 23:45 | |
| *** sballe has quit IRC | 23:46 | |
| *** tosky has quit IRC | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!