*** ykarel has joined #openstack-rpm-packaging | 02:53 | |
*** gkadam has joined #openstack-rpm-packaging | 03:19 | |
*** gkadam has quit IRC | 04:21 | |
*** ykarel has quit IRC | 04:47 | |
*** ykarel has joined #openstack-rpm-packaging | 05:04 | |
*** openstackgerrit has joined #openstack-rpm-packaging | 06:51 | |
openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging master: openstackdocstheme: Update to 1.28.0 https://review.openstack.org/624935 | 06:51 |
---|---|---|
openstackgerrit | Merged openstack/rpm-packaging master: stevedore: Use pytest instead of stestr to break build cycle https://review.openstack.org/632066 | 07:12 |
*** pcaruana has joined #openstack-rpm-packaging | 07:41 | |
*** gkadam has joined #openstack-rpm-packaging | 07:51 | |
*** ykarel is now known as ykarel|lunch | 08:06 | |
*** jpena|off is now known as jpena | 08:56 | |
*** ykarel|lunch is now known as ykarel | 08:57 | |
*** jpich has joined #openstack-rpm-packaging | 09:01 | |
*** jpich has quit IRC | 09:02 | |
*** jpich has joined #openstack-rpm-packaging | 09:04 | |
openstackgerrit | Javier Peña proposed openstack/rpm-packaging master: openstacksdk: Update to 0.23.0 https://review.openstack.org/625117 | 09:15 |
ykarel | cool final new tag released for openstacksdk | 09:31 |
*** sum12 has quit IRC | 09:43 | |
*** sum12 has joined #openstack-rpm-packaging | 09:44 | |
*** ykarel_ has joined #openstack-rpm-packaging | 10:25 | |
*** ykarel has quit IRC | 10:26 | |
*** ykarel_ is now known as ykarel | 10:42 | |
openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging master: remove unnecessary PYTHONPATH setting https://review.openstack.org/632413 | 11:03 |
*** jpena is now known as jpena|lunch | 12:43 | |
*** ykarel is now known as ykarel|afk | 13:08 | |
*** ykarel|afk has quit IRC | 13:12 | |
*** ykarel|afk has joined #openstack-rpm-packaging | 13:31 | |
*** ykarel|afk is now known as ykarel | 13:33 | |
*** sum12 has quit IRC | 13:33 | |
*** jpena|lunch is now known as jpena | 13:47 | |
*** sum12 has joined #openstack-rpm-packaging | 14:11 | |
*** eggmaster is now known as eggs | 14:56 | |
openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging master: remove unnecessary PYTHONPATH setting https://review.openstack.org/632413 | 15:35 |
dirk | cmurphy: toabctl : can I get a quick review on ^^ ? Factory reviewers don't want to check it in with the typo.. | 15:36 |
toabctl | dirk, done | 15:36 |
cmurphy | dirk: shouldn't it be PYTHONPATH=. ? | 15:37 |
toabctl | ah. true | 15:37 |
toabctl | or if PYTHONPATH= works, just remove PYTHONPATH | 15:37 |
dirk | no, removing it fails | 15:37 |
dirk | see CI failure | 15:37 |
dirk | :-) | 15:37 |
dirk | I admit I don't fully understand it | 15:37 |
dirk | I can also set it it to PYTHONPATH=pythonrocks, that also works | 15:38 |
dirk | it needs to be set, but the value doesn't matter | 15:38 |
dirk | do you like '.' more? | 15:39 |
dirk | it works as well | 15:39 |
cmurphy | if it really doesn't matter then i suppose it's fine as-is but everywhere else it's . which I was pretty sure was important | 15:40 |
openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging master: remove unnecessary PYTHONPATH setting https://review.openstack.org/632413 | 15:40 |
dirk | now it has a dot | 15:41 |
dirk | I don't get why "" works | 15:42 |
dirk | maybe "" is expanded as "." | 15:42 |
cmurphy | it's weird that without it set it says "WARNING: Cannot find git top directory, assuming "."" | 15:43 |
toabctl | $ PYTHONPATH= python -c "import os;print(os.environ['PYTHONPATH'])" | 15:43 |
toabctl | tom@basilikum:~$ PYTHONPATH=. python -c "import os;print(os.environ['PYTHONPATH'])" | 15:43 |
toabctl | . | 15:43 |
toabctl | ^^ it's not expanded. at least not on my TW installation | 15:44 |
dirk | cmurphy: oh no, you approved it even though the commit message was wrong! I'm shocked! ;) | 15:44 |
toabctl | lol | 15:44 |
cmurphy | oops | 15:45 |
dirk | toabctl: well, the error before is setuptools | 15:45 |
dirk | e.g. it doesn't find the locally installed oslo.config | 15:46 |
dirk | sorry, not installed | 15:46 |
dirk | so I think setting PYTHONPATH=. is the right thing to do | 15:46 |
dirk | it just surprises me that PYTHONPATH="" is working | 15:46 |
toabctl | yes. I'm just wondering why setting it to nothing works. | 15:46 |
dirk | me too | 15:47 |
dirk | but since its the last blocker for the 3.7 transition, factory team wants us to fix it.. | 15:47 |
*** openstackgerrit has quit IRC | 15:51 | |
*** ykarel is now known as ykarel|away | 15:53 | |
*** openstackgerrit has joined #openstack-rpm-packaging | 15:58 | |
openstackgerrit | Merged openstack/rpm-packaging master: remove unnecessary PYTHONPATH setting https://review.openstack.org/632413 | 15:58 |
*** pcaruana has quit IRC | 17:02 | |
*** jpich has quit IRC | 17:26 | |
*** pcaruana has joined #openstack-rpm-packaging | 18:01 | |
*** ykarel|away has quit IRC | 18:09 | |
*** jpena is now known as jpena|off | 18:22 | |
*** pcaruana has quit IRC | 18:23 | |
*** gkadam has quit IRC | 18:26 | |
*** pcaruana has joined #openstack-rpm-packaging | 19:50 | |
*** pcaruana has quit IRC | 20:11 | |
*** pcaruana has joined #openstack-rpm-packaging | 20:24 | |
*** pcaruana has quit IRC | 21:19 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!