*** vnogin has joined #openstack-rpm-packaging | 01:20 | |
*** vnogin has quit IRC | 01:24 | |
*** vnogin has joined #openstack-rpm-packaging | 03:21 | |
*** vnogin has quit IRC | 03:27 | |
*** vnogin has joined #openstack-rpm-packaging | 05:24 | |
*** vnogin has quit IRC | 05:29 | |
*** pcaruana has joined #openstack-rpm-packaging | 06:50 | |
*** vnogin has joined #openstack-rpm-packaging | 11:16 | |
*** vnogin has quit IRC | 13:46 | |
*** openstackgerrit has joined #openstack-rpm-packaging | 14:50 | |
openstackgerrit | Merged openstack/rpm-packaging master: Update osc-lib to 1.6.0 https://review.openstack.org/460222 | 14:50 |
---|---|---|
openstackgerrit | Adam Spiers proposed openstack/rpm-packaging master: Add initial spec for masakari https://review.openstack.org/459879 | 15:19 |
*** vnogin has joined #openstack-rpm-packaging | 15:25 | |
dirk | aspiers: thanks. does it really not use oslo.service? | 15:47 |
dirk | that's a chance of upstream contribution! | 15:47 |
aspiers | dirk: it uses a lot of oslo stuff; not sure about oslo.service | 15:47 |
aspiers | dirk: no, it does use oslo.service. missing dependency? | 15:48 |
aspiers | no, the dependencies are there | 15:48 |
aspiers | dirk: why did you ask? | 15:49 |
dirk | aspiers: because the systemd file uses Type=simple, I think it should use a notifying type then so that systemd waits for the service to start | 15:58 |
aspiers | dirk: sounds good. is there an example I can copy? | 15:59 |
dirk | aspiers: openstack-nova-compute | 15:59 |
aspiers | dirk: thanks. BTW now I have climbed most of the rpm-packaging learning curve, it should be much easier for me to add other packages | 15:59 |
aspiers | for example, in the fictional future where I have some free time, I would like to add Watcher | 16:00 |
aspiers | it's a pretty cool project which shouldn't be hard to add and would bring some quite shiny capabilities | 16:00 |
aspiers | in the same fictional future I can also fix all Jenkins failures and rewrite SOC in ansible | 16:01 |
aspiers | I'm 13 points away from 10k reputation on StackOverflow and the suspense is killing me | 16:01 |
aspiers | dirk: I've looked in latest nova and can't find nova-compute calls to oslo_service.systemd APIs anywhere, even though they must be there | 16:17 |
aspiers | https://docs.openstack.org/developer/oslo.service/api/systemd.html | 16:17 |
aspiers | https://openstack.nimeyo.com/1990/openstack-dev-do-all-openstack-daemons-support-sd_notify | 16:19 |
aspiers | I see systemd.notify_once() in neutron though | 16:20 |
aspiers | in wsgi.py and ovs_neutron_agent.py | 16:21 |
aspiers | but none of those APIs are in masakari, so it will have to stick with Type=simple for now | 16:22 |
aspiers | but we could file a blueprint to add support, although it seems Dan Prince found some issues with sd_notify - not sure if they're resolved yet | 16:22 |
* cousin_luigi doesn't quite understand how things work between renderspec, the existing spec templates and the dist templates. | 17:33 | |
cousin_luigi | Are the dist templates only used to identify the former or also to generate them? | 17:33 |
*** apevec has joined #openstack-rpm-packaging | 18:08 | |
*** apevec has joined #openstack-rpm-packaging | 18:08 | |
dirk | cousin_luigi: what does "dist_template" refer to? | 18:20 |
cousin_luigi | dirk: https://github.com/openstack/renderspec/blob/e96e65c8c897d4d3379c24163fd79c30062eb1b2/renderspec/dist-templates/suse.spec.j2 | 18:21 |
dirk | cousin_luigi: ah, they're used for generation | 18:47 |
dirk | By default it chooses the host distribution flavor unless you're using cmdline override | 18:48 |
cousin_luigi | dirk: Ok. Suppose that I want to add a Provides line only to suse specs, do I create a new function in renderspec that converts or deletes the line {{ py2pvd(name) }} ? Or am I approaching this the wrong way? | 18:57 |
dirk | cousin_luigi: if it's always the same provides i guess you could just add it to the dist template.. | 19:11 |
*** pcaruana has quit IRC | 19:16 | |
cousin_luigi | dirk: I mean, I wanted to fix the single-spec dependency with a Provides: python2-%{name} = %{version} | 19:16 |
cousin_luigi | sorry, pypy_name | 19:16 |
cousin_luigi | or whatever | 19:16 |
cousin_luigi | dirk: Won't that require all .spec.j2 to be regenerated? | 19:16 |
dirk | cousin_luigi: ah, ok, for single spec compatibility | 19:19 |
dirk | cousin_luigi: just add it to the dist template? | 19:19 |
cousin_luigi | dirk: Plain? | 19:19 |
cousin_luigi | Will do I suppose. | 19:19 |
cousin_luigi | dirk: Do I make a fork on github and submit a pull request? How does it work? | 19:20 |
dirk | There was actually​ a discussion whether we're just going to rename to python2 globally | 19:20 |
cousin_luigi | dirk: That's going to screw up things elsewhere. | 19:20 |
cousin_luigi | Meanwhile there are packages I can't submit to factory because the redhat guys don't want to make a decision. | 19:21 |
dirk | cousin_luigi: what is currently blocked from factory submission and ehy? | 19:34 |
cousin_luigi | dirk: singlespec stuff depending on python-stevedore for example | 19:34 |
cousin_luigi | not very important, but it's my stuff, isn't it? | 19:35 |
dirk | cousin_luigi: well, I'm certainly not against making things work | 19:35 |
cousin_luigi | also other stuff I've encountered. I can find it if it's important. | 19:35 |
dirk | cousin_luigi: can you try a provides python2-{{pypiname }} ? | 19:36 |
dirk | cousin_luigi: provides python2-{{pypiname }} = %version I mean of course | 19:36 |
cousin_luigi | dirk: exactly what I meant. But I'm not sure how to proceed. | 19:36 |
cousin_luigi | dirk: Fork and pr? | 19:37 |
dirk | cousin_luigi: just post a review against renderspec or the rpm-packaging git template? | 19:37 |
cousin_luigi | dirk: I have no idea how to do that. | 19:47 |
cousin_luigi | I mean, this is how I would do it https://github.com/openstack/renderspec/compare/master...luigino:master | 19:48 |
cousin_luigi | But I'm going to have to ask some handholding for the rest. | 19:48 |
dirk | cousin_luigi: lets give it a try.. try running renderspec locally against a spec.j2 template and see what gets generated | 20:23 |
*** apevec has quit IRC | 20:26 | |
cousin_luigi | dirk: No change whatsoever. | 20:50 |
cousin_luigi | That's why I wanted an expert:/ | 20:50 |
aspiers | dirk: any chance you could do me a big favour and give me 5 mins of your keystone troubleshooting expertise? | 21:11 |
aspiers | sorry, off topic for this channel | 21:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!