| opendevreview | Riccardo Pittau proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/955421 | 07:35 |
|---|---|---|
| frickler | rpittau: ^^ that's not enough, see https://review.opendev.org/c/openstack/requirements/+/907665/108 . you can squash the stack to get a working mergeable patch | 07:45 |
| rpittau | frickler: yeah, I realized after uploading that, I'm testing it locally | 07:45 |
| *** ykarel_ is now known as ykarel | 07:52 | |
| opendevreview | Riccardo Pittau proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/955421 | 08:01 |
| rpittau | ooook this ^ should work | 08:01 |
| *** bauzas8 is now known as bauzas | 08:32 | |
| stephenfin | ralonsoh: frickler: Sorry, I forgot to open hexchat yesterday. The reason it can't find the package is because the last version of pkg_resources supported on Python 3.8 still has a bug where it is not normalizing packages names, and since January we are correctly naming wheels as e.g. oslo_foo instead of oslo.foo. | 09:38 |
| ralonsoh | stephenfin, should be use an older pkg_resources version there? only of py38 | 09:39 |
| stephenfin | ralonsoh: I'm under the impression it was always broken. We just never noticed because we weren't correctly normalizing wheels before that change in January (fungi has the specifics) | 09:40 |
| stephenfin | so I don't think there is an older version we can switch to | 09:41 |
| stephenfin | https://github.com/pypa/setuptools/issues/5051 | 09:41 |
| stephenfin | The thing I still haven't figured out is why pkg_resources is getting invoked in the first place. That should never happen. On newer versions of pip, pip itself generates console scripts and doesn't use pkg_resources. On older versions of pip, pbr overrides the distutils InstallScripts command to generate a version of the script that doesn't use pkg_resources, overriding the setuptools default | 09:43 |
| stephenfin | I'm guessing either my patch isn't actually getting used, or we're doing something like an editable install and the PEP-517 backend is getting invoked (so all the distutils logic from pbr is bypassed) but pip is somehow not generating console scripts for us as you'd expect | 09:45 |
| stephenfin | Yeah, it doesn't look like my patch is being used? Looking at log lines with timestamps 2025-07-22 08:42:53.321531 and 2025-07-22 08:48:52.426214 from the build log https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d8e/openstack/d8e3003ef09a4ae9bd504a96a6ee1dc2/job-output.txt | 09:48 |
| frickler | stephenfin: ah, your patch is for 2025.1, but the test is running against 2024.2 where the issue appears. so I think we need to backport your change to 2024.2 and test with that? it doesn't look like 2025.1 is affected, not sure why | 10:38 |
| stephenfin | Aha, good spot. I couldn't figure that out. Had assumed required_projects was unset but it was | 10:39 |
| stephenfin | I can propose the backports | 10:40 |
| stephenfin | frickler: ralonsoh: Done https://review.opendev.org/c/openstack/neutron/+/951494 Let's wait and see now | 10:45 |
| ralonsoh | stephenfin, thanks | 10:46 |
| frickler | stephenfin: why did you drop the dep on https://review.opendev.org/c/openstack/requirements/+/951735? without that we won't see the issue, or am I missing something? | 10:58 |
| stephenfin | frickler: That was a mistake, sorry. I thought the issue was reproducing in its current state. Re-added | 11:17 |
| frickler | thx. I'll set up an autohold for that job so that we can take a closer look if needed | 11:24 |
| stephenfin | frickler: Looks like that passed https://review.opendev.org/c/openstack/neutron/+/951494 | 12:38 |
| stephenfin | ralonsoh too | 12:38 |
| ralonsoh | stephenfin, so we need the revert^2 and the designate patch then | 12:39 |
| stephenfin | yes, but designate first | 12:40 |
| opendevreview | Merged openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/955421 | 16:23 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!