| opendevreview | Tony Breeds proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/906938 | 01:06 |
|---|---|---|
| opendevreview | Tony Breeds proposed openstack/requirements master: Partial Revert "Updated from generate-constraints" https://review.opendev.org/c/openstack/requirements/+/907160 | 01:10 |
| opendevreview | Merged openstack/requirements master: Update eventlet to 0.35.0 https://review.opendev.org/c/openstack/requirements/+/907048 | 02:48 |
| tkajinam | hmm. it seems eventlet 3.15 still breaks docs job in manila... | 15:00 |
| tkajinam | but it's no longer necessary. I myself didn't know this improvement until stephenfin pointed it out a while ago. | 15:00 |
| tkajinam | <stephenfin> yeah, that hasn't been the case for about 6 years now (from back while dhellmann was still working on OpenStack) | 15:00 |
| tkajinam | sorry. wrong paste | 15:00 |
| tkajinam | didin't notice these are in the clipboard X-( | 15:00 |
| tkajinam | https://zuul.opendev.org/t/openstack/build/63914f9dc9e24e1180eea22bfd92e13c | 15:00 |
| tkajinam | meant to post this | 15:00 |
| tkajinam | hberaud, ^^^ wondering if you have any idea about this error. seems monkey_patch does not work when called by autodoc ? `AttributeError: 'functools.partial' object has no attribute 'items'` | 15:01 |
| frickler | hmm, I had hoped that the fix for the ironic issue, which looked very similar, also fixed manila | 15:51 |
| JayF | Hi all o/ the latest eventlet bump broke more docs builds -- this time in Manila. https://github.com/eventlet/eventlet/pull/907 fixes the issue, if we can get eventlet to land and release a .1 and bump it, we should be able to avoid a rollback. cc: hberaud | 16:39 |
| JayF | I already pointed this out to Itamar (eventlet dev) downstream, so hopefully things will get moving :) | 16:39 |
| hberaud | Will produce a new version ASAP | 17:24 |
| JayF | Yeah, I just got a test written for it | 17:26 |
| JayF | things should be quite happier | 17:26 |
| hberaud | awesome | 17:26 |
| JayF | I think the approach on that patch should squash a whole class of this kinda bug | 17:27 |
| JayF | at the small risk of preventing us from seeing new kinds of breakages | 17:27 |
| hberaud | JayF: Please can you also update the changelog file (https://github.com/eventlet/eventlet/blob/master/NEWS)? We will win some iteration cycles | 17:27 |
| JayF | hberaud: amended the commit | 17:29 |
| hberaud | JayF: Please add a title dedicated to 0.35.1, else I'd have to propose a new pull requests et cetera | 17:30 |
| JayF | I didn't wanna be presumptuous :D | 17:32 |
| JayF | hberaud: you want an empty unrelesed header still? | 17:32 |
| hberaud | yes | 17:32 |
| JayF | aight, done | 17:33 |
| hberaud | all the other commits landed by 0.35.1 are not significant enough to also require a dedicated changelog entries | 17:34 |
| hberaud | thanks | 17:34 |
| clarkb | JayF: this is me nitpicking but you know you can copy and paste text directly into the PR/issue markdown :) I find that a million times better than screenshots particularly since for some reason those screenshots refuse to load at larger resolution for me so I can't see their content in a readable way. | 17:35 |
| clarkb | just wrap the text in ```'s | 17:35 |
| hberaud | the resolution is not good for me too :( | 17:35 |
| JayF | clarkb: that's a total preference thing, and I find generally github-based projets prefer screenshots, that's why my flow was that way | 17:35 |
| JayF | I should've probably adjusted for this being a special case, but autopilot is a thing :D | 17:36 |
| clarkb | JayF: ok they literally don't open for me. That is probably a github bug but still | 17:36 |
| JayF | (e.g. I don't think "eventlet" is just a random github thing) | 17:36 |
| JayF | oh, weird, yeah likely. either way it's just an exception then, not an exception | 17:36 |
| JayF | and now that I have a test demonstrating the behavior (which fails without my fix), I feel it's slightly less needed | 17:36 |
| clarkb | but also text is copy pastable. images not so much | 17:36 |
| JayF | I agree with you in terms of my preference; but I just usually interact with a project in the way I think they want, github -> default images, and my brain was so laser-focused on getting the fix done I didn't adjust for the special case | 17:37 |
| JayF | I do whatever it takes to get my code landed, and sometimes external projects want weird things *shrug* | 17:37 |
| opendevreview | Jay Faulkner proposed openstack/requirements master: Force use of 0.35.1 eventlet https://review.opendev.org/c/openstack/requirements/+/907243 | 17:46 |
| JayF | hberaud: ^ once your release is done, recheck that | 17:48 |
| JayF | hberaud: I wanted to ensure we were disallowing broken versions of eventlet as well, as requested by prometheanfire and myself on the last bump | 17:49 |
| hberaud | JayF: the asyncio job failed with your patch | 17:50 |
| hberaud | and with py3.8 | 17:50 |
| hberaud | eventlet/tests/isolated/patcher_fork_after_monkey_patch.py fails | 17:52 |
| JayF | yep, trying to repro locally | 17:52 |
| JayF | and I think I did and fixed it | 17:52 |
| JayF | hberaud: fix pushed | 17:55 |
| hberaud | thx | 17:55 |
| hberaud | py3.8 + asyncio job seems now happy, waiting for checks fully completed | 18:05 |
| JayF | To update, 0.35.1 is released, https://review.opendev.org/c/openstack/requirements/+/907243 is rechecking against it with a single +2 | 18:27 |
| JayF | so once that clears CI, it should be able to land and fix gates | 18:27 |
| opendevreview | Merged openstack/requirements master: Force use of 0.35.1 eventlet https://review.opendev.org/c/openstack/requirements/+/907243 | 21:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!