openstackgerrit | Tang Chen proposed openstack/requirements: Update osprofiler requirement https://review.openstack.org/355688 | 01:39 |
---|---|---|
*** abashmak has joined #openstack-requirements | 01:51 | |
abashmak | hello, anybody in here? | 01:52 |
*** abashmak has left #openstack-requirements | 01:57 | |
prometheanfire | and they are gone | 01:58 |
openstackgerrit | Matthew Thode proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/353349 | 03:26 |
stevemar | prometheanfire: still around? | 03:38 |
prometheanfire | stevemar: yarp | 03:38 |
prometheanfire | they aren't back | 03:39 |
stevemar | prometheanfire: is approving a u-c bump a single core thing? https://review.openstack.org/#/c/355616/ | 03:39 |
patchbot | stevemar: patch 355616 - requirements - update constraint for osc-lib to new release 1.0.1 | 03:39 |
stevemar | prometheanfire: regardless, would be great to get eyes on that | 03:39 |
prometheanfire | stevemar: yes | 03:39 |
stevemar | prometheanfire: yeah, abashmak left as quick as he came :) | 03:39 |
prometheanfire | though I think we may change that to two | 03:39 |
prometheanfire | we talked about it last meeting | 03:40 |
stevemar | prometheanfire: "wheeeee" | 03:40 |
stevemar | hehe | 03:40 |
stevemar | i actually lol'ed | 03:41 |
stevemar | prometheanfire: thank you, it'll help unstick the OSC gate | 03:41 |
prometheanfire | :D | 03:41 |
prometheanfire | I need to come up with some ascii art to leave in every comment I approve | 03:41 |
prometheanfire | though probably won't show up right in the web client | 03:42 |
stevemar | prometheanfire: start leaving shrugs | 03:43 |
prometheanfire | stevemar: how is it holding you back btw? | 03:43 |
prometheanfire | sorry, diferent review | 03:43 |
prometheanfire | not osc-lib | 03:43 |
* stevemar approved, i guess ¯\_(ツ)_/¯ | 03:43 | |
prometheanfire | osprofiler wants to update global-requirements (min version | 03:43 |
stevemar | in osc we need osc-lib 1.0.1 to be used in our gate job, need a last minute fix | 03:44 |
stevemar | (i guess you already guessed that since you said 'sorry, different review' :) ) | 03:45 |
prometheanfire | ya, np on that one | 03:45 |
prometheanfire | osprofiler 1.4.0 has released, and a new initializer class has been added. It is useful to users when initializint the notifier in other projects. So update the global requirement. | 03:46 |
prometheanfire | that's not a reason to update gr | 03:46 |
prometheanfire | uc, sure and if a project requires it, sure | 03:46 |
stevemar | prometheanfire: yeah, should only bump gr when ready, that change (which they are pushing in keystone) is a pretty big change | 03:52 |
prometheanfire | fair enough | 03:53 |
prometheanfire | ya | 03:53 |
prometheanfire | figured out why the oslo.db update failed | 03:53 |
prometheanfire | update master with a mitaka package will do that | 03:53 |
stevemar | hehe | 03:54 |
prometheanfire | stevemar: you know if you can change the target branch in a review? | 04:03 |
prometheanfire | I mean submitting to the same change-id | 04:03 |
stevemar | prometheanfire: i normally click the cherry-pick button in gerrit | 04:04 |
prometheanfire | ya, this is to overwrite that bad one | 04:04 |
stevemar | but that'll copy it, not really change the target | 04:04 |
prometheanfire | we'll see | 04:04 |
stevemar | cherry-pick and abandon is a bad idea :) | 04:05 |
prometheanfire | nope | 04:05 |
prometheanfire | huh, didn't update... | 04:06 |
prometheanfire | maybe found a bug? | 04:06 |
* stevemar shrugs at prometheanfire | 04:11 | |
stevemar | bed time for me, kid just woke up, time to put him back to sleep | 04:11 |
prometheanfire | ya, notabug | 04:12 |
prometheanfire | https://review.openstack.org/#/q/I67d7a5000bfe0c98717d3e29d23edc9c6117e765,n,z shows both reviews | 04:12 |
prometheanfire | stevemar: nn | 04:12 |
openstackgerrit | Thomas Bechtold proposed openstack/requirements: Add dogtag-pki used by Barbican https://review.openstack.org/352310 | 05:01 |
*** jpena|off has quit IRC | 06:02 | |
*** jpena|off has joined #openstack-requirements | 06:04 | |
*** jpena|off has quit IRC | 06:10 | |
*** jpena|off has joined #openstack-requirements | 06:11 | |
openstackgerrit | Merged openstack/requirements: update constraint for osc-lib to new release 1.0.1 https://review.openstack.org/355616 | 06:55 |
openstackgerrit | Merged openstack/requirements: update constraint for cliff to new release 2.2.0 https://review.openstack.org/355610 | 06:59 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/353349 | 07:04 |
*** jpena|off is now known as jpena | 07:07 | |
*** jpena has quit IRC | 09:46 | |
*** amoralej has quit IRC | 09:46 | |
*** jpena has joined #openstack-requirements | 09:47 | |
*** sdague has joined #openstack-requirements | 10:23 | |
*** jpena is now known as jpena|lunch | 11:57 | |
*** sigmavirus|away is now known as sigmavirus | 12:05 | |
*** jpena|lunch is now known as jpena | 12:56 | |
*** jpena is now known as jpena|brb | 13:33 | |
*** jpena|brb is now known as jpena | 13:58 | |
*** abashmak has joined #openstack-requirements | 15:11 | |
abashmak | Good morning | 15:11 |
prometheanfire | can someone ack https://review.openstack.org/355711 | 15:11 |
prometheanfire | abashmak: ? | 15:11 |
abashmak | I have a question. I'm trying to add a global requirement, instructions say to run "generate-constraints" | 15:12 |
abashmak | I can't find the tool anywhere | 15:12 |
prometheanfire | https://github.com/openstack/requirements/blob/master/openstack_requirements/cmds/generate.py I think | 15:13 |
prometheanfire | but if you are trying to add an entry to global-requirements the just add it, the gate should do the rest | 15:13 |
abashmak | so the gate will modify uppper-constraintes.txt? | 15:14 |
abashmak | Or should I do it? | 15:14 |
prometheanfire | you should do that too | 15:15 |
prometheanfire | for the initial commit | 15:15 |
abashmak | I see, thank you prometheanfire! | 15:16 |
prometheanfire | :D | 15:16 |
prometheanfire | abashmak: also, stay in the channel next time :P | 15:16 |
abashmak | will do :) | 15:17 |
openstackgerrit | Alexander Bashmakov proposed openstack/requirements: Adding pybrctl to global-requirements. https://review.openstack.org/356006 | 15:19 |
prometheanfire | abashmak: oh y | 15:22 |
abashmak | yes? | 15:22 |
prometheanfire | abashmak: oh ya, add the answers from https://github.com/openstack/requirements/blob/master/README.rst#for-new-requirements to your commit message | 15:22 |
abashmak | prometheanfire: how can I tell if the library is Python3 compatible? | 15:25 |
prometheanfire | abashmak: do they say they are on pypi? | 15:25 |
prometheanfire | otherwise, testing | 15:25 |
prometheanfire | or if the code is simple, looking | 15:26 |
abashmak | they are on https://pypi.python.org/pypi/pybrctl/0.1.1 | 15:26 |
sigmavirus | oh god pybrctl's source looks gross and they have no tests | 15:27 |
sigmavirus | they only claim to support py2.7 | 15:27 |
prometheanfire | sigmavirus: ya, just noticed | 15:27 |
prometheanfire | the code is short, so it might | 15:28 |
prometheanfire | or might be converted easilly | 15:28 |
sigmavirus | yeah I'm doing a visual scan | 15:28 |
prometheanfire | but at the moment it's a no based on no tests and no py3 | 15:28 |
abashmak | If not, I'll go back to making shell calls to 'brctl', no biggie | 15:29 |
prometheanfire | abashmak: sorry, just not looking good | 15:30 |
abashmak | that's fine, thanks for the prompt feedback. Should I abandon the patch? | 15:31 |
prometheanfire | abashmak: also, iirc you can create bridges in ip | 15:31 |
sigmavirus | abashmak: also the library has a lot of methods that raise a NotImplementedError and so it looks like it's barely finished or maintained | 15:31 |
prometheanfire | abashmak: unless you want to work with upstream to fix all the things :P | 15:31 |
prometheanfire | abashmak: ip link add name bridge_name type bridge | 15:32 |
prometheanfire | yep :D | 15:32 |
prometheanfire | https://wiki.archlinux.org/index.php/Network_bridge#With_iproute2 | 15:32 |
abashmak | prometheanfire: thank you for the link, I'll look into using that instead of brctl | 15:33 |
prometheanfire | abashmak: thanks :D | 15:33 |
* prometheanfire remembers converting to ip from brctl a year or so ago | 15:34 | |
*** david-lyle_ has joined #openstack-requirements | 17:09 | |
*** david-lyle has quit IRC | 17:13 | |
*** david-lyle_ is now known as david-lyle | 17:13 | |
*** sdague has quit IRC | 21:04 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!