opendevreview | Matthew Oliver proposed openstack/releases master: swift-bench 2.0.0 release https://review.opendev.org/c/openstack/releases/+/942972 | 03:32 |
---|---|---|
opendevreview | Tim Burke proposed openstack/releases master: swift-bench 2.0.0 release https://review.opendev.org/c/openstack/releases/+/942972 | 05:46 |
frickler | gtema: stephenfin: I don't really understand this horizon failure on the sdk bump, but if it indeed turns out to be related, that would be another blocker https://zuul.opendev.org/t/openstack/build/00933ba0845b47498d0e79e02d82481d (cc release-team) | 09:37 |
gtema | hmm, me neither. But I was yesterday seeing interesting fact of downstream "broken" from sdk 4.4.0 which was indeed downstream bug caught with better typing | 09:40 |
gtema | from what I see in this log it looks like another job that fails when warnings are thrown. And those warnings doesn't look like coming from sdk | 09:41 |
frickler | gtema: yes, the weird thing is that the failure only happened on the sdk bumps, all other recent invocations of that job passed. but let's just wait for the recheck result, then | 09:44 |
frickler | s/bumps/bump/ | 09:45 |
gtema | yeah, looking that this job on other bumps passes with warnings | 09:45 |
gtema | so at least they are not responsible for failure | 09:45 |
gtema | openstack_dashboard/test/unit/api/test_neutron.py::NeutronApiTests::test_router_static_route_add FAILED | 09:45 |
gtema | so 2 neutron relates tests failed, i hope recheck will help | 09:46 |
gtema | ugly that those failures are hidden in the log | 09:46 |
gtema | expected = call('725c24c9-061b-416b-b9d4-012392b32fd9', routes=[{'nexthop': '10.0.0.1', 'destination': '172.0.0.0/24'}, {'nexthop': '10.0.0.2', 'destination': '172.1.0.0/24'}]) | 09:48 |
gtema | actual = call('725c24c9-061b-416b-b9d4-012392b32fd9', routes=[{'nexthop': '10.0.0.5', 'destination': '40.0.1.0/24'}, {'nexthop': '10.0.0.1', 'destination': '172.0.0.0/24'}, {'nexthop': '10.0.0.2', 'destination': '172.1.0.0/24'}]) | 09:48 |
gtema | frickler: the world has changed apparently what the test is not expecting? | 09:49 |
frickler | gtema: not sure if horizon is executing things in parallel, but if it does it might be a race condition between those two tests | 09:58 |
gtema | yeah, think so. There hasn't been any related changes in this release (not that I would recognize in any form related) | 09:59 |
frickler | gtema: same failure again on the recheck, so there's a high chance that it is related after all :( there are some changes by stephenfin in that code region that look like a bit more than just typing https://zuul.opendev.org/t/openstack/build/6f0bd544038245c0b0810b365093ca7c | 10:03 |
gtema | frickler: you mean add of if-match? | 10:07 |
opendevreview | Riccardo Pittau proposed openstack/releases master: Release ironic-ui 6.5.0 for epoxy https://review.opendev.org/c/openstack/releases/+/942986 | 10:15 |
opendevreview | Riccardo Pittau proposed openstack/releases master: Release networking-baremetal 6.5.0 for epoxy https://review.opendev.org/c/openstack/releases/+/942987 | 10:20 |
opendevreview | Riccardo Pittau proposed openstack/releases master: Relase ironic-prometheus-exporter 4.5.0 for epoxy https://review.opendev.org/c/openstack/releases/+/942988 | 10:23 |
frickler | gtema: that and possibly also https://review.opendev.org/c/openstack/openstacksdk/+/941270 | 10:31 |
gtema | this is just an add, so it should not be related. Anyway - I am able to reproduce this locally with horizon tests, but so far not able to understand why | 10:32 |
gtema | it is not a race for sure | 10:33 |
gtema | frickler, I haven't found the cause yet, but the unittest modifies the SDK resource that it uses in mock in place and that is silently not having any effect. So in those 2 tests the expectation is actually wrong while the reality is correct | 11:19 |
gtema | https://opendev.org/openstack/openstacksdk/commit/a11df932f671c1d7ad7679c418fb74b126f5851c is to blame | 11:27 |
opendevreview | Stephen Finucane proposed openstack/releases master: cliff 4.9.1 https://review.opendev.org/c/openstack/releases/+/942996 | 11:53 |
stephenfin | gtema: I don't think so. bisect is showing this change to the culprit https://review.opendev.org/c/openstack/openstacksdk/+/941271 | 12:07 |
gtema | ok, anyway the bad actor is https://opendev.org/openstack/horizon/src/commit/1252f1c099bdda554fda5fecb294eb63cc348f6e/openstack_dashboard/test/unit/api/test_neutron.py#L1617 | 12:07 |
gtema | we never supported such inplace modifications. I wonder why that worked since making a tiny test shows it was not workign even before | 12:08 |
gtema | btw, you pointed to the very same change, just that I posted commit while you gerrit | 12:09 |
stephenfin | gtema: I posted the wrong link, that's why :) | 12:10 |
stephenfin | It's https://review.opendev.org/c/openstack/openstacksdk/+/941272 | 12:10 |
stephenfin | 'fields: Tweak _convert_type' | 12:10 |
stephenfin | I think this is the issue | 12:10 |
gtema | ok | 12:10 |
stephenfin | https://github.com/openstack/openstacksdk/commit/bf1b56e23f1c8cbdd3a2041b09506fb4b7091ed3#diff-912cc605d1c7dac81859938b2620b64c2de4a419bcab096eed36069dc03331c9R34 | 12:11 |
stephenfin | So previously, we returned 'value'. Now we return 'data_type(value)', which creates a _copy_ | 12:11 |
stephenfin | so in-place modifications will be lost during conversion | 12:12 |
stephenfin | I think. Just confirming now. | 12:12 |
gtema | https://paste.openstack.org/show/byZpxP2y2ujhv4TCKehT/ - such thing does not work for me also with 4.3.0 | 12:13 |
gtema | I am wrong - it was working before | 12:15 |
gtema | just testing in the openstack repo itself even under venv is overriding the stuff | 12:16 |
stephenfin | yup, if you checkout bf1b56e23f1c8cbdd3a2041b09506fb4b7091ed3 and change that line (s/data_type(value)/value/) the test passes | 12:17 |
stephenfin | actually, let's bring this to #openstack-sdks :) | 12:17 |
gtema | sure | 12:17 |
stephenfin | Fix for horizon is here https://review.opendev.org/c/openstack/horizon/+/943001 | 13:22 |
elodilles | reminder: meeting in 30 mins | 13:30 |
elodilles | #startmeeting releaseteam | 14:00 |
opendevmeet | Meeting started Fri Feb 28 14:00:23 2025 UTC and is due to finish in 60 minutes. The chair is elodilles. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'releaseteam' | 14:00 |
elodilles | Ping list: release-team armstrong | 14:00 |
elodilles | #link https://etherpad.opendev.org/p/epoxy-relmgt-tracking | 14:00 |
ttx | o/ | 14:00 |
frickler | \o | 14:00 |
elodilles | we are at line 291 | 14:01 |
elodilles | o/ | 14:01 |
elodilles | let's start \o/ | 14:01 |
elodilles | #topic Review task completion | 14:01 |
elodilles | 1st task: | 14:02 |
elodilles | ' Process any remaining library freeze exception (all)' | 14:02 |
elodilles | #link https://review.opendev.org/q/topic:epoxy-final-non-client-libs+is:open | 14:02 |
elodilles | there is a 2nd final patch for cliff :) | 14:02 |
elodilles | 2 patches still on the gate | 14:02 |
elodilles | se we have to keep an eye on this | 14:03 |
elodilles | s/se/so/ | 14:03 |
ttx | looks good to me | 14:03 |
elodilles | +1 | 14:03 |
elodilles | otherwise nothing else left | 14:04 |
elodilles | anyway, added it to next week's tasks | 14:05 |
elodilles | 2nd task: | 14:05 |
elodilles | ' Ensure that all new-release patches in requirements repository for the library releases are merged. This should be an empty list:' | 14:05 |
elodilles | #link https://review.opendev.org/q/project:openstack/requirements+branch:master+is:open+topic:new-release | 14:05 |
elodilles | well, this contains now this week's releases as well | 14:05 |
frickler | well the list is still quite crowded, mostly due to CI instability | 14:06 |
elodilles | and that ^^^ | 14:06 |
frickler | but I'm rechecking my way through it | 14:06 |
elodilles | thanks frickler o/ | 14:06 |
elodilles | frickler: do you see any problematic release that fails on any cross-job? | 14:06 |
frickler | elodilles: there was the sdk issue mentioned earlier, but that seems to be under control | 14:07 |
elodilles | ACK | 14:07 |
elodilles | cool | 14:07 |
frickler | or really a horizon bug, but uncovered by new sdk | 14:07 |
frickler | #link https://review.opendev.org/c/openstack/horizon/+/943001 | 14:08 |
frickler | just for the record ;) | 14:08 |
elodilles | we have to monitor this next week as well since some of the client library releases are still on the way | 14:08 |
elodilles | frickler: logged :) | 14:08 |
elodilles | let's move on | 14:09 |
elodilles | 3rd task: | 14:09 |
elodilles | ' Propose autoreleases (process_auto_releases) for cycle-with-intermediary client libraries which had commits that have not been included in a release (elod)' | 14:09 |
elodilles | #link https://review.opendev.org/q/topic:epoxy-milestone-3 | 14:09 |
elodilles | quite many merged | 14:09 |
elodilles | some needs a 2nd +2 | 14:10 |
elodilles | and some needs force merge, due to no response from the team | 14:10 |
frickler | I can check the remainders later today | 14:10 |
elodilles | i will go through them some time after the meeting, but a 2nd review would be apprechiated | 14:11 |
elodilles | frickler: thanks in advance o/ | 14:11 |
ttx | I'll do another reveiw round | 14:11 |
elodilles | that will be more than enough then :) thanks ttx :) | 14:11 |
elodilles | some release patch seem to be left for next week (-1'd by team) but that's OK | 14:12 |
elodilles | 4th task: | 14:12 |
elodilles | ' Evaluate any non-client libraries that did not have any change merged over the cycle to see if it is time to transition them to the independent release model (ttx)' | 14:12 |
elodilles | ttx wrote: no non-client libraries found | 14:13 |
ttx | Yes so that yielded nothing | 14:13 |
ttx | (only client libraries) | 14:13 |
elodilles | yeah, just wanted to say that we had like 3 client library like that :/ | 14:13 |
elodilles | but that is not part of this task | 14:13 |
elodilles | so we are good with this task | 14:14 |
elodilles | 5th task: | 14:14 |
elodilles | ' List cycle-with-intermediary deliverables that have not been released yet and send email (ttx)' | 14:14 |
elodilles | and the list: | 14:14 |
ttx | that was done, you can see what i found in the etherpad | 14:14 |
elodilles | swift, horizon, | 14:14 |
elodilles | bifrost ironic-inspector ironic-prometheus-exporter ironic-python-agent-builder ironic-ui networking-baremetal networking-generic-switch | 14:14 |
elodilles | email sent Tuesday | 14:15 |
elodilles | EOM | 14:15 |
elodilles | thanks ttx o/ | 14:15 |
elodilles | i've even seen some new releases from this list ^^^ | 14:15 |
elodilles | so the mail did its purpose i guess :) | 14:15 |
ttx | indeed, that remidner got some traction! | 14:15 |
elodilles | +1 | 14:16 |
elodilles | and +2 even! | 14:16 |
elodilles | 6th task: | 14:16 |
elodilles | ' On Friday, remind the requirements team to freeze changes to openstack/requirements by applying -2 to all open patches (elod)' | 14:16 |
elodilles | well, we still have cliff we have to wait for if i'm not mistaken | 14:17 |
frickler | yeah, remind me to do that later, too | 14:17 |
elodilles | frickler: ACK, will do | 14:17 |
frickler | well it doesn't apply to new-release changes anyway, right? | 14:17 |
elodilles | frickler: it should afair | 14:18 |
elodilles | those needs RFE | 14:18 |
elodilles | (requirements freeze exception) | 14:18 |
elodilles | of course if they are in the upper-constraints.txt | 14:19 |
elodilles | but i might be wrong | 14:19 |
elodilles | anyway, | 14:19 |
elodilles | prometheanfire tonyb frickler : heads up about 2025.1 Epoxy requirements freeze ^^^ | 14:19 |
opendevreview | Merged openstack/releases master: Release final python-venusclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942556 | 14:20 |
frickler | "Ensure that reviewers do not approve changes created by the proposal bot, but do approve changes for new OpenStack deliverable releases." | 14:20 |
elodilles | and that's all about this week's tasks | 14:20 |
elodilles | frickler: ACK, you are right | 14:20 |
elodilles | thanks! | 14:20 |
frickler | that's the second sentence in https://releases.openstack.org/reference/process.html#r-5-week-milestone-3 | 14:20 |
elodilles | true-true | 14:21 |
elodilles | my bad | 14:21 |
elodilles | #topic Assign R-4 week tasks | 14:22 |
elodilles | as far as i see all tasks taken | 14:22 |
opendevreview | Merged openstack/releases master: Release ironic-ui 6.5.0 for epoxy https://review.opendev.org/c/openstack/releases/+/942986 | 14:22 |
elodilles | as usual, feel free to hijack a task from me if you want to deal with any | 14:22 |
elodilles | otherwise we can move on | 14:22 |
elodilles | #topic Review weekly countdown email | 14:23 |
elodilles | #link https://etherpad.opendev.org/p/relmgmt-weekly-emails | 14:23 |
elodilles | please review ^^^ | 14:23 |
ttx | lgtm | 14:24 |
frickler | +1 | 14:25 |
elodilles | thanks! | 14:25 |
elodilles | will send it some time later today | 14:25 |
elodilles | #topic Open Discussion | 14:25 |
elodilles | anything to bring up? | 14:26 |
fungi | i didn't have anything | 14:26 |
frickler | fungi: while you're around, did I miss the patch for the new signing key or is that still pending? | 14:27 |
ttx | niothing from me! | 14:27 |
fungi | still haven't gotten to it, but it's on my list | 14:27 |
elodilles | it was an early reminder so we still have time :) | 14:28 |
fungi | exactly | 14:28 |
elodilles | so, thanks in advance fungi o/ | 14:28 |
elodilles | good. if nothing else to discuss... | 14:28 |
elodilles | then thanks everyone for participating o/ | 14:29 |
elodilles | and let's end the meeting | 14:29 |
elodilles | #endmeeting | 14:29 |
opendevmeet | Meeting ended Fri Feb 28 14:29:35 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:29 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/releaseteam/2025/releaseteam.2025-02-28-14.00.html | 14:29 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/releaseteam/2025/releaseteam.2025-02-28-14.00.txt | 14:29 |
opendevmeet | Log: https://meetings.opendev.org/meetings/releaseteam/2025/releaseteam.2025-02-28-14.00.log.html | 14:29 |
ttx | thanks elodilles ! | 14:30 |
opendevreview | Merged openstack/releases master: Relase ironic-prometheus-exporter 4.5.0 for epoxy https://review.opendev.org/c/openstack/releases/+/942988 | 14:31 |
elodilles | thanks too o/ | 14:31 |
opendevreview | Merged openstack/releases master: Release networking-baremetal 6.5.0 for epoxy https://review.opendev.org/c/openstack/releases/+/942987 | 14:33 |
opendevreview | Merged openstack/releases master: Release final python-keystoneclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942546 | 14:33 |
opendevreview | Merged openstack/releases master: Release final python-glanceclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942544 | 14:33 |
opendevreview | Merged openstack/releases master: Release final python-brick-cinderclient-ext for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942539 | 14:33 |
opendevreview | Merged openstack/releases master: swift-bench 2.0.0 release https://review.opendev.org/c/openstack/releases/+/942972 | 14:33 |
opendevreview | Merged openstack/releases master: Release keystoneauth for stable/2023.2 https://review.opendev.org/c/openstack/releases/+/941401 | 14:47 |
opendevreview | Merged openstack/releases master: Release keystone for stable/2023.2 https://review.opendev.org/c/openstack/releases/+/941399 | 14:47 |
priteau | elodilles: Hello. May we have your approval for cliff release? | 15:50 |
priteau | Thanks :) | 15:53 |
opendevreview | Merged openstack/releases master: cliff 4.9.1 https://review.opendev.org/c/openstack/releases/+/942996 | 16:02 |
elodilles | priteau: np :] | 16:04 |
frickler | elodilles: ttx: we still have this weird error to solve https://review.opendev.org/c/openstack/releases/+/942537 | 18:09 |
elodilles | frickler: yeah i'm working on it, let me push a patch for that | 18:17 |
elodilles | it seems that 'packaging' fixed an operator which now works as it should :) | 18:20 |
opendevreview | Merged openstack/releases master: Release final python-cloudkittyclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942541 | 18:21 |
frickler | elodilles: ttx: another open topic is the ironic-lib deprecation https://review.opendev.org/c/openstack/releases/+/939280 and related reqs cleanup https://review.opendev.org/c/openstack/requirements/+/939279 not sure what the best solution is there | 18:29 |
opendevreview | Merged openstack/releases master: Release final python-designateclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942543 | 18:32 |
opendevreview | Merged openstack/releases master: Release final python-zaqarclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942558 | 18:32 |
opendevreview | Merged openstack/releases master: Release final python-watcherclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942557 | 18:32 |
opendevreview | Merged openstack/releases master: Release final python-observabilityclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942552 | 18:32 |
opendevreview | Merged openstack/releases master: Release final python-troveclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942555 | 18:32 |
opendevreview | Elod Illes proposed openstack/releases master: Release final python-aodhclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942537 | 19:08 |
opendevreview | Elod Illes proposed openstack/releases master: [validator] reproduce bug with version comparison https://review.opendev.org/c/openstack/releases/+/943050 | 19:08 |
opendevreview | Elod Illes proposed openstack/releases master: [validator] fix bug with version comparison https://review.opendev.org/c/openstack/releases/+/943051 | 19:08 |
elodilles | frickler: yepp, i was a bit hesitant, but if possible i'd rather remove ironic-lib under deliverables/epoxy/ and from requirements... :/ it's a bit late though... | 19:09 |
elodilles | for that... | 19:09 |
opendevreview | Brian Rosmaita proposed openstack/releases master: Release final python-cinderclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942540 | 19:17 |
opendevreview | Merged openstack/releases master: Release final python-mistralclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942550 | 20:24 |
opendevreview | Merged openstack/releases master: Release final python-barbicanclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942538 | 20:37 |
opendevreview | Elod Illes proposed openstack/releases master: [validator] Reproduce bug with version comparison https://review.opendev.org/c/openstack/releases/+/943050 | 20:54 |
opendevreview | Elod Illes proposed openstack/releases master: [validator] Fix bug with version comparison https://review.opendev.org/c/openstack/releases/+/943051 | 20:54 |
opendevreview | Elod Illes proposed openstack/releases master: Release final python-aodhclient for 2025.1 Epoxy https://review.opendev.org/c/openstack/releases/+/942537 | 20:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!