opendevreview | Dr. Jens Harbott proposed openstack/releases master: Transition unmaintained/victoria to EOL https://review.opendev.org/c/openstack/releases/+/937515 | 07:28 |
---|---|---|
frickler | release-team: ^^ is the result of the discussion in the TC meeting yesterday, will handle newer branches once this patch is done | 07:33 |
frickler | humm, I had been wondering whether I'd need to exclude the *-tempest-plugins, tox validate says I should have :-( | 08:18 |
opendevreview | Dr. Jens Harbott proposed openstack/releases master: Transition unmaintained/victoria to EOL https://review.opendev.org/c/openstack/releases/+/937515 | 08:23 |
elodilles | frickler: ACK, I will add my notes there. yepp, tempest-plugins are branchless. | 08:55 |
opendevreview | Merged openstack/releases master: Puppet OpenStack: Create final stable/2023.1 release https://review.opendev.org/c/openstack/releases/+/937244 | 10:09 |
opendevreview | Merged openstack/releases master: release oslo.db 17.1.0 https://review.opendev.org/c/openstack/releases/+/937452 | 10:14 |
opendevreview | Dr. Jens Harbott proposed openstack/releases master: Transition unmaintained/victoria to EOL https://review.opendev.org/c/openstack/releases/+/937515 | 10:18 |
frickler | so ... I ran "list-deliverables --series victoria | xargs -i new-release victoria {} eol" to generate the above and I wonder how to best filter out what I just removed. inserting a "grep -v tempest" is easy, guess I'll need to continue to treat the other three manually? | 10:20 |
elodilles | frickler: use like this: "list-deliverables --series victoria --except-type tempest-plugin" | 10:27 |
frickler | ah, ok, that still leaves me with patrole and tempest itself, but that seems feasible, thx | 10:37 |
frickler | another question: can we delete stuff that never did get any release in a series? like deliverables/victoria/validations-common.yaml ? that one I also had to exclude manually | 10:40 |
elodilles | good question. probably it's less effort if we just keep it there and don't touch at all. | 12:01 |
frickler | well, assuming that we don't retire victoria completely (which iiuc you want to prevent), we'll have to touch things again every 6 months, that's what I'd like to avoid | 12:16 |
elodilles | in general, there shouldn't be such deliverable yaml that does not contain any release, so hopefully we won't have a long list of such cases (if there will be at all on wallaby and later) | 12:22 |
elodilles | frickler: i think the tools/list_eol_stale_branches.sh has some issue :S it did not work for me :/ | 13:18 |
elodilles | commented it on your patch | 13:18 |
opendevreview | Dr. Jens Harbott proposed openstack/releases master: Update tooling to delete unmaintained branches https://review.opendev.org/c/openstack/releases/+/936637 | 13:40 |
frickler | ^^ that should be better now, though there aren't actually any stale branches on 2023.1 currently. however I'm now running the abandon and then eol scripts for older branches | 13:44 |
elodilles | frickler: there should be some stale branch due to these merged yesterday: https://review.opendev.org/q/topic:eom-to-eol | 13:46 |
frickler | elodilles: yes, a lot of them, but only zed and older afaict. or the script is still somehow broken with my latest patch. I did use some hardcoded series values when I did the initial eol run, I can try that in a bit when the other stuff is don | 13:59 |
fungi | looks like the neutron point releases covering ossa-2024-005 still need a second release manager to approve: 937113, 937114, 937115 (not super urgent, but would be nice to get those tags in, as it will ease downstream communication about applying fixes) | 14:23 |
frickler | fungi: ack, will do | 14:25 |
fungi | thanks! | 14:25 |
frickler | elodilles: ^^ actually I think I found a bug in the above, but only noticed on the third patch. I was already wondering why the diffs in list-changes were so large, but didn't spot the cause | 14:35 |
elodilles | yepp. you are right... | 14:38 |
elodilles | thanks for spotting that issue | 14:38 |
fungi | picked a commit from the wrong branch? | 14:39 |
elodilles | nope | 14:40 |
elodilles | the hashes are right | 14:40 |
elodilles | the problem is that the new release was inserted before the diff-start line, thus it is moved to the new release, which is a problem | 14:41 |
frickler | ralonsoh: are you around and can update https://review.opendev.org/c/openstack/releases/+/937113 and above? else I could do it for you | 14:47 |
frickler | abandoning changes is done, starting branch deletions now | 14:53 |
elodilles | +1 | 14:54 |
ralonsoh | frickler, sure let me check | 15:21 |
ralonsoh | frickler, what is the missing requirement? | 15:21 |
ralonsoh | elodilles, https://review.opendev.org/c/openstack/releases/+/937113/1/deliverables/bobcat/neutron.yaml#45 | 15:22 |
ralonsoh | what should be there? the latest tag? | 15:22 |
elodilles | ralonsoh: diff-start: should have been added to 23.0.0 version entry and should not move as we are creating new release | 15:24 |
ralonsoh | so not to b1, but to 23.0.0 | 15:25 |
frickler | yes. the error was introduced earlier already though, like in https://review.opendev.org/c/openstack/releases/+/901058/1/deliverables/bobcat/neutron.yaml | 15:25 |
ralonsoh | can we change this now? | 15:25 |
frickler | I think we still can change this, yes | 15:26 |
ralonsoh | ok, I'll update the patch and the upper ones now | 15:26 |
frickler | although we also might want to consider how we can have an automated check for this going forward | 15:26 |
elodilles | ralonsoh: diff-start is generated for the final release originally and should stay there. (in original patch: https://review.opendev.org/c/openstack/releases/+/896971/3/deliverables/bobcat/neutron.yaml ) | 15:27 |
ralonsoh | so I'm lost now, how should I update the patch? | 15:28 |
elodilles | frickler: yes, probably we should have some check for this :/ | 15:28 |
elodilles | ralonsoh: do you use the 'new-release' command when creating the new releases? o:) (because that creates the new versions correctly o:)) | 15:29 |
ralonsoh | no, I manually modify the yaml files | 15:29 |
ralonsoh | I didn't know that there was a tool for that | 15:29 |
elodilles | ralonsoh: we usually advertise it in the beginning of the cycle to PTLs, but it is also documented here: https://releases.openstack.org/reference/using.html#using-new-release-command | 15:32 |
elodilles | though i understand that it is fairly easy to edit yamls manually as well | 15:32 |
ralonsoh | ok, I'll update again these patches | 15:33 |
ralonsoh | to be honest, I don't know why I added this field | 15:33 |
elodilles | ralonsoh: you didn't added it, just shifted it with every new releases and we haven't noticed that earlier. sorry for that :/ | 15:34 |
ralonsoh | in any case, this field has been pushed down in several patches before mine | 15:34 |
ralonsoh | yes | 15:34 |
ralonsoh | should we push it up again? | 15:35 |
ralonsoh | or does it break something? | 15:35 |
elodilles | yeah, let's try that | 15:35 |
elodilles | i hope it won't break anything. fingers crossed. | 15:35 |
ralonsoh | I'll push the patches now | 15:35 |
elodilles | thanks! | 15:36 |
opendevreview | Rodolfo Alonso proposed openstack/releases master: [Neutron] Fix the diff-start reference in 2023.2 and 2024.1 https://review.opendev.org/c/openstack/releases/+/937542 | 15:50 |
opendevreview | Rodolfo Alonso proposed openstack/releases master: [Neutron] Release a new 2023.2 version: 23.3.0 https://review.opendev.org/c/openstack/releases/+/937113 | 15:51 |
opendevreview | Rodolfo Alonso proposed openstack/releases master: [Neutron] Release a new 2023.2 version: 23.3.0 https://review.opendev.org/c/openstack/releases/+/937113 | 15:52 |
opendevreview | Rodolfo Alonso proposed openstack/releases master: [Neutron] Release a new 2024.1 version: 24.1.0 https://review.opendev.org/c/openstack/releases/+/937114 | 15:53 |
opendevreview | Rodolfo Alonso proposed openstack/releases master: [Neutron] Release a new 2024.2 version: 25.1.0 https://review.opendev.org/c/openstack/releases/+/937115 | 15:53 |
opendevreview | Rodolfo Alonso proposed openstack/releases master: [Neutron] Release a new 2024.2 version: 25.1.0 https://review.opendev.org/c/openstack/releases/+/937115 | 15:54 |
ralonsoh | done ^ | 15:54 |
elodilles | thanks o/ let's see if the validator likes them | 15:55 |
elodilles | frickler: i think we can give them a try ^^^ | 16:37 |
frickler | I'll take another look in a bit | 16:42 |
frickler | 268 branches deleted, that might be a new record for a single run ;) https://paste.opendev.org/show/b9SCoKB93C3m3va5y4AM/ | 16:42 |
elodilles | :-o | 16:43 |
gouthamr | carloss: can we un-wip this one and get it out the door? https://review.opendev.org/c/openstack/releases/+/932133 | 16:51 |
carloss | gouthamr: sure, other releases were completed some weeks ago, let's get this going | 16:52 |
gouthamr | elodilles: frickler: apologies for holding up https://review.opendev.org/c/openstack/releases/+/934506 .. it was unfortunate the one bugfix that we were trying to get in crossed paths with the EOL transition across the stack | 16:53 |
elodilles | gouthamr: yes, we started the stable branch deletion which ended up like half of the branches had only stable/2023.1 the other half unmaintained/2023.1 and that did not really help the CI jobs | 16:58 |
elodilles | this is exactly we try to advertise that to teams to push final stable releases before we start the transition process | 16:59 |
elodilles | on the other hand it is good to see if a team is so active on its old stable branch :D | 17:01 |
opendevreview | Merged openstack/releases master: [Neutron] Fix the diff-start reference in 2023.2 and 2024.1 https://review.opendev.org/c/openstack/releases/+/937542 | 17:09 |
opendevreview | Merged openstack/releases master: [Neutron] Release a new 2023.2 version: 23.3.0 https://review.opendev.org/c/openstack/releases/+/937113 | 17:11 |
opendevreview | Merged openstack/releases master: [Neutron] Release a new 2024.1 version: 24.1.0 https://review.opendev.org/c/openstack/releases/+/937114 | 17:14 |
opendevreview | Merged openstack/releases master: [Neutron] Release a new 2024.2 version: 25.1.0 https://review.opendev.org/c/openstack/releases/+/937115 | 17:15 |
fungi | yay! | 17:15 |
fungi | thanks everyone! | 17:15 |
clarkb | as a heads up the opendev team is landing some followup changes to the gerrit upgrade. One of these changes results in a new gerrit container image which pulls in a bugfix for login redirects. I want to restart gerrit quickly today to pick that update up | 17:37 |
frickler | clarkb: you may want to make sure that the tag and release pipelines have cleared before you do that. I'm done with doing release approvals and branch cleanups for today | 17:43 |
clarkb | ack they are both fairly quiet with only a few changes each. I don't anticipate the restart will happen soon enough to impact those ut will double check before any restarts occur | 17:45 |
-opendevstatus- NOTICE: Gerrit will undergo a short restart to pick up some bugfixes for the 3.10 release that we upgraded to. | 19:26 | |
*** haleyb is now known as haleyb|out | 23:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!