| *** bauzas_ is now known as bauzas | 10:12 | |
| mnasiadka | release-team: Any chance to get https://review.opendev.org/c/openstack/releases/+/934054 merged? | 16:47 |
|---|---|---|
| elodilles | mnasiadka: i'll review the release patch now | 16:50 |
| mnasiadka | Thank you very much | 16:50 |
| elodilles | mnasiadka: there is a single patch that is not part of the release of kolla-ansible | 16:55 |
| elodilles | is that intentional? | 16:55 |
| elodilles | (though that would require an rc3) | 16:55 |
| mnasiadka | That's a reno update, does it have to be part of the release? | 16:55 |
| elodilles | https://zuul.opendev.org/t/openstack/build/9e44a71b9eef438797d5ff18db5984fa/log/tox/list-changes/list-changes-results.log#525 | 16:55 |
| elodilles | mnasiadka: not necessarily | 16:56 |
| elodilles | ACK, then I'm +2+W the release patch | 16:56 |
| mnasiadka | Yeah, and we do monthly releases anyway (or we try to) | 16:57 |
| mnasiadka | So that shouldn't be a problem. | 16:57 |
| elodilles | also i've commented, that the bot generated patches (.gitreview / TOX_CONSTRAINTS_FILE updates) don't require an rc2 (though they don't harm) | 16:58 |
| elodilles | mnasiadka: ACK | 16:58 |
| elodilles | tkajinam: for which deliverables are you planning a final stable/2023.1 release before the transition? just out of curiosity o:) (as I'm planning to generate the transitioning patches soon - should have done it last week, but i was on vacation + we need some tooling fix, too) | 17:00 |
| tkajinam | elodilles, puppet, oslo and heat. though I first have to check if we have any unreleased changes in 2023.1 | 17:01 |
| elodilles | tkajinam: i've generated this (4 weeks ago, though, so probably not realy up-to-date if teams not updated): https://etherpad.opendev.org/p/2023.1-antelope-final-release-before-eom | 17:03 |
| elodilles | but i don't remember seeing puppet or heat changes that worth a release | 17:04 |
| tkajinam | ahh, ok. | 17:04 |
| elodilles | but i might be wrong | 17:04 |
| elodilles | so a double check might be useful | 17:04 |
| tkajinam | let me go through these... for puppet things a bit more complicated as we have to modify metadata file in code repo, too | 17:04 |
| elodilles | tkajinam: ACK | 17:05 |
| opendevreview | Merged openstack/releases master: kolla: final Dalmatian release https://review.opendev.org/c/openstack/releases/+/934054 | 17:05 |
| elodilles | tkajinam: no need to hurry, i'm probably generating the patches later this week + we can wait for a final release if needed | 17:06 |
| tkajinam | elodilles, ack and thanks | 17:06 |
| elodilles | no problem | 17:11 |
| ttx | Hmm, same ModuleNotFoundError: No module named 'setuptools' error on publish-tox-docs-releases | 17:24 |
| ttx | I think we should fix that befroe issuing any more releases | 17:24 |
| ttx | IIRC we worked around that by avoiding Noble hosts for certain jobs in the past... maybe fungi remembers | 17:25 |
| ttx | https://zuul.opendev.org/t/openstack/build/0909463e62c14678849039b155e530d0 | 17:25 |
| clarkb | that issue is likely going to be due to running on python3.12 which doesn't include setuptools | 17:25 |
| clarkb | you can still install setuptools if you need it | 17:25 |
| clarkb | *python3.12 doesn't include setuptools by default | 17:26 |
| ttx | like.. ading it to the releases repo bindep.txt? | 17:26 |
| clarkb | or pip installing it via requirements.txt if we do that | 17:27 |
| clarkb | another potential is if you just need ti at install time then a pyproject.toml file can list it as a build dep | 17:28 |
| clarkb | I think that is what most python people woudl suggest you do | 17:28 |
| ttx | It's a post-merge job so we might need it to be in bindep.txt | 17:28 |
| ttx | requirements.txt has a scary warning about that | 17:29 |
| fungi | https://opendev.org/openstack/releases/src/branch/master/openstack_releases/links.py#L16 | 17:29 |
| ttx | https://opendev.org/openstack/releases/src/branch/master/requirements.txt | 17:29 |
| fungi | it's trying to import wheel.bdist_wheel which apparently needs setuptools also installed in the venv | 17:29 |
| ttx | uh | 17:29 |
| clarkb | ok so not just a build dep | 17:30 |
| fungi | https://github.com/pypa/wheel/blob/main/src/wheel/_bdist_wheel.py#L24 | 17:31 |
| fungi | that's where it's coming from | 17:31 |
| clarkb | that code is just generating a wheel name from the package name? | 17:32 |
| clarkb | I wonder if there is a more standard way of doing that now that setuptools/wheel are deprecated | 17:32 |
| fungi | wheel doesn't itself declare a dependency on setuptools, so requirements.txt for the releases repo will need to add setuptools unless you want to change that links.py script to no longer rely on wheel.bdist_wheel | 17:33 |
| ttx | fungi: is requirements.txt enough? The scary warning at https://opendev.org/openstack/releases/src/branch/master/requirements.txt says it's not going to be enough for post-merge jobs like publish-tox-docs-releases | 17:35 |
| fungi | https://opendev.org/openstack/releases/src/branch/master/tox.ini#L78 indicates you could stick it in docs/requirements.txt if needed. i guess the question is whether links.py gets used in other jobs that aren't running tox -e docs | 17:36 |
| fungi | er, doc/requirements.txt i mean | 17:36 |
| ttx | yeah it seems to work | 17:40 |
| ttx | (adding it to doc/requirements.txt) | 17:40 |
| ttx | I'll push a quick fix | 17:40 |
| fungi | hopefully that's the only python 3.12 related regression | 17:41 |
| dansmith | can I beg for someone to push this over the line please? https://review.opendev.org/c/openstack/releases/+/933627 | 17:42 |
| dansmith | multiple bug/feature efforts blocked on it | 17:42 |
| ttx | hey my +2 is already there! maybe elodilles or frickler ? | 17:46 |
| opendevreview | Thierry Carrez proposed openstack/releases master: Add setuptools for publish-tox-docs-releases https://review.opendev.org/c/openstack/releases/+/934163 | 17:48 |
| opendevreview | Merged openstack/releases master: Add setuptools for publish-tox-docs-releases https://review.opendev.org/c/openstack/releases/+/934163 | 18:11 |
| frickler | approved the oslo.utils release now to test ^^ | 18:32 |
| dansmith | frickler: thanks | 18:34 |
| opendevreview | Merged openstack/releases master: Create new epoxy release of oslo.utils https://review.opendev.org/c/openstack/releases/+/933627 | 18:40 |
| elodilles | thx for the setuptools fix, it worked as far as i can see \o/ >>> https://zuul.opendev.org/t/openstack/build/88a10595a8b24899854018f3beefdf43 | 19:05 |
| *** bauzas_ is now known as bauzas | 22:05 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!