| fungi | the other trove backport (835494) is also failing a bunch of jobs | 01:31 |
|---|---|---|
| fungi | i suspect it may need to depends-on the passing commit | 01:33 |
| fungi | TypeError: __init__() got an unexpected keyword argument 'tenant' | 01:33 |
| fungi | yeah | 01:34 |
| fungi | i'll update the commit message | 01:34 |
| fungi | er, rebase i mean | 01:34 |
| fungi | ! [remote rejected] HEAD -> refs/for/master%topic=stable/yoga (change https://review.opendev.org/c/openstack/trove/+/834373 closed) | 01:44 |
| opendevmeet | fungi: Error: "remote" is not a valid command. | 01:44 |
| fungi | this is very confusing | 01:44 |
| fungi | oh | 01:44 |
| fungi | there we go. the branch is still missing its .gitreview change, that was why | 01:45 |
| fungi | looks like rebasing it has gotten the unit tests passing | 02:17 |
| fungi | unfortunately my murano fix is still not coming along as i'd hoped | 02:17 |
| fungi | i worry i'm a bit out of my depth with it, and it's getting late | 02:41 |
| fungi | the current iteration is spewing tracebacks like https://zuul.opendev.org/t/openstack/build/8f5d43c35053445985f62dddc2e1745f/log/job-output.txt#1426-1448 | 02:41 |
| fungi | i guess i need to update the db sessions to use project_id as well | 02:43 |
| fungi | er, no, it must be that package_upload() is getting passed a nonetype tenant_id | 02:45 |
| fungi | i'll ask on the ml for help | 02:45 |
| fungi | the stable/yoga backports for trove have been approved for an hour now but are still not in the gate pipeline | 03:23 |
| fungi | apparently it just wanted a recheck. maybe something about how i originally applied the workflow and code review votes failed to match the comment-added event | 03:33 |
| *** abhishekk is now known as akekane|home | 04:54 | |
| *** akekane|home is now known as abhishekk | 04:54 | |
| *** marios is now known as marios|ruck | 05:22 | |
| ttx | I can live with a broken Murano release if it comes down to it | 06:46 |
| ttx | fungi: Thanks a lot for driving this overnight! | 06:47 |
| *** jbadiapa|off is now known as jbadiapa | 07:20 | |
| ttx | approved Sahara rc2 | 07:40 |
| elodilles | yepp, thanks for working on it | 07:42 |
| ttx | postign trove rc2 now | 07:42 |
| elodilles | ttx: ack | 07:43 |
| elodilles | ttx: i wanted to make the generated patch to merge, but it seems the recheck did not work ( this https://review.opendev.org/c/openstack/trove/+/832972 and this https://review.opendev.org/c/openstack/trove/+/832974 ) | 07:44 |
| ttx | working off https://review.opendev.org/c/openstack/trove/+/835492 | 07:45 |
| elodilles | oh, the recheck worked, but it is still on the gate :S | 07:45 |
| elodilles | (in check queue) | 07:45 |
| opendevreview | Merged openstack/releases master: Final RC patch for sahara https://review.opendev.org/c/openstack/releases/+/835037 | 07:47 |
| elodilles | but anyway, they are not that important since we are in lack of time | 07:47 |
| opendevreview | Thierry Carrez proposed openstack/releases master: Release Trove Yoga rc2 https://review.opendev.org/c/openstack/releases/+/835544 | 07:47 |
| ttx | That leaves murano, Andy Botting proposed a new rev on the patch | 07:48 |
| ttx | currently in check | 07:48 |
| ttx | If we get a patch that works we can backport it and fungi can approve them, then we can regenerate our release patch alright | 07:49 |
| elodilles | sounds good! | 07:49 |
| elodilles | ttx: about the other, setuptools problem: if i understood correctly you also preferred temporary pinning setuptools (with this patch: https://review.opendev.org/c/openstack/releases/+/835423 ) | 07:53 |
| elodilles | (though 1 out of 3 in-place workarounds has landed: https://review.opendev.org/q/topic:setuptools-issue-3197 , but those would also need last-minute re-releases) | 07:54 |
| ttx | yes approved | 07:54 |
| elodilles | ttx: awesome, thanks! | 07:55 |
| opendevreview | Merged openstack/releases master: Pin setuptools for Yoga release https://review.opendev.org/c/openstack/releases/+/835423 | 08:04 |
| ttx | FWIW in the case we can't get Murano fixed very soon, I would be fine releasing Murano as-is and fix it in stable release. Like I said, it's not the first time it happened (we usually realize it's broken after the release :)) | 08:17 |
| ttx | Ideally we'd post the release patch at least 24 hours before approving it to give people tie to +1 it | 08:18 |
| ttx | So if we don;t have a new Murano release in a couple of hours, I would move on | 08:19 |
| elodilles | ttx: i agree | 08:25 |
| ttx | (it seems to fail tests on more than just that oslo.context thing) | 08:26 |
| elodilles | yes, i just looked the results and saw now we are at the same failures than with the 'lower-constraints' job (which means, with oslo.context<4.0.0) | 08:28 |
| elodilles | this has passed meanwhile if you want to +2 it: https://review.opendev.org/c/openstack/releases/+/835544 | 08:29 |
| elodilles | (your trove release patch) | 08:29 |
| ttx | done | 08:30 |
| elodilles | \o/ | 08:31 |
| opendevreview | Merged openstack/releases master: Release Trove Yoga rc2 https://review.opendev.org/c/openstack/releases/+/835544 | 08:44 |
| elodilles | hmm, we have this as well: https://review.opendev.org/c/openstack/releases/+/835461 | 09:33 |
| elodilles | though this maybe contain a high important bug fix, but it's not release-critical and does not affect installation | 09:37 |
| elodilles | in my opinion | 09:38 |
| ttx | Since we are late anyway I'd consider fixing it, though | 09:38 |
| ttx | It seems to be rather simple and not very risky | 09:39 |
| ttx | and very visible bug | 09:39 |
| ttx | so I'd support including it | 09:40 |
| elodilles | ttx: hmmm, OK, let's review the patch and release it | 09:41 |
| ttx | I'll look up the patches | 09:41 |
| ttx | (in horizon) | 09:41 |
| elodilles | ttx: one more thing: this would need a RFE as well since horizon is in the upper-constraints.txt | 09:43 |
| ttx | ah hm | 09:43 |
| elodilles | maybe better to hold this release :/ | 09:43 |
| elodilles | (this is the bug btw: https://bugs.launchpad.net/horizon/+bug/1950659 ) | 09:44 |
| ttx | The trick is... I'm not sure that's a valid stable update. It does change behavior very significantly | 09:44 |
| ttx | so if we don;t release it pre-release, we create another issue | 09:44 |
| *** marios is now known as marios|ruck | 09:45 | |
| ttx | see https://review.opendev.org/c/openstack/horizon/+/835143/1/releasenotes/notes/keystone-admin-endpoint-no-longer-required-06a8d29dfdb3b1cd.yaml | 09:45 |
| elodilles | that's true :/ | 09:46 |
| ttx | What happens if we grant that RFE? | 09:48 |
| ttx | anything else needs to be re-released? | 09:48 |
| ttx | I feel like those days teh impact is limited | 09:49 |
| elodilles | well, we need upper-constraints.txt to be updated as soon as possible | 09:50 |
| elodilles | in that case | 09:51 |
| elodilles | and an ACK from prometheanfire | 09:51 |
| ttx | FTR that would be a +1 on https://review.opendev.org/c/openstack/releases/+/835461 | 09:52 |
| ttx | I find it normal to release horizon late -- after all it needs to digest changes in everything upstream of it | 09:53 |
| ttx | but yeah that's about as late as it can get | 09:53 |
| elodilles | yepp, that is the generated patch, we need | 09:54 |
| zigo | FYI, trove-dashboard needs another release, including this patch: https://review.opendev.org/c/openstack/trove-dashboard/+/833497 | 10:29 |
| zigo | It's currently broken with latest Horizon release, since https://review.opendev.org/c/openstack/horizon/+/816303 | 10:29 |
| zigo | Though the package seems still broken ... | 10:30 |
| ttx | that one could be a stable release | 10:42 |
| ttx | once it's unbroken | 10:42 |
| elodilles | i agree with ttx | 10:47 |
| fungi | okay, i'm awake and catching up. sounds like murano is a long shot, the second trove fix bounced out of the gate but has been rechecked, anything else to do related to the oslo.context tenant removal? | 11:22 |
| ttx | I think we are good. Murano is a pretty long shot at this point, we are holding on Horizon RFE before regenerating the final release patch | 11:24 |
| elodilles | fungi: trove is released and sahara as well | 11:24 |
| ttx | everything else is A-OK | 11:24 |
| fungi | oh trove got through on the second try? excellent! | 11:25 |
| elodilles | yepp | 11:26 |
| elodilles | so yes, now horizon (22.1.0) is the question -- https://review.opendev.org/c/openstack/releases/+/835461 | 11:26 |
| elodilles | though it's not a cycle-with-rc so we won't need to update anything in yoga-final patch | 11:28 |
| *** dviroel|out is now known as dviroel | 11:28 | |
| elodilles | so far with ttx we discussed this and found that it would be better to release it - despite how late we are with it ( https://meetings.opendev.org/irclogs/%23openstack-release/%23openstack-release.2022-03-29.log.html#t2022-03-29T09:33:16 ) | 11:30 |
| elodilles | prometheanfire: ^^^ if you are around and could share your opinion that would be awesome | 11:30 |
| fungi | elodilles: you may be right about needing to bump oslo.context in murano's lower-constraints job. hberaud: do you happen to know off the top of your head what the earliest version of oslo.context is which should work with project_id instead of tenant? | 12:24 |
| elodilles | fungi: hberaud is on PTO today and tomorrow | 12:36 |
| fungi | i'll try to work it out fro the release notes | 12:36 |
| fungi | thanks! | 12:36 |
| elodilles | unfortunately releasenotes are mostly empty :( | 12:39 |
| elodilles | https://docs.openstack.org/releasenotes/oslo.context/ | 12:39 |
| fungi | yeah. i grepped for tenant and only found the most recent one where it's removed | 12:41 |
| fungi | same for project id | 12:41 |
| fungi | so i guess i'll have to resort to git log | 12:41 |
| fungi | project_id seems to be in use as far back as when the files got reshuffled in 2014 | 12:43 |
| fungi | i'm trying to find where tenant was actually logged as a deprecation or documented | 12:45 |
| fungi | no luck. seems like it's just been assumed to be deprecated but never really called out anywhere as such that i can find | 12:49 |
| fungi | the commit message for the removal simply asserts "The tenant argument of RequestContext have been deprecated long time ago" but doesn't seem to remove any actual deprecation warnings or logging or documentation notices | 12:51 |
| elodilles | weird | 12:52 |
| fungi | i'll try raising the lower constraint to 3.0.0 and see what happens | 12:52 |
| elodilles | i'm now testing locally the l-c job | 12:52 |
| elodilles | OK, 4.0.0 works, 3.4.0 does not :'( | 12:53 |
| fungi | huh, maybe the l-c bump in that trove change was needed after all, then | 12:53 |
| elodilles | so something is fishy here | 12:54 |
| elodilles | yes, it seems that is needed | 12:54 |
| fungi | there were only two non-merge commits between 3.4.0 and 4.0.0 | 12:54 |
| fungi | one is a testing change | 12:55 |
| fungi | the other is the tenant removal change | 12:55 |
| fungi | anyway, i don't put much stock in the lower-constraints jobs, if we can work around this by upping the minimum for oslo.context to 4.0.0 there, it's fine by me | 13:00 |
| elodilles | it's OK to me too, as the l-c test clearly shows 4.0.0 is needed | 13:01 |
| elodilles | zhurong decided to drop the l-c job instead | 13:02 |
| fungi | oh, that's fine by me then | 13:05 |
| fungi | it would be irrelevant in stable/yoga anyway (or should be) since we previously got consensus that lower-constraints jobs aren't really maintainable on stable branches | 13:06 |
| elodilles | yepp, there are projects who dropped lc completely from their stable branches | 13:08 |
| elodilles | now this is master branch though :S | 13:09 |
| fungi | it's also a project with very nominal levels of maintenance, so i completely understand if its maintainer(s) think also supporting the lower-constraints job in master is too much for them | 13:10 |
| *** amoralej|off is now known as amoralej | 13:23 | |
| prometheanfire | elodilles: I'm out today for house move | 13:56 |
| opendevreview | Elod Illes proposed openstack/releases master: Add release note link for heat https://review.opendev.org/c/openstack/releases/+/835632 | 14:00 |
| elodilles | prometheanfire: oh, ack, that sounds fun :] ... or it depends. o:) enjoy the new place! :) | 14:03 |
| elodilles | ttx: then the decision about horizon is on us :) | 14:04 |
| prometheanfire | ya, it's a good thing | 14:07 |
| elodilles | that's cool then :] | 14:14 |
| elodilles | ttx: I've +2'd the horizon release patch then - https://review.opendev.org/c/openstack/releases/+/835461 | 14:14 |
| ttx | horizon is a go! | 14:40 |
| ttx | elodilles: I propose we regenerate the release patch once that lands | 14:41 |
| ttx | Murano will not be perfect but I can live with that | 14:42 |
| ttx | (I did push for its retirement last August, i stand by that) | 14:43 |
| ttx | or did I miss a Murano fix? | 14:43 |
| ttx | oh, I did | 14:44 |
| fungi | backport is in the gate now | 14:44 |
| elodilles | ttx: the murano fix is in the gate queue | 14:44 |
| fungi | other contributors fixed up my patch to be much less terrible ;) | 14:44 |
| elodilles | i'll prepare an rc2 patch for murano, i'll need review on that, and then i'll update the yoga-final patch | 14:45 |
| elodilles | ttx: one minor patch to land: https://review.opendev.org/c/openstack/releases/+/835632 | 14:46 |
| elodilles | (reno link for heat) | 14:46 |
| opendevreview | Merged openstack/releases master: Release horizon 22.1.0(Yoga) https://review.opendev.org/c/openstack/releases/+/835461 | 14:56 |
| ttx | +2 | 14:57 |
| elodilles | +2+W | 14:57 |
| elodilles | ~o~ | 14:58 |
| fungi | w00t | 15:06 |
| opendevreview | Merged openstack/releases master: Add release note link for heat https://review.opendev.org/c/openstack/releases/+/835632 | 15:16 |
| *** dviroel is now known as dviroel|lunch | 15:17 | |
| clarkb | fungi: catching up on release status seems we are good with oslo.context but what about the setuptools issue with multiple packages and needing a virtualenv/tox update? | 15:30 |
| fungi | clarkb: if tox gets updated then all will be fine, otherwise we need to put a workaround in place | 15:31 |
| fungi | (i think a workaround was merged to the script already?) | 15:31 |
| clarkb | fungi: release script you mean? | 15:37 |
| fungi | yes | 15:37 |
| fungi | er, not tox, virtualenv release i mean | 15:37 |
| clarkb | ok definitely ping if I can help debug further or review changes or figure out a workaround | 15:38 |
| fungi | clarkb: https://review.opendev.org/835423 Pin setuptools for Yoga release | 15:39 |
| clarkb | https://github.com/pypa/virtualenv/pull/2324 is still open with no reviews | 15:39 |
| fungi | looks like it worked there because that doesn't rely on constraints | 15:39 |
| fungi | and yeah, https://github.com/pypa/virtualenv/pull/2324 doesn't seem to be getting fast-tracked so i wouldn't bank on it merging today | 15:39 |
| clarkb | oh intereting if you put virtualenv in requires for tox it figure out how to use tha virtualenv for the test envs? | 15:40 |
| fungi | yeah | 15:41 |
| elodilles | sorry, yes, the setuptools WA has been merged today morning. it solves our problem | 15:42 |
| elodilles | i've tested it in some early patch set ( https://review.opendev.org/c/openstack/releases/+/835423/2/ ) | 15:43 |
| elodilles | after the release we can revert this actually, and the packages can fix the 'multiple top level' issue by themselves | 15:44 |
| elodilles | (which technically means they need to merge these patches: https://review.opendev.org/q/topic:setuptools-issue-3197 ) | 15:45 |
| clarkb | cool thanks for confirming that was addressed | 15:46 |
| *** amoralej is now known as amoralej|off | 15:47 | |
| fungi | in theory, pbr could grow an option to make that unnecessary too | 16:07 |
| fungi | having pbr build a manifest from everything tracked by git makes the autodiscovery of python files in setuptools quite redundant, so would probably just disable it and maybe throw in a toggle to allow it to still run in case it's needed for some unusual circumstances | 16:09 |
| ttx | Still in gate | 16:10 |
| ttx | elodilles: will you be around to push the final release patch before EOD? | 16:11 |
| elodilles | ttx: sure, i'll be here | 16:14 |
| elodilles | i'm waiting for the murano patch to merge, then propose the release patch | 16:15 |
| elodilles | it would be good if you could review that | 16:15 |
| elodilles | and after that i'll update the yoga-final patch | 16:15 |
| opendevreview | Elod Illes proposed openstack/releases master: [murano] Release RC2 for Yoga https://review.opendev.org/c/openstack/releases/+/835663 | 16:19 |
| elodilles | it has merged, and here is the release patch ^^^ | 16:19 |
| elodilles | please review it | 16:19 |
| elodilles | fungi: hmmm, that pbr feature sounds fancy! | 16:20 |
| elodilles | i mean, nice :) | 16:21 |
| *** dviroel|lunch is now known as dviroel | 16:21 | |
| fungi | elodilles: the fancy part is what pbr already does (generates the MANIFEST.in file based on git ls-files, more or less), it's just that setuptools also separately tries to find your python files and that's what's started breaking with the ultiple top-level packages error | 16:26 |
| elodilles | i see :-o | 16:28 |
| *** sfinucan is now known as stephenfin | 16:31 | |
| elodilles | ttx: btw, this horizon constraints lift patch needs review too (when the gate is ready with the testing): https://review.opendev.org/c/openstack/requirements/+/835647 | 16:31 |
| ttx | elodilles: I posted my +2 ahead of the check result | 16:31 |
| fungi | elodilles: the murano stable/yoga change just merged | 16:32 |
| elodilles | ttx: thanks \o/ | 16:32 |
| fungi | ahh, i see i'm late to the party, you already said that | 16:32 |
| ttx | Feel free to +2a later. Also you should rebase https://review.opendev.org/c/openstack/releases/+/835322 on top of the murano patch | 16:33 |
| elodilles | fungi: :) we just need the gate to finish with the testing there (with the release patch) | 16:33 |
| elodilles | ttx: ack, will do that! | 16:33 |
| *** marios|ruck is now known as marios|out | 16:34 | |
| ttx | elodilles: murano release ready for +2a | 16:59 |
| ttx | ame for requirements patch | 17:00 |
| ttx | updated https://etherpad.opendev.org/p/tenant-projectid-last-minute-fixes | 17:01 |
| ttx | I did +2s murano rc2 | 17:02 |
| ttx | +2a | 17:02 |
| elodilles | thanks (i was slow, but did the same :D) | 17:06 |
| elodilles | by requirements patch you mean the horizon one? or is there something else? :-o | 17:07 |
| opendevreview | Merged openstack/releases master: [murano] Release RC2 for Yoga https://review.opendev.org/c/openstack/releases/+/835663 | 17:20 |
| opendevreview | Elod Illes proposed openstack/releases master: Yoga final releases for cycle-with-rc projects https://review.opendev.org/c/openstack/releases/+/835322 | 17:28 |
| opendevreview | Elod Illes proposed openstack/releases master: Mark Yoga as released https://review.opendev.org/c/openstack/releases/+/835323 | 17:28 |
| elodilles | there we go ^^^ | 17:28 |
| fungi | the anticipation is unbearable ;) | 17:42 |
| elodilles | and the suspense is terrible :S :) | 17:46 |
| elodilles | and it will last for a while as yoga-final patch is quite heavy :-o | 17:49 |
| fungi | yup | 17:50 |
| *** dviroel is now known as dviroel|out | 20:50 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!