Wednesday, 2021-02-17

« Tuesday, 2021-02-16 Index Thursday, 2021-02-18 »
*** xarlos has quit IRC00:07
*** e0ne has joined #openstack-release00:31
*** e0ne has quit IRC00:35
*** brinzhang has joined #openstack-release01:10
*** ricolin has joined #openstack-release01:29
*** e0ne has joined #openstack-release02:32
*** e0ne has quit IRC02:37
*** ricolin has quit IRC04:16
*** e0ne has joined #openstack-release04:32
*** vishalmanchanda has joined #openstack-release04:36
*** e0ne has quit IRC04:37
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-release05:33
*** whoami-rajat__ has joined #openstack-release06:12
*** ricolin has joined #openstack-release06:29
*** mnaser has quit IRC06:32
*** e0ne has joined #openstack-release06:33
*** mnaser has joined #openstack-release06:34
*** e0ne has quit IRC06:38
*** slaweq has joined #openstack-release07:07
*** sboyron has joined #openstack-release07:56
*** ricolin has quit IRC08:08
*** rpittau|afk is now known as rpittau08:12
*** ricolin_ has joined #openstack-release08:12
*** ricolin_ is now known as ricolin08:17
*** eolivare has joined #openstack-release08:21
*** e0ne has joined #openstack-release08:34
*** e0ne has quit IRC08:38
*** xarlos has joined #openstack-release08:43
*** e0ne has joined #openstack-release08:45
*** jbadiapa has joined #openstack-release08:46
*** tosky has joined #openstack-release09:14
*** tosky_ has joined #openstack-release09:20
*** tosky has quit IRC09:24
*** tosky_ is now known as tosky09:25
*** jbadiapa has quit IRC09:29
*** evrardjp has quit IRC09:46
*** evrardjp has joined #openstack-release09:48
*** dtantsur|afk is now known as dtantsur10:01
*** prometheanfire has quit IRC10:42
*** e0ne has quit IRC10:53
*** prometheanfire has joined #openstack-release11:02
*** e0ne has joined #openstack-release11:05
openstackgerritBrian Rosmaita proposed openstack/releases master: Release cinder 18.0.0.0b1  https://review.opendev.org/c/openstack/releases/+/77611411:44
*** e0ne has quit IRC12:06
*** eolivare has quit IRC12:09
*** jbadiapa has joined #openstack-release12:49
*** jbadiapa has quit IRC12:50
*** jbadiapa has joined #openstack-release12:51
openstackgerritMerged openstack/releases master: Update the project owner  https://review.opendev.org/c/openstack/releases/+/77232213:04
openstackgerritMerged openstack/releases master: Release IPA bugfix/6.6.0 for wallaby  https://review.opendev.org/c/openstack/releases/+/77537813:06
openstackgerritMerged openstack/releases master: os-traits 2.5.0  https://review.opendev.org/c/openstack/releases/+/77580413:09
*** e0ne has joined #openstack-release13:09
openstackgerritMerged openstack/releases master: Release placement for stable/train  https://review.opendev.org/c/openstack/releases/+/77309313:09
*** eolivare has joined #openstack-release13:19
*** nweinber has joined #openstack-release13:26
*** xarlos has quit IRC14:10
*** e0ne has quit IRC14:28
*** e0ne has joined #openstack-release14:29
openstackgerritHervé Beraud proposed openstack/releases master: Ensure that we can build sdist from requested tags  https://review.opendev.org/c/openstack/releases/+/77620614:31
openstackgerritHervé Beraud proposed openstack/releases master: DNM - testing POC for sdist tests on tags  https://review.opendev.org/c/openstack/releases/+/77620714:31
hberaudttx, elod ^ here is a new test to try to protect us against problem similar to os-collect-config/tripleo-ipsec recent issues (missing stable branches and tag creation)14:32
hberaudPreviously we only tried to build sdist for a specific commit context and not from tag, I think this is why we didn't see validation errors previously14:35
openstackgerritHervé Beraud proposed openstack/releases master: Ensure that we can build sdist from requested tags  https://review.opendev.org/c/openstack/releases/+/77620614:38
openstackgerritHervé Beraud proposed openstack/releases master: DNM - testing POC for sdist tests on tags  https://review.opendev.org/c/openstack/releases/+/77620714:38
*** jhesketh has quit IRC14:52
*** brinzhang has quit IRC14:55
elodhberaud: thx \o/ sounds like14:55
eloda good improvement!14:55
*** brinzhang has joined #openstack-release14:55
elodwill review it, when I get there :)14:55
hberaudhopefully yes14:56
hberaudthanks14:56
hberaudno rush14:56
*** brinzhang has quit IRC14:57
*** brinzhang has joined #openstack-release14:58
ttxhberaud: do we need to keep the other one?14:58
hberaudWhich one? the DNM?14:58
hberaudttx: ^14:58
ttxno the try to build sdist for a specific commit14:58
hberaudah14:59
hberaudhm... can't hurt14:59
* ttx checks how much time it takes14:59
hberaudI'm not sure to see the functional use case but I think we can keep it14:59
ttxit does hurt if it eats resources :)14:59
hberaudyes :)14:59
*** slaweq has quit IRC15:00
hberaudlocally I didn't see significant performance impacts15:00
ttxhmm, it feels like your DNM test is actually failing several things, including the original sdist build15:01
*** slaweq has joined #openstack-release15:04
ttx(fails validate_build_sdist validate_build_sdist_from_tag validate_pypi_readme validate_tarball_base)15:04
ttxso it fails superfast15:05
ttxhberaud: so I'm not sure the test proves anything15:06
hberaudthe new one or the previous?15:07
ttxI think your DNM would also fail without the new test added15:07
ttxsince it generates 4 errors15:07
hberaudyes probably15:08
ttxthat repo is borked at this point, so it will fail all tests15:08
ttxThe trick is how to avoid introducing the bork15:08
hberaudHowever why it doesn't failed with => https://review.opendev.org/c/openstack/releases/+/77204715:09
ttxmaybe your test catches it, but the DNM does not prove that15:09
hberaudyes I see15:09
ttxIdeally we'd find a repo that is in the same state and would try to push a tag to it, basically reproduce 772047 false positive15:09
ttxthen check that your added test catches it15:10
ttxbut I'm not sure we have one of those around15:11
hberaudI think that if we search for unbranched repo on victoria or ussuri and if we try to release a tag on similar sha than the latest we could be able to reproduced15:11
hberaudreproduce15:11
hberauddo we have a command to retrieve unbranched repos?15:12
hberaudfor a specific series15:12
ttxchecking quickly15:12
ttxa grep could do it15:12
hberaudcould be useful to have this kind of command15:12
hberaudyes15:12
ttxgrep -L stable/ussuri deliverables/ussuri/*15:13
hberaudpatrole could be an entrypoint15:13
hberaudos-refresh-config too15:14
hberaudall the rest seems to be tempest plugin so they are branch less projects15:14
ttxthere was no release at all there, but i guess that could work15:14
ttx(os-refresh-config)15:15
gmannttx: hberaud patrole is also tempest plugins and branchless15:15
gmannits name does not reflect that though15:15
hberaudos-refresh-config is perfect15:15
hberauddeliverables/wallby/os-refresh-config.yaml contains a version 13.0.015:15
hberaudso we are in the same scenario15:16
ttxok so tagging a 11.0.0 on ussuri15:16
hberaudgmann: ack thanks gmann15:16
hberaudyes15:16
ttxhberaud: ok, maybe try withut your change first, to check if it would pass tests15:16
hberaudlet me transform my DNM15:16
hberaudyes15:16
ttxthen we can check we are in the same situation15:17
ttxhberaud: regarding your test... i was wondering if just adding the tag  before building the sdist in validate_build_sdist would do it15:19
openstackgerritHervé Beraud proposed openstack/releases master: DNM - test create tag on unbranched series  https://review.opendev.org/c/openstack/releases/+/77621515:19
ttxbecause currently you try: build an sdist from desired SHA / build sdist from tag on HEAD15:19
ttxIt feels like we should be testing "build an sdist from tag on desired SHA"15:20
hberaudwyes15:20
hberaudyes15:20
hberaudthe test ^15:20
ttxso  maybe add gitutils.add_tag on line 81515:20
ttxand remove the new test15:20
ttxIf that catches it I think we are good15:21
hberaudIf validation doesn't fail with ^ I'll update my test as you suggest and cherry-pick it as a parent commit of this one15:21
ttxI'll comment to that effect15:22
hberaudack15:22
hberaudlocally validation pass15:25
hberaudwithout catching anything15:25
ttxok let's see if Zuul also fails to detect it15:26
hberaudand it pass with my test too..15:26
hberaudso my test is bad15:26
hberaudby moving git tag to line 815 I'm able to catch the error15:34
openstackgerritHervé Beraud proposed openstack/releases master: Ensure that we can build sdist from requested tags  https://review.opendev.org/c/openstack/releases/+/77620615:35
openstackgerritHervé Beraud proposed openstack/releases master: DNM - test create tag on unbranched series  https://review.opendev.org/c/openstack/releases/+/77621515:35
hberaudlet's retry with the fixed version15:35
hberaudand against os-refresh-config15:36
hberaudhm15:44
hberaud2021-02-17 15:41:59.983450 | ubuntu-focal | WARNING: failed to add tag: Command '['git', 'tag', '-m', 'temporary tag', '11.0.0', '754bb751e6728aafa680111a6fab3013609654cc']' returned non-zero exit status 128. [b'*** Please tell me who you are.\n\nRun\n\n  git config --global user.email "you@example.com"\n  git config --global user.name "Your Name"\n\nto set your account\'s default identity.\nOmit15:44
hberaud--global to set the identity only in this repository.\n\nfatal: unable to auto-detect email address (got \'zuul@ubuntu-focal-ovh-bhs1-0023062756.(none)\')']15:44
hberaudThis is why the test didn't failed on the gates15:45
hberaudAnd it's why it works locally (because config is defined)15:46
hberaudthe tag wasn't created so the sdist build worked15:46
hberaudi'll try to call ensure_basic_git_config15:48
openstackgerritHervé Beraud proposed openstack/releases master: Ensure that we can build sdist from requested tags  https://review.opendev.org/c/openstack/releases/+/77620615:52
openstackgerritHervé Beraud proposed openstack/releases master: DNM - test create tag on unbranched series  https://review.opendev.org/c/openstack/releases/+/77621515:52
hberaudthird round15:52
openstackgerritIury Gregory Melo Ferreira proposed openstack/releases master: Release ironic client 4.6.0 for Wallaby  https://review.opendev.org/c/openstack/releases/+/77622216:00
hberaudThat work \o/16:11
openstackgerritHervé Beraud proposed openstack/releases master: Ensure that we can build sdist from requested tags  https://review.opendev.org/c/openstack/releases/+/77620616:17
openstackgerritHervé Beraud proposed openstack/releases master: DNM - test create tag on unbranched series  https://review.opendev.org/c/openstack/releases/+/77621516:17
*** slaweq has quit IRC16:53
openstackgerritDmitriy Rabotyagov proposed openstack/releases master: Release OpenStack-Ansible Train  https://review.opendev.org/c/openstack/releases/+/77623416:59
openstackgerritDmitriy Rabotyagov proposed openstack/releases master: Release OpenStack-Ansible Ussuri  https://review.opendev.org/c/openstack/releases/+/77623617:04
*** dtantsur is now known as dtantsur|afk17:17
*** eolivare has quit IRC17:28
*** rpittau is now known as rpittau|afk17:41
*** slaweq has joined #openstack-release18:23
*** e0ne has quit IRC18:46
*** slaweq has quit IRC19:20
*** e0ne has joined #openstack-release19:48
*** elod has quit IRC20:17
*** elod has joined #openstack-release20:19
*** slaweq has joined #openstack-release20:46
*** armstrong has joined #openstack-release20:50
*** e0ne has quit IRC21:24
*** vishalmanchanda has quit IRC21:37
*** gmann is now known as gmann_afk21:51
*** slaweq has quit IRC22:02
*** whoami-rajat__ has quit IRC22:09
*** nweinber has quit IRC22:22
*** jhesketh has joined #openstack-release22:32
*** armstrong has quit IRC23:00
*** sboyron has quit IRC23:07
*** gmann_afk is now known as gmann23:22
*** prometheanfire has quit IRC23:27
*** prometheanfire has joined #openstack-release23:51
« Tuesday, 2021-02-16 Index Thursday, 2021-02-18 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!