*** tosky has quit IRC | 00:09 | |
*** mlavalle has quit IRC | 00:26 | |
*** armstrong has quit IRC | 00:42 | |
*** tetsuro has joined #openstack-release | 01:07 | |
*** portdirect has quit IRC | 01:12 | |
*** mordred has quit IRC | 01:14 | |
*** hberaud has quit IRC | 01:14 | |
*** mordred has joined #openstack-release | 01:15 | |
*** portdirect has joined #openstack-release | 01:15 | |
*** hberaud has joined #openstack-release | 01:16 | |
*** ekcs has quit IRC | 01:47 | |
*** tetsuro has quit IRC | 01:56 | |
*** tetsuro has joined #openstack-release | 01:56 | |
*** tetsuro has quit IRC | 03:13 | |
*** tetsuro has joined #openstack-release | 03:22 | |
*** tetsuro_ has joined #openstack-release | 03:28 | |
*** tetsuro has quit IRC | 03:30 | |
*** tetsuro_ has quit IRC | 03:33 | |
*** tetsuro has joined #openstack-release | 03:34 | |
*** tetsuro_ has joined #openstack-release | 03:47 | |
*** tetsuro has quit IRC | 03:48 | |
*** ykarel|away is now known as ykarel | 03:51 | |
*** raukadah is now known as chandankumar | 04:11 | |
*** AJaeger has joined #openstack-release | 05:02 | |
AJaeger | release team, please merge https://review.opendev.org/708918 to update jobs | 05:02 |
---|---|---|
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-release | 05:34 | |
*** ekcs has joined #openstack-release | 05:38 | |
*** ekcs has quit IRC | 05:43 | |
*** ricolin has quit IRC | 06:15 | |
*** ricolin has joined #openstack-release | 07:21 | |
*** lpetrut has joined #openstack-release | 07:39 | |
*** rpittau|afk is now known as rpittau | 07:50 | |
*** slaweq has joined #openstack-release | 08:00 | |
rakhmerov | hi, can we backport patches with changes in setup.cfg? | 08:05 |
rakhmerov | e.g. changes in stevedore entry points | 08:05 |
rakhmerov | ttx: hi, may be you can advise | 08:05 |
AJaeger | rakhmerov: could those break existing code? | 08:13 |
rakhmerov | well, no | 08:13 |
AJaeger | rakhmerov: I mean: Adding lines is fine, changing sounds like breaking the API | 08:13 |
rakhmerov | that's what I'm trying to understand | 08:13 |
rakhmerov | let me show you... | 08:13 |
rakhmerov | https://review.opendev.org/#/c/709057/4/setup.cfg | 08:14 |
rakhmerov | I understand that it's not desirable to backport such patches, but I'm in the middle of making changes that I want to backport on top of this patch | 08:14 |
rakhmerov | it will be easier for me to finish them if this patch can also be backported | 08:15 |
rakhmerov | I'm changing code, yes, and setup.cfg so that a project needs to be reinstalled anyway | 08:15 |
rakhmerov | but I don't break API, main config file, DB schema etc. | 08:15 |
AJaeger | rakhmerov: those lines look fine in that file - but to me it looks like it shows you break the API elsewhere. | 08:17 |
rakhmerov | API? Why? | 08:17 |
AJaeger | rakhmerov: I hear you - let's see what others say, might want to talk with stable team as well | 08:17 |
rakhmerov | no, those python changes are not part of the API | 08:17 |
rakhmerov | AJaeger: ok | 08:17 |
rakhmerov | thanks | 08:17 |
AJaeger | rakhmerov: you might be right - I don't know the code good enough. It just smells like API change ;) | 08:18 |
rakhmerov | no-no, I reassure you :) | 08:18 |
AJaeger | ;) | 08:24 |
rakhmerov | AJaeger: also wrote this question to #openstack-stable | 08:25 |
*** tetsuro_ has quit IRC | 08:26 | |
*** tosky has joined #openstack-release | 08:27 | |
*** ykarel is now known as ykarel|lunch | 08:47 | |
*** tetsuro has joined #openstack-release | 08:51 | |
*** ykarel|lunch is now known as ykarel | 08:55 | |
*** e0ne has joined #openstack-release | 08:59 | |
*** e0ne has quit IRC | 08:59 | |
*** e0ne has joined #openstack-release | 09:00 | |
*** tetsuro has quit IRC | 09:03 | |
ttx | hi! | 10:05 |
ttx | AJaeger: done | 10:05 |
AJaeger | thanks, ttx! | 10:06 |
ttx | rakhmerov: It's more of a stable question, but we have limited activity in #openstack-stable those days | 10:08 |
ttx | rakhmerov: it's definitely a grey area, I think it would be worth raising it on the ML to get wider feedback | 10:08 |
ttx | My personal 2c would be: we avoid refactoring in stable patches, especially if that refactoring ends up affecting public function names, and even more if those are exposed by setup.cfg. But I guess it's a trade-off with how important it is to backport the patch that lives on top of that refactoring... and how painful it would be to adapt that patch so that it would live on top of non-refactored | 10:11 |
ttx | code | 10:11 |
rakhmerov | ttx: ok, got it | 10:12 |
rakhmerov | I'll try to avoid backporting it I guess | 10:12 |
ttx | I can think of a few examples where a security patch lived on top of lightly-refactored code that was affectign public, but rarely-used functions... and that was deemed a good trade-off | 10:13 |
ttx | But here it sounds like a bit too far on the "user-visible change to facilitate unrelated backporting" side | 10:14 |
openstackgerrit | Merged openstack/releases master: Update docs publishing job https://review.opendev.org/708918 | 10:26 |
*** jbadiapa has joined #openstack-release | 10:31 | |
openstackgerrit | Merged openstack/releases master: Release Adjutant 0.5.0 https://review.opendev.org/708794 | 10:57 |
*** haleyb|away has quit IRC | 11:15 | |
*** ykarel is now known as ykarel|afk | 11:16 | |
*** N3l1x has joined #openstack-release | 11:30 | |
*** ykarel|afk is now known as ykarel | 11:42 | |
*** rpittau is now known as rpittau|bbl | 11:43 | |
evrardjp | rakhmerov: (and ttx) my opinion is that it's indeed in grey area -- though here the functions exposed aren't changed themselves, only their implementation in setup.cfg. So for me, this is only a refactor, not an interface change. An interface change in stable is a no-go by default (basically unless no choice). The refactor in a stable branch is, for me, up to the project, but there is probably not many reasons to want | 11:49 |
evrardjp | this, except to backport other bugfixes later in an easier fashion. In any case, that should be documented on _why_ it is done . | 11:49 |
*** dtantsur|afk is now known as dtantsur | 12:06 | |
*** ricolin has quit IRC | 12:14 | |
*** adriant has quit IRC | 12:53 | |
*** adriant has joined #openstack-release | 12:54 | |
*** rpittau|bbl is now known as rpittau | 13:00 | |
*** ykarel is now known as ykarel|afk | 13:22 | |
*** rpittau is now known as rpittau|afk | 13:57 | |
*** mlavalle has joined #openstack-release | 14:00 | |
*** mgoddard has joined #openstack-release | 14:08 | |
mgoddard | Hello, I'd like to release some kayobe branches that existed prior to becoming an official deliverable. | 14:08 |
mgoddard | Is there someone that can help with that? | 14:08 |
mgoddard | I'd like 6.1.0 on stable/stein, and 5.1.0 on stable/rocky | 14:09 |
openstackgerrit | Merged openstack/releases master: Release os-brick 3.0.0 https://review.opendev.org/708957 | 14:26 |
smcginnis | mgoddard: Pre-official deliverables would have had to have been done directly by the team. | 14:33 |
smcginnis | mgoddard: Not sure about the ACLs, but you would just need to push a tag on those branches. | 14:33 |
mgoddard | hmm, I assumed it wouldn't work, but let me try | 14:34 |
smcginnis | ttx: Do we have any similar situations in the past for that? ^ | 14:35 |
mgoddard | ! [remote rejected] 6.1.0 -> 6.1.0 (prohibited by Gerrit) | 14:35 |
*** ykarel|afk is now known as ykarel | 15:34 | |
ttx | No, branches need to be created manually | 15:52 |
ttx | hmm, sorry let me have a look | 15:52 |
ttx | Ah yeah, the issue is that you are limited by the ACL. We can probably push those mnanually for you | 15:53 |
ttx | IIRC members of the "Release Managers" group should be able to push the tag, doublechecknig | 15:54 |
ttx | or infra | 15:55 |
ttx | smcginnis: so we should push the signed tag, as the ACL is not branch-specific. Iguess we could make it branch-specific, but pushing it ourselves is simpler | 15:55 |
openstackgerrit | Kristi Nikolla proposed openstack/releases master: stable/rocky releases for keystone deliverables https://review.opendev.org/709165 | 15:59 |
*** lpetrut has quit IRC | 16:09 | |
smcginnis | mgoddard: Looks like I can do that. To confirm before I do anything, that would be the following tags: | 16:20 |
smcginnis | tag 5.1.0 on stable/rocky, commit 755bc38ce1d4867855dae0cdee81269a1e14edf2 | 16:20 |
smcginnis | tag 6.1.0 on stable/stein, commit 26c8abc6642af90e1436b68c4fedad27c40f7cae | 16:21 |
mgoddard | smcginnis: +1 | 16:21 |
smcginnis | OK, I'll give it a shot now. | 16:21 |
mgoddard | thanks | 16:21 |
ttx | Feels like 2014 all over again | 16:25 |
smcginnis | :) | 16:25 |
*** e0ne has quit IRC | 16:27 | |
openstackgerrit | Merged openstack/releases master: Release ussuri beta1 of neutron and related projects https://review.opendev.org/708909 | 16:32 |
smcginnis | mgoddard: Post tagging release jobs are running. | 16:34 |
mgoddard | great, thanks smcginnis! | 16:36 |
smcginnis | No problem! | 16:39 |
*** ekcs has joined #openstack-release | 16:39 | |
smcginnis | ttx: Did you want me to put the proposed release schedule the ML? | 16:39 |
smcginnis | I think in the past we just decided, but I could be forgetting. | 16:40 |
*** ekcs has quit IRC | 16:43 | |
ttx | smcginnis: we decide, but it's good to open for comments, just in case we missed something obvious | 16:50 |
smcginnis | +1 | 16:50 |
openstackgerrit | Kristi Nikolla proposed openstack/releases master: stable/rocky releases for keystone deliverables https://review.opendev.org/709165 | 16:52 |
ttx | smcginnis: see https://review.opendev.org/#/c/709047/1 | 16:53 |
*** dtantsur is now known as dtantsur|afk | 17:16 | |
*** tosky has quit IRC | 17:23 | |
*** evrardjp has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-release | 17:35 | |
*** ekcs has joined #openstack-release | 17:53 | |
*** ekcs has quit IRC | 17:53 | |
openstackgerrit | Andreas Jaeger proposed openstack/releases master: Release openstack-doc-tools, os-api-ref,openstackdocstheme https://review.opendev.org/709200 | 17:53 |
*** diablo_rojo has joined #openstack-release | 17:59 | |
knikolla | smcginnis: i'm not quite sure why https://review.opendev.org/#/c/709165/ is failing on the sdist build. | 18:03 |
*** e0ne has joined #openstack-release | 18:08 | |
smcginnis | knikolla: Ah, it's a reno issue we've seen elsewhere. | 18:15 |
smcginnis | knikolla: You will need to do something like this: https://review.opendev.org/#/q/topic:reno-3.0.0+(status:open+OR+status:merged) | 18:15 |
smcginnis | AJaeger: Do you want to pick up that just merged URL fix for the openstackdocstheme release? | 18:17 |
AJaeger | smcginnis: yes, didn't I include it? | 18:17 |
smcginnis | AJaeger: Oh, maybe. I was just looking at the timing, and I didn't think it merged until after you had proposed the patch. | 18:18 |
AJaeger | smcginnis: I was lucky it just worked ;) | 18:18 |
smcginnis | Sorry, I actually looked at the list-changes output, and you did indeed get it. I should have looked first before saying anything. :) | 18:18 |
AJaeger | smcginnis: https://zuul.opendev.org/t/openstack/build/3ac45693384249c09fc4f74dd44c41c4/log/job-output.txt#1704 | 18:19 |
AJaeger | smcginnis: I was expecting to recheck because of the timing - and then it passed, so wondered already whether I screwed up... | 18:19 |
smcginnis | Very good timing. ;) | 18:20 |
AJaeger | ;) | 18:20 |
AJaeger | smcginnis: thanks for double checking! | 18:20 |
knikolla | smcginnis: would that patch get an exception to rule 4 or does it need to go through master->train->stein->rocky in succession? https://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes | 18:21 |
smcginnis | knikolla: Since it is just a release note configuration change, I do not think it needs to go step by step. Should be able to propose and merge it to all right away. | 18:21 |
*** ykarel is now known as ykarel|away | 18:24 | |
*** ekcs has joined #openstack-release | 18:25 | |
openstackgerrit | Merged openstack/releases master: Release openstack-doc-tools, os-api-ref,openstackdocstheme https://review.opendev.org/709200 | 18:32 |
*** openstackstatus has quit IRC | 18:33 | |
*** diablo_rojo has quit IRC | 18:36 | |
*** e0ne has quit IRC | 18:37 | |
*** diablo_rojo has joined #openstack-release | 18:37 | |
mlavalle | diablo_rojo: hey, for this year, are we only going to have this event: https://www.openstack.org/events/opendev-ptg-2020/? | 18:49 |
diablo_rojo_phon | mlavalle: no, there will be a summit + ptg in October as well | 18:53 |
mlavalle | diablo_rojo_phon: do we know where? | 18:53 |
mlavalle | sorry to bother, but I have to make a budget | 18:53 |
diablo_rojo_phon | mlavalle: Berlin. It was in the last foundation newsletter :) | 18:54 |
diablo_rojo_phon | No problem at all! | 18:54 |
knikolla | smcginnis: Thanks for all the help! I tried that locally and it seemed to work https://review.opendev.org/#/q/I28fd0fd499c40e33ff164fd643dadd6ac9009b17 | 18:57 |
mlavalle | diablo_rojo_phon: should we expect discount codes for code contributors? If yes, do you know how much would we pay? | 19:00 |
*** ekcs has quit IRC | 19:09 | |
*** ianychoi_ has joined #openstack-release | 19:15 | |
diablo_rojo_phon | mlavalle: I don't think it need decided yet but I think they were leaning towards not doing discounts this time? | 19:16 |
diablo_rojo_phon | I would email Kendall Waters about that one. | 19:17 |
*** ianychoi has quit IRC | 19:18 | |
*** chandankumar is now known as raukadah | 19:27 | |
*** ekcs has joined #openstack-release | 19:31 | |
*** diablo_rojo has quit IRC | 19:37 | |
*** diablo_rojo has joined #openstack-release | 19:37 | |
*** N3l1x has quit IRC | 19:51 | |
*** ekcs has quit IRC | 19:54 | |
mlavalle | diablo_rojo_phon: ah, ok, I'll ask your tocaya | 20:10 |
mlavalle | Thanks! | 20:10 |
*** AJaeger has left #openstack-release | 20:12 | |
*** e0ne has joined #openstack-release | 20:15 | |
diablo_rojo_phon | mlavalle: no problem! | 20:27 |
*** ekcs has joined #openstack-release | 20:28 | |
*** ekcs has quit IRC | 20:38 | |
*** ekcs has joined #openstack-release | 20:41 | |
*** e0ne has quit IRC | 21:38 | |
*** e0ne has joined #openstack-release | 21:39 | |
*** e0ne has quit IRC | 22:27 | |
*** ekcs has quit IRC | 22:44 | |
*** armstrong has joined #openstack-release | 22:44 | |
*** ekcs has joined #openstack-release | 22:47 | |
*** dhellmann_ has joined #openstack-release | 23:05 | |
*** dhellmann has quit IRC | 23:06 | |
*** dhellmann_ is now known as dhellmann | 23:06 | |
*** dave-mccowan has quit IRC | 23:11 | |
*** ekcs has quit IRC | 23:13 | |
*** ekcs has joined #openstack-release | 23:13 | |
*** dave-mccowan has joined #openstack-release | 23:29 | |
*** mlavalle has quit IRC | 23:29 | |
*** jbadiapa has quit IRC | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!