*** armax has quit IRC | 00:02 | |
*** yamahata has quit IRC | 00:35 | |
*** hongbin has quit IRC | 00:44 | |
openstackgerrit | Merged openstack/releases master: release os-vif 1.5.0 https://review.openstack.org/469649 | 01:01 |
---|---|---|
openstackgerrit | Merged openstack/releases master: pike: release os-traits 0.3.1 https://review.openstack.org/469670 | 01:04 |
*** mriedem has quit IRC | 01:06 | |
*** yolkfull_ has joined #openstack-release | 01:18 | |
*** ekcs_ has quit IRC | 01:24 | |
*** armax has joined #openstack-release | 02:23 | |
*** hongbin has joined #openstack-release | 02:27 | |
*** yolkfull_ has quit IRC | 02:27 | |
*** ttx has quit IRC | 02:45 | |
*** yolkfull_ has joined #openstack-release | 02:48 | |
*** ttx has joined #openstack-release | 02:51 | |
*** bobh has joined #openstack-release | 02:57 | |
*** udesale has joined #openstack-release | 03:02 | |
*** mriedem has joined #openstack-release | 03:04 | |
*** dave-mccowan has quit IRC | 03:16 | |
*** zhurong has joined #openstack-release | 03:27 | |
*** bobh has quit IRC | 03:30 | |
*** csomerville has joined #openstack-release | 03:31 | |
*** csomerville has quit IRC | 03:35 | |
*** cody-somerville has joined #openstack-release | 03:36 | |
*** cody-somerville has quit IRC | 03:36 | |
*** cody-somerville has joined #openstack-release | 03:36 | |
*** cody-somerville has quit IRC | 03:46 | |
*** mriedem has quit IRC | 04:18 | |
*** zhurong has quit IRC | 04:27 | |
*** kornica has quit IRC | 04:29 | |
*** cody-somerville has joined #openstack-release | 04:33 | |
*** cody-somerville has quit IRC | 04:33 | |
*** cody-somerville has joined #openstack-release | 04:33 | |
*** zhurong has joined #openstack-release | 04:36 | |
*** stevemar__ has joined #openstack-release | 04:40 | |
*** stevemar__ has quit IRC | 04:43 | |
*** pcaruana has joined #openstack-release | 04:43 | |
*** stevemar__ has joined #openstack-release | 04:44 | |
*** kornicameister has joined #openstack-release | 04:47 | |
*** stevemar__ has quit IRC | 04:48 | |
*** csomerville has joined #openstack-release | 05:01 | |
*** armax has quit IRC | 05:02 | |
*** cody-somerville has quit IRC | 05:04 | |
*** cody-somerville has joined #openstack-release | 05:08 | |
*** cody-somerville has quit IRC | 05:08 | |
*** cody-somerville has joined #openstack-release | 05:08 | |
*** csomerville has quit IRC | 05:10 | |
*** yamahata has joined #openstack-release | 05:11 | |
*** zhurong has quit IRC | 05:16 | |
*** zhurong has joined #openstack-release | 05:17 | |
*** hongbin has quit IRC | 05:22 | |
*** pcaruana has quit IRC | 05:49 | |
*** pcaruana has joined #openstack-release | 06:02 | |
*** jpich has joined #openstack-release | 07:00 | |
*** otherwiseguy has quit IRC | 07:06 | |
*** eranrom has joined #openstack-release | 07:07 | |
*** shardy has joined #openstack-release | 07:16 | |
*** stevebaker has quit IRC | 07:16 | |
*** tmorin has joined #openstack-release | 07:16 | |
*** claudiub has joined #openstack-release | 07:18 | |
*** eranrom has quit IRC | 07:26 | |
*** eranrom has joined #openstack-release | 07:31 | |
*** eranrom has quit IRC | 07:35 | |
*** eranrom has joined #openstack-release | 07:41 | |
*** yamahata has quit IRC | 07:44 | |
*** amoralej|off is now known as amoralej | 07:54 | |
*** alexchadin has joined #openstack-release | 07:55 | |
openstackgerrit | Julien Danjou proposed openstack/reno master: Remove Babel from setup.cfg and requirements https://review.openstack.org/469801 | 07:59 |
*** stevemar__ has joined #openstack-release | 08:15 | |
*** stevemar__ has quit IRC | 08:20 | |
*** yamahata has joined #openstack-release | 08:25 | |
*** lucas-afk is now known as lucasagomes | 08:27 | |
*** zhurong has quit IRC | 08:29 | |
*** electrofelix has joined #openstack-release | 08:36 | |
*** sheeprine has joined #openstack-release | 08:42 | |
*** pbandark has joined #openstack-release | 09:03 | |
*** yamahata has quit IRC | 09:22 | |
*** openstackstatus has quit IRC | 09:36 | |
*** openstackstatus has joined #openstack-release | 09:38 | |
*** ChanServ sets mode: +v openstackstatus | 09:38 | |
*** yolkfull has joined #openstack-release | 09:40 | |
*** yolkfull__ has joined #openstack-release | 09:42 | |
*** yolkfull_ has quit IRC | 09:42 | |
*** yolkfull__ has quit IRC | 09:43 | |
-openstackstatus- NOTICE: There is a known issue with setuptools 36.0.0 and errors about the "six" package. For current details see https://github.com/pypa/setuptools/issues/1042 and monitor #openstack-infra | 09:45 | |
*** yolkfull has quit IRC | 09:45 | |
*** shardy is now known as shardy_afk | 09:47 | |
*** sheeprine has quit IRC | 09:57 | |
*** dtantsur|afk is now known as dtantsur | 10:00 | |
*** yolkfull has joined #openstack-release | 10:03 | |
*** shardy_afk is now known as shardy | 10:05 | |
dims | ttx : dhellmann : o/ | 10:07 |
ttx | dims: o/ | 10:08 |
ttx | Several fails from last night | 10:09 |
*** wolverineav has joined #openstack-release | 10:09 | |
ttx | puppet-nova-releasenotes: http://logs.openstack.org/d9/d913ccd1ea88f3661c32b0fcfdac58d749cd4eb2/tag/puppet-nova-releasenotes/cefa30a/ | 10:10 |
dims | ttx : i saw this in a tweet, but we are affected too - http://logs.openstack.org/58/469658/2/gate/gate-releases-tox-validate-ubuntu-xenial/a688665/console.html#_2017-06-01_09_17_29_691978 | 10:10 |
ttx | Warning, treated as error: The deprecations section of releasenotes/notes/deprecate_live_migration_progress_timeout-1892fd37e5761891.yaml does not parse as a list of strings. Is the YAML input escaped properly? | 10:10 |
*** alexchadin has quit IRC | 10:11 | |
dims | the "::" may be throwing stuff off? https://review.openstack.org/#/c/464960/2/releasenotes/notes/deprecate_live_migration_progress_timeout-1892fd37e5761891.yaml | 10:12 |
ttx | maybe, the others have it as a lost | 10:12 |
ttx | list* | 10:12 |
ttx | Wondering why that was not caught earlier though | 10:13 |
* ttx looks at the others | 10:13 | |
ttx | openstack-ansible-announce-release: http://logs.openstack.org/2b/2b85a9d0ebf168c3bc73362ff1fe7a802c99dbc8/release/openstack-ansible-announce-release/a15ac4f/ | 10:13 |
ttx | send-mail failed with AttributeError: 'NoneType' object has no attribute 'split', which points to msg['to'] being None | 10:15 |
*** lucasagomes has quit IRC | 10:18 | |
ttx | beh, bit unclear too | 10:20 |
ttx | swift-releasenotes http://logs.openstack.org/2a/2a0aef949d0ecce5a495c4c0f75e392eceb905b6/tag/swift-releasenotes/83cbb75/ | 10:20 |
ttx | Warning, treated as error: <reno.sphinxext origin/stable/newton>:1:Unexpected indentation. | 10:21 |
ttx | (the other swift one is similar) | 10:21 |
*** lucasagomes has joined #openstack-release | 10:25 | |
ttx | Looks similar to the first one -- releasenotes job being extra picky | 10:25 |
ttx | the openstack-ansible-announce-release one is probably due to the previous failure: TypeError: Can't mix strings and bytes in path components, generated from reno scanner.py line 1017 fullpath = os.path.join(notesdir, path) | 10:32 |
ttx | resulting in a truncated relnotes file that send-mail can't send | 10:33 |
ttx | will continue debugging after lunch | 10:34 |
*** zhurong has joined #openstack-release | 10:34 | |
dims | ack ttx | 10:38 |
*** Dinesh_Bhor has joined #openstack-release | 10:49 | |
*** tellesnobrega has quit IRC | 11:01 | |
*** dave-mccowan has joined #openstack-release | 11:08 | |
*** amoralej is now known as amoralej|lunch | 11:09 | |
*** alexchadin has joined #openstack-release | 11:16 | |
*** otherwiseguy has joined #openstack-release | 11:23 | |
*** udesale has quit IRC | 11:33 | |
*** shardy has quit IRC | 11:36 | |
ttx | for the -releasenotes jobs i'm wondering if that's not because we caught sphinx 1.6.2 recently | 11:39 |
ttx | the -announce-release fail is pretty weird, let's wait for dhellmann on that one | 11:40 |
*** lucasagomes is now known as lucas-hungry | 11:41 | |
*** tellesnobrega has joined #openstack-release | 11:43 | |
*** shardy has joined #openstack-release | 11:58 | |
*** bobh has joined #openstack-release | 12:00 | |
*** stevemar__ has joined #openstack-release | 12:12 | |
*** amrith has quit IRC | 12:14 | |
*** bobh has quit IRC | 12:14 | |
*** amrith has joined #openstack-release | 12:15 | |
*** zhurong has quit IRC | 12:16 | |
*** amoralej|lunch is now known as amoralej | 12:17 | |
*** lucas-hungry is now known as lucasagomes | 12:22 | |
*** stevemar__ has quit IRC | 12:23 | |
*** yolkfull has quit IRC | 12:34 | |
*** yolkfull has joined #openstack-release | 12:35 | |
*** yolkfull has quit IRC | 12:37 | |
*** yolkfull has joined #openstack-release | 12:38 | |
*** yolkfull has quit IRC | 12:38 | |
*** yolkfull has joined #openstack-release | 12:38 | |
*** yolkfull_ has joined #openstack-release | 12:42 | |
*** stevemar__ has joined #openstack-release | 12:43 | |
*** yolkfull has quit IRC | 12:45 | |
*** Dinesh_Bhor has quit IRC | 12:45 | |
*** yolkfull_ has quit IRC | 12:45 | |
*** Dinesh_Bhor has joined #openstack-release | 12:46 | |
*** Dinesh_Bhor has quit IRC | 12:49 | |
*** Dinesh_Bhor has joined #openstack-release | 12:49 | |
*** Dinesh_Bhor has quit IRC | 12:49 | |
*** Dinesh_Bhor has joined #openstack-release | 12:50 | |
*** mriedem has joined #openstack-release | 13:05 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/releases master: oslo.cache release for etcd3gw driver https://review.openstack.org/469658 | 13:05 |
*** stevemar__ has quit IRC | 13:11 | |
*** tmorin has quit IRC | 13:17 | |
*** askb has quit IRC | 13:30 | |
*** bobh has joined #openstack-release | 13:34 | |
*** yamahata has joined #openstack-release | 13:53 | |
*** spzala has joined #openstack-release | 14:00 | |
*** stevemar__ has joined #openstack-release | 14:05 | |
dhellmann | dims, ttx: o/ | 14:12 |
* dhellmann starts investigating those release notes failures | 14:12 | |
*** cody-somerville has quit IRC | 14:12 | |
ttx | dhellmann: puppet-nova-releasenotes and swift-releasenotes ones look like sphinx warnings now considered as errors. Was wondering if !=1.6.1 is not enough now that 1.6.2 is out | 14:15 |
ttx | The openstack-ansible-announce-release is slightly more baffling. That TypeError comes from deep inside the reno scanner code | 14:15 |
dhellmann | yeah, I've seen that before but not been able to reproduce it | 14:16 |
dhellmann | I think it's a filesystem encoding thing with the filename | 14:16 |
dhellmann | the puppet-nova problem is a legit issue with the format of that note | 14:16 |
ttx | like filenames being read as bytes instead of strings | 14:16 |
dhellmann | yeah | 14:16 |
ttx | been trying to spot something odd in those files but so far has escaped me :) | 14:17 |
dhellmann | I don't know why the puppet nova issue slipped through before. there does seem to be a check job in place to catch it | 14:17 |
ttx | dhellmann: might be a pre-1.6.2 check | 14:18 |
ttx | i.e. the check job ran with a different version of sphinx | 14:19 |
dhellmann | yeah | 14:19 |
dhellmann | the fix is easy enough | 14:19 |
dhellmann | and I should just make reno more flexible, too | 14:19 |
dhellmann | hey, I can reproduce the filename issue for this one | 14:22 |
*** armax has joined #openstack-release | 14:24 | |
ttx | which filename is causing issues ? | 14:25 |
ttx | The only weird one is the one starting with an uppercase A | 14:26 |
ttx | or is it a completely different filename ? | 14:26 |
dhellmann | it's actually not a filename, it's a bug in how reno is interpreting the delete change from dulwich | 14:31 |
dhellmann | it's looking at the sha instead of the filename (wrong tuple element) | 14:32 |
*** openstackgerrit has quit IRC | 14:34 | |
-openstackstatus- NOTICE: python-setuptools 36.0.1 has been released and now making its way into jobs. Feel free to 'recheck' your failures. If you have any problems, please join #openstack-infra | 14:34 | |
*** kornicameister has quit IRC | 14:35 | |
*** openstackgerrit has joined #openstack-release | 14:37 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: fix the way we handle deleted notes https://review.openstack.org/469878 | 14:37 |
dhellmann | ttx: ^^ | 14:38 |
ttx | Ah! nice catch | 14:38 |
dhellmann | ttx: I sent the openstack-ansible release announcement using this change locally | 14:39 |
dhellmann | print debugging ftw | 14:39 |
dims | +2 dhellmann | 14:40 |
*** lbragsta_ has joined #openstack-release | 14:45 | |
*** spzala has quit IRC | 14:47 | |
*** lbragsta_ has quit IRC | 14:47 | |
*** hongbin has joined #openstack-release | 14:47 | |
openstackgerrit | Merged openstack/releases master: oslo.cache release for etcd3gw driver https://review.openstack.org/469658 | 14:50 |
*** tellesnobrega has quit IRC | 14:51 | |
dhellmann | ttx: the fix for swift is in https://review.openstack.org/469881 | 14:54 |
dhellmann | puppet-nova is in https://review.openstack.org/469872 | 14:55 |
dims | dhellmann : the reno change ran into trouble - https://review.openstack.org/#/c/469878/ | 14:56 |
dhellmann | dims : yeah, looking at that now | 14:57 |
*** yamahata has quit IRC | 15:00 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: fix the way we handle deleted notes https://review.openstack.org/469878 | 15:00 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to field https://review.openstack.org/469657 | 15:14 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: skip validation in closed series https://review.openstack.org/469656 | 15:15 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: add jsonschema https://review.openstack.org/469655 | 15:15 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: protect against repos where we can't get project name https://review.openstack.org/469654 | 15:15 |
openstackgerrit | Merged openstack/reno master: fix the way we handle deleted notes https://review.openstack.org/469878 | 15:16 |
*** armax has quit IRC | 15:20 | |
*** toabctl has quit IRC | 15:22 | |
*** toabctl has joined #openstack-release | 15:23 | |
*** openstackgerrit has quit IRC | 15:33 | |
*** openstackgerrit has joined #openstack-release | 15:36 | |
openstackgerrit | Merged openstack/releases master: neutron: new stable releases https://review.openstack.org/468552 | 15:36 |
*** alexchadin has quit IRC | 16:03 | |
*** jpich has quit IRC | 16:12 | |
*** yamahata has joined #openstack-release | 16:23 | |
*** cody-somerville has joined #openstack-release | 16:25 | |
*** cody-somerville has quit IRC | 16:25 | |
*** cody-somerville has joined #openstack-release | 16:25 | |
*** armax has joined #openstack-release | 16:29 | |
*** spzala has joined #openstack-release | 16:32 | |
*** hyakuhei has quit IRC | 16:41 | |
*** hyakuhei has joined #openstack-release | 16:41 | |
*** hyakuhei has quit IRC | 16:41 | |
*** hyakuhei has joined #openstack-release | 16:41 | |
*** dtantsur is now known as dtantsur|afk | 16:45 | |
mwhahaha | dhellmann: we're hitting this in puppet-tripleo but the yaml appears valid http://logs.openstack.org/25/314225/16/gate/gate-puppet-tripleo-releasenotes/a8d09f9/console.html#_2017-06-01_14_48_35_030848 | 16:48 |
dhellmann | mwhahaha: looking | 16:49 |
mwhahaha | also puppet-gnocchi has another issue for stable/newton http://logs.openstack.org/30/469230/1/check/gate-puppet-gnocchi-releasenotes/0e1c8dc/console.html#_2017-05-31_15_20_19_014304 | 16:49 |
mwhahaha | i tried rewriting the yaml in puppet-tripleo but it still errors | 16:49 |
*** shardy has quit IRC | 16:53 | |
dhellmann | mwhahaha: I just submitted 3 patches against puppet-tripleo that fix the build locally. I don't know if we're going to be able to merge them normally since they are on multiple branches | 16:57 |
mwhahaha | so i guess we need to make it non-voting for a bit | 16:58 |
mwhahaha | dhellmann: thanks. any idea on the puppet-gnocchi error? | 16:59 |
dhellmann | mwhahaha : I'm also going to look at changing reno to relax that rule, since it seems to keep tripping everyone up | 16:59 |
dhellmann | looking at that one now | 16:59 |
dhellmann | mwhahaha : which patch is causing the puppet-gnocchi issue? | 17:01 |
mwhahaha | https://review.openstack.org/#/c/469230/ | 17:01 |
*** claudiub has quit IRC | 17:02 | |
odyssey4me | we're getting an odd releasenotes job fail for a master patch to an untagged repo: http://logs.openstack.org/31/469831/5/check/gate-openstack-ansible-tests-releasenotes/f1fe389/console.html#_2017-06-01_16_59_17_303655 | 17:02 |
odyssey4me | we'd appreciate help identifying a cause for it | 17:03 |
dhellmann | mwhahaha : the puppet-gnocchi thing looks like a reno bug | 17:06 |
dhellmann | odyssey4me : you've hit the same bug | 17:06 |
dhellmann | working on a fix | 17:06 |
*** cody-somerville has quit IRC | 17:06 | |
*** cody-somerville has joined #openstack-release | 17:07 | |
*** cody-somerville has quit IRC | 17:07 | |
*** cody-somerville has joined #openstack-release | 17:07 | |
odyssey4me | ah, great thanks dhellmann | 17:07 |
dhellmann | the fix isn't going to be trivial, but I think I know what to do | 17:13 |
*** tellesnobrega has joined #openstack-release | 17:43 | |
*** amoralej is now known as amoralej|off | 17:44 | |
*** spzala has quit IRC | 17:52 | |
openstackgerrit | Merged openstack/releases master: protect against repos where we can't get project name https://review.openstack.org/469654 | 17:53 |
*** bobh has quit IRC | 17:56 | |
*** electrofelix has quit IRC | 17:56 | |
*** pbandark has quit IRC | 18:00 | |
openstackgerrit | Erno Kuvaja proposed openstack/releases master: Release python-glanceclient 2.7.0 https://review.openstack.org/469964 | 18:02 |
mriedem | dhellmann: it's that time of the week | 18:06 |
mriedem | dhellmann: you know what i'm going to mention? | 18:06 |
dhellmann | mriedem : you seeing the same valueerror that odyssey4me and mwhahaha have reported? | 18:07 |
mriedem | nope, reno issue | 18:07 |
mriedem | 14.0.0 upgrade notes for nova https://docs.openstack.org/releasenotes/nova/newton.html#upgrade-notes | 18:07 |
mriedem | that should have this https://github.com/openstack/nova/commit/17a8e8a68cbe4045a1bc2889d1bf51f2db7ebcca | 18:07 |
mriedem | but it's not there | 18:07 |
mriedem | no idea why | 18:07 |
dhellmann | ok. I'm working on that other issue which is causing job failures. can I get you to file this one in LP for me to look at next? | 18:08 |
mriedem | will do | 18:08 |
*** spzala has joined #openstack-release | 18:08 | |
dhellmann | thanks for your patience | 18:08 |
mriedem | np | 18:09 |
mriedem | hmm i see we only set :earliest-version: for newton, but not liberty, mitaka or ocata | 18:12 |
mriedem | i wonder if that's screwing things up | 18:13 |
*** lucasagomes is now known as lucas-afk | 18:14 | |
mriedem | and should :branch: origin/stable/liberty be an eol tag? | 18:14 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: do not assume the current branch is the most recent https://review.openstack.org/469966 | 18:15 |
dhellmann | odyssey4me, mwhahaha : do you want to give ^^ a try locally to see if it resolves your issue? | 18:15 |
dhellmann | mriedem : reno tries to convert the stable branch names to eol tags automatically | 18:15 |
dhellmann | and it also tries to figure out the earliest version, which is probably where your issue is | 18:16 |
mriedem | ok filling in the missing earliest-versions to see if that helps | 18:17 |
dhellmann | I'm building the notes locally here to see what I get | 18:18 |
mriedem | no configuration file in /home/user/git/nova/releasenotes/config.yaml | 18:21 |
mriedem | our config is in the release-specific rst | 18:21 |
mwhahaha | dhellmann: yea that fixes it | 18:28 |
openstackgerrit | Matt Riedemann proposed openstack/reno master: Document how reno handles eol branches in config https://review.openstack.org/469970 | 18:31 |
*** alexchadin has joined #openstack-release | 18:43 | |
dhellmann | mriedem : the issue is a8ebbebd4e merges the 13.0.0 tag into that branch and that screws up reno's scanner | 18:44 |
dhellmann | at that point the scanner can't tell the difference between the mitaka and newton branches | 18:45 |
dhellmann | let me see if I can teach it to ignore those | 18:46 |
mriedem | oh weird https://review.openstack.org/#/c/302578/ | 18:46 |
mriedem | i don't even remember that thing | 18:46 |
dhellmann | we used to do that so that master never had older version numbers than stable branches | 18:46 |
dhellmann | we stopped doing it shortly after adopting reno, I think? | 18:47 |
mriedem | this is the bug btw https://bugs.launchpad.net/reno/+bug/1695057 | 18:47 |
openstack | Launchpad bug 1695057 in reno "upgrade note missing from nova 14.0.0 release notes" [Undecided,New] | 18:47 |
rosmaita | hello release peeps ... when someone has a chance, can you look at https://review.openstack.org/#/c/469964/ ? error seems to be that it doesn't like us tagging 2.7.0 from master (though i am probably reading that error incorrectly) | 18:49 |
dhellmann | rosmaita : try leaving out the "branches" section -- you only need that when you want to make a new branch | 18:49 |
rosmaita | dhellmann: ty, will try that | 18:50 |
openstackgerrit | Brian Rosmaita proposed openstack/releases master: Release python-glanceclient 2.7.0 https://review.openstack.org/469964 | 18:51 |
rosmaita | dhellmann: worked like a charm, thanks! | 18:56 |
*** wolverineav has quit IRC | 19:03 | |
*** wolverineav has joined #openstack-release | 19:03 | |
*** wolverineav has quit IRC | 19:05 | |
*** spzala_ has joined #openstack-release | 19:10 | |
*** spzala has quit IRC | 19:13 | |
*** bobh has joined #openstack-release | 19:17 | |
*** spzala_ has quit IRC | 19:21 | |
*** claudiub has joined #openstack-release | 19:30 | |
*** dave-mccowan has quit IRC | 19:32 | |
dhellmann | mriedem : adding a hacky check to reno to try to skip null-merge commits gives me 12 more release notes file in stable/newton for nova | 19:44 |
dhellmann | could you review this list and see if they make sense to you? https://etherpad.openstack.org/p/oT3tetEcz6 | 19:44 |
*** yamahata has quit IRC | 19:45 | |
mriedem | yeah | 19:45 |
mriedem | releasenotes/notes/flavors-moved-to-api-database-b33489ed3b1b246b.yaml is definitely the one we were looking for | 19:45 |
dhellmann | now I need to figure out a less hacky way | 19:45 |
dhellmann | fungi : maybe you have some ideas on this | 19:45 |
dhellmann | I'm trying to figure out how to detect a null-merge commit that brings a tag from one stable branch forward into the next stable branch (it would have been master at the time of the merge) | 19:46 |
*** dave-mccowan has joined #openstack-release | 19:46 | |
dhellmann | I'm currently looking for the string "This is a null-merge" in the commit message, which is terribly project-specific | 19:46 |
dhellmann | I'm not sure if there's some other characteristic of the commit that I could use to tell that it's one of these special things | 19:47 |
*** stevemar__ has quit IRC | 19:50 | |
*** spzala has joined #openstack-release | 19:51 | |
dhellmann | mriedem : thanks | 19:59 |
*** armax has quit IRC | 20:00 | |
odyssey4me | dhellmann I have a report that https://review.openstack.org/469966 works. Unfortunately I'm not in a position to confirm. | 20:04 |
dhellmann | odyssey4me : ok | 20:04 |
fungi | dhellmann: i'll have to dig up some examples and play around. i want to say we should be able to identify it by the lack of a diff possibly coupled with matching a parent to a tagged object id | 20:09 |
dhellmann | fungi : a8ebbebd4ee0c3bb1452ea32f92e1588a6b35067 in nova is the one I'm working with | 20:10 |
*** cody-somerville has quit IRC | 20:10 | |
fungi | `git show a8ebbebd4ee0c3bb1452ea32f92e1588a6b35067 | grep '^diff '` returns nothing, which is probably one sign at least | 20:12 |
fungi | need to ponder whether there are other sorts of commits which could exhibit that same sort of behavior | 20:12 |
fungi | that's owing to the "ours" merge strategy which does no conflict resolution and just merges history without changing the tree | 20:13 |
fungi | nevermind | 20:15 |
fungi | merge commits in general lack a diff unless there was conflict resolution | 20:15 |
dhellmann | oh, yeah | 20:16 |
dhellmann | looking for the parent with a tag might work, though | 20:17 |
*** spzala has quit IRC | 20:17 | |
fungi | the ones generated by our automation also have a commit message subject matching "^ Merge tag '.*'$" and OpenStack Proposal Bot <openstack-infra@lists.openstack.org> as the author | 20:17 |
dhellmann | yeah, my hacky detection code is relying on the message right now | 20:18 |
fungi | building up a table of the commit ids each tag refers to is probably not super expensive (nova for example only has 143 tags at the moment) | 20:19 |
fungi | er, maybe not even necessary to take it that far | 20:20 |
fungi | use git tag --contains on the parents and pick the last one according to sort -V | 20:21 |
fungi | or something along those lines | 20:21 |
fungi | and then compare the object which was tagged to see if it's the parent in question | 20:21 |
dhellmann | I'm already buiding that table | 20:21 |
fungi | right, so most of the work is already done ;) | 20:22 |
dhellmann | and, fwiw, reno uses dulwich now, and doesn't call out to git. I've had to build a couple of porcelain pieces | 20:22 |
*** stevemar__ has joined #openstack-release | 20:23 | |
dhellmann | hmm, there's a case where the first parent of a merge commit is tagged and it's a legit tag on the branch | 20:24 |
fungi | nice. i need to check that lib out (we're still using pygit most other places we need a lib) | 20:24 |
dhellmann | I think I only want to look at 2nd and later parents | 20:24 |
dhellmann | dulwich is nice. I had to build my own topo ordering walker, too, but the author is interested in me moving that upstream so I just need to find the time to do it | 20:24 |
fungi | right, i never can remember which order the parents come in | 20:24 |
fungi | oh, great! | 20:25 |
dhellmann | there's one in the lib, but it produces things in the wrong order | 20:25 |
dhellmann | it still includes a date ordering component because of the way it was built | 20:25 |
fungi | need to disappear for a bit, but ping me if you need more digging | 20:26 |
dhellmann | fungi : thanks for the tip, I'm going to experiment some with this | 20:27 |
fungi | i'm curious to know how you get on... it's an interesting puzzle, for sure | 20:28 |
*** dave-mccowan has quit IRC | 20:32 | |
*** alexchadin has quit IRC | 20:36 | |
*** jrist has quit IRC | 20:45 | |
*** yamahata has joined #openstack-release | 20:49 | |
*** jrist has joined #openstack-release | 20:49 | |
*** cody-somerville has joined #openstack-release | 20:51 | |
*** armax has joined #openstack-release | 20:56 | |
*** stevemar__ has quit IRC | 21:04 | |
*** stevemar__ has joined #openstack-release | 21:09 | |
*** stevebaker has joined #openstack-release | 21:10 | |
*** stevemar__ has quit IRC | 21:14 | |
*** yamahata has quit IRC | 21:30 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: ignore null-merges https://review.openstack.org/470023 | 21:34 |
dhellmann | mriedem : here's another patch to test ^^ | 21:34 |
dhellmann | fungi : ^^ | 21:34 |
*** myoung is now known as myoung|gone | 21:36 | |
mriedem | ok | 21:38 |
*** askb has joined #openstack-release | 21:41 | |
*** yamahata has joined #openstack-release | 21:46 | |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from closed series https://review.openstack.org/470025 | 21:46 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from independent projects https://review.openstack.org/470026 | 21:46 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from mitaka projects https://review.openstack.org/470027 | 21:46 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from newton projects https://review.openstack.org/470028 | 21:46 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from ocata projects https://review.openstack.org/470029 | 21:46 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from pike projects https://review.openstack.org/470030 | 21:46 |
mriedem | dhellmann: works, ship it | 21:48 |
mriedem | i see that "Flavors are being moved to the API database for CellsV2." reno showing up in the 14.0.0 newton release notes now | 21:48 |
dhellmann | \o/ | 21:48 |
*** cody-somerville has quit IRC | 21:49 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: ignore null-merges https://review.openstack.org/470023 | 21:50 |
fungi | taking a gander meself | 21:53 |
*** cody-somerville has joined #openstack-release | 21:55 | |
*** cody-somerville has quit IRC | 21:55 | |
*** cody-somerville has joined #openstack-release | 21:55 | |
openstackgerrit | Merged openstack/releases master: Release python-glanceclient 2.7.0 https://review.openstack.org/469964 | 22:02 |
*** claudiub has quit IRC | 22:08 | |
*** bobh has quit IRC | 22:19 | |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from ocata projects https://review.openstack.org/470029 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from newton projects https://review.openstack.org/470028 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: skip validation in closed series https://review.openstack.org/469656 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from pike projects https://review.openstack.org/470030 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from closed series https://review.openstack.org/470025 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from mitaka projects https://review.openstack.org/470027 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: remove send-announcements-to from independent projects https://review.openstack.org/470026 | 22:38 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: add jsonschema https://review.openstack.org/469655 | 22:38 |
*** ekcs_ has joined #openstack-release | 22:39 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: ignore null-merges https://review.openstack.org/470023 | 22:41 |
*** stevemar__ has joined #openstack-release | 22:57 | |
*** bobh has joined #openstack-release | 23:17 | |
*** spzala has joined #openstack-release | 23:18 | |
openstackgerrit | Sean McGinnis proposed openstack/releases master: Release python-cinderclient 2.2.0 https://review.openstack.org/470060 | 23:20 |
*** spzala has quit IRC | 23:23 | |
*** bobh has quit IRC | 23:27 | |
*** yamahata has quit IRC | 23:27 | |
*** spzala has joined #openstack-release | 23:29 | |
*** bobh has joined #openstack-release | 23:30 | |
*** stevemar__ has quit IRC | 23:33 | |
*** stevemar__ has joined #openstack-release | 23:43 | |
*** dklyle has joined #openstack-release | 23:55 | |
*** hongbin has quit IRC | 23:56 | |
*** david-lyle has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!