*** harlowja has quit IRC | 00:04 | |
*** bobh has quit IRC | 00:09 | |
*** bobh has joined #openstack-release | 00:13 | |
*** dave-mccowan has quit IRC | 00:13 | |
*** bobh has quit IRC | 00:21 | |
*** bobh has joined #openstack-release | 00:24 | |
*** bobh has quit IRC | 00:30 | |
*** mriedem has quit IRC | 00:40 | |
*** dave-mccowan has joined #openstack-release | 00:47 | |
*** bobh has joined #openstack-release | 00:56 | |
*** bobh has quit IRC | 00:58 | |
*** yanyanhu has joined #openstack-release | 01:25 | |
*** yolkfull__ has joined #openstack-release | 01:29 | |
*** mriedem has joined #openstack-release | 01:36 | |
*** zhurong has joined #openstack-release | 01:50 | |
*** yamahata has joined #openstack-release | 01:58 | |
*** zhurong has quit IRC | 02:07 | |
*** flwang2 has joined #openstack-release | 02:20 | |
*** flwang has quit IRC | 02:21 | |
openstackgerrit | Emilien Macchi proposed openstack/releases master: Release openstacklient 3.10.0 https://review.openstack.org/461959 | 02:33 |
---|---|---|
EmilienM | dtroyer: ^ | 02:33 |
dtroyer | EmilienM: thanks, but not quite yet, I'm still chasing a thing or two that really needs to get fixed | 02:34 |
EmilienM | dtroyer: ok - can you confirm that this release will help with https://bugs.launchpad.net/tripleo/+bug/1687706 ? | 02:35 |
openstack | Launchpad bug 1687706 in tripleo "__init__() got an unexpected keyword argument 'url'" [Critical,In progress] - Assigned to Emilien Macchi (emilienm) | 02:35 |
EmilienM | this bug is blocking us to promote the packages in tripleo CI :( | 02:35 |
dtroyer | yeah, it should address that | 02:36 |
*** dave-mccowan has quit IRC | 02:36 | |
dtroyer | FWIW, I've been trying to do this release for over a week now, and NNED to get it done before going to Boston, so basically tomorrow | 02:36 |
EmilienM | ok | 02:36 |
EmilienM | dtroyer: i'll pin the package in RDO to the latest commit in the meantime | 02:37 |
EmilienM | d930b043eef262f3eb34489f01b9856077dc2dc4 | 02:37 |
dtroyer | the timing of the novaclient 8.0 stuff set me back 2 weeks and that's what I've been focused on | 02:37 |
EmilienM | I hope it will work fine with latest tag of osc-lib | 02:37 |
dtroyer | it should, we bumped g-r min to the current osc-lib and os-client-config, both of which the next osc need | 02:38 |
EmilienM | ok | 02:38 |
EmilienM | thx for the infos | 02:38 |
dtroyer | ok, I just saw stevemar merged the last two func test fixes I had, so there is just one more thing I need to look at | 02:39 |
EmilienM | dtroyer: feel free to take over my release patch, I won't abandon it | 02:39 |
dtroyer | it'll need to be updated, I'll do that when its time | 02:39 |
*** yamahata has quit IRC | 02:40 | |
EmilienM | oki | 02:43 |
*** armax has quit IRC | 02:48 | |
*** hongbin has quit IRC | 02:59 | |
*** gcb has quit IRC | 02:59 | |
*** armax has joined #openstack-release | 03:05 | |
*** ricolin has joined #openstack-release | 03:12 | |
*** gcb has joined #openstack-release | 03:12 | |
*** bobh has joined #openstack-release | 03:13 | |
*** bobh has quit IRC | 03:16 | |
*** armax has quit IRC | 03:19 | |
*** bobh has joined #openstack-release | 03:21 | |
*** mriedem has quit IRC | 03:25 | |
*** armax has joined #openstack-release | 03:35 | |
*** zhurong has joined #openstack-release | 03:37 | |
*** zhurong has quit IRC | 03:40 | |
*** bobh has quit IRC | 03:41 | |
stevemar | yeah, EmilienM, dtroyer is super close to getting everything fixed | 03:45 |
EmilienM | cool ! | 03:47 |
*** armax has quit IRC | 04:27 | |
*** armax has joined #openstack-release | 04:28 | |
*** zhurong has joined #openstack-release | 04:37 | |
*** armax has quit IRC | 04:38 | |
*** yamahata has joined #openstack-release | 04:40 | |
*** yamahata has quit IRC | 04:55 | |
*** udesale has joined #openstack-release | 04:58 | |
*** udesale has quit IRC | 05:00 | |
*** udesale has joined #openstack-release | 05:01 | |
*** gcb has quit IRC | 05:10 | |
*** gcb has joined #openstack-release | 05:27 | |
*** pcaruana has joined #openstack-release | 06:27 | |
*** eranrom has joined #openstack-release | 06:56 | |
*** shardy has joined #openstack-release | 07:00 | |
*** bauwser is now known as bauzas | 07:12 | |
*** zhurong has quit IRC | 07:24 | |
*** tmorin has joined #openstack-release | 07:34 | |
*** pbandark has joined #openstack-release | 07:34 | |
*** Qiming has quit IRC | 07:36 | |
*** dtantsur|afk is now known as dtantsur | 07:40 | |
*** Qiming has joined #openstack-release | 07:42 | |
*** zhurong has joined #openstack-release | 07:42 | |
*** amoralej|off is now known as amoralej | 07:48 | |
*** oanson has quit IRC | 07:52 | |
*** oanson has joined #openstack-release | 07:53 | |
*** alexchadin has joined #openstack-release | 08:09 | |
*** lucas-afk is now known as lucasagomes | 08:26 | |
*** witek has quit IRC | 08:26 | |
*** electrofelix has joined #openstack-release | 08:28 | |
openstackgerrit | Merged openstack/releases master: Release magnum 3.2.0 https://review.openstack.org/460478 | 08:40 |
openstackgerrit | Merged openstack/releases master: Release magnum 2.1.0 https://review.openstack.org/460481 | 08:41 |
*** zhurong has quit IRC | 08:47 | |
*** zhurong has joined #openstack-release | 09:01 | |
*** tmorin has quit IRC | 09:13 | |
*** Jeffrey4l has quit IRC | 09:25 | |
*** Jeffrey4l has joined #openstack-release | 09:27 | |
*** zhurong has quit IRC | 09:41 | |
*** udesale has quit IRC | 09:45 | |
*** alexchadin has quit IRC | 09:48 | |
*** sdague has joined #openstack-release | 09:55 | |
*** tmorin has joined #openstack-release | 09:59 | |
*** tmorin has left #openstack-release | 10:01 | |
*** gcb has quit IRC | 10:04 | |
*** ricolin has quit IRC | 10:07 | |
*** ricolin has joined #openstack-release | 10:08 | |
*** zhurong has joined #openstack-release | 10:19 | |
*** oanson has quit IRC | 10:19 | |
*** oanson has joined #openstack-release | 10:21 | |
*** zhurong has quit IRC | 10:30 | |
*** yanyanhu has quit IRC | 10:40 | |
*** tmorin1 has joined #openstack-release | 10:47 | |
*** witek has joined #openstack-release | 10:50 | |
*** yolkfull__ has quit IRC | 11:00 | |
*** alexchadin has joined #openstack-release | 11:00 | |
*** alexchadin has quit IRC | 11:14 | |
*** alexchadin has joined #openstack-release | 11:14 | |
*** lucasagomes is now known as lucas-hungry | 11:28 | |
*** alexchadin has quit IRC | 11:29 | |
*** alexchadin has joined #openstack-release | 11:34 | |
*** tellesnobrega has joined #openstack-release | 11:35 | |
openstackgerrit | Dean Troyer proposed openstack/releases master: Release python-openstacklient 3.10.0 https://review.openstack.org/461959 | 11:40 |
dtroyer | EmilienM: ^^^^ thanks | 11:41 |
EmilienM | woot | 11:42 |
*** pcaruana has quit IRC | 11:53 | |
ttx | +2d | 11:54 |
openstackgerrit | Merged openstack/releases master: Release python-openstacklient 3.10.0 https://review.openstack.org/461959 | 11:57 |
*** pcaruana has joined #openstack-release | 11:57 | |
*** wolverineav has joined #openstack-release | 11:58 | |
*** zhurong has joined #openstack-release | 12:02 | |
*** Qiming has quit IRC | 12:06 | |
*** tmorin1 has quit IRC | 12:08 | |
*** tmorin has joined #openstack-release | 12:08 | |
*** Qiming has joined #openstack-release | 12:20 | |
*** askb has quit IRC | 12:24 | |
*** alexchadin has quit IRC | 12:34 | |
*** lucas-hungry is now known as lucasagomes | 12:42 | |
*** mriedem has joined #openstack-release | 12:51 | |
dims | ttx : dhellmann : o/ | 12:55 |
ttx | dims: o/ | 12:55 |
*** gcb has joined #openstack-release | 12:56 | |
*** claudiub has joined #openstack-release | 13:02 | |
*** alexchadin has joined #openstack-release | 13:06 | |
dhellmann | dims, ttx: o/ | 13:06 |
*** tmorin has quit IRC | 13:08 | |
*** askb has joined #openstack-release | 13:15 | |
*** zhurong has quit IRC | 13:28 | |
*** dtantsur is now known as dtantsur|brb | 13:35 | |
*** gcb has quit IRC | 13:40 | |
*** gcb has joined #openstack-release | 13:40 | |
*** gcb has quit IRC | 13:43 | |
*** gcb has joined #openstack-release | 13:44 | |
andymccr | morning releases team. im having an issue with the reno gate for OSA - TL;DR some duplicate renos merged in newton (the id at the end was the same, due to a bulk patch across multiple repos), that's since been fixed, but now the "fix patch" causes failures on ocata/master reno gates | 13:46 |
andymccr | it looks due to the way it iterates through commits (it tries to perform the delete for the rename patch, before processing the commit that adds the original duplicate renos - so fails) | 13:46 |
*** mriedem has quit IRC | 13:48 | |
*** mriedem has joined #openstack-release | 13:51 | |
*** armax has joined #openstack-release | 13:51 | |
*** zhurong has joined #openstack-release | 14:02 | |
*** bobh has joined #openstack-release | 14:06 | |
*** openstackgerrit has quit IRC | 14:18 | |
*** dave-mccowan has joined #openstack-release | 14:25 | |
*** amotoki has joined #openstack-release | 14:26 | |
*** askb has quit IRC | 14:36 | |
ttx | andymccr: do you have pointers to the failed tests ? /cc dhellmann | 14:40 |
andymccr | ttx: sure do! the failure is here: http://logs.openstack.org/04/461004/5/check/gate-openstack-ansible-releasenotes/e9001b0/console.html#_2017-05-03_08_59_24_650953 | 14:41 |
*** udesale has joined #openstack-release | 14:43 | |
ttx | wow, that exceeds my limited reno debug capabilities. And I don't have much time this week to improve those capabilities :) But maybe piece of cake for dhellmann | 14:47 |
*** zhurong has quit IRC | 14:52 | |
*** dtantsur|brb is now known as dtantsur | 14:56 | |
*** gcb has quit IRC | 15:02 | |
*** gcb has joined #openstack-release | 15:03 | |
*** gcb has quit IRC | 15:10 | |
*** hongbin has joined #openstack-release | 15:13 | |
*** gcb has joined #openstack-release | 15:17 | |
*** udesale has quit IRC | 15:22 | |
dhellmann | andymccr, ttx : I'll take a look | 15:23 |
*** alexchadin has quit IRC | 15:24 | |
andymccr | dhellmann: thanks! I dug a bit, so i think i understand the reason its failing, but im not too sure how to best fix that - appreciate the help | 15:27 |
dhellmann | andymccr : this is definitely a case I didn't anticipate with big random numbers to provide unique filenames :-) | 15:28 |
andymccr | dhellmann: edge cases are always more fun! | 15:29 |
dhellmann | andymccr: I think I understand what happened here, please verify: there are a bunch of reno files in one commit but that contain different content. is that right? | 15:40 |
andymccr | dhellmann: yes, there are 5 renos in https://github.com/openstack/openstack-ansible/commit/179668188a18c0f183136220fb6ab14e593a32f5 that have the same ID but different content (its basically the same feature for a few different role repositories) | 15:42 |
*** Rockyg has joined #openstack-release | 15:42 | |
dhellmann | ok, got it | 15:42 |
andymccr | usually that doesnt merge because it checks for duplicate ids (so not sure how it did merge this time!) | 15:42 |
dhellmann | I wonder why that patch didn't fail in this same way :-/ | 15:42 |
andymccr | the gate for stable/ocata was then failing because of duplicates - so i adjusted them: https://github.com/openstack/openstack-ansible/commit/121fb00c82b62be4585f16b95b4fcb67495d83f1 | 15:43 |
andymccr | but yeah now its failing as its not able to delete :) | 15:43 |
*** tmorin has joined #openstack-release | 15:43 | |
dhellmann | yeah | 15:44 |
dhellmann | ok, still digging | 15:44 |
dhellmann | I think I just need to make that loop smarter | 15:44 |
dhellmann | I suppose I should ignore those files | 15:44 |
andymccr | i figured it should loop through the other way and that way it would action the "add" first, and then the "delete" afterwards. but couldnt quite figure out how to do that :) | 15:46 |
dhellmann | the problem isn't that there's an add, it's that there are several files with the same uid being added | 15:46 |
dhellmann | that should have barfed | 15:46 |
andymccr | could the uid not be based on a hash of the filename? | 15:47 |
*** openstackgerrit has joined #openstack-release | 15:59 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: deal with non-unique UIDs https://review.openstack.org/462199 | 15:59 |
dhellmann | andymccr : see if ^^ produces the output you expect locally, please | 15:59 |
dhellmann | now I need to figure out how to protect against this case in the future without breaking your build again | 15:59 |
andymccr | dhellmann: i'll give that a test -thanks for digging into that | 16:00 |
dhellmann | andymccr : maybe a better fix is to just ignore those files and emit a warning that they're being ignored. that leaves them unhandled, and they can then be renamed | 16:02 |
dhellmann | andymccr : I guess the patch as it stands now might fail by emitting the notes twice, so that's the thing to check for | 16:03 |
dhellmann | yeah, I'm seeing dupes | 16:04 |
*** tmorin has quit IRC | 16:10 | |
andymccr | dhellmann: how can you tell the end result? im seeing deletes for the 5 notes | 16:10 |
andymccr | the test passed - but yeah if its passing /w duplicates thats not ideal | 16:11 |
dhellmann | andymccr : I ran "tox -e releasenotes" in openstack-ansible then .tox/releasenotes/bin/pip uninstall reno then installed reno with that patch then ran tox -e releasenotes and looked at the output | 16:12 |
andymccr | dhellmann: ok so im looking at the same - but i can see "note deleted in 121fb00c82b62be4585f16b95b4fcb67495d83f1" x 5 which im guessing is the removal of teh duplicate from https://github.com/openstack/openstack-ansible/commit/121fb00c82b62be4585f16b95b4fcb67495d83f1 | 16:13 |
*** ekcs has joined #openstack-release | 16:13 | |
andymccr | or at least thats how im reading it | 16:13 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: deal with non-unique UIDs https://review.openstack.org/462199 | 16:13 |
dhellmann | andymccr : yeah, it's going to report on everything it does but you have to look at the actual html output to see the duplicate content | 16:14 |
andymccr | ahh i see | 16:14 |
dhellmann | the new version of the patch eliminates the duplicates in the output | 16:14 |
andymccr | dhellmann: ahh ok tested that - yeah the new one doesnt have duplicates in the html output. | 16:17 |
andymccr | dhellmann: thanks again. that LGTM. | 16:19 |
dhellmann | andymccr : great | 16:19 |
dhellmann | I wonder if that warning is enough | 16:20 |
dhellmann | ideally the add would have broken things | 16:20 |
*** lucasagomes is now known as lucas-afk | 16:21 | |
andymccr | dhellmann: agreed. im not too sure how that didnt flag as duplicates (it did on the ocata gate). I guess the warning just exists for the case where the duplicates were somehow added - but allows them to be deleted. | 16:22 |
dhellmann | right, if I throw an error there you'll never be able to fix your build | 16:23 |
*** pcaruana has quit IRC | 16:24 | |
*** shardy has quit IRC | 16:28 | |
*** tellesnobrega has quit IRC | 16:40 | |
*** dtantsur is now known as dtantsur|afk | 16:40 | |
*** armax has quit IRC | 16:43 | |
*** tellesnobrega has joined #openstack-release | 16:46 | |
*** harlowja has joined #openstack-release | 16:48 | |
*** armax has joined #openstack-release | 16:51 | |
dhellmann | andymccr : did you open a bug for this that I can reference in these patches? | 16:55 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: deal with non-unique UIDs https://review.openstack.org/462199 | 17:01 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: modify the change aggregation api https://review.openstack.org/462220 | 17:01 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: do not allow multiple files with the same UID https://review.openstack.org/462221 | 17:01 |
*** ricolin has quit IRC | 17:04 | |
dhellmann | dims, ttx, AJaegar: it would be good to get this series reviewed and released soon to unblock andymccr and the OSA team | 17:06 |
*** zul has quit IRC | 17:26 | |
*** Rockyg has quit IRC | 17:27 | |
*** zul has joined #openstack-release | 17:29 | |
*** amoralej is now known as amoralej|off | 17:29 | |
dims | ack dhellmann | 17:37 |
*** mtreinish has quit IRC | 17:46 | |
dhellmann | dims : I'm going to add a release note there -- I keep forgetting to add them in reno :-) | 17:46 |
dims | LOL :) | 17:47 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: do not allow multiple files with the same UID https://review.openstack.org/462221 | 17:49 |
*** hongbin has quit IRC | 17:55 | |
*** pbandark has quit IRC | 18:03 | |
*** mtreinish has joined #openstack-release | 18:05 | |
*** mriedem is now known as mriedem_away | 18:19 | |
*** david-lyle has quit IRC | 18:24 | |
*** dklyle has joined #openstack-release | 18:24 | |
EmilienM | dhellmann: hey, we have a bunch of release notes that have same ideas, but not for same project. For example, it's highly possible that some renos have been copy/pasted across projects. Is it a big deal? | 18:32 |
dhellmann | EmilienM : that case is fine | 18:32 |
EmilienM | ok | 18:33 |
dhellmann | the issue is the way reno tries to figure out if a file has been renamed within a given repository | 18:33 |
dhellmann | smcginnis : can you unapprove https://review.openstack.org/462250 for now? | 18:34 |
dhellmann | I need to test something -- it seems to be deleting the old note | 18:35 |
smcginnis | dhellmann: Not just renaming? | 18:35 |
dhellmann | smcginnis : because the "sameness" detection is based on the UID, not the full filename, renaming one of those files makes reno think both were deleted | 18:36 |
smcginnis | Huh. Well, good luck with that. :) | 18:36 |
dhellmann | yeah | 18:36 |
-openstackstatus- NOTICE: Gerrit on review.openstack.org is being restarted to accomodate a memory leak in Gerrit. Service should return shortly. | 18:53 | |
*** electrofelix has quit IRC | 18:55 | |
*** hongbin has joined #openstack-release | 18:59 | |
*** hongbin has quit IRC | 19:06 | |
*** hongbin has joined #openstack-release | 19:07 | |
openstackgerrit | Terry Wilson proposed openstack/releases master: Release ovsdbapp 0.4.0 https://review.openstack.org/462273 | 19:24 |
*** otherwiseguy has joined #openstack-release | 19:35 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: add a lint command https://review.openstack.org/462276 | 19:36 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: add a lint command https://review.openstack.org/462276 | 19:38 |
*** mriedem_away is now known as mriedem | 19:49 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: add a lint command https://review.openstack.org/462276 | 19:53 |
*** otherwiseguy has quit IRC | 20:17 | |
*** dave-mccowan has quit IRC | 20:41 | |
*** askb has joined #openstack-release | 21:01 | |
*** hongbin has quit IRC | 21:12 | |
*** hongbin has joined #openstack-release | 21:12 | |
*** bobh has quit IRC | 21:15 | |
*** otherwiseguy has joined #openstack-release | 21:28 | |
*** wolverineav has quit IRC | 22:07 | |
*** wolverineav has joined #openstack-release | 22:08 | |
*** wolverineav has quit IRC | 22:15 | |
*** abadger2000 has joined #openstack-release | 22:25 | |
*** harlowja has quit IRC | 22:28 | |
*** abadger1999 has quit IRC | 22:28 | |
*** d0ugal has quit IRC | 22:28 | |
*** d0ugal has joined #openstack-release | 22:53 | |
*** sdague has quit IRC | 23:02 | |
*** bobh has joined #openstack-release | 23:04 | |
*** csomerville has joined #openstack-release | 23:04 | |
*** hongbin has quit IRC | 23:08 | |
*** cody-somerville has quit IRC | 23:09 | |
*** bobh has quit IRC | 23:11 | |
*** dklyle has quit IRC | 23:23 | |
*** harlowja has joined #openstack-release | 23:31 | |
*** gcb has quit IRC | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!