| *** dims has joined #openstack-release | 00:31 | |
| dims | lifeless : the project-requirements-change.py change made its way into the images, so gate-nova-requirements in review (https://review.openstack.org/#/c/237359/) passes now. | 00:35 |
|---|---|---|
| dims | lifeless : there are 3 *-constraints jobs that fail in that review. need to peel the next layer of onion | 00:36 |
| dims | lifeless : please take a look when you get a chance | 00:37 |
| lifeless | dims: are they passing on master? | 00:39 |
| dims | lifeless : we did not break any existing scenarios so we are good | 00:40 |
| dims | lifeless : in this review we are trying to use oslo.db[fixtures] instead of test-resources directly | 00:41 |
| dims | (for nova) | 00:41 |
| dims | this review used to fail in gate-nova-requirements before which we fixed | 00:41 |
| lifeless | dims: sure, but those jobs are non-voting, which usually means that they are failing on master // flaky | 00:41 |
| lifeless | dims: I wouldn't expect constraints to be flaky, so the question is whether they are passing on master | 00:41 |
| dims | lifeless : ah. they are passing on master | 00:41 |
| lifeless | dims: before we dig in deep | 00:42 |
| dims | lifeless : y, i have another review in parallel to test things - https://review.openstack.org/#/c/259645/ | 00:42 |
| dims | the same 3 jobs work fine (green) | 00:42 |
| lifeless | k | 00:43 |
| lifeless | 2015-12-20 18:39:13.170 | ImportError: No module named testresources | 00:44 |
| lifeless | 2015-12-20 18:39:13.170 | The test run didn't actually run any tests | 00:44 |
| lifeless | dims: I'm pretty sure pip isn't fixed yet | 00:44 |
| lifeless | dims: we're going to be looking at 3-6 months to fix this | 00:45 |
| dims | all 3 jobs? | 00:45 |
| lifeless | dims: the pip patch is done, but we need it in a release, then time to get it out there | 00:45 |
| lifeless | dims: all three will have the same symptoms | 00:45 |
| lifeless | dims: pip sees oslo.db as a dependency and doesn't merge the extras in | 00:45 |
| dims | lifeless : one of them had a "Double Requirement" let me dig that up | 00:45 |
| dims | http://logs.openstack.org/59/237359/10/check/gate-nova-python34-constraints/25d23a5/console.html#_2015-12-20_18_31_51_323 | 00:46 |
| dims | lifeless : ^^ | 00:46 |
| dims | so 2 problems i guess | 00:46 |
| lifeless | dims: same thing yes | 00:46 |
| dims | ok thanks lifeless. i can rest easy :) | 00:47 |
| lifeless | https://github.com/pypa/pip/issues/3189 | 00:47 |
| lifeless | its closed, but not in a release | 00:47 |
| dims | thanks lifeless | 00:53 |
| dims | lifeless : one more... do you want a pbr release this week? | 00:57 |
| dims | lifeless : http://paste.openstack.org/show/482378/ | 01:01 |
| dims | please open a review against releases/ repo if you do | 01:02 |
| dims | thanks | 01:02 |
| *** dims has quit IRC | 01:02 | |
| *** dims has joined #openstack-release | 02:07 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/releases: Oslo Releases for week of Dec 21st 2015 https://review.openstack.org/259707 | 03:06 |
| lifeless | dims: no pbr release - not just before christmas | 03:17 |
| dims | lifeless :) | 03:19 |
| *** dims has quit IRC | 03:32 | |
| *** amotoki has joined #openstack-release | 05:21 | |
| *** ifat_afek has joined #openstack-release | 06:19 | |
| *** amotoki has quit IRC | 06:59 | |
| *** ifat_afek has quit IRC | 09:02 | |
| *** ifat_afek has joined #openstack-release | 09:03 | |
| *** openstack has joined #openstack-release | 15:35 | |
| *** openstackstatus has joined #openstack-release | 15:36 | |
| *** ChanServ sets mode: +v openstackstatus | 15:36 | |
| *** stevemar_znc is now known as stevemar | 16:28 | |
| jroll | dims_: we need a resolution on this before another o.msg release, or we're just going to break again https://review.openstack.org/#/c/254904/ | 16:31 |
| dims_ | jroll : good point | 16:33 |
| dims_ | jroll : merging it | 16:34 |
| jroll | dims_: awesome, thank you | 16:34 |
| openstackgerrit | Monty Taylor proposed openstack/releases: Release os-client-config 0.13.0 https://review.openstack.org/260090 | 16:44 |
| *** devananda has quit IRC | 17:08 | |
| *** devananda has joined #openstack-release | 17:15 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/releases: Oslo Releases for week of Dec 21st 2015 https://review.openstack.org/259707 | 17:39 |
| dims_ | jroll : ^^ | 17:40 |
| jroll | dims_: thanks | 17:41 |
| dims_ | mriedem : have a few mins to eye ball this? | 17:41 |
| mriedem | oh i suppose | 17:43 |
| mriedem | oh man, well, i'm going to have to check the git compare for the last release and see if there are any backward incompat changes being released | 17:44 |
| dims_ | mriedem : look at the list-changes job output | 17:50 |
| dims_ | mriedem : has all that good stuff | 17:50 |
| mriedem | ooo that's nice | 17:58 |
| mriedem | i hope 789a6625980f97a302d6320d864cebb35b405e1c doesn't impact logstash | 18:02 |
| mriedem | i'm not sure that it would, i guess we'll know if it does | 18:02 |
| *** dtantsur is now known as dtantsur|afk | 18:06 | |
| mriedem | dims_: should have probably been emitting a deprecation warning on this option https://review.openstack.org/#/c/252274/5/oslo_messaging/_drivers/amqp.py | 18:08 |
| mriedem | i kind of wonder if removing that warrants a major version bump | 18:09 |
| dims_ | mriedem : y borderline | 18:10 |
| jroll | mriedem: I agree completely | 18:12 |
| openstackgerrit | Sean McGinnis proposed openstack/releases: Release cinder 7.0.1 for stable/liberty https://review.openstack.org/260140 | 18:12 |
| jroll | idk what's borderline about removing a config option, especially when the default behavior was not the same as the behavior now | 18:12 |
| *** Guest95009 is now known as jgriffith | 18:15 | |
| dims_ | jroll : please read the approved spec when you get a chance http://specs.openstack.org/openstack/oslo-specs/specs/liberty/oslo.messaging-remove-double-reply.html | 18:16 |
| jroll | dims_: sure, but that still should be a major bump, and I wish it was deprecated properly | 18:17 |
| dims_ | jroll : soon we'll be shipping 10000.1.0 | 18:18 |
| jroll | dims_: nothing wrong with that :) | 18:18 |
| dims_ | if it helps folks from stopping using deprecated code, sure. it clearly does not | 18:19 |
| dims_ | sorry, not in a good mood | 18:19 |
| mriedem | posted my comments, there were some suspect changes in taskflow and tooz also | 18:20 |
| mriedem | that look like maybe a major version bump | 18:20 |
| mriedem | as for the oslo.messaging one, yeah removing deprecation options isn't in itself bad, but (1) the default behavior now is not the same and (2) it wasn't logging a deprecation warning when the option was being used | 18:21 |
| dims_ | jroll : mriedem : at the moment the entire burden of this backwards stuff is on oslo team which is not fair | 18:21 |
| mriedem | well, that's kind of how things work, right? things at the bottom of a software stack are slowest to be able to move | 18:21 |
| *** electrichead is now known as redrobot | 18:21 | |
| mriedem | b/c of deps up the stack | 18:21 |
| dims_ | we get told not to break any stuff, but folks don't cleanup for several releases | 18:22 |
| jroll | dims_: if you give proper deprecation warnings for the proper amount of time, you should totally be able to break things | 18:22 |
| jroll | if people don't clean up their stuff, it's their fault | 18:22 |
| dims_ | jroll : exhibit A - the timeutils + nova | 18:22 |
| jroll | I'm not up to speed on that one | 18:23 |
| dims_ | jroll : my problem is that i do not see any effort towards a common goal | 18:23 |
| dims_ | jroll : http://markmail.org/message/7y2p45xwndwru77c | 18:24 |
| mriedem | dims_: those patches can be restored | 18:24 |
| dims_ | mriedem : those are symptoms of the problem i am talking about matt. | 18:25 |
| dims_ | be right back | 18:25 |
| jroll | dims_: I mean, the efforts are just beginning | 18:27 |
| jroll | but really needing to do a major vs minor version bump isn't a burden at all | 18:27 |
| dims_ | jroll : just complaining :) | 18:43 |
| jroll | :) | 18:43 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/releases: Oslo Releases for week of Dec 21st 2015 https://review.openstack.org/259707 | 18:45 |
| dims_ | done. ^^ | 18:45 |
| dims_ | thanks for the reviews mriedem and jroll | 18:46 |
| jroll | np | 18:46 |
| dims_ | mriedem : jroll : we totally missed any reference to configuration options in http://docs.openstack.org/developer/pbr/semver.html | 18:47 |
| dims_ | lifeless ^^ | 18:47 |
| lifeless | dims_: ? | 18:50 |
| dims_ | lifeless : was re-reading that doc to see if we cover "i am removing a deprecated option. Do i bump x or y in x.y.z" | 18:51 |
| lifeless | dims_: its an API break | 18:52 |
| lifeless | dims_: x, always x. | 18:52 |
| lifeless | dims_: (if config options are part of the public API) | 18:53 |
| dims_ | lifeless : does it matter if the behavior remains the same after the option is removed or not? | 18:54 |
| jroll | afaik, it does not | 18:54 |
| dims_ | jroll : not for this case, asking in general | 18:54 |
| jroll | I know :) | 18:55 |
| dims_ | oh ok | 18:55 |
| jroll | but I defer to lifeless anyhow, because he tends to know these things better than me | 18:56 |
| lifeless | dims_: https://review.openstack.org/#/c/226157/ might offer some clarity | 18:57 |
| lifeless | dims_: but in general think about it like a quantum physics problem... if the change is observable | 18:58 |
| lifeless | dims_: and its disruptive, then its not backwards compatible | 18:58 |
| lifeless | dims_: deprecating a thing is not disruptive (assuming folk have their log setups correct etc, which is a reasonable assumption) | 18:59 |
| lifeless | dims_: removing the deprecated thing itself is where the disruption occurs. | 19:00 |
| lifeless | dims_: also, another nuance - I believe for servers we don't consider config options public interface | 19:02 |
| lifeless | dims_: and instead only consider the HTTP API, though I suspect deployers don't really like that :) | 19:02 |
| dims_ | lifeless : ack. trying to digest the nuances :) | 19:03 |
| dims_ | mriedem : looks like harlowja responded on the review https://review.openstack.org/#/c/259707/ please take a look and i can cut the releases | 19:05 |
| dims_ | after that | 19:05 |
| mriedem | dims_: i think taskflow probably needs a major version bump for the version field being dropped from the failure object, if that object is part of the public API for taskflow | 19:09 |
| mriedem | i think the version on tooz is probably OK as-is based on harlowja's reply | 19:09 |
| dims_ | mriedem : let me drop taskflow from this review for now | 19:11 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/releases: Oslo Releases for week of Dec 21st 2015 https://review.openstack.org/259707 | 19:12 |
| dims_ | mriedem : ready for your +1 :) | 19:13 |
| lifeless | mriedem: so I think we have enough consensus on the backwards compat spec to start applying it - or at least raising it - on any backwards incompat change: "if it breaks supported servers, don't do it" | 19:16 |
| lifeless | mriedem: I haven't looked at the list of releases in detail, but any major version bump is a good alert :) | 19:17 |
| mriedem | lifeless: i noted this as needing a major version bump for oslo.messaging https://review.openstack.org/#/c/252274/ | 19:19 |
| mriedem | i think that's the only one in dims_' current set of oslo releases | 19:19 |
| dims_ | mriedem : right | 19:20 |
| dims_ | lifeless : there | 19:26 |
| dims_ | lifeless : there should be some incentive for folks to cleanup the deprecated stuff. no? | 19:27 |
| *** doug-fish has quit IRC | 19:29 | |
| mriedem | dims_: well, depends, that's like saying nova should have incentive to support glance v2 just because glance v1 is deprecated, but nova doesn't actually need to use anything in glance v2, or at least didn't use to (not sure if there is anything nova is depending on for glance v2 besides the fact v1 is deprecated) | 19:33 |
| mriedem | it was really the glance team that wanted that to happen, which is why they were/are driving it | 19:34 |
| mriedem | same with keystoneauth | 19:34 |
| dims_ | right, there is no incentive for the core team currently | 19:35 |
| mriedem | well, one thing nova needs is an oslo liaison to raise these issues up https://wiki.openstack.org/wiki/CrossProjectLiaisons#Oslo | 19:40 |
| mriedem | that used to be jogo | 19:40 |
| mriedem | we won't have a nova meeting until early january, but that should be on the meeting agenda | 19:41 |
| dims_ | mriedem : i tried and haypo tried as well for a while after jogo left. at this point i believe for nova at least it should be a core who is a liaison. otherwise it wont work | 19:42 |
| mriedem | a core liaison is probably best, sure, but honestly i don't know who has bandwidth for that right now | 19:43 |
| mriedem | i'll add it to the meeting agenda though | 19:43 |
| mriedem | herding cats and reporting status, attending oslo meetings, that doesn't need to be a core | 19:43 |
| mriedem | that would actually be a good opportunity for a newer person looking to get involved | 19:44 |
| dims_ | mriedem : that's exactly what we tell other teams | 19:44 |
| dims_ | we can talk more about it in nova meeting. i am getting ready to push the release button | 19:45 |
| mriedem | lifeless: are you ok with the oslo.messaging major version bump here? https://review.openstack.org/#/c/259707/ | 19:46 |
| dims_ | mriedem : too early there i think :) | 19:48 |
| mriedem | nearly 9am | 19:49 |
| dims_ | mriedem : i don't expect him to say no to the bump | 19:49 |
| mriedem | release if you want, it's getting late if you're going to do it today, | 19:50 |
| mriedem | sdague is out for 2 weeks i think, | 19:50 |
| dims_ | yep | 19:50 |
| mriedem | and i'm only working tomorrow | 19:50 |
| mriedem | so if everything explodes from this, i only have tomorrow to look really | 19:50 |
| mriedem | i'll assume that mtreinish is not taking any vacation time though since he's young and single | 19:50 |
| dims_ | :) | 19:52 |
| jroll | young single people deserve vacations too! | 19:52 |
| mtreinish | mriedem: I'm takng vacation, just not today | 19:57 |
| mtreinish | maybe tomorrow, not sure yet | 19:57 |
| openstackgerrit | Merged openstack/releases: Oslo Releases for week of Dec 21st 2015 https://review.openstack.org/259707 | 20:13 |
| mtreinish | dims_: when you get a sec can you help with: https://review.openstack.org/#/c/259266/ | 20:14 |
| dims_ | mtreinish : upper-constraints already has tempest-lib===0.12.0 | 20:17 |
| dims_ | mtreinish : want to rebase? | 20:17 |
| mtreinish | dims_: that was pushed before it got updated. We still need the g-r bump | 20:17 |
| mtreinish | sure, one sec | 20:17 |
| mtreinish | done | 20:18 |
| * mtreinish notes the button works for that case | 20:18 | |
| dims_ | mtreinish : done | 20:18 |
| mtreinish | dims_: cool, thanks | 20:19 |
| lifeless | dims_: incentive yes, punishment no | 20:25 |
| lifeless | mriedem: dims_: looking | 20:25 |
| lifeless | mriedem: dims_ : Whats the incompatible change in messaging ? | 20:25 |
| mriedem | lifeless: https://review.openstack.org/#/c/252274/5/oslo_messaging/_drivers/amqp.py | 20:26 |
| lifeless | mriedem: so this breaks kilo [but the capped versions in kilo mitigate] ? | 20:27 |
| lifeless | actually, doesn't it break L too, per the docs ? | 20:28 |
| lifeless | mriedem: ^ | 20:28 |
| mriedem | it would break anyone using that option in L i think | 20:28 |
| lifeless | yeah | 20:28 |
| lifeless | so, yes, I object. We need to revert that, and leave it to L-eol. | 20:28 |
| mriedem | the server projects don't use it as far as i know, but it can be passed through from the server config files | 20:29 |
| lifeless | remind me | 20:31 |
| lifeless | does oslo.config error on invalid settings | 20:31 |
| lifeless | like | 20:31 |
| lifeless | foo=True | 20:31 |
| lifeless | but foo isn't in the schema? | 20:31 |
| lifeless | or does it ignore them | 20:31 |
| dims_ | lifeless : ignores | 20:31 |
| lifeless | ok | 20:31 |
| lifeless | so | 20:32 |
| lifeless | there are two parts here | 20:32 |
| lifeless | first, there's a bunch of cruft being cleaned up in the code | 20:32 |
| lifeless | and there is this option, which defaults *false* | 20:32 |
| lifeless | which we're now forcing to True | 20:33 |
| dims_ | lifeless : this was the spec https://specs.openstack.org/openstack/oslo-specs/specs/liberty/oslo.messaging-remove-double-reply.html | 20:34 |
| lifeless | so, is this wire level incompatible? | 20:34 |
| lifeless | its looking like it is | 20:34 |
| lifeless | won't that break upgrades? | 20:34 |
| dims_ | you can't mix juno and kilo | 20:35 |
| dims_ | in the same install | 20:35 |
| dims_ | if you want to use this new oslo.messaging library | 20:35 |
| lifeless | but thats exactly how nova rolling upgrades work | 20:35 |
| lifeless | they deliberately run during the rolling upgrade with half the stack old version, half the stack new version | 20:36 |
| dims_ | lifeless : let's see if it shows up in a grenade failure | 20:37 |
| lifeless | so AIUI oslo.messaging @ time of L's release can handle either 1-part or 2-part messages | 20:37 |
| lifeless | dims_: lets work through it quickly here | 20:37 |
| dims_ | lifeless : we'll probably need at least sileht for this | 20:37 |
| dims_ | i don't want to guess | 20:37 |
| lifeless | when we change this, we'll always send 1-part, which means K cannot handle a message we emit | 20:37 |
| lifeless | L can handle it. | 20:38 |
| lifeless | But, if this oslo.messaging is to be usable by L, and L is going to be able to upgrade from kilo, L still needs to be able to send messages to kilo mid rolling-upgrade, so L still needs this to be off by default. | 20:38 |
| lifeless | -> I think we can't change the default until K has eol'd. | 20:38 |
| lifeless | mriedem: ^ care to check my logic ? | 20:39 |
| lifeless | mriedem: since you spend way more time than me on stable issues... | 20:39 |
| mriedem | so the thinking is grenade in liberty will be broken by this | 20:42 |
| lifeless | if it ran unconstrained | 20:44 |
| lifeless | so specifically I'd expect requirements constraints updates to fail grenade after the release is done | 20:45 |
| lifeless | as I don't believe we have a job that reflects this yet | 20:45 |
| lifeless | (in L) | 20:45 |
| *** bnemec has quit IRC | 21:26 | |
| *** bnemec has joined #openstack-release | 21:28 | |
| *** dims_ has quit IRC | 21:33 | |
| *** dims has joined #openstack-release | 21:33 | |
| *** dims has quit IRC | 21:43 | |
| *** nikhil_k has joined #openstack-release | 21:44 | |
| *** nikhil has quit IRC | 21:48 | |
| *** dims has joined #openstack-release | 21:49 | |
| openstackgerrit | Monty Taylor proposed openstack/releases: Release os-client-config 0.13.0 https://review.openstack.org/260090 | 22:04 |
| mordred | dims: ^^ look, I made you a present :) | 22:07 |
| * mordred hands dims a large box of kittens to go with it | 22:07 | |
| *** dims_ has joined #openstack-release | 22:08 | |
| *** dims has quit IRC | 22:08 | |
| *** dims has joined #openstack-release | 22:12 | |
| *** dims_ has quit IRC | 22:13 | |
| openstackgerrit | Tony Breeds proposed openstack/releases: Release python-novaclient 2.23.3 for kilo https://review.openstack.org/260233 | 22:24 |
| *** dims has quit IRC | 22:29 | |
| *** mriedem is now known as mriedem_away | 22:30 | |
| *** dims has joined #openstack-release | 23:21 | |
| *** dims has quit IRC | 23:30 | |
| *** dims has joined #openstack-release | 23:32 | |
| *** gordc has quit IRC | 23:42 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!