| *** flwang1 has joined #openstack-rating | 08:18 | |
| flwang1 | sheeprine: ping | 08:18 |
|---|---|---|
| sheeprine | flwang1: pong | 08:18 |
| flwang1 | sheeprine: did you see my comments on the collector patch? just a small question, overall looks good | 08:19 |
| sheeprine | Yep saw that | 08:20 |
| sheeprine | The MetaCollector is only responsible of loading other collectors | 08:21 |
| flwang1 | yep, I guess so, then it's a little bit weird of making it as a plugable backend, toughts? | 08:22 |
| sheeprine | It's just to be able to use regular collectors without the meta collector | 08:23 |
| flwang1 | ok | 08:25 |
| flwang1 | these days I'm working on horizon plugin for rating, is there any guy from your company I can work with? | 08:26 |
| sheeprine | just to finish about the collectors, you can still use the old behaviour without any configurations (it's useful for simple or small deployments) or use the meta collector and enable/disable module and configure priority. | 08:32 |
| sheeprine | flwang1: does it seem reasonable to you? | 08:32 |
| sheeprine | We're working again on the Horizon integration, the guy that did the job was an intern and during the sprint we saw that it was far from working... | 08:33 |
| sheeprine | the code from our gitlab is way different from the stackforge one, we are working on integrating it, we can push it on another repo on github for you to work on it | 08:34 |
| sheeprine | One of my co worker will work on it (client + horizon) | 08:34 |
| flwang1 | sounds really cool | 08:34 |
| flwang1 | thank you so much | 08:35 |
| flwang1 | as for the rest api, any updates? | 08:35 |
| sheeprine | I was busy on other stuff, I really need to dedicate time for the new API. | 08:36 |
| flwang1 | the endpoint/parameter designed on apiary.io is what we're using in distil, BTW | 08:36 |
| flwang1 | sheeprine: me too :( | 08:37 |
| flwang1 | but I still suggest we have regular sync on each Monday until the summit :) | 08:37 |
| sheeprine | Yep | 08:39 |
| sheeprine | I'll work asap on moving the writer code out of the processor and writing the backend driver to store rated data. | 08:48 |
| sheeprine | And create a new process: cloudkitty-writer to generate reports | 08:48 |
| sheeprine | We'll need to implement the API on top of that | 08:48 |
| sheeprine | flwang1: ^ | 08:49 |
| flwang1 | sheeprine: cool | 08:49 |
| flwang1 | if you will submit the code of horizion plugin, pls let me know, thanks | 08:50 |
| sheeprine | Are you OK with the multiple collector code? Can you validate the review if you got time for this. | 08:50 |
| sheeprine | I'll push our code to github asap and give you the URL | 08:50 |
| sheeprine | I'm trying to see with the guy that did the Horizon integrations what should be adressed and if our repo is missing code | 08:52 |
| flwang1 | I'm ok with the collector code | 09:01 |
| sheeprine | good :) | 09:01 |
| flwang1 | except the question I mentioned above | 09:01 |
| flwang1 | ;) | 09:01 |
| flwang1 | but it's not a blocker | 09:01 |
| sheeprine | The goal is to have the previous behaviour for easier deployments | 09:02 |
| flwang1 | I will add my tiny +1 on the patch :) | 09:02 |
| sheeprine | or meta collector for more control | 09:02 |
| sheeprine | We'll iron stuff later ;) | 09:02 |
| flwang1 | yep, I see | 09:02 |
| sheeprine | BTW gpocentek is working on tests ;) | 09:02 |
| flwang1 | sheeprine: yep, i saw that | 09:02 |
| flwang1 | it's great to see more tests are coming | 09:03 |
| sheeprine | ekarlso: I've added the flake import exclusions in tox.ini | 13:36 |
| sheeprine | I'll validate the review so you can rebase your code and don't have errors about i18n | 13:36 |
| sheeprine | still same pep8 errors though | 13:36 |
| ekarlso | :p | 13:37 |
| sheeprine | s/same/some/ | 13:38 |
| *** flwang1 has quit IRC | 18:59 | |
| *** flwang1 has joined #openstack-rating | 20:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!