| *** threestrands has joined #openstack-rally | 05:06 | |
| *** threestrands has quit IRC | 08:01 | |
| *** tosky has joined #openstack-rally | 08:02 | |
| openstackgerrit | Andreas Jaeger proposed openstack/rally-openstack master: Update hacking for Python3 https://review.opendev.org/716885 | 08:05 |
|---|---|---|
| marosg | andreykurilin: could you help me with git? last zuul failed becasue there were changes of the last commit which chanegs how decorators are checked. So I rebased my code on master | 09:43 |
| marosg | but noiw when I try git review -R it complains I have two commits | 09:43 |
| marosg | https://paste.ubuntu.com/p/F94WVhghB7/ | 09:44 |
| andreykurilin | marosg: hi. Usually, I fix it by checkouting to master, pulling the latest code, switching back to may working branch and rebasing to master. | 09:48 |
| marosg | well, that is what I did (so that I could reproduce errors I got from zuul) | 09:49 |
| marosg | if you look at pastebin, 771c is from master | 09:50 |
| andreykurilin | strange | 09:51 |
| marosg | maybe I need to squash that commit from master to previous commit from master | 09:51 |
| andreykurilin | ok, from my experience: if you call `git review -R` it will not push the commits that already exists at gerrit, so you continue with this command and everything should be ok | 09:52 |
| openstackgerrit | Merged openstack/rally master: Update hacking for Python3 https://review.opendev.org/716750 | 09:58 |
| openstackgerrit | Marian Gasparovic proposed openstack/rally-openstack master: add manila+VM test https://review.opendev.org/715656 | 10:03 |
| andreykurilin | marosg: your patch looks good to me but need to thing how to enable CI for it (manila jobs do not have anything except keystone+manila) | 10:10 |
| andreykurilin | marosg: oh...one more thing: we had broken custom checks for pep8. it should be fixed with https://review.opendev.org/#/c/716885/ . Your change doesn't pass one of rule - double quotas should be used instead of single for wrapping strings for code consistency. I see some single quotas at your new unit tests | 10:16 |
| marosg | andreykurilin: I will change double quotas in an hour or so | 10:18 |
| andreykurilin | great, thanks! | 10:22 |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: Remove deprecated stuff. Part 1 https://review.opendev.org/715963 | 10:33 |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: Remove deprecated stuff. Part 1 https://review.opendev.org/715963 | 10:37 |
| openstackgerrit | Marian Gasparovic proposed openstack/rally-openstack master: add manila+VM test https://review.opendev.org/715656 | 10:57 |
| openstackgerrit | Merged openstack/rally-openstack master: Update hacking for Python3 https://review.opendev.org/716885 | 11:20 |
| *** rcernin has quit IRC | 11:54 | |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: [ci] Restore osresources comparison script https://review.opendev.org/716974 | 12:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: [ci] Restore osresources comparison script https://review.opendev.org/716974 | 12:53 |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: Remove deprecated stuff. Part 1 https://review.opendev.org/715963 | 13:01 |
| marosg | andreykurilin: ha, zuul is happy, looks like git black magic worked | 13:19 |
| andreykurilin | great to hear that | 13:59 |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: [ci] Restore osresources comparison script https://review.opendev.org/716974 | 14:11 |
| andreykurilin | marosg: can you push a follow up patch with adding one line note about new scenario here - https://github.com/openstack/rally-openstack/blob/master/CHANGELOG.rst#added ? | 14:12 |
| openstackgerrit | Marian Gasparovic proposed openstack/rally-openstack master: add ManilaShares.create_share_and_access_from_vm to CHANGELOG.rst https://review.opendev.org/717034 | 14:36 |
| *** dmellado has quit IRC | 15:14 | |
| *** dmellado has joined #openstack-rally | 15:30 | |
| openstackgerrit | Merged openstack/rally-openstack master: add manila+VM test https://review.opendev.org/715656 | 15:50 |
| openstackgerrit | Merged openstack/rally-openstack master: add ManilaShares.create_share_and_access_from_vm to CHANGELOG.rst https://review.opendev.org/717034 | 17:31 |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: DNM: play with osresources https://review.opendev.org/717098 | 18:32 |
| openstackgerrit | Merged openstack/rally-openstack master: Remove deprecated stuff. Part 1 https://review.opendev.org/715963 | 18:38 |
| openstackgerrit | Merged openstack/rally-openstack master: [ci] Restore osresources comparison script https://review.opendev.org/716974 | 19:01 |
| *** rcernin has joined #openstack-rally | 22:22 | |
| *** openstackstatus has quit IRC | 22:56 | |
| *** openstack has joined #openstack-rally | 22:57 | |
| *** ChanServ sets mode: +o openstack | 22:57 | |
| *** tosky has quit IRC | 23:00 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!