| *** tosky has joined #openstack-rally | 07:25 | |
| *** rcernin has quit IRC | 09:00 | |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: Clarify python trove classifiers https://review.opendev.org/715493 | 09:49 |
|---|---|---|
| *** dmellado has quit IRC | 10:50 | |
| *** dmellado has joined #openstack-rally | 12:06 | |
| marosg | andreykurilin: hello. would you have some time to review my patch? | 12:42 |
| openstackgerrit | Merged openstack/rally-openstack master: Clarify python trove classifiers https://review.opendev.org/715493 | 12:53 |
| *** dave-mccowan has joined #openstack-rally | 12:59 | |
| *** irclogbot_2 has quit IRC | 13:15 | |
| *** irclogbot_0 has joined #openstack-rally | 13:19 | |
| *** anilvenkata has joined #openstack-rally | 13:48 | |
| *** dmellado has quit IRC | 14:04 | |
| *** dmellado has joined #openstack-rally | 14:05 | |
| openstackgerrit | Andrey Kurilin proposed openstack/rally-openstack master: Remove deprecated stuff. Part 1 https://review.opendev.org/715963 | 14:34 |
| *** anilvenkata_ has joined #openstack-rally | 15:13 | |
| *** anilvenkata has quit IRC | 15:16 | |
| *** dmellado has quit IRC | 15:32 | |
| *** andreykurilin has quit IRC | 15:39 | |
| *** dmellado has joined #openstack-rally | 15:39 | |
| *** Anticimex has quit IRC | 15:45 | |
| *** Anticimex has joined #openstack-rally | 15:45 | |
| *** andreykurilin has joined #openstack-rally | 15:46 | |
| *** Anticimex has quit IRC | 16:43 | |
| *** Anticimex has joined #openstack-rally | 16:44 | |
| marosg | andreykurilin: those unittests which look similar to vmtaks, core of it is a copy/paste from vmtask. I will see what I can do with it, thanks for review | 16:55 |
| marosg | "The script at L127 doesn't produce any JSON-like output, so everything at L152-161 & L173-176 is redundant" - it means it is redundant also in vmtaks from where I copied | 17:13 |
| andreykurilin | marosg: not. VMTasks.boot_runcommand_delete scenario accepts the script (or command) to execute on remote host. This script can provide rally-like output that we can accept for building charts. The good example is VMTasks.dd_load_test scenario which executes VMTasks.boot_runcommand_delete with hardcoded script that produces json output | 17:17 |
| andreykurilin | Your scenario also have hardocded script. This script cannot be modified outside the code (cannot be modified via task args), so it's output is always predictable and is always text | 17:18 |
| andreykurilin | that is why no need to try parse the output as json, since we know that it will never have json | 17:19 |
| andreykurilin | another case (which I tried to describe at first comment) is to use similar to VMTasks.dd_load_test script that will collect more data and also produces output in json format | 17:20 |
| *** anilvenkata has joined #openstack-rally | 17:30 | |
| *** anilvenkata has quit IRC | 17:30 | |
| marosg | ok, thanks for explanation | 17:48 |
| *** rcernin has joined #openstack-rally | 21:56 | |
| *** tosky has quit IRC | 22:20 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!