Sunday, 2015-05-10

*** anshul has quit IRC00:29
*** mwagner_lap has joined #openstack-rally01:29
*** botang has quit IRC02:31
*** botang has joined #openstack-rally02:31
*** igormarnat is now known as imarnat03:58
*** tfreger has joined #openstack-rally04:29
*** tfreger has left #openstack-rally04:31
*** imarnat is now known as igormarnat04:33
*** yfried|afk has quit IRC04:59
*** yfried|afk has joined #openstack-rally06:20
*** exploreshaifali has joined #openstack-rally07:01
*** yfried|afk is now known as yfried__07:18
*** yfried__ is now known as yfried|afk07:28
*** agarciam has joined #openstack-rally07:39
*** andreykurilin has quit IRC07:43
*** oanufriev has quit IRC07:43
*** amaretskiy has quit IRC07:44
*** svasheka has quit IRC07:45
*** rvasilets_ has quit IRC07:47
*** aarefiev has quit IRC07:50
*** rvasilets has joined #openstack-rally07:59
*** svasheka has joined #openstack-rally07:59
*** aarefiev has joined #openstack-rally07:59
*** oanufriev has joined #openstack-rally08:00
*** amaretskiy has joined #openstack-rally08:00
*** andreykurilin1 has joined #openstack-rally08:02
*** exploreshaifali has quit IRC08:10
*** yfried|afk is now known as yfried__08:33
*** svasheka has quit IRC08:38
*** rvasilets has quit IRC08:40
*** andreykurilin1 has quit IRC08:40
*** amaretskiy has quit IRC08:41
*** aarefiev has quit IRC08:41
*** oanufriev has quit IRC08:41
*** yfried__ is now known as yfried|afk08:44
*** yfried|afk is now known as yfried__08:45
*** exploreshaifali has joined #openstack-rally09:16
*** yfried__ has quit IRC09:16
*** rvasilets has joined #openstack-rally09:22
*** agarciam has quit IRC09:26
*** aarefiev has joined #openstack-rally09:29
*** svasheka has joined #openstack-rally09:29
*** amaretskiy has joined #openstack-rally09:38
*** andreykurilin1 has joined #openstack-rally09:38
*** oanufriev has joined #openstack-rally10:14
*** exploreshaifali has quit IRC11:08
*** yfried__ has joined #openstack-rally12:23
yfried__boris-42: ping12:38
boris-42yfried__: pong12:43
yfried__boris-42: hi12:44
yfried__boris-42: https://review.openstack.org//#/c/168849/12:44
boris-42yfried__: okay I will review it12:48
yfried__boris-42: tnx12:48
boris-42yfried__: we need as well andreykurilin1 )12:48
yfried__boris-42: of course12:48
boris-42yfried__: what about moving SLA stuff12:49
yfried__boris-42: working on it now12:52
yfried__boris-42: https://review.openstack.org//#/c/180509/7/rally/cmd/commands/info.py12:52
yfried__boris-42: I don't understand your comment ther12:52
yfried__e12:52
yfried__boris-42: do you want to me to add another: utils.load_plugins("/path/to/plugins")?12:53
boris-42yfried__: yes you must add it otherwise it won't work12:54
boris-42yfried__: you don't need to add /path/to/plugins12:55
boris-42yfried__: you can just add "rally.plugins"12:55
boris-42yfried__: it should work12:55
boris-42yfried__: if you don't import all modules in rally.plugins they won't be autodiscovered and they won't work12:55
yfried__boris-42: I'm not sure about that, but does it mean that I need to remove the import from info.py file?12:57
boris-42yfried__: what you are not sure about?12:57
boris-42yfried__: about autodiscovering?12:57
boris-42yfried__: I wrote it, so you can be sure*12:57
yfried__boris-42: I mean that I have no idea how this works12:57
boris-42yfried__: it is very simple mechanism12:57
yfried__boris-42: so I'm just following your instructions12:57
boris-42yfried__: let me expalian how it works12:58
boris-42there is base class12:58
yfried__boris-42: I'm pushing my current draft including scenarios.12:58
boris-42and we are iterating over all subclasses12:58
boris-42of this baseclass12:58
boris-42subclasses are plugins12:58
boris-42and we are just checking that name of class (whatever) is that we are looking for12:58
boris-42yfried__: ^12:58
boris-42yfried__: so if you don't import modules, when you will start iterating over the subclasses (you won't find anything that wasn't imported)12:59
boris-42yfried__: that is why we need to do recursive imports12:59
boris-42yfried__: here is how it works now https://github.com/openstack/rally/blob/master/rally/benchmark/__init__.py#L19-L2113:00
yfried__boris-42: do I need to use the utils.load_plugins func, or do a simple "from rally import plugins"?13:00
boris-42yfried__: if you do "from rally import plugins" nothing won't be imported except plugins and import from plugins13:00
boris-42yfried__: and you need to improt all modules13:01
boris-42so you need these special utils13:01
boris-42rutils.import_modules_from_package("rally.plugin")13:01
boris-42yfried__: the questing regarding to "do you need to import in info" module13:01
boris-42yfried__: nope you don't need if you put where I asked you, becuase that place will be executed before info commands13:02
boris-42yfried__: I hope now it's no more magic for you?)13:03
boris-42yfried__: by the way I would like one more thing from you13:09
boris-42yfried__: it's to put read me file that describes plugins13:09
boris-42yfried__: it can be just ln -s to the documentation with name README.rst here13:09
boris-42yfried__: https://rally.readthedocs.org/en/latest/plugins.html13:10
boris-42yfried__: it will simplify learning repo structure13:10
*** aarefiev has quit IRC13:19
*** rvasilets has quit IRC13:20
*** aarefiev has joined #openstack-rally13:20
*** rvasilets has joined #openstack-rally13:20
*** yfried__ is now known as yfried|afk13:35
*** tfreger has joined #openstack-rally13:38
*** tfreger has left #openstack-rally13:38
*** yfried|afk is now known as yfried__13:48
openstackgerritYair Fried proposed openstack/rally: Split SLA to base and plugins  https://review.openstack.org/18050914:51
openstackgerritYair Fried proposed openstack/rally: Split runners to base and plugins  https://review.openstack.org/18090414:51
openstackgerritYair Fried proposed openstack/rally: Split scenarios under Plugins  https://review.openstack.org/18173814:51
yfried__boris-42: I'm having trouble with the imports (I think) my unitests aren't working14:52
yfried__boris-42: could you please take a look? and could you please post the README thing to the patch comments?14:52
*** yfried has joined #openstack-rally15:10
*** yfried__ has quit IRC15:13
*** yfried_ has joined #openstack-rally16:06
*** yfried_ is now known as yfried|afk16:08
*** yfried has quit IRC16:10
*** yfried|afk is now known as yfried_16:13
*** yfried_ has quit IRC16:23
*** mpopow has joined #openstack-rally16:45
*** yfried_ has joined #openstack-rally17:39
*** e0ne has joined #openstack-rally17:53
*** e0ne has quit IRC17:59
*** e0ne has joined #openstack-rally18:03
*** openstackgerrit has quit IRC18:04
*** openstackgerrit has joined #openstack-rally18:05
*** e0ne has quit IRC18:24
*** e0ne has joined #openstack-rally18:28
*** e0ne has quit IRC18:30
*** e0ne has joined #openstack-rally18:34
*** e0ne has quit IRC18:37
*** e0ne has joined #openstack-rally18:41
*** e0ne has quit IRC19:01
*** e0ne has joined #openstack-rally19:05
*** e0ne has quit IRC19:07
*** e0ne has joined #openstack-rally19:12
*** e0ne has quit IRC19:14
*** e0ne has joined #openstack-rally19:18
*** flamebot has quit IRC19:26
*** e0ne has quit IRC19:35
*** e0ne has joined #openstack-rally19:40
*** e0ne has quit IRC19:40
*** panbalag has quit IRC20:25
boris-42yfried_: I can maybe20:26
*** mpopow has quit IRC22:46
*** mpopow has joined #openstack-rally23:47
*** mpopow has quit IRC23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!