| opendevreview | Friedrich Hiekel proposed openstack/patrole master: fix wrong error type in glance metadef tests https://review.opendev.org/c/openstack/patrole/+/850462 | 08:37 |
|---|---|---|
| opendevreview | Friedrich Hiekel proposed openstack/patrole master: fix wrong error type in glance metadef tests https://review.opendev.org/c/openstack/patrole/+/850462 | 09:40 |
| opendevreview | Benny Kopilov proposed openstack/tempest master: Allow multiple instances on create_test_server https://review.opendev.org/c/openstack/tempest/+/850518 | 12:44 |
| opendevreview | Martin Kopec proposed openstack/devstack master: Fix doc for adding sudo privileges to stack user https://review.opendev.org/c/openstack/devstack/+/850525 | 14:09 |
| slaweq | dansmith: hi, I recently finally checked that "v2.0" endpoint in the neutron logs as You asked me some time ago | 14:49 |
| slaweq | I proposed patch https://review.opendev.org/c/openstack/devstack/+/849145 to change it | 14:49 |
| slaweq | please review it when You will have some time | 14:49 |
| dansmith | oh sweet, thanks! | 14:59 |
| akekane_ | soniya29, around? | 17:09 |
| *** akekane_ is now known as abhishekk | 17:09 | |
| soniya29 | abhishekk, yes | 17:09 |
| abhishekk | soniya29, just replied to your comment on tempest patch | 17:10 |
| soniya29 | abhishekk, sure, let me check | 17:10 |
| abhishekk | ack, thanks | 17:10 |
| soniya29 | abhishekk, i have dropped one suggestion on the patch, otherwise everything seems good :) | 17:38 |
| abhishekk | soniya29, ack,thanks, the link is actually in comments | 17:38 |
| abhishekk | https://review.opendev.org/c/openstack/tempest/+/825112/comments/e97c07c8_c03756c9 | 17:38 |
| dansmith | putting it in the commit message is less good, IMHO, because it won't be relevant forever, and commit messages are timeless | 17:39 |
| abhishekk | adding DNM link in commit message does not seeks good | 17:39 |
| abhishekk | s/seems | 17:39 |
| dansmith | agree | 17:40 |
| soniya29 | abhishekk, dansmith, yeah, it wont be relevant forever hence adding may not seem good, it just that it makes reviewers work a bit easy :) | 17:43 |
| abhishekk | understood, will add it again on a latest patch as a comment | 17:44 |
| soniya29 | abhishekk, thanks! | 17:45 |
| abhishekk | np! thank you for review | 17:45 |
| dansmith | what would really help, | 17:46 |
| dansmith | is if abhishekk would be better about using the same topic everywhere for related patches, so it's easy to click on it and see all those, including the DNM test patches :) | 17:47 |
| * dansmith scowls at abhishekk | 17:47 | |
| abhishekk | that is also a good idea | 17:47 |
| dansmith | this one is better than some in that at least the spec and code are in the same branch, which isn't always the case | 17:47 |
| dansmith | "git review -t" if they're not already stacked in glance (but they probably should be in this case anyway) | 17:49 |
| abhishekk | just DNM is not in the list | 17:49 |
| dansmith | right | 17:49 |
| abhishekk | now it is | 17:49 |
| dansmith | nice :) | 17:50 |
| abhishekk | lesson learned :D | 17:50 |
| dansmith | ++ | 17:50 |
| soniya29 | abhishekk, dansmith, ++ | 18:07 |
| opendevreview | Simon Dodsley proposed openstack/tempest master: Add new NVMe protocols to the known list of protocols https://review.opendev.org/c/openstack/tempest/+/849841 | 20:00 |
| opendevreview | Simon Dodsley proposed openstack/tempest master: Add new NVMe protocols to the known list of protocols https://review.opendev.org/c/openstack/tempest/+/849841 | 21:08 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!