*** dkranz has joined #openstack-qa | 00:00 | |
dkranz | cyeoh: Chris, you there? | 00:01 |
---|---|---|
dkranz | cyeoh: I'm not sure what to do with things like https://review.openstack.org/#/c/42616/1 | 00:02 |
dkranz | cyeoh: I can't really verify it is correct, but I believe you. | 00:02 |
dkranz | cyeoh: I'm not sure why afazekas gave it a +1 rather than +A either. | 00:03 |
*** HenryG has joined #openstack-qa | 00:32 | |
openstackgerrit | Angus Salkeld proposed a change to openstack-dev/devstack: Add support for heat enviroments https://review.openstack.org/43387 | 00:33 |
*** jasondotstar has joined #openstack-qa | 00:52 | |
*** jasondotstar has joined #openstack-qa | 00:52 | |
*** malini_afk is now known as malini | 01:00 | |
*** anteaya has quit IRC | 01:08 | |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: close http connections https://review.openstack.org/43390 | 01:12 |
mriedem | has anyone seen the CLI tests start failing in the last day or so with 'too many files open'? was just looking at that and then saw the above review ^ | 01:33 |
mriedem | coincidentally | 01:33 |
clarkb | we can bump the file limit if you need a bunch legitimately | 01:34 |
mriedem | it's weird, i just started seeing this this morning, wasn't a problem yesterday, and there weren't any merged commits in the last day that jumped out at me as causing this | 01:37 |
cyeoh | dkranz: hi - i'm not sure why afazekas +1'd it rather than +A | 01:47 |
cyeoh | dkranz: its one of those that we can't check in the gate because the corresponding nova patch isn't merged yet and we can't merge the nova side until the tempest side is fixed. | 01:48 |
cyeoh | dkranz: however the tempest change does look correct to me from looking at what the proposed nova patch is doing | 01:49 |
*** psedlak has quit IRC | 01:49 | |
*** psedlak_ has joined #openstack-qa | 01:49 | |
mriedem | clarkb: btw, i mean 'too many files open' when running tempest internally, not in openstack community | 01:56 |
clarkb | I see | 01:56 |
dkranz | cyeoh: Thanks, Chris. I just approved it. | 02:10 |
dkranz | cyeoh: I'd appreciate a look at https://review.openstack.org/#/c/40897/ | 02:12 |
dkranz | cyeoh: I would like to push the slow heat job (non-voting) tomorrow. | 02:13 |
*** LiangZheng has joined #openstack-qa | 02:18 | |
*** mriedem has quit IRC | 02:21 | |
cyeoh | dkranz: sure, I'll have a look at it | 02:25 |
dkranz | cyeoh: Thanks. Got to move towards sleep now... | 02:26 |
openstackgerrit | Angus Salkeld proposed a change to openstack-dev/devstack: Add support for heat enviroments https://review.openstack.org/43387 | 02:43 |
*** malini is now known as malini_afk | 03:03 | |
*** psedlak_ has quit IRC | 03:52 | |
*** jasondotstar has quit IRC | 04:10 | |
openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 04:15 |
afazekas | dkranz, cyeoh: I +1 it because I wanted to check the API stability impact before +2 it | 04:20 |
cyeoh | afazekas: ah, cool. I think it'd be useful when cores +1 instead of +2 if we leave a comment saying why. I completely support people doing a +1 instead of +2, just is useful for others (including the submitter) to know what the concern is. | 04:22 |
*** psedlak has joined #openstack-qa | 04:24 | |
*** Anju has joined #openstack-qa | 04:32 | |
*** rahmu has quit IRC | 04:38 | |
*** rahmu has joined #openstack-qa | 04:39 | |
raies | annegentle: please have a look on this https://review.openstack.org/#/c/42624/ | 04:39 |
afazekas | cyeoh: makes sense | 04:48 |
*** afazekas is now known as __afazekas | 04:48 | |
Anju | afazekas : gm please have a look in this | 04:50 |
Anju | __afazekas : gm please have a look in this | 04:51 |
openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 04:56 |
__afazekas | Anju: I will login again from another location | 04:56 |
openstackgerrit | Angus Salkeld proposed a change to openstack-dev/devstack: Add support for heat enviroments https://review.openstack.org/43387 | 05:00 |
Anju | __afazekas : ok | 05:09 |
openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 05:20 |
*** afazekas has joined #openstack-qa | 05:23 | |
afazekas | Anju: pong | 05:24 |
Anju | yeah afazekas : https://review.openstack.org/#/c/38803/ | 05:24 |
afazekas | Anju: why did you pointed me that review ? | 05:26 |
Anju | actually the commiter wants the reveiwer | 05:27 |
Anju | and i know u | 05:27 |
Anju | and i also saw the code | 05:27 |
Anju | so wants your comments also | 05:27 |
afazekas | Anju: I usually do the tempest reviews first, this is nova change and it already got 3 times +1. I cannot vote with +2 on nova changes. | 05:29 |
Anju | okk afazeka s : | 05:29 |
Anju | afazekas .I did not know this | 05:30 |
psedlak | afazekas: https://jenkins01.openstack.org/job/gate-tempest-devstack-vm-full/4193/console | 05:40 |
afazekas | Anju: After the bug fixed, a test cases would be a good idea | 05:43 |
Anju | ao afazeka s: It can added be as a negative test? | 05:44 |
Anju | ao afazeka : It can added be as a negative test? | 05:44 |
Anju | ao afazekas : It can added be as a negative test? | 05:45 |
*** thomasbiege has joined #openstack-qa | 05:49 | |
openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 05:50 |
afazekas | Anju: probbaly there is more similar case, what should be tested | 05:52 |
afazekas | Anju: the nova change might get -1, I guess it needs to use 'is not None' in the if | 05:54 |
*** thomasbiege has quit IRC | 05:54 | |
openstackgerrit | Yuuichi Fujioka proposed a change to openstack/tempest: Append some operations to boot from volume pattern https://review.openstack.org/41048 | 06:05 |
openstackgerrit | Mike Perez proposed a change to openstack-dev/grenade: Add Cinder API v2 to Keystone catalog https://review.openstack.org/43352 | 06:06 |
Anju | afazekas : yes :) | 06:11 |
Anju | afazekas : 5 times + 1 | 06:12 |
afazekas | stevebaker: ping | 06:16 |
afazekas | cyeoh: can you +A it https://review.openstack.org/#/c/34866/ ? | 06:18 |
afazekas | I mean this one: https://review.openstack.org/#/c/36367/ | 06:23 |
cyeoh | afazekas, just looking now | 06:23 |
cyeoh | afazekas: done, but aren't you able to approve it too? dkranz had already +2'd it too | 06:24 |
cyeoh | afazekas,: oh nw I see | 06:25 |
afazekas | cyeoh: thank you | 06:29 |
afazekas | dkranz: https://review.openstack.org/#/c/40897/ merge conflict | 06:32 |
*** SergeyLukjanov has joined #openstack-qa | 06:42 | |
afazekas | cyeoh: https://review.openstack.org/#/c/42593/ a rebased change | 06:44 |
cyeoh | afazekas: ok | 06:50 |
*** guest_____ has quit IRC | 06:52 | |
afazekas | cyeoh: thank you | 06:54 |
cyeoh | afazekas: np | 06:54 |
*** SergeyLukjanov has quit IRC | 06:58 | |
raies | annegentle: r u there ? | 07:20 |
raies | hi. is there anybody from "openstack-api-site" ? | 07:26 |
raies | ??? | 07:31 |
raies | ?? | 07:31 |
raies | ?? | 07:31 |
openstackgerrit | afazekas proposed a change to openstack/tempest: Updating HACKING.rst https://review.openstack.org/42296 | 07:50 |
afazekas | raies: Are you planning to add something more to api site which depends on your previous patch ? | 07:56 |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: Fix ssh timeout issue https://review.openstack.org/43415 | 07:57 |
*** giulivo has joined #openstack-qa | 07:58 | |
*** fbo_away is now known as fbo | 08:02 | |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: close http connections https://review.openstack.org/43390 | 08:03 |
raies | afazekas: I had logged a bug https://bugs.launchpad.net/openstack-api-site/+bug/1213890. my patch https://review.openstack.org/42296 are fixes of this bug. | 08:21 |
raies | afazekas: I want to let someone to know about this | 08:22 |
raies | bug | 08:22 |
*** jhenner has joined #openstack-qa | 08:24 | |
*** psedlak has quit IRC | 08:29 | |
*** jhenner has quit IRC | 08:30 | |
*** thomasbiege has joined #openstack-qa | 08:32 | |
*** thomasbiege has quit IRC | 08:37 | |
*** psedlak has joined #openstack-qa | 08:40 | |
*** psedlak has quit IRC | 08:43 | |
*** psedlak has joined #openstack-qa | 08:43 | |
openstackgerrit | Nejc Saje proposed a change to openstack/tempest: Adds client and CRUD tests for Ceilometer alarms https://review.openstack.org/39237 | 08:47 |
*** SergeyLukjanov has joined #openstack-qa | 08:51 | |
raies | afazekas : | 09:02 |
raies | afazekas : ping | 09:02 |
afazekas | psedlak: https://review.openstack.org/#/c/43309/ can you add the related bug numbers to this review ? | 09:16 |
afazekas | raies: pong | 09:16 |
raies | afazekas: yes i am in | 09:18 |
raies | I have replied on your comment in the patch 5 | 09:18 |
afazekas | psedlak: what can be the solution ? force install newer version by devstack, adding to one of the requirement.txt , or just skipping those test by the bug number ? | 09:19 |
psedlak | afazekas: 1) add it to the requirements somewhere - that would be better consulted with someone who know what python-keyring is used for here | 09:20 |
raies | afazekas: please also check my commit messages | 09:21 |
psedlak | 2) pip install newer version by devstack or install gir1.2-gnomekeyring package | 09:21 |
afazekas | psedlak: IMHO it mostly used for pissing of me , by expecting things in the system based a wrong assumption :) | 09:21 |
psedlak | 1) could be maybe done in keystoneclient (if it's the one who uses keyring) | 09:22 |
psedlak | 2) would require modification of stable/grizzly devstack so it's kind of tricky too | 09:22 |
afazekas | psedlak: workaround on the keystone client side ? | 09:23 |
psedlak | 3) we can skip those test for bug, but still this needs to go to the stable/grizzly tempest ... which is again ... | 09:23 |
psedlak | afazekas: well i meant ... if a) keystoneclient is the only consumer of python-keyring b) it's always used from master branch b') we don't need to touch stable/* branches c) it's known to work with 1.6-1 keyring | 09:25 |
psedlak | afazekas: if all of those are true ... it could be good place for fix | 09:25 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Implement some test of extend-volume https://review.openstack.org/42813 | 09:25 |
openstackgerrit | A change was merged to openstack/tempest: cli: add messages to assertTrue https://review.openstack.org/43350 | 09:39 |
afazekas | giulivo: https://review.openstack.org/#/c/42813/ | 09:40 |
*** thomasbiege has joined #openstack-qa | 09:40 | |
afazekas | you was fast :) | 09:40 |
*** thomasbiege has quit IRC | 09:42 | |
raies | afazekas: I had asked someting in https://review.openstack.org/#/c/42624/5/api-ref/src/wadls/netconn-api/src/api_samples/networks-post-create-bulk-req.xml | 09:42 |
afazekas | raies: As I told before, I do not know the api-site commit rules and customs perfectly. So I am not the best person to ask. But AFAIK the other samples are the same. | 09:44 |
psedlak | afazekas: https://review.openstack.org/#/c/43424/ | 09:45 |
*** LiangZheng has quit IRC | 09:45 | |
afazekas | cyeoh, mtreinish, jaypipes, dkranz: https://review.openstack.org/#/c/43424/ | 09:46 |
psedlak | afazekas: http://status.openstack.org/zuul/#graph-container | 10:02 |
psedlak | afazekas: https://jenkins02.openstack.org/ https://jenkins01.openstack.org/ https://jenkins.openstack.org/ | 10:03 |
psedlak | russellb: ping | 10:29 |
*** jhenner has joined #openstack-qa | 10:36 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Implement some test of extend-volume https://review.openstack.org/42813 | 10:38 |
*** SergeyLukjanov has quit IRC | 11:04 | |
afazekas | raies: an additional note: the other xml requests starts with the '<?xml version="1.0" encoding="UTF-8"?>' line | 11:07 |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: refactor - _is_timed_out using instance timeout https://review.openstack.org/43434 | 11:08 |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: Fix ssh timeout issue https://review.openstack.org/43415 | 11:08 |
raies | afazekas: no it is not like that , please check http://api.openstack.org/api-ref.html#netconn-api | 11:29 |
afazekas | raies: on that page the other jsons are formatted differently (probbaly with some kind of json formatter) | 11:33 |
raies | yes I think this is correct | 11:35 |
raies | I have to amend | 11:35 |
*** Anju has quit IRC | 11:46 | |
afazekas | 1. '<?xml version="1.0" encoding="UTF-8"?>' | 11:46 |
afazekas | 2. same request on json + xml | 11:46 |
afazekas | 3. same formatting | 11:46 |
afazekas | 4. really working examples | 11:47 |
*** anteaya has joined #openstack-qa | 11:50 | |
*** thomasbiege has joined #openstack-qa | 11:51 | |
*** thomasbiege has quit IRC | 11:52 | |
raies | 1,2,3,4 what these are ? | 11:55 |
raies | afazekas: ^^ | 11:56 |
*** SergeyLukjanov has joined #openstack-qa | 12:05 | |
afazekas | raies: 1: ok, the other network sample does not contains it, however it is normally there | 12:09 |
afazekas | 2. the bulk network xml and json request IMHO should be similar | 12:11 |
*** malini_afk is now known as malini | 12:11 | |
afazekas | 3. json should be formatted as the others | 12:11 |
openstackgerrit | A change was merged to openstack/tempest: Heat autoscaling scenario test https://review.openstack.org/36367 | 12:12 |
mkoderer | afazekas: why does it take so long to merge https://review.openstack.org/#/c/38980/ into master? | 12:13 |
openstackgerrit | Marc Koderer proposed a change to openstack/tempest: Create discovery option for stress test https://review.openstack.org/43444 | 12:17 |
afazekas | mkoderer: I do not see it in the queue, may be it needs a reverify | 12:18 |
afazekas | there is another change in a similar situation | 12:18 |
mkoderer | strange | 12:18 |
mkoderer | afazekas: please have a look to https://review.openstack.org/#/c/43444/ | 12:18 |
mkoderer | it's WIP and not tested - but I want to know you opinion | 12:19 |
mkoderer | giulivo: maybe you could have a look as well | 12:20 |
mkoderer | I know that I have to clean up the code - but I need you feedback :) | 12:21 |
openstackgerrit | A change was merged to openstack/tempest: Cleanup: Add common "create volume" method https://review.openstack.org/42593 | 12:21 |
afazekas | I am not sure is it py.26 friendly | 12:22 |
afazekas | http://docs.python.org/2/library/unittest.html#test-discovery | 12:22 |
mkoderer | mhh I see.. but how did tempest do it in 26 then? | 12:23 |
afazekas | nose has something | 12:24 |
afazekas | testtools also has an alternate method | 12:24 |
mkoderer | ok but nose is something that I don't wanted to use | 12:25 |
afazekas | :) | 12:25 |
mkoderer | ok I will check testtools | 12:25 |
afazekas | mkoderer: at first look, it looks ok | 12:27 |
mkoderer | afazekas: ok great - I just want to make sure that my idea makes sense at all | 12:28 |
afazekas | mkoderer: if contains configure info in decorator, it may not fit for everyone | 12:31 |
afazekas | For example constant multiplier for the all max_threads, would help to scale it for larger systems | 12:32 |
*** jasondotstar has joined #openstack-qa | 12:32 | |
mkoderer | afazekas: yes good idea | 12:32 |
openstackgerrit | Alex Gaynor proposed a change to openstack/tempest: Fixed up a missing space in an error message https://review.openstack.org/43451 | 12:41 |
*** weshay has joined #openstack-qa | 12:44 | |
*** raies has left #openstack-qa | 12:45 | |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: Fix ssh timeout issue https://review.openstack.org/43415 | 12:53 |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: refactor - _is_timed_out using instance timeout https://review.openstack.org/43434 | 12:53 |
mkoderer | dkranz: ping | 12:53 |
openstackgerrit | A change was merged to openstack/tempest: Fixing format_flavor to handle flavor extra_specs https://review.openstack.org/42616 | 12:59 |
*** mriedem has joined #openstack-qa | 13:23 | |
*** SergeyLukjanov has quit IRC | 13:30 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack-dev/devstack: Skip DHCP variables for Nova Network FlatManager https://review.openstack.org/43468 | 13:31 |
*** thomasbiege has joined #openstack-qa | 13:31 | |
*** thomasbiege has quit IRC | 13:32 | |
*** sthaha has quit IRC | 13:36 | |
*** woodspa has joined #openstack-qa | 13:43 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Use common create_keypair method for autoscaling https://review.openstack.org/43472 | 13:48 |
dkranz | mkoderer: pong | 13:48 |
*** SergeyLukjanov has joined #openstack-qa | 13:56 | |
mkoderer | dkranz: could you have a look to https://review.openstack.org/#/c/43444/ | 14:00 |
dkranz | mkoderer: Yes, in a few minutes. | 14:00 |
mkoderer | dkranz: I'd appreciate your thoughts | 14:00 |
mkoderer | it's WIP so it's more a review of the design what I would need | 14:01 |
mkoderer | dkranz: thx | 14:01 |
*** burt has joined #openstack-qa | 14:03 | |
openstackgerrit | A change was merged to openstack/tempest: Unit tests as stress tests https://review.openstack.org/38980 | 14:05 |
openstackgerrit | A change was merged to openstack/tempest: Skip os-fixed-ips test since neutron has not implemented it https://review.openstack.org/42798 | 14:06 |
openstackgerrit | A change was merged to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 14:06 |
dkranz | mkoderer: So now that we have the capability to run and tempest test as a stress test, I'm not sure why we want to hard-code the stress attributes in the code. | 14:09 |
dkranz | mkoderer: I would think those would be described in an overall stress configuration that we already support. | 14:10 |
openstackgerrit | Yassine Lamgarchal proposed a change to openstack/tempest: Adds client and CRUD tests for Ceilometer alarms https://review.openstack.org/39237 | 14:18 |
*** afazekas has quit IRC | 14:22 | |
*** SergeyLukjanov has quit IRC | 14:24 | |
*** SergeyLukjanov has joined #openstack-qa | 14:25 | |
*** Anju has joined #openstack-qa | 14:26 | |
openstackgerrit | Yassine Lamgarchal proposed a change to openstack/tempest: Adds client and CRUD tests for Ceilometer alarms https://review.openstack.org/39237 | 14:31 |
giulivo | ping mtreinish | 14:32 |
giulivo | regarding this https://review.openstack.org/#/c/42424/ | 14:33 |
giulivo | I only see two places where we use "bug:" | 14:33 |
*** thomasbiege has joined #openstack-qa | 14:33 | |
*** thomasbiege has quit IRC | 14:34 | |
*** thomasbiege has joined #openstack-qa | 14:36 | |
giulivo | mtreinish, and the checking file sugges "T101: skips must contain "Bug #<bug_number>" | 14:37 |
*** thomasbiege has quit IRC | 14:40 | |
mkoderer | dkranz: yes your right - I just want to introduce a mechanism to put attributes in to it | 14:41 |
dkranz | mkoderer: Is the purpose to say that a particular test can be run in "stress mode"? | 14:42 |
mkoderer | dkranz: exactly | 14:42 |
mkoderer | dkranz: so you put those attribute on test that you want to use for stress testing | 14:42 |
dkranz | mkoderer: Then I suggest just using a simple decorator. | 14:42 |
dkranz | mkoderer: I don't think it makes sense to be specifying things like number of threads in this static way. | 14:43 |
mkoderer | dkranz: ok but it maybe important to specify whether this test supports a global class setup or a per process setup | 14:43 |
dkranz | mkoderer: Yes, that is true. | 14:43 |
mkoderer | dkranz: so I would keep this setting - all other I agree, it may be better to put it in configuration | 14:44 |
dkranz | mkoderer: I just mean that there should only be params that describe how to use it as a stress test. | 14:44 |
dkranz | mkoderer: The others would be ok if there were meaningful defaults but I don't think there are. | 14:44 |
mkoderer | dkranz: ok agree | 14:45 |
mkoderer | dkranz: the other open issue is that the scenario test aren't listet | 14:45 |
mkoderer | since they aren't usual unit tests | 14:45 |
dkranz | mkoderer: Great. This will solve my objection that a stress configurer might screw up the setup or usage. | 14:45 |
dkranz | mkoderer: I think this is much less useful for scenario tests. | 14:46 |
mkoderer | dkranz: ok cool - happy that you like the idea :) | 14:46 |
dkranz | mkoderer: Don't see much value add over picking some and running them in parallel with regular tempest runs. | 14:46 |
openstackgerrit | Yassine Lamgarchal proposed a change to openstack/tempest: Add client and tests for Ceilometer compute metering. https://review.openstack.org/43481 | 14:47 |
mkoderer | dkranz: that right - but we could filter them with additional attrs | 14:47 |
mtreinish | giulivo: oh I remember the details now we enforce without the ':' via hacking rule but we had to leave the colon for existing bugs (there were more of them then) | 14:47 |
giulivo | let me play a bit with this | 14:48 |
giulivo | I want to fix the skip messages | 14:48 |
giulivo | so your change can be merged as is | 14:48 |
mkoderer | dkranz: so if we would use a attribute for scenario test we could only start all scenario test in paralell | 14:48 |
mkoderer | dkranz: but I need to think about it | 14:49 |
dkranz | mkoderer: OK, sounds good. | 14:49 |
*** russellb is now known as rustlebee | 14:50 | |
mkoderer | dkranz: thanks for the feedback - I will work on it :) | 14:50 |
dkranz | mkoderer: np | 14:50 |
*** anteaya is now known as anTeaya | 14:51 | |
*** bnemec is now known as RyanStiles | 14:54 | |
*** anTeaya is now known as ColinMochrie | 14:56 | |
*** SergeyLukjanov has quit IRC | 15:01 | |
*** SergeyLukjanov has joined #openstack-qa | 15:02 | |
openstackgerrit | Mate Lakat proposed a change to openstack/tempest: close http connections https://review.openstack.org/43390 | 15:06 |
*** malini is now known as malini_afk | 15:07 | |
openstackgerrit | Giulio Fidente proposed a change to openstack/tempest: uniforms skip messages https://review.openstack.org/43490 | 15:19 |
dkranz | mtreinish: ping | 15:19 |
dkranz | giulivo: ping | 15:20 |
giulivo | pong dkranz | 15:20 |
dkranz | giulivo: I'm having trouble verifying the slow heat tests that boils down to this not returning anything: testr list-tests '(^tempest\.scenario)' | 15:21 |
dkranz | giulivo: Does that work for you? | 15:21 |
mtreinish | dkranz: pong | 15:21 |
dkranz | mtreinish: ^^^^ | 15:21 |
dkranz | If I use any other subdir it works fine. | 15:22 |
dkranz | And this seems to work when running in the gate. | 15:22 |
giulivo | dkranz, haven't checked that, sorry | 15:22 |
mtreinish | dkranz: http://paste.openstack.org/show/45036/ it seems to work fine for me | 15:22 |
dkranz | mtreinish, giulivo : Hmm. Must be something wrong with my environment. Very strange. | 15:23 |
*** SergeyLukjanov has quit IRC | 15:29 | |
*** SergeyLukjanov has joined #openstack-qa | 15:44 | |
openstackgerrit | A change was merged to openstack-dev/devstack: turn out usb_tablet for libvirt https://review.openstack.org/42562 | 15:46 |
*** Anju has quit IRC | 15:48 | |
openstackgerrit | David Kranz proposed a change to openstack/tempest: Provide tox entry for running slow heat tests https://review.openstack.org/43497 | 15:48 |
*** ColinMochrie has quit IRC | 15:49 | |
*** giulivo has quit IRC | 16:01 | |
openstackgerrit | David Kranz proposed a change to openstack-infra/devstack-gate: Conditionally run the slow heat tests https://review.openstack.org/43500 | 16:08 |
*** Anju has joined #openstack-qa | 16:18 | |
*** anteaya has joined #openstack-qa | 16:29 | |
*** anteaya is now known as ColinMochrie | 16:33 | |
*** weshay is now known as weshay_brb | 16:35 | |
*** SergeyLukjanov has quit IRC | 16:41 | |
*** fbo is now known as fbo_away | 16:47 | |
*** weshay_brb has quit IRC | 16:56 | |
*** weshay_brb has joined #openstack-qa | 16:57 | |
*** hemnafk is now known as hemna | 17:13 | |
*** weshay_brb is now known as weshay | 17:14 | |
dkranz | mtreinish: Chris approved this last night but it had to be rebased. Could you give a quick look? https://review.openstack.org/#/c/43497/ | 17:35 |
mtreinish | dkranz: didn't you just push that a little over an hour ago? | 17:36 |
dkranz | mtreinish: Yes, because I screwed up the rebase and could not figure out how to amend the original change. | 17:39 |
dkranz | mtreinish: This was the original https://review.openstack.org/#/c/40897/ | 17:40 |
mtreinish | dkranz: ahh, ok I was a little confused | 17:40 |
dkranz | mtreinish: Sorry about that. | 17:40 |
mtreinish | my only question is why are you adding it as a serial job | 17:40 |
mtreinish | (I've got to keep pushing the parallel angle :) ) | 17:40 |
dkranz | mtreinish: As the checkin message says, I want to see it work in serial first. | 17:41 |
mtreinish | dkranz: that the tox job or the actual tests? | 17:41 |
dkranz | mtreinish: NOt sure what you mean... | 17:42 |
dkranz | mtreinish: The test that will be running has not run before because it was marked slow. | 17:43 |
mtreinish | dkranz: are you trying to prove that the tox job works or that the tests tagged as slow work first? | 17:44 |
dkranz | mtreinish: The latter. | 17:44 |
mtreinish | dkranz: ok, but before we make the job voting we need to move it over to parallel. | 17:45 |
mtreinish | although if I were doing it I'd probably just dive in head first and start with debugging everything in parallel | 17:45 |
dkranz | mtreinish: OK. Of course it was going to start as non-voting anyway. | 17:46 |
mtreinish | dkranz: approved | 17:46 |
dkranz | mtreinish: Thanks. | 17:46 |
dkranz | mtreinish: If this were an environment where I had a lot of debugging experience I would too. But it's not... | 17:47 |
openstackgerrit | David Kranz proposed a change to openstack-infra/devstack-gate: Conditionally run the slow heat tests https://review.openstack.org/43500 | 17:54 |
openstackgerrit | David Kranz proposed a change to openstack-infra/devstack-gate: Conditionally run the slow heat tests https://review.openstack.org/43500 | 18:00 |
*** SergeyLukjanov has joined #openstack-qa | 18:07 | |
*** Anju has quit IRC | 18:12 | |
*** malini_afk is now known as malini1 | 18:44 | |
dkranz | mtreinish: You made an approving comment in https://review.openstack.org/#/c/43424/1 but did not approve. Is there a reason? I would like to approve it. | 18:48 |
mtreinish | dkranz: so I had to step out for a bit | 19:10 |
mtreinish | I actually didn't fully understand the bug I don't think we should skip yet | 19:10 |
dkranz | mtreinish: I approved it to open the stable/grizzly gate. | 19:10 |
dkranz | mtreinish: I ran into this yesterday and there has been a flurry about it on the stable maint list. | 19:11 |
mtreinish | dkranz: I just think it's too soon to skip it | 19:12 |
mtreinish | ttx implied there is another workaround | 19:12 |
dkranz | mtreinish: stable/grizzly has been dead for 6 days | 19:12 |
dkranz | mtreinish: And it is just two cli tests. | 19:13 |
mtreinish | dkranz: I just think there needs to be a wider discussion and a more technical reason for why it needs to be skipped first. Just because no progress has been made on it in 6 days isn't enough IMO. | 19:14 |
dkranz | mtreinish: Well, it was no progress plus a lot of noise about it. | 19:18 |
dkranz | mtreinish: And it's Friday afternoon. I don't really disagree with you. | 19:18 |
mtreinish | dkranz: ok, I was also partially deffering to ttx. He seems to have a better grasp on what's going on with the bug too. | 19:19 |
*** psedlak has quit IRC | 19:20 | |
dkranz | mtreinish: I don't think it is a huge deal. It is horrible to disable tests. And it is also horrible to have a stable branch totally broken for a week. | 19:21 |
*** psedlak has joined #openstack-qa | 19:22 | |
*** __afazekas is now known as afazekas | 19:28 | |
dkranz | mtreinish: BTW, if you look at your comment in the patch you are basically giving your approval. THat's why I didn't wait when you did not respond on irc. | 19:29 |
afazekas | It is keystoneclient related test, and the python-keystoneclient does not have a stable branch. We have the correct coverage with the master branch | 19:30 |
dkranz | afazekas: If there a plan to fix that? | 19:30 |
dkranz | afazekas: Really that means that every project with a client needs a stable branch. | 19:31 |
afazekas | dkranz: I am not aware of any other fix, but multiple other workaround is possible | 19:31 |
dkranz | afazekas: This is a prelude to implementating the stable client blueprint | 19:31 |
dkranz | afazekas: Where we run the scenario and cli tests on stable branches against master clients. | 19:31 |
mtreinish | dkranz: yeah sorry about that. I assumed that there was already a disscusion about the bug and it wasn't going to get fixed anytime soon. (I should have looked into it more) | 19:34 |
mtreinish | and I was curious about doing it on master because of that | 19:34 |
mtreinish | but I didn't have all the info that's why I didn't approve it | 19:34 |
dkranz | mtreinish: I think the "damage" of skipping this is overblown a bit. We disable tests all the time unfortunately. | 19:35 |
dkranz | mtreinish: The fact that a solution appeared at exactly the time we gave up and skipped, even though it's been dead for a week,, is most unlikely, if true. | 19:36 |
mtreinish | dkranz: I hadn't really been following the discussion until I saw the review. Well, most of the skips that have gone in lately have been skip if neutron :) | 19:38 |
dkranz | mtreinish: I guess we should give some attention to https://blueprints.launchpad.net/tempest/+spec/client-lib-stability | 19:39 |
dkranz | mtreinish: And in IMO it is a bigger problem that this slipped through the gate than that we skipped a test to fix it. | 19:40 |
mtreinish | dkranz: agreed | 19:41 |
openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Switch gating tox jobs to testr parallel https://review.openstack.org/41797 | 19:42 |
openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Switch gating tox jobs to testr parallel https://review.openstack.org/41797 | 19:42 |
mtreinish | psedlak: hey so I've seen a similar fail quite a bit lately on master. See: | 19:51 |
mtreinish | http://logs.openstack.org/42/39842/3/check/gate-tempest-devstack-vm-testr-full/0154219/ | 19:51 |
*** malini1 is now known as malini_afk | 19:54 | |
psedlak | hi, finished catching up backlog | 19:55 |
openstackgerrit | Yassine Lamgarchal proposed a change to openstack/tempest: Add client and tests for Ceilometer compute metering https://review.openstack.org/43481 | 20:00 |
*** comstud is now known as bearhands | 20:08 | |
*** RyanStiles is now known as bnemec | 20:13 | |
*** woodspa has quit IRC | 20:15 | |
toanster | does anyone know if an approved tempest patch would get automatically merged? been tracking this https://review.openstack.org/#/c/40384/ for more than a week and notice there hasnt been any love :( | 20:52 |
*** SergeyLukjanov has quit IRC | 20:54 | |
mtreinish | toanster: it was merged https://github.com/openstack/tempest/commit/c04a0fc59d69068135dad7ffb1dbbcbdfd7b7bc9 | 20:56 |
*** psedlak is now known as __psedlak | 20:57 | |
*** __psedlak is now known as psedlakZzz | 20:58 | |
*** jhenner has quit IRC | 21:00 | |
openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Update requirements from global requirements https://review.openstack.org/43168 | 21:00 |
toanster | mtreinish: thanks! | 21:04 |
*** mriedem has quit IRC | 21:05 | |
*** jasondotstar has quit IRC | 21:13 | |
openstackgerrit | A change was merged to openstack/tempest: Provide tox entry for running slow heat tests https://review.openstack.org/43497 | 21:40 |
openstackgerrit | A change was merged to openstack/tempest: Fix skip tracker regex for multi-line skips https://review.openstack.org/42424 | 21:48 |
openstackgerrit | A change was merged to openstack/tempest: Fixed up a missing space in an error message https://review.openstack.org/43451 | 21:50 |
openstackgerrit | A change was merged to openstack/tempest: Add more tests for Swift Account Quota https://review.openstack.org/41099 | 21:58 |
*** burt has quit IRC | 22:04 | |
openstackgerrit | Dean Troyer proposed a change to openstack-dev/devstack: Add support for Docker as Nova hypervisor https://review.openstack.org/40759 | 22:36 |
openstackgerrit | A change was merged to openstack/tempest: use assertIsNotNone instead of assertNotEqual(*, None) https://review.openstack.org/43081 | 23:00 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!