| -openstackstatus- NOTICE: Due to a failure on the logs.openstack.org volume, old logs are unavailable while partition is recovered. New logs are being stored. ETA for restoration probably ~Mon Jul 22 12:00 UTC 2019 | 06:05 | |
| *** ChanServ changes topic to "Due to a failure on the logs.openstack.org volume, old logs are unavailable while partition is recovered. New logs are being stored. ETA for restoration probably ~Mon Jul 22 12:00 UTC 2019" | 06:05 | |
| *** ricolin__ is now known as ricolin | 06:20 | |
| *** ChanServ changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 06:25 | |
| -openstackstatus- NOTICE: logs.openstack.org volume has been restored. please report any issues in #openstack-infra | 06:25 | |
| *** irclogbot_1 has quit IRC | 12:39 | |
| *** irclogbot_3 has joined #openstack-powervm | 12:43 | |
| openstackgerrit | VedaAnnayappa proposed openstack/nova-powervm master: Merge: https://review.opendev.org/671928 | 13:45 |
|---|---|---|
| *** VedaAnnayappa has joined #openstack-powervm | 16:13 | |
| *** VedaAnnayappa has quit IRC | 16:25 | |
| *** ricolin has quit IRC | 16:57 | |
| *** VedaAnnayappa has joined #openstack-powervm | 17:15 | |
| efried | o/ VedaAnnayappa | 17:15 |
| VedaAnnayappa | @efried Hi | 17:16 |
| efried | So first thing, have you read https://wiki.openstack.org/wiki/GitCommitMessages ? | 17:16 |
| efried | This gives an overview of how to split up changes (not just how to format commit messages) | 17:16 |
| VedaAnnayappa | So I need to update the lower-constraints changes to get the test working for py27,py36 and lower-constrains | 17:19 |
| prometheanfire | ohai | 17:20 |
| efried | Yes. Clearly that needs to be done first, because you won't be able to merge anything else until then. | 17:20 |
| VedaAnnayappa | and push those changes. means deliver those changes before any other code changes.. | 17:22 |
| prometheanfire | you should be able to run tox locally for the lower-constraints tests to do some quick itteration rather than waiting on gate | 17:22 |
| efried | The important points for right now are: | 17:22 |
| efried | - Each change set should do just one thing. Right now https://review.opendev.org/671928 is doing two things: updating constraints; and bringing in image type capabilities. So it needs to be split into two commits. It's possible to put them in series so the image-type commit builds on top of the constraints commit. Or you could just wait for the constraints patch to merge and then propose the other change afterward. | 17:22 |
| efried | - Commit title needs to be <=50c and be descriptive of the change. Right now ^ just says "Merge:" | 17:22 |
| efried | - Commit message should describe what's going on and why, wrapped at 72c. | 17:22 |
| VedaAnnayappa | I had observed that local tox on lower-constraints passes even when the zuul complaints. | 17:23 |
| efried | you would have to run | 17:24 |
| efried | tox -e lower-constraints | 17:24 |
| efried | explicitly. But even then, I've noticed sometimes the gate does things differently, which can be frustrating. | 17:24 |
| efried | In any case, what you've got now is clearly passing, so I wouldn't mess with it any further. | 17:24 |
| prometheanfire | once the constraints are fixed, doing things in parallel should be doable | 17:26 |
| VedaAnnayappa | ok.. so u prefer me to create a new change set? | 17:28 |
| prometheanfire | a single changeset for the requirements/constraints changes | 17:30 |
| openstackgerrit | VedaAnnayappa proposed openstack/nova-powervm master: Updated Libraries https://review.opendev.org/672121 | 17:42 |
| VedaAnnayappa | I am getting an error remote: Processing changes: refs: 1, done | 18:09 |
| VedaAnnayappa | To ssh://VedaAnnayappa@review.opendev.org:29418/openstack/nova-powervm.git | 18:09 |
| VedaAnnayappa | ! [remote rejected] HEAD -> refs/publish/master (you are not allowed to upload merges) | 18:09 |
| VedaAnnayappa | error: failed to push some refs to 'ssh://VedaAnnayappa@review.opendev.org:29418/openstack/nova-powervm.git' | 18:09 |
| openstackgerrit | VedaAnnayappa proposed openstack/nova-powervm master: Updated Libraries: https://review.opendev.org/672125 | 18:16 |
| prometheanfire | VedaAnnayappa: mind making a review for https://github.com/powervm/pypowervm/issues/12 as well? | 18:18 |
| VedaAnnayappa | let me try | 18:21 |
| prometheanfire | thanks, that'll allow openstack to consume updates from pypowervm again | 18:24 |
| VedaAnnayappa | @prometheanfire I am new to opensource, can you guide me on the issue 12 | 18:29 |
| prometheanfire | VedaAnnayappa: I'm not sure how you manage that repo internally, but for github, you create a branch, make your commit then the github ui will show a popup to create a pull request | 18:30 |
| efried | VedaAnnayappa: Do you have access to the internal gerrit for pypowervm? When I was there, it was called morpheus | 18:31 |
| VedaAnnayappa | That I would manage to do, wanted to understand the problem.. yes | 18:31 |
| efried | cool. prometheanfire: morpheus is an internal gerrit, so no pull requests necessary. Assuming it's still wired up, merging in that gerrit will automatically publish to external github repo. | 18:32 |
| efried | whereupon I think someone needs to tag a release - again from inside. I don't actually know how that's done :( | 18:33 |
| VedaAnnayappa | fine.. I will check on those.. Wanted to understand the issue and how can i reproduce it | 18:33 |
| VedaAnnayappa | i have cloned the morpheus pypowervm | 18:34 |
| prometheanfire | VedaAnnayappa: the logs are gone, but it's a requirements job that fails if using a new version of pypowervm | 18:35 |
| prometheanfire | openstack uses a newer verion of taskflow | 18:35 |
| prometheanfire | pypowervm disallows the use of those newer versions of taskflow | 18:36 |
| prometheanfire | https://github.com/openstack/requirements/commit/375a5fded52d7456240be0357de2fd1c09aaef29 | 18:36 |
| prometheanfire | https://github.com/openstack/requirements/commit/790f2bf704a936c29241a605639343fc91cd0099 too | 18:36 |
| efried | VedaAnnayappa: I think what you need to do is update the taskflow constraints in pypowervm to match what nova-powervm likes -- namely >=2.16.0 per https://review.opendev.org/#/c/671928/3/requirements.txt@16 -- and then make sure PowerVM CI succeeds (in tree and out of tree). | 18:37 |
| efried | Of course, that means you'll need to get PowerVM CI working in the first place... | 18:37 |
| prometheanfire | ^ that :D | 18:37 |
| VedaAnnayappa | currently i could see in requirements.txt:taskflow>=2.16.0,<3.2.0 # Apache-2.0 | 18:38 |
| efried | Mm. Any idea why the <3.2.0 would be there? prometheanfire was that cap in place in g-r at any point in the past? | 18:38 |
| prometheanfire | I don't think so | 18:39 |
| efried | looks like the queens u-c was 3.1.0 | 18:39 |
| efried | and at rocky g-r stopped having version numbers in it, but u-c was 3.2.0 | 18:40 |
| prometheanfire | going back in history | 18:40 |
| VedaAnnayappa | so.. taskflow is >=2.16.0, do you still see there is need to change it | 18:40 |
| prometheanfire | two years, no cap | 18:40 |
| efried | it's possible the pypowervm cap was put in place simply to match up with the up | 18:40 |
| efried | u-c | 18:41 |
| prometheanfire | no commit capping it at all | 18:41 |
| efried | anyway, it seems like the thing to do is make sure you can pass PowerVM CI with taskflow at the current u-c of 3.7.0 | 18:41 |
| prometheanfire | ya, that's possible | 18:41 |
| efried | VedaAnnayappa and also sanity check PowerVC internally, probably | 18:42 |
| efried | actually, that may be the easier thing ^ | 18:42 |
| efried | Get someone to run FV regression on PowerVC with taskflow at 3.7.0 | 18:42 |
| VedaAnnayappa | so shall i change taskflow to 3.7.0 and do necessary test? | 18:42 |
| VedaAnnayappa | ok | 18:43 |
| efried | Yeah, I'm suggesting doing that --^ internally with PowerVC. If that passes FVT (which is much more rigorous than the CI anyway) then it's most likely fine. | 18:43 |
| efried | that way you're not blocked on getting the upstream CI working. | 18:43 |
| efried | Okay, I'm out this afternoon. Sounds like you've got enough to keep you busy for a little while :) | 18:44 |
| efried | good luck! | 18:44 |
| efried | o/ | 18:44 |
| prometheanfire | thanks | 18:44 |
| VedaAnnayappa | sure.. this would sometime for me to setup for the test.. will verify and update in channel | 18:44 |
| VedaAnnayappa | https://review.opendev.org/#/c/672125/ -- zuul passed | 18:45 |
| efried | okay, I'll fast approve it so y'all can get moving... | 18:45 |
| efried | done | 18:45 |
| VedaAnnayappa | so next changes will be after pushing it .. hope i am on right track | 18:46 |
| *** efried is now known as efried_pto | 18:47 | |
| openstackgerrit | Merged openstack/nova-powervm master: Updated Libraries: https://review.opendev.org/672125 | 18:57 |
| *** VedaAnnayappa has quit IRC | 18:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!