| openstackgerrit | Eric Fried proposed openstack/networking-powervm master: Uncap eventlet and sync requirements https://review.openstack.org/560519 | 01:08 |
|---|---|---|
| *** edmondsw has joined #openstack-powervm | 02:19 | |
| *** edmondsw has quit IRC | 02:24 | |
| *** edmondsw has joined #openstack-powervm | 04:07 | |
| *** edmondsw has quit IRC | 04:12 | |
| *** chhagarw has joined #openstack-powervm | 05:07 | |
| *** chhavi__ has joined #openstack-powervm | 05:07 | |
| *** openstackgerrit has quit IRC | 05:48 | |
| *** edmondsw has joined #openstack-powervm | 05:56 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 05:58 | |
| *** edmondsw has quit IRC | 06:00 | |
| *** AlexeyAbashkin has quit IRC | 06:24 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:35 | |
| *** AlexeyAbashkin has quit IRC | 06:44 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:01 | |
| *** edmondsw has joined #openstack-powervm | 07:44 | |
| *** edmondsw has quit IRC | 07:48 | |
| *** adreznec has quit IRC | 08:05 | |
| *** adreznec has joined #openstack-powervm | 08:06 | |
| *** chas_ has joined #openstack-powervm | 08:28 | |
| *** chas_ has quit IRC | 08:28 | |
| *** AlexeyAbashkin has quit IRC | 08:29 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:30 | |
| *** AlexeyAbashkin has quit IRC | 10:10 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 10:53 | |
| *** edmondsw has joined #openstack-powervm | 11:20 | |
| *** edmondsw has quit IRC | 11:24 | |
| *** AlexeyAbashkin has quit IRC | 12:28 | |
| *** apearson has joined #openstack-powervm | 12:29 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 12:29 | |
| *** edmondsw has joined #openstack-powervm | 13:01 | |
| *** edmondsw has quit IRC | 13:20 | |
| *** edmondsw has joined #openstack-powervm | 13:21 | |
| *** edmondsw has quit IRC | 13:21 | |
| *** esberglu has joined #openstack-powervm | 13:38 | |
| *** chhavi__ has quit IRC | 13:55 | |
| *** chhagarw has quit IRC | 13:55 | |
| *** chhagarw has joined #openstack-powervm | 13:55 | |
| chhagarw | efried: Please review https://review.openstack.org/#/c/557800/ | 13:56 |
| efried | chhagarw: on it. | 13:56 |
| chhagarw | thanks | 13:59 |
| *** AlexeyAbashkin has quit IRC | 14:45 | |
| *** tjakobs has joined #openstack-powervm | 14:53 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 15:07 | |
| *** AlexeyAbashkin has quit IRC | 15:12 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 15:32 | |
| *** apearson has quit IRC | 15:48 | |
| *** edmondsw has joined #openstack-powervm | 15:50 | |
| *** edmondsw has quit IRC | 15:53 | |
| *** edmondsw has joined #openstack-powervm | 15:58 | |
| *** efried has quit IRC | 16:03 | |
| *** efried has joined #openstack-powervm | 16:04 | |
| *** apearson has joined #openstack-powervm | 16:32 | |
| efried | chhagarw, edmondsw: Reviewed | 16:50 |
| efried | ...and sorry | 16:50 |
| chhagarw | efried: thanks for the comments, would like to explain the reason behind passing vios_ids in _get_iscsi_initiators | 17:42 |
| efried | hit me | 17:42 |
| chhagarw | The purpose of this method is to be generic which can return the initiators for the required vioses, _get_iscsi_initiator, | 17:43 |
| chhagarw | at the same time, since its static, i would like to make it more open so it can be consumed. | 17:43 |
| chhagarw | If we cll _get_active_vioses within the method, it will be completely closed by the vioses returned by pypowervm | 17:45 |
| *** apearson has quit IRC | 17:48 | |
| efried | chhagarw: Yeah, so we have to resist the temptation to code for future possibilities that are as yet unknown. | 17:49 |
| efried | Right now there's no reason not to consolidate it. If we decide to do something later on where we need to "reuse", we can split it out then. | 17:50 |
| efried | No harm no foul. | 17:50 |
| *** apearson has joined #openstack-powervm | 18:13 | |
| esberglu | efried: Cleaned up the localdisk nits. Thanks for the review | 18:38 |
| efried | esberglu: ack | 18:42 |
| *** AlexeyAbashkin has quit IRC | 19:06 | |
| esberglu | efried: 1 thing on localdisk. IT we have the default disk driver as ssp. OOT the default is localdisk. How do we want to handle that? | 19:32 |
| *** openstackgerrit has joined #openstack-powervm | 19:40 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Refactor connection data for iSCSI properties https://review.openstack.org/561022 | 19:40 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Refactor connection data for iSCSI properties https://review.openstack.org/561022 | 19:41 |
| efried | esberglu: Good point. Is there a reason we shouldn't switch the in-tree default to localdisk when we introduce the localdisk patch? | 19:50 |
| esberglu | efried: I think it's fine, would just need to add an upgrade release note right? | 19:51 |
| chhagarw | efried: https://review.openstack.org/#/c/561022/ | 19:51 |
| efried | esberglu: I think so | 19:52 |
| efried | However we did it for proc_units_factor | 19:52 |
| esberglu | efried: Yeah that seems to be the best path forward | 19:52 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Return iSCSI Initiatos for all VIOSes https://review.openstack.org/557800 | 20:01 |
| efried | chhagarw: Oh, looks like you were able to do those patches completely independent of one another. Nice. | 20:06 |
| efried | chhagarw: What about making get_iscsi_initiators a module-level method rather than a staticmethod in IscsiVolumeAdapter? | 20:07 |
| chhagarw | For volume refactoring, Matt is looking for an option to have it static so he can get the initiator without creating an instance of IscsVolumeAdapter | 20:09 |
| chhagarw | I will be out prashant will update if there are any further review comments. We need to get this merged soon. | 20:10 |
| efried | chhagarw: Having it as a module level method *also* allows you to invoke it without creating an instance of the class. It's effectively the same thing; it's just more pythonic and less java-y. | 20:15 |
| chhagarw | can we have that later in a separate change set | 20:16 |
| chhagarw | I will have it in my ToDo list | 20:16 |
| *** tjakobs has quit IRC | 20:16 | |
| efried | yeah, sure, though if pvc is planning to call it, they'll have to change too. | 20:17 |
| chhagarw | sure, we will handle in pvc once that is in | 20:17 |
| *** tjakobs has joined #openstack-powervm | 20:18 | |
| *** chhagarw has quit IRC | 20:22 | |
| esberglu | efried: Does that multiattach non-voting comment turn off voting somehow, or are you just saying they turned off voting for the job | 20:42 |
| efried | esberglu: It (never) affects how tests are run; it's just a note to self and others that I'm not blindly rechecking. | 20:43 |
| efried | In this case the previous failure was due to a bug in that multiattach job. There was a separate patch merged a couple hours ago that disabled that job while we figure out the root cause. So rechecks should be clear of that bug now. | 20:43 |
| efried | So that's all I was noting by saying that. | 20:44 |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Remove powervm localdisk conf options https://review.openstack.org/561045 | 20:50 |
| *** apearson has quit IRC | 21:26 | |
| *** openstackstatus has quit IRC | 21:27 | |
| *** openstack has joined #openstack-powervm | 21:29 | |
| *** ChanServ sets mode: +o openstack | 21:29 | |
| *** esberglu has quit IRC | 21:58 | |
| *** tjakobs has quit IRC | 22:41 | |
| *** dxrt231 has joined #openstack-powervm | 23:39 | |
| -openstackstatus- NOTICE: The Etherpad service at https://etherpad.openstack.org/ is being restarted to pick up the latest release version; browsers should see only a brief ~1min blip before reconnecting automatically to active pads | 23:40 | |
| *** dxrt231 has quit IRC | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!