| *** svenkat has joined #openstack-powervm | 00:08 | |
| *** svenkat has quit IRC | 00:50 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 05:06 | |
| *** AlexeyAbashkin has quit IRC | 05:10 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 05:31 | |
| *** AlexeyAbashkin has quit IRC | 05:46 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:17 | |
| *** AlexeyAbashkin has quit IRC | 07:55 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:35 | |
| *** AlexeyAbashkin has quit IRC | 08:40 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 09:22 | |
| *** AlexeyAbashkin has quit IRC | 10:13 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 10:13 | |
| -openstackstatus- NOTICE: Zuul is currently under heavy load. Do not *recheck* or *approve* any changes. | 11:03 | |
| *** AlexeyAbashkin has quit IRC | 11:23 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:59 | |
| *** svenkat has joined #openstack-powervm | 12:58 | |
| *** svenkat has quit IRC | 13:03 | |
| *** svenkat has joined #openstack-powervm | 13:04 | |
| -openstackstatus- NOTICE: Zuul is currently under heavy load. Do not *recheck* or *approve* any changes until we give the go ahead. | 13:33 | |
| *** ChanServ changes topic to "Zuul is currently under heavy load. Do not *recheck* or *approve* any changes until we give the go ahead." | 13:33 | |
| *** edmondsw has joined #openstack-powervm | 13:41 | |
| *** apearson has joined #openstack-powervm | 13:58 | |
| *** edmondsw has quit IRC | 14:25 | |
| *** edmondsw has joined #openstack-powervm | 14:28 | |
| -openstackstatus- NOTICE: we've been able to restart zuul, and re-enqueue changes for gate. Please hold off on recheck or approves, we are still recovering. More info shortly. | 14:30 | |
| *** esberglu has joined #openstack-powervm | 14:51 | |
| *** tjakobs has joined #openstack-powervm | 14:56 | |
| *** tjakobs has quit IRC | 15:19 | |
| *** esberglu has quit IRC | 15:48 | |
| *** esberglu has joined #openstack-powervm | 15:49 | |
| *** tjakobs has joined #openstack-powervm | 15:58 | |
| esberglu | efried: edmondsw: I'm seeing a bunch of InstanceNotFound errors trying to unplug vifs in the OOT CI runs | 15:59 |
|---|---|---|
| edmondsw | just OOT? | 16:00 |
| esberglu | What appears to be happening is that the destroy flow goes through successfully and unplugs everything as normal | 16:00 |
| esberglu | edmondsw: Yep | 16:00 |
| esberglu | Then after that, I think that custom neutron event stuff is causing unplug_vifs to be called a second time | 16:00 |
| esberglu | Which is obviously failing because the instance was already destroyed | 16:01 |
| edmondsw | why would this only crop up now? | 16:01 |
| efried | Are we ignoring that 404 and moving on, or is it causing a failure in the destroy? | 16:01 |
| esberglu | efried: We're just logging the exception and moving on, it's not causing CI runs to fail or anything | 16:02 |
| esberglu | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L1055-L1058 | 16:02 |
| esberglu | We could possibly change that to LOG.warning? | 16:03 |
| esberglu | https://etherpad.openstack.org/p/powervm_tempest_failures | 16:03 |
| esberglu | I've got timestamped notes of the flow at the top of that page if curious | 16:03 |
| edmondsw | esberglu yeah, that should probably just be LOG.warn | 16:04 |
| edmondsw | sorry, I should spell that out to be clear... LOG.warning, not the old LOG.warn | 16:05 |
| esberglu | edmondsw: Okay I will change that. However do you think that there is a problem with our destroy flow? Do we really need to hit unplug_vifs a second time? | 16:06 |
| edmondsw | but it would be nice to avoid trying a 2nd unplug if we can figure out how | 16:06 |
| efried | Perhaps we should reexamine this flow and figure out why we're ... yeah, what he said. | 16:06 |
| efried | what both of you said. | 16:06 |
| edmondsw | great minds... | 16:06 |
| esberglu | I'll make the log change quick so the logs aren't so gross and continue looking into it | 16:07 |
| edmondsw | esberglu tx | 16:07 |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: LOG.warning on unplug_vifs InstanceNotFound https://review.openstack.org/538964 | 16:16 |
| efried | Not sure how changing to LOG.warning is going to help the logs significantly. We're always logging at DEBUG level, nah? | 16:17 |
| esberglu | efried: It will help if you are searching for a different exception if something else goes wrong | 16:18 |
| efried | okay. | 16:19 |
| *** ChanServ changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 16:22 | |
| -openstackstatus- NOTICE: zuul.o.o is back online, feel free to recheck / approve patches. | 16:22 | |
| *** AlexeyAbashkin has quit IRC | 17:34 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 17:37 | |
| *** AlexeyAbashkin has quit IRC | 17:41 | |
| *** efried is now known as efried_hexchat | 18:29 | |
| *** efried has joined #openstack-powervm | 18:30 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 19:11 | |
| *** edmondsw has quit IRC | 19:23 | |
| openstackgerrit | Merged openstack/nova-powervm master: LOG.warning on unplug_vifs InstanceNotFound https://review.openstack.org/538964 | 19:42 |
| *** AlexeyAbashkin has quit IRC | 20:25 | |
| *** edmondsw has joined #openstack-powervm | 20:30 | |
| *** edmondsw has quit IRC | 20:32 | |
| *** edmondsw_ has joined #openstack-powervm | 20:32 | |
| *** svenkat has quit IRC | 21:13 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Mock sleep in UT https://review.openstack.org/539023 | 21:47 |
| edmondsw_ | efried what do you think of ^ ? My first thought would be to "with mock.patch" just for the assertRaises part of the test, but maybe that's a nit... | 22:24 |
| efried | edmondsw_: For my money, I would rather mock sleep in setUp to make sure we don't *ever* waste test time. | 22:25 |
| edmondsw_ | efried yeah... except that we use it to make sure threads get a chance to run, and that won't happen if we mocked it, right? | 22:25 |
| edmondsw_ | most of our sleeps are sleep(0) | 22:26 |
| efried | oh? Are we using sleep(0)? | 22:26 |
| efried | I didn't look at the source. | 22:26 |
| edmondsw_ | not in this test, but in other places | 22:26 |
| *** edmondsw_ is now known as edmondsw | 22:26 | |
| efried | Anyway, I don't like it when a mock is created with an arg but never used. Should either add new=mock.Mock() to the decorator and remove the arg, or add an assertion that uses the arg. | 22:28 |
| efried | Otherwise, I'm fine with the methodology. | 22:28 |
| efried | But we don't have to have identical opinions on this. Swhy we want multiple reviewers on a thing. | 22:29 |
| edmondsw | so we can confuse esberglu on what to do, right? ;) | 22:30 |
| * edmondsw gives evil grin | 22:31 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Mock sleep in UT https://review.openstack.org/539023 | 22:49 |
| esberglu | edmondsw: efried: ^ Combined your ideas, let me know what you think | 22:50 |
| efried | wfm | 22:50 |
| edmondsw | same | 22:53 |
| *** edmondsw has quit IRC | 23:06 | |
| *** tjakobs has quit IRC | 23:09 | |
| *** edmondsw has joined #openstack-powervm | 23:20 | |
| *** apearson has quit IRC | 23:29 | |
| *** svenkat has joined #openstack-powervm | 23:37 | |
| *** edmondsw has quit IRC | 23:46 | |
| *** edmondsw has joined #openstack-powervm | 23:47 | |
| *** edmondsw has quit IRC | 23:51 | |
| *** svenkat has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!