| *** AlexeyAbashkin has joined #openstack-powervm | 00:01 | |
| *** AlexeyAbashkin has quit IRC | 00:05 | |
| *** gman-tx has joined #openstack-powervm | 02:03 | |
| *** gman-tx has quit IRC | 03:17 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 03:52 | |
| *** AlexeyAbashkin has quit IRC | 03:57 | |
| *** chhavi__ has joined #openstack-powervm | 04:25 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 04:25 | |
| *** AlexeyAbashkin has quit IRC | 04:29 | |
| *** edmondsw has joined #openstack-powervm | 06:00 | |
| *** edmondsw has quit IRC | 06:04 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:57 | |
| *** AlexeyAbashkin has quit IRC | 11:18 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:18 | |
| *** chhavi__ has quit IRC | 11:35 | |
| *** edmondsw has joined #openstack-powervm | 13:01 | |
| *** apearson__ has joined #openstack-powervm | 13:55 | |
| *** chhavi__ has joined #openstack-powervm | 14:34 | |
| *** gman-tx has joined #openstack-powervm | 14:56 | |
| -openstackstatus- NOTICE: Gerrit is being restarted due to slowness and to apply kernel patches | 14:58 | |
| *** openstackgerrit has quit IRC | 15:01 | |
| edmondsw | esberglu posted more comments on the vscsi patch | 15:55 |
|---|---|---|
| edmondsw | I've reviewed all the non-test code at this point | 15:56 |
| esberglu | edmondsw: Ok. I ended up reworking test_vscsi. I'm finishing up the last few tests, should be done before lunch. Will address your comments in the next patch | 15:59 |
| *** AlexeyAbashkin has quit IRC | 16:55 | |
| *** zerick has joined #openstack-powervm | 17:39 | |
| *** zerick has quit IRC | 17:41 | |
| *** zerick has joined #openstack-powervm | 17:42 | |
| *** zerick has quit IRC | 17:45 | |
| *** zerick has joined #openstack-powervm | 17:46 | |
| esberglu | efried: https://review.openstack.org/#/c/526094/17/nova/virt/powervm/volume/vscsi.py@154 | 18:05 |
| esberglu | You know the answer to that? | 18:05 |
| *** openstack has joined #openstack-powervm | 18:31 | |
| *** ChanServ sets mode: +o openstack | 18:31 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:31 | |
| *** AlexeyAbashkin has quit IRC | 18:35 | |
| esberglu | edmondsw: https://review.openstack.org/#/c/526094/17/nova/virt/powervm/driver.py@436 | 18:51 |
| esberglu | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L776-L780 | 18:51 |
| esberglu | Based on that it looks like that only applies to the live migration case. Just rip it out? | 18:51 |
| esberglu | edmondsw: test_vscsi is ready for review | 19:18 |
| edmondsw | esberglu as long as we remember to put it back when we do port in live migration... | 19:26 |
| edmondsw | and yeah, the OOT comment should help with that | 19:28 |
| *** zerick has quit IRC | 19:51 | |
| *** zerick_ has joined #openstack-powervm | 19:51 | |
| efried | esberglu Responded, sorry for the delay. | 20:49 |
| *** gman-tx has quit IRC | 20:56 | |
| *** gman-tx has joined #openstack-powervm | 20:57 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 21:00 | |
| *** AlexeyAbashkin has quit IRC | 21:04 | |
| *** kylek3h has joined #openstack-powervm | 21:16 | |
| *** kylek3h has quit IRC | 21:38 | |
| *** chhavi__ has quit IRC | 21:41 | |
| edmondsw | esberglu finished reviewing the vscsi tests | 22:02 |
| edmondsw | comments were against an older PS (19) | 22:02 |
| edmondsw | esberglu you around? | 22:20 |
| esberglu | edmondsw: Yeah | 22:20 |
| edmondsw | good catch on adding the support-matrix... I meant to comment on that and then forgot | 22:21 |
| edmondsw | but couple questions in the networking one | 22:21 |
| edmondsw | you said complete for security groups... did we do something for that? | 22:21 |
| edmondsw | and if complete is correct for that, then we probably need to say the same for networking.firewallrules | 22:22 |
| edmondsw | which appears to be a duplicate | 22:22 |
| -openstackstatus- NOTICE: The zuul system is being restarted to apply security updates and will be offline for several minutes. It will be restarted and changes re-equeued; changes approved during the downtime will need to be rechecked or re-approved. | 22:23 | |
| edmondsw | esberglu ^ | 22:25 |
| edmondsw | esberglu other question would be does the networking support we've added work with nova-network as well as neutron, or just the latter? | 22:26 |
| edmondsw | because I'm not sure if the networking stuff in the support matrix is supposed to just be re: nova-network | 22:27 |
| edmondsw | at least networking.topology.vlan sounds that way | 22:27 |
| edmondsw | then again, probably better to say we have networking support there and be told to remove it than to not say it and someone things we don't have networking implemented | 22:28 |
| esberglu | edmondsw: security groups are supported using ovs | 22:38 |
| esberglu | I can mark the same for firewallrules | 22:38 |
| edmondsw | sounds good | 22:38 |
| edmondsw | it should be supported, but I didn't recall seeing anything related to that in the patch | 22:39 |
| esberglu | edmondsw: Nothing needed in our code afaik. Devstack creates a default group and I confirmed you can create your own | 22:40 |
| edmondsw | cool | 22:40 |
| edmondsw | what about the nova-network question... does our driver care whether you're using nova-network vs. neutron? | 22:40 |
| esberglu | I thought it had to be neutron? I haven't tried it with nova-network though | 22:41 |
| esberglu | Isn't nova-network deprecated? | 22:42 |
| edmondsw | yes | 22:42 |
| edmondsw | I suspect networking.topology.vlan is just wrong to specifically call out nova-network in its description | 22:42 |
| edmondsw | maybe throw up a separate patch to remove " when using nova-network" there? | 22:43 |
| esberglu | edmondsw: Sure | 22:44 |
| edmondsw | when you've fixed the firewallrules one ping me and efried to re +1 | 22:45 |
| edmondsw | and let's not make any more changes after that without talking first :) | 22:46 |
| esberglu | edmondsw: efried: Done | 22:47 |
| efried | I haven't been following. What action is required on my part? | 22:48 |
| efried | (my upstream to-do list blew up today) | 22:48 |
| edmondsw | esberglu added support matrix changes to the OVS patch, so we need to rereview and +1 that and SEA (rebased) | 22:49 |
| edmondsw | esberglu you rebased SEA, right? | 22:49 |
| esberglu | edmondsw: Yep, that doesn't lose +1 though | 22:49 |
| edmondsw | oh, nice | 22:49 |
| efried | done | 22:51 |
| *** edmondsw has quit IRC | 22:59 | |
| *** apearson__ has quit IRC | 23:15 | |
| *** gman-tx has quit IRC | 23:18 | |
| *** efried has quit IRC | 23:44 | |
| *** edmondsw has joined #openstack-powervm | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!