| *** kylek3h has joined #openstack-powervm | 00:00 | |
| *** esberglu has joined #openstack-powervm | 00:12 | |
| *** esberglu has quit IRC | 02:20 | |
| *** esberglu has joined #openstack-powervm | 03:08 | |
| *** esberglu has quit IRC | 03:12 | |
| *** edmondsw has quit IRC | 03:22 | |
| *** jwcroppe has joined #openstack-powervm | 03:46 | |
| *** esberglu has joined #openstack-powervm | 05:53 | |
| *** esberglu has quit IRC | 05:57 | |
| *** chhavi has joined #openstack-powervm | 06:06 | |
| *** k0da has joined #openstack-powervm | 07:29 | |
| *** esberglu has joined #openstack-powervm | 07:41 | |
| *** esberglu has quit IRC | 07:45 | |
| openstackgerrit | Bing Li proposed openstack/nova-powervm master: Remove log translations https://review.openstack.org/476411 | 08:38 |
|---|---|---|
| openstackgerrit | Bing Li proposed openstack/nova-powervm master: Remove log translations https://review.openstack.org/476411 | 09:16 |
| *** esberglu has joined #openstack-powervm | 10:23 | |
| *** esberglu has quit IRC | 10:27 | |
| *** chhavi has quit IRC | 11:21 | |
| *** smatzek_ has joined #openstack-powervm | 11:28 | |
| *** jwcroppe has quit IRC | 11:54 | |
| *** edmondsw has joined #openstack-powervm | 12:10 | |
| *** kylek3h has quit IRC | 12:21 | |
| *** jwcroppe has joined #openstack-powervm | 12:36 | |
| *** edmondsw has quit IRC | 12:38 | |
| *** kylek3h has joined #openstack-powervm | 12:49 | |
| *** esberglu has joined #openstack-powervm | 13:05 | |
| *** esberglu has quit IRC | 13:09 | |
| *** edmondsw has joined #openstack-powervm | 13:11 | |
| *** jwcroppe has quit IRC | 13:20 | |
| *** esberglu has joined #openstack-powervm | 13:24 | |
| *** mdrabe has joined #openstack-powervm | 13:28 | |
| *** edmondsw_ has joined #openstack-powervm | 13:40 | |
| *** edmondsw_ has quit IRC | 13:40 | |
| *** smatzek_ has quit IRC | 13:46 | |
| esberglu | edmondsw: We need to leave a time delay before removing patches from patching.conf files after they merge | 13:48 |
| esberglu | Otherwise anything that hasn't been rebased recently enough to include that patch will fail | 13:49 |
| *** dwayne has joined #openstack-powervm | 13:51 | |
| edmondsw | esberglu hmm... do we really? The CI should take the commit and apply it to the latest in the branch, not to the point in time where the commit was based | 14:02 |
| *** smatzek_ has joined #openstack-powervm | 14:05 | |
| *** mdrabe has quit IRC | 14:15 | |
| *** mdrabe has joined #openstack-powervm | 14:17 | |
| *** efried has joined #openstack-powervm | 14:26 | |
| *** jwcroppe has joined #openstack-powervm | 14:42 | |
| esberglu | Lets say you have two changes, a and b. Change a is the change being tested, change b is in the patching.conf. Change a isn't rebased recently enough to include change b. The CI just checks out the change it is testing as is, then tries to cherry-pick the patching.conf patches. So if b merges and we remove it from the patching.conf, all runs against change a will fail until it gets rebased to include change b. We can | 14:45 |
| esberglu | bypass this by leaving patch b in the patching.conf file for a while after it gets merged. It's already merged, so anything rebased recently enough will skip it. Anything not rebased recently enough will either a)succeed cherry-picking, all is well, or b) Fail during the cherry-pick. If change b can't be cherry-picked, change a will be in merge conflict so who cares if it fails there | 14:45 |
| esberglu | edmondsw: ^ | 14:45 |
| *** dwayne has quit IRC | 14:48 | |
| edmondsw | esberglu I understand what you're saying... I just think it indicates a problem with our CI | 14:52 |
| edmondsw | "The CI just checks out the change it is testing as is" <-- that seems like the problem | 14:53 |
| edmondsw | shouldn't it cherry-pick it? | 14:53 |
| esberglu | edmondsw: We would get so many more failures if we did that. Anything in merge conflict would automatically fail | 14:54 |
| edmondsw | esberglu shouldn't gerrit flag merge conflicts and it wouldn't even get to the CI? | 14:55 |
| esberglu | edmondsw: Oh yeah | 14:55 |
| edmondsw | esberglu here's where I'm coming from... forget our CI for a second and just think about jenkins. Jenkins needs to test a patch against what the latest merge is, not what the patch was based on, else it's quite possible it would pass and get merged and then break things because it wasn't tested against something that merged between when it was created and when it merged | 14:58 |
| edmondsw | doesn't our CI need to do the same? | 14:59 |
| esberglu | edmondsw: Yeah I think you're right | 14:59 |
| *** mdrabe has quit IRC | 14:59 | |
| efried | But it still needs to have all the unmerged changes it's based on. | 15:11 |
| esberglu | efried: Ahh yeah you're right | 15:11 |
| *** jwcroppe has quit IRC | 15:11 | |
| efried | So you would have to git review -d and then rebase to the tip of the branch | 15:12 |
| efried | or something. | 15:12 |
| *** jwcroppe has joined #openstack-powervm | 15:16 | |
| *** jwcroppe has quit IRC | 15:18 | |
| *** jwcroppe has joined #openstack-powervm | 15:25 | |
| *** mdrabe has joined #openstack-powervm | 15:26 | |
| efried | edmondsw Taking longer to review each patch in this log t9n removal change than to fix it up ourselves. Tempted to do that. | 15:44 |
| *** k0da has quit IRC | 15:54 | |
| *** dwayne has joined #openstack-powervm | 15:55 | |
| *** mdrabe has quit IRC | 16:07 | |
| *** mdrabe has joined #openstack-powervm | 16:07 | |
| edmondsw | efried yeah, I'd be on board with that. I was similarly temped. :) | 16:11 |
| edmondsw | tempted* | 16:11 |
| efried | edmondsw I'm working through it, but see my comments; I'm still torn whether to do all that cleanup via this change, or split it out. | 16:11 |
| edmondsw | efried your comments appear to be more about how to improve what we log than about t9n... I would argue they should be a separate patch | 16:26 |
| edmondsw | at least the ones I've read so far | 16:27 |
| efried | edmondsw Yeah, you're right procedurally. Just going to be a PITA patch-chain-wise. | 16:27 |
| edmondsw | efried not if we wait to propose that until after this merges | 16:28 |
| efried | edmondsw Yeah, but I'm already working on it. | 16:28 |
| efried | I mired myself. | 16:28 |
| edmondsw | efried but if you want to take it over and do it all in one, works for me :) | 16:28 |
| edmondsw | efried I tried really hard not to look at the messages so I didn't notice things like you did and get us into that :) | 16:29 |
| efried | yeah, totally | 16:29 |
| efried | I got sucked in bit by bit, first when I saw your "consolidate lines" comments; then when I noticed a LOG.exception that was redundantly printing the exception.... | 16:30 |
| efried | quicksand | 16:30 |
| edmondsw | sorry for contributing to that! | 16:32 |
| *** thorst has joined #openstack-powervm | 16:44 | |
| esberglu | edmondsw: efried: Any idea what could be causing these SSL Errors? | 16:52 |
| esberglu | http://184.172.12.213/85/330285/55/check/nova-out-of-tree-pvm/a60bb75/console.html | 16:52 |
| efried | I defer to edmondsw | 16:53 |
| edmondsw | esberglu looking... | 16:53 |
| esberglu | edmondsw: I haven't debugged this at all yet fyi | 16:54 |
| edmondsw | esberglu not sure off the top of my head | 16:54 |
| esberglu | edmondsw: Okay. I'll see what I find after lunch | 16:54 |
| edmondsw | esberglu is that trying to pull down a package? | 16:55 |
| edmondsw | esberglu might just have to retry and see if the network cleared up, or try a mirror | 16:55 |
| *** thorst has quit IRC | 16:57 | |
| *** thorst has joined #openstack-powervm | 16:57 | |
| edmondsw | esberglu there's this, but we wouldn't be using multiprocessing, would we? https://stackoverflow.com/questions/3724900/python-ssl-problem-with-multiprocessing | 16:58 |
| *** thorst_ has joined #openstack-powervm | 17:00 | |
| *** thorst has quit IRC | 17:02 | |
| *** thorst_ has quit IRC | 17:05 | |
| *** mdrabe has quit IRC | 17:10 | |
| *** thorst has joined #openstack-powervm | 17:20 | |
| *** jwcroppe has quit IRC | 17:20 | |
| *** thorst has quit IRC | 17:24 | |
| *** efried has quit IRC | 17:25 | |
| esberglu | edmondsw: I put up a WIP patch for the hypervisor devref in openstack-manuals. I guess that is frozen because they are migrating the docs | 17:56 |
| esberglu | http://lists.openstack.org/pipermail/openstack-dev/2017-June/118584.html | 17:56 |
| esberglu | No big deal, we wanted that doc in by the pike-3 milestone which still gives us plenty of time | 17:56 |
| esberglu | Not sure if the nova side of the doc migration is done yet | 17:57 |
| esberglu | Just wanted to let you know since I said I would have a draft up today | 17:57 |
| edmondsw | esberglu tx | 18:00 |
| edmondsw | esberglu any luck with the SSL error? | 18:00 |
| esberglu | Nope just about to dive in | 18:00 |
| *** thorst has joined #openstack-powervm | 18:23 | |
| *** mdrabe has joined #openstack-powervm | 18:27 | |
| *** thorst has quit IRC | 18:27 | |
| *** jwcroppe has joined #openstack-powervm | 18:31 | |
| *** thorst has joined #openstack-powervm | 18:35 | |
| *** thorst has quit IRC | 18:40 | |
| *** thorst has joined #openstack-powervm | 18:50 | |
| *** thorst has quit IRC | 18:54 | |
| *** thorst has joined #openstack-powervm | 19:40 | |
| *** mdrabe has quit IRC | 19:43 | |
| *** thorst has quit IRC | 19:44 | |
| *** thorst has joined #openstack-powervm | 19:46 | |
| *** thorst has quit IRC | 19:50 | |
| *** efried has joined #openstack-powervm | 19:51 | |
| *** jwcroppe has quit IRC | 20:00 | |
| efried | esberglu Is openstack net-delete the right syntax? Not openstack network delete ? | 20:10 |
| esberglu | efried: Fixed | 20:10 |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Remove log translations https://review.openstack.org/476411 | 20:13 |
| efried | edmondsw ^^ | 20:13 |
| efried | Followup change for the other cleanup stuff. | 20:13 |
| efried | That is, the above just has translation stuff; and I will be proposing a followup change for the other cleanup stuff. | 20:14 |
| *** k0da has joined #openstack-powervm | 20:23 | |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Remove log translations https://review.openstack.org/476411 | 20:24 |
| *** jwcroppe has joined #openstack-powervm | 20:28 | |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Clean up log messages https://review.openstack.org/476695 | 20:33 |
| efried | edmondsw ^^ is the followup. | 20:34 |
| efried | I probably want to do another pass to make sure I hit the LOG.debugs, since I did ^ just based on the t9n review. | 20:34 |
| *** mdrabe has joined #openstack-powervm | 20:38 | |
| *** esberglu has quit IRC | 20:43 | |
| *** smatzek_ has quit IRC | 20:45 | |
| *** jwcroppe has quit IRC | 20:50 | |
| *** thorst has joined #openstack-powervm | 21:04 | |
| *** jwcroppe has joined #openstack-powervm | 21:09 | |
| edmondsw | efried sorry, was on screen, and now I have to run... will try to look later tonight | 21:09 |
| efried | edmondsw No hurry. | 21:09 |
| *** edmondsw has quit IRC | 21:13 | |
| *** mdrabe has quit IRC | 21:13 | |
| *** mdrabe has joined #openstack-powervm | 21:13 | |
| *** edmondsw has joined #openstack-powervm | 21:16 | |
| *** edmondsw has quit IRC | 21:21 | |
| *** esberglu has joined #openstack-powervm | 21:30 | |
| *** esberglu has quit IRC | 21:35 | |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Adopt new pypowervm power_off APIs https://review.openstack.org/476274 | 21:45 |
| *** smatzek has joined #openstack-powervm | 21:45 | |
| *** thorst has quit IRC | 21:47 | |
| *** smatzek has quit IRC | 21:58 | |
| *** kylek3h has quit IRC | 21:58 | |
| *** mdrabe has quit IRC | 22:00 | |
| *** dwayne has quit IRC | 22:12 | |
| *** jwcroppe has quit IRC | 22:21 | |
| *** edmondsw has joined #openstack-powervm | 22:49 | |
| *** thorst has joined #openstack-powervm | 22:52 | |
| *** k0da has quit IRC | 23:05 | |
| *** thorst has quit IRC | 23:09 | |
| *** dwayne has joined #openstack-powervm | 23:18 | |
| *** jwcroppe has joined #openstack-powervm | 23:22 | |
| *** jwcroppe has quit IRC | 23:23 | |
| *** jwcroppe_ has joined #openstack-powervm | 23:24 | |
| *** jwcroppe_ has quit IRC | 23:25 | |
| *** jwcroppe_ has joined #openstack-powervm | 23:25 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!