| *** thorst has joined #openstack-powervm | 00:02 | |
| *** k0da has quit IRC | 00:07 | |
| *** thorst has quit IRC | 00:18 | |
| *** thorst has joined #openstack-powervm | 01:14 | |
| *** thorst has quit IRC | 01:19 | |
| *** svenkat has quit IRC | 01:36 | |
| *** edmondsw has joined #openstack-powervm | 01:41 | |
| *** edmondsw has quit IRC | 01:45 | |
| *** thorst has joined #openstack-powervm | 01:59 | |
| *** thorst has quit IRC | 02:26 | |
| *** thorst has joined #openstack-powervm | 03:26 | |
| *** thorst has quit IRC | 03:31 | |
| *** thorst has joined #openstack-powervm | 03:33 | |
| *** thorst has quit IRC | 03:35 | |
| *** thorst has joined #openstack-powervm | 04:05 | |
| *** thorst has quit IRC | 04:22 | |
| *** edmondsw has joined #openstack-powervm | 05:17 | |
| *** edmondsw has quit IRC | 05:21 | |
| *** chhavi has joined #openstack-powervm | 06:08 | |
| *** thorst has joined #openstack-powervm | 06:18 | |
| *** thorst has quit IRC | 06:23 | |
| *** chhavi has quit IRC | 06:38 | |
| *** edmondsw has joined #openstack-powervm | 07:05 | |
| *** edmondsw has quit IRC | 07:09 | |
| *** thorst has joined #openstack-powervm | 07:20 | |
| *** thorst has quit IRC | 07:24 | |
| *** k0da has joined #openstack-powervm | 07:44 | |
| *** thorst has joined #openstack-powervm | 08:20 | |
| *** chhavi has joined #openstack-powervm | 08:22 | |
| *** chhavi_ has joined #openstack-powervm | 08:32 | |
| *** chhavi has quit IRC | 08:33 | |
| *** thorst has quit IRC | 08:40 | |
| *** edmondsw has joined #openstack-powervm | 08:53 | |
| *** edmondsw has quit IRC | 08:57 | |
| *** thorst has joined #openstack-powervm | 09:37 | |
| *** thorst has quit IRC | 09:41 | |
| *** edmondsw has joined #openstack-powervm | 10:41 | |
| *** edmondsw has quit IRC | 10:45 | |
| *** svenkat has joined #openstack-powervm | 11:23 | |
| *** chhavi_ has quit IRC | 11:34 | |
| *** thorst has joined #openstack-powervm | 11:51 | |
| *** efried has quit IRC | 12:09 | |
| *** efried has joined #openstack-powervm | 12:21 | |
| *** mdrabe has joined #openstack-powervm | 12:27 | |
| *** edmondsw has joined #openstack-powervm | 12:55 | |
| *** chhavi_ has joined #openstack-powervm | 12:57 | |
| *** jwcroppe has quit IRC | 13:05 | |
| *** esberglu has joined #openstack-powervm | 13:08 | |
| *** jpasqualetto has joined #openstack-powervm | 13:29 | |
| *** jwcroppe has joined #openstack-powervm | 13:32 | |
| *** tjakobs has joined #openstack-powervm | 14:40 | |
| *** kriskend has joined #openstack-powervm | 14:42 | |
| *** kriskend has quit IRC | 14:57 | |
| esberglu | thorst: efried: edmondsw: PowerVM support matrix https://review.openstack.org/#/c/470999/ | 15:01 |
|---|---|---|
| esberglu | Would like a sanity check there. Some of the feature descriptions were iffy | 15:02 |
| efried | dig | 15:02 |
| edmondsw | tx esberglu | 15:04 |
| esberglu | np | 15:05 |
| edmondsw | efried should attach/detach vol be "partial" at this point? | 15:05 |
| efried | nope, missing. | 15:05 |
| edmondsw | efried missing? even with the SSP stuff merging? | 15:05 |
| efried | That's ephemeral. This is referring to volume. | 15:05 |
| edmondsw | oh, true | 15:06 |
| efried | I haven't gotten all the way through, but ephemeral may be implicitly supported. | 15:06 |
| edmondsw | efried line 981... I can't tell if that includes ephemeral or not | 15:12 |
| efried | getting there... | 15:12 |
| edmondsw | I love the notes for 718 :) | 15:14 |
| edmondsw | and the fact that it has wtf in the name | 15:14 |
| efried | edmondsw 981, yeah, I don't think that's what we have. I think that's, like, swift/ceph/whatever. | 15:15 |
| edmondsw | swift is object storage, not block | 15:16 |
| edmondsw | efried I was confused as to why it even mentioned swift there | 15:16 |
| edmondsw | efried I assumed it was only to elaborate on the "alternative" to this line | 15:17 |
| efried | I think our ephemeral is covered by 1078 | 15:17 |
| efried | esberglu Posted responses. Definitely want thorst to take a look, and it would be nice to get adreznec's eye on it as well. | 15:18 |
| esberglu | efried: Okay I'll wait until have a chance to take a look to update | 15:19 |
| efried | esberglu Let's not cross off stuff in the etherpad until it's merged. | 15:23 |
| efried | thorst do you know offhand if is cpu_time_ns considered necessary to claim complete support for get-guest-info? https://review.openstack.org/#/c/470999/2/doc/source/support-matrix.ini@279 | 15:26 |
| thorst | I don't think so? | 15:26 |
| efried | Cause we don't even have that OOT. | 15:26 |
| thorst | but not for certain | 15:26 |
| efried | thorst The notes list it ("cummulative CPU execution time") without any provisos or caveats, so just based on that, it would seem so. We don't even have that OOT. | 15:27 |
| efried | Not even sure if that's available to us. | 15:27 |
| efried | ...without accumulating from PCM from the birth of the instance, which I don't see us doing. | 15:27 |
| thorst | we can but we can't | 15:28 |
| thorst | if it ever live migrates, the PCM data is removed | 15:28 |
| thorst | which should be the same with libvirt... | 15:28 |
| edmondsw | do we already have resize support in? | 15:29 |
| thorst | otherwise, yeah, we may actually be able to work | 15:29 |
| thorst | edmondsw: no - I already indicated it in the review | 15:29 |
| edmondsw | thorst tx, I hadn't seen your comments yet | 15:29 |
| thorst | literally just posted | 15:29 |
| efried | I think someone's going to have to poke through the other drivers to see if/how they support that cumulative CPU thing. | 15:32 |
| efried | thorst Does PCM even give us a total-since-inception for a VM? | 15:34 |
| thorst | I thought so? | 15:34 |
| thorst | unless it wipes it out on a VM restart | 15:34 |
| thorst | but again, that'd be the same for libvirt | 15:34 |
| efried | If it doesn't, we've got no way to do this anyway, cause we wouldn't have a way to store it across compute process and/or REST server restarts. | 15:34 |
| thorst | looking at libvirt code, it seems to me they have the same problem. | 15:35 |
| efried | Guess we should at least raise a LP bug to look into this. | 15:35 |
| *** dwayne_ has joined #openstack-powervm | 15:41 | |
| efried | thorst https://bugs.launchpad.net/nova-powervm/+bug/1695924 | 15:44 |
| openstack | Launchpad bug 1695924 in nova-powervm "Cumulative CPU time not implemented" [Low,Confirmed] | 15:44 |
| *** k0da has quit IRC | 15:44 | |
| *** chhavi_ has quit IRC | 15:58 | |
| *** kriskend has joined #openstack-powervm | 16:04 | |
| *** kriskend has quit IRC | 16:20 | |
| *** kriskend has joined #openstack-powervm | 16:20 | |
| *** chhavi has joined #openstack-powervm | 16:35 | |
| *** k0da has joined #openstack-powervm | 18:01 | |
| *** chhavi has quit IRC | 18:01 | |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Performance improvements for Lifecycle events https://review.openstack.org/469982 | 18:02 |
| efried | thorst adreznec edmondsw esberglu ^^ is ready for final reviews. TIA. | 18:03 |
| *** tjakobs has quit IRC | 18:25 | |
| *** k0da has quit IRC | 18:26 | |
| *** tjakobs has joined #openstack-powervm | 18:49 | |
| efried | thorst edmondsw Soooo... get_info is used in only two places in nova, and both of them only look at the state, nothing else. | 18:54 |
| efried | In another wrinkle, the docstring on the superclass method def says we're supposed to be looking up the instance by its name, not its ID, which we've never done. | 18:55 |
| edmondsw | efried link? | 18:55 |
| efried | https://github.com/openstack/nova/blob/master/nova/virt/driver.py#L152 | 18:56 |
| efried | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1179 | 18:57 |
| efried | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6376-L6377 | 18:57 |
| *** kriskend has quit IRC | 18:57 | |
| efried | vmware tries to get by UUID and then name: https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L1115-L1116 | 18:59 |
| edmondsw | efried we even have that comment in our docstring: https://github.com/openstack/nova/blob/master/nova/virt/powervm/driver.py#L92 | 18:59 |
| efried | Well, yes, we copied & pasted it, but didn't actually do that. | 19:00 |
| edmondsw | yeah, the next line of the docstring says it's an obj, not a string | 19:00 |
| efried | libvirt does it by name | 19:00 |
| efried | Yeah, I'm not disputing that we get an Instance object - but the docstring for some reason says we're supposed to do the lookup by name, and the other drivers (so far) seem to be actually doing that. | 19:01 |
| efried | I wonder if the docstring is moldy, and there's no need for it to be by name anymore, but when it got converted, the consumers only updated to index into the obj instead of changing over to lookup by UUID | 19:02 |
| edmondsw | efried I think it must be | 19:02 |
| efried | git blame time. | 19:02 |
| edmondsw | if we weren't getting an object, this would blow up: https://github.com/openstack/nova/blob/master/nova/virt/powervm/vm.py#L95 | 19:02 |
| edmondsw | I'm guessing the docstring is from before it was an object | 19:03 |
| edmondsw | once it's an object, why would they care what from the object we use to do the lookup? | 19:03 |
| efried | yuh. Looks like mikal missed it in I54b32a5020b0dbc21ba7156ed38ed188c483086b | 19:09 |
| *** esberglu has quit IRC | 19:31 | |
| *** k0da has joined #openstack-powervm | 19:33 | |
| *** esberglu_ has joined #openstack-powervm | 19:33 | |
| efried | FYI: https://review.openstack.org/471106 | 19:40 |
| efried | thorst edmondsw esberglu_ Following up: I'm considering not implementing those other fields. If we leave it the way it is, the first time nova does anything that attempts to use them, our CI will blow up with AttributeError. This will give us the opportunity to see how they're being used, and evaluate how we should implement them. | 19:43 |
| edmondsw | efried did you ask any of the nova cores if they know of plans to use them? | 19:44 |
| efried | Like, if the usages are scattered and few, we may wish to use quick props, like the OOT driver does today. | 19:44 |
| efried | If they're used densely all together, we may wish to get the whole LPAR wrapper. | 19:44 |
| efried | If the static-ish ones are used frequently from various places, we may wish to cache them for longer than an InstanceInfo lives. | 19:45 |
| efried | Etc. | 19:45 |
| efried | edmondsw I did not. Kinda hinted at it to mriedem, but he didn't bite. | 19:45 |
| efried | From what I know about how they're doing resource providers and allocations and such, I have reason to believe they'll never care about what we report. They'll register those amounts in the db on spawn/resize and just consult those numbers to calculate how much the host has consumed. Which is probably what they're doing today. | 19:46 |
| edmondsw | efried might be good to ask, so that if there are some plans we can implement based on those and not worry about the CI breaking. | 19:47 |
| edmondsw | efried But if we can't uncover any plans, I think I'm fine with what you suggested | 19:47 |
| edmondsw | efried comments up on https://review.openstack.org/#/c/469982 | 19:56 |
| efried | thanks | 19:58 |
| *** esberglu_ has quit IRC | 20:07 | |
| *** esberglu has joined #openstack-powervm | 20:09 | |
| *** esberglu has quit IRC | 20:09 | |
| *** esberglu has joined #openstack-powervm | 20:10 | |
| *** edmondsw has quit IRC | 20:26 | |
| *** thorst has quit IRC | 20:28 | |
| *** thorst has joined #openstack-powervm | 20:28 | |
| *** thorst has quit IRC | 20:33 | |
| *** thorst has joined #openstack-powervm | 20:50 | |
| *** thorst has quit IRC | 20:54 | |
| *** dwayne_ has quit IRC | 20:58 | |
| *** svenkat has quit IRC | 21:19 | |
| *** thorst has joined #openstack-powervm | 21:23 | |
| *** edmondsw has joined #openstack-powervm | 21:28 | |
| *** edmondsw has quit IRC | 21:32 | |
| *** kriskend has joined #openstack-powervm | 21:42 | |
| *** jpasqualetto has quit IRC | 21:52 | |
| *** kriskend has quit IRC | 22:02 | |
| *** thorst has quit IRC | 22:08 | |
| *** thorst has joined #openstack-powervm | 22:09 | |
| *** thorst has quit IRC | 22:13 | |
| *** thorst has joined #openstack-powervm | 22:42 | |
| *** thorst has quit IRC | 22:42 | |
| *** tjakobs has quit IRC | 22:43 | |
| *** jwcroppe has quit IRC | 22:53 | |
| *** thorst has joined #openstack-powervm | 22:55 | |
| *** thorst has quit IRC | 22:55 | |
| *** jwcroppe has joined #openstack-powervm | 23:24 | |
| *** thorst has joined #openstack-powervm | 23:26 | |
| *** jwcroppe has quit IRC | 23:28 | |
| *** k0da has quit IRC | 23:41 | |
| *** thorst has quit IRC | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!