| *** chas has joined #openstack-powervm | 00:04 | |
| *** chas has quit IRC | 00:09 | |
| *** chas has joined #openstack-powervm | 00:20 | |
| *** chas has quit IRC | 00:25 | |
| *** thorst has joined #openstack-powervm | 00:25 | |
| *** thorst has quit IRC | 00:27 | |
| *** thorst has joined #openstack-powervm | 00:57 | |
| *** svenkat has joined #openstack-powervm | 01:14 | |
| *** thorst has quit IRC | 01:16 | |
| *** YuYangWang has joined #openstack-powervm | 01:25 | |
| *** YuYangWang has quit IRC | 01:28 | |
| *** YuYangWang has joined #openstack-powervm | 01:28 | |
| *** thorst has joined #openstack-powervm | 01:31 | |
| *** thorst has quit IRC | 01:33 | |
| *** jay1_ has joined #openstack-powervm | 01:35 | |
| *** smatzek has joined #openstack-powervm | 02:10 | |
| *** thorst has joined #openstack-powervm | 02:18 | |
| *** thorst has quit IRC | 02:19 | |
| *** chas has joined #openstack-powervm | 02:21 | |
| *** smatzek has quit IRC | 02:25 | |
| *** chas has quit IRC | 02:25 | |
| *** thorst has joined #openstack-powervm | 02:29 | |
| *** thorst has quit IRC | 02:29 | |
| *** jpasqualetto has quit IRC | 02:31 | |
| *** YuYangWang has quit IRC | 02:45 | |
| *** YuYangWang has joined #openstack-powervm | 02:45 | |
| *** svenkat has quit IRC | 02:47 | |
| *** jpasqualetto has joined #openstack-powervm | 02:48 | |
| *** thorst has joined #openstack-powervm | 03:00 | |
| *** kjw3 has quit IRC | 03:04 | |
| *** thorst has quit IRC | 03:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova-powervm master: Updated from global requirements https://review.openstack.org/464435 | 03:39 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer-powervm master: Updated from global requirements https://review.openstack.org/463156 | 03:46 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/networking-powervm master: Updated from global requirements https://review.openstack.org/464425 | 03:51 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova-powervm master: Updated from global requirements https://review.openstack.org/464435 | 03:54 |
| *** jay1_ has quit IRC | 04:03 | |
| *** jay1_ has joined #openstack-powervm | 04:15 | |
| *** thorst has joined #openstack-powervm | 04:15 | |
| *** thorst has quit IRC | 04:20 | |
| *** chas has joined #openstack-powervm | 04:22 | |
| *** chas has quit IRC | 04:27 | |
| *** shyama has joined #openstack-powervm | 05:16 | |
| *** thorst has joined #openstack-powervm | 05:16 | |
| *** thorst has quit IRC | 05:21 | |
| *** chhavi has joined #openstack-powervm | 05:22 | |
| *** jay1_ has quit IRC | 05:41 | |
| *** thorst has joined #openstack-powervm | 06:17 | |
| *** thorst has quit IRC | 06:22 | |
| *** chas has joined #openstack-powervm | 06:23 | |
| *** chas has quit IRC | 06:28 | |
| *** jay1_ has joined #openstack-powervm | 06:33 | |
| *** chas has joined #openstack-powervm | 06:45 | |
| *** thorst has joined #openstack-powervm | 07:18 | |
| *** thorst has quit IRC | 07:22 | |
| *** k0da has joined #openstack-powervm | 07:38 | |
| *** thorst has joined #openstack-powervm | 08:18 | |
| *** thorst has quit IRC | 08:23 | |
| *** thorst has joined #openstack-powervm | 09:19 | |
| *** thorst has quit IRC | 09:39 | |
| openstackgerrit | Arun Mani proposed openstack/nova-powervm master: Remove block_migration attribute from migration rollback call https://review.openstack.org/465045 | 10:31 |
| *** thorst has joined #openstack-powervm | 10:35 | |
| *** shyama has quit IRC | 10:37 | |
| *** thorst has quit IRC | 10:40 | |
| -openstackstatus- NOTICE: gerrit is being restarted to help stuck git replication issues | 10:54 | |
| *** YuYangWang has quit IRC | 11:01 | |
| *** smatzek has joined #openstack-powervm | 11:12 | |
| *** svenkat has joined #openstack-powervm | 11:40 | |
| *** thorst has joined #openstack-powervm | 11:46 | |
| *** jay1_ has quit IRC | 12:06 | |
| *** jwcroppe has quit IRC | 12:16 | |
| *** jwcroppe has joined #openstack-powervm | 12:16 | |
| *** jwcroppe has quit IRC | 12:20 | |
| openstackgerrit | Merged openstack/ceilometer-powervm master: Updated from global requirements https://review.openstack.org/463156 | 12:23 |
| openstackgerrit | Merged openstack/networking-powervm master: Updated from global requirements https://review.openstack.org/464425 | 12:24 |
| openstackgerrit | Merged openstack/nova-powervm master: Updated from global requirements https://review.openstack.org/464435 | 12:24 |
| *** chas has quit IRC | 12:29 | |
| *** dwayne has quit IRC | 12:35 | |
| *** edmondsw has joined #openstack-powervm | 12:41 | |
| *** kylek3h has quit IRC | 12:46 | |
| *** chhavi has quit IRC | 12:46 | |
| *** chhavi has joined #openstack-powervm | 12:53 | |
| *** esberglu has joined #openstack-powervm | 13:00 | |
| *** apearson has joined #openstack-powervm | 13:05 | |
| *** lan has quit IRC | 13:11 | |
| esberglu | https://review.openstack.org/#/c/461586 | 13:12 |
| *** kriskend_ has joined #openstack-powervm | 13:12 | |
| *** apearson has quit IRC | 13:13 | |
| esberglu | thorst: efried: adreznec: They are asking for core review for the above. Just a doc change | 13:14 |
| esberglu | Can I W+1 something like that? I think when I was added to the cores it was just for release stuff | 13:14 |
| *** mdrabe has joined #openstack-powervm | 13:14 | |
| thorst | I'll take a peak in a bit | 13:14 |
| adreznec | why would we go back and update an old spec? | 13:15 |
| adreznec | That looks like what he's doing | 13:15 |
| efried | That's what I was thinking | 13:15 |
| efried | I mean, meh, I don't mind, but unless the old link is broken, I'm not sure I see the point. | 13:15 |
| efried | (the old link is not broken) | 13:15 |
| adreznec | I mean I guess it probably should have been that way to begin with, but it's kind of a waste... it's not like anyone is going to reference the spec again | 13:15 |
| esberglu | I was thinking it was because liberty is EOL | 13:15 |
| * adreznec shrugs | 13:15 | |
| esberglu | But again idk what the point of the spec update is | 13:16 |
| efried | New openstack contributor, trying to rack up some changes, I guess. | 13:17 |
| adreznec | esberglu: To answer your earlier question, you should have authority to W+1 changes like that I think | 13:18 |
| adreznec | As per https://review.openstack.org/#/admin/groups/593,members | 13:19 |
| *** kylek3h has joined #openstack-powervm | 13:19 | |
| efried | Yes. And feel free to merge this one. It's harmless, if pointless. | 13:19 |
| *** apearson has joined #openstack-powervm | 13:22 | |
| openstackgerrit | Merged openstack/nova-powervm master: Specs:Neutron Networking Guide link https://review.openstack.org/461586 | 13:27 |
| *** dwayne has joined #openstack-powervm | 13:32 | |
| *** thorst is now known as thorst_afk | 13:36 | |
| *** apearson has quit IRC | 13:45 | |
| *** apearson has joined #openstack-powervm | 13:46 | |
| *** apearson has quit IRC | 13:58 | |
| *** jwcroppe has joined #openstack-powervm | 14:04 | |
| thorst_afk | sorry to loop back, but to esberglu's review q. One thing that I know was brought up at the PTG was that to many users, blueprints are the design and should be kept up to date | 14:16 |
| thorst_afk | to developers they're a point in time thing | 14:16 |
| thorst_afk | but to users...they explain the system as it is today | 14:16 |
| thorst_afk | speaking as someone who had to learn OpenStack...I can say I leaned just as heavily on the blueprints as I did the code. | 14:17 |
| thorst_afk | now just changing it from liberty to newton...that's not really a big deal...but the broader question still holds true | 14:17 |
| thorst_afk | :-) | 14:17 |
| *** apearson has joined #openstack-powervm | 14:22 | |
| *** chhavi_ has joined #openstack-powervm | 14:24 | |
| *** chhavi has quit IRC | 14:26 | |
| *** jwcroppe has quit IRC | 14:28 | |
| *** jwcroppe has joined #openstack-powervm | 14:29 | |
| *** jwcroppe_ has joined #openstack-powervm | 14:32 | |
| *** jwcroppe has quit IRC | 14:34 | |
| *** dwayne has quit IRC | 14:39 | |
| thorst_afk | efried: there? | 14:46 |
| efried | Yeah. | 14:46 |
| thorst_afk | https://review.openstack.org/#/c/465045/2/nova_powervm/virt/powervm/driver.py | 14:47 |
| thorst_afk | not sure I agree with your change request to arun | 14:47 |
| efried | What, naming the kwarg? | 14:47 |
| thorst_afk | yep | 14:48 |
| thorst_afk | sec....getting line from github | 14:48 |
| efried | Because the function we get passed in could be anything at all? | 14:48 |
| efried | Or because you think it's actually wrong in this specific case? | 14:48 |
| thorst_afk | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6458 | 14:48 |
| thorst_afk | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6466-L6467 | 14:48 |
| thorst_afk | mostly because 'that's not what libvirt does' | 14:48 |
| efried | Yeah, libvirt is not perfect, dude. | 14:49 |
| thorst_afk | totes | 14:49 |
| thorst_afk | but that's why I'm not sure | 14:49 |
| thorst_afk | so still digging....but I want to make sure recover_method comes from known places and isn't something that can just swap in or out | 14:49 |
| efried | Note that even if we get passed a function where migration_data isn't a kwarg, as long as it's called migration_data, us naming the kwarg will still work. | 14:50 |
| thorst_afk | o yeah...no you're right | 14:50 |
| thorst_afk | comes from exactly one place | 14:50 |
| efried | And I would argue that if we suddenly start getting a function that doesn't conform to that spec, we WANT to break. | 14:50 |
| thorst_afk | alright...nevermind | 14:50 |
| efried | Like we did this time. | 14:51 |
| efried | Except we want to break more explicitly | 14:51 |
| efried | Which naming the kwarg ought to help with. | 14:51 |
| thorst_afk | yeah yeah, you're right | 14:51 |
| thorst_afk | I should never doubt :-) | 14:51 |
| efried | I'm not super comfortable about it either, for the record. | 14:51 |
| thorst_afk | well, at least gets it going | 14:51 |
| efried | Passing in a method with an unknown spec is pretty brittle (and tough as hell to maintain/debug). | 14:51 |
| thorst_afk | yeah, but if all drivers are in tree...it'd be easy to fix | 14:52 |
| thorst_afk | the problem is out of tree specific really | 14:52 |
| efried | The docstring doesn't explicitly describe the method sig - just points to the method they're thinking they're going to use, probably, maybe, if you're lucky. | 14:52 |
| efried | Yes, agree. | 14:52 |
| thorst_afk | which is why we go into the tree | 14:52 |
| efried | Though even in-tree is going to be questionable whether we get swept into changes there. | 14:52 |
| efried | Cause it's not just going to break on pep8 or something. | 14:53 |
| efried | Because freakin function pointer. | 14:53 |
| thorst_afk | agree. | 14:53 |
| thorst_afk | well, we've got arun :-) | 14:53 |
| efried | I suppose we oughtta have a better unit test. | 14:53 |
| efried | One that invokes the base driver method | 14:53 |
| efried | ...but still, the thing we would want to check is the call to their method that gets passed in. | 14:54 |
| efried | Which we still don't know about until runtime. | 14:54 |
| efried | So catch-22. | 14:54 |
| efried | This is about the best we can hope to do. | 14:54 |
| thorst_afk | auto spec the method from the compute manager | 14:54 |
| thorst_afk | is that a thing? | 14:54 |
| thorst_afk | auto spec a mock of it (cause we don't really want to call it, but we want to maintain its signature) | 14:55 |
| thorst_afk | (whatever said signature is) | 14:55 |
| thorst_afk | I need to learn that auto spec magic some day | 14:55 |
| thorst_afk | back when I can code again... | 14:55 |
| efried | Yeah, that would be okay until they swap whatever method they're passing in, and leave the old one hanging around. | 14:55 |
| efried | But that would be a good idea here, you're right. | 14:56 |
| thorst_afk | yeah...but better. | 14:56 |
| openstackgerrit | Merged openstack/nova-powervm master: Remove block_migration attribute from migration rollback call https://review.openstack.org/465045 | 14:59 |
| *** k0da has quit IRC | 15:32 | |
| *** mdrabe has quit IRC | 15:36 | |
| *** tjakobs has joined #openstack-powervm | 15:36 | |
| *** mdrabe has joined #openstack-powervm | 15:44 | |
| *** arunman has joined #openstack-powervm | 15:45 | |
| *** dwayne has joined #openstack-powervm | 16:00 | |
| *** chhavi_ has quit IRC | 17:09 | |
| *** arunman has quit IRC | 17:10 | |
| *** apearson has quit IRC | 17:12 | |
| *** jwcroppe_ has quit IRC | 17:13 | |
| *** arunman has joined #openstack-powervm | 17:42 | |
| *** jwcroppe has joined #openstack-powervm | 17:43 | |
| *** arunman has quit IRC | 17:53 | |
| *** smatzek is now known as smatzek_away | 18:05 | |
| *** jwcroppe has quit IRC | 18:34 | |
| *** k0da has joined #openstack-powervm | 19:02 | |
| *** apearson has joined #openstack-powervm | 19:02 | |
| *** jwcroppe has joined #openstack-powervm | 19:06 | |
| *** k0da has quit IRC | 19:57 | |
| *** smatzek_away has quit IRC | 20:10 | |
| *** jay1_ has joined #openstack-powervm | 20:25 | |
| *** k0da has joined #openstack-powervm | 20:37 | |
| *** k0da has quit IRC | 20:53 | |
| *** jay1_ has quit IRC | 20:57 | |
| *** apearson has quit IRC | 20:58 | |
| *** thorst_afk has quit IRC | 21:03 | |
| *** jwcroppe has quit IRC | 21:03 | |
| *** kylek3h has quit IRC | 21:16 | |
| *** esberglu has quit IRC | 21:19 | |
| *** kylek3h has joined #openstack-powervm | 21:22 | |
| *** svenkat has quit IRC | 21:24 | |
| *** edmondsw has quit IRC | 21:27 | |
| *** edmondsw has joined #openstack-powervm | 21:28 | |
| *** edmondsw_ has joined #openstack-powervm | 21:31 | |
| *** edmondsw has quit IRC | 21:32 | |
| *** kriskend_ has quit IRC | 21:35 | |
| *** edmondsw_ has quit IRC | 21:36 | |
| *** mdrabe has quit IRC | 21:55 | |
| *** thorst_afk has joined #openstack-powervm | 22:00 | |
| *** kylek3h has quit IRC | 22:12 | |
| *** dwayne has quit IRC | 22:12 | |
| *** thorst_afk has quit IRC | 22:20 | |
| *** svenkat has joined #openstack-powervm | 22:27 | |
| *** svenkat has quit IRC | 22:36 | |
| *** svenkat has joined #openstack-powervm | 22:39 | |
| *** tjakobs has quit IRC | 22:47 | |
| openstackgerrit | Sridhar Venkat proposed openstack/networking-powervm master: Heal and optimize fails to retrieve vifs. https://review.openstack.org/465761 | 23:14 |
| *** dwayne has joined #openstack-powervm | 23:16 | |
| *** thorst_afk has joined #openstack-powervm | 23:20 | |
| *** svenkat has quit IRC | 23:23 | |
| *** thorst_afk has quit IRC | 23:41 | |
| *** svenkat has joined #openstack-powervm | 23:43 | |
| *** kriskend_ has joined #openstack-powervm | 23:52 | |
| *** kriskend_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!