*** thorst has quit IRC | 00:12 | |
*** chas has joined #openstack-powervm | 00:26 | |
*** chas has quit IRC | 00:31 | |
*** chas has joined #openstack-powervm | 01:02 | |
*** chas has quit IRC | 01:07 | |
*** jpasqualetto has quit IRC | 01:08 | |
*** thorst has joined #openstack-powervm | 01:25 | |
*** thorst has quit IRC | 01:32 | |
*** chas has joined #openstack-powervm | 01:39 | |
*** jpasqualetto has joined #openstack-powervm | 01:43 | |
*** chas has quit IRC | 01:43 | |
*** dwayne has joined #openstack-powervm | 01:45 | |
*** smatzek has joined #openstack-powervm | 01:49 | |
*** smatzek has quit IRC | 02:02 | |
*** thorst has joined #openstack-powervm | 02:05 | |
*** thorst has quit IRC | 02:05 | |
*** thorst has joined #openstack-powervm | 02:05 | |
*** thorst has quit IRC | 02:10 | |
*** thorst has joined #openstack-powervm | 02:36 | |
*** thorst has quit IRC | 02:50 | |
*** thorst has joined #openstack-powervm | 02:50 | |
*** thorst has quit IRC | 02:50 | |
*** chas has joined #openstack-powervm | 02:50 | |
*** chas has quit IRC | 02:56 | |
*** dwayne has quit IRC | 03:10 | |
*** thorst has joined #openstack-powervm | 03:51 | |
*** thorst has quit IRC | 03:56 | |
*** shyama has joined #openstack-powervm | 04:45 | |
*** thorst has joined #openstack-powervm | 04:52 | |
*** thorst has quit IRC | 04:57 | |
*** openstackgerrit has joined #openstack-powervm | 05:48 | |
openstackgerrit | Arun Mani proposed openstack/nova-powervm master: Deploy of VM occasionally fails with OSError https://review.openstack.org/457707 | 05:48 |
---|---|---|
*** kylek3h has quit IRC | 05:52 | |
*** kylek3h has joined #openstack-powervm | 05:52 | |
*** thorst has joined #openstack-powervm | 05:52 | |
*** kylek3h has quit IRC | 05:57 | |
*** thorst has quit IRC | 05:57 | |
openstackgerrit | Arun Mani proposed openstack/nova-powervm master: Deploy of VM occasionally fails with OSError https://review.openstack.org/457707 | 05:59 |
*** kylek3h has joined #openstack-powervm | 06:53 | |
*** thorst has joined #openstack-powervm | 06:53 | |
*** kylek3h has quit IRC | 06:58 | |
*** thorst has quit IRC | 06:58 | |
*** chas has joined #openstack-powervm | 07:08 | |
*** kylek3h has joined #openstack-powervm | 07:54 | |
*** thorst has joined #openstack-powervm | 07:54 | |
*** shyama has quit IRC | 07:57 | |
*** kylek3h has quit IRC | 07:58 | |
*** thorst has quit IRC | 08:14 | |
*** shyama has joined #openstack-powervm | 08:42 | |
*** k0da has joined #openstack-powervm | 08:49 | |
*** kylek3h has joined #openstack-powervm | 08:55 | |
*** kylek3h has quit IRC | 08:59 | |
*** kylek3h has joined #openstack-powervm | 09:56 | |
*** kylek3h has quit IRC | 10:00 | |
*** thorst has joined #openstack-powervm | 10:11 | |
*** thorst has quit IRC | 10:16 | |
*** smatzek has joined #openstack-powervm | 10:44 | |
*** kylek3h has joined #openstack-powervm | 10:56 | |
*** kylek3h has quit IRC | 11:01 | |
*** thorst has joined #openstack-powervm | 11:25 | |
*** kylek3h has joined #openstack-powervm | 11:57 | |
*** kylek3h has quit IRC | 12:02 | |
*** jpasqualetto has quit IRC | 12:09 | |
*** jpasqualetto has joined #openstack-powervm | 12:22 | |
*** shyama_ has joined #openstack-powervm | 12:28 | |
*** shyama has quit IRC | 12:29 | |
*** shyama_ is now known as shyama | 12:30 | |
*** kylek3h has joined #openstack-powervm | 12:46 | |
*** jpasqualetto has quit IRC | 12:48 | |
*** apearson has joined #openstack-powervm | 12:52 | |
*** efried has quit IRC | 12:57 | |
*** mdrabe has joined #openstack-powervm | 13:04 | |
*** jpasqualetto has joined #openstack-powervm | 13:08 | |
*** efried has joined #openstack-powervm | 13:09 | |
*** edmondsw has joined #openstack-powervm | 13:15 | |
*** esberglu has joined #openstack-powervm | 13:19 | |
*** tjakobs has joined #openstack-powervm | 13:25 | |
*** kjw3 has joined #openstack-powervm | 13:42 | |
*** dwayne has joined #openstack-powervm | 13:43 | |
*** jpasqualetto has quit IRC | 13:49 | |
*** jpasqualetto has joined #openstack-powervm | 14:01 | |
*** jpasqualetto has quit IRC | 14:18 | |
*** jpasqualetto has joined #openstack-powervm | 14:32 | |
waler | Quick question, for a P8/NovaLink Compute node, the /etc/neutron/plugins/ml2/ml2_conf.ini file has the bridge_mappings attribute. If your VIOS has two SEA (one on one phyp vSwitch, one on another vSwitch), but only one of them is to be used by deployed VMs, do you still need to specify both in the file? | 14:53 |
*** mdrabe has quit IRC | 15:02 | |
adreznec | waler: I don't think so... thorst efried? ^ | 15:03 |
efried | waler I wouldn't think so. But yeah, that's a thorst question. | 15:04 |
waler | just trying to fathom out the meaning in the docs, to see if I've done "too much" config upfront. I configured the SEA with additional VLANs (when I build the VIOS). But the networking-powervm docs say "the operator does not need to add VLANs, those will be managed by the powervm agent". | 15:05 |
waler | would certainly be useful if there were some example "known good/working" configuration files - just as something to compare against | 15:08 |
*** mdrabe has joined #openstack-powervm | 15:10 | |
efried | adreznec Our devref has examples at least, right? Can you point waler to that? (I never know where those are.) | 15:12 |
efried | waler Obviously we can't have known good/working cause your hosts/devs will be named differently from ours. | 15:12 |
waler | yeah I appreciate naming conventions will be different. but it just is proving quite an uphill task to make progress | 15:13 |
adreznec | efried: thorst (waler) the devref has examples of format, but nothing about what would be required for a specific SEA config given X VIOSes with Y SEAs | 15:14 |
adreznec | It's here FWIW http://networking-powervm.readthedocs.io/en/latest/devref/usage.html#optional-configuration | 15:14 |
waler | yep, already found that | 15:14 |
thorst | waler: what do you mean one on a PHYP vswitch and another on anoter vswitch? Is that other vswitch still a PHYP vswitch/ | 15:15 |
thorst | but basically, if you have two SEAs, you need to specify in the bridge mappings which should be used for each 'physical network' | 15:16 |
waler | yes both are PHYP vswitches, first SEA is on one of them, 2nd sea is on the other | 15:16 |
thorst | the physical network is an attribute you set on the neutron network when you create it | 15:16 |
waler | it's just a way to separate the "openstack management" traffic, from the "tennant/vm" traffic | 15:16 |
thorst | if you don't set the physical network, the system assumes the name like 'default'. | 15:16 |
thorst | but the idea is in the ml2.conf, you specify "default:vios1:ent5' | 15:16 |
thorst | (not positive on syntax) | 15:16 |
adreznec | Format: <phnet1>:<sea1>:<vio1>,<phnet2>:<sea2>:<vio2> Example: default:ent5:vios_1,speedy:ent6:vios_1 | 15:17 |
adreznec | Is the example syntax we give | 15:17 |
thorst | but that says that if a neutron network is running on the 'default' physical network, for this host that means VIOS1 running on ent5 | 15:17 |
waler | yes, I appreciate the syntax - that was fine/clear. It was just if you only needed to specify the one you wanted openstack to know/care about. as aside to any/all SEAs | 15:17 |
thorst | yeah, just the one you know and care about | 15:18 |
thorst | with that said | 15:18 |
thorst | I do think the code is limited to ETHERNET0 | 15:18 |
thorst | for phyp vswitch | 15:18 |
thorst | that's something I've had on the backlog for a while... | 15:18 |
waler | right, so leave the default phyp vswitch with the default name. let me see if that helps | 15:19 |
thorst | yeah...that could definitely be the issue | 15:19 |
waler | and what about the VLANs? will it be an issue that I've configured the SEA up-front with the additional VLANs (ie. traditionally)? | 15:19 |
thorst | shouldn't be. The networking-powervm will configure it for you. If you have additional trunks attached to the SEA, that is what it deploys to | 15:22 |
thorst | you are only guaranteed control over the primary VEA on the SEA... | 15:22 |
thorst | net - we'll periodically clean out unused VLANs on the box (that's the entire box...not just things OpenStack knows about) | 15:22 |
waler | okay thanks. Let me try renaming the phyp vswitch back to the default and update the ml2_conf.ini accordingly and we'll try again | 15:24 |
*** kjw3 has quit IRC | 15:26 | |
esberglu | efried: You got time to talk IT CI patching | 15:26 |
efried | Yah | 15:27 |
efried | So scenarios: | 15:27 |
esberglu | 1) Running against a patch that isn't IT | 15:30 |
efried | 1) A pvm in-tree patch might be a) between master and console (including console), or b) after console. | 15:30 |
efried | dammit, that's #2! | 15:30 |
esberglu | Oh I though you were asking me for them lol | 15:31 |
efried | Yeah, I paused too long - got sidelined on another channel. | 15:31 |
efried | Okay, so let's do pvm changes first. | 15:31 |
esberglu | Yep sounds good | 15:31 |
efried | 1a will break if we try to apply the whole chain individually until patches above the one being checked are rebased. | 15:32 |
efried | I think. | 15:32 |
esberglu | Yep | 15:32 |
esberglu | And it will also break if any of the patches in the list get merged | 15:32 |
esberglu | Because we are only checking back to master | 15:33 |
efried | well, hold on, I'm not talking about how we have the CI set up right now. | 15:33 |
esberglu | okay sorry | 15:33 |
efried | I'm just trying to enumerate the scenarios. | 15:33 |
efried | So we can rewrite the CI code accordingly. | 15:33 |
efried | So to make 1a work... we could (brainstorming here) `git review -d` the change in question. This will bring down the change and any deps below it. | 15:34 |
efried | Then we go through all the changes from console down, applying them one at a time; but for each, check if it's already in the chain, and skip it if so. | 15:35 |
efried | I think that'll actually work UNLESS the patch set on the change in question causes a merge conflict up the chain. | 15:35 |
efried | Whereupon we'll need to rebase the chain. | 15:35 |
efried | To make 1b work, I think we do the same process. It'll wind up skipping *all* the changes from console down, cause they're already applied. | 15:36 |
efried | This is assuming the change in question is properly based on the latest console patch set. | 15:36 |
efried | Now non-pvm changes... | 15:36 |
efried | I think we do the same thing there. git review -d will bring down that guy and any dependencies. Then we cherry-pick from console down. | 15:36 |
efried | which should all work, unless the change in question is based on a branch containing an older patch set of in-flight pvm changes, which should never happen unless it's ours. | 15:37 |
efried | So then the only quirk is that we need to do that look-back to a known merged commit that precedes our first in-tree change. | 15:38 |
efried | rather than master. | 15:38 |
efried | So that we don't have to keep updating every time we merge one. | 15:38 |
esberglu | That's the only change from what we're already doing | 15:38 |
esberglu | except we are cherry picking from #1 up instead of console down | 15:39 |
edmondsw | efried are you regretting adding me to these reviews yet? ;) | 15:39 |
esberglu | Does that make a difference? | 15:39 |
efried | edmondsw I grudgingly appreciate your thoroughness. | 15:40 |
edmondsw | :) | 15:40 |
efried | esberglu That was a misstatement on my part - we should be going up, not down. | 15:40 |
efried | esberglu So line 154 of prep_devstack.sh | 15:41 |
efried | Change origin/${ZUUL_BRANCH} to whatever hardcoded commit hash we decide on. | 15:41 |
efried | We need to think through non-master scenarios. In that case, do we even get here? | 15:42 |
efried | I guess we will once pike is cut - but burn that bridge when we cross it. | 15:42 |
esberglu | Nope nova in-tree only runs master | 15:42 |
efried | With luck, we'll be merged up to console within the next week or two, and we can get rid of this whole shenanigans. | 15:42 |
efried | The other option at this point is to bust the whitelist back to working only on what we've got merged. Then we need no patches at all. | 15:42 |
efried | And lockstep the whitelist up with every new merge. | 15:43 |
efried | Course then we don't get *real* CI for new patches. | 15:43 |
efried | So I think I prefer keeping it this way, and adding new patches to the list as they're ready. (At the same time, we can drop already-merged ones off, just for housekeeping.) | 15:43 |
esberglu | Yeah I'm okay with that | 15:44 |
esberglu | I think flipping the whitelist to a blacklist is good call for IT too | 15:45 |
esberglu | To make the lockstep smoother | 15:45 |
efried | Not sure I agree there. | 15:45 |
efried | blacklist will be huge, and just as tough to maintain, if not tougher. | 15:45 |
efried | Let's try 9569bc3552f4ae2df5f7e063ab8b09b20103e61c as that bottom commit. See if it works. | 15:49 |
esberglu | K trying it out on a manual run quick | 15:49 |
efried | Ima be afk for a while here. | 15:51 |
esberglu | Why not just use the one right before IT #1? | 15:51 |
efried | esberglu I think cherry-pick bombs (is that a cherry bomb?) if you try to base on a 'merge' commit. | 15:55 |
efried | But feel free to try it out. | 15:55 |
*** k0da has quit IRC | 15:59 | |
*** esberglu has quit IRC | 16:30 | |
*** arunman has joined #openstack-powervm | 16:41 | |
arunman | thorst, efried final changes on https://review.openstack.org/#/c/457707 is out for review. | 16:42 |
*** arunman has quit IRC | 17:08 | |
*** esberglu has joined #openstack-powervm | 17:40 | |
*** esberglu_ has joined #openstack-powervm | 17:41 | |
*** esberglu has quit IRC | 17:41 | |
*** apearson has quit IRC | 17:55 | |
*** jpasqualetto has quit IRC | 18:10 | |
*** apearson has joined #openstack-powervm | 18:10 | |
*** jpasqualetto has joined #openstack-powervm | 18:23 | |
*** chas has quit IRC | 18:26 | |
*** dwayne has quit IRC | 19:01 | |
*** apearson has quit IRC | 19:02 | |
*** k0da has joined #openstack-powervm | 19:06 | |
*** dwayne has joined #openstack-powervm | 19:14 | |
*** apearson has joined #openstack-powervm | 19:14 | |
*** k0da has quit IRC | 19:28 | |
openstackgerrit | Merged openstack/nova-powervm master: Deploy of VM occasionally fails with OSError https://review.openstack.org/457707 | 19:28 |
*** dwayne has quit IRC | 19:32 | |
*** k0da has joined #openstack-powervm | 19:34 | |
*** dwayne has joined #openstack-powervm | 19:38 | |
-openstackstatus- NOTICE: Gerrit will be offline briefly starting at 20:00 for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html | 19:42 | |
*** dwayne has quit IRC | 19:49 | |
efried | esberglu_ Howzat new commit chain logic working? | 19:52 |
esberglu_ | Works fine I put up a change for it | 19:53 |
esberglu_ | 5177 | 19:53 |
efried | esberglu_ Yah, saw that, didn't know whether you were ready to pull the trigger on it. | 19:53 |
esberglu_ | Yep. Wasn't expecting the changes to start getting merged this fast! | 19:54 |
esberglu_ | Gonna be down to no patches by the time this gets in | 19:55 |
efried | esberglu_ Knock on wood | 19:55 |
esberglu_ | It will take another mgmt redeploy for this change to get in. Might hold off until this weekend to minimize disruption | 19:57 |
*** smatzek has quit IRC | 20:02 | |
-openstackstatus- NOTICE: Gerrit is offline briefly for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html | 20:03 | |
*** ChanServ changes topic to "Gerrit is offline briefly for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html" | 20:03 | |
*** dwayne has joined #openstack-powervm | 20:11 | |
*** jpasqualetto has quit IRC | 20:12 | |
efried | edmondsw Got a suggestion for an exception that'll percolate up to a 500? | 20:14 |
efried | https://review.openstack.org/#/c/391288/56/nova/virt/powervm/vm.py@464 | 20:14 |
efried | nm, I see how to figure it out. | 20:15 |
efried | edmondsw Perhaps I should just raise a KeyError | 20:20 |
efried | There's nothing likely in exceptions.py already, and I would hate to create a new one for this should-never-happen edge case. | 20:20 |
*** chas has joined #openstack-powervm | 20:26 | |
*** chas has quit IRC | 20:31 | |
*** ChanServ changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 20:36 | |
-openstackstatus- NOTICE: Gerrit is back in service and generally usable, though remote Git replicas (git.openstack.org and github.com) will be stale for the next few hours until online reindexing completes | 20:36 | |
*** openstackgerrit has quit IRC | 20:48 | |
*** thorst has quit IRC | 21:03 | |
*** thorst has joined #openstack-powervm | 21:27 | |
edmondsw | efried any uncaught exception should result in a 500 | 21:31 |
*** smatzek has joined #openstack-powervm | 21:31 | |
efried | edmondsw KeyError seemed pretty appropriate. See what you think. | 21:31 |
*** thorst has quit IRC | 21:32 | |
*** smatzek has quit IRC | 21:32 | |
*** smatzek has joined #openstack-powervm | 21:33 | |
*** tjakobs has quit IRC | 21:41 | |
edmondsw | efried, yeah, that's fine | 21:50 |
edmondsw | 2 nits, but I wouldn't respin for either | 21:50 |
edmondsw | patch set 57 !!! | 21:50 |
*** smatzek has quit IRC | 21:55 | |
*** dwayne has quit IRC | 21:56 | |
*** k0da has quit IRC | 21:58 | |
*** mdrabe has quit IRC | 22:00 | |
*** thorst has joined #openstack-powervm | 22:22 | |
*** chas has joined #openstack-powervm | 22:28 | |
*** chas has quit IRC | 22:32 | |
*** apearson has quit IRC | 22:36 | |
*** thorst has quit IRC | 22:37 | |
*** thorst has joined #openstack-powervm | 23:08 | |
*** edmondsw has quit IRC | 23:09 | |
*** edmondsw has joined #openstack-powervm | 23:09 | |
*** thorst has quit IRC | 23:12 | |
*** edmondsw has quit IRC | 23:14 | |
*** esberglu_ has quit IRC | 23:17 | |
*** thorst has joined #openstack-powervm | 23:38 | |
*** thorst has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!