| *** svenkat has quit IRC | 00:06 | |
| *** tblakes has joined #openstack-powervm | 00:18 | |
| *** smatzek has joined #openstack-powervm | 00:18 | |
| *** smatzek has quit IRC | 00:19 | |
| *** smatzek has joined #openstack-powervm | 00:19 | |
| *** smatzek has quit IRC | 00:24 | |
| *** smatzek has joined #openstack-powervm | 00:27 | |
| *** dwayne has quit IRC | 00:45 | |
| *** k0da has quit IRC | 00:46 | |
| openstackgerrit | gengchc2 proposed openstack/ceilometer-powervm master: Remove support for py34 for ceilometer-powervm https://review.openstack.org/430619 | 00:53 |
|---|---|---|
| *** thorst has joined #openstack-powervm | 00:53 | |
| *** svenkat has joined #openstack-powervm | 01:03 | |
| *** tblakes has quit IRC | 01:35 | |
| *** thorst has quit IRC | 01:45 | |
| *** smatzek has quit IRC | 02:12 | |
| *** seroyer has joined #openstack-powervm | 02:40 | |
| *** esberglu has joined #openstack-powervm | 03:10 | |
| *** thorst has joined #openstack-powervm | 03:13 | |
| *** esberglu has quit IRC | 03:15 | |
| *** thorst has quit IRC | 03:18 | |
| *** svenkat has quit IRC | 03:31 | |
| *** seroyer has quit IRC | 03:42 | |
| *** esberglu has joined #openstack-powervm | 04:10 | |
| *** thorst has joined #openstack-powervm | 04:14 | |
| *** esberglu has quit IRC | 04:15 | |
| *** thorst has quit IRC | 04:18 | |
| *** thorst has joined #openstack-powervm | 05:15 | |
| *** thorst has quit IRC | 05:19 | |
| *** esberglu has joined #openstack-powervm | 05:55 | |
| *** esberglu has quit IRC | 05:59 | |
| *** k0da has joined #openstack-powervm | 06:10 | |
| *** k0da has quit IRC | 06:47 | |
| *** esberglu has joined #openstack-powervm | 06:55 | |
| *** esberglu has quit IRC | 07:00 | |
| *** thorst has joined #openstack-powervm | 07:16 | |
| *** thorst has quit IRC | 07:21 | |
| *** edmondsw has joined #openstack-powervm | 07:39 | |
| *** edmondsw has quit IRC | 07:44 | |
| *** esberglu has joined #openstack-powervm | 07:50 | |
| *** esberglu has quit IRC | 07:54 | |
| *** thorst has joined #openstack-powervm | 08:17 | |
| *** thorst has quit IRC | 08:22 | |
| *** k0da has joined #openstack-powervm | 08:23 | |
| *** alainfisher has joined #openstack-powervm | 09:11 | |
| *** thorst has joined #openstack-powervm | 09:18 | |
| *** thorst has quit IRC | 09:23 | |
| *** esberglu has joined #openstack-powervm | 09:35 | |
| *** esberglu has quit IRC | 09:39 | |
| *** edmondsw has joined #openstack-powervm | 10:04 | |
| *** edmondsw has quit IRC | 10:09 | |
| *** thorst has joined #openstack-powervm | 10:19 | |
| *** thorst has quit IRC | 10:23 | |
| *** openstackgerrit has quit IRC | 10:33 | |
| *** esberglu has joined #openstack-powervm | 10:34 | |
| *** esberglu has quit IRC | 10:39 | |
| *** thorst has joined #openstack-powervm | 11:20 | |
| *** thorst has quit IRC | 11:24 | |
| *** esberglu has joined #openstack-powervm | 11:30 | |
| *** esberglu has quit IRC | 11:38 | |
| *** smatzek has joined #openstack-powervm | 11:58 | |
| *** jpasqualetto has joined #openstack-powervm | 12:23 | |
| *** k0da has quit IRC | 12:28 | |
| *** seroyer has joined #openstack-powervm | 12:40 | |
| *** k0da has joined #openstack-powervm | 12:41 | |
| *** thorst has joined #openstack-powervm | 12:43 | |
| *** seroyer has quit IRC | 13:03 | |
| *** esberglu has joined #openstack-powervm | 13:12 | |
| *** esberglu has quit IRC | 13:13 | |
| *** esberglu has joined #openstack-powervm | 13:13 | |
| *** esberglu has quit IRC | 13:17 | |
| *** edmondsw has joined #openstack-powervm | 13:23 | |
| *** seroyer has joined #openstack-powervm | 13:43 | |
| *** k0da has quit IRC | 13:47 | |
| *** tblakes has joined #openstack-powervm | 13:50 | |
| *** seroyer has quit IRC | 13:57 | |
| *** apearson has joined #openstack-powervm | 13:59 | |
| *** seroyer has joined #openstack-powervm | 13:59 | |
| *** k0da has joined #openstack-powervm | 14:04 | |
| *** alainfisher_ has joined #openstack-powervm | 14:16 | |
| *** alainfisher has quit IRC | 14:18 | |
| *** alainfisher_ is now known as alainfisher | 14:18 | |
| *** svenkat has joined #openstack-powervm | 14:21 | |
| *** tjakobs has joined #openstack-powervm | 14:25 | |
| *** esberglu has joined #openstack-powervm | 14:27 | |
| *** smatzek has quit IRC | 14:29 | |
| *** esberglu_ has joined #openstack-powervm | 14:39 | |
| *** esberglu has quit IRC | 14:42 | |
| *** smatzek has joined #openstack-powervm | 14:52 | |
| efried | thorst esberglu_ can we discuss https://review.openstack.org/#/c/444031/ ? | 15:31 |
| thorst | efried: wait a tick | 15:31 |
| thorst | we always call close_vterm...even if there wasn't one open | 15:31 |
| thorst | and it never error'd out before | 15:32 |
| thorst | I think this is a scenario where we're somehow calling close_vterm after the VM is deleted. | 15:32 |
| efried | Or before it ever existed, yes. | 15:32 |
| esberglu_ | I think it never existed | 15:32 |
| thorst | so why don't we just do a quick 'partition exists' check? | 15:32 |
| efried | Timing. | 15:33 |
| thorst | ugh | 15:33 |
| efried | But... that would _probably_ work the vast majority of the time. | 15:33 |
| thorst | I mean its a dlt_lpar | 15:33 |
| efried | No, I think we have a more consistent solution. | 15:33 |
| thorst | so I don't think its a timing thing | 15:33 |
| efried | Discussion esberglu_ and I had yesterday after you left. | 15:33 |
| efried | If you look at the other methods in vm.py - e.g. power_on/_off - they've got 404 trappers in them that no-op. | 15:34 |
| efried | So we felt it would be appropriate if dlt_lpar did the same thing. | 15:34 |
| thorst | right, but you'll just fail at line 652 | 15:34 |
| efried | And then we can remove this horrible horribleness from the driver: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L681-L700 | 15:34 |
| thorst | not all of it... | 15:35 |
| thorst | maybe to 696 | 15:35 |
| esberglu_ | Yeah just to 696 | 15:35 |
| thorst | plus, I think that the dlt_lpar is the last thing to get called there | 15:35 |
| thorst | where as that 'doesn't exist' exception would probably get raised earlier in the task flow | 15:35 |
| efried | Nope. | 15:36 |
| thorst | really? | 15:36 |
| efried | Cause power-off already no-ops it. | 15:36 |
| efried | And delete & disconnect disks will still work. | 15:36 |
| thorst | vifs? | 15:36 |
| efried | I'll look, but likewise no-ops already in place. | 15:36 |
| efried | Else we wouldn't have seen this error, would we? | 15:36 |
| thorst | possibly | 15:37 |
| thorst | I guess I like the idea of checking up front (because task states should sync ops...but I know that's not always valid) | 15:37 |
| efried | Especially if the LPAR never existed, no VIFs would have been created, so UnplugVifs would no-op for that reason | 15:37 |
| thorst | so having this crappy except block kinda caught it in case any op failed. | 15:37 |
| efried | thorst Only for dlt_lpar. Which was fine if it was the actual DELETE that raised 404, because it was using the URI of that format. | 15:38 |
| efried | And in theory, that trap should catch the 404 from the CloseVTerm - but it's not, because the URI format isn't the same. | 15:38 |
| thorst | efried: unless vifs (which have CNA's that hang under)....but I see your point | 15:38 |
| efried | This comparing on the URI format is ugly, stupid, gorpy, and wrong. | 15:38 |
| thorst | o totes...agree with that | 15:38 |
| thorst | I hated that logic when it went in | 15:38 |
| efried | And the 404 check should be moved down into the vm lib method. | 15:38 |
| thorst | I just have to argue otherwise now | 15:38 |
| efried | because that matches the paradigm of the other methods in that lib. | 15:39 |
| thorst | https://review.openstack.org/#/c/444031/1/nova_powervm/virt/powervm/vm.py | 15:39 |
| thorst | line 652 | 15:39 |
| thorst | wouldn't that fail? | 15:39 |
| efried | With a 404. If we got to it. Yes. | 15:39 |
| efried | But I contend that, if the CloseVTerm 404s, we just quit right then. | 15:39 |
| thorst | heh...just to be a jackass | 15:40 |
| thorst | 'timing' | 15:40 |
| efried | Both of those ops should be wrapped in 404 handlers. | 15:40 |
| thorst | or the same 404 handler... | 15:40 |
| efried | Uh, I'm good with the timing there. | 15:40 |
| efried | The timing problem I was mentioning before was, if we check and the LPAR exists, and then it gets deleted between then and when we call dlt_lpar, we'll get the 404 anyway. | 15:40 |
| efried | But here, if we get a 404, the LPAR is already gone. | 15:41 |
| efried | The likelihood that it's still getting created somewhere... I don't think we have that code path, do we? | 15:41 |
| thorst | probably not | 15:41 |
| efried | Anyway, if you prefer, we ignore the 404 from CloseVTerm, and then try the delete anyway, and ignore its 404 as well. | 15:41 |
| efried | That would certainly be... thorough. | 15:41 |
| thorst | no no...I'm just saying, widen the scope of the try catch | 15:41 |
| thorst | have the close and dlt in the same try block | 15:42 |
| efried | That will be tricky, though. | 15:42 |
| thorst | then if either 404...well the VM is deleted | 15:42 |
| thorst | and you're good | 15:42 |
| efried | Because if we catch an exception that's _not_ 404 - like when there's no VTerm in the first place - we would still want to proceed to the delete. | 15:42 |
| efried | So I think we need two try/except blocks, unfortunately. | 15:42 |
| thorst | but what I'm saying is, close_vterm doesn't error when there is no vterm in the first place | 15:43 |
| thorst | otherwise 99% of all deploys always would have failed. | 15:43 |
| efried | Okay. But what if it errors for some other reason? | 15:43 |
| efried | Small chances, I know. Just trying to be safe. | 15:43 |
| thorst | :-) we could wrap most code in try/excepts that way | 15:43 |
| thorst | I think that's paranoia | 15:43 |
| efried | yeah... | 15:43 |
| efried | Doesn't mean they're not out to get me. | 15:44 |
| thorst | then in 6 months you'll be saying 'and we can get rid of this ugly except block' | 15:44 |
| * thorst too far? nah... | 15:44 | |
| efried | Shall I swear by the moon? | 15:44 |
| thorst | uhh? reference lost on em | 15:44 |
| thorst | *me | 15:45 |
| efried | Th'inconstant moon / That monthly changes in her circle orb | 15:45 |
| efried | Romeo & Juliet. Educate yourself <slap> | 15:45 |
| *** seroyer has quit IRC | 15:45 | |
| efried | We scared off seroyer | 15:45 |
| thorst | well now you made seroyer leave | 15:45 |
| thorst | :-) | 15:45 |
| adreznec | lol | 15:46 |
| thorst | anywhoooo, I think its a little paranoid to do that try/except. I think its fair to do it all in one. | 15:46 |
| thorst | I'll put a comment in | 15:46 |
| efried | Okay. So esberglu_ you up with the plan? | 15:46 |
| efried | Remove the horrible hack from the driver; put a try/except to catch and ignore 404 into dlt_lpar. | 15:47 |
| esberglu_ | Rip out that crappy URI exception thing and have 1 404 exception for vterm close and delete | 15:47 |
| efried | yuh | 15:47 |
| efried | thorst Is there any actual reason for us to be testing the URI? | 15:48 |
| efried | If we get a 404, that's definitive, neh? | 15:48 |
| thorst | testing the URI? | 15:48 |
| efried | String matching horribleness. | 15:48 |
| thorst | uhh, didn't you make that/ | 15:48 |
| efried | Not a chance. | 15:48 |
| efried | Let me look. | 15:48 |
| * thorst scurry to gitblame | 15:49 | |
| efried | Kyle. | 15:49 |
| efried | kylek3h | 15:49 |
| thorst | heh | 15:49 |
| efried | I'll just leave that up there, see if he deigns to answer for himself. | 15:50 |
| kylek3h | on, but presenting at the moment. will check later. | 15:50 |
| efried | I'll ask apearson if there's any reason for us to be doing that. | 15:50 |
| thorst | you know...it probably doesn't hurt to have a lpar_exists check just at the beginning of destroy itself. Half second (if that) check... | 15:50 |
| thorst | but meh | 15:50 |
| thorst | efried: thoughts? | 15:51 |
| efried | Meh indeed. | 15:51 |
| efried | Probably not worth the effort of thinking through all the implications for LPM, RR, etc. | 15:51 |
| thorst | how would it impact any of those? | 15:52 |
| thorst | I suppose it could impact the disk | 15:52 |
| efried | Pause, suspend, shelve... | 15:53 |
| thorst | fine fine | 15:53 |
| thorst | point taken | 15:53 |
| efried | Or Rebuild - doesn't that deliberately delete the disks without deleting the LPAR, or vice versa, or something? | 15:54 |
| efried | Yeah, anyway, that would be a different change set, methinks. | 15:54 |
| efried | Write up a blueprint for it. | 15:54 |
| thorst | fair enough | 15:54 |
| thorst | ugh | 15:54 |
| *** alainfisher has left #openstack-powervm | 16:00 | |
| *** seroyer has joined #openstack-powervm | 16:01 | |
| efried | esberglu_ What was that change set you said needed to be merged before our CI would start working again? | 16:07 |
| esberglu_ | https://review.openstack.org/#/c/437880/ | 16:07 |
| esberglu_ | https://review.openstack.org/#/c/443558/ | 16:07 |
| esberglu_ | There's actually 2 we need, 1 for tempest, 1 for g-r ocata | 16:07 |
| efried | oh, that was just ocata, right. | 16:09 |
| efried | thorst https://review.openstack.org/#/c/403474/ (was looking for change sets with no reviewers). See any reason not to accept this? | 16:19 |
| esberglu_ | Also the same g-r change is needs to merge for newton CI | 16:20 |
| adreznec | efried: thorst are we going to merge https://review.openstack.org/#/c/440811/ ? Or are we just going to wait on g-r until we figure out pypowervm verisoning | 16:22 |
| efried | adreznec Wait. | 16:22 |
| adreznec | My vote personally is just to merge it, but... | 16:22 |
| efried | Or merge. | 16:22 |
| efried | As you wish. | 16:22 |
| efried | (Legend) | 16:22 |
| thorst | efried: LGTM | 16:23 |
| thorst | I +2'd | 16:23 |
| efried | k, merging. | 16:23 |
| efried | adreznec I'm okay to merge it, but that's going to allow the others in, which means we'll start getting new proposals from the bot. | 16:23 |
| adreznec | One thing I did notice while looking at that now is that it's removing the discover req from test-requirements | 16:24 |
| efried | I buzzed jfoliva in slack earlier, but haven't heard back. | 16:24 |
| adreznec | We passed CI without it... any idea what that req was for offhand? | 16:24 |
| adreznec | efried: I think we're going to start getting bot proposals regardless | 16:24 |
| adreznec | Now that https://review.openstack.org/#/c/440852/ has a WF+1 | 16:25 |
| efried | That guy has a depends-on to the above, so it won't merge yet. | 16:25 |
| adreznec | Ah, I see | 16:25 |
| adreznec | Missed that | 16:25 |
| *** thorst is now known as thorst_afk | 16:27 | |
| *** k0da has quit IRC | 16:30 | |
| *** openstackgerrit has joined #openstack-powervm | 16:35 | |
| openstackgerrit | Merged openstack/nova-powervm master: Use ConfigParser instead of SafeConfigParser in Python 3 https://review.openstack.org/403474 | 16:35 |
| *** seroyer has quit IRC | 16:44 | |
| efried | thorst_afk https://review.openstack.org/#/c/404679/ ?? | 16:48 |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Except HttpError 404 dlt_lpar https://review.openstack.org/444031 | 17:00 |
| *** nbante has joined #openstack-powervm | 17:05 | |
| efried | esberglu_ IOError: [Errno 2] No such file or directory: '/opt/stack/tempest/.tox/tempest/lib/python2.7/site-packages/appdirs-1.4.0.dist-info/METADATA' Is this because of that setuptools BS? | 17:07 |
| esberglu_ | Yeah | 17:07 |
| efried | butbutbut... I have 33.1.1 on my system. | 17:08 |
| efried | And I'm not on ocata, dammit. | 17:09 |
| efried | guess it doesn't matter. | 17:09 |
| *** seroyer has joined #openstack-powervm | 17:12 | |
| efried | 'cept the corresponding change set in master has already been merged. So that must not be my problem? | 17:14 |
| efried | Perhaps I need to upgrade to 34-something-that-isn't-forbidden? | 17:15 |
| *** nbante has quit IRC | 17:50 | |
| esberglu_ | efried: Sorry I totally missed this earlier. The corresponding tempest change hasn't merged yet | 19:19 |
| esberglu_ | https://review.openstack.org/#/c/437880/ | 19:19 |
| esberglu_ | So you have the g-r change but not the tempest change | 19:20 |
| esberglu_ | efried: adreznec: thorst_afk: It was brought to my attention that when we leave 'recheck powervm' comments, we are actually kicking off rechecks for ALL CI systems | 19:21 |
| esberglu_ | Because they just check for 'recheck *' | 19:22 |
| esberglu_ | I have a proposed change up (4974) | 19:22 |
| esberglu_ | That updates or recheck trigger to 'powervm recheck' (among a few other variants) | 19:22 |
| esberglu_ | And will also trigger on 'recheck *' | 19:23 |
| esberglu_ | To bring us in line with other CIs | 19:23 |
| thorst_afk | esberglu_: I'm good with the change, just be sure to also update the OpenStack CI page with the recheck comment | 19:23 |
| esberglu_ | I updated the comment that CI posts to include the updated recheck trigger. Is that what you mean? Not sure where else we have the recheck comment format posted | 19:25 |
| esberglu_ | Unless you are talking about our PowerVM CI wiki page. (which doesn't have the old format) | 19:28 |
| thorst_afk | yeah, that was it | 19:29 |
| *** esberglu_ has quit IRC | 19:39 | |
| *** esberglu has joined #openstack-powervm | 19:39 | |
| *** esberglu has quit IRC | 19:44 | |
| *** esberglu has joined #openstack-powervm | 19:51 | |
| *** k0da has joined #openstack-powervm | 20:22 | |
| efried | esberglu I would actually rather not trigger on 'recheck *' | 20:46 |
| efried | Cause I want to be able to recheck e.g. Jenkins without spinning off a whole PowerVM CI run. | 20:46 |
| *** k0da has quit IRC | 20:51 | |
| esberglu | efried: Was talking this morning about that with the PowerKVM CI operator. From that I thought it was supposed to be supported by the community | 21:17 |
| esberglu | After further discussion that is not the case | 21:17 |
| esberglu | I will have a change up shortly | 21:17 |
| efried | thorst_afk adreznec Here's a cool thing you may not have known. | 21:18 |
| efried | tox -e pep8 -- -HEAD | 21:18 |
| efried | The -HEAD bit will restrict analysis to files you've changed. | 21:18 |
| efried | Useful for big projects like nova. | 21:18 |
| thorst_afk | that is neat | 21:18 |
| esberglu | efried: 4977 | 21:19 |
| adreznec | Nice, that's handy | 21:20 |
| efried | esberglu I posted some comments on the already-merged one you did earlier | 21:21 |
| efried | about your regex. | 21:21 |
| efried | I'll repost on this 'un. | 21:21 |
| efried | esberglu Also, I don't see how what you've done here is going to help. Maybe I'm misunderstanding the purpose of this change set... | 21:22 |
| efried | oh, I get it. Yeah, I don't like this either. | 21:23 |
| efried | adreznec Help me out here. | 21:23 |
| efried | I'm of the opinion that we shouldn't recheck PowerVM CI unless it's explicitly asked for. | 21:23 |
| efried | I want to be able to post 'recheck' and have it just redo jenkins. | 21:24 |
| efried | Is there some other comment format that will run just jenkins, but not trigger PowerVM CI? | 21:24 |
| adreznec | efried: Not that I'm aware of, and at least in Nova most other CIs seem to also recheck on a generic recheck | 21:25 |
| efried | adreznec Well, I don't like it. | 21:25 |
| efried | We should buck the system. | 21:26 |
| *** thorst_afk has quit IRC | 21:26 | |
| efried | Does our CI post that handy-dandy comment explaining how to trigger a recheck, when it fails? | 21:26 |
| efried | esberglu ^ | 21:26 |
| efried | Just knowing how relatively small our CI env is, especially since we're non-voting, I wouldn't want every recheck in the world to trigger us. | 21:27 |
| efried | I think we should only go when 'powervm' is included in the comment. | 21:27 |
| adreznec | efried: It does | 21:27 |
| efried | adreznec I'm saying we should *only* go when 'powervm' is included in the comment. | 21:28 |
| efried | Oh, you were answering the question about the explanatory comment when the CI fails. | 21:28 |
| *** k0da has joined #openstack-powervm | 21:29 | |
| efried | So yeah - convince me that it should be otherwise. | 21:29 |
| adreznec | Right | 21:30 |
| adreznec | I don't have a strong preference either way | 21:30 |
| adreznec | Just saying that's how it is with existing other CIs | 21:30 |
| adreznec | The only downside is usability | 21:30 |
| adreznec | You can't do a general "recheck" and hit everything. You'd have to go find the magic incantation for each | 21:31 |
| efried | adreznec I'm good with that, at least for right now, because a) we're non-voting, and b) we're the only ones who care about our CI. | 21:31 |
| efried | So better to reduce the load. | 21:31 |
| esberglu | efried: It's one of the requirements of 3rd party CI that you support the 'recheck' comment triggering your CI | 21:32 |
| efried | boo | 21:32 |
| efried | really | 21:32 |
| efried | fine | 21:32 |
| efried | So just tweak the regex to make me happy and we'll call it good. | 21:32 |
| esberglu | Yep already did | 21:33 |
| esberglu | Oh nvm I see what you mean | 21:33 |
| *** smatzek has quit IRC | 21:36 | |
| *** thorst_afk has joined #openstack-powervm | 21:44 | |
| efried | esberglu If we merge this, how long before it takes effect? | 21:50 |
| efried | Cause I got one I want to recheck powervm, but don't want it to retrigger the world. | 21:50 |
| esberglu | Well you can already do that with 'powervm: recheck' | 21:51 |
| efried | okay | 21:51 |
| esberglu | But I can update it in like a second after it merges | 21:51 |
| efried | So wait, what's changing here? | 21:51 |
| efried | Just that before if I said 'recheck foo' it would trigger our CI? | 21:52 |
| efried | And now even 'recheck powervm' won't do it. | 21:52 |
| efried | So it has to be 'powervm recheck' | 21:52 |
| esberglu | Yes | 21:52 |
| efried | Uhm. Did you update the text of that comment accordingly? | 21:52 |
| efried | or did it already say the right thing. | 21:52 |
| efried | ? | 21:53 |
| esberglu | Yeah I did in the 1st patch | 21:53 |
| efried | okay, I see it. | 21:53 |
| efried | esberglu Okay, merge away. | 21:54 |
| esberglu | Cool, its live | 21:55 |
| *** svenkat has quit IRC | 22:01 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Except HttpError 404 dlt_lpar https://review.openstack.org/444031 | 22:05 |
| *** tjakobs has quit IRC | 22:16 | |
| efried | thorst_afk Are you out for the count at this point? | 22:31 |
| thorst_afk | efried: yes | 22:38 |
| efried | Enjoy! | 22:38 |
| * adreznec waves goodbye to thorst_afk | 22:42 | |
| *** seroyer has quit IRC | 22:43 | |
| efried | esberglu I'd like you to port https://review.openstack.org/#/c/444031/ in-tree once the CI verifies it. | 22:44 |
| esberglu | ack | 22:45 |
| efried | esberglu I believe you'll need to stack it on top of https://review.openstack.org/#/c/438598/ | 22:45 |
| efried | Let me know if you need a hand with the git paperwork on that. | 22:45 |
| efried | Almost wonder if you should just submit it as a patch to that change set instead... | 22:46 |
| esberglu | Yeah it's not that big and isn't out of place there | 22:56 |
| *** tblakes has quit IRC | 23:12 | |
| *** apearson has quit IRC | 23:20 | |
| *** thorst_afk has quit IRC | 23:27 | |
| *** edmondsw has quit IRC | 23:35 | |
| *** edmondsw has joined #openstack-powervm | 23:37 | |
| *** edmondsw has quit IRC | 23:42 | |
| *** nbante has joined #openstack-powervm | 23:47 | |
| *** nbante has quit IRC | 23:51 | |
| *** tblakes has joined #openstack-powervm | 23:57 | |
| *** jpasqualetto has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!